From: Alessandro Boch Date: Tue, 4 Feb 2014 17:20:32 +0000 (-0800) Subject: Stats Mgr to skip equality check on flow stats X-Git-Tag: autorelease-tag-v20140601202136_82eb3f9~526^2 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=4cff32bcf72cca1bbc6f6a44eb70d7c159df38a6;hp=14ebd2da24a8122c1059e73d80aa1c50afb553dd Stats Mgr to skip equality check on flow stats - Statistics Manager runs an equality check on the list of flow statistics received from the protocol plugin with its cached ones to decide whether to update or not, in order to avoid a cluster cache update. In presence of flows on the switch, the flow updated statistics are always different becasue of the milli and nano secs duration fields they contain Change-Id: I8290457c1d0a43294e2449cb16c14d6c1e36481e Signed-off-by: Alessandro Boch --- diff --git a/opendaylight/statisticsmanager/implementation/src/main/java/org/opendaylight/controller/statisticsmanager/internal/StatisticsManager.java b/opendaylight/statisticsmanager/implementation/src/main/java/org/opendaylight/controller/statisticsmanager/internal/StatisticsManager.java index aa6e4ac383..5cd47f2f20 100644 --- a/opendaylight/statisticsmanager/implementation/src/main/java/org/opendaylight/controller/statisticsmanager/internal/StatisticsManager.java +++ b/opendaylight/statisticsmanager/implementation/src/main/java/org/opendaylight/controller/statisticsmanager/internal/StatisticsManager.java @@ -467,11 +467,8 @@ public class StatisticsManager implements IStatisticsManager, IReadServiceListen @Override public void nodeFlowStatisticsUpdated(Node node, List flowStatsList) { - List currentStat = this.flowStatistics.get(node); - // Update cache only if changed to avoid unnecessary cache sync operations - if (! flowStatsList.equals(currentStat)){ - this.flowStatistics.put(node, flowStatsList); - } + // No equality check because duration fields change constantly + this.flowStatistics.put(node, flowStatsList); } @Override