From: Robert Varga Date: Thu, 12 Feb 2015 10:18:32 +0000 (+0100) Subject: BUG-2627: JMX interfaces need to be public X-Git-Tag: release/lithium~481^2~5^2 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=63129df122d3005453e60e8d79054d10d50ee348 BUG-2627: JMX interfaces need to be public Java 8 enforces the specification's required for MXBean interfaces to be public. The mock interfaces were not public, hence were failing the test automatically. Change-Id: I4a358ff750da6c91571847b650ef0746e9da3621 Signed-off-by: Robert Varga --- diff --git a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/util/InterfacesHelperTest.java b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/util/InterfacesHelperTest.java index 34039ce8d0..5656163cbe 100644 --- a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/util/InterfacesHelperTest.java +++ b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/util/InterfacesHelperTest.java @@ -8,7 +8,6 @@ package org.opendaylight.controller.config.manager.impl.util; import static org.junit.Assert.assertEquals; - import com.google.common.collect.ImmutableSet; import com.google.common.collect.Sets; import java.util.Collections; @@ -25,37 +24,37 @@ import org.opendaylight.yangtools.concepts.Identifiable; public class InterfacesHelperTest { - interface SuperA { + public interface SuperA { } - interface SuperBMXBean { + public interface SuperBMXBean { } - interface SuperC extends SuperA, SuperBMXBean { + public interface SuperC extends SuperA, SuperBMXBean { } - class SuperClass implements SuperC { + public class SuperClass implements SuperC { } @MXBean - interface SubA { + public interface SubA { } @ServiceInterfaceAnnotation(value = "a", osgiRegistrationType = SuperA.class, namespace = "n", revision = "r", localName = "l") - interface Service extends AbstractServiceInterface{} + public interface Service extends AbstractServiceInterface{} @ServiceInterfaceAnnotation(value = "b", osgiRegistrationType = SuperC.class, namespace = "n", revision = "r", localName = "l") - interface SubService extends Service{} + public interface SubService extends Service{} - abstract class SubClass extends SuperClass implements SubA, Module { + public abstract class SubClass extends SuperClass implements SubA, Module { } - abstract class SubClassWithService implements SubService, Module { + public abstract class SubClassWithService implements SubService, Module { }