From: Robert Varga <rovarga@cisco.com>
Date: Fri, 9 May 2014 15:22:19 +0000 (+0200)
Subject: BUG-891: do not drop events silently
X-Git-Tag: autorelease-tag-v20140601202136_82eb3f9~115
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=85700d729ad014ee67e9b6dd5320dccd85957732

BUG-891: do not drop events silently

As it turns out, infrastructure silently drops things on the floor if
exceptions happen. When these exceptions occur, they hint at major
problems. Promote tham to warnings.

Change-Id: Ib4afdc7ff1a17e562211b3cfbb30735a592d0a2d
Signed-off-by: Robert Varga <rovarga@cisco.com>
---

diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/AbstractForwardedDataBroker.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/AbstractForwardedDataBroker.java
index 685a91979c..fa48416484 100644
--- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/AbstractForwardedDataBroker.java
+++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/md/sal/binding/impl/AbstractForwardedDataBroker.java
@@ -99,7 +99,7 @@ public abstract class AbstractForwardedDataBroker implements Delegator<DOMDataBr
                 Entry<InstanceIdentifier<? extends DataObject>, DataObject> binding = getCodec().toBinding(entry);
                 newMap.put(binding.getKey(), binding.getValue());
             } catch (DeserializationException e) {
-                LOG.debug("Omitting {}", entry, e);
+                LOG.warn("Failed to transform {}, omitting it", entry, e);
             }
         }
         return newMap;
@@ -113,7 +113,7 @@ public abstract class AbstractForwardedDataBroker implements Delegator<DOMDataBr
                 InstanceIdentifier<? extends DataObject> binding = getCodec().toBinding(normalizedPath);
                 hashSet.add(binding);
             } catch (DeserializationException e) {
-                LOG.debug("Omitting {}", normalizedPath, e);
+                LOG.warn("Failed to transform {}, omitting it", normalizedPath, e);
             }
         }
         return hashSet;