From: Robert Varga Date: Wed, 30 Aug 2023 15:01:08 +0000 (+0200) Subject: Fix sal-distributed-datastore checkstyle X-Git-Tag: v8.0.1~4 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=91143d29e61cd262543f0ec2d0b85461c2898b23 Fix sal-distributed-datastore checkstyle Upgraded checkstyle is flagging a few nested classes as potentially final, fix that up. Change-Id: I8f5370fb700a76f6f71ad186d78cbb50e595a8a2 Signed-off-by: Robert Varga --- diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DatastoreContextContextPropertiesUpdaterTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DatastoreContextContextPropertiesUpdaterTest.java index a113856627..244df9c0bc 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DatastoreContextContextPropertiesUpdaterTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/DatastoreContextContextPropertiesUpdaterTest.java @@ -88,8 +88,7 @@ public class DatastoreContextContextPropertiesUpdaterTest { return currProps.get(obj); } - private class DummyListenerImpl implements Listener { - + private static final class DummyListenerImpl implements Listener { private DatastoreContextFactory contextFactory; @Override diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/ActorUtilsTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/ActorUtilsTest.java index 548d476dc0..daef2143a2 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/ActorUtilsTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/utils/ActorUtilsTest.java @@ -67,10 +67,10 @@ import scala.concurrent.Future; import scala.concurrent.duration.FiniteDuration; public class ActorUtilsTest extends AbstractActorTest { - static final Logger LOG = LoggerFactory.getLogger(ActorUtilsTest.class); - private static class TestMessage { + private static final class TestMessage { + } private static final class MockShardManager extends UntypedAbstractActor {