From: Ed Warnicke Date: Wed, 15 May 2013 00:33:18 +0000 (-0500) Subject: Replace EqualsBuilder, HashBuilder, ReflectionToString X-Git-Tag: releasepom-0.1.0~458 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=92cdbf2893220b6bf9f57a5cea63d6ae30901533 Replace EqualsBuilder, HashBuilder, ReflectionToString In one file, as a test case, replace the EqualsBuilder, HashiCodeBuilder, and ReflectionToString with code generated by Eclipse. This is a very partial fix for bug 20 (more work to be done). Change-Id: I21cbcb0abf1a22f6a644884e966af953a2a9da14 Signed-off-by: Ed Warnicke --- diff --git a/opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/core/internal/PriorityMessage.java b/opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/core/internal/PriorityMessage.java index 0c66dccd01..6a2cb9e9c4 100644 --- a/opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/core/internal/PriorityMessage.java +++ b/opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/core/internal/PriorityMessage.java @@ -10,8 +10,6 @@ package org.opendaylight.controller.protocol_plugin.openflow.core.internal; import java.util.concurrent.atomic.AtomicLong; -import org.apache.commons.lang3.builder.EqualsBuilder; -import org.apache.commons.lang3.builder.HashCodeBuilder; import org.apache.commons.lang3.builder.ReflectionToStringBuilder; import org.openflow.protocol.OFMessage; @@ -55,17 +53,41 @@ class PriorityMessage { @Override public int hashCode() { - return HashCodeBuilder.reflectionHashCode(this); + final int prime = 31; + int result = 1; + result = prime * result + ((msg == null) ? 0 : msg.hashCode()); + result = prime * result + priority; + result = prime * result + (int) (seqNum ^ (seqNum >>> 32)); + result = prime * result + (syncReply ? 1231 : 1237); + return result; } @Override public boolean equals(Object obj) { - return EqualsBuilder.reflectionEquals(this, obj); + if (this == obj) + return true; + if (obj == null) + return false; + if (getClass() != obj.getClass()) + return false; + PriorityMessage other = (PriorityMessage) obj; + if (msg == null) { + if (other.msg != null) + return false; + } else if (!msg.equals(other.msg)) + return false; + if (priority != other.priority) + return false; + if (seqNum != other.seqNum) + return false; + if (syncReply != other.syncReply) + return false; + return true; } @Override public String toString() { - return "PriorityMessage[" + ReflectionToStringBuilder.toString(this) - + "]"; + return "PriorityMessage [msg=" + msg + ", priority=" + priority + + ", seqNum=" + seqNum + ", syncReply=" + syncReply + "]"; } }