From: Tom Pantelis Date: Mon, 24 Oct 2016 20:43:22 +0000 (-0400) Subject: Fix CS warnings in cds-access-api and enable enforcement X-Git-Tag: release/carbon~420 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=93fd87f9e46446be9eb8538669ebbfade205590e Fix CS warnings in cds-access-api and enable enforcement Fixed checkstyle warnings and enabled enforcement. Most of the warnings/changes were for: - variable name too short - correct ordering of @Nonnull annotations - line too long - suppressing CS RedundantModifier warning for ctors where public is needed for packaged-scoped classes that implement Externalizable - adding protected to ctors for packaged-scoped abstract classes that implement Externalizable to avoid CS RedundantModifier warning - local vars/params hiding a field - putting overloaded methods close to one another Change-Id: Ib85e15f21118f3484ccb8e945e8257ae3e3278bc Signed-off-by: Tom Pantelis --- diff --git a/opendaylight/md-sal/cds-access-api/pom.xml b/opendaylight/md-sal/cds-access-api/pom.xml index f1254e5451..c8ab1a3f98 100644 --- a/opendaylight/md-sal/cds-access-api/pom.xml +++ b/opendaylight/md-sal/cds-access-api/pom.xml @@ -59,6 +59,18 @@ + + + + org.apache.maven.plugins + maven-checkstyle-plugin + + checkstyle.violationSeverity=error + + + + + scm:git:http://git.opendaylight.org/gerrit/controller.git scm:git:ssh://git.opendaylight.org:29418/controller.git diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/ABIVersion.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/ABIVersion.java index 0e40e6e1cb..b476536b74 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/ABIVersion.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/ABIVersion.java @@ -25,7 +25,7 @@ import org.slf4j.LoggerFactory; */ @Beta public enum ABIVersion implements WritableObject { - // NOTE: enumeration values need to be sorted in asceding order of their version to keep Comparable working + // NOTE: enumeration values need to be sorted in ascending order of their version to keep Comparable working /** * Version which is older than any other version. This version exists purely for testing purposes. @@ -69,7 +69,8 @@ public enum ABIVersion implements WritableObject { * * @return Current {@link ABIVersion} */ - public static @Nonnull ABIVersion current() { + @Nonnull + public static ABIVersion current() { return BORON; } @@ -77,23 +78,24 @@ public enum ABIVersion implements WritableObject { * Return the {@link ABIVersion} corresponding to an unsigned short integer. This method is provided for callers * which provide their own recovery strategy in case of version incompatibility. * - * @param s Short integer as returned from {@link #shortValue()} + * @param value Short integer as returned from {@link #shortValue()} * @return {@link ABIVersion} * @throws FutureVersionException if the specified integer identifies a future version * @throws PastVersionException if the specified integer identifies a past version which is no longer supported */ - public static @Nonnull ABIVersion valueOf(final short s) throws FutureVersionException, PastVersionException { - switch (Short.toUnsignedInt(s)) { + @Nonnull + public static ABIVersion valueOf(final short value) throws FutureVersionException, PastVersionException { + switch (Short.toUnsignedInt(value)) { case 0: case 1: case 2: case 3: case 4: - throw new PastVersionException(s, BORON); + throw new PastVersionException(value, BORON); case 5: return BORON; default: - throw new FutureVersionException(s, BORON); + throw new FutureVersionException(value, BORON); } } @@ -110,7 +112,8 @@ public enum ABIVersion implements WritableObject { * @return An {@link ABIVersion} * @throws IOException If read fails or an unsupported version is encountered */ - public static @Nonnull ABIVersion readFrom(final @Nonnull DataInput in) throws IOException { + @Nonnull + public static ABIVersion readFrom(@Nonnull final DataInput in) throws IOException { final short s = in.readShort(); try { return valueOf(s); @@ -119,7 +122,7 @@ public enum ABIVersion implements WritableObject { } } - public static ABIVersion inexactReadFrom(final @Nonnull DataInput in) throws IOException { + public static ABIVersion inexactReadFrom(@Nonnull final DataInput in) throws IOException { final short onWire = in.readShort(); try { return ABIVersion.valueOf(onWire); diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/AbstractVersionException.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/AbstractVersionException.java index 11a27950f7..e416fc63ac 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/AbstractVersionException.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/AbstractVersionException.java @@ -42,7 +42,8 @@ public abstract class AbstractVersionException extends Exception { * * @return Closest supported {@link ABIVersion} */ - public final @Nonnull ABIVersion getClosestVersion() { + @Nonnull + public final ABIVersion getClosestVersion() { return closestVersion; } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbortLocalTransactionRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbortLocalTransactionRequest.java index 5dc630cac5..19df54628f 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbortLocalTransactionRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbortLocalTransactionRequest.java @@ -23,8 +23,8 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier public final class AbortLocalTransactionRequest extends AbstractLocalTransactionRequest { private static final long serialVersionUID = 1L; - public AbortLocalTransactionRequest(final @Nonnull TransactionIdentifier identifier, - final @Nonnull ActorRef replyTo) { + public AbortLocalTransactionRequest(@Nonnull final TransactionIdentifier identifier, + @Nonnull final ActorRef replyTo) { super(identifier, 0, replyTo); } -} \ No newline at end of file +} diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java index 0fbeecc023..f6ba2e7970 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalHistoryRequestProxy.java @@ -19,10 +19,11 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie * * @param Message type */ -abstract class AbstractLocalHistoryRequestProxy> extends AbstractRequestProxy { +abstract class AbstractLocalHistoryRequestProxy> + extends AbstractRequestProxy { private static final long serialVersionUID = 1L; - AbstractLocalHistoryRequestProxy() { + protected AbstractLocalHistoryRequestProxy() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java index bc9bb6225b..55225a7442 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractLocalTransactionRequest.java @@ -20,10 +20,12 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * * @param Message type */ -abstract class AbstractLocalTransactionRequest> extends TransactionRequest { +abstract class AbstractLocalTransactionRequest> + extends TransactionRequest { private static final long serialVersionUID = 1L; - AbstractLocalTransactionRequest(final TransactionIdentifier identifier, final long sequence, final ActorRef replyTo) { + AbstractLocalTransactionRequest(final TransactionIdentifier identifier, final long sequence, + final ActorRef replyTo) { super(identifier, sequence, replyTo); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequest.java index a8fbbcfb33..17054f78a2 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractReadTransactionRequest.java @@ -20,6 +20,7 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; * Abstract base class for {@link TransactionRequest}s accessing data as visible in the isolated context of a particular * transaction. The path of the data being accessed is returned via {@link #getPath()}. * + *

* This class is visible outside of this package for the purpose of allowing common instanceof checks * and simplified codepaths. * @@ -28,7 +29,8 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; * @param Message type */ @Beta -public abstract class AbstractReadTransactionRequest> extends TransactionRequest { +public abstract class AbstractReadTransactionRequest> + extends TransactionRequest { private static final long serialVersionUID = 1L; private final YangInstanceIdentifier path; @@ -43,7 +45,8 @@ public abstract class AbstractReadTransactionRequest Message type */ -abstract class AbstractReadTransactionRequestProxyV1> extends AbstractTransactionRequestProxy { +abstract class AbstractReadTransactionRequestProxyV1> + extends AbstractTransactionRequestProxy { private static final long serialVersionUID = 1L; private YangInstanceIdentifier path; - AbstractReadTransactionRequestProxyV1() { + protected AbstractReadTransactionRequestProxyV1() { // For Externalizable } @@ -56,5 +57,5 @@ abstract class AbstractReadTransactionRequestProxyV1 Message type */ -abstract class AbstractTransactionRequestProxy> extends AbstractRequestProxy { +abstract class AbstractTransactionRequestProxy> + extends AbstractRequestProxy { private static final long serialVersionUID = 1L; - AbstractTransactionRequestProxy() { + protected AbstractTransactionRequestProxy() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java index a0648c975d..a1284b703f 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/AbstractTransactionSuccessProxy.java @@ -19,10 +19,11 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * * @param Message type */ -abstract class AbstractTransactionSuccessProxy> extends AbstractSuccessProxy { +abstract class AbstractTransactionSuccessProxy> + extends AbstractSuccessProxy { private static final long serialVersionUID = 1L; - AbstractTransactionSuccessProxy() { + protected AbstractTransactionSuccessProxy() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequest.java index 1cb7bb1c69..a1aa3995a2 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CommitLocalTransactionRequest.java @@ -22,13 +22,14 @@ import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeModification * @author Robert Varga */ @Beta -public final class CommitLocalTransactionRequest extends AbstractLocalTransactionRequest { +public final class CommitLocalTransactionRequest + extends AbstractLocalTransactionRequest { private static final long serialVersionUID = 1L; private final DataTreeModification mod; private final boolean coordinated; - public CommitLocalTransactionRequest(final @Nonnull TransactionIdentifier identifier, - final @Nonnull ActorRef replyTo, final @Nonnull DataTreeModification mod, final boolean coordinated) { + public CommitLocalTransactionRequest(@Nonnull final TransactionIdentifier identifier, + @Nonnull final ActorRef replyTo, @Nonnull final DataTreeModification mod, final boolean coordinated) { super(identifier, 0, replyTo); this.mod = Preconditions.checkNotNull(mod); this.coordinated = coordinated; @@ -54,4 +55,4 @@ public final class CommitLocalTransactionRequest extends AbstractLocalTransactio protected ToStringHelper addToStringAttributes(final ToStringHelper toStringHelper) { return super.addToStringAttributes(toStringHelper).add("coordinated", coordinated); } -} \ No newline at end of file +} diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureProxyV1.java index 7059fe7ec1..55efb283c0 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientFailureProxyV1.java @@ -20,6 +20,9 @@ import org.opendaylight.controller.cluster.access.concepts.RequestException; * @author Robert Varga */ final class ConnectClientFailureProxyV1 extends AbstractRequestFailureProxy { + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public ConnectClientFailureProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java index 45e7ba89b6..be888e2e7e 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientRequest.java @@ -24,6 +24,7 @@ import org.opendaylight.controller.cluster.access.concepts.RequestException; * - its minimum supported ABI version * - its maximum supported ABI version * + *

* It also includes request stream sequencing information. * * @author Robert Varga @@ -62,12 +63,13 @@ public final class ConnectClientRequest extends Request externalizableProxy(final ABIVersion version) { + protected AbstractRequestProxy externalizableProxy( + final ABIVersion version) { return new ConnectClientRequestProxyV1(this); } @@ -77,7 +79,8 @@ public final class ConnectClientRequest extends Request alternates, - final @Nonnull DataTree dataTree, final int maxMessages) { + public ConnectClientSuccess(@Nonnull final ClientIdentifier target, final long sequence, + @Nonnull final ActorRef backend, @Nonnull final List alternates, + @Nonnull final DataTree dataTree, final int maxMessages) { this(target, sequence, backend, alternates, Optional.of(dataTree), maxMessages); } @@ -58,11 +58,13 @@ public final class ConnectClientSuccess extends RequestSuccess getAlternates() { + @Nonnull + public List getAlternates() { return alternates; } - public @Nonnull ActorRef getBackend() { + @Nonnull + public ActorRef getBackend() { return backend; } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java index f9fddb7276..fb44e07c10 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ConnectClientSuccessProxyV1.java @@ -34,6 +34,9 @@ final class ConnectClientSuccessProxyV1 extends AbstractSuccessProxy externalizableProxy(final ABIVersion version) { + protected AbstractLocalHistoryRequestProxy externalizableProxy( + final ABIVersion version) { return new CreateLocalHistoryRequestProxyV1(this); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequestProxyV1.java index 8a17e909f1..b61c9f5309 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/CreateLocalHistoryRequestProxyV1.java @@ -19,6 +19,9 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie final class CreateLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public CreateLocalHistoryRequestProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequest.java index 505ad37ac3..375128318c 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequest.java @@ -21,7 +21,8 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie public final class DestroyLocalHistoryRequest extends LocalHistoryRequest { private static final long serialVersionUID = 1L; - public DestroyLocalHistoryRequest(final LocalHistoryIdentifier target, final long sequence, final ActorRef replyTo) { + public DestroyLocalHistoryRequest(final LocalHistoryIdentifier target, final long sequence, + final ActorRef replyTo) { super(target, sequence, replyTo); } @@ -30,7 +31,8 @@ public final class DestroyLocalHistoryRequest extends LocalHistoryRequest externalizableProxy(final ABIVersion version) { + protected AbstractLocalHistoryRequestProxy externalizableProxy( + final ABIVersion version) { return new DestroyLocalHistoryRequestProxyV1(this); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java index 845d0193e2..0ebd69054d 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/DestroyLocalHistoryRequestProxyV1.java @@ -19,6 +19,9 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie final class DestroyLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public DestroyLocalHistoryRequestProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequest.java index f689e2552f..b8621177e2 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequest.java @@ -23,8 +23,8 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; public final class ExistsTransactionRequest extends AbstractReadTransactionRequest { private static final long serialVersionUID = 1L; - public ExistsTransactionRequest(final @Nonnull TransactionIdentifier identifier, final long sequence, - final @Nonnull ActorRef replyTo, final @Nonnull YangInstanceIdentifier path) { + public ExistsTransactionRequest(@Nonnull final TransactionIdentifier identifier, final long sequence, + @Nonnull final ActorRef replyTo, @Nonnull final YangInstanceIdentifier path) { super(identifier, sequence, replyTo, path); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java index 84f74004fe..e95da8ddde 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionRequestProxyV1.java @@ -20,6 +20,9 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; final class ExistsTransactionRequestProxyV1 extends AbstractReadTransactionRequestProxyV1 { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public ExistsTransactionRequestProxyV1() { // For Externalizable } @@ -33,4 +36,4 @@ final class ExistsTransactionRequestProxyV1 extends AbstractReadTransactionReque final ActorRef replyTo, final YangInstanceIdentifier path) { return new ExistsTransactionRequest(target, sequence, replyTo, path); } -} \ No newline at end of file +} diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java index 538c1ffa7f..24de17656d 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ExistsTransactionSuccessProxyV1.java @@ -22,6 +22,9 @@ final class ExistsTransactionSuccessProxyV1 extends AbstractTransactionSuccessPr private static final long serialVersionUID = 1L; private boolean exists; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public ExistsTransactionSuccessProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java index 0f3e533ba2..0d3a687a41 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistoryFailureProxyV1.java @@ -19,9 +19,13 @@ import org.opendaylight.controller.cluster.access.concepts.RequestException; * * @author Robert Varga */ -final class LocalHistoryFailureProxyV1 extends AbstractRequestFailureProxy { +final class LocalHistoryFailureProxyV1 extends + AbstractRequestFailureProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public LocalHistoryFailureProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java index 23858b20b2..97a7a1c8d6 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/LocalHistorySuccessProxyV1.java @@ -20,7 +20,10 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie final class LocalHistorySuccessProxyV1 extends AbstractSuccessProxy { private static final long serialVersionUID = 1L; - LocalHistorySuccessProxyV1() { + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") + public LocalHistorySuccessProxyV1() { // For Externalizable } @@ -29,7 +32,7 @@ final class LocalHistorySuccessProxyV1 extends AbstractSuccessProxy modifications; private Optional protocol; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public ModifyTransactionRequestProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PersistenceProtocol.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PersistenceProtocol.java index 36acfb2925..c1377fc102 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PersistenceProtocol.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PersistenceProtocol.java @@ -58,18 +58,18 @@ public enum PersistenceProtocol implements WritableObject { out.writeByte(byteValue()); } - abstract byte byteValue(); - public static PersistenceProtocol readFrom(final DataInput in) throws IOException { return valueOf(in.readByte()); } + abstract byte byteValue(); + static int byteValue(final PersistenceProtocol finish) { return finish == null ? 0 : finish.byteValue(); } - static PersistenceProtocol valueOf(final byte b) { - switch (b) { + static PersistenceProtocol valueOf(final byte value) { + switch (value) { case 0: return null; case 1: @@ -79,7 +79,7 @@ public enum PersistenceProtocol implements WritableObject { case 3: return THREE_PHASE; default: - throw new IllegalArgumentException("Unhandled byte value " + b); + throw new IllegalArgumentException("Unhandled byte value " + value); } } } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java index 1ac90daa21..11c344f539 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/PurgeLocalHistoryRequestProxyV1.java @@ -19,6 +19,9 @@ import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifie final class PurgeLocalHistoryRequestProxyV1 extends AbstractLocalHistoryRequestProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public PurgeLocalHistoryRequestProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequest.java index 2d754cbb18..14bb6b4a9e 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequest.java @@ -23,8 +23,8 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; public final class ReadTransactionRequest extends AbstractReadTransactionRequest { private static final long serialVersionUID = 1L; - public ReadTransactionRequest(final @Nonnull TransactionIdentifier identifier, final long sequence, - final @Nonnull ActorRef replyTo, final @Nonnull YangInstanceIdentifier path) { + public ReadTransactionRequest(@Nonnull final TransactionIdentifier identifier, final long sequence, + @Nonnull final ActorRef replyTo, @Nonnull final YangInstanceIdentifier path) { super(identifier, sequence, replyTo, path); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java index 0c60b2b015..a438a8b4a4 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionRequestProxyV1.java @@ -20,6 +20,9 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; final class ReadTransactionRequestProxyV1 extends AbstractReadTransactionRequestProxyV1 { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public ReadTransactionRequestProxyV1() { // For Externalizable } @@ -33,4 +36,4 @@ final class ReadTransactionRequestProxyV1 extends AbstractReadTransactionRequest final ActorRef replyTo, final YangInstanceIdentifier path) { return new ReadTransactionRequest(target, sequence, replyTo, path); } -} \ No newline at end of file +} diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java index f3d8395d6f..733ce71d6c 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java @@ -15,7 +15,8 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; /** - * Successful reply to an {@link ReadTransactionRequest}. It indicates presence of requested data via {@link #getData()}. + * Successful reply to an {@link ReadTransactionRequest}. It indicates presence of requested data via + * {@link #getData()}. * * @author Robert Varga */ diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java index ed45695d10..3637aa8ac9 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccessProxyV1.java @@ -26,6 +26,9 @@ final class ReadTransactionSuccessProxyV1 extends AbstractTransactionSuccessProx private static final long serialVersionUID = 1L; private Optional> data; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public ReadTransactionSuccessProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java index 0743e3e24e..3e67dfe83b 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortRequestProxyV1.java @@ -19,6 +19,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier final class TransactionAbortRequestProxyV1 extends AbstractTransactionRequestProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionAbortRequestProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java index 3cf513ae3c..c9de3b9703 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionAbortSuccessProxyV1.java @@ -18,6 +18,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier final class TransactionAbortSuccessProxyV1 extends AbstractTransactionSuccessProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionAbortSuccessProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java index 4e689b2ace..e6149bd5da 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccess.java @@ -24,7 +24,8 @@ public final class TransactionCanCommitSuccess extends TransactionSuccess externalizableProxy(final ABIVersion version) { + protected AbstractTransactionSuccessProxy externalizableProxy( + final ABIVersion version) { return new TransactionCanCommitSuccessProxyV1(this); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java index b645d68885..b41ec2998f 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCanCommitSuccessProxyV1.java @@ -21,6 +21,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier final class TransactionCanCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionCanCommitSuccessProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java index aaf07c26e1..f23da7bac2 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionCommitSuccessProxyV1.java @@ -18,6 +18,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier final class TransactionCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionCommitSuccessProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java index ce9ca9b004..fcb63fd0f5 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionDoCommitRequestProxyV1.java @@ -19,6 +19,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier final class TransactionDoCommitRequestProxyV1 extends AbstractTransactionRequestProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionDoCommitRequestProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java index 15cf09c5b7..d3b1dd7cf7 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionFailureProxyV1.java @@ -22,6 +22,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier final class TransactionFailureProxyV1 extends AbstractRequestFailureProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionFailureProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequest.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequest.java index d79dbea642..226557d124 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequest.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequest.java @@ -21,7 +21,8 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier public final class TransactionPreCommitRequest extends TransactionRequest { private static final long serialVersionUID = 1L; - public TransactionPreCommitRequest(final TransactionIdentifier target, final long sequence, final ActorRef replyTo) { + public TransactionPreCommitRequest(final TransactionIdentifier target, final long sequence, + final ActorRef replyTo) { super(target, sequence, replyTo); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java index 649db56a57..bf044e1a15 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitRequestProxyV1.java @@ -11,14 +11,17 @@ import akka.actor.ActorRef; import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier; /** - * Externalizable proxy for use with {@link TransactionPreCommitRequest}. It implements the initial (Boron) serialization - * format. + * Externalizable proxy for use with {@link TransactionPreCommitRequest}. It implements the initial (Boron) + * serialization format. * * @author Robert Varga */ final class TransactionPreCommitRequestProxyV1 extends AbstractTransactionRequestProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionPreCommitRequestProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java index 1cf00e668f..716f37804c 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccess.java @@ -23,7 +23,8 @@ public final class TransactionPreCommitSuccess extends TransactionSuccess externalizableProxy(final ABIVersion version) { + protected AbstractTransactionSuccessProxy externalizableProxy( + final ABIVersion version) { return new TransactionPreCommitSuccessProxyV1(this); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java index 387a60c8e9..17b1b8da0d 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionPreCommitSuccessProxyV1.java @@ -18,6 +18,9 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier final class TransactionPreCommitSuccessProxyV1 extends AbstractTransactionSuccessProxy { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public TransactionPreCommitSuccessProxyV1() { // For Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionSuccess.java index 77a6b56d1e..e15c2dc7c4 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionSuccess.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/TransactionSuccess.java @@ -21,7 +21,8 @@ import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier * @param Message type */ @Beta -public abstract class TransactionSuccess> extends RequestSuccess { +public abstract class TransactionSuccess> + extends RequestSuccess { private static final long serialVersionUID = 1L; TransactionSuccess(final TransactionIdentifier identifier, final long sequence) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java index 69fc29305c..326a514abc 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractEnvelopeProxy.java @@ -20,7 +20,7 @@ abstract class AbstractEnvelopeProxy> implements Externa private long sessionId; private long txSequence; - public AbstractEnvelopeProxy() { + protected AbstractEnvelopeProxy() { // for Externalizable } @@ -45,9 +45,9 @@ abstract class AbstractEnvelopeProxy> implements Externa message = (T) in.readObject(); } - abstract Envelope createEnvelope(T message, long sessionId, long txSequence); + abstract Envelope createEnvelope(T wrappedNessage, long envSessionId, long envTxSequence); final Object readResolve() { return createEnvelope(message, sessionId, txSequence); } -} \ No newline at end of file +} diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java index 48ad0d39bb..8a59168136 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractMessageProxy.java @@ -34,7 +34,7 @@ abstract class AbstractMessageProxy> extends AbstractEnvelopeProxy { private static final long serialVersionUID = 1L; - public AbstractResponseEnvelopeProxy() { + protected AbstractResponseEnvelopeProxy() { // for Externalizable } @@ -20,4 +20,4 @@ abstract class AbstractResponseEnvelopeProxy> extends A @Override abstract ResponseEnvelope createEnvelope(T message, long sequence, long retry); -} \ No newline at end of file +} diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java index 351a6f882b..b72b2b9f7c 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/AbstractResponseProxy.java @@ -22,11 +22,11 @@ abstract class AbstractResponseProxy { private static final long serialVersionUID = 1L; - AbstractResponseProxy() { + protected AbstractResponseProxy() { // for Externalizable } - AbstractResponseProxy(final @Nonnull C response) { + AbstractResponseProxy(@Nonnull final C response) { super(response); } @@ -35,5 +35,6 @@ abstract class AbstractResponseProxy> implements Immutable, Se } /** - * Get the enclosed message + * Get the enclosed message. * * @return enclose message */ diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java index 892b44d33b..b9ba98e1c5 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FailureEnvelopeProxy.java @@ -10,6 +10,9 @@ package org.opendaylight.controller.cluster.access.concepts; final class FailureEnvelopeProxy extends AbstractResponseEnvelopeProxy> { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to be + // able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public FailureEnvelopeProxy() { // for Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java index fc728130e6..60e40e9e16 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendIdentifier.java @@ -30,6 +30,9 @@ public final class FrontendIdentifier implements WritableIdentifier { private MemberName memberName; private FrontendType clientType; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public Proxy() { // Needed for Externalizable } @@ -95,15 +98,15 @@ public final class FrontendIdentifier implements WritableIdentifier { } @Override - public boolean equals(final Object o) { - if (this == o) { + public boolean equals(final Object obj) { + if (this == obj) { return true; } - if (!(o instanceof FrontendIdentifier)) { + if (!(obj instanceof FrontendIdentifier)) { return false; } - final FrontendIdentifier other = (FrontendIdentifier) o; + final FrontendIdentifier other = (FrontendIdentifier) obj; return memberName.equals(other.memberName) && clientType.equals(other.clientType); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java index 52b6ccc6c8..b58e240874 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/FrontendType.java @@ -37,6 +37,9 @@ public final class FrontendType implements Comparable, WritableIde private static final long serialVersionUID = 1L; private byte[] serialized; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public Proxy() { // For Externalizable } @@ -85,6 +88,7 @@ public final class FrontendType implements Comparable, WritableIde * - US-ASCII letters and numbers * - special characters: -_.*+:=,!~'; * + * @param name the input name * @return A {@link FrontendType} instance * @throws IllegalArgumentException if the string is null, empty or contains invalid characters */ @@ -103,9 +107,9 @@ public final class FrontendType implements Comparable, WritableIde @Override public void writeTo(final DataOutput out) throws IOException { - final byte[] serialized = getSerialized(); - out.writeInt(serialized.length); - out.write(serialized); + final byte[] local = getSerialized(); + out.writeInt(local.length); + out.write(local); } public String getName() { @@ -118,13 +122,13 @@ public final class FrontendType implements Comparable, WritableIde } @Override - public boolean equals(final Object o) { - return this == o || (o instanceof FrontendType && name.equals(((FrontendType)o).name)); + public boolean equals(final Object obj) { + return this == obj || obj instanceof FrontendType && name.equals(((FrontendType)obj).name); } @Override - public int compareTo(final FrontendType o) { - return this == o ? 0 : name.compareTo(o.name); + public int compareTo(final FrontendType obj) { + return this == obj ? 0 : name.compareTo(obj.name); } @Override diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java index a6e81f13aa..29e3df74f5 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/LocalHistoryIdentifier.java @@ -42,6 +42,9 @@ public final class LocalHistoryIdentifier implements WritableIdentifier { private long historyId; private long cookie; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public Proxy() { // For Externalizable } @@ -122,15 +125,15 @@ public final class LocalHistoryIdentifier implements WritableIdentifier { } @Override - public boolean equals(final Object o) { - if (this == o) { + public boolean equals(final Object obj) { + if (this == obj) { return true; } - if (!(o instanceof LocalHistoryIdentifier)) { + if (!(obj instanceof LocalHistoryIdentifier)) { return false; } - final LocalHistoryIdentifier other = (LocalHistoryIdentifier) o; + final LocalHistoryIdentifier other = (LocalHistoryIdentifier) obj; return historyId == other.historyId && cookie == other.cookie && clientId.equals(other.clientId); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java index 2b1a642029..55737c47b7 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/MemberName.java @@ -32,6 +32,9 @@ public final class MemberName implements Comparable, WritableIdentif private static final long serialVersionUID = 1L; private byte[] serialized; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public Proxy() { // For Externalizable } @@ -85,9 +88,9 @@ public final class MemberName implements Comparable, WritableIdentif @Override public void writeTo(final DataOutput out) throws IOException { - final byte[] serialized = getSerialized(); - out.writeInt(serialized.length); - out.write(serialized); + final byte[] local = getSerialized(); + out.writeInt(local.length); + out.write(local); } public String getName() { @@ -100,13 +103,13 @@ public final class MemberName implements Comparable, WritableIdentif } @Override - public boolean equals(final Object o) { - return this == o || (o instanceof MemberName && name.equals(((MemberName)o).name)); + public boolean equals(final Object obj) { + return this == obj || obj instanceof MemberName && name.equals(((MemberName)obj).name); } @Override - public int compareTo(final MemberName o) { - return this == o ? 0 : name.compareTo(o.name); + public int compareTo(final MemberName obj) { + return this == obj ? 0 : name.compareTo(obj.name); } @Override diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java index 30e631eed7..8788c0df98 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Message.java @@ -23,21 +23,26 @@ import org.opendaylight.yangtools.concepts.WritableIdentifier; * An abstract concept of a Message. This class cannot be instantiated directly, use its specializations {@link Request} * and {@link Response}. * + *

* Messages have a target and a sequence number. Sequence numbers are expected to be assigned monotonically on a * per-target basis, hence two targets can observe the same sequence number. * + *

* This class includes explicit versioning for forward- and backward- compatibility of serialization format. This is * achieved by using the serialization proxy pattern. Subclasses are in complete control of what proxy is used to * serialize a particular object on the wire. This class can serve as an explicit version marker, hence no further * action is necessary in the deserialization path. * + *

* For the serialization path an explicit call from the user is required to select the appropriate serialization * version. This is done via {@link #toVersion(ABIVersion)} method, which should return a copy of this object with * the requested ABI version recorded and should return the appropriate serialization proxy. * + *

* This workflow allows least disturbance across ABI versions, as all messages not affected by a ABI version bump * will remain working with the same serialization format for the new ABI version. * + *

* Note that this class specifies the {@link Immutable} contract, which means that all subclasses must follow this API * contract. * @@ -74,7 +79,8 @@ public abstract class Message externalizableProxy(@Nonnull ABIVersion version); + @Nonnull + abstract AbstractMessageProxy externalizableProxy(@Nonnull ABIVersion reqVersion); protected final Object writeReplace() { return externalizableProxy(version); diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java index 2f5cb4f4be..75fbadd00a 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Request.java @@ -29,12 +29,12 @@ public abstract class Request toRequestFailure(final @Nonnull RequestException cause); + @Nonnull + public abstract RequestFailure toRequestFailure(@Nonnull final RequestException cause); @Override protected ToStringHelper addToStringAttributes(final ToStringHelper toStringHelper) { diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java index 8ab450d8d3..66e7eaa0a2 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestEnvelopeProxy.java @@ -10,6 +10,9 @@ package org.opendaylight.controller.cluster.access.concepts; final class RequestEnvelopeProxy extends AbstractEnvelopeProxy> { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public RequestEnvelopeProxy() { // for Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestException.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestException.java index ec51912841..f3b3d73421 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestException.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestException.java @@ -20,11 +20,11 @@ import javax.annotation.Nonnull; public abstract class RequestException extends Exception { private static final long serialVersionUID = 1L; - protected RequestException(final @Nonnull String message) { + protected RequestException(@Nonnull final String message) { super(Preconditions.checkNotNull(message)); } - protected RequestException(final @Nonnull String message, final @Nonnull Exception cause) { + protected RequestException(@Nonnull final String message, @Nonnull final Exception cause) { super(Preconditions.checkNotNull(message), Preconditions.checkNotNull(cause)); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestFailure.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestFailure.java index ecd2ff4955..13eb4bc618 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestFailure.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/RequestFailure.java @@ -23,16 +23,17 @@ import org.opendaylight.yangtools.concepts.WritableIdentifier; * @param Message class */ @Beta -public abstract class RequestFailure> extends Response { +public abstract class RequestFailure> + extends Response { private static final long serialVersionUID = 1L; private final RequestException cause; - protected RequestFailure(final @Nonnull C failure, final @Nonnull ABIVersion version) { + protected RequestFailure(@Nonnull final C failure, @Nonnull final ABIVersion version) { super(failure, version); this.cause = Preconditions.checkNotNull(failure.getCause()); } - protected RequestFailure(final @Nonnull T target, final long sequence, final @Nonnull RequestException cause) { + protected RequestFailure(@Nonnull final T target, final long sequence, @Nonnull final RequestException cause) { super(target, sequence); this.cause = Preconditions.checkNotNull(cause); } @@ -42,7 +43,8 @@ public abstract class RequestFailure { private static final long serialVersionUID = 1L; - protected RequestSuccess(final @Nonnull C success, final @Nonnull ABIVersion version) { + protected RequestSuccess(@Nonnull final C success, @Nonnull final ABIVersion version) { super(success, version); } - protected RequestSuccess(final @Nonnull T target, final long sequence) { + protected RequestSuccess(@Nonnull final T target, final long sequence) { super(target, sequence); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Response.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Response.java index c520da19b7..cc6188bd84 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Response.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/Response.java @@ -26,11 +26,11 @@ import org.opendaylight.yangtools.concepts.WritableIdentifier; public abstract class Response> extends Message { private static final long serialVersionUID = 1L; - Response(final @Nonnull T target, final long sequence) { + Response(@Nonnull final T target, final long sequence) { super(target, sequence); } - Response(final @Nonnull C response, final @Nonnull ABIVersion version) { + Response(@Nonnull final C response, @Nonnull final ABIVersion version) { super(response, version); } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java index 50df24771f..b9d6183f9e 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/SuccessEnvelopeProxy.java @@ -10,6 +10,9 @@ package org.opendaylight.controller.cluster.access.concepts; final class SuccessEnvelopeProxy extends AbstractResponseEnvelopeProxy> { private static final long serialVersionUID = 1L; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public SuccessEnvelopeProxy() { // for Externalizable } diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java index dac3314628..202b5ce6dc 100644 --- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java +++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/concepts/TransactionIdentifier.java @@ -31,6 +31,9 @@ public final class TransactionIdentifier implements WritableIdentifier { private LocalHistoryIdentifier historyId; private long transactionId; + // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to + // be able to create instances via reflection. + @SuppressWarnings("checkstyle:RedundantModifier") public Proxy() { // For Externalizable } @@ -62,7 +65,7 @@ public final class TransactionIdentifier implements WritableIdentifier { private final long transactionId; private transient String shortString; - public TransactionIdentifier(final @Nonnull LocalHistoryIdentifier historyId, final long transactionId) { + public TransactionIdentifier(@Nonnull final LocalHistoryIdentifier historyId, final long transactionId) { this.historyId = Preconditions.checkNotNull(historyId); this.transactionId = transactionId; } @@ -92,24 +95,24 @@ public final class TransactionIdentifier implements WritableIdentifier { } @Override - public boolean equals(final Object o) { - if (this == o) { + public boolean equals(final Object obj) { + if (this == obj) { return true; } - if (!(o instanceof TransactionIdentifier)) { + if (!(obj instanceof TransactionIdentifier)) { return false; } - final TransactionIdentifier other = (TransactionIdentifier) o; + final TransactionIdentifier other = (TransactionIdentifier) obj; return transactionId == other.transactionId && historyId.equals(other.historyId); } public String toShortString() { - if(shortString == null) { + if (shortString == null) { String histStr = historyId.getHistoryId() == 0 ? "" : "-chn-" + historyId.getHistoryId(); - shortString = historyId.getClientId().getFrontendId().getMemberName().getName() + "-" + - historyId.getClientId().getFrontendId().getClientType().getName() + "-fe-" + - historyId.getClientId().getGeneration() + histStr + "-txn-" + transactionId; + shortString = historyId.getClientId().getFrontendId().getMemberName().getName() + "-" + + historyId.getClientId().getFrontendId().getClientType().getName() + "-fe-" + + historyId.getClientId().getGeneration() + histStr + "-txn-" + transactionId; } return shortString; diff --git a/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/ABIVersionTest.java b/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/ABIVersionTest.java index 6866136496..f9e9c0c954 100644 --- a/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/ABIVersionTest.java +++ b/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/ABIVersionTest.java @@ -12,6 +12,7 @@ import static org.junit.Assert.assertTrue; import static org.opendaylight.controller.cluster.access.ABIVersion.BORON; import static org.opendaylight.controller.cluster.access.ABIVersion.TEST_FUTURE_VERSION; import static org.opendaylight.controller.cluster.access.ABIVersion.TEST_PAST_VERSION; + import com.google.common.io.ByteArrayDataOutput; import com.google.common.io.ByteStreams; import java.io.IOException; @@ -32,12 +33,12 @@ public class ABIVersionTest { assertEquals(BORON, ABIVersion.readFrom(ByteStreams.newDataInput(writeVersion(BORON)))); } - @Test(expected=PastVersionException.class) + @Test(expected = PastVersionException.class) public void testInvalidPastVersion() throws Exception { ABIVersion.valueOf(TEST_PAST_VERSION.shortValue()); } - @Test(expected=FutureVersionException.class) + @Test(expected = FutureVersionException.class) public void testInvalidFutureVersion() throws Exception { ABIVersion.valueOf(TEST_FUTURE_VERSION.shortValue()); } @@ -48,7 +49,7 @@ public class ABIVersionTest { return bado.toByteArray(); } - @Test(expected=IOException.class) + @Test(expected = IOException.class) public void testBadRead() throws IOException { ABIVersion.readFrom(ByteStreams.newDataInput(writeVersion(TEST_PAST_VERSION))); } diff --git a/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/AbstractIdentifierTest.java b/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/AbstractIdentifierTest.java index 34ce489793..080e1e46b4 100644 --- a/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/AbstractIdentifierTest.java +++ b/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/AbstractIdentifierTest.java @@ -10,6 +10,7 @@ package org.opendaylight.controller.cluster.access.concepts; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; + import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.IOException; @@ -20,7 +21,9 @@ import org.opendaylight.yangtools.concepts.Identifier; public abstract class AbstractIdentifierTest { abstract T object(); + abstract T differentObject(); + abstract T equalObject(); @Test @@ -38,10 +41,10 @@ public abstract class AbstractIdentifierTest { } @SuppressWarnings("unchecked") - private static T copy(T o) throws IOException, ClassNotFoundException { + private static T copy(T obj) throws IOException, ClassNotFoundException { final ByteArrayOutputStream bos = new ByteArrayOutputStream(); try (ObjectOutputStream oos = new ObjectOutputStream(bos)) { - oos.writeObject(o); + oos.writeObject(obj); } try (ObjectInputStream ois = new ObjectInputStream(new ByteArrayInputStream(bos.toByteArray()))) { diff --git a/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/MemberNameTest.java b/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/MemberNameTest.java index e5031fc15a..2c377e5efd 100644 --- a/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/MemberNameTest.java +++ b/opendaylight/md-sal/cds-access-api/src/test/java/org/opendaylight/controller/cluster/access/concepts/MemberNameTest.java @@ -9,6 +9,7 @@ package org.opendaylight.controller.cluster.access.concepts; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; + import org.junit.Test; public class MemberNameTest extends AbstractIdentifierTest {