From: Tony Tkacik Date: Fri, 24 Jan 2014 18:30:53 +0000 (+0100) Subject: Bug 319: Fixed two-phase commit verification of data. X-Git-Tag: jenkins-controller-bulk-release-prepare-only-2-10~11 X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=acb48de64c98d7a4cc2c523074b7f900357f61f0 Bug 319: Fixed two-phase commit verification of data. Change-Id: I0183b2543d8842e485ad118badd14055035a44b0 Signed-off-by: Tony Tkacik --- diff --git a/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java b/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java index 56fbb9a525..ee0b356b00 100644 --- a/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java +++ b/opendaylight/md-sal/sal-binding-dom-it/src/test/java/org/opendaylight/controller/sal/binding/test/bugfix/DOMCodecBug01Test.java @@ -224,7 +224,7 @@ public class DOMCodecBug01Test extends AbstractDataServiceTest { @Override public Void call() { try { - //startSyncObject.wait(); + //startSyncObj ect.wait(); //Thread.sleep(500); createFlow(); createFlow2(); diff --git a/opendaylight/md-sal/sal-dom-broker/pom.xml b/opendaylight/md-sal/sal-dom-broker/pom.xml index eba096ca5d..57ad058c4e 100644 --- a/opendaylight/md-sal/sal-dom-broker/pom.xml +++ b/opendaylight/md-sal/sal-dom-broker/pom.xml @@ -126,6 +126,7 @@ org.opendaylight.controller.sal.dom.broker, org.opendaylight.controller.sal.dom.broker.impl, org.opendaylight.controller.sal.dom.broker.osgi, + org.opendaylight.controller.sal.dom.broker.util, org.opendaylight.controller.config.yang.md.sal.dom.impl, org.opendaylight.controller.config.yang.md.sal.dom.statistics, org.opendaylight.yangtools.yang.util diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java index 039bd5d07c..0120231f8d 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/impl/SchemaAwareDataStoreAdapter.java @@ -11,6 +11,7 @@ import org.opendaylight.controller.md.sal.common.api.data.DataReader; import org.opendaylight.controller.md.sal.common.impl.AbstractDataModification; import org.opendaylight.controller.md.sal.common.impl.util.AbstractLockableDelegator; import org.opendaylight.controller.sal.core.api.data.DataStore; +import org.opendaylight.controller.sal.dom.broker.util.YangSchemaUtils; import org.opendaylight.yangtools.yang.model.api.SchemaServiceListener; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.RpcResult; @@ -20,8 +21,7 @@ import org.opendaylight.yangtools.yang.data.api.Node; import org.opendaylight.yangtools.yang.data.impl.CompositeNodeTOImpl; import org.opendaylight.yangtools.yang.model.api.DataSchemaNode; import org.opendaylight.yangtools.yang.model.api.SchemaContext; -import org.opendaylight.yangtools.yang.util.YangDataOperations; -import org.opendaylight.yangtools.yang.util.YangSchemaUtils; +import org.opendaylight.controller.sal.dom.broker.util.YangDataOperations; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangDataOperations.xtend b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangDataOperations.xtend similarity index 94% rename from opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangDataOperations.xtend rename to opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangDataOperations.xtend index f69e00aa3a..f37fb0e5c0 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangDataOperations.xtend +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangDataOperations.xtend @@ -1,4 +1,4 @@ -package org.opendaylight.yangtools.yang.util +package org.opendaylight.controller.sal.dom.broker.util import org.opendaylight.yangtools.yang.data.api.CompositeNode import org.opendaylight.yangtools.yang.model.api.ContainerSchemaNode @@ -14,14 +14,13 @@ import java.util.List import org.opendaylight.yangtools.yang.model.api.LeafSchemaNode import org.opendaylight.yangtools.yang.model.api.LeafListSchemaNode import java.util.Collections -import static extension org.opendaylight.yangtools.yang.util.YangDataUtils.*; import java.util.HashSet import org.opendaylight.yangtools.yang.common.QName +import static extension org.opendaylight.controller.sal.dom.broker.util.YangDataUtils.*; class YangDataOperations { static def CompositeNode merge(DataSchemaNode schema, CompositeNode stored, CompositeNode modified, boolean config) { - checkConfigurational(schema, config); if (stored === null) { return modified; } @@ -42,7 +41,7 @@ class YangDataOperations { List> modified, boolean configurational) { checkArgument(original.size === 1); checkArgument(modified.size === 1); - checkConfigurational(node, configurational); + return modified; } @@ -61,7 +60,7 @@ class YangDataOperations { private static dispatch def Iterable> mergeMultiple(ListSchemaNode node, List> original, List> modified, boolean configurational) { - checkConfigurational(node,configurational); + if(node.keyDefinition === null || node.keyDefinition.empty) { return modified; } diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangDataUtils.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangDataUtils.java similarity index 95% rename from opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangDataUtils.java rename to opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangDataUtils.java index 687e4d9bf0..166fe38328 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangDataUtils.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangDataUtils.java @@ -1,4 +1,4 @@ -package org.opendaylight.yangtools.yang.util; +package org.opendaylight.controller.sal.dom.broker.util; import java.util.HashMap; import java.util.List; diff --git a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangSchemaUtils.java b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangSchemaUtils.java similarity index 99% rename from opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangSchemaUtils.java rename to opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangSchemaUtils.java index 3b31380afb..9a862d7a0c 100644 --- a/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/yangtools/yang/util/YangSchemaUtils.java +++ b/opendaylight/md-sal/sal-dom-broker/src/main/java/org/opendaylight/controller/sal/dom/broker/util/YangSchemaUtils.java @@ -1,4 +1,4 @@ -package org.opendaylight.yangtools.yang.util; +package org.opendaylight.controller.sal.dom.broker.util; import java.util.Iterator;