From: Ryan Goulding <ryandgoulding@gmail.com>
Date: Thu, 2 Mar 2017 21:53:49 +0000 (-0500)
Subject: Modify archetype to enable checkstyle failOnError by default
X-Git-Tag: release/carbon~199
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=ca157ceb95403bda3e73ede7c13cca4fadabac2b

Modify archetype to enable checkstyle failOnError by default

As a community, we want to try our best to influence new projects to write
clean, consistent code.  As such, we really ought to enable checkstyle failOnError
for projects that are generated using the startup archetype.  This change does
that;  projects can still turn this off, but it requires manual opt out.

By default, we should really try to influence failOnError so people write
good looking code.

Change-Id: If740df92cbc3d8ff8a0169d323028415e239a15a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
---

diff --git a/opendaylight/archetypes/opendaylight-startup/src/main/resources/archetype-resources/pom.xml b/opendaylight/archetypes/opendaylight-startup/src/main/resources/archetype-resources/pom.xml
index 2f0c96c278..481918991a 100644
--- a/opendaylight/archetypes/opendaylight-startup/src/main/resources/archetype-resources/pom.xml
+++ b/opendaylight/archetypes/opendaylight-startup/src/main/resources/archetype-resources/pom.xml
@@ -87,6 +87,12 @@ and is available at http://www.eclipse.org/legal/epl-v10.html INTERNAL
             </execution>
             </executions>
           </plugin>
+          <plugin>
+            <artifactId>maven-checkstyle-plugin</artifactId>
+            <configuration>
+              <failsOnError>true</failsOnError>
+            </configuration>
+          </plugin>
         </plugins>
       </build>
     </profile>