From: Robert Varga <rovarga@cisco.com>
Date: Sun, 1 Jun 2014 07:52:44 +0000 (+0200)
Subject: BUG-614: No need to build a future list
X-Git-Tag: release/helium~730
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=dc7c294911fd22c000eaa4e34d867482885975ed

BUG-614: No need to build a future list

It is obvious that the constructed list of futures is never going to be
used, so let's not construct it at all.

Change-Id: I506e33da52c53b5e63088a5c8ae0bb206eb6a720
Signed-off-by: Robert Varga <rovarga@cisco.com>
---

diff --git a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotificationBrokerImpl.java b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotificationBrokerImpl.java
index 5c7d924d34..49d51025dd 100644
--- a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotificationBrokerImpl.java
+++ b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotificationBrokerImpl.java
@@ -10,7 +10,6 @@ package org.opendaylight.controller.sal.binding.impl;
 import java.util.Collections;
 import java.util.Set;
 import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Future;
 
 import org.eclipse.xtext.xbase.lib.Conversions;
 import org.eclipse.xtext.xbase.lib.Functions.Function1;
@@ -28,8 +27,6 @@ import org.slf4j.LoggerFactory;
 
 import com.google.common.base.Preconditions;
 import com.google.common.collect.HashMultimap;
-import com.google.common.collect.ImmutableSet;
-import com.google.common.collect.ImmutableSet.Builder;
 import com.google.common.collect.Iterables;
 import com.google.common.collect.Multimap;
 import com.google.common.collect.Multimaps;
@@ -86,15 +83,10 @@ public class NotificationBrokerImpl implements NotificationProviderService, Auto
         };
         final Set<NotifyTask> tasks = IterableExtensions.<NotifyTask>toSet(
                 IterableExtensions.<NotificationListener<?>, NotifyTask>map(listenerToNotify, _function));
-        this.submitAll(executor, tasks);
-    }
 
-    private ImmutableSet<Future<Object>> submitAll(final ExecutorService service, final Set<NotifyTask> tasks) {
-        final Builder<Future<Object>> ret = ImmutableSet.<Future<Object>>builder();
         for (final NotifyTask task : tasks) {
-            ret.add(service.submit(task));
+            service.submit(task);
         }
-        return ret.build();
     }
 
     @Override