From: Tom Pantelis <tompantelis@gmail.com>
Date: Thu, 8 Mar 2018 02:54:09 +0000 (-0500)
Subject: Fix findbugs violations in md-sal - part 1
X-Git-Tag: release/fluorine~147
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=e2607370f5ac443a5a2f1f00f693f82a0b57161d;hp=e2607370f5ac443a5a2f1f00f693f82a0b57161d

Fix findbugs violations in md-sal - part 1

- sal-common-util
- sal-common-impl
- sal-dom-api
- sal-dom-spi
- sal-binding-api
- sal-inmemory-datastore

Violations:

- Non-transient non-serializable instance field in serializable class
- Field isn't final but should be
- Unchecked/unconfirmed cast
- Class names shouldn't shadow simple name of implemented interface
- Redundant nullcheck of value known to be non-null
- Field not initialized in constructor but dereferenced without null check
- Equals checks for incompatible operand
- Method ignores return value

Change-Id: I57ceba7dae12114eba962c01aea259004f4a2983
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
---