From: Alissa Bonas <abonas@redhat.com>
Date: Mon, 28 Oct 2013 10:44:28 +0000 (+0200)
Subject: Make existCache more efficient in ClusterManager
X-Git-Tag: jenkins-controller-bulk-release-prepare-only-2-1~526
X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?p=controller.git;a=commitdiff_plain;h=refs%2Fchanges%2F13%2F2213%2F2

Make existCache more efficient in ClusterManager

Allocate cacheName only when it's needed, when manager
is null the concatenation of strings is redundant.

Change-Id: I031e923d2d725b3e295ed7be53ceba19a6892e96
Signed-off-by: Alissa Bonas <abonas@redhat.com>
---

diff --git a/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java b/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java
index 518bf7b1a8..a9e6948a40 100644
--- a/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java
+++ b/opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java
@@ -398,10 +398,12 @@ public class ClusterManager implements IClusterServices {
     @Override
     public boolean existCache(String containerName, String cacheName) {
         EmbeddedCacheManager manager = this.cm;
-        String realCacheName = "{" + containerName + "}_{" + cacheName + "}";
+
         if (manager == null) {
             return false;
         }
+
+        String realCacheName = "{" + containerName + "}_{" + cacheName + "}";
         return manager.cacheExists(realCacheName);
     }