controller.git
5 years agoFix test case mis-spelling. 22/13822/1
Gary Wu [Mon, 22 Dec 2014 20:31:30 +0000 (12:31 -0800)]
Fix test case mis-spelling.

Change-Id: Ic50c32a18648e6ee484d8689d169b5b341d4f3c2
Signed-off-by: Gary Wu <Gary.Wu1@huawei.com>
5 years agoMerge "Remove sonar.profile since it's deprecated in Sonar 4.5"
Ed Warnicke [Sat, 20 Dec 2014 19:47:49 +0000 (19:47 +0000)]
Merge "Remove sonar.profile since it's deprecated in Sonar 4.5"

5 years agoMerge "Set root pom.xml <name> for Sonar"
Ed Warnicke [Sat, 20 Dec 2014 19:47:29 +0000 (19:47 +0000)]
Merge "Set root pom.xml <name> for Sonar"

5 years agoRemove sonar.profile since it's deprecated in Sonar 4.5 87/13587/3
Thanh Ha [Fri, 12 Dec 2014 05:00:20 +0000 (00:00 -0500)]
Remove sonar.profile since it's deprecated in Sonar 4.5

This parameter is deprecated in Sonar 4.5 and should no longer be used.
Instead this profile should be set server side on the Sonar server.

Change-Id: I6ac86e7c3cd18540dcfef7b43c19800007046612
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoSet root pom.xml <name> for Sonar 85/13585/3
Thanh Ha [Fri, 12 Dec 2014 02:21:50 +0000 (21:21 -0500)]
Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname. In this case "controller".

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: I1c963d398b7cee6506ffadb6ea7d30f54771071e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoRemove duplicate dependency declarations 84/13584/3
Thanh Ha [Fri, 12 Dec 2014 02:13:53 +0000 (21:13 -0500)]
Remove duplicate dependency declarations

org.opendaylight.controller:networkconfig.neutron and
org.opendaylight.yangtools:features-test are declared twice in the pom
file causing Maven to throw warnings.

Change-Id: I32da02be41a5a51ad05c85a0e186549141f38513
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoMerge "Fixed tag for <nexus.repository.snapshot>"
Ed Warnicke [Fri, 19 Dec 2014 16:38:20 +0000 (16:38 +0000)]
Merge "Fixed tag for <nexus.repository.snapshot>"

5 years agoMerge "added namespace to features/adsal pom.xml"
Ed Warnicke [Fri, 19 Dec 2014 16:37:44 +0000 (16:37 +0000)]
Merge "added namespace to features/adsal pom.xml"

5 years agoMerge "BUG-1382: do not instantiate prefixed QNames"
Tony Tkacik [Fri, 19 Dec 2014 15:44:44 +0000 (15:44 +0000)]
Merge "BUG-1382: do not instantiate prefixed QNames"

5 years agoBUG-1382: do not instantiate prefixed QNames 80/13680/5
Robert Varga [Tue, 16 Dec 2014 12:41:26 +0000 (13:41 +0100)]
BUG-1382: do not instantiate prefixed QNames

Prefix-aware QName constructor is going away, do not use it. Also fix
all references to QName.getPrefix().

Change-Id: Ife6567a269c2db16019ae97a6eace74a19ac3b23
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFixed tag for <nexus.repository.snapshot> 46/13746/1
Jonathan Fok kan [Thu, 18 Dec 2014 22:07:46 +0000 (17:07 -0500)]
Fixed tag for <nexus.repository.snapshot>

Change-Id: Ibc0a67e539c921449fc88b3c4435057d80112b54
Signed-off-by: Jonathan Fok kan <jfokkan@inocybe.com>
5 years agoadded namespace to features/adsal pom.xml 45/13745/5
Jonathan Fok kan [Thu, 18 Dec 2014 21:35:02 +0000 (16:35 -0500)]
added namespace to features/adsal pom.xml

Change-Id: I6a9751fd01bb63fa31125fbf2a483905dbf5f867
Signed-off-by: Jonathan Fok kan <jfokkan@inocybe.com>
5 years agoBUG-2459: use ImmutableSet instead of an unmodifieable HashSet 10/13410/5
Robert Varga [Fri, 5 Dec 2014 10:36:04 +0000 (11:36 +0100)]
BUG-2459: use ImmutableSet instead of an unmodifieable HashSet

This makes the lookups much more efficient.

Change-Id: I9c9a210b1eef1b5a2850013259191fde9a9c439b
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: reuse EXI Reader 12/13312/18
Robert Varga [Tue, 2 Dec 2014 15:21:14 +0000 (16:21 +0100)]
BUG-2459: reuse EXI Reader

The reader performs an internal reset on each invocation of parse(), so
it can be freely reused as long as we guarantee there are no concurrent
invocations. Our decoder class is not Shared, so netty guarantees this.

Change-Id: Icd575988e48ca5252d6f6716f4e08f83b23c99ca
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: reuse EXI Transmogrifier 11/13311/19
Robert Varga [Tue, 2 Dec 2014 14:57:27 +0000 (15:57 +0100)]
BUG-2459: reuse EXI Transmogrifier

EXI Transmogrifier performs an internal reset whenever we acquire the
SAXTransmogrifier. This means that we are free to reuse the instance
between individual invocations as long as we can guarantee there are no
concurrent access. That is guaranteed by our Handler not being Shared.

Change-Id: Iba141915000b016579b273d4413ecd205f8da777
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge changes Ic8cadf33,If59b1dd3
Tony Tkacik [Thu, 18 Dec 2014 14:22:32 +0000 (14:22 +0000)]
Merge changes Ic8cadf33,If59b1dd3

* changes:
  Bug-2342: Add stress test with more threads and start of testtool device.
  Bug-2342: Fixing rpc-reply messages id's get mixed up

5 years agoMerge changes Icd18348e,I0e642b1b,I304bec5e
Tony Tkacik [Thu, 18 Dec 2014 14:20:29 +0000 (14:20 +0000)]
Merge changes Icd18348e,I0e642b1b,I304bec5e

* changes:
  BUG-2459: maintain a cache of grammar caches
  BUG-2459: cache GrammarCache
  BUG-2459: centralize codec allocation

5 years agoMerge "BUG-2511 Fix XXE vulnerability in initial config loaders"
Tony Tkacik [Thu, 18 Dec 2014 14:16:30 +0000 (14:16 +0000)]
Merge "BUG-2511 Fix XXE vulnerability in initial config loaders"

5 years agoMerge "BUG-2288: DOMNotification API"
Tony Tkacik [Thu, 18 Dec 2014 14:13:12 +0000 (14:13 +0000)]
Merge "BUG-2288: DOMNotification API"

5 years agoBUG-2511 Fix XXE vulnerability in initial config loaders 31/13731/1
Maros Marsalek [Thu, 18 Dec 2014 09:33:02 +0000 (10:33 +0100)]
BUG-2511 Fix XXE vulnerability in initial config loaders

Change-Id: I0b9aefa8d7a2d59f542075172fe03678618a6385
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "BUG 2509 : Removing all journal entries from a Followers in-memory journal...
Tom Pantelis [Wed, 17 Dec 2014 23:56:32 +0000 (23:56 +0000)]
Merge "BUG 2509 : Removing all journal entries from a Followers in-memory journal causes Leader to send an InstallSnapshot"

5 years agoMerge "BUG 2464 : Shard dataSize does not seem to correspond to actual memory usage"
Tom Pantelis [Wed, 17 Dec 2014 23:55:44 +0000 (23:55 +0000)]
Merge "BUG 2464 : Shard dataSize does not seem to correspond to actual memory usage"

5 years agoBUG 2464 : Shard dataSize does not seem to correspond to actual memory usage 49/13349/7
Moiz Raja [Wed, 3 Dec 2014 17:58:35 +0000 (09:58 -0800)]
BUG 2464 : Shard dataSize does not seem to correspond to actual memory usage

The dataSize that is reported is the "serialized" size of the payload. Since the replicated
log actually contains the CompositeModification object (which may hold on to a lot more memory)
the serialized size is not neccessarily the same as the object size.

To make the data size correspond to memory usage and to actually reduce memory usage this patch
creates a new payload class called CompositeModificationByteStringPayload which only stores the
ByteString which is an order of magnitude smaller. Custom serialization ensures that this object
is written and read correctly.

This patch is backward compatible in that a replicated log containing a CompositeModificationPayload
will be read correctly but is not forward compatible in that if a new controller instance were to send
a CompositeModificationPayload to an older instance it would not work.

To ensure that we do not need to immediately require a conversion from ByteString to PersistentMessages.CompositeModification we maintain a SoftReference to CompositeModification.

Change-Id: I32c921dea2d39ed689aa2fb6f68eb8528be920d0
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG-2459: maintain a cache of grammar caches 18/13318/17
Robert Varga [Tue, 2 Dec 2014 17:47:36 +0000 (18:47 +0100)]
BUG-2459: maintain a cache of grammar caches

This just reuses instances across multiple sessions, since the
cardinality is usually low.

Change-Id: Icd18348eee51295f50e224572c103e3b5572963b
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: cache GrammarCache 09/13309/20
Robert Varga [Tue, 2 Dec 2014 14:55:20 +0000 (15:55 +0100)]
BUG-2459: cache GrammarCache

The GrammarCache without a schema is used as a template, so it is
expliticly okay to reuse it across multiple instances. Make sure we
reuse it as much as possible.

Change-Id: I0e642b1b580051e997de9602020ab0dace7dbcac
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: centralize codec allocation 10/13310/18
Robert Varga [Tue, 2 Dec 2014 14:59:06 +0000 (15:59 +0100)]
BUG-2459: centralize codec allocation

This moves EXI codec allocation into AbstractNetconfSession, so it is
can be standardized for both client and server.

Change-Id: I304bec5e19efaa6c3ff63ac66f2bd0d9c55c6b7a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2511: disable external entitiy resolution with EXI 51/13651/2
Robert Varga [Mon, 15 Dec 2014 13:38:25 +0000 (14:38 +0100)]
BUG-2511: disable external entitiy resolution with EXI

OpenEXI transmogrifier can resolve external entities. This should never
be necessary in NETCONF context, so disallow that. The same goes for the
reader, but there we need to add a custom EntityResolver.

Change-Id: Idf4b7faf13063c88624f2ba16f3871679c072b3e
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG 2509 : Removing all journal entries from a Followers in-memory journal causes... 75/13675/1
Moiz Raja [Tue, 16 Dec 2014 05:59:13 +0000 (21:59 -0800)]
BUG 2509 : Removing all journal entries from a Followers in-memory journal causes Leader to send an InstallSnapshot

This patch simply checks if an AppendEntries#prevLogIndex is equal to the followers ReplicatedLog#snapshotIndex. If
both are the same it also verifies that the AppendEntries#prevLogTerm is equal to the followers ReplicatedLog#snapshotTerm.
This is sufficient in most cases to prevent a re-installation of a snapshot when the AppendEntries message is supposed
to immediately follow the snapshot.

Change-Id: Iab9b493455538544efd06334329f91cc426d61f8
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Remove throws declaration of a runtime exception"
Tony Tkacik [Mon, 15 Dec 2014 15:07:09 +0000 (15:07 +0000)]
Merge "Remove throws declaration of a runtime exception"

5 years agoMerge "BUG-2511 Fix possible XXE vulnerability in restconf"
Tony Tkacik [Mon, 15 Dec 2014 14:57:59 +0000 (14:57 +0000)]
Merge "BUG-2511 Fix possible XXE vulnerability in restconf"

5 years agoMerge "Allow rpc definition for RuntimeMXBeans to come from groupings"
Tony Tkacik [Mon, 15 Dec 2014 14:57:22 +0000 (14:57 +0000)]
Merge "Allow rpc definition for RuntimeMXBeans to come from groupings"

5 years agoBug-2342: Add stress test with more threads and start of testtool device. 04/13404/10
Marian Dubai [Thu, 4 Dec 2014 11:53:42 +0000 (12:53 +0100)]
Bug-2342: Add stress test with more threads and start of testtool device.

Change-Id: Ic8cadf339d330d9e165db4b0eafe8e8408601abd
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoBug-2342: Fixing rpc-reply messages id's get mixed up 03/13403/11
Marian Dubai [Thu, 4 Dec 2014 09:03:41 +0000 (10:03 +0100)]
Bug-2342: Fixing rpc-reply messages id's get mixed up

Change-Id: If59b1dd30c6552efa93df7bb8d776396a9c7bafb
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoMerge "BUG-2511 Fix XXE vulnerability in Netconf"
Tony Tkacik [Mon, 15 Dec 2014 13:20:47 +0000 (13:20 +0000)]
Merge "BUG-2511 Fix XXE vulnerability in Netconf"

5 years agoAllow rpc definition for RuntimeMXBeans to come from groupings 29/13129/4
Maros Marsalek [Tue, 25 Nov 2014 17:02:02 +0000 (18:02 +0100)]
Allow rpc definition for RuntimeMXBeans to come from groupings

Change-Id: I796b43e8a4b01277bcb0c73f5ac86bc710839061
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2511 Fix possible XXE vulnerability in restconf 49/13649/2
Maros Marsalek [Mon, 15 Dec 2014 11:19:11 +0000 (12:19 +0100)]
BUG-2511 Fix possible XXE vulnerability in restconf

Change-Id: I16eaf8a743b94ec26e3ac427fb777d0c769ec3c2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge topic 'checkstyle'
Tony Tkacik [Mon, 15 Dec 2014 11:43:59 +0000 (11:43 +0000)]
Merge topic 'checkstyle'

* changes:
  Fix checkstyle if-statements must use braces northbound/commons
  Fix checkstyle if-statements must use braces hosttracker_new
  Fix checkstyle simplify boolean expression config-api

5 years agoMerge "Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration"
Tony Tkacik [Mon, 15 Dec 2014 11:42:32 +0000 (11:42 +0000)]
Merge "Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration"

5 years agoMerge "Registry instance cannot be null in RpcProxyRegistration"
Tony Tkacik [Mon, 15 Dec 2014 11:37:34 +0000 (11:37 +0000)]
Merge "Registry instance cannot be null in RpcProxyRegistration"

5 years agoMerge "Do not instantiate FluentIterable"
Tony Tkacik [Mon, 15 Dec 2014 11:37:25 +0000 (11:37 +0000)]
Merge "Do not instantiate FluentIterable"

5 years agoBUG-2511 Fix XXE vulnerability in Netconf 47/13647/1
Maros Marsalek [Mon, 15 Dec 2014 10:03:56 +0000 (11:03 +0100)]
BUG-2511 Fix XXE vulnerability in Netconf

Change-Id: Ifc1d63fc632e7395a46d85fc2ccb9095e7008430
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Fix warnings in config-manager"
Tony Tkacik [Mon, 15 Dec 2014 09:51:11 +0000 (09:51 +0000)]
Merge "Fix warnings in config-manager"

5 years agoRemove throws declaration of a runtime exception 33/13633/2
Robert Varga [Sun, 14 Dec 2014 18:18:40 +0000 (19:18 +0100)]
Remove throws declaration of a runtime exception

IllegalStateException is a RuntimeException -- hence we do not need to
declare it.

Change-Id: I681eff319b299beecf7710c44f154c1bb1b5174a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoShorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration 32/13632/2
Robert Varga [Sun, 14 Dec 2014 17:38:56 +0000 (18:38 +0100)]
Shorten org.opendaylight.controller.sal.core.api.Broker.RoutedRpcRegistration

We can safely import the class, shortening references to it.

Change-Id: I41d5ca29f1dd4daff726d3598c1bf14732318752
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRegistry instance cannot be null in RpcProxyRegistration 31/13631/2
Robert Varga [Sun, 14 Dec 2014 17:21:25 +0000 (18:21 +0100)]
Registry instance cannot be null in RpcProxyRegistration

removeRegistration() is guaranteed to be invoked at most once, and
registry cannot be null. Make it final and remove the safety check.

Change-Id: Ie8f2da7430c076d0bec71eb8b58a4adc2af25adf
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoDo not instantiate FluentIterable 30/13630/2
Robert Varga [Sun, 14 Dec 2014 17:16:50 +0000 (18:16 +0100)]
Do not instantiate FluentIterable

We are performing an immediate transformation of the iterrable.
Instead of that we can immediately use Collections2.transform(), saving
an object.

Change-Id: Ie943a0a79e04713427bf6470e06d921412ebb179
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Fixed compilation error in Eclipse."
Tony Tkacik [Mon, 15 Dec 2014 08:49:25 +0000 (08:49 +0000)]
Merge "Fixed compilation error in Eclipse."

5 years agoFix checkstyle if-statements must use braces northbound/commons 20/13620/2
Thanh Ha [Sun, 14 Dec 2014 16:29:16 +0000 (11:29 -0500)]
Fix checkstyle if-statements must use braces northbound/commons

Change-Id: Iadad636ebf07e8c31a8c85540f10180b825c8a4a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces hosttracker_new 19/13619/2
Thanh Ha [Sun, 14 Dec 2014 16:21:37 +0000 (11:21 -0500)]
Fix checkstyle if-statements must use braces hosttracker_new

Change-Id: I8261723a288103deb227b99e72d558f6303a37d8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle simplify boolean expression config-api 86/13586/3
Thanh Ha [Fri, 12 Dec 2014 03:03:26 +0000 (22:03 -0500)]
Fix checkstyle simplify boolean expression config-api

Change-Id: I4e47824cfd73bc798a06fc1dac299d94cebed7b3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix warnings in config-manager 73/13073/4
Robert Varga [Fri, 21 Nov 2014 19:31:19 +0000 (20:31 +0100)]
Fix warnings in config-manager

Unused import and an unused PMD warning suppression.

Change-Id: I84073e732a1ea40f07b20e5ebd0101ae4249906e
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Reuse PEM provider in netconf-testtool."
Tony Tkacik [Mon, 15 Dec 2014 08:06:17 +0000 (08:06 +0000)]
Merge "Reuse PEM provider in netconf-testtool."

5 years agoMerge topic 'stable/helium'
Tony Tkacik [Mon, 15 Dec 2014 07:57:53 +0000 (07:57 +0000)]
Merge topic 'stable/helium'

* changes:
  Shorten YangInstanceIdentifier references
  BUG-2510: handle RPC route removal

5 years agoMerge "BUG-2510: Remove all registrations when a routed rpc is closed"
Tony Tkacik [Mon, 15 Dec 2014 07:56:57 +0000 (07:56 +0000)]
Merge "BUG-2510: Remove all registrations when a routed rpc is closed"

5 years agoMerge "BUG-2459: use thread-local cache of transformers"
Tony Tkacik [Mon, 15 Dec 2014 07:51:47 +0000 (07:51 +0000)]
Merge "BUG-2459: use thread-local cache of transformers"

5 years agoMerge "Mark DomBrokerImplModule.createLegacyDataService() as deprecated"
Tony Tkacik [Mon, 15 Dec 2014 07:51:25 +0000 (07:51 +0000)]
Merge "Mark DomBrokerImplModule.createLegacyDataService() as deprecated"

5 years agoMerge "BUG-2500: add current tree state to traces"
Tony Tkacik [Mon, 15 Dec 2014 07:51:15 +0000 (07:51 +0000)]
Merge "BUG-2500: add current tree state to traces"

5 years agoMerge "Cache TransformerFactory"
Tony Tkacik [Mon, 15 Dec 2014 07:50:52 +0000 (07:50 +0000)]
Merge "Cache TransformerFactory"

5 years agoShorten YangInstanceIdentifier references 29/13629/1
Robert Varga [Sun, 14 Dec 2014 17:13:10 +0000 (18:13 +0100)]
Shorten YangInstanceIdentifier references

We no longer have InstanceIdentifier name clash, so we can safely import
YangInstanceIdentifier and use it that way.

Change-Id: I48d13f9e6ecd17c1de40b5a017962cfc792810ad
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2510: handle RPC route removal 28/13628/1
Robert Varga [Sun, 14 Dec 2014 18:32:13 +0000 (19:32 +0100)]
BUG-2510: handle RPC route removal

DOM to Binding forwarding ignored removals of RPC implementations. Add
that case back.

Change-Id: I7af1d8b43b9b229cc9a696cfdfc61146f960b374
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2510: Remove all registrations when a routed rpc is closed 27/13627/1
Robert Varga [Sun, 14 Dec 2014 18:20:00 +0000 (19:20 +0100)]
BUG-2510: Remove all registrations when a routed rpc is closed

The API contract specifies that the effects of a Registration are
removed on close(). Unfortunately the routed RPC case is more funny, as
it has sub-registrations, for each added path -- and we have no mention
of the fact that the user should be removing them.

Hence we need to handle the user expecting us to remove any and all
paths which have been registered.

Change-Id: Iedf451c2a481d648173819f895cccb9e63c54d99
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFixed compilation error in Eclipse. 51/13551/2
Gary Wu [Wed, 10 Dec 2014 22:56:39 +0000 (14:56 -0800)]
Fixed compilation error in Eclipse.

Change-Id: Id6004fbbc1c409f111b9ca57419d36b8686b1f89
Signed-off-by: Gary Wu <gary.wu@gmail.com>
5 years agoMark DomBrokerImplModule.createLegacyDataService() as deprecated 77/13077/2
Robert Varga [Mon, 24 Nov 2014 16:40:49 +0000 (17:40 +0100)]
Mark DomBrokerImplModule.createLegacyDataService() as deprecated

This marks the method deprecated, as we want to get rid of it. Fixes a
few warnings.

Change-Id: If4e613c07e9cd2b9b737fd697cbcd5709499c4d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: use thread-local cache of transformers 17/13317/13
Robert Varga [Tue, 2 Dec 2014 19:01:53 +0000 (20:01 +0100)]
BUG-2459: use thread-local cache of transformers

As it turns out, we can reuse transformers in the encode path. Do
precisely that, keeping them in thread-local variables. This is safe in
context of Netty, as we are invoked only from the netty threadpool. This
has the benefit of reusing the transformers across all sessions
associated with the threadpool.

Change-Id: If57933f68a9c9196b649baea17353fd2bd472e09
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2500: add current tree state to traces 63/13563/3
Robert Varga [Thu, 11 Dec 2014 12:10:10 +0000 (13:10 +0100)]
BUG-2500: add current tree state to traces

When a data validation exception occurs, also add the current tree state
to trace output.

Change-Id: I637973458519d4ed25fa3203fa79b72faf9a9e8b
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoCache TransformerFactory 62/13562/2
Robert Varga [Thu, 11 Dec 2014 10:11:59 +0000 (11:11 +0100)]
Cache TransformerFactory

Instantiating a transformerfactory is costly, so cache and reuse it.

Change-Id: I43561ef36cdd10ef077b77c71673840d4dc83fbd
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: do not instantiate factories in fastpath 60/13560/2
Robert Varga [Thu, 11 Dec 2014 10:08:26 +0000 (11:08 +0100)]
BUG-2459: do not instantiate factories in fastpath

This caches the factories in static fields rather than instantiating
them on each call.

Change-Id: I4dfee7724320914f2c7c9724192e4653deea3cde
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2506: split out maven binding 90/13590/2
Robert Varga [Fri, 12 Dec 2014 11:07:45 +0000 (12:07 +0100)]
BUG-2506: split out maven binding

Maven integration needs to be split out of the runtime implementation,
simply because we do not want to pull the requisite runtime into our
containers. It would never be used there anyway.

Change-Id: Ided36e3b06316739a3829d758889ba523e7e19ad
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "BUG-2470: add trace of failed modification"
Tony Tkacik [Wed, 10 Dec 2014 15:35:38 +0000 (15:35 +0000)]
Merge "BUG-2470: add trace of failed modification"

5 years agoMerge "BUG-2475: Do not issue garbage collection on when pushing configurations"
Tony Tkacik [Wed, 10 Dec 2014 15:34:14 +0000 (15:34 +0000)]
Merge "BUG-2475: Do not issue garbage collection on when pushing configurations"

5 years agoMerge topic 'checkstyle'
Tony Tkacik [Wed, 10 Dec 2014 09:11:31 +0000 (09:11 +0000)]
Merge topic 'checkstyle'

* changes:
  Fix checkstyle if-statements must use braces liblldp
  Fix checkstyle if-statements must use braces hosttracker
  Fix checkstyle if-statements must use braces bundlescanner
  Fix checkstyle if-statements must use braces ClusterManager
  Fix checkstyle if-statements must use braces HostTrackerCallable
  Fix checkstyle if-statements must use braces ConnectionManagerNorthbound
  Fix checkstyle if-statements must use braces HostTrackerNorthbound
  Fix checkstyle if-statements must use braces BridgeDomainNorthbound
  Fix checkstyle if-statements must use braces adsal/northbound/staticrouting
  Fix checkstyle if-statements must use braces adsal/northbound/statistics
  Fix checkstyle if-statements must use braces adsal/protocol_plugins
  Fix checkstyle if-statements must use braces adsal/sal/connection
  Fix checkstyle if-statements must use braces adsal/samples/loadbalancer
  Fix checkstyle if-statements must use braces adsal/usermanager
  Fix checkstyle if-statements must use braces config-persister-file-xml-adapter
  Fix checkstyle if-statements must use braces logback-config
  Fix checkstyle if-statements must use braces yang-jmx-generator-plugin
  Fix checkstyle if-statements must use braces yang-jmx-generator
  Fix checkstyle if-statements must use braces sal-common-impl
  Fix checkstyle if-statements must use braces sal-common-util
  Fix checkstyle if-statements must use braces sal-dom-xsql
  Fix checkstyle if-statements must use braces sal-netconf-connector
  Fix checkstyle if-statements must use braces sal-rest-docgen
  Fix checkstyle if-statements must use braces md/statistics
  Fix checkstyle if-statements must use braces netconf

5 years agoMerge "Fix duplicate dependency warnings"
Tony Tkacik [Wed, 10 Dec 2014 09:07:23 +0000 (09:07 +0000)]
Merge "Fix duplicate dependency warnings"

5 years agoMerge "Fix Sonar Bad practice - Method may fail to close stream"
Tony Tkacik [Wed, 10 Dec 2014 09:07:01 +0000 (09:07 +0000)]
Merge "Fix Sonar Bad practice - Method may fail to close stream"

5 years agoFix checkstyle if-statements must use braces liblldp 24/13524/1
Thanh Ha [Wed, 10 Dec 2014 00:19:16 +0000 (19:19 -0500)]
Fix checkstyle if-statements must use braces liblldp

Change-Id: I2e36139dbeea5890a7eec7003da186af162e8998
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces hosttracker 23/13523/1
Thanh Ha [Wed, 10 Dec 2014 00:16:11 +0000 (19:16 -0500)]
Fix checkstyle if-statements must use braces hosttracker

Change-Id: I4ecd87422d228da396bfd3027aae3a365206fe2a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces bundlescanner 22/13522/1
Thanh Ha [Wed, 10 Dec 2014 00:13:17 +0000 (19:13 -0500)]
Fix checkstyle if-statements must use braces bundlescanner

Change-Id: I54dcb1e13e913f3dcfcb1b2801b78aa62919a6bf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces ClusterManager 21/13521/1
Thanh Ha [Tue, 9 Dec 2014 23:03:30 +0000 (18:03 -0500)]
Fix checkstyle if-statements must use braces ClusterManager

Change-Id: Ie8f6ec2ad3ea1e4131218b599fa4f1c5a9eb5cc4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces HostTrackerCallable 20/13520/1
Thanh Ha [Tue, 9 Dec 2014 23:02:46 +0000 (18:02 -0500)]
Fix checkstyle if-statements must use braces HostTrackerCallable

Change-Id: I199f7b95f8e2740a4f5375f2ecd9a6ce4e39a2f6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces ConnectionManagerNorthbound 19/13519/1
Thanh Ha [Tue, 9 Dec 2014 23:01:44 +0000 (18:01 -0500)]
Fix checkstyle if-statements must use braces ConnectionManagerNorthbound

Change-Id: If429fd24b5b346a350bc1cf488c800d445d4bbc1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces HostTrackerNorthbound 18/13518/1
Thanh Ha [Tue, 9 Dec 2014 23:01:12 +0000 (18:01 -0500)]
Fix checkstyle if-statements must use braces HostTrackerNorthbound

Change-Id: Iaf3b56c7d66bd1609599e05833788c80bddf8924
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces BridgeDomainNorthbound 17/13517/1
Thanh Ha [Tue, 9 Dec 2014 22:59:45 +0000 (17:59 -0500)]
Fix checkstyle if-statements must use braces BridgeDomainNorthbound

Change-Id: If3656f11133856b14340ef03939e53ebd46874a3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/northbound/staticrouting 16/13516/1
Thanh Ha [Tue, 9 Dec 2014 22:58:29 +0000 (17:58 -0500)]
Fix checkstyle if-statements must use braces adsal/northbound/staticrouting

Change-Id: I1a12ee8523e948af752c5fb2627a8567c99ed9e5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/northbound/statistics 15/13515/1
Thanh Ha [Tue, 9 Dec 2014 22:57:09 +0000 (17:57 -0500)]
Fix checkstyle if-statements must use braces adsal/northbound/statistics

Change-Id: I2ef8d4fc3977eb8db6e369d9bb2fb2c6b5ad70db
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/protocol_plugins 14/13514/1
Thanh Ha [Tue, 9 Dec 2014 22:55:35 +0000 (17:55 -0500)]
Fix checkstyle if-statements must use braces adsal/protocol_plugins

Change-Id: I2110c4623f141e738b368d0bce0695ebc98809ff
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/sal/connection 13/13513/1
Thanh Ha [Tue, 9 Dec 2014 22:54:26 +0000 (17:54 -0500)]
Fix checkstyle if-statements must use braces adsal/sal/connection

Change-Id: Ib08edee1ed589b1bcbbaa9b38054ed5c301bb49c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/samples/loadbalancer 12/13512/1
Thanh Ha [Tue, 9 Dec 2014 22:53:03 +0000 (17:53 -0500)]
Fix checkstyle if-statements must use braces adsal/samples/loadbalancer

Change-Id: I57535ed22a2ad4947dfb768b399c69d15444b39e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces adsal/usermanager 11/13511/1
Thanh Ha [Tue, 9 Dec 2014 22:51:06 +0000 (17:51 -0500)]
Fix checkstyle if-statements must use braces adsal/usermanager

Change-Id: Idfb6cc67ab679c6b126724d25fefecc3e4cf45c2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces config-persister-file-xml-adapter 10/13510/1
Thanh Ha [Tue, 9 Dec 2014 22:50:14 +0000 (17:50 -0500)]
Fix checkstyle if-statements must use braces config-persister-file-xml-adapter

Change-Id: I8c3d8a5e7ada9bb39822d364e765be253c6a9691
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces logback-config 09/13509/1
Thanh Ha [Tue, 9 Dec 2014 22:49:34 +0000 (17:49 -0500)]
Fix checkstyle if-statements must use braces logback-config

Change-Id: Ie857c55d72e6ab582a9abde8bf7e649e23f8323a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces yang-jmx-generator-plugin 08/13508/1
Thanh Ha [Tue, 9 Dec 2014 22:48:37 +0000 (17:48 -0500)]
Fix checkstyle if-statements must use braces yang-jmx-generator-plugin

Change-Id: Ic3411f453bea29817e0c637423059efa6d398e93
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces yang-jmx-generator 07/13507/1
Thanh Ha [Tue, 9 Dec 2014 22:45:50 +0000 (17:45 -0500)]
Fix checkstyle if-statements must use braces yang-jmx-generator

Change-Id: I2d57b840a80d48d5227651582436b6c78ddf1ad5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-common-impl 06/13506/1
Thanh Ha [Tue, 9 Dec 2014 22:42:25 +0000 (17:42 -0500)]
Fix checkstyle if-statements must use braces sal-common-impl

Change-Id: Ib2d0a8bcf4cef4a589a8c23181433dd14ea84657
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-common-util 05/13505/1
Thanh Ha [Tue, 9 Dec 2014 22:41:24 +0000 (17:41 -0500)]
Fix checkstyle if-statements must use braces sal-common-util

Change-Id: I518b9fa156af55c080d7e6a55067deab2c789a42
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-dom-xsql 04/13504/1
Thanh Ha [Tue, 9 Dec 2014 22:40:23 +0000 (17:40 -0500)]
Fix checkstyle if-statements must use braces sal-dom-xsql

Change-Id: I68b6f356b30e56247dec7c96aa43e345e6d972f8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-netconf-connector 03/13503/1
Thanh Ha [Tue, 9 Dec 2014 22:35:29 +0000 (17:35 -0500)]
Fix checkstyle if-statements must use braces sal-netconf-connector

Change-Id: I2b4587534eb54833a012e01179d24e526d70d208
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces sal-rest-docgen 02/13502/1
Thanh Ha [Tue, 9 Dec 2014 22:32:21 +0000 (17:32 -0500)]
Fix checkstyle if-statements must use braces sal-rest-docgen

Change-Id: Id08ad375b27838637497dd507df0c076bf2b63df
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces md/statistics 01/13501/1
Thanh Ha [Tue, 9 Dec 2014 22:30:56 +0000 (17:30 -0500)]
Fix checkstyle if-statements must use braces md/statistics

Change-Id: I3e1ba6fdbed82a4f724585d5a420299698e851c9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix checkstyle if-statements must use braces netconf 00/13500/1
Thanh Ha [Tue, 9 Dec 2014 22:28:38 +0000 (17:28 -0500)]
Fix checkstyle if-statements must use braces netconf

Change-Id: I2e5b8cc264acee74530ccbb990014b54649764b1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoBUG-2470: add trace of failed modification 82/13482/1
Robert Varga [Tue, 9 Dec 2014 17:01:10 +0000 (18:01 +0100)]
BUG-2470: add trace of failed modification

With this change, the InMemoryDOMDataStore trace logs should contain the
dump of failed modifications.

Change-Id: Iea3038169090a574030c5e03cf155089faa6e985
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2475: Do not issue garbage collection on when pushing configurations 79/13479/3
Robert Varga [Tue, 9 Dec 2014 15:11:48 +0000 (16:11 +0100)]
BUG-2475: Do not issue garbage collection on when pushing configurations

This gc() call used to make sense when we were running this code as a
one-shot initialization (e.g. Hydrogen container). With the Karaf
changes, this was moved into a persistent codepath -- which does not
make sense at all.

Change-Id: I0e3d4a2b674241c80d682630b031fb3517621251
Signed-off-by: Robert Varga <rovarga@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.