controller.git
7 years agoyang-prototype: add missing version for maven-site-plugin 61/1061/1
Chris Wright [Fri, 30 Aug 2013 06:44:43 +0000 (23:44 -0700)]
yang-prototype: add missing version for maven-site-plugin

This fixes the following warnings:

[WARNING] Some problems were encountered while building the effective model for org.opendaylight.controller:concepts-lang:jar:0.5-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-site-plugin is missing. @ org.opendaylight.controller:yang-prototype:0.5-SNAPSHOT, /home/chrisw/git/opendaylight/controller/opendaylight/sal/yang-prototype/pom.xml, line 227, column 21
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.controller:yang-prototype:pom:0.5-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-site-plugin is missing. @ line 227, column 21

Change-Id: Ie36afa672081e3fa5445e539d9279ce14a6fdec0
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
7 years agoMerge "When ports are added to a container, construct its topology immediately based...
Alessandro Boch [Fri, 30 Aug 2013 14:59:43 +0000 (14:59 +0000)]
Merge "When ports are added to a container, construct its topology immediately based on the existing global topology."

7 years agoMerge "Gracefully stop HT threads when the bundle is being stopped (cache terminated...
Jason Ye [Fri, 30 Aug 2013 14:53:01 +0000 (14:53 +0000)]
Merge "Gracefully stop HT threads when the bundle is being stopped (cache terminated exception)"

7 years agoMerge "Fix undefined event, add check prior to delete"
Andrew Kim [Fri, 30 Aug 2013 01:30:32 +0000 (01:30 +0000)]
Merge "Fix undefined event, add check prior to delete"

7 years agoMerge "FRM event sync developement"
Madhu Venugopal [Fri, 30 Aug 2013 01:18:31 +0000 (01:18 +0000)]
Merge "FRM event sync developement"

7 years agoGracefully stop HT threads when the bundle is being stopped (cache terminated exception) 55/1055/1
Alessandro Boch [Thu, 29 Aug 2013 23:58:31 +0000 (16:58 -0700)]
Gracefully stop HT threads when the bundle is being stopped (cache terminated exception)

ISSUE:
When HT bundle is being stopped because container is being destroyed,
infinispan cache terminated exceptions are thrown because HT treads
during their last run are accessing terminated HT caches.
CHANGE:
- Have a stopping flag which gets set when dep mgr calls the HT stopping() method,
so that pending threads and timer tasks can be stopped before Cluster Mgr
terminates the HT caches.
- Fix other static analysis issues in HT code

Change-Id: I3eedb81f9db31c8419502d2eba02aa421616f06a
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix undefined event, add check prior to delete 54/1054/1
Andrew Kim [Thu, 29 Aug 2013 23:37:03 +0000 (18:37 -0500)]
Fix undefined event, add check prior to delete

Also changed remove button colors to btn-danger

Change-Id: If1166199b3713132c2c00db4e25d5bc06f26e07a
Signed-off-by: Andrew Kim <andrekim@cisco.com>
7 years agoWhen ports are added to a container, construct its topology immediately based on... 52/1052/1
Jason Ye [Thu, 29 Aug 2013 23:27:24 +0000 (16:27 -0700)]
When ports are added to a container, construct its topology immediately based on the existing global topology.

Change-Id: I6f78a6e03001f52af3eb7cd024fd95dec917dad3
Signed-off-by: Jason Ye <yisye@cisco.com>
7 years agoFix for the Nodes Learnt dashlet error when there are no ports in the topology. 51/1051/2
lakshya [Thu, 29 Aug 2013 23:10:34 +0000 (16:10 -0700)]
Fix for the Nodes Learnt dashlet error when there are no ports in the topology.
This fixes the issue of the dashlet not loading by introducing a null check.

Change-Id: I2c00166409706e95024a913d7e2d85d4f8d4fc3e
Signed-off-by: lakshya <lakshya@cisco.com>
7 years agoFRM event sync developement 35/1035/2
Giovanni Meo [Thu, 22 Aug 2013 21:00:35 +0000 (23:00 +0200)]
FRM event sync developement

- Created necessary logic for distributing entry programming among the
FRM instances in the cluster.
- Made serializable Status so it can be distributed.
- Hooked FRM with connection manager, such that the FRM programming
can be distributed if the node is not local
- In case of non-local node someone picks it and process it, then the
status is returned back to caller.
- At the moment the whole logic to timeout entries that don't get an
answer is missing, will come along.
- HostTracker ages out the ARP entries in clustered environment
because when refreshed the timeout was not being refreshed
clusterwide, probably need a better way to deal with the timing out
-Added license in files missing it.
- Fixed integration test failing, now in fact we can no longer use
fake values else the connection manager will not report them as
attached to local controller and will stuck the test case

Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Change-Id: I74b7535371f61759e89883c66ba9b22596d7dddc

7 years agoNorthbound api cleanup for Subnets 37/1037/1
Diti Bhatia [Thu, 29 Aug 2013 06:34:45 +0000 (23:34 -0700)]
Northbound api cleanup for Subnets

Change-Id: I55f9bfdad8d35a19e2c19a10933d57714b69da88
Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
7 years agoChange 'Nodes Learnt' to 'Nodes Learned' 34/1034/1
Andrew Kim [Wed, 28 Aug 2013 17:06:35 +0000 (12:06 -0500)]
Change 'Nodes Learnt' to 'Nodes Learned'

Change-Id: If3b6099d4f730a8237b471ab4b83db2419745775
Signed-off-by: Andrew Kim <andrekim@cisco.com>
7 years agoMerge "Added archetypes to releasepom"
Giovanni Meo [Wed, 28 Aug 2013 15:26:37 +0000 (15:26 +0000)]
Merge "Added archetypes to releasepom"

7 years agoHostTracker REST APIs compliance of new guidelines 09/1009/6
Asad Ahmed [Tue, 27 Aug 2013 18:19:40 +0000 (11:19 -0700)]
HostTracker REST APIs compliance of new guidelines

Change-Id: I8d33f9970bc4585120316f4cc96f8f32669df4ed
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
7 years agoAdded archetypes to releasepom 33/1033/1
Ed Warnicke [Wed, 28 Aug 2013 14:59:11 +0000 (07:59 -0700)]
Added archetypes to releasepom

Change-Id: Id6cbfba6d3d798fe90ed227c54cc9472b4d57068
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMerge "Prepare for mvn release:prepare release:perform operation"
Ed Warnicke [Wed, 28 Aug 2013 14:48:33 +0000 (14:48 +0000)]
Merge "Prepare for mvn release:prepare release:perform operation"

7 years agoPrepare for mvn release:prepare release:perform operation 78/978/4
Giovanni Meo [Fri, 23 Aug 2013 08:56:51 +0000 (10:56 +0200)]
Prepare for mvn release:prepare release:perform operation

- Make sure every bundle include a proper scm section
- Provided a pom to be used for release operations in the root
directory, this is due to some implicit assumptions
maven-release-manager does when performing a release. The
maven-release-manager in fact calculate a tag name starting from the
developerConnection and removing from the URL layers based on how
deep the release pom is versus the assumed root. This is hardcoded in:
http://svn.apache.org/viewvc/maven/release/tags/maven-release-2.3.2/maven-release-manager/src/main/java/org/apache/maven/shared/release/util/ReleaseUtil.java?view=markup
Line 182 (this logic is not really specific to 2.3.2 version, but
pretty much in every version).
The tag calculation is fine if applied to SCM live SVN but not to GIT
hence this limitation of having to place the root pom in the root
itself.
- Removed uneeded distributions like sdk and parent, because are
combined in the main distribution.
- Corrected some wrong dependencies in clustering
- Added parent poms to distribution so to simplify the deploy of the
artifacts.
- Disable signing of openflowJ during release, it hangs
- Forcing maven-release-plugin to version 2.3.2, latest today (2.4.1)
has some issues.
- Updated README.OPENDAYLIGHT with process for releasing artifacts
- pom file in the root directory is merely a pointer to the main
distribution, this doesn't change any of the current workflow and
enable release support
- Create a profile triggered when the -DDOBUILDRELEASE is set which
exclude modules that are still depending on snapshots not under
controller project

Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Change-Id: I7d18fd7a5efd5809d3fc77d4e0ddc302296d9d98

7 years agoAdded distribution management to archetypes/ root pom 32/1032/1
Ed Warnicke [Wed, 28 Aug 2013 14:17:09 +0000 (07:17 -0700)]
Added distribution management to archetypes/ root pom

Change-Id: I1424cd3d94a4709e8ece65dbe0aeca3ab730b329
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMerge "Added an archetype odl-model-project"
Giovanni Meo [Wed, 28 Aug 2013 10:24:02 +0000 (10:24 +0000)]
Merge "Added an archetype odl-model-project"

7 years agoAdded CorsFilter to enable secure cross site scripting 31/1031/1
Madhu Venugopal [Wed, 28 Aug 2013 05:26:13 +0000 (22:26 -0700)]
Added CorsFilter to enable secure cross site scripting

This is in addition to Ed's original Cors Filter changes. Default Cors Config
doesnt seem to work in certain scenarios. Added some custom configurations
and also added it per-bundle (started with Flow & i will add it to other bundles
once this is verified).

Also, by default AngularJS like frameworks uses HTTP OPTIONS method to check for
server options and that doesnt carry authentication headers. Hence in order for
the cors to work properly, we have to ignore authentication for OPTIONS method
alone. This is taken care in the web.xml configuration for all the northbound
bundle.

See: http://tomcat.apache.org/tomcat-7.0-doc/config/filter.html#CORS_Filter
And: http://en.wikipedia.org/wiki/Cross-origin_resource_sharing
This is done to allow a web page using javascript to be able to make calls
to our REST APIs even though it does not originate in our domain.

Added CorsFilter bundle in Third Party to bring in the class as a Fragment
on the org.apache.catalina bundle.

Added CorsFilter to the web/root web.xml file so it will be used for
all WebApps.

Fixed the northbound integration tests

Change-Id: I29435c5820613982ef691e03a1d446bc7f958537
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
7 years agoReverting because it caused instability to the northbound, wondering why verify didn... 29/1029/1
Giovanni Meo [Wed, 28 Aug 2013 08:46:55 +0000 (08:46 +0000)]
Reverting because it caused instability to the northbound, wondering why verify didn't catch those.

Revert "Added CorsFilter to enable secure cross site scripting"

This reverts commit 8cbcc63bbb004b50c66ce3c65d0b8d7943c8ffac

Change-Id: I41e292b91dfff6c7ceefe33f92f63c081ca2e499

7 years agoAdded CorsFilter to enable secure cross site scripting 45/945/3
Madhu Venugopal [Wed, 28 Aug 2013 05:26:13 +0000 (22:26 -0700)]
Added CorsFilter to enable secure cross site scripting

This is in addition to Ed's original Cors Filter changes. Default Cors Config
doesnt seem to work in certain scenarios. Added some custom configurations
and also added it per-bundle (started with Flow & i will add it to other bundles
once this is verified).

Also, by default AngularJS like frameworks uses HTTP OPTIONS method to check for
server options and that doesnt carry authentication headers. Hence in order for
the cors to work properly, we have to ignore authentication for OPTIONS method
alone. This is taken care in the web.xml configuration for all the northbound
bundle.

See: http://tomcat.apache.org/tomcat-7.0-doc/config/filter.html#CORS_Filter
And: http://en.wikipedia.org/wiki/Cross-origin_resource_sharing
This is done to allow a web page using javascript to be able to make calls
to our REST APIs even though it does not originate in our domain.

Added CorsFilter bundle in Third Party to bring in the class as a Fragment
on the org.apache.catalina bundle.

Added CorsFilter to the web/root web.xml file so it will be used for
all WebApps.

Change-Id: I5fc6a53f2046816984fab722b841730c0eee396a
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
7 years agoAdded an archetype odl-model-project 28/1028/1
Ed Warnicke [Wed, 28 Aug 2013 05:07:22 +0000 (22:07 -0700)]
Added an archetype odl-model-project

Change-Id: I4b6c14f34a4657a21626285475628c7ab72738d5
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMerge "Add Select all checkbox to all datagrids, remove out port and out vlan columns...
Andrew Kim [Wed, 28 Aug 2013 04:57:36 +0000 (04:57 +0000)]
Merge "Add Select all checkbox to all datagrids, remove out port and out vlan columns from troubleshooting, Change WEB to UI for UI generated requests in audit log Signed-off-by: Sapan Shah <sapshah@cisco.com>"

7 years agoMerge "Misc fix for some error seen during IT and javadoc"
Alessandro Boch [Tue, 27 Aug 2013 20:40:36 +0000 (20:40 +0000)]
Merge "Misc fix for some error seen during IT and javadoc"

7 years agoMerge "On ARPHandler restart Threads are left dangling, very visible in the IT tests"
Alessandro Boch [Tue, 27 Aug 2013 20:39:05 +0000 (20:39 +0000)]
Merge "On ARPHandler restart Threads are left dangling, very visible in the IT tests"

7 years agoMisc fix for some error seen during IT and javadoc 19/1019/2
Giovanni Meo [Thu, 22 Aug 2013 20:56:45 +0000 (22:56 +0200)]
Misc fix for some error seen during IT and javadoc

- Silent StaticRoutingImplementation when thread is interrupted, it can
happen.
- During IT logging bridge complain for a null exception because
unhandled.
- Fix some deprecation warning not really needed and some spellings in
javadocs

Change-Id: Id6daa0560943a52b25fbdd4b8a24624e0254353e
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoOn ARPHandler restart Threads are left dangling, very visible in the IT tests 17/1017/2
Giovanni Meo [Thu, 22 Aug 2013 20:50:57 +0000 (22:50 +0200)]
On ARPHandler restart Threads are left dangling, very visible in the IT tests

- Also added debug logs to trace how the ARP Handler is doing event syncs

Change-Id: I183c1eeb69e737eedd4d7b785cf974e8abd19b75
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoAdd Select all checkbox to all datagrids, remove out port and out vlan columns from... 27/1027/1
Sapan Shah [Tue, 27 Aug 2013 05:18:08 +0000 (22:18 -0700)]
Add Select all checkbox to all datagrids, remove out port and out vlan columns from troubleshooting, Change WEB to UI for UI generated requests in audit log
Signed-off-by: Sapan Shah <sapshah@cisco.com>
Change-Id: I5501698720177e51cfd91127fd9e867823575a44
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoMerge changes I5809ac06,I4362cd4e
Giovanni Meo [Tue, 27 Aug 2013 13:43:00 +0000 (13:43 +0000)]
Merge changes I5809ac06,I4362cd4e

* changes:
  Added Intellij files to gitignore
  Fixed typo and remove unecessary java.lang import

7 years agoAdded Intellij files to gitignore 26/1026/1
Alissa Bonas [Tue, 27 Aug 2013 12:43:32 +0000 (15:43 +0300)]
Added Intellij files to gitignore

Added IntelliJ IDE specific files extensions
to .gitignore.

Change-Id: I5809ac06ab24215c593313ea48a8cb5a937f7593
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoFixed typo and remove unecessary java.lang import 21/1021/1
Alissa Bonas [Tue, 27 Aug 2013 10:29:45 +0000 (13:29 +0300)]
Fixed typo and remove unecessary java.lang import

Fixed typo in comment and remove unecessary java.lang import
(as proposed by Sonar report)

Change-Id: I4362cd4e25965c9a5c9322a5a25e189241599c18
Signed-off-by: Alissa Bonas <abonas@redhat.com>
7 years agoAllow controller to be managed via JMX remotely 91/991/3
Giovanni Meo [Mon, 26 Aug 2013 10:39:05 +0000 (12:39 +0200)]
Allow controller to be managed via JMX remotely

- In order to inspect the controller remotely JMX comes very handy
especially in clustered environment, this patch allow to start the
controller and to enable JMX remotely, this is still only the unsecure
version, for secure version a subsequent patch will be provided

Change-Id: I47c8651f19e4207b37b064161bb88476f3e31d0b
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoFixing a Northbound IT test breakage due to a recent NB change 12/1012/1
Madhu Venugopal [Tue, 27 Aug 2013 03:08:12 +0000 (20:08 -0700)]
Fixing a Northbound IT test breakage due to a recent NB change

Change-Id: I1699413cf7fa6f02b713f72a669c2fc3115c59cd
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
7 years agoMerge "Northbound cleanup for Flow programmer"
Madhu Venugopal [Tue, 27 Aug 2013 02:26:17 +0000 (02:26 +0000)]
Merge "Northbound cleanup for Flow programmer"

7 years agoMerge "Northbound cleanup for static routing"
Madhu Venugopal [Tue, 27 Aug 2013 02:19:01 +0000 (02:19 +0000)]
Merge "Northbound cleanup for static routing"

7 years agoNorthbound cleanup for Flow programmer 02/1002/4
Pramila Singh [Mon, 26 Aug 2013 17:08:22 +0000 (10:08 -0700)]
Northbound cleanup for Flow programmer

Change-Id: I687b3558a4f19a17a0a9ad9247bb25327f4bb676
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoMerge "Cleaup Statistics northbound and add exmaples"
Madhu Venugopal [Tue, 27 Aug 2013 02:14:53 +0000 (02:14 +0000)]
Merge "Cleaup Statistics northbound and add exmaples"

7 years agoNorthbound cleanup for static routing 11/1011/1
Prasanth Pallamreddy [Mon, 26 Aug 2013 23:45:45 +0000 (16:45 -0700)]
Northbound cleanup for static routing

Change-Id: I252c0338780be7eb80d577bbcdfe8455aa171c8c
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
7 years agoCleaup Statistics northbound and add exmaples 01/1001/4
Yevgeny Khodorkovsky [Mon, 26 Aug 2013 22:48:15 +0000 (15:48 -0700)]
Cleaup Statistics northbound and add exmaples

- Clean up stats northbound to align with common REST conventions,
  add more descriptive javadoc with examples

Change-Id: I9508e72b9f62dc576ab4a569f699b75e7bfb29a9
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
7 years agoOpenFLow plugin & SAL API documentation 06/1006/3
Jason Ye [Mon, 26 Aug 2013 17:56:22 +0000 (10:56 -0700)]
OpenFLow plugin & SAL API documentation

Change-Id: I0947e48f4ab52cf61e84973dcc808b10045e3382
Signed-off-by: Jason Ye <yisye@cisco.com>
7 years agoMerge "Fix to remove camel case for Northbound API"
Madhu Venugopal [Mon, 26 Aug 2013 21:14:29 +0000 (21:14 +0000)]
Merge "Fix to remove camel case for Northbound API"

7 years agoFix to remove camel case for Northbound API 99/999/3
Pramila Singh [Mon, 26 Aug 2013 16:50:34 +0000 (09:50 -0700)]
Fix to remove camel case for Northbound API

Change-Id: I2d13e9d53b0d73504c15d32a57207110d70afb3a
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoFix to show Node name if present when adding ports to Subnet Gateway on the devices... 08/1008/2
lakshya [Mon, 26 Aug 2013 18:44:50 +0000 (11:44 -0700)]
Fix to show Node name if present when adding ports to Subnet Gateway on the devices tab.
A minor change from Mac to MAC in nodes learnt popout.

Change-Id: I600a8437d757b72bdaf8f0e5d8ffa624a08c4d2b
Signed-off-by: lakshya <lakshya@cisco.com>
7 years agoFix for NorthboundIT test failure 10/1010/1
Pramila Singh [Mon, 26 Aug 2013 20:36:27 +0000 (13:36 -0700)]
Fix for NorthboundIT test failure

Change-Id: I0d3c2216bf2cdb9ba23b186307ad49b8f2b36184
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoMerge "HostTracker immediately ages out hosts on coordinator"
Madhu Venugopal [Mon, 26 Aug 2013 19:33:07 +0000 (19:33 +0000)]
Merge "HostTracker immediately ages out hosts on coordinator"

7 years agoMerge "Integration of MDSAL into distribution"
Ed Warnicke [Mon, 26 Aug 2013 19:19:18 +0000 (19:19 +0000)]
Merge "Integration of MDSAL into distribution"

7 years agoMerge "Northbound cleanup for Switch Manager"
Madhu Venugopal [Mon, 26 Aug 2013 18:52:42 +0000 (18:52 +0000)]
Merge "Northbound cleanup for Switch Manager"

7 years agoIntegration of MDSAL into distribution 07/1007/1
Tony Tkacik [Mon, 26 Aug 2013 17:27:57 +0000 (12:27 -0500)]
Integration of MDSAL into distribution

- Fixed Class Loader bug in runtime code generator

Change-Id: I8282b16247a9d80d74f8646d2ef56f364c2d349f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoHostTracker immediately ages out hosts on coordinator 05/1005/1
Giovanni Meo [Mon, 26 Aug 2013 17:53:20 +0000 (19:53 +0200)]
HostTracker immediately ages out hosts on coordinator

- Let say an Host 1.1.4.1 is learnt by CTRL2 and CTRL1 is doing
cleanup of the host tracker database, the CTRL1 was cleaning
immediately the hosts learnt on other controllers because the host
count was not serialized appropriately

Change-Id: I1a0542c5e44cf3fc3f33d6fe95d129e83825cc8c
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoMerge "Fixing a bug to show node name if present instead of node id while adding...
Andrew Kim [Mon, 26 Aug 2013 17:11:15 +0000 (17:11 +0000)]
Merge "Fixing a bug to show node name if present instead of node id while adding SPAN ports on the devices page."

7 years agoNorthbound cleanup for Switch Manager 00/1000/1
Pramila Singh [Mon, 26 Aug 2013 17:01:46 +0000 (10:01 -0700)]
Northbound cleanup for Switch Manager

Change-Id: If312264096eeefd0f32c2556fd8387d8a3d7a3de
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoFixing a bug to show node name if present instead of node id while adding 98/998/1
lakshya [Mon, 26 Aug 2013 06:25:28 +0000 (23:25 -0700)]
Fixing a bug to show node name if present instead of node id while adding
SPAN ports on the devices page.

Change-Id: Id9745acec14bb83dd36f2b35f2811cf1706458e1
Signed-off-by: lakshya <lakshya@cisco.com>
7 years agoFixing a minor bug in Cache replace code in Connection Manager. 90/990/1
Madhu Venugopal [Mon, 26 Aug 2013 00:34:05 +0000 (17:34 -0700)]
Fixing a minor bug in Cache replace code in Connection Manager.

Change-Id: Ic885dc0890860abb23b067458353ba16d21b275b
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
7 years agoMerge "Fix Connection manager to retrieve inventory when is up"
Alessandro Boch [Sat, 24 Aug 2013 14:55:22 +0000 (14:55 +0000)]
Merge "Fix Connection manager to retrieve inventory when is up"

7 years agoMerge "Fix Match intersection logic"
Chi-Vien Ly [Sat, 24 Aug 2013 03:30:22 +0000 (03:30 +0000)]
Merge "Fix Match intersection logic"

7 years agoFix Match intersection logic 87/987/1
Alessandro Boch [Sat, 24 Aug 2013 02:43:32 +0000 (19:43 -0700)]
Fix Match intersection logic

    - Change in Match.java: Empty match represents all packets (universal set) while empty set is the null match.
                        So, in case of no intersection, return a null Match.
                            intersect() and getIntersection() optimized in case of universal and empty sets
    - Changes in MatchTest.java to junit the above changes
    - Change in FlowEntry.java: Match.mergewithFilter() is now returning a new Match instance

Change-Id: Idd3ff80d2fbcc11c3f83757268806596b7b2fc50
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoNorthbound cleanup for topology manager 84/984/3
Jason Ye [Fri, 23 Aug 2013 20:49:36 +0000 (13:49 -0700)]
Northbound cleanup for topology manager

Change-Id: I49862df3d3ac616127c82e7622e7c158ca58849e
Signed-off-by: Jason Ye <yisye@cisco.com>
7 years agoMerge "Fixed run.sh to autodetect JAVA_HOME on Mac OS X"
Alessandro Boch [Sat, 24 Aug 2013 00:20:20 +0000 (00:20 +0000)]
Merge "Fixed run.sh to autodetect JAVA_HOME on Mac OS X"

7 years agoMerge "Add intersection methods to Match"
Jason Ye [Fri, 23 Aug 2013 20:43:09 +0000 (20:43 +0000)]
Merge "Add intersection methods to Match"

7 years agoMerge "Delete Multiple flows in a single click"
Andrew Kim [Fri, 23 Aug 2013 17:43:42 +0000 (17:43 +0000)]
Merge "Delete Multiple flows in a single click"

7 years agoMerge "Change nodeconnector string shown on the troubleshoot tab when clicked on...
Andrew Kim [Fri, 23 Aug 2013 17:37:08 +0000 (17:37 +0000)]
Merge "Change nodeconnector string shown on the troubleshoot tab when clicked on ports to show node name if it is available and node id otherwise."

7 years agoDelete Multiple flows in a single click 75/975/2
Sapan Shah [Fri, 23 Aug 2013 07:43:04 +0000 (00:43 -0700)]
Delete Multiple flows in a single click

Change-Id: I0b61799e66e05aed2b7d89cb885f7b29fa032663
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoEnabled classes not in org.opendaylight.controller package to output log. 54/954/3
Hideyuki [Thu, 22 Aug 2013 15:46:05 +0000 (11:46 -0400)]
Enabled classes not in org.opendaylight.controller package to output log.

Change-Id: I85819272500c1f4ed3a5eb3f6580b6aa6aac75d9
Signed-off-by: Hideyuki <h-tai@cd.jp.nec.com>
7 years agoChange nodeconnector string shown on the troubleshoot tab when clicked on ports 73/973/1
lakshya [Fri, 23 Aug 2013 00:42:41 +0000 (17:42 -0700)]
Change nodeconnector string shown on the troubleshoot tab when clicked on ports
to show node name if it is available and node id otherwise.

Change-Id: I7ccb73ac56f963feaf31380ddbd87417c905804e
Signed-off-by: lakshya <lakshya@cisco.com>
7 years agoFixed run.sh to autodetect JAVA_HOME on Mac OS X 71/971/2
Ed Warnicke [Thu, 22 Aug 2013 19:24:39 +0000 (14:24 -0500)]
Fixed run.sh to autodetect JAVA_HOME on Mac OS X

Change-Id: I3043d19a90f90258883a870d65acd8c26698e3e1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoAdd intersection methods to Match 69/969/2
Alessandro Boch [Thu, 22 Aug 2013 16:57:50 +0000 (09:57 -0700)]
Add intersection methods to Match

- Add method to test and get intersection of two Match objects and correspondent Junit
- Fixed bug in NetUtils.inetAddressConflict()
- Made Match.toString() less verbose

Change-Id: I46cb93f7fc1a46aaaf3a3c341477166d8c1c8822
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix Connection manager to retrieve inventory when is up 76/976/1
Giovanni Meo [Thu, 22 Aug 2013 20:53:26 +0000 (22:53 +0200)]
Fix Connection manager to retrieve inventory when is up

When ConnectionManager comes up, it's very much possible that may have
missed some inventory updates, so it needs to retrieve them to make
sure holes are covered, this is seen during integration test with the
stub protocol plugin, hence also make sure stub protocol plugin
provides the necessary hooks.

Change-Id: I41d5c71dd70aad909f7a75e0f596ec69a212400c
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoAdded startImpl to provide BundleContext to providers 66/966/1
Tony Tkacik [Thu, 22 Aug 2013 15:23:37 +0000 (17:23 +0200)]
Added startImpl to provide BundleContext to providers

Change-Id: Id92b7c469ffa6da22745854fc5d58862f232d6a2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoFixed reference to missing file. 58/958/1
Tony Tkacik [Thu, 22 Aug 2013 09:42:35 +0000 (11:42 +0200)]
Fixed reference to missing file.

Change-Id: Ib87d4a207c8604d7fefc9b7587434121768b6f1c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoMerge "Added distributionManagement section to md-sal parent pom."
Chi-Vien Ly [Thu, 22 Aug 2013 04:01:54 +0000 (04:01 +0000)]
Merge "Added distributionManagement section to md-sal parent pom."

7 years agoMerge "1. Controller switchEvents queue should be priority based. The queue holds...
Chi-Vien Ly [Thu, 22 Aug 2013 03:53:25 +0000 (03:53 +0000)]
Merge "1. Controller switchEvents queue should be priority based. The queue holds switch up, down, error and message events. Assign higher priority to switch up/down events. 2. When switch is going to disconnect, SwitchHandler can clean up some internal states to speed up the process in order to avoid unnecessary messages backing up in the queue. 3. In SwitchManager, don't send additional port down notifications after node down event is received. 4. Fixed an issue where links are not recovered when the switch is reconnected to the controller. 5. Fixed TLS exception@java.security.ProviderException."

7 years agoAdded distributionManagement section to md-sal parent pom. 51/951/1
Ed Warnicke [Thu, 22 Aug 2013 03:37:35 +0000 (22:37 -0500)]
Added distributionManagement section to md-sal parent pom.

Change-Id: I553acfa7476e88a389002b3a3a864ded9e3ba3ac
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoMerge "Minor correction to UI element"
Andrew Kim [Wed, 21 Aug 2013 23:52:12 +0000 (23:52 +0000)]
Merge "Minor correction to UI element"

7 years agoMerge "Enhancements to common.northbound"
Andrew Kim [Wed, 21 Aug 2013 23:45:57 +0000 (23:45 +0000)]
Merge "Enhancements to common.northbound"

7 years agoMinor correction to UI element 31/931/2
Andrew Kim [Wed, 21 Aug 2013 03:42:10 +0000 (22:42 -0500)]
Minor correction to UI element

Change-Id: I4fab95bdf8d9fa73c53c9ee6d7dd9a52961cae6e
Signed-off-by: Andrew Kim <andrekim@cisco.com>
7 years agoMerge "Frm to install/uninstall flow when port is added/removed from slice"
Alessandro Boch [Wed, 21 Aug 2013 23:09:20 +0000 (23:09 +0000)]
Merge "Frm to install/uninstall flow when port is added/removed from slice"

7 years agoFix for JS error on Flows tab. 50/950/1
lakshya [Wed, 21 Aug 2013 22:44:27 +0000 (15:44 -0700)]
Fix for JS error on Flows tab.
This fixes the JS error "TypeError: $span.data(...) is null" on the flows tab by introducing a null check.

Change-Id: Ibbf2141bdca83b445e0d5d162cfe8a3e9a1fe9a0
Signed-off-by: lakshya <lakshya@cisco.com>
7 years ago1. Controller switchEvents queue should be priority based. The queue holds switch... 49/949/1
Jason Ye [Wed, 21 Aug 2013 20:44:44 +0000 (13:44 -0700)]
1. Controller switchEvents queue should be priority based. The queue holds switch up, down, error and message events. Assign higher priority to switch up/down events.
2. When switch is going to disconnect, SwitchHandler can clean up some internal states to speed up the process in order to avoid unnecessary messages backing up in the queue.
3. In SwitchManager, don't send additional port down notifications after node down event is received.
4. Fixed an issue where links are not recovered when the switch is reconnected to the controller.
5. Fixed TLS exception@java.security.ProviderException.

Change-Id: I4ba190a59f8d046df999401572d3c6822b15429b
Signed-off-by: Jason Ye <yisye@cisco.com>
7 years agoIncrease the number of rows per page to 10 for a popout. 47/947/1
lakshya [Wed, 21 Aug 2013 20:20:43 +0000 (13:20 -0700)]
Increase the number of rows per page to 10 for a popout.

Change-Id: Ia516bc3f76b7e03ecd302c006cda2bc8662fe8f5
Signed-off-by: lakshya <lakshya@cisco.com>
7 years agoFrm to install/uninstall flow when port is added/removed from slice 30/930/1
Diti Bhatia [Wed, 21 Aug 2013 00:13:50 +0000 (17:13 -0700)]
Frm to install/uninstall flow when port is added/removed from slice

Change-Id: I462545382e55f480f7bdc1c5084e0c09907a8a8f
Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
7 years agoEnhancements to common.northbound 29/929/2
Alessandro Boch [Tue, 20 Aug 2013 23:36:45 +0000 (16:36 -0700)]
Enhancements to common.northbound

- Added BadRequest and NotImplemented exceptions

Change-Id: I9a021ddd103c16122c39626e9cca044bd8a33ea6
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMerge "Added YANG models for flow configuration, statistics and inventory."
Ed Warnicke [Tue, 20 Aug 2013 15:52:55 +0000 (15:52 +0000)]
Merge "Added YANG models for flow configuration, statistics and inventory."

7 years agoMerge "Fix for hosttracker. Ignore ARP messages from internal nodes."
Giovanni Meo [Tue, 20 Aug 2013 06:53:55 +0000 (06:53 +0000)]
Merge "Fix for hosttracker.  Ignore ARP messages from internal nodes."

7 years agoAdded YANG models for flow configuration, statistics and inventory. 12/912/1
Tony Tkacik [Mon, 19 Aug 2013 18:37:51 +0000 (20:37 +0200)]
Added YANG models for flow configuration, statistics and inventory.

Added AbstractBindingAwareConsumer and Provider, updated samples.

Change-Id: I72a8707b7e0b4e97d11d9f6f4288f0656d0840e0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoFRM to expose list of installed flow entries per group 09/909/1
Alessandro Boch [Mon, 19 Aug 2013 16:12:53 +0000 (09:12 -0700)]
FRM to expose list of installed flow entries per group

    ISSUE:
    Given a group/policy name, ForwardingRulesManager only provides a function to return the list of Flow Entry it was requested to install.
    In presence of container flows, this list does not represent the actual entries which were installed on the network nodes for that group.
    CHANGE:
    Add getInstalledFlowEntriesForGroup(String policyName) to IForwardingRulesManager.

Change-Id: Ie26d64c05d5eb49b3073d34d701ea1fa5b05adfa
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix bug in Static Route configuration path 83/883/2
Alessandro Boch [Thu, 15 Aug 2013 16:36:38 +0000 (09:36 -0700)]
Fix bug in Static Route configuration path

ISSUE: Multiple equivalent static route configurations with different names not detected
CHANGE: In addStaticRoute() perform proper equality check on existing StaticRoute objects
        (using available StaticRoute compareTo() method) instead of checking on StaticRouteConfig
        objects which can never be positive as same name config is detected at the beginning of method

Change-Id: I51d2e1a641f612f5e79eb11063a868739a275209
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix: Switch manager should clean the nodeconnector info when a switch disconnects 85/885/2
Pramila Singh [Thu, 15 Aug 2013 22:06:15 +0000 (15:06 -0700)]
Fix: Switch manager should clean the nodeconnector info when a switch disconnects

Change-Id: I2ccdf1a6d2ed38e1e78242ae99d9bb1711f20040
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoDefault network admin password change is not persistent across controller restart 87/887/3
Alessandro Boch [Thu, 15 Aug 2013 23:47:45 +0000 (16:47 -0700)]
Default network admin password change is not persistent across controller restart

ISSUE: Change default network admin (NA) user password, save config, restart controller.
       To be able to login as default NA user you still have to type the default password.
       This happens because when parsing startup configuration user config addition are replayed
       through public API which has a check to block addiiton/removal of default NA user.

CHANGES:
- Perform checks in a middle layer function and have a internal level function which just update the db
- Call the internal function during startup config replay
- Added missing checks on presence/conflict of user configs when removing/adding a user config object

Change-Id: I38c98bb946b42215cec46d86d3b1a9885c12795b
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix for hosttracker. Ignore ARP messages from internal nodes. 96/896/1
Katrina LaCurts [Fri, 16 Aug 2013 20:30:41 +0000 (16:30 -0400)]
Fix for hosttracker.  Ignore ARP messages from internal nodes.

Signed-off-by: Katrina LaCurts <katrina.lacurts@plexxi.com>
Change-Id: I2030822045b7dc8bd1d013cf5dfcd4898f5ddc32

7 years agoMerge "Migrating caches to TRANSACTIONAL Caches and enabled use1PcForAutoCommitTransa...
Giovanni Meo [Fri, 16 Aug 2013 16:04:08 +0000 (16:04 +0000)]
Merge "Migrating caches to TRANSACTIONAL Caches and enabled use1PcForAutoCommitTransactions. In addition, - Removed all the unused Caches (especially the save event cache). - Changed ARP Handler's ICacheUpdateAware processing to not process the cache event   in its own thread (instead of the infinispan's thread)."

7 years agoMerge "Devices dashlet show port total numbers, modal shows collapsible list Replaced...
Andrew Kim [Fri, 16 Aug 2013 15:33:46 +0000 (15:33 +0000)]
Merge "Devices dashlet show port total numbers, modal shows collapsible list Replaced Tabs with white space"

7 years agoMigrating caches to TRANSACTIONAL Caches and enabled use1PcForAutoCommitTransactions. 94/894/1
Madhu Venugopal [Fri, 16 Aug 2013 14:26:28 +0000 (07:26 -0700)]
Migrating caches to TRANSACTIONAL Caches and enabled use1PcForAutoCommitTransactions.
In addition,
- Removed all the unused Caches (especially the save event cache).
- Changed ARP Handler's ICacheUpdateAware processing to not process the cache event
  in its own thread (instead of the infinispan's thread).

Change-Id: I608aecd425d0394ba9c4e665424c82790bb874ca
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
7 years agoMerge changes I8293baab,I63e248bd
Ed Warnicke [Fri, 16 Aug 2013 12:41:08 +0000 (12:41 +0000)]
Merge changes I8293baab,I63e248bd

* changes:
  Added sample provider and consumer for MD SAL
  Clean up of binding broker implementation

7 years agoDevices dashlet show port total numbers, modal shows collapsible list 89/889/2
Sapan Shah [Fri, 16 Aug 2013 04:45:53 +0000 (21:45 -0700)]
Devices dashlet show port total numbers, modal shows collapsible list
Replaced Tabs with white space

Change-Id: I9a8ede6a761e4d46fb1dcaa90ddffb46822e5e79
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoChange HostTracker's ArrayLists to ConcurrentMaps. Add new CLIs 86/886/2
Maurice Qureshi [Thu, 15 Aug 2013 22:43:06 +0000 (15:43 -0700)]
Change HostTracker's ArrayLists to ConcurrentMaps. Add new CLIs

1)Initially some data structures were used which were used ony in main thread. As the code has
evolved, those data structures are being accessed in multiple threads now. Therefore
changed two ArrayList to ConcurrentMaps

2) Changed the name of Caches in consistent with other modules "hosttracker.activeHosts" and "hosttracker.InactiveHosts"

3) Added New CLIs to dump couple of data structures

Change-Id: I06b68e4e559b0193ec502612d6ea29c634bd9a81
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
7 years agoConverting tables in flow and troubleshoot to use datagrid. 84/884/1
lakshya [Thu, 15 Aug 2013 21:06:44 +0000 (14:06 -0700)]
Converting tables in flow and troubleshoot to use datagrid.

Change-Id: I70c69ef9f2e5204ad47caa41e7d0ba3b2603c0f1
Signed-off-by: lakshya <lakshya@cisco.com>
7 years agoDevices: NodesLearnt table integration with FuelUx Datagrid. 78/878/3
lakshya [Mon, 12 Aug 2013 06:40:34 +0000 (23:40 -0700)]
Devices: NodesLearnt table integration with FuelUx Datagrid.
Removed glyph-icons + added fuelux copyright information.

Change-Id: If0844a9df414d92e01c6d2cd72942c054784f959
Signed-off-by: lakshya <lakshya@cisco.com>
7 years agoMerge "Should not allow nodes to have same node name"
Alessandro Boch [Wed, 14 Aug 2013 17:12:41 +0000 (17:12 +0000)]
Merge "Should not allow nodes to have same node name"

7 years agoMerge "Fixed NullPointerException seen in Hosttracker when fetching the hierarchy...
Giovanni Meo [Wed, 14 Aug 2013 13:24:53 +0000 (13:24 +0000)]
Merge "Fixed NullPointerException seen in Hosttracker when fetching the hierarchy of host"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.