controller.git
6 years agoMerge "CHange log level from warn to debug in ProtocolSessionPromise when connection...
Tony Tkacik [Mon, 17 Feb 2014 16:31:35 +0000 (16:31 +0000)]
Merge "CHange log level from warn to debug in ProtocolSessionPromise when connection attempt fails"

6 years agoMerge changes I393151af,I0a302cde
Tony Tkacik [Mon, 17 Feb 2014 16:30:03 +0000 (16:30 +0000)]
Merge changes I393151af,I0a302cde

* changes:
  Fix unused field warnings
  Fix warnings about overriden versions

6 years agoMerge "Add support for multiple choice case statements within one augument in config...
Tony Tkacik [Mon, 17 Feb 2014 16:28:11 +0000 (16:28 +0000)]
Merge "Add support for multiple choice case statements within one augument in config yang files"

6 years agoMerge "Fix namespaces for netconf monitoring extensions."
Tony Tkacik [Mon, 17 Feb 2014 16:19:09 +0000 (16:19 +0000)]
Merge "Fix namespaces for netconf monitoring extensions."

6 years agoFix typo in switchmanager log message in word 'available' 66/5366/1
Alissa Bonas [Mon, 17 Feb 2014 12:49:20 +0000 (14:49 +0200)]
Fix typo in switchmanager log message in word 'available'

Change-Id: I97bd3d69109b9fec460793758f9a56459a5226b0
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoFix unused field warnings 57/5357/2
Robert Varga [Sun, 16 Feb 2014 11:22:03 +0000 (12:22 +0100)]
Fix unused field warnings

Removes affected fields, add @Override annotations and make constant
fields final.

Change-Id: I393151af1459e31eeded0786cf32223068635172
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings about overriden versions 56/5356/2
Robert Varga [Sun, 16 Feb 2014 11:03:08 +0000 (12:03 +0100)]
Fix warnings about overriden versions

With proper parent structure, version overrides should not be present.

Change-Id: I0a302cde1c619af76f9290f7e5ca5080ff4fe251
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix namespaces for netconf monitoring extensions. 53/5253/6
Maros Marsalek [Tue, 11 Feb 2014 10:13:02 +0000 (11:13 +0100)]
Fix namespaces for netconf monitoring extensions.

Change-Id: Ib191dbcb121ead95db65263b4b478b8eac64c004
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoCleanup warnings 55/5355/2
Robert Varga [Sun, 16 Feb 2014 10:22:45 +0000 (11:22 +0100)]
Cleanup warnings

Change-Id: I26d45b3f3856ddd893b54089521b5366deb34db3
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Serializable classes should have serialVersionUID"
Tony Tkacik [Mon, 17 Feb 2014 09:57:38 +0000 (09:57 +0000)]
Merge "Serializable classes should have serialVersionUID"

6 years agoMerge "Do not access static methods through object instances"
Tony Tkacik [Mon, 17 Feb 2014 09:56:36 +0000 (09:56 +0000)]
Merge "Do not access static methods through object instances"

6 years agoMerge "Add a bit of documentation"
Tony Tkacik [Mon, 17 Feb 2014 08:54:30 +0000 (08:54 +0000)]
Merge "Add a bit of documentation"

6 years agoSerializable classes should have serialVersionUID 54/5354/1
Robert Varga [Sun, 16 Feb 2014 09:56:01 +0000 (10:56 +0100)]
Serializable classes should have serialVersionUID

Change-Id: I3b7e3270202275a6bc08617957f78ee969d3ac70
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDo not access static methods through object instances 53/5353/1
Robert Varga [Sun, 16 Feb 2014 09:48:01 +0000 (10:48 +0100)]
Do not access static methods through object instances

Stops eclipse from complaining.

Change-Id: I153b651068cceb8263f2f4a8ea65b8de45a1ba50
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd a bit of documentation 47/5347/1
Robert Varga [Sat, 15 Feb 2014 06:05:11 +0000 (07:05 +0100)]
Add a bit of documentation

Change-Id: I57883cffb62f4f22de74d567f9d040a90e21a5d0
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDisconnect node statistics tracking 46/5346/1
Robert Varga [Sat, 15 Feb 2014 06:36:09 +0000 (07:36 +0100)]
Disconnect node statistics tracking

This patch moves scheduling into the node handlers themselves. This
should allow for spreading out of the statistics collection, preventing
spikes. Additionally delay the initial collection by up to 5 seconds to
deal with multiple switches connecting at the same time.

Change-Id: I6ea039b405595b3756263bddd9cf8997bc73a038
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoHandle openflowplugin returning null 45/5345/1
Robert Varga [Sat, 15 Feb 2014 02:17:36 +0000 (03:17 +0100)]
Handle openflowplugin returning null

It turns out that openflow plugin reports success with null transaction
ID if the switch does not support a feature. This is quite bad, but we
can recover rather easily. Rework the registration contract to take care
of the changes.

Change-Id: I62fe7badeb5d792c8533762f5e68b7d37811f8ed
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDetect RPC failures 42/5342/1
Robert Varga [Sat, 15 Feb 2014 02:17:36 +0000 (03:17 +0100)]
Detect RPC failures

This detects when RPCs to stats services fail. Also it removes the enums
used only for legacy debug.

Change-Id: Id4eb348b92378735a143b799b4c97b9840766ff6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Move queue/meter/flow listeners into their trackers"
Tony Tkacik [Sat, 15 Feb 2014 03:52:52 +0000 (03:52 +0000)]
Merge "Move queue/meter/flow listeners into their trackers"

6 years agoMerge "Move statistics request functions into trackers"
Tony Tkacik [Sat, 15 Feb 2014 03:26:48 +0000 (03:26 +0000)]
Merge "Move statistics request functions into trackers"

6 years agoMerge "Bug fixes for netconf southbound plugin."
Tony Tkacik [Sat, 15 Feb 2014 03:25:14 +0000 (03:25 +0000)]
Merge "Bug fixes for netconf southbound plugin."

6 years agoMove queue/meter/flow listeners into their trackers 35/5335/3
Robert Varga [Fri, 14 Feb 2014 19:24:40 +0000 (20:24 +0100)]
Move queue/meter/flow listeners into their trackers

This completes the move of triggers under a per-node registration. With
this structure we should have a complete control of what should be going
on for a switch.

Change-Id: Ia35c925947e044ff826c1f2560c040fe696aaed0
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMove statistics request functions into trackers 23/5323/5
Robert Varga [Fri, 14 Feb 2014 19:24:05 +0000 (20:24 +0100)]
Move statistics request functions into trackers

This moves the gory details of specific requests into their respective
trackers. It also makes the request pipeline asynchronous.

Change-Id: I56ad175bc75b1af18263ae294cb3ffc118557abd
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMove statistics request methods into NodeStatisticsHandler 22/5322/3
Robert Varga [Fri, 14 Feb 2014 01:42:01 +0000 (02:42 +0100)]
Move statistics request methods into NodeStatisticsHandler

This move make sure we route all requests through a particular node
handler, so it now sees which stats are actually requested for a
particular node.

This means that MultipartMessageManager can use a simple map, as all
operations are now protected by the NodeStatisticsHandler's lock.

Current code organization now allows the individual statistics request
methods to be moved into individual trackers.

Change-Id: Iebd53d6dd447db7ab684cd2c6a90d9abf1b0e91e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMove MultipartMessageManager into NodeStatisticsHandler 21/5321/3
Robert Varga [Thu, 13 Feb 2014 22:37:20 +0000 (23:37 +0100)]
Move MultipartMessageManager into NodeStatisticsHandler

There is no reason to have a global manager, now each
NodeStatisticsHandler instantiates its own manager -- thus the nodeId
in its tables has no point. This has the added value of being protected
by the NodeStatisticsHandler lock, thus we are prepared to having a
completely consistent view of what operations are really expected even
when switches flap.

Change-Id: I4ca63982506c6f290967040d5626400cb0a0996e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoSplit out statistics tracking into separate classes 12/5312/4
Robert Varga [Thu, 13 Feb 2014 18:45:13 +0000 (19:45 +0100)]
Split out statistics tracking into separate classes

- FlowStats
- FlowTableStats
- GroupDescStats
- GroupStats
- MeterConfigStats
- MeterStats
- NodeConnectorStats
- QueueStats

are all now tracked by dedicated classes. Also create a dedicated
QueueStatsEntry and FlowStatsEntry class.

Furthermore the flow walking code is modified to stop searching as soon
as it finds a matching flow.

Change-Id: Ia2bacb12f9c0af6520c115c161388b72a846b062
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd proxies for statistics getters 11/5311/3
Robert Varga [Thu, 13 Feb 2014 08:33:28 +0000 (09:33 +0100)]
Add proxies for statistics getters

This is a simple unification of stats collection triggers so they are
centered about their per-node collector.

Change-Id: Iaf63d782b58b84ed3270b9215587f96f93aab3cc
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoUse a single Timer instead of two threads 00/5300/4
Robert Varga [Thu, 13 Feb 2014 07:45:36 +0000 (08:45 +0100)]
Use a single Timer instead of two threads

It turns out that we really want to have the aging and collection bound
to a common timeline, so let's combine them. This will give us the
opportunity to perform mark&sweep in future.

Furthermore we use the threads only for periodic tasks, so let's convert
to a Timer with TimerTasks. This will allow us more flexibility going
forward, for example allowing NodeStatisticsHandlers to manage how often
they wish to collect individual statistics.

Change-Id: Ie2cd0e4e7391e1175a8927773f85278b80f16c48
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoStart rework of MultipartMessageManager 99/5299/4
Robert Varga [Thu, 13 Feb 2014 07:00:13 +0000 (08:00 +0100)]
Start rework of MultipartMessageManager

- TxIdEntry should be private static final
- Remove unused method
- Use System.nanoTime() for timekeeping

Change-Id: I51bf99082aadeb1f83055a0bf6a07e320c089db0
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCentralize targetNodeRef in the NodeStatisticsHandler 98/5298/7
Robert Varga [Thu, 13 Feb 2014 03:41:07 +0000 (04:41 +0100)]
Centralize targetNodeRef in the NodeStatisticsHandler

There's no reason to allocate it over and over again, we will be using
for a long time. Also push the DataProviderService into
NodeStatisticsHandler such that we do not have circular references.

Change-Id: I1e2444644a27516c87ca93d386f5dc2ac334ffaf
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoKeep track of the tables we discover 97/5297/6
Robert Varga [Thu, 13 Feb 2014 03:23:54 +0000 (04:23 +0100)]
Keep track of the tables we discover

NodeStatisticsHandler has always the most uptodate information about
which tables were discovered. Let's cache the table IDs -- we will
need them for sending out follow-up requests.

And now that we do that, we do not have to read the tables from
DataProviderService just to get the keys -- use whatever we cached.

Change-Id: I9550ae3330215277d373ec0b2ea67945ef0e7c5c
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Walk the tables directly"
Tony Tkacik [Sat, 15 Feb 2014 01:38:51 +0000 (01:38 +0000)]
Merge "Walk the tables directly"

6 years agoMerge "Do not rely od DataStore for all connected nodes"
Tony Tkacik [Sat, 15 Feb 2014 01:37:07 +0000 (01:37 +0000)]
Merge "Do not rely od DataStore for all connected nodes"

6 years agoMerge "Split off tracking of node presence"
Tony Tkacik [Sat, 15 Feb 2014 01:36:41 +0000 (01:36 +0000)]
Merge "Split off tracking of node presence"

6 years agoMerge "Fix issue where NodeConnector ADDED events were propagated as NodeConnector...
Tony Tkacik [Sat, 15 Feb 2014 01:32:32 +0000 (01:32 +0000)]
Merge "Fix issue where NodeConnector ADDED events were propagated as NodeConnector CHANGED events"

6 years agoBug fixes for netconf southbound plugin. 22/5222/5
Lukas Sedlak [Mon, 10 Feb 2014 07:15:51 +0000 (23:15 -0800)]
Bug fixes for netconf southbound plugin.

Fixed wrong operation type sending in edit-config for netconf device. Action type replaced for "operation" type.
Fixed conversion of toRpcMessage in NetconfMapping. Fixed wrong QName - changed from "action" to "operation".

Change-Id: Ic9e07dfc2bdb50552321754cb92333ef88aa14bb
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoMerge "Changing SimpleBroadcastHandler so that it's disabled by default to fix stabil...
Alessandro Boch [Fri, 14 Feb 2014 22:33:16 +0000 (22:33 +0000)]
Merge "Changing SimpleBroadcastHandler so that it's disabled by default to fix stability issues with >10 switches."

6 years agoSwitch Manager should ignore redundant updates 29/5329/3
Yevgeny Khodorkovsky [Wed, 12 Feb 2014 18:04:41 +0000 (10:04 -0800)]
Switch Manager should ignore redundant updates

- Redundant node and node connector updates (such as in the case of
  cluster switchover) should not be notified to apps/listeners, to avoid expensive tasks

Change-Id: Ia541bdcba6b53170c7a6c29e2c35f1b7b8104d60
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoMerge "Fixed bug when RPC was not propagared"
Tony Tkacik [Fri, 14 Feb 2014 22:06:04 +0000 (22:06 +0000)]
Merge "Fixed bug when RPC was not propagared"

6 years agoChanging SimpleBroadcastHandler so that it's disabled by default to fix stability... 36/5336/1
Colin Dixon [Fri, 14 Feb 2014 21:37:04 +0000 (15:37 -0600)]
Changing SimpleBroadcastHandler so that it's disabled by default to fix stability issues with >10 switches.

Change-Id: I6ac1c15e431760c97348bc466a9783f25f6d9fee
Signed-off-by: Colin Dixon <ckd@us.ibm.com>
6 years agoFix for container directory creation/deletion in startup without saving config 38/5238/7
Diti Bhatia [Fri, 14 Feb 2014 21:42:42 +0000 (13:42 -0800)]
Fix for container directory creation/deletion in startup without saving config

Change-Id: I423e7c3ab186af5ea5bd0ab6d42553b4f988e82f
Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
6 years agoWalk the tables directly 96/5296/5
Robert Varga [Thu, 13 Feb 2014 02:52:54 +0000 (03:52 +0100)]
Walk the tables directly

This inlines a function with a single caller, such that we do not have
to create an interim list. This allows us to know the call site which
needs to know about tables.

Change-Id: I530233bd3ec8e85417a3b9efa878c80b683ce5ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDo not rely od DataStore for all connected nodes 92/5292/5
Robert Varga [Thu, 13 Feb 2014 02:27:26 +0000 (03:27 +0100)]
Do not rely od DataStore for all connected nodes

Now that we track all connected flow-capable nodes we do need to go and
read all nodes just to find them. Just look at which handlers are
currently created.

Change-Id: I1a33b53399d0de0e2cdbdbd90512a09933d127c8
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoSplit off tracking of node presence 90/5290/6
Robert Varga [Thu, 13 Feb 2014 02:03:13 +0000 (03:03 +0100)]
Split off tracking of node presence

Introducing FlowCapableTracker. It's sole responsibility is to react
to FlowCapableNodes appearing and disappearing in the inventory and
spinning up statistics handlers based on that. This makes the
NodeStatisticsHandler lifecycle more predictable, thus we can activate
the 'ignore' part of the getStatisticsHandler(). Final part limits the
visibility of the various 'getFooStats' methods, so we can reason about
them better.

Change-Id: Icdbcca6038ae7fb0bff06d378fafa0f476f0fe18
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFixed bug when RPC was not propagared 15/5315/2
Abhishek Kumar [Fri, 14 Feb 2014 00:20:35 +0000 (16:20 -0800)]
Fixed bug when RPC was not propagared

 - Fixed DOM Broker and BI Connector code
 - The refactoring was done so that DOM Broker does not get exposed to
 - BA Broker directly but rather through a proxy. This also fixes the
   issue where DOM Broker would not be initialized in BI Connector, therefore
   any messages from BA Broker would not flow to DOM Broker via BI Connector.

Change-Id: Ia25a71787857c8d052a5dbd40e8237015d8c4d63
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoMerge "Fixed bug when Binding-Aware Data Change Listeners we're not triggered."
Ed Warnicke [Fri, 14 Feb 2014 15:36:23 +0000 (15:36 +0000)]
Merge "Fixed bug when Binding-Aware Data Change Listeners we're not triggered."

6 years agoLimit visibility of FlowEntry 91/5291/4
Robert Varga [Thu, 13 Feb 2014 02:26:08 +0000 (03:26 +0100)]
Limit visibility of FlowEntry

This class is no longer needed to be visible. Make it private and
static.

Change-Id: I30c612fca44aa993f29922fb1465ecdb16ea50c5
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFixed bug when Binding-Aware Data Change Listeners we're not triggered. 20/5320/3
Tony Tkacik [Fri, 14 Feb 2014 05:10:59 +0000 (06:10 +0100)]
Fixed bug when Binding-Aware Data Change Listeners we're not triggered.

  - Added additional strategy to inspect changes based on registered listeners
  - Fixed normalization of data for changes where parent node was written
      - Extracts data for listener, so listener does not need to
        extract that data manually
  - Splitted AbstractDataBroker.xtend into several classes

Change-Id: I7e5d1d759c40519d164b08678a9dc22743d329bb
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoFix issue where NodeConnector ADDED events were propagated as NodeConnector CHANGED... 41/5241/6
Moiz Raja [Tue, 11 Feb 2014 03:23:50 +0000 (19:23 -0800)]
Fix issue where NodeConnector ADDED events were propagated as NodeConnector CHANGED events

Note that this is an interim fix which will work only in a non-clustered setup

The major part of this fix is coded in InventoryAndReadAdapter. The fix is as follows when a NodeConnectorChanged
event is received by the InventoryAdapter it first checks whether this node connector has ever been seen before by
it. It does this by looking at a Map of Nodes to NodeConnectors that it maintains. If the Node Connector is not found
in the Map then this must be a NodeConnector ADDED notification otherwise it is a NodeConnector CHANGED notification.

This commit also contains some code for what would be the ideal fix - one that would work in a cluster scenario as well
That code is in InventoryNotificationProvider and NodeConnectorDataChangeListener. The fix in there works like this. We set
up a DataChangeListener on the MD-SAL DataProvider Service which would notify us whenever a NodeConnector is added, modified
or removed. When the change event comes in depending on whether the node connector was added or modified the data change
listener fires the ADDED or CHANGED event. This fix is disabled for now till another issue with MD-SAL regarding removal
of nodes on mininet exit (or switch disconnect) is resolved.

There are some other changes in the FlowProgrammerAdapter which basically suppress some error conditions when a flow that is
being removed or modified does not exist in the cache that the FlowProgrammerAdapter maintains to translate between AD-SAL and
MD-SAL flows.

This fix allows pingall to work with upto 32 switches - after that other issues prevent testing with more switches.

Change-Id: Ide2e6e85191856a8c6a9746b2397605905938d56
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Fix for Bug 403: Install button does not work correctly first time if flow...
Andrew Kim [Thu, 13 Feb 2014 17:10:26 +0000 (17:10 +0000)]
Merge "Fix for Bug 403: Install button does not work correctly first time if flow is edited in UI."

6 years agoremoved obsolete config yang and RuntimeGeneratedMappingService 06/5306/2
Martin Bobak [Thu, 13 Feb 2014 14:48:42 +0000 (15:48 +0100)]
removed obsolete config yang and RuntimeGeneratedMappingService

Change-Id: I86c721ecce6132bd545778fe9a7380684c53c8f8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
6 years agoMerge "Refactor Additional header for netconf hello message."
Ed Warnicke [Thu, 13 Feb 2014 11:44:11 +0000 (11:44 +0000)]
Merge "Refactor Additional header for netconf hello message."

6 years agoMerge "sal-restconf-broker initial implementation needs https://git.opendaylight...
Ed Warnicke [Thu, 13 Feb 2014 11:31:25 +0000 (11:31 +0000)]
Merge "sal-restconf-broker initial implementation  needs https://git.opendaylight.org/gerrit/#/c/5259/  and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for  successful build"

6 years agoFix for Bug 403: Install button does not work correctly first time if flow is edited... 02/5302/2
deepankar [Thu, 13 Feb 2014 08:55:34 +0000 (14:25 +0530)]
Fix for Bug 403: Install button does not work correctly first time if flow is edited in UI.

Root Cause: Whenever user edits a flow entry, page.js file passes the value of installInHw as true always (line ). If the flow is not installed in the hardware, this reverts the value of installInHw from false to true causing this issue.

Fix: Changes Done:
1. In page.js file, On edit click button a new variable install is defined, which is assigned to the value of installInHw(true/false) in respect to a flow entry.
2. The variable install is passed to the edit function instead of passing the value as true always

Change-Id: I4e0df2a3061d165b8ab534dff44d4c196e7d9872
Signed-off-by: deepankar <deepankar.gupta@tcs.com>
6 years agoRefactor Additional header for netconf hello message. 63/5263/3
Maros Marsalek [Tue, 11 Feb 2014 17:19:42 +0000 (18:19 +0100)]
Refactor Additional header for netconf hello message.

Allow additional header only for hello messages.
Introduce customized (en|decoders) for hello message to parse/serialize additional header.
These handlers are replaced after successful negotiation.

Change-Id: I54c441bc166e7141f503888f0eb1934882971045
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoCHange log level from warn to debug in ProtocolSessionPromise when connection attempt... 01/5301/1
Maros Marsalek [Thu, 13 Feb 2014 08:32:24 +0000 (09:32 +0100)]
CHange log level from warn to debug in ProtocolSessionPromise when connection attempt fails

Change-Id: I933bb145fb8dfda19a98c60cda108da078eb93e5
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Increase SSL input buffer size to accommodate large number of flows"
Chi-Vien Ly [Thu, 13 Feb 2014 07:17:11 +0000 (07:17 +0000)]
Merge "Increase SSL input buffer size to accommodate large number of flows"

6 years agoCompress removals into a single transaction 78/5278/2
Robert Varga [Wed, 12 Feb 2014 02:34:26 +0000 (03:34 +0100)]
Compress removals into a single transaction

When node removal occurs, do not cascade into multiple transactions, but
trigger only a single one.

Change-Id: Ic9994e6a801953efdf83a707be3b821f9a93b35b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRename NodeStatisticsAger and StatisticsUpdateCommiter 77/5277/2
Robert Varga [Wed, 12 Feb 2014 02:16:40 +0000 (03:16 +0100)]
Rename NodeStatisticsAger and StatisticsUpdateCommiter

The component's responsibilities have changed, rename them to reflect
this change. The new division of responsibilities is:

There is a single StatisticsListener listens for notifications
carrying the statistics data and routes them towards the appropriate
NodeStatisticsHandler. Once MD-SAL is able to route notifications based
on key, this class should be completely removed.

There are per-node NodeStatisticsHandlers, each of which is responsible
for taking care of lifecycle of statistics for a particular node.

Change-Id: I16d7a1f353a1f484db11da1e5edc97b4778dad3c
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMove flow statistics update handling 76/5276/2
Robert Varga [Wed, 12 Feb 2014 02:07:45 +0000 (03:07 +0100)]
Move flow statistics update handling

This finishes the cleanup of StatisticsUpdateCommiter, we now have all
per-node statistics processing guarded by the lock -- e.g. have
predictable and isolated updates to statistics.

Change-Id: Ia58983d5d1dc857e5239a68e3e94fc7d3676cf6d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Move flow comparison methods into utility class"
Ed Warnicke [Thu, 13 Feb 2014 03:52:26 +0000 (03:52 +0000)]
Merge "Move flow comparison methods into utility class"

6 years agoMerge "Prepare for transitioning NodeStatisticsAger"
Ed Warnicke [Thu, 13 Feb 2014 03:51:54 +0000 (03:51 +0000)]
Merge "Prepare for transitioning NodeStatisticsAger"

6 years agoMerge "Simplify StatisticsManagerActivator/StatisticsProvider contract"
Ed Warnicke [Thu, 13 Feb 2014 03:51:29 +0000 (03:51 +0000)]
Merge "Simplify StatisticsManagerActivator/StatisticsProvider contract"

6 years agoMerge "Centralize NodeStatisticsAger creation"
Ed Warnicke [Thu, 13 Feb 2014 03:50:54 +0000 (03:50 +0000)]
Merge "Centralize NodeStatisticsAger creation"

6 years agoMerge "Optimize statistics cleanup"
Ed Warnicke [Thu, 13 Feb 2014 03:50:39 +0000 (03:50 +0000)]
Merge "Optimize statistics cleanup"

6 years agoIncrease SSL input buffer size to accommodate large number of flows 93/5293/1
Jason Ye [Thu, 13 Feb 2014 03:07:05 +0000 (19:07 -0800)]
Increase SSL input buffer size to accommodate large number of flows

Change-Id: I59036ba805682ef1d4dae0d7a7d5f7f40acd94ac
Signed-off-by: Jason Ye <yisye@cisco.com>
6 years agoMerge "Do not allocate/commit transactions in tight loops"
Ed Warnicke [Wed, 12 Feb 2014 15:33:09 +0000 (15:33 +0000)]
Merge "Do not allocate/commit transactions in tight loops"

6 years agoMerge "Rework NETCONF interfaces"
Ed Warnicke [Wed, 12 Feb 2014 15:32:33 +0000 (15:32 +0000)]
Merge "Rework NETCONF interfaces"

6 years agoMerge "Fix thread safety issues in netconf client"
Ed Warnicke [Wed, 12 Feb 2014 15:32:00 +0000 (15:32 +0000)]
Merge "Fix thread safety issues in netconf client"

6 years agoMerge "Cache sessionID to increase readability"
Ed Warnicke [Wed, 12 Feb 2014 15:31:42 +0000 (15:31 +0000)]
Merge "Cache sessionID to increase readability"

6 years agoMerge "Remove unused DefaultNetconfOperation marker"
Ed Warnicke [Wed, 12 Feb 2014 15:29:27 +0000 (15:29 +0000)]
Merge "Remove unused DefaultNetconfOperation marker"

6 years agosal-restconf-broker initial implementation 69/5169/11
Martin Bobak [Mon, 20 Jan 2014 13:27:44 +0000 (14:27 +0100)]
sal-restconf-broker initial implementation
 needs https://git.opendaylight.org/gerrit/#/c/5259/
 and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for
 successful build

Change-Id: Ic665eaf25c908ed7633cfeee7629354d647ef09f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
6 years agoRemoved redundant dependency on configuration artifact 82/5282/1
Martin Bobak [Wed, 12 Feb 2014 12:51:51 +0000 (13:51 +0100)]
Removed redundant dependency on configuration artifact

Change-Id: Ifae0e3071c08ddc7363af1fdb05d97e2b22e4329
Signed-off-by: Martin Bobak <mbobak@cisco.com>
6 years agoMerge "Fixed removals from data store did not clean direct-match indexes to child...
Ed Warnicke [Wed, 12 Feb 2014 06:57:08 +0000 (06:57 +0000)]
Merge "Fixed removals from data store did not clean direct-match indexes to child nodes."

6 years agoMerge "Fixed bug when publisher's thread was blocked until all notifications were...
Ed Warnicke [Wed, 12 Feb 2014 06:56:15 +0000 (06:56 +0000)]
Merge "Fixed bug when publisher's thread was blocked until all notifications were delivered."

6 years agoAuthenticatedUser not to expose internal implementation 79/5279/2
Alessandro Boch [Wed, 12 Feb 2014 04:55:12 +0000 (20:55 -0800)]
AuthenticatedUser not to expose internal implementation

Update unit test

Change-Id: I9606742fbdfe3bbbae8bbf789e130d24bd946d82
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoMove flow comparison methods into utility class 75/5275/1
Robert Varga [Wed, 12 Feb 2014 01:52:27 +0000 (02:52 +0100)]
Move flow comparison methods into utility class

The whole machinery is not interesting except for the two public
methods. Let's move into its dedicated file and limit its visibility to
package for now.

Change-Id: I0377a135b085cc674c66ba238dd5a4608c307cb4
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoPrepare for transitioning NodeStatisticsAger 73/5273/3
Robert Varga [Wed, 12 Feb 2014 00:35:30 +0000 (01:35 +0100)]
Prepare for transitioning NodeStatisticsAger

NodeStatisticsAger is currently the object which tracks per-node state,
synchronizing our view of what comes from the network vs. what is timed
out. Previous patches have already added partial ordering, this patch
moves the actual modifications in NodeStatisticsAger. This gives us
predictable behavior while keeping us per-switch scalable.

Change-Id: I7a11cf5eb885b46972ecf7a362a8d80a97923a0a
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFixed removals from data store did not clean direct-match indexes to child 70/5270/1
Tony Tkacik [Wed, 12 Feb 2014 00:19:23 +0000 (01:19 +0100)]
Fixed removals from data store did not clean direct-match indexes to child
nodes.

  - Added deepRemoveStrategy, which checks for all quick indexes
    if they are removed correctly.

Change-Id: Icb7a231ca0308774f76b43ac40ab4eaf47e68937
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoSimplify StatisticsManagerActivator/StatisticsProvider contract 72/5272/1
Robert Varga [Tue, 11 Feb 2014 23:16:39 +0000 (00:16 +0100)]
Simplify StatisticsManagerActivator/StatisticsProvider contract

Get rid of the need for the StatisticsManagerActivator to keep around
the Provider session -- it is only ever referenced from
StatisticsProvider.start(). Same goes for the various services which
are set into it.

Change-Id: I8014dbdd03e8830bb929e083672f988504d02994
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCentralize NodeStatisticsAger creation 71/5271/1
Robert Varga [Tue, 11 Feb 2014 22:58:56 +0000 (23:58 +0100)]
Centralize NodeStatisticsAger creation

Change-Id: I47fd16cfbcd41b89ea1ec760e1d4e07cf02e1ca1
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoProvide Switch Information in Troubleshooting Tab 69/5269/1
Sapan Shah [Tue, 11 Feb 2014 22:51:27 +0000 (14:51 -0800)]
Provide Switch Information in Troubleshooting Tab

Change-Id: I5fc02b4c6ac5babbe21cc082aa4723882846568a
Signed-off-by: Sapan Shah <sapshah@cisco.com>
6 years agoOptimize statistics cleanup 67/5267/1
Robert Varga [Tue, 11 Feb 2014 18:20:25 +0000 (19:20 +0100)]
Optimize statistics cleanup

Perform a single transaction for cleaning up the flow. Also use
System.nanoTime() for keeping the expiry time and keep it constant.

Furthermore, use HashMap instead of ConcurrentHashMap to gain better
memory peformance. This requires synchronizing between the statistics
update and statistics cleanup -- which actually is okay, as it closes
the race between an update happening precisely when a flow entry would
be retired. With the lockless design that entry could be lost, simply
because we'd get undefined ordering between cleanup and update
transaction commit.

Change-Id: Iceaee5b44643075d325f664af774a9c6841bcfc6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFixed bug when publisher's thread was blocked until all notifications were delivered. 66/5266/1
Tony Tkacik [Tue, 11 Feb 2014 18:35:42 +0000 (19:35 +0100)]
Fixed bug when publisher's thread was blocked until all notifications were delivered.

Change-Id: Ieb083feec0ac6a64877fb045fa4fa6ba6e3fa412
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoDo not allocate/commit transactions in tight loops 30/5230/4
Robert Varga [Mon, 10 Feb 2014 16:35:19 +0000 (17:35 +0100)]
Do not allocate/commit transactions in tight loops

A transaction is additive and there's little harm in commiting empty
ones. Move allocation/commit outside of tight loops, such that we get
proper bulking.

Change-Id: I1f4920965c8ecf3091b6afb69ce1e1baa7ca0e24
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRework NETCONF interfaces 18/5218/7
Robert Varga [Sun, 9 Feb 2014 22:41:45 +0000 (23:41 +0100)]
Rework NETCONF interfaces

NetconfSession and NetconfClientSessionListener are supposed to be
interfaces, not classes. Convert them to such and introduce utility
classes which retain their current functionality. Remove an unused
method and fix type safety warnings while we're at it.

Change-Id: Id7d78c831e3c3d46abb4379efe4a5ca353cd55ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix thread safety issues in netconf client 17/5217/3
Robert Varga [Sun, 9 Feb 2014 19:32:33 +0000 (20:32 +0100)]
Fix thread safety issues in netconf client

This patch introduces a proper asynchronous interface and reworks
internals such that thread safety is maintained.

Change-Id: I6eb1c56518b0b3cc6f64c1df8bc0c857298f79b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCache sessionID to increase readability 13/5213/4
Robert Varga [Sun, 9 Feb 2014 17:04:16 +0000 (18:04 +0100)]
Cache sessionID to increase readability

Change-Id: Ia4440f8a30cdc9b987139879f471be67ffe1dc3f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove unused DefaultNetconfOperation marker 12/5212/4
Robert Varga [Sun, 9 Feb 2014 15:48:01 +0000 (16:48 +0100)]
Remove unused DefaultNetconfOperation marker

DefaultCloseSession and DefaultGetSchema do not need the netconf
session. so drop their use of DefaultNetconfOperation.

Change-Id: I724bd56d913b0f836c88ca8d1b436be308852a30
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix yangtools API incompatibility 57/5257/1
Robert Varga [Tue, 11 Feb 2014 14:42:42 +0000 (15:42 +0100)]
Fix yangtools API incompatibility

Change-Id: Ia6883492a49765f1ffcd38128fcd6084636bc470
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Do not use deprecated StringBufferInputStream"
Ed Warnicke [Tue, 11 Feb 2014 01:51:42 +0000 (01:51 +0000)]
Merge "Do not use deprecated StringBufferInputStream"

6 years agoMerge "Fix a warning"
Ed Warnicke [Tue, 11 Feb 2014 01:51:11 +0000 (01:51 +0000)]
Merge "Fix a warning"

6 years agoMerge "Remove deprecated API elements from protocol framework"
Ed Warnicke [Tue, 11 Feb 2014 01:47:28 +0000 (01:47 +0000)]
Merge "Remove deprecated API elements from protocol framework"

6 years agoMerge "Fix typo in match types yang model"
Ed Warnicke [Tue, 11 Feb 2014 01:34:35 +0000 (01:34 +0000)]
Merge "Fix typo in match types yang model"

6 years agoMerge "Changed model versions to dependencies"
Ed Warnicke [Tue, 11 Feb 2014 01:31:00 +0000 (01:31 +0000)]
Merge "Changed model versions to dependencies"

6 years agoDo not use deprecated StringBufferInputStream 16/5216/2
Robert Varga [Sun, 9 Feb 2014 21:02:56 +0000 (22:02 +0100)]
Do not use deprecated StringBufferInputStream

Change-Id: I745529dd05f2a4156dab98535ba73b81de44872b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix a warning 11/5211/3
Robert Varga [Sun, 9 Feb 2014 15:16:06 +0000 (16:16 +0100)]
Fix a warning

Change-Id: I8605ada63c471d9446ebf7fe31fb518138422cd4
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRewrite POSSIBLE_ENDS and POSSIBLE_STARTS 99/5199/3
Robert Varga [Sat, 8 Feb 2014 02:45:52 +0000 (03:45 +0100)]
Rewrite POSSIBLE_ENDS and POSSIBLE_STARTS

These two are really simple byte arrays, initialized them as such
withouth going through strings/UTF8.

Change-Id: Id80151d9ff57df4b7a5595f76f30a379d89af3dd
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Some methods should be final"
Ed Warnicke [Tue, 11 Feb 2014 00:08:29 +0000 (00:08 +0000)]
Merge "Some methods should be final"

6 years agoMerge "Expose ChannelFuture from sendMessage()"
Ed Warnicke [Mon, 10 Feb 2014 23:50:32 +0000 (23:50 +0000)]
Merge "Expose ChannelFuture from sendMessage()"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.