controller.git
5 years agoMerge "BUG-1953: fix SAL compatility layer"
Tony Tkacik [Fri, 31 Oct 2014 12:57:24 +0000 (12:57 +0000)]
Merge "BUG-1953: fix SAL compatility layer"

5 years agoMerge "Bug 2065 - fixed typo in leaf name"
Tony Tkacik [Fri, 31 Oct 2014 10:19:45 +0000 (10:19 +0000)]
Merge "Bug 2065 - fixed typo in leaf name"

5 years agoBUG 2134 : Make persistence configurable at the datastore level 52/12352/5
Moiz Raja [Fri, 17 Oct 2014 23:42:41 +0000 (16:42 -0700)]
BUG 2134 : Make persistence configurable at the datastore level

- Added a peristent flag in the config sub-system
- If persistent in not true then we ignore recovery messages and not use the
  akka persistence apis for persisting anything
- The unit tests
    - assume that persistence is on by default (which it is)
    - test that if recovery is applicable only then the ShardManager and RaftActor process the recovoery messages.
    - test that when persisting the data-persistence API is used in the appropriate places (see RaftActorTest/ShardManagerTest)

Change-Id: I19913bcd32e609ccde6ad8e35209788315504426
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 2065 - fixed typo in leaf name 81/12381/1
Martin Bobak [Thu, 30 Oct 2014 13:54:14 +0000 (14:54 +0100)]
Bug 2065 - fixed typo in leaf name

Change-Id: I9f0f201078ffc3d7c08f57108b4d113f87df9ac4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
5 years agoMerge "Bug 2055: Handle Tx create in TransactionProxy resiliently"
Moiz Raja [Thu, 30 Oct 2014 01:59:53 +0000 (01:59 +0000)]
Merge "Bug 2055: Handle Tx create in TransactionProxy resiliently"

5 years agoMerge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"
Devin Avery [Wed, 29 Oct 2014 14:17:58 +0000 (14:17 +0000)]
Merge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"

5 years agoCosmetics: check in pom.xml files as _sort_pom_ wants them to be 12/12312/1
Flavio Fernandes [Wed, 29 Oct 2014 10:07:12 +0000 (06:07 -0400)]
Cosmetics: check in pom.xml files as _sort_pom_ wants them to be

Change-Id: I08fc2c0284e0396605cec7d218ea4470a312bfc8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
5 years agoMerge "Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools...
Moiz Raja [Wed, 29 Oct 2014 09:00:27 +0000 (09:00 +0000)]
Merge "Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools interface"

5 years agoMerge "Bug 2252: Terminate ShardWriteTransaction actor on ready"
Moiz Raja [Wed, 29 Oct 2014 08:59:51 +0000 (08:59 +0000)]
Merge "Bug 2252: Terminate ShardWriteTransaction actor on ready"

5 years agoMerge "BUG 2221 : Add metering to ShardTransaction actor"
Moiz Raja [Wed, 29 Oct 2014 03:05:09 +0000 (03:05 +0000)]
Merge "BUG 2221 : Add metering to ShardTransaction actor"

5 years agoMerge "Bug 2086: Adding normalized node stream reader and writer."
Tom Pantelis [Tue, 28 Oct 2014 15:55:45 +0000 (15:55 +0000)]
Merge "Bug 2086: Adding normalized node  stream reader and writer."

5 years agoMerge "BUG-2195 Enable features test for netconf connector"
Tony Tkacik [Tue, 28 Oct 2014 11:46:23 +0000 (11:46 +0000)]
Merge "BUG-2195 Enable features test for netconf connector"

5 years agoBUG-2195 Enable features test for netconf connector 34/12234/5
Maros Marsalek [Fri, 24 Oct 2014 13:06:47 +0000 (15:06 +0200)]
BUG-2195 Enable features test for netconf connector

Change-Id: I85eca361a8af13a87f09477781405dbcb9f721b4
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2086: Adding normalized node stream reader and writer. 84/12284/1
Harman Singh [Tue, 21 Oct 2014 21:50:04 +0000 (14:50 -0700)]
Bug 2086: Adding normalized node  stream reader and writer.

Normalized node and its children are written in recursive manner. Besides the leafNode, leafSetEntryNode and anyxmlNode, all other nodes must call endNode method
while writing object to data stream. This helps to recreate the object.

Recursion  runs in opposite direction while reading the object.

Updated code with review comments

Change-Id: Ibb822e11fc76f52b5be78596ed979c3b97d51de8
Signed-off-by: Harman Singh <harmasin@cisco.com>
5 years agoBug 2055: Handle Tx create in TransactionProxy resiliently 15/12215/7
tpantelis [Sun, 12 Oct 2014 14:44:35 +0000 (10:44 -0400)]
Bug 2055: Handle Tx create in TransactionProxy resiliently

    Modified TransactionProxy to utilize the FindPrimaryShard
functionality
    to wait until the shard is initialized. Also added retries to
    the CreateTransaction operation to wait a period of time for the
shard
    to elect a leader. This makes it more resilient to avoid transient
    timing/sequencing failures, particularly on startup.

    In addition, the FindPrimaryShard and CreateTransaction operations
are now
    done async (non-blocking). The futures are combined to yield the
    CreateTransactionReply which is passed to a new class
    TransactionFutureCallback on completion. The
TransactionFutureCallback
    class creates and stores the TransactionContext which subsequent
    read/write/delete/ready transaction operations can access. If a
    transaction operation occurs before CreateTransaction completes, the
    operation is cached in TransactionFutureCallback and executed when
    the CreateTransaction future completes.

Change-Id: Id9cdc9641038922d6209c44d924bd168658a71fb
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Bug-2098- sal-compatibility not get up-to-date flow information"
Moiz Raja [Mon, 27 Oct 2014 23:20:21 +0000 (23:20 +0000)]
Merge "Bug-2098- sal-compatibility not get up-to-date flow information"

5 years agoBug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools interface 93/12293/2
tpantelis [Mon, 27 Oct 2014 21:13:58 +0000 (17:13 -0400)]
Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools interface

The NormalizedNodeOutputStreamWriter was originally written to implement
a NormalizedNodeStreamWriter interface class that was copied from
yangtools. This was done to get access to the NodeWithValue in the
leafSetEntryNode method which isn't specified in the yangtools
interface. However it turns out we don't actually need the NodeWithValue so
NormalizedNodeOutputStreamWriter was changed to implement the yangtols interface
and the copied NormalizedNodeStreamWriter interface was removed.

Change-Id: I72f0c96359e4fe96e8e183aa7afba9291c5d519d
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBug-2098- sal-compatibility not get up-to-date flow information 31/11631/7
Kamal Rameshan [Sat, 27 Sep 2014 19:08:12 +0000 (12:08 -0700)]
Bug-2098- sal-compatibility not get up-to-date flow information

When cached is passed in as false, we attempt to collect all the notifications in a guava cache and
return the results after we get the last notification.

Depends on the OFP Patch : https://git.opendaylight.org/gerrit/#/c/11655/

Change-Id: I78d911648957f30d0ae0c92945ad3ac4cf7fc483
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoMerge "Bug 2055: Handle shard not initialized resiliently"
Moiz Raja [Mon, 27 Oct 2014 17:14:58 +0000 (17:14 +0000)]
Merge "Bug 2055: Handle shard not initialized resiliently"

5 years agoMerge changes I8b1a0281,Ib6342c74
Tony Tkacik [Mon, 27 Oct 2014 11:23:18 +0000 (11:23 +0000)]
Merge changes I8b1a0281,Ib6342c74

* changes:
  BUG-1612 Remove ganymed third party ssh lib (replaced by mina ssh)
  BUG-1612 Remove ganymed implementation of SSH server wrapper.

5 years agoMerge "BUG 1839 - HTTP delete of non existing data"
Tony Tkacik [Mon, 27 Oct 2014 10:22:29 +0000 (10:22 +0000)]
Merge "BUG 1839 - HTTP delete of non existing data"

5 years agoMerge "Fix checkstyle warnings"
Tony Tkacik [Mon, 27 Oct 2014 09:58:19 +0000 (09:58 +0000)]
Merge "Fix checkstyle warnings"

5 years agoMerge "Convert netconf to use artifacts"
Tony Tkacik [Mon, 27 Oct 2014 09:28:44 +0000 (09:28 +0000)]
Merge "Convert netconf to use artifacts"

5 years agoMerge "Import yangtools-artifacts"
Tony Tkacik [Mon, 27 Oct 2014 09:28:29 +0000 (09:28 +0000)]
Merge "Import yangtools-artifacts"

5 years agoMerge "Cleanup RpcRoutingStrategy definition"
Tony Tkacik [Mon, 27 Oct 2014 09:28:04 +0000 (09:28 +0000)]
Merge "Cleanup RpcRoutingStrategy definition"

5 years agoBUG-1612 Remove ganymed third party ssh lib (replaced by mina ssh) 97/11997/7
Maros Marsalek [Thu, 16 Oct 2014 06:10:07 +0000 (08:10 +0200)]
BUG-1612 Remove ganymed third party ssh lib (replaced by mina ssh)

Change-Id: I8b1a0281161f29345f1ee1af646a5fca504ad823
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-1612 Remove ganymed implementation of SSH server wrapper. 41/11841/7
Maros Marsalek [Tue, 7 Oct 2014 17:17:56 +0000 (19:17 +0200)]
BUG-1612 Remove ganymed implementation of SSH server wrapper.

Change-Id: Ib6342c74ff9335265d1fe7a12ca8caecbd72d94f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "BUG-1612 Update netconf testtool to use new ssh server wrapper"
Tony Tkacik [Mon, 27 Oct 2014 09:17:26 +0000 (09:17 +0000)]
Merge "BUG-1612 Update netconf testtool to use new ssh server wrapper"

5 years agoMerge "BUG-1612 Implement mina ssh netconf server endpoint"
Tony Tkacik [Mon, 27 Oct 2014 09:17:14 +0000 (09:17 +0000)]
Merge "BUG-1612 Implement mina ssh netconf server endpoint"

5 years agoMerge "Fix failing reconnect test."
Tony Tkacik [Mon, 27 Oct 2014 08:27:13 +0000 (08:27 +0000)]
Merge "Fix failing reconnect test."

5 years agoMerge "BUG-2184 Fix subtree filtering for identity-ref leaves"
Tony Tkacik [Mon, 27 Oct 2014 08:26:36 +0000 (08:26 +0000)]
Merge "BUG-2184 Fix subtree filtering for identity-ref leaves"

5 years agoMerge "BUG-2184 Fix config.yang module(add type as a key for modules list)"
Tony Tkacik [Mon, 27 Oct 2014 08:26:25 +0000 (08:26 +0000)]
Merge "BUG-2184 Fix config.yang module(add type as a key for modules list)"

5 years agoBug 2210: Fixed initial DCL notification on registration 88/12088/6
tpantelis [Thu, 9 Oct 2014 17:54:18 +0000 (13:54 -0400)]
Bug 2210: Fixed initial DCL notification on registration

On RegisterChangeListener message, if the shard isn't the leader, the
listener proxy isn't registered with the IMDS yet, instead a
DelayedListenerRegistration innstance is created and added to a
delayedListenerRegistrations list. When the shard becomes the leader, in
onStateChange, the DelayedListenerRegistration instances in the
delayedListenerRegistrations list are registered with the IMDS.

Change-Id: Id5fbfc3e452e9843f6977139d101e71f4022dc0a
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBug 2252: Terminate ShardWriteTransaction actor on ready 62/12262/2
tpantelis [Sun, 26 Oct 2014 21:15:19 +0000 (17:15 -0400)]
Bug 2252: Terminate ShardWriteTransaction actor on ready

Change-Id: I16f9dcf370aab1e23073163e0e055a40f1415a1a
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoConvert netconf to use artifacts 60/12060/4
Robert Varga [Fri, 17 Oct 2014 23:23:01 +0000 (01:23 +0200)]
Convert netconf to use artifacts

Change-Id: I23feabe96c7fc3e0d1ca59b6773abeb97e9467f9
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoImport yangtools-artifacts 42/11942/5
Robert Varga [Sun, 12 Oct 2014 11:33:52 +0000 (13:33 +0200)]
Import yangtools-artifacts

This patch makes use of artifacts exported by yangtools, simplifying the
dependencyManagement section.

Change-Id: Id00030f6f4134c6bebc573cf3c14fe271e59e61a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Bug-2136 : Clustering : When a transaction is local then do not serialize...
Tom Pantelis [Fri, 24 Oct 2014 21:39:29 +0000 (21:39 +0000)]
Merge "Bug-2136 : Clustering : When a transaction is local then do not serialize the Reading/Writing of data"

5 years agoBUG-1612 Update netconf testtool to use new ssh server wrapper 42/11842/4
Maros Marsalek [Tue, 7 Oct 2014 17:44:35 +0000 (19:44 +0200)]
BUG-1612 Update netconf testtool to use new ssh server wrapper

Change-Id: I8625f8d34df65f6d7e47ad77d393f482afa1abdf
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-1612 Implement mina ssh netconf server endpoint 40/11840/4
Maros Marsalek [Mon, 6 Oct 2014 16:09:10 +0000 (18:09 +0200)]
BUG-1612 Implement mina ssh netconf server endpoint

Extract sessionCloseCallback and readHandler from AsyncSshHandlerReader

Change-Id: I0e09341fd59f74f7ac57688414a6dac7c9823b8a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoFix failing reconnect test. 33/12233/1
Maros Marsalek [Fri, 24 Oct 2014 13:34:16 +0000 (15:34 +0200)]
Fix failing reconnect test.

Test verified that session that was dropped during negotiation was not reconnected.
This is no longer true, so the test is failing. However not on jenkins.

Change-Id: I5f416a3397c33607e5004dc48f9569d9da992326
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "[Fix for Bug 1631] - Refactored RaftActorBehavior#handleMessage (and related...
Moiz Raja [Fri, 24 Oct 2014 06:23:22 +0000 (06:23 +0000)]
Merge "[Fix for Bug 1631] - Refactored RaftActorBehavior#handleMessage (and related methods) to return RaftActorBehavior   instead of RaftActorState. - Moved behavior switching from RaftActor based on requested state to the implementations of the   behaviors that should control that switch (Leader/Follower/Candidate) based on the type of   message received. - Pull up logger reference for concrete RAFT behaviors to parent for a common LOG reference. - Updated all logger calls to:   - Use substitution instead of String concatenation.  - Debug logger calls are gated by isDebugEnabled check.  - Correctly use Akka logging API for stack trace on exception.  - Avoid toString() calls during logging.  - Use assigned logger instance (LOG) instead of call to context.getLogger()"

5 years ago[Fix for Bug 1631] 65/11965/5
mark.mozolewski [Tue, 14 Oct 2014 23:05:57 +0000 (16:05 -0700)]
[Fix for Bug 1631]
- Refactored RaftActorBehavior#handleMessage (and related methods) to return RaftActorBehavior
  instead of RaftActorState.
- Moved behavior switching from RaftActor based on requested state to the implementations of the
  behaviors that should control that switch (Leader/Follower/Candidate) based on the type of
  message received.
- Pull up logger reference for concrete RAFT behaviors to parent for a common LOG reference.
- Updated all logger calls to:
  - Use substitution instead of String concatenation.
- Debug logger calls are gated by isDebugEnabled check.
- Correctly use Akka logging API for stack trace on exception.
- Avoid toString() calls during logging.
- Use assigned logger instance (LOG) instead of call to context.getLogger()

Change-Id: I376e21734a0540aae714fe9ef1562d74e73e558b
Signed-off-by: mark.mozolewski <mark.mozolewski@hp.com>
5 years agoBug 2002: Classpath error when loading neutron northbound api 88/12188/1
Sam Hague [Wed, 22 Oct 2014 01:51:27 +0000 (21:51 -0400)]
Bug 2002: Classpath error when loading neutron northbound api

Add the org.eclipse.persistence.antlr to the odl-pseristence feture. There are weird timing issues where if the antlr bundle is not loaded before core and moxy then the classes in antlr cannot be found.

Change-Id: I8fd30b5fb215b8a25512deac45e80099c91c539e
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit 3ee4966ad2d840a907fae33ff74037d599765742)

5 years agoBUG-2184 Fix subtree filtering for identity-ref leaves 65/12165/1
Maros Marsalek [Wed, 22 Oct 2014 15:49:19 +0000 (17:49 +0200)]
BUG-2184 Fix subtree filtering for identity-ref leaves

Change-Id: I7d367c793a461ae26f56ddf611f7e45a723f28fc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2184 Fix config.yang module(add type as a key for modules list) 69/12069/2
Maros Marsalek [Mon, 20 Oct 2014 10:46:28 +0000 (12:46 +0200)]
BUG-2184 Fix config.yang module(add type as a key for modules list)

Netconf server requires the type and name when e.g. deleting data so the yang model did not fully reflect the implementation

Change-Id: If4b04fe1ec427cff0f52d743cc1440fc7fe143d2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "BUG-2207 Make reconnect promise reconnect even if session was dropped during...
Tony Tkacik [Wed, 22 Oct 2014 13:09:27 +0000 (13:09 +0000)]
Merge "BUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation"

5 years agoMerge "BUG-2217 Add missing namespace to serialized inner runtime beans"
Tony Tkacik [Wed, 22 Oct 2014 11:52:44 +0000 (11:52 +0000)]
Merge "BUG-2217 Add missing namespace to serialized inner runtime beans"

5 years agoBUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation 58/11858/4
Maros Marsalek [Thu, 9 Oct 2014 15:23:25 +0000 (17:23 +0200)]
BUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation

Change-Id: I58adc2e42bb8ce09bfb8b5cd214a91300bb2bbb0
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG 1833 : Remove all unused code from sal-clustering-commons 30/12130/1
Moiz Raja [Tue, 21 Oct 2014 21:12:19 +0000 (14:12 -0700)]
BUG 1833 : Remove all unused code from sal-clustering-commons

Change-Id: I7ce05b4ee77b6151f361091b18d1a7bbd8ed408a
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 4861f2406206bf208a07a703ad8d6808072c6e45)

5 years agoMerge "Bug2174: XSQL log file is hardcode to /tmp/xql.log"
Moiz Raja [Tue, 21 Oct 2014 19:51:29 +0000 (19:51 +0000)]
Merge "Bug2174: XSQL log file is hardcode to /tmp/xql.log"

5 years agoBUG 2221 : Add metering to ShardTransaction actor 19/11619/3
Moiz Raja [Fri, 26 Sep 2014 17:59:17 +0000 (10:59 -0700)]
BUG 2221 : Add metering to ShardTransaction actor

Change-Id: I4cbf74f9e8979b996a30a019657177b92fbdfc18
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Add support for metadata to the Match/Action classes"
Alessandro Boch [Mon, 20 Oct 2014 16:12:08 +0000 (16:12 +0000)]
Merge "Add support for metadata to the Match/Action classes"

5 years agoBUG-2217 Add missing namespace to serialized inner runtime beans 71/12071/1
Maros Marsalek [Mon, 20 Oct 2014 11:17:22 +0000 (13:17 +0200)]
BUG-2217 Add missing namespace to serialized inner runtime beans

Change-Id: I267c23ec620bacbd800ee171f37413d4f5997f69
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Add get-config commit edit-config to testtool"
Tony Tkacik [Mon, 20 Oct 2014 09:19:04 +0000 (09:19 +0000)]
Merge "Add get-config commit edit-config to testtool"

5 years agoMerge "Issue fix for config subsystem"
Tony Tkacik [Mon, 20 Oct 2014 09:18:40 +0000 (09:18 +0000)]
Merge "Issue fix for config subsystem"

5 years agoAdd get-config commit edit-config to testtool 46/12046/6
Maros Marsalek [Fri, 17 Oct 2014 09:58:07 +0000 (11:58 +0200)]
Add get-config commit edit-config to testtool

Change-Id: Ie85c839c2077b9d7ca560dc42120268501acb8b0
Signed-off-by: Andrej Socha <ansocha@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug2174: XSQL log file is hardcode to /tmp/xql.log 90/11890/2
Christopher O'Shea [Fri, 10 Oct 2014 17:18:46 +0000 (10:18 -0700)]
Bug2174: XSQL log file is hardcode to /tmp/xql.log

Change XSQL to point to java.io.tmpdir which should be data\tmp\xql.log

Change-Id: I811064dd28ce2f4cdb661c7bf968a1cee21d32be
Signed-off-by: Christopher O'Shea <christopher.o.shea@ericsson.com>
5 years agoBUG 1839 - HTTP delete of non existing data 32/11232/5
Jozef Gloncak [Tue, 16 Sep 2014 12:49:24 +0000 (14:49 +0200)]
BUG 1839 - HTTP delete of non existing data

Before - after deleting non existing data an exception was raised.
Now - after deleting non existing data it is checked whether there is in
exception chain instance of ModifiedNodeDoesNotExistException. If it is so then
HTTP 404 - data missing status is returned.

Change-Id: I43ccaa16abe7dfaffa3e031aa31d93f8f106a81f
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoIssue fix for config subsystem 99/11999/1
Filip Tehlar [Thu, 16 Oct 2014 10:42:12 +0000 (12:42 +0200)]
Issue fix for config subsystem

Change-Id: I73d02158accb65c92dabc76eb8b353b052ac2d05
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
5 years agoMerge "Bug 1577: Gates access to Shard actor until its initialized"
Moiz Raja [Wed, 15 Oct 2014 19:36:01 +0000 (19:36 +0000)]
Merge "Bug 1577: Gates access to Shard actor until its initialized"

5 years agoMerge "Fixes bug 2114"
Devin Avery [Wed, 15 Oct 2014 16:25:07 +0000 (16:25 +0000)]
Merge "Fixes bug 2114"

5 years agoAdd support for metadata to the Match/Action classes 55/11755/2
Giovanni Meo [Mon, 6 Oct 2014 10:09:25 +0000 (12:09 +0200)]
Add support for metadata to the Match/Action classes

- Allow to attach some property to Match and Action so they can be
used for passing extra informations, that applications can use.

Change-Id: I4225271d7cd3429b11adb191ae178f541bbd635d
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
5 years agoMerge "BUG 720 - YANG leaf as JSON input *<*:* couldn't be saved"
Devin Avery [Wed, 15 Oct 2014 09:38:56 +0000 (09:38 +0000)]
Merge "BUG 720 - YANG leaf as JSON input *<*:* couldn't be saved"

5 years agoBUG 720 - YANG leaf as JSON input *<*:* couldn't be saved 66/11566/3
Jozef Gloncak [Thu, 25 Sep 2014 08:18:02 +0000 (10:18 +0200)]
BUG 720 - YANG leaf as JSON input *<*:* couldn't be saved

If input value for leaf in JSON format contained opending angle bracket
(<) followed by collon (:) then exception was raised.

Because schema isn't present at time of JSON input reading it was also
supposed that data could be of type leafref which is specified in format
module:value. Module part is then transformed to instance of URI object.

Chracter < isn't permitted in URI according RFC2396 for URI and while
creating instance of URI class the exception which wasn't caught was
raised and transformed to returning error message.

Change-Id: I46bb949b38623f62a02daf4390c373371775ae1f
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoFix checkstyle warnings 43/11943/3
Robert Varga [Tue, 14 Oct 2014 09:40:02 +0000 (11:40 +0200)]
Fix checkstyle warnings

Reorder imports and rename logger->LOG.

Change-Id: I75929957f0ec6d4f70d274c86f4de3a92c248a9a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoCleanup RpcRoutingStrategy definition 08/11308/5
Robert Varga [Wed, 17 Sep 2014 12:44:20 +0000 (14:44 +0200)]
Cleanup RpcRoutingStrategy definition

Adds preconditions and final keywords as appropriate, removes single-use
private static constructors.

Change-Id: If3bc7c46cb46edb1e2059453f42e1bfc521af46d
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFix compilation after jacoco version bump 41/11941/1
Robert Varga [Tue, 14 Oct 2014 09:34:11 +0000 (11:34 +0200)]
Fix compilation after jacoco version bump

The plugin configuration for 0.6.3+ has been changed incompatibly, so
fix it up.

Change-Id: Ia8e96f9a98e18810680e18f9bd59cbb54873c331
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBug 2055: Handle shard not initialized resiliently 94/11994/9
tpantelis [Sat, 4 Oct 2014 06:37:00 +0000 (02:37 -0400)]
Bug 2055: Handle shard not initialized resiliently

Added a flag to the FindLocalShard and FindPrimaryShard messages to
specify whether or not to wait for he shard to be initialized.

Modified FindLocalShard and FindPrimaryShard message handling in the
ShardManager to wait for the shard to be initialized before replying if
the flag is set in the message. This is done async by caching the
response info in the ShardInformation and sending the response when the
ActorInitialized message for the shard is received.

Modified DistributedDataStore#registerChangeListener to always create a
DataChangeListenerRegistrationProxy and moved the code that performs the
findLocalShard and RegisterChangeListener operations into
DataChangeListenerRegistrationProxy. In DataChangeListenerRegistrationProxy,
the findLocalShard operation is done async (with a long time out). On success,
the RegisterChangeListener message is sent.

Added change listener test to DistributedDataStoreIntegrationTest and
removed the DistributedDataStoreTest since most of the tests tested
registration and the bulk of that logic is now in
DataChangeListenerRegistrationProxy with associated tests. The rest of
the tests in DistributedDataStoreTest are covered by
DistributedDataStoreIntegrationTest.

Change-Id: I9f0d412801110c97eb48ecc4d0fd77ee081a7e81
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBug-2136 : Clustering : When a transaction is local then do not serialize the Reading... 34/11934/8
Kamal Rameshan [Wed, 22 Oct 2014 03:06:09 +0000 (20:06 -0700)]
Bug-2136 : Clustering : When a transaction is local then do not serialize the Reading/Writing of data

Ensured that the TransactionContext created for each shard within the transaction has a flag isShardLocal.
if the flag is false, we would be using ProfoBuf to serialize.

Change-Id: I3dc754ae58566212237a6ce385e5f5bb63afd4e0
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoMerge "Update the XSQL jdbc driver to support pentaho"
Moiz Raja [Fri, 10 Oct 2014 17:34:00 +0000 (17:34 +0000)]
Merge "Update the XSQL jdbc driver to support pentaho"

5 years agoAdding restconf to the opendaylight-karaf distribution 62/11862/2
Colin Dixon [Thu, 9 Oct 2014 19:46:35 +0000 (14:46 -0500)]
Adding restconf to the opendaylight-karaf distribution

Change-Id: I91cbee656e2f4da2af62f8a26e7800401f9c6aa4
Signed-off-by: Colin Dixon <colin@colindixon.com>
5 years agoMerge "Bug 2003: CDS serialization improvements"
Moiz Raja [Thu, 9 Oct 2014 19:24:19 +0000 (19:24 +0000)]
Merge "Bug 2003: CDS serialization improvements"

5 years agoBug 2135: Create ShardInformation on startup 33/12033/5
tpantelis [Wed, 8 Oct 2014 11:21:43 +0000 (07:21 -0400)]
Bug 2135: Create ShardInformation on startup

Modified the ShardManager to create the ShardInformation map on startup,
but without creating the shard actors yet, instead of when the SchemaContext is initialized.

When the SchemaContext is fully initialized then create the shard actors.

On FindLocalShard and FindPrimaryShard messages, only return a valid
response if the shard actor is created and it's initialized.

Change-Id: I361f2af9e53878f62c5890350afd7a5f2877b95c
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Bug 2160: Added concurrent 3-phase commit coordinator"
Moiz Raja [Fri, 17 Oct 2014 16:20:25 +0000 (16:20 +0000)]
Merge "Bug 2160: Added concurrent 3-phase commit coordinator"

5 years agoMerge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."
Tony Tkacik [Fri, 17 Oct 2014 15:01:54 +0000 (15:01 +0000)]
Merge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."

5 years agoMerge "Bug 2038: Ensure only one concurrent 3-phase commit in Shard"
Moiz Raja [Fri, 17 Oct 2014 14:56:16 +0000 (14:56 +0000)]
Merge "Bug 2038: Ensure only one concurrent 3-phase commit in Shard"

5 years agoBug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods. 51/12051/1
Tony Tkacik [Fri, 17 Oct 2014 14:05:21 +0000 (16:05 +0200)]
Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods.

Some components in controller still used methods which was deprecated
before Helium and was removed after Helium was released to accomodate
API changes for 0.7.0 Yangtools. This patch migrates code to replacement
methods.

Change-Id: Ia7ef044eb3af4f5652dc71d9cba2bb64efd95187
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoMerge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."
Tony Tkacik [Fri, 17 Oct 2014 13:35:10 +0000 (13:35 +0000)]
Merge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."

5 years agoBug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods. 47/12047/4
Tony Tkacik [Fri, 17 Oct 2014 12:05:06 +0000 (14:05 +0200)]
Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods.

Some components in controller still used methods which was deprecated
before Helium and was removed after Helium was released to accomodate
API changes for 0.7.0 Yangtools. This patch migrates code to replacement
methods.

Change-Id: I146a08caefeb0d666223cf66600a4342a5b49165
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoMerge "Migrate netconf testtool to work with karaf distribution"
Tony Tkacik [Fri, 17 Oct 2014 13:00:50 +0000 (13:00 +0000)]
Merge "Migrate netconf testtool to work with karaf distribution"

5 years agoMerge "Bug 1764 - added service for pushing default node configuration"
Tony Tkacik [Fri, 17 Oct 2014 10:56:13 +0000 (10:56 +0000)]
Merge "Bug 1764 - added service for pushing default node configuration"

5 years agoMerge "Add features-netconf-connector to controller karaf distro"
Tony Tkacik [Fri, 17 Oct 2014 10:13:30 +0000 (10:13 +0000)]
Merge "Add features-netconf-connector to controller karaf distro"

5 years agoMerge "BUG-2006: Rework state tracking"
Tony Tkacik [Fri, 17 Oct 2014 09:17:35 +0000 (09:17 +0000)]
Merge "BUG-2006: Rework state tracking"

5 years agoMigrate netconf testtool to work with karaf distribution 32/11532/4
Maros Marsalek [Thu, 16 Oct 2014 15:41:07 +0000 (17:41 +0200)]
Migrate netconf testtool to work with karaf distribution

Make testtool part of default build process.

Change-Id: Ie957bcf2a38405fee979a6f8547b328d3bd8e2ea
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoAdd features-netconf-connector to controller karaf distro 27/12027/2
Maros Marsalek [Thu, 16 Oct 2014 15:40:37 +0000 (17:40 +0200)]
Add features-netconf-connector to controller karaf distro

Change-Id: I44bf8d82f35586a03950d5ef2f26a321931cb8c6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2038: Ensure only one concurrent 3-phase commit in Shard 95/11795/10
tpantelis [Sun, 5 Oct 2014 03:05:16 +0000 (23:05 -0400)]
Bug 2038: Ensure only one concurrent 3-phase commit in Shard

Added a ShardCommitCoordinator class that ensures there's only one
concurrent 3-phase commit.

The following outlines the new commit workflow:

- On ready, the ShardTransaction creates the dom store cohort and
forwards a new ForwardedReadyTransaction message to the shard.

- The shard calls its ShardCommitCoordinator to add the cohort and
modificaton to a cached keyed by transaction ID.

- On CanCommitTransaction message, the ShardCommitCoordinator looks up and removes
the cohort entry from the cache corresponding to the transaction ID
passed via the CanCommit message. The ShardCommitCoordinator also caches
the cohort entry for the current transaction in progress. If there's no
transaction in progress, the committing transaction becomes the current
transaction and canCommit is called on the cohort. Otherwise, the cohort
entry is queued to be processed after the current tranaction completes.

- On CommitTransaction message, if the transaction ID passed via the
Commit message matches the currently cached cohort entry, the preCommit
and commit phases are performed. When complete, the ShardCommitCoordinator
dequeues the next waiting transaction cohort entry, if any, and process
it.

If a Tx is aborted and it is the current transaction, the
ShardCommitCoordinator handles it as a completed Tx.

Implemented a timeout mechanism using the akka scheduler such that if
the commit message isn't received after a period of time (default 30 s)
after the canCommit message, the transaction is aborted so that the next
transaction can proceed. This is to handle remote node or network
failures during a 3-phrase commit.

The ThreePhaseCommitCohort actor was removed along with the
ForwardedCommitTransaction.

Change-Id: Iaa5692ca45cd7635d1a06a609f4bf98bec50df14
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Bug 1965: Fixed DataChangedReply sent to deadletters"
Moiz Raja [Thu, 16 Oct 2014 20:51:59 +0000 (20:51 +0000)]
Merge "Bug 1965: Fixed DataChangedReply sent to deadletters"

5 years agoMerge "Bug-1607: Clustering : Remove actorFor (deprecated) call from TransactionProx...
Moiz Raja [Thu, 16 Oct 2014 17:03:23 +0000 (17:03 +0000)]
Merge "Bug-1607:  Clustering : Remove actorFor (deprecated) call from TransactionProxy.java"

5 years agoBug 1764 - added service for pushing default node configuration 00/12000/4
Martin Bobak [Thu, 16 Oct 2014 05:29:05 +0000 (07:29 +0200)]
Bug 1764 - added service for pushing default node configuration

Change-Id: I8018c639ce05118722c8f33ca842436cca44372e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
5 years agoMerge "BUG 2047 - HTTP GET - no returning error message"
Tony Tkacik [Thu, 16 Oct 2014 13:21:40 +0000 (13:21 +0000)]
Merge "BUG 2047 - HTTP GET - no returning error message"

5 years agoMerge "BUG 1966 - change message logging level (info -> trace)"
Tony Tkacik [Thu, 16 Oct 2014 13:03:16 +0000 (13:03 +0000)]
Merge "BUG 1966 - change message logging level (info -> trace)"

5 years agoMerge "Bug 2131 - NPE when starting controller"
Tony Tkacik [Thu, 16 Oct 2014 13:02:09 +0000 (13:02 +0000)]
Merge "Bug 2131 - NPE when starting controller"

5 years agoBUG-2006: Rework state tracking 17/11417/5
Robert Varga [Thu, 18 Sep 2014 13:53:24 +0000 (15:53 +0200)]
BUG-2006: Rework state tracking

Separate out the two embedded classes to allow easier analysis of
interactions. Introduce a state-tracking class within
DOMStoreTransactionChainImpl with three distinct states: Idle, Allocated
and Shutdown. The allocated state has an internal sub-state when the
transaction has been readied. Perform atomic state transitions using
compare-and-swap.

Change-Id: I4b852d42455d7e07076c56af3626f804ba572770
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge changes I879118ce,I664b391e
Tony Tkacik [Thu, 16 Oct 2014 10:09:05 +0000 (10:09 +0000)]
Merge changes I879118ce,I664b391e

* changes:
  BUG-2017 Fix possible concurrent modification ex in config subsystem
  BUG-1520 Set correct factory in ImmediateEventExecutorModuleTest

5 years agoMerge "BUG-1958 Fix leafref path in config-yang module."
Tony Tkacik [Thu, 16 Oct 2014 10:08:50 +0000 (10:08 +0000)]
Merge "BUG-1958 Fix leafref path in config-yang module."

5 years agoMerge "BUG-1521 netconf-impl & netconf-monitoring line coverage."
Tony Tkacik [Thu, 16 Oct 2014 10:08:13 +0000 (10:08 +0000)]
Merge "BUG-1521 netconf-impl & netconf-monitoring line coverage."

5 years agoBug-1607: Clustering : Remove actorFor (deprecated) call from TransactionProxy.java 34/11834/4
Kamal Rameshan [Wed, 8 Oct 2014 21:09:37 +0000 (14:09 -0700)]
Bug-1607:  Clustering : Remove actorFor (deprecated) call from TransactionProxy.java

1. Changes to use ActorSelection instead of ActorPath
2. Removed actorFor usage
3. Removed resolvePath calls
4. Changes in test classes.

Rebased.

Change-Id: I8fdc18a1ac18d75d1b6d5c8cd0da986e19d08280
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoUpdate the XSQL jdbc driver to support pentaho 24/11724/5
Sharon Aicler [Fri, 3 Oct 2014 15:36:10 +0000 (08:36 -0700)]
Update the XSQL jdbc driver to support pentaho

Change-Id: I72f54b36a87c84c9fa493a1d35300b241a53ec34
Signed-off-by: Sharon Aicler <saichler@cisco.com>
5 years agoBug 1965: Fixed DataChangedReply sent to deadletters 32/11932/3
tpantelis [Mon, 6 Oct 2014 22:31:18 +0000 (18:31 -0400)]
Bug 1965: Fixed DataChangedReply sent to deadletters

Change-Id: I3a579823d57e113597aabeb647c883d8811f29f1
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBug 2160: Added concurrent 3-phase commit coordinator 66/11966/3
tpantelis [Tue, 7 Oct 2014 13:34:01 +0000 (09:34 -0400)]
Bug 2160: Added concurrent 3-phase commit coordinator

Added a new class DOMConcurrentDataCommitCoordinator which is an
implementation of DOMDataCommitExecutor that allows multiple concurrent
3-phase transaction commits. The 3 phases are still performed serially and
non-blocking per transaction.

A new flag, "allow-concurrent-commits", was added to the DOM in-memory
data broker's yang config. If true, the new
DOMConcurrentDataCommitCoordinator implementation is used, otherwise the
current implementation is used. The default is false.

The distributed data store will use the concurrent coordinator.

Change-Id: Ie21947d6f9c1086f89686a73442c854c08c07100
Signed-off-by: tpantelis <tpanteli@brocade.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.