Tony Tkacik [Tue, 29 Jul 2014 09:29:39 +0000 (09:29 +0000)]
Merge changes Ifd28301d,I38220acb,I9bad24df
* changes:
WIP: Backwards compatible MountPointService
Fix children element lookup in XmlElement
Fix config attributes with same names for different modules.
Tony Tkacik [Tue, 29 Jul 2014 09:28:17 +0000 (09:28 +0000)]
Merge "BUG-1410 Fix config yang generator parsing dependency containers"
Tony Tkacik [Tue, 29 Jul 2014 08:04:05 +0000 (08:04 +0000)]
Merge changes I442a0ee9,I11825b90
* changes:
Fix a typo
BUG-1281: call static methods
Maros Marsalek [Tue, 29 Jul 2014 07:58:10 +0000 (09:58 +0200)]
BUG-1410 Fix config yang generator parsing dependency containers
Check if the grouping used is of type service-ref.
Until now, any container containing grouping was considered a dependency.
Add test for this case.
Change-Id: I9299b2b39e393d940c71a41f8d33d737564f2530
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Fri, 18 Jul 2014 12:29:39 +0000 (14:29 +0200)]
WIP: Backwards compatible MountPointService
Change-Id: Ifd28301ddd08d4edba93dba04a4d38c2ee13078a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Fri, 25 Jul 2014 11:13:47 +0000 (13:13 +0200)]
Fix children element lookup in XmlElement
Change-Id: I38220acbfedf8f1b8554516f6abda4c1a16dd2ee
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Thu, 24 Jul 2014 15:09:53 +0000 (17:09 +0200)]
Fix config attributes with same names for different modules.
Yang does not allow attributes in different cases to have the same name.
In yang modules for config, the configuration is located in cases and if 2 cases in same yang module contain child with same name, the transformation of data from CompositeNode to NormalizedNode
NOTE: This might break bgpcep and SP distribution, check.
Change-Id: I9bad24df9ac149da74b745ff648c72345e33deb1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Moiz Raja [Tue, 29 Jul 2014 04:26:34 +0000 (04:26 +0000)]
Merge "Fix for -Pintegrationtest profile"
Ed Warnicke [Tue, 29 Jul 2014 00:44:57 +0000 (19:44 -0500)]
Fix for -Pintegrationtest profile
The -Pintegrationtest profile was not including
the restconf config file.
Change-Id: Ic62da8f4532aeeda19a1836c08214fa795d84b98
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Moiz Raja [Wed, 9 Jul 2014 22:11:23 +0000 (15:11 -0700)]
Initial support for multiple-shards
Change-Id: Ic58d2dc9198b88c689143a9d85a612016b6bfa22
Signed-off-by: Moiz Raja <moraja@cisco.com>
Basheeruddin Ahmed [Wed, 9 Jul 2014 19:41:38 +0000 (12:41 -0700)]
Changed RegisterChangeListener and RegisterChangeListenerReply
in distributed datastore to be based on protocol buffer
ListenerRegistrationMessages
Change-Id: Ia1e427ca4d60336bb1cbf774c19fada4a1d0aed1
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Basheeruddin Ahmed [Wed, 9 Jul 2014 17:36:48 +0000 (10:36 -0700)]
ReadData and ReadDataReply protobuff messages
in distributed datastore
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Change-Id: Ia8353fc70d7af8589de855fee82ec79f06c7a36b
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Moiz Raja [Wed, 9 Jul 2014 00:20:55 +0000 (17:20 -0700)]
Make CompositeModification serializable using protocol buffers
Change-Id: I3e91452b0244c6adec84c000e83d7f993b2a59b7
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Tue, 8 Jul 2014 21:57:48 +0000 (14:57 -0700)]
Switch to using protocol buffer serialization for the WriteData message
- This commit also fixes an issues with the NodeToNormalizedNodeBuilder where an empty container node was decode with a leaf node within
- MergeData and WriteData are passed in their serialized forms from the TransactionProxy as well
Change-Id: I22eab6059becd427a9f0fae1a9273c8c4e293ee5
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Tue, 8 Jul 2014 19:44:05 +0000 (12:44 -0700)]
Store schemaContext in ActorContext so that all proxy objects can have access to it
Use it for MergeData and WriteData message construction
Change-Id: I20df92fc77c41016df7cc6f737226368b25b5a0f
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Tue, 8 Jul 2014 19:20:12 +0000 (12:20 -0700)]
Use Protocol Buffers to Serialize DeleteData
Change-Id: I2d96007610a28929e1e046a11726b33bec67394f
Signed-off-by: Moiz Raja <moraja@cisco.com>
Basheeruddin Ahmed [Tue, 8 Jul 2014 19:03:00 +0000 (12:03 -0700)]
Included MergeData and updated WriteData,DeleteData
protobuff messages
Change-Id: Id374c10dd47f725630cf7a92e9b0b5bc9c7764d5
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Basheeruddin Ahmed [Tue, 8 Jul 2014 18:40:40 +0000 (11:40 -0700)]
ReadData message using protocol buffer
and InstanceIdentifierUtils
Change-Id: I57100033200fc38d69ab6aa04841e8bc7546839c
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Moiz Raja [Tue, 8 Jul 2014 18:17:52 +0000 (11:17 -0700)]
Pattern for switching from POJO messages to Protocol Buffer messages
Change-Id: I053581bc66cdd2627132af7366e01d8276a7c27e
Signed-off-by: Moiz Raja <moraja@cisco.com>
Basheeruddin Ahmed [Tue, 8 Jul 2014 14:10:55 +0000 (07:10 -0700)]
NormalizedNode serialization using protocol buffer
Utilization of CreateTransactionReply protocol buffer
message in Distributed Datastore
Subsequent commits will utilize other portocol buffer
messages in Distributed Datastore
Change-Id: I64c08d1998bab29a92351fc1fd5897d0faaf4081
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>
Robert Varga [Mon, 28 Jul 2014 19:31:45 +0000 (21:31 +0200)]
Fix a typo
Just a test name fix.
Change-Id: I442a0ee951475fb247eca4117ad61ed315a39dfc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 28 Jul 2014 19:11:36 +0000 (21:11 +0200)]
BUG-1281: call static methods
This is just a cleanup of warnings.
Change-Id: I11825b90b415c77074ff8684feaba918876e0c95
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 28 Jul 2014 17:45:38 +0000 (17:45 +0000)]
Merge "Introduction of XSQL"
Tony Tkacik [Mon, 28 Jul 2014 15:05:01 +0000 (15:05 +0000)]
Merge "Wiring rest-connector with config subsytem."
Tony Tkacik [Mon, 28 Jul 2014 15:02:06 +0000 (15:02 +0000)]
Merge "Improve RESTCONF QName parsing speed"
Ed Warnicke [Mon, 28 Jul 2014 14:06:45 +0000 (14:06 +0000)]
Merge "Updated remote rpc code after integration tests. Rpc execution is failing because of one existing defect"
Ed Warnicke [Thu, 24 Jul 2014 19:12:18 +0000 (14:12 -0500)]
Wiring rest-connector with config subsytem.
Change-Id: If826bb7352101833acd288b81cbcf7cec2f28b43
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:32:53 +0000 (06:32 +0200)]
Improve RESTCONF QName parsing speed
SchemaContext provides useful (and optimized) methods for looking up
modules. Eliminate home-grown version of findModuleByName(). Requires
https://git.opendaylight.org/gerrit/#/c/9351/ .
Change-Id: I4c4e07e23a614b46b01a87485965af0c066aa693
Signed-off-by: Robert Varga <rovarga@cisco.com>
Sharon Aicler [Mon, 21 Jul 2014 17:47:41 +0000 (10:47 -0700)]
Introduction of XSQL
XSQL is SQL wrapper for MD-SAL Data Broker
which provides query capabilities for MD-SAL
YANG model is rendered as set of virtual tables
and where leafs are columns in that table.
For more information see
https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:XSQL
Change-Id: I9224c100ffe5e50559fc7181f1c9a79b3f7b2a32
Signed-off-by: Sharon Aicler <saichler@cisco.com>
Tony Tkacik [Mon, 28 Jul 2014 12:24:45 +0000 (12:24 +0000)]
Merge "BUG-432: migrate users of Registration as appropriate"
Tony Tkacik [Mon, 28 Jul 2014 12:04:31 +0000 (12:04 +0000)]
Merge "RPC registrations should not throw"
Tony Tkacik [Mon, 28 Jul 2014 09:01:25 +0000 (09:01 +0000)]
Merge "Deprecating unused get{Provider,Consumer} Functionality"
Tony Tkacik [Mon, 28 Jul 2014 09:01:02 +0000 (09:01 +0000)]
Merge "Removed BundleContext from Broker.register{Consumer,Provider} (Part 2)"
Tony Tkacik [Mon, 28 Jul 2014 09:00:21 +0000 (09:00 +0000)]
Merge "Removed BundleContext from Broker.register{Consumer,Provider}"
Tony Tkacik [Mon, 28 Jul 2014 08:56:53 +0000 (08:56 +0000)]
Merge "Optimize RESTCONF module/node parsing"
Tony Tkacik [Mon, 28 Jul 2014 08:56:39 +0000 (08:56 +0000)]
Merge "Improve RESTCONF thread safety when reconfiguring"
Tony Tkacik [Mon, 28 Jul 2014 08:56:15 +0000 (08:56 +0000)]
Merge "Allow getChildNodes() to become a Collection"
Tony Tkacik [Mon, 28 Jul 2014 08:53:03 +0000 (08:53 +0000)]
Merge "BUG-1381: do not use JavassistUtils.getLock()"
Robert Varga [Sun, 27 Jul 2014 20:27:21 +0000 (22:27 +0200)]
BUG-432: migrate users of Registration as appropriate
This patch adjust all users to the non-generic nator of Registration,
plus migrates a few to ListenerRegistration.
Change-Id: I69c1c61890f866d24a4b50e685bddba32bac7815
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 25 Jul 2014 12:39:27 +0000 (14:39 +0200)]
RPC registrations should not throw
Change-Id: I7f7f13ea7bdce3db5e833e3532c2e5db873daf74
Signed-off-by: Robert Varga <rovarga@cisco.com>
Moiz Raja [Fri, 25 Jul 2014 00:47:41 +0000 (17:47 -0700)]
Enhance code documentation and add TODOs
This commit is based on a code walk through done with Colin Dixon and
Abhishek Kumar.
TODOs and FIXMEs have been added to guide further development.
The major things that need to be completed are,
1. Installing snapshots
2. Adding and removing a new peer with consensus
3. Optimizing AppendEntries (faster synchronization)
Change-Id: Ic788e050fe8fa591176a927906004fd2277e29fa
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Sun, 20 Jul 2014 07:59:05 +0000 (00:59 -0700)]
Fix bug in ReplicatedLogImpl#removeFrom and use akka-persistence for removing entries
The way things were coded in removeFrom assumed that when a set of entries was deleted
from the persistent log the sequence number would be reset. This is most likely to not be
the case.
Switched to usage which is more appropriate for akka-persistence namely to persist
the operation to delete entries in the akka-persistence journal and on recovery take the
appropriate action.
Also since now we are using the akka-persistence journal purely for persistence we can safely
add other stuff to the journal and so I added UpdateElectionTerm also to the journal. This
takes care of persisting the election information in the same journal.
Change-Id: I34202535711660f19b4cdd9e71a7b55fde7433ce
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Sun, 20 Jul 2014 02:49:42 +0000 (19:49 -0700)]
Remove the confusion around suggestedState
The code has been refactored so that it is clear how exactly a state is
applied. Earlier the state was being passed around and the decision of which
state was returned was not clear.
Tests were modified as appropriate.
Change-Id: Ifb3d339affcc206d1358119defd4b7400e247f8b
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Fri, 18 Jul 2014 12:03:48 +0000 (05:03 -0700)]
Fix issue when adding new peers
- There a couple of cases that were not being handled correctly
in Follower#handleAppendEntries this had to be fixed
- ReplicatedLogImpl#size was not properly reported
Change-Id: I8af214cb46a5bae844d1e20e8788502255ffeab5
Signed-off-by: Moiz Raja <moraja@cisco.com>
Kamal Rameshan [Thu, 17 Jul 2014 23:43:40 +0000 (16:43 -0700)]
Test driver and changes related to it
Change-Id: I6f638dd4f4ce56be2ad31f056394568adeba165c
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Wed, 16 Jul 2014 16:17:32 +0000 (09:17 -0700)]
Initial implementation of saving and installing snapshots
This commit basically sketches out how creating and installing snapshots would fit into
the overall design. This has not been tested yet.
Change-Id: I0c575049e8dbda6b63e49dab80ff0980546029d3
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Wed, 16 Jul 2014 12:35:58 +0000 (05:35 -0700)]
Test handling of the Replicate message by the Leader
Refactored some code, added comments and a test
Change-Id: I0719dbdb4f1f6da611b090faa6cabc84b85e50df
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Mon, 14 Jul 2014 01:52:50 +0000 (18:52 -0700)]
Test RaftActor using a simple program
Change-Id: Id0a8091c8f6ee89178bf774be398647c60a25d03
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Sun, 13 Jul 2014 01:46:15 +0000 (18:46 -0700)]
Implement handling of AppendEntries from a recipient perspective
This commit includes everything that a recipient will do when it receives an AppendEntries
except applying of the state to the state machine
Change-Id: I9131b7b73624527efb1a7cb7f0c999fa03f90dfd
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Sat, 12 Jul 2014 12:39:52 +0000 (05:39 -0700)]
Properly handle RequestVote in all states
Change-Id: I31987824a2219be230e439ecb152e031c749d4ef
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Sat, 12 Jul 2014 00:12:59 +0000 (17:12 -0700)]
Complete Candidate behavior implementation
Change-Id: I483ec7d0a3430e186decda7ac45258b47132694b
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Sat, 26 Jul 2014 21:43:57 +0000 (21:43 +0000)]
Merge "Remove RaftReplicator and move hearbeat logic to the leader"
Moiz Raja [Sat, 26 Jul 2014 21:42:54 +0000 (21:42 +0000)]
Merge "Implement behavior common to a RaftActor in all it's states"
Moiz Raja [Sat, 26 Jul 2014 21:40:02 +0000 (21:40 +0000)]
Merge "Initial code/design for an Akka Raft implementation"
Robert Varga [Sat, 26 Jul 2014 04:41:44 +0000 (06:41 +0200)]
Optimize RESTCONF module/node parsing
Profiling has shown that the current implementations are still not upto
par with what they should be: 189 invocations of the two consumed 64ms,
with most of the time being spent splitting and iterating.
Given that the parsing operation is really simple, we can do much better
using String.indexOf() and String.substring().
Change-Id: I06ef0403edb2c8d12cbbc3c7909091e9efc5138e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:18:40 +0000 (06:18 +0200)]
Improve RESTCONF thread safety when reconfiguring
There is a race which could see us without a populated mapping while a
schemacontext change is underway. Use a immutablemap guarded by an
atomicreference to allow proper switching. Note that the fix is
incomplete, as the schema context needs to be replaced at the same time.
Change-Id: I7d64fae99a0bc0f7d1ec19f08450c1954cb7af97
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 26 Jul 2014 04:06:52 +0000 (06:06 +0200)]
Allow getChildNodes() to become a Collection
Preparatory patch for yangtools change -- getChildNodes() will start
returning a Collection, not a Set.
Change-Id: Ie7255757e3f48465e3acd9e65764f1b79a3a9511
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tom Pantelis [Fri, 25 Jul 2014 21:08:41 +0000 (21:08 +0000)]
Merge "Bug 1417 - Removed extraneous pom dep on flow-management-compatibility"
Robert Varga [Fri, 25 Jul 2014 13:33:05 +0000 (15:33 +0200)]
BUG-1381: do not use JavassistUtils.getLock()
We have it now synchronized through the instance, so there's no need for
getLock().
Change-Id: I3e962f284132b376f77e9e2665b3fbb47f246514
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Fri, 25 Jul 2014 12:21:31 +0000 (07:21 -0500)]
Deprecating unused get{Provider,Consumer} Functionality
Provider.getProviderFunctionality
Consumer.getConsumerFunctionality
interface ProviderFunctionality
interface ConsumerFunctionality
are unused. They should go away, so this patch marks
them as deprecated.
Change-Id: Icfcbf9f4cfed0186c720eab26405894183b9009f
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Tony Tkacik [Fri, 25 Jul 2014 12:25:15 +0000 (12:25 +0000)]
Merge "Bug 1178 - removed unused parameter from checkOdAction() menthod."
Ed Warnicke [Fri, 25 Jul 2014 12:05:21 +0000 (07:05 -0500)]
Removed BundleContext from Broker.register{Consumer,Provider} (Part 2)
Moved the bodies of the methods around to make the deprecated
methods just call throughs to the new methods.
Removed extra argument from private method newSessionFor
Change-Id: I748662491e6670262ecfad4122bcc7a9f831107d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Fri, 25 Jul 2014 12:00:14 +0000 (07:00 -0500)]
Removed BundleContext from Broker.register{Consumer,Provider}
Don't freak out... the old methods are still there, just
deprecated.
Change-Id: I6f37af7d93948bbf0d3b23635c73803645028ec7
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Tony Tkacik [Fri, 25 Jul 2014 11:17:52 +0000 (11:17 +0000)]
Merge "BUG-1381: make users of JavassistUtils.getLock synchronized properly"
Tony Tkacik [Fri, 25 Jul 2014 11:16:05 +0000 (11:16 +0000)]
Merge "Override TransactionFactor method in DataBroker to return correct TransactionChain."
Maros Marsalek [Thu, 24 Jul 2014 11:43:09 +0000 (13:43 +0200)]
Make DOMMountPointService listenable
Change-Id: Ic44a4bf214f6f6a6d653627b6a62ab2f47bd9963
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tom Pantelis [Thu, 24 Jul 2014 19:44:19 +0000 (19:44 +0000)]
Merge "Bug 1280: Added option to automaticly create parents"
jameshall03885 [Thu, 24 Jul 2014 18:24:44 +0000 (14:24 -0400)]
Bug 1417 - Removed extraneous pom dep on flow-management-compatibility
Change-Id: Ie39e5328b809c4a82b3c971f02392c01cbfb1302
Signed-off-by: jameshall03885 <ghall@brocade.com>
Ed Warnicke [Thu, 24 Jul 2014 16:10:58 +0000 (16:10 +0000)]
Merge "Bug 1378: Make sure config extender does not block bundle loading."
Robert Varga [Wed, 16 Jul 2014 21:07:27 +0000 (23:07 +0200)]
BUG-1381: make users of JavassistUtils.getLock synchronized properly
As a transition period, use both locking schemes. Once the initial
patches are in, we can then remove the use of getLock().
Change-Id: Ibf4c0ea9f420d81dfe74f7b0c5479f01b45a8d2d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Thu, 24 Jul 2014 09:30:11 +0000 (11:30 +0200)]
Override TransactionFactor method in DataBroker to return correct TransactionChain.
Change-Id: Ib86159c8faa8ddd729b9abc69ea7708fd4b086f3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Wed, 23 Jul 2014 14:38:09 +0000 (16:38 +0200)]
Bug 1378: Make sure config extender does not block bundle loading.
Change-Id: Ic706ad9dd41ad951e0517e02b7f1f3b8b25ea9ea
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tom Pantelis [Wed, 23 Jul 2014 14:30:44 +0000 (14:30 +0000)]
Merge "Bug 279, 1390: Used Guava Cache r for lazy-loading of RPC Routers"
Jozef Gloncak [Wed, 23 Jul 2014 11:55:21 +0000 (13:55 +0200)]
BUG 1144 - response 500 instead of 400
RestconfDocumentedException with error tag INVALID_VALUE (400) was caught and
wrapped to RestconfDocumentedException with error tag OPERATION_FAILED
(500)
Change-Id: I0ad75958e0d8e25d5bf1bdf7cbac5f855cc2b03d
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Wed, 23 Jul 2014 10:14:46 +0000 (10:14 +0000)]
Merge "BUG 1359:Fixed using option 1"
Tony Tkacik [Wed, 23 Jul 2014 05:41:39 +0000 (05:41 +0000)]
Merge "NormalizedNode Mount APIs."
Moiz Raja [Wed, 23 Jul 2014 01:18:38 +0000 (01:18 +0000)]
Merge "Made config/mdsal/netconf features non-cyclic"
Tony Tkacik [Tue, 22 Jul 2014 15:43:21 +0000 (15:43 +0000)]
Merge "BUG-692 Fix intermittent failure in NetconfDeviceTest"
Maros Marsalek [Fri, 18 Jul 2014 12:28:53 +0000 (14:28 +0200)]
NormalizedNode Mount APIs.
Change-Id: Iee3b7101642bde9aa1a38150ee2a62b84c3de1fb
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Tue, 22 Jul 2014 15:05:55 +0000 (15:05 +0000)]
Merge "Optimize netconf capability handling"
Tony Tkacik [Tue, 22 Jul 2014 15:03:11 +0000 (15:03 +0000)]
Merge "BUG-865: do not use InstanceIdentifier.getPath()"
Devin Avery [Tue, 22 Jul 2014 13:43:37 +0000 (13:43 +0000)]
Merge "API Usability: Introduced type capture for Transaction Factory"
Robert Varga [Sat, 19 Jul 2014 14:53:14 +0000 (16:53 +0200)]
Optimize netconf capability handling
Inefficient splitting, forward scans and similar. This patch
optimizes it as much as possible.
Change-Id: Ibf52b3b8f512c6b4936dca3089e73bbb1671eaa7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 19 Jul 2014 14:02:02 +0000 (16:02 +0200)]
BUG-865: do not use InstanceIdentifier.getPath()
InstanceIdentifier exposes the reverse path via a dedicated method, so
use that rather than home-brewing our own.
Change-Id: I3568bf8fc294e235a9f5bae8a72d6cd89079b348
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jozef Gloncak [Tue, 22 Jul 2014 07:06:11 +0000 (09:06 +0200)]
BUG 1379 - rpcs behind yang-ext:mount aren't always executed
new corrected behavior:
If rpc is from device behing yang-ext:mount and it doesn't exist in
controller then it is ALSO executed.
Change-Id: Ieebf2522b39cd42a8da57b05cf49e528c924f7ba
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Maros Marsalek [Tue, 22 Jul 2014 07:01:01 +0000 (09:01 +0200)]
BUG-692 Fix intermittent failure in NetconfDeviceTest
Error in NetconfDeviceTest.testNotificationBeforeSchema, verification without timeout was performed before the actual call.
Fixed by adding timeout to all verifications.
Change-Id: I494523036fff456d66398f0d17b0003fe6c083a0
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Giovanni Meo [Tue, 22 Jul 2014 06:28:34 +0000 (06:28 +0000)]
Merge "Flow request containing an invalid action should be rejected"
Vaishali Mithbaokar [Tue, 22 Jul 2014 01:41:12 +0000 (18:41 -0700)]
BUG 1359:Fixed using option 1
Change-Id: Idb744e4c1eab70ee8a3eeaaf8194f33f91aa84d4
Signed-off-by: Vaishali Mithbaokar <vmithbao@cisco.com>
Ed Warnicke [Tue, 22 Jul 2014 01:14:13 +0000 (20:14 -0500)]
Made config/mdsal/netconf features non-cyclic
We previously had some cross dependency between config-features and
netconf-features. This is highly undesirable because it
precludes folks being able to simply have a maven dependency for the
one feature they want and requires enumerating *all* the feature
files.
This fixes that by pulling out
features/config-netty
features/config-persister
from
features/config
So the dependency graph is now non-cyclic:
config-netty -> config-persister
config-persister -> (netconf,config)
netconf -> (config,protocol-framework)
Change-Id: Ie662df40bd6985e2ecd4280596ddafc947e5edd0
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Harman Singh [Tue, 8 Jul 2014 00:11:22 +0000 (17:11 -0700)]
Updated remote rpc code after integration tests. Rpc execution is failing because of one existing defect
Change-Id: Ic51bba7088371b4428624da9744e0563abdc4a95
Signed-off-by: Harman Singh <harmasin@cisco.com>
Devin Avery [Mon, 21 Jul 2014 14:16:31 +0000 (14:16 +0000)]
Merge "Change put/merge methods to be type-safe in WriteTransaction"
tpantelis [Sat, 12 Jul 2014 10:53:46 +0000 (06:53 -0400)]
Change put/merge methods to be type-safe in WriteTransaction
Removed declaration of put/merge methods from the common
AsyncWriteTransaction interface.
Defined put/merge methods in the derived Binding and DOM interfaces.
The Binding methods were made type-safe.
Javadoc usage/examples for the methods was put into the
AsyncWriteTransaction class docs and is linked to by the derived
interfaces.
This change is source-code compatible - no client code needs to change
(unless a client actually is incompatible path and data).
Change-Id: I779f6477f1c98e299c5d559043da612be97bfbe6
Signed-off-by: tpantelis <tpanteli@brocade.com>
Tony Tkacik [Fri, 11 Jul 2014 09:33:51 +0000 (11:33 +0200)]
Bug 1352: Added regression test to InMemory Data Store.
Change-Id: Ia3a4e332c275d6dfdf9dafd2dfc433de15dbcb6f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 11:48:03 +0000 (13:48 +0200)]
Fixed incorrect XML test suites & Usage of removed API
Change in underlying YANG Tools codec, unvereded
that there were test-suites which did string
comparison for testing of XML responses and
any change in XML serialization (valid from
XML point-of-view) triggered this tests to
fail.
Reworked offending tests to use XML W3C Document
for testing instead of string comparison and regexes.
Change-Id: Ib6e35e8d2fe79275666235370d1dda461277a59f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 09:40:53 +0000 (09:40 +0000)]
Merge "BUG 1387 - degrade log output from info to debug"
Tony Tkacik [Mon, 21 Jul 2014 09:11:50 +0000 (09:11 +0000)]
Merge "Bug 1362: New AsyncWriteTransaction#submit method"
Jozef Gloncak [Mon, 21 Jul 2014 08:48:29 +0000 (10:48 +0200)]
BUG 1387 - degrade log output from info to debug
Change-Id: Ia98ab154bb53cc3c43f42270a3bd6c65bd9dee65
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Mon, 21 Jul 2014 08:08:41 +0000 (08:08 +0000)]
Merge "Bug 1239 - Clean up and refactor netconf-ssh client"
Moiz Raja [Fri, 11 Jul 2014 20:30:28 +0000 (13:30 -0700)]
Remove RaftReplicator and move hearbeat logic to the leader
This makes more sense. The RaftReplicator does not seem to add any value.
Change-Id: Id3cf8ecbd2493b35c1a32382d65876795a78fa30
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Fri, 11 Jul 2014 01:37:22 +0000 (18:37 -0700)]
Implement behavior common to a RaftActor in all it's states
The common behavior for a RaftActor is
- Change state to follower when it receives a RaftRPC with a newer term
- Increment the applied state of the commitIndex of the AppendEntries message
is higher than it's applied state
Change-Id: I1fc0cdcb90368f3c07f555b307ac827286386651
Signed-off-by: Moiz Raja <moraja@cisco.com>
Code Review / controller.git / log