controller.git
7 years agoMerge "Statistics-Manager - Performance Improvement 1) Introduced statistics request...
Ed Warnicke [Tue, 29 Apr 2014 15:08:14 +0000 (15:08 +0000)]
Merge "Statistics-Manager - Performance Improvement 1) Introduced statistics request scheduler, to schedule request based on the current transaction load on MD-SAL DataStore. Each node submit all individual statistics request to schedular for execution 2) Send statistics request if there is no MD-SAL trasaction pending. It just keep tracks of the MD-SAL trasaction triggered by statistics-manager 3) Removal of stale statistics is now done based on counter rather then time values. Time based removal will break in case of clustered environment. 4) Code clean up Change-Id: Ie7522d0c60f2c7051dbfcdf9a6657843ef4da743 Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>"

7 years agoMerge "Fixing an unsorted pom change"
Giovanni Meo [Tue, 29 Apr 2014 14:18:45 +0000 (14:18 +0000)]
Merge "Fixing an unsorted pom change"

7 years agoMerge "Resolve Bug:853 - remove groovy from config code generator."
Ed Warnicke [Tue, 29 Apr 2014 12:13:46 +0000 (12:13 +0000)]
Merge "Resolve Bug:853 - remove groovy from config code generator."

7 years agoFixing an unsorted pom change 88/6588/1
Giovanni Meo [Tue, 29 Apr 2014 09:00:35 +0000 (11:00 +0200)]
Fixing an unsorted pom change

- This would cause changes every time someone builds

Change-Id: I134067fe52d9405f20b777db05e5710d10c12666
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoMerge changes Ie84ea1ff,Ifa0a97da
Tony Tkacik [Tue, 29 Apr 2014 08:32:33 +0000 (08:32 +0000)]
Merge changes Ie84ea1ff,Ifa0a97da

* changes:
  BUG-848 Make base capabilities from netconf server configurable
  BUG-848 Fix netconf communication while using CHUNK encoding

7 years agoMerge "Allow to disable default gw feature"
Giovanni Meo [Tue, 29 Apr 2014 08:15:35 +0000 (08:15 +0000)]
Merge "Allow to disable default gw feature"

7 years agoBUG-848 Make base capabilities from netconf server configurable 44/6544/2
Maros Marsalek [Mon, 28 Apr 2014 13:41:35 +0000 (15:41 +0200)]
BUG-848 Make base capabilities from netconf server configurable

Refactor ConcurrentClientsTest, add cases for different netconf server configuration (EXI/CHUNK)

Change-Id: Ie84ea1ff716b11b0da49e0498127a0defc86f41f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG-848 Fix netconf communication while using CHUNK encoding 43/6543/2
Maros Marsalek [Mon, 28 Apr 2014 09:12:08 +0000 (11:12 +0200)]
BUG-848 Fix netconf communication while using CHUNK encoding

Cause:
When using Chunk encoding, the negotiation process lasts longer due to pipeline manipulation.
Messages received while still in negotiation were not processed correctly (This is incorrect, messages should not be processed while still in negotiation).

Fix:
Introduce a message barrier that will forward only hello message until negotiation is completed (implemented in NetconfXmlToHelloMessageDecoder).
Modify SessionNegotiators to replace message barier/hello decoder when negotiation is finished and to process non-hello messages stopped by the barier.

* Exclude pax-url-aether dependency in netconf-it

Change-Id: Ifa0a97da75ac3cdca29e29bf40138b637e08ff45
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "Fixed typo in test name. Temporary ignore test."
Ed Warnicke [Mon, 28 Apr 2014 12:30:31 +0000 (12:30 +0000)]
Merge "Fixed typo in test name. Temporary ignore test."

7 years agoMerge "Resolve Bug:748 - Remove test resources from netconf-impl."
Ed Warnicke [Mon, 28 Apr 2014 12:28:30 +0000 (12:28 +0000)]
Merge "Resolve Bug:748 - Remove test resources from netconf-impl."

7 years agoMerge changes I8e90a7d5,I25249fe8
Ed Warnicke [Mon, 28 Apr 2014 12:21:45 +0000 (12:21 +0000)]
Merge changes I8e90a7d5,I25249fe8

* changes:
  Resolve Bug:807 - Keep ModuleFactory references shutdown purposes.
  Resolve Bug:681 - Fix config module registration to Service Registry.

7 years agoMerge "BUG 652 leafref CCE & BUG 720 colons problem"
Ed Warnicke [Mon, 28 Apr 2014 12:21:21 +0000 (12:21 +0000)]
Merge "BUG 652 leafref CCE & BUG 720 colons problem"

7 years agoMerge "Bug 460 - Fix warning throughout netconf subsystem"
Ed Warnicke [Mon, 28 Apr 2014 12:18:40 +0000 (12:18 +0000)]
Merge "Bug 460 - Fix warning throughout netconf subsystem"

7 years agoMerge "Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery"
Ed Warnicke [Mon, 28 Apr 2014 12:16:33 +0000 (12:16 +0000)]
Merge "Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery"

7 years agoMerge "BUG-732 Fix sal-netconf-connector unable to download schemas"
Tony Tkacik [Mon, 28 Apr 2014 12:01:53 +0000 (12:01 +0000)]
Merge "BUG-732 Fix sal-netconf-connector unable to download schemas"

7 years agoResolve Bug:853 - remove groovy from config code generator. 35/6535/1
Tomas Olvecky [Mon, 28 Apr 2014 12:01:23 +0000 (14:01 +0200)]
Resolve Bug:853 - remove groovy from config code generator.

Replace 3 groovy classes with java equivalents.

Change-Id: I625f0498c3ccaedf0441c637ac61a9653c98e579
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoMerge "Cleaned Commons POM prerequisites for Karaf distribution"
Giovanni Meo [Mon, 28 Apr 2014 10:10:35 +0000 (10:10 +0000)]
Merge "Cleaned Commons POM prerequisites for Karaf distribution"

7 years agoBUG-732 Fix sal-netconf-connector unable to download schemas 56/6356/7
Maros Marsalek [Thu, 24 Apr 2014 12:09:02 +0000 (14:09 +0200)]
BUG-732 Fix sal-netconf-connector unable to download schemas

BUG#1 NetconfDeviceListener used wrong method to parse rpc results
BUG#2 Parsing rpc result in NetconfMapping was looking for schema to response even if it was not needed
BUG#3 Netconf client sent base netconf capability in wrong format

Change-Id: I4798b29bb8cd7361d24188b6d5ac40a612a0c6c8
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBug 460 - Fix warning throughout netconf subsystem 99/5599/14
Martin Bobak [Mon, 10 Mar 2014 16:11:35 +0000 (17:11 +0100)]
Bug 460 - Fix warning throughout netconf subsystem

Change-Id: I461a7bab47ef67c13c6fd5864d8938cdd47c3c8b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoStatistics-Manager - Performance Improvement 85/5785/5
Anil Vishnoi [Tue, 25 Mar 2014 21:49:09 +0000 (03:19 +0530)]
Statistics-Manager - Performance Improvement
1) Introduced statistics request scheduler, to schedule request based on the current transaction load on MD-SAL DataStore.
Each node submit all individual statistics request to schedular for execution
2) Send statistics request if there is no MD-SAL trasaction pending.
It just keep tracks of the MD-SAL trasaction triggered by statistics-manager
3) Removal of stale statistics is now done based on counter rather then time values.
Time based removal will break in case of clustered environment.
4) Code clean up
Change-Id: Ie7522d0c60f2c7051dbfcdf9a6657843ef4da743
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>
7 years agoBug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery 41/6441/1
Debolina Bandyopadhyay [Fri, 25 Apr 2014 21:50:53 +0000 (14:50 -0700)]
Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery

Change-Id: Iec8335fadd5f1529b3f04288805bda2f5594cc94
Signed-off-by: Debolina Bandyopadhyay <dbandyop@cisco.com>
Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery

Change-Id: Ie5d82011676aac2b8750fe1e6e46b89da8c3b4eb
Signed-off-by: Debolina Bandyopadhyay <dbandyop@cisco.com>
Removed @SuppressWarnings("all")

Change-Id: I4e012890813f94ec1edc66b538904a7c8bd2e41c
Signed-off-by: Debolina Bandyopadhyay <dbandyop@cisco.com>
7 years agoAllow to disable default gw feature 29/6429/2
Alessandro Boch [Sun, 27 Apr 2014 17:08:03 +0000 (10:08 -0700)]
Allow to disable default gw feature

- Default gateway is a good feature for having host discovery, and
  consequently hosts' pings, work out of the box.
  But in real scenarios a controlled network node may be connected to a
  legacy switch's trunk port which exposes thousand of hosts which ARP
  packets would easily stress controller functionality.
  Even though today this can be prevented by configuring a more
  specific subnet gateway, the issue is very much possible at first
  controller boot, and can always re-occur during subnet config manipulation
  if at any point of time we have no user configured subnet gateways.
- This patch provides a way to disable he default gw feature by mean of
  a property in config.ini. Property addition is not included, current
  behavior is unchanged.

Change-Id: I15b63233e3ed46a8a9fb57bb0988a0d4a2984b11
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoCleaned Commons POM prerequisites for Karaf distribution 07/6407/6
Mathieu Lemay [Fri, 25 Apr 2014 21:51:45 +0000 (17:51 -0400)]
Cleaned Commons POM prerequisites for Karaf distribution

Change-Id: I747b29407c853f72f532cedbe9044b93b66dcb6c
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
7 years agoFix Operation not permitted warning. 90/6390/1
Martin Bobak [Fri, 25 Apr 2014 14:05:48 +0000 (16:05 +0200)]
Fix Operation not permitted warning.

This fix removes warning
WARN  o.o.c.n.c.m.c.ModuleElementDefinition - Operation not permitted on
current strategy  while default strategy is merge. Element definition
strategy set to default

that occured on osgi startup.

Change-Id: Ic12ce37e9bfa08cfffd0cac0e591fc49ffe227c6
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoMerge "Bug 451 - Fix netconf exception handling"
Tony Tkacik [Fri, 25 Apr 2014 08:56:45 +0000 (08:56 +0000)]
Merge "Bug 451 - Fix netconf exception handling"

7 years agoMerge "BUG-832 Add initial configuration for controller self mount"
Tony Tkacik [Fri, 25 Apr 2014 08:02:04 +0000 (08:02 +0000)]
Merge "BUG-832 Add initial configuration for controller self mount"

7 years agoBug 451 - Fix netconf exception handling 12/5512/22
Martin Bobak [Mon, 3 Mar 2014 10:17:50 +0000 (11:17 +0100)]
Bug 451 - Fix netconf exception handling

Change-Id: I815b34da996cf2660650577edb2e8ca623ae96df
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoMerge "Bug-590: Packet loss on first time ping test"
Giovanni Meo [Thu, 24 Apr 2014 13:06:05 +0000 (13:06 +0000)]
Merge "Bug-590: Packet loss on first time ping test"

7 years agoBUG-832 Add initial configuration for controller self mount 52/6352/2
Maros Marsalek [Thu, 24 Apr 2014 07:56:48 +0000 (09:56 +0200)]
BUG-832 Add initial configuration for controller self mount

Netconf server for config subsystem is mounted to restconf under id "controller-config" by default

This illustrates the usage of sal-netconf-connector

Change-Id: I3f324b41995dc094bac0d316788dfdb05e18ef60
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "Bug 509: Added support for merge operation to InMemoryData Store"
Ed Warnicke [Thu, 24 Apr 2014 11:56:27 +0000 (11:56 +0000)]
Merge "Bug 509: Added support for merge operation to InMemoryData Store"

7 years agoBug-590: Packet loss on first time ping test 54/6354/1
Flavio Fernandes [Thu, 24 Apr 2014 11:06:37 +0000 (07:06 -0400)]
Bug-590: Packet loss on first time ping test

In this commit, we are addressing a race that could cause the exception (ie first ip packet) to
be lost. What is observed with this bug is that the non-arp packet -- in this case the icmp packet --
is being 'exceptioned' to the SimpleForwarding code path because the node has not yet been programmed
with flows that would allow it to forward the packet to its destination w/out involving the controller.

The race in this case is caused by the exceptioned packet being received before the rulesDB member
in simpleForwarding module is updated. That member -- rulesDB -- is updated via the
hostTracker::notifyHTClient() callback shortly after. In this particular race, the hostTracker is already
updated with the proper information, and rulesDB is 'stale'. Thus, the proposed fix is to make the forwarding
less strict (ie. ignore rulesDB). Note that both routing and hostTracker are all simpleForwarding needs to
know how to forward the packet.

Change-Id: Icfb909ca89abff6031212b4fcd0f5d1bd1a27d6b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
7 years agoBUG 652 leafref CCE & BUG 720 colons problem 35/6335/4
Jozef Gloncak [Wed, 23 Apr 2014 12:56:10 +0000 (14:56 +0200)]
BUG 652 leafref CCE & BUG 720 colons problem

BUG 652 leafref Class cast exception
By default if input data were in format which was possible to parse as
XPath if was done like this. It caused that for leafref which indexed to
instance-identifier the value was parsed as XPath and not as string.

BUG 720 colons problem in JSON
If input string contained colon (:) then it was dealed as namespace:value
and object of type IdentityValuesDTO was created (it is probable that
data could be of type identityref). If data wasn't of type leafref then it
was incorrectly processed as leafref.
The RestCodec was updated to correctly translate data (cases when data
contains ':' but aren't of type leafref)

Change-Id: I0cba06bce1b1c69f6901cc90d2b30a3735e5f57e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoBug 509: Added support for merge operation to InMemoryData Store 38/6338/3
Tony Tkacik [Wed, 23 Apr 2014 14:17:31 +0000 (16:17 +0200)]
Bug 509: Added support for merge operation to InMemoryData Store

Merge operation support is critical for backwards compatibility
and for Binding-Aware mapping and Restconf, which are not aware
of Mixin nodes representing lists, leaflists and choices.

Semantics of merge operation are similar to subtree modified,
but when node is not existing it creates one based on
state provided by user of the Data Broker APIs.

Merge operation also fixes concurrent creations of mixin nodes
as demonstrated in ConcurrentImplicitCreateTest,
where two separate applications may indirectly create same
root node.

Change-Id: I9ab290b512601bd99750a68ee53564e67ef0c879
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoBug 722 - nagasena version bumped to 0000.0002.0038 51/6351/3
Martin Bobak [Wed, 23 Apr 2014 12:43:32 +0000 (14:43 +0200)]
Bug 722 - nagasena version bumped to 0000.0002.0038

Change-Id: Ie755a9a613096aed6f134005d216716c59b90563
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoFixed typo in test name. Temporary ignore test. 25/6225/2
Martin Vitez [Wed, 16 Apr 2014 07:37:24 +0000 (09:37 +0200)]
Fixed typo in test name. Temporary ignore test.

Change-Id: Icdae59971bded5e76a181d4ab63132e011a561ca
Signed-off-by: Martin Vitez <mvitez@cisco.com>
7 years agoMerge "Bug 781: Statistics manager is throwing IllegalStateException"
Ed Warnicke [Wed, 23 Apr 2014 11:58:13 +0000 (11:58 +0000)]
Merge "Bug 781: Statistics manager is throwing IllegalStateException"

7 years agoMerge changes I67420353,I6851f9b9
Tony Tkacik [Wed, 23 Apr 2014 11:48:59 +0000 (11:48 +0000)]
Merge changes I67420353,I6851f9b9

* changes:
  Bug:701-Have Typed ErrorNotification for different node errors
  Bug:645 - MDSAL Notification pool threads not getting spawned besides the core threads

7 years agoResolve Bug:807 - Keep ModuleFactory references shutdown purposes. 12/6312/2
Tomas Olvecky [Tue, 22 Apr 2014 10:32:19 +0000 (12:32 +0200)]
Resolve Bug:807 - Keep ModuleFactory references shutdown purposes.

Retain ModuleFactory instances even if they disappear from OSGi SR,
so that the already committed instances can be closed cleanly. Also
remove shutdown customization (stopping config-manager as first bundle)
from shutdown-impl.

Change-Id: I8e90a7d593b7e4cc84c7a9a7d3f8bb804daf5f41
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoBUG-732 Add rollback-on-error error-option to edit-config rpcs from netconf-connector 05/6205/3
Maros Marsalek [Tue, 15 Apr 2014 14:00:27 +0000 (16:00 +0200)]
BUG-732 Add rollback-on-error error-option to edit-config rpcs from netconf-connector

Just in case rollback-on-error capability is supported

+ Add error response warning to netconf-connector

Change-Id: I16251a12b270bd0ed89b39bfccc5251b4b3fe934
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoResolve Bug:681 - Fix config module registration to Service Registry. 64/5964/6
Tomas Olvecky [Tue, 8 Apr 2014 14:22:48 +0000 (16:22 +0200)]
Resolve Bug:681 - Fix config module registration to Service Registry.

Rework OSGi service registration during second phase commit: only service references
will be registered into SR, instead of old behaviour when each module's service
interfaces were used. Only one key-value entry is persisted in registration:
{name: name of service reference} .

Change-Id: I25249fe8f9e51570cd3ea963e91145b7e44da57d
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoMerge "BUG-732 Fix netconf client deadlock when downloading yang schemas from remote...
Tony Tkacik [Wed, 23 Apr 2014 08:14:48 +0000 (08:14 +0000)]
Merge "BUG-732 Fix netconf client deadlock when downloading yang schemas from remote device"

7 years agoMerge "BUG-758 Eliminate xtend from sal-netconf-connector"
Tony Tkacik [Wed, 23 Apr 2014 08:14:25 +0000 (08:14 +0000)]
Merge "BUG-758 Eliminate xtend from sal-netconf-connector"

7 years agoMerge "fix for BUG-709 - mixed up flow cookie and connection cookie"
Tony Tkacik [Wed, 23 Apr 2014 08:11:13 +0000 (08:11 +0000)]
Merge "fix for BUG-709 - mixed up flow cookie and connection cookie"

7 years agoBug 781: Statistics manager is throwing IllegalStateException 98/6298/3
Anil Vishnoi [Mon, 21 Apr 2014 23:05:57 +0000 (04:35 +0530)]
Bug 781: Statistics manager is throwing IllegalStateException

Change-Id: I418bd4b86bbe9802be3ec7ed904a14ce537f085e
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>
7 years agoMerge "Bug-590: Packet loss on first time ping test"
Giovanni Meo [Tue, 22 Apr 2014 18:32:03 +0000 (18:32 +0000)]
Merge "Bug-590: Packet loss on first time ping test"

7 years agoBug-590: Packet loss on first time ping test 16/6316/3
Flavio Fernandes [Tue, 22 Apr 2014 15:39:36 +0000 (11:39 -0400)]
Bug-590: Packet loss on first time ping test

In this commit, we are addressing 2 issues that could cause the exception (ie first ip packet) to
be lost. What is observed with this bug is that the non-arp packet -- in this case the icmp packet --
is being 'exceptioned' to the SimpleForwarding code path because the node has not yet been programmed
with flows that would allow it to forward the packet to its destination w/out involving the controller.

Change #1: In cases when the src and dst ip are of hosts in the same node, the getRoute() call is going
to return 'null'. That is because the IRouting lookup will not find a path when src and dst nodes are
the same.

Change #2: When looking up the rulesDB, the key used was using the destHost and the node of the incoming
connector. It should be the destHost and the node of the destHost. Kudos go 100% to Giovanni on this.

Change-Id: I4861acd6ab6d7efe14b50d7537e4b920bffc8a75
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
7 years agoResolve Bug:748 - Remove test resources from netconf-impl. 01/6201/2
Tomas Olvecky [Tue, 15 Apr 2014 12:15:48 +0000 (14:15 +0200)]
Resolve Bug:748 - Remove test resources from netconf-impl.

Remove old testing resources that are not required in tests.

Change-Id: Idba3be129aa177fa2eb362032719c79fb30331ba
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoBUG-509, BUG-808: Added datastore support for lists without keys. 11/6311/1
Robert Varga [Tue, 22 Apr 2014 12:54:04 +0000 (14:54 +0200)]
BUG-509, BUG-808: Added datastore support for lists without keys.

The datastore needs to support users who do not specify a list key, but
how expect the item ordering to be retained.

Added test which test all three possible behaviours of list
statement: ordered map, unordered map and list without keys.

Change-Id: I9e136267f57a88e4d2a6a4476025c33497373518
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-732 Fix netconf client deadlock when downloading yang schemas from remote device 53/6253/2
Maros Marsalek [Thu, 17 Apr 2014 10:12:25 +0000 (12:12 +0200)]
BUG-732 Fix netconf client deadlock when downloading yang schemas from remote device

Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Change-Id: Ic70085655e38ebc1e159fd4ba4b93172e468f4ad

7 years agoBUG-758 Eliminate xtend from sal-netconf-connector 52/6252/2
Maros Marsalek [Wed, 16 Apr 2014 09:29:09 +0000 (11:29 +0200)]
BUG-758 Eliminate xtend from sal-netconf-connector

Change-Id: I6add3e5ef2790aab5f0cda886f40bc400ff81f8d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "BUG-732 Fix netconf-connector unable to detect monitoring capability"
Ed Warnicke [Tue, 22 Apr 2014 12:26:11 +0000 (12:26 +0000)]
Merge "BUG-732 Fix netconf-connector unable to detect monitoring capability"

7 years agoMerge "Update to new version of the artifacts proposed by jenkins-controller-version...
Giovanni Meo [Tue, 22 Apr 2014 08:19:07 +0000 (08:19 +0000)]
Merge "Update to new version of the artifacts proposed by jenkins-controller-version-changes-30"

7 years agoMerge "Bug-780: potential lock release being missed if error code path happens in...
Giovanni Meo [Tue, 22 Apr 2014 08:17:51 +0000 (08:17 +0000)]
Merge "Bug-780: potential lock release being missed if error code path happens in SimpleBroadcastHandlerImpl.java"

7 years agoMerge "tomcat Session manager to support clustering using infinispan"
Giovanni Meo [Tue, 22 Apr 2014 08:15:50 +0000 (08:15 +0000)]
Merge "tomcat Session manager to support clustering using infinispan"

7 years agoBug-780: potential lock release being missed if error code path happens in SimpleBroa... 97/6297/1
Flavio Fernandes [Mon, 21 Apr 2014 22:52:56 +0000 (18:52 -0400)]
Bug-780: potential lock release being missed if error code path happens in SimpleBroadcastHandlerImpl.java

Change-Id: Ie8749e5dfcb04042922293ed45e8f06d42de90ab
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
7 years agoMerge "Bug 509: Improve logging in InMemoryDataStore."
Ed Warnicke [Mon, 21 Apr 2014 21:35:07 +0000 (21:35 +0000)]
Merge "Bug 509: Improve logging in InMemoryDataStore."

7 years agotomcat Session manager to support clustering using infinispan 66/6266/3
Harman Singh [Thu, 17 Apr 2014 23:43:22 +0000 (16:43 -0700)]
tomcat Session manager to support clustering using infinispan

Change-Id: I65faff3a62f5c2cf3098e87b52649bf58a6e873a
Signed-off-by: Harman Singh <harmasin@cisco.com>
7 years agoUpdate to new version of the artifacts proposed by jenkins-controller-version-changes-30 93/6293/1
jenkins-controller [Sun, 20 Apr 2014 00:58:14 +0000 (00:58 +0000)]
Update to new version of the artifacts proposed by jenkins-controller-version-changes-30

Change-Id: I78f3db52695a984cfde7aee159f4bf2c40582b9d
Signed-off-by: jenkins-controller <jenkins-controller@opendaylight.org>
7 years agoRemove last instance of controller.version 85/6285/2
Giovanni Meo [Fri, 18 Apr 2014 15:48:21 +0000 (17:48 +0200)]
Remove last instance of controller.version

controller.version was still used in the config.ini so made sure to
fix it

Change-Id: I7739df2c16dae6ce0e2f26aa991ff0984963cc63
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoRemoved duplication of the yang-jmx-generator-plugin 84/6284/2
Giovanni Meo [Fri, 18 Apr 2014 15:25:11 +0000 (17:25 +0200)]
Removed duplication of the yang-jmx-generator-plugin

- Removed unnecessary duplications or a dependency of
yang-maven-plugin which would cause issues in the release process

Change-Id: I858d96d298d2ce6a3a6be87a0261a7f23c2d70e8
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoRemove unnecessary variable in netconf-it 83/6283/2
Giovanni Meo [Fri, 18 Apr 2014 14:09:09 +0000 (16:09 +0200)]
Remove unnecessary variable in netconf-it

- Another roadblock to release of artifact mdsal.version is used as
variable in netconf-it, remove it

Change-Id: I955b7796c46a0852fd74d2ce2d77a033669f5922
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoRemove dependencyManagement from MDSAL 82/6282/3
Giovanni Meo [Fri, 18 Apr 2014 13:56:31 +0000 (15:56 +0200)]
Remove dependencyManagement from MDSAL

- MDSAL dependencyManagement has been removed in favor of commons.opendaylight

Change-Id: Ia744c3a24cebb5bc218991037359e69071575fdc
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoMerge "sal-dom-binding-it is not a bundle but is marked so"
Alessandro Boch [Sat, 19 Apr 2014 19:50:05 +0000 (19:50 +0000)]
Merge "sal-dom-binding-it is not a bundle but is marked so"

7 years agosal-dom-binding-it is not a bundle but is marked so 86/6286/2
Giovanni Meo [Fri, 18 Apr 2014 16:05:40 +0000 (18:05 +0200)]
sal-dom-binding-it is not a bundle but is marked so

- The wrong type of bundle causes the bundle to fail to compile

Change-Id: I41571c45d25262bc5af0b65f1cab9fa6587ce290
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoMerge "bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim"
Alessandro Boch [Sat, 19 Apr 2014 19:08:22 +0000 (19:08 +0000)]
Merge "bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim"

7 years agoMerge "Remove hardcode yang.jmx.plugin"
Alessandro Boch [Sat, 19 Apr 2014 18:33:10 +0000 (18:33 +0000)]
Merge "Remove hardcode yang.jmx.plugin"

7 years agoMerge " Remove version mismatch in config.version"
Alessandro Boch [Fri, 18 Apr 2014 23:07:49 +0000 (23:07 +0000)]
Merge " Remove version mismatch in config.version"

7 years agoMerge "Ignore some auto-generated files"
Alessandro Boch [Fri, 18 Apr 2014 23:07:20 +0000 (23:07 +0000)]
Merge "Ignore some auto-generated files"

7 years agoMerge " Removed controller.version variable"
Madhu Venugopal [Fri, 18 Apr 2014 19:04:20 +0000 (19:04 +0000)]
Merge " Removed controller.version variable"

7 years agoMerge "Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statis...
Giovanni Meo [Fri, 18 Apr 2014 17:42:05 +0000 (17:42 +0000)]
Merge "Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics"

7 years agoRemove hardcode yang.jmx.plugin 81/6281/1
Giovanni Meo [Fri, 18 Apr 2014 13:40:51 +0000 (15:40 +0200)]
Remove hardcode yang.jmx.plugin

- Remove stale hardcode dependency

Change-Id: Ide87fd574cf6987a5d89bf31f9b078cad2033473
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years ago Remove version mismatch in config.version 80/6280/1
Giovanni Meo [Fri, 18 Apr 2014 13:32:50 +0000 (15:32 +0200)]
 Remove version mismatch in config.version

 - End goal was to remove several config.version present in the pom, in
 the making i cleaned some of the repetition in config parent pom and
 aligned with the commons.opendaylight
- Removed some more warning on the pom files

Change-Id: I6717ceb915fe90fa7313472eb03884de9d09235d
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoIgnore some auto-generated files 79/6279/1
Giovanni Meo [Fri, 18 Apr 2014 08:55:10 +0000 (10:55 +0200)]
Ignore some auto-generated files

- Some files under yang-test are autogenerated, ignore them

Change-Id: If8eebca103fffef50d11c2871e68530713e43d81
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years ago Removed controller.version variable 78/6278/1
Giovanni Meo [Fri, 18 Apr 2014 11:13:23 +0000 (13:13 +0200)]
 Removed controller.version variable

- controller.version doesn't make much sense given the BOM is composed
of different modules and the version of the pom.xml at root decide the
version of the whole while each component keeps his versioning.

Change-Id: I9cf6a0e8334cf2725f8e487148fe29cacdbec512
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
7 years agoMerge "Bug 773: SimpleForwardingImpl hits NPE when .frm member is null and new host...
Giovanni Meo [Fri, 18 Apr 2014 07:59:05 +0000 (07:59 +0000)]
Merge "Bug 773:  SimpleForwardingImpl hits NPE when .frm member is null and new host is discovered"

7 years agoMerge "BUG-472: fix integration test breakage"
Giovanni Meo [Fri, 18 Apr 2014 07:58:31 +0000 (07:58 +0000)]
Merge "BUG-472: fix integration test breakage"

7 years agoIncorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics 68/6268/1
Pramila Singh [Fri, 18 Apr 2014 03:24:12 +0000 (20:24 -0700)]
Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics

Change-Id: I6d146d946e721540f70065de4ca8d1b8be73d838
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoBug 773: SimpleForwardingImpl hits NPE when .frm member is null and new host is... 67/6267/1
Flavio Fernandes [Fri, 18 Apr 2014 02:26:03 +0000 (22:26 -0400)]
Bug 773:  SimpleForwardingImpl hits NPE when .frm member is null and new host is discovered

Change-Id: Iba0986cec7f8cc999b2d9852b2bf21b2c5ba3c6f
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
7 years agoMerge "BUG-509: use dedicated executor for notifications"
Tony Tkacik [Thu, 17 Apr 2014 17:16:19 +0000 (17:16 +0000)]
Merge "BUG-509: use dedicated executor for notifications"

7 years agoBUG-509: use dedicated executor for notifications 62/6262/2
Robert Varga [Thu, 17 Apr 2014 16:48:22 +0000 (18:48 +0200)]
BUG-509: use dedicated executor for notifications

This dedicates a thread to datastore notifications, such that they are
delivered outside of the invoking threads. Also adds proper headers.

Change-Id: I44aeb9c4fefb8784d22ded9ae591d38993905ffa
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Enhance the LLDPTLV.java to handle the LLDP port ID subtypes 3 (MAC) in additi...
Jason Ye [Thu, 17 Apr 2014 16:21:34 +0000 (16:21 +0000)]
Merge "Enhance the LLDPTLV.java to handle the LLDP port ID subtypes 3 (MAC) in addition to 7 (Local). Many Ethernet switches take MAC addresses as the port IDs."

7 years agofix for BUG-709 - mixed up flow cookie and connection cookie 59/6259/4
Michal Rehak [Thu, 17 Apr 2014 15:08:42 +0000 (17:08 +0200)]
fix for BUG-709 - mixed up flow cookie and connection cookie

- flow cookie [64b] is present at receivedPacket (to distinguish responsible flow)
- connection cookie [32b] is present at receivedPacket and is expected
  to be copied into corresponding transmitPacketInput (to distinguish auxiliary connection)
- fixed sal-compatibility, l2switch/implementation, sal-binding-it

Change-Id: I331aa3a0f582219a1c604e21466c7a893ee4ed67
Signed-off-by: Michal Rehak <mirehak@cisco.com>
7 years agoAdding auto-sorting plugin to all Controller via parent/pom.xml 47/6247/2
jameshall03885 [Wed, 16 Apr 2014 18:18:57 +0000 (14:18 -0400)]
Adding auto-sorting plugin to all Controller via parent/pom.xml

leveraging google's sortpom plugin, all controller poms are sorted
at build time as per the opendaylight/commons/parent/pom.xml configuration.

Sorted lists of properties, dependencies, and plugins will increase pom readability
and help prevent duplicate entry errors.

This first submission is huge as I changed one pom.xml and all are then sorted.
Only if the sortpom plugin is reconfigured will all pom's again be changed.

Note that if any pom.xml is pushed without having been through a build ... folks are
going to see pom.xml files showup as modified unintentionally.

Change-Id: I8553f38b9f0e5f6d27177ad6b9b9c35a4b43d55a
Signed-off-by: jameshall03885 <ghall@brocade.com>
7 years agoBUG-472: fix integration test breakage 56/6256/1
Robert Varga [Thu, 17 Apr 2014 14:27:56 +0000 (16:27 +0200)]
BUG-472: fix integration test breakage

This makes sure IT using TestHelper do not break due to openexi not
being pulled in.

Change-Id: Iccf465f017d8a651e703d516d8142ef3dba4a24d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoUnify jacoco versions to 0.6.2.201302030002 24/5824/3
Maros Marsalek [Mon, 31 Mar 2014 16:30:55 +0000 (18:30 +0200)]
Unify jacoco versions to 0.6.2.201302030002

This cleans up previously unused pluginManagement sections and bumps
jacoco version 0.6.2.201302030002 (previously used by config subsys).

Change-Id: I027b219e7fd0225fe2ef12cbdcc1f7d47509e993
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoEnhance the LLDPTLV.java to handle the LLDP port ID 12/3812/2
Paiwei Wang [Wed, 18 Dec 2013 11:00:55 +0000 (03:00 -0800)]
Enhance the LLDPTLV.java to handle the LLDP port ID
subtypes 3 (MAC) in addition to 7 (Local).
Many Ethernet switches take MAC addresses as the
port IDs.

Change-Id: I8a0d0e5cf0e914a9fe77acd3d0d4787a2ac98760
Signed-off-by: Paiwei Wang <pwwang@itri.org.tw>
7 years agoBUG-732 Fix netconf-connector unable to detect monitoring capability 34/6234/2
Maros Marsalek [Wed, 16 Apr 2014 12:36:20 +0000 (14:36 +0200)]
BUG-732 Fix netconf-connector unable to detect monitoring capability

Change-Id: I6d84db9994a85116d6159d960908c0816f31461b
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBug:701-Have Typed ErrorNotification for different node errors 49/6249/1
Kamal Rameshan [Thu, 17 Apr 2014 02:59:54 +0000 (19:59 -0700)]
Bug:701-Have Typed ErrorNotification for different node errors

Change-Id: I674203531d0205dd13b47b64616624b5193bcb4d
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
7 years agoBug:645 - MDSAL Notification pool threads not getting spawned besides the core threads 57/5857/3
Kamal Rameshan [Wed, 2 Apr 2014 00:20:22 +0000 (17:20 -0700)]
Bug:645 - MDSAL Notification pool threads not getting spawned besides the core threads

Change-Id: I6851f9b90b500b2b10a135bcda784a11c8f44786
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
7 years agoAllow abilitiy to boot controller with non-default admin credentials 48/6248/2
Prasanth Pallamreddy [Wed, 16 Apr 2014 18:48:08 +0000 (11:48 -0700)]
Allow abilitiy to boot controller with non-default admin credentials

  - Default admin password can be overridden using the reset
    mechanism. NETWORK_ADMIN_PASSWORD_RECOVERY can optionally
    contain the password to be reset to.
  - Provide optional configuration to disallow factory default
    password. (-Dusermanager.disable-default-admin-password=true)
  - Convert ATN & ATZ security sensitive messages to 'trace' level
    instead of 'info' level

Change-Id: I7dcaf15e8d562f61a3a4636a8abc244b0d6365ae
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
7 years agoMerge "BUG-731: remove unneeded null check"
Tony Tkacik [Wed, 16 Apr 2014 17:07:44 +0000 (17:07 +0000)]
Merge "BUG-731: remove unneeded null check"

7 years agoMerge "BUG-731: do not do String.toString()"
Tony Tkacik [Wed, 16 Apr 2014 17:07:18 +0000 (17:07 +0000)]
Merge "BUG-731: do not do String.toString()"

7 years agoMerge "BUG-731: do not catch Throwable"
Tony Tkacik [Wed, 16 Apr 2014 17:07:00 +0000 (17:07 +0000)]
Merge "BUG-731: do not catch Throwable"

7 years agoMerge "Bug 615: Removed xtend from Topology Manager"
Ed Warnicke [Wed, 16 Apr 2014 16:55:24 +0000 (16:55 +0000)]
Merge "Bug 615: Removed xtend from Topology Manager"

7 years agoMerge "Bug 509: Fixed incorrect merging of Data Store Writes / Events"
Ed Warnicke [Wed, 16 Apr 2014 16:44:35 +0000 (16:44 +0000)]
Merge "Bug 509: Fixed incorrect merging of Data Store Writes / Events"

7 years agoChange OpenEXI version to -SNAPSHOT 37/6237/4
Robert Varga [Wed, 16 Apr 2014 15:15:53 +0000 (17:15 +0200)]
Change OpenEXI version to -SNAPSHOT

This fixes the merge job failing because it cannot publish a released
artifact.

Change-Id: I6e2eeb5ef8e9e521df40a77c12ff8ae94436d16d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-472 Initial EXI encoder/decoder implementation in Netconf 78/5678/15
Maros Marsalek [Wed, 19 Mar 2014 14:58:03 +0000 (15:58 +0100)]
BUG-472 Initial EXI encoder/decoder implementation in Netconf

according to http://tools.ietf.org/html/draft-varga-netconf-exi-capability-02

Change-Id: I861c126a8df1b26f477aa354ed1f8dba59d651cd
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG-472: Add EXI codecs without wiring them 94/5494/6
Robert Varga [Sat, 8 Feb 2014 03:06:48 +0000 (04:06 +0100)]
BUG-472: Add EXI codecs without wiring them

This patch implements the EXI codecs to be used in the NETCONF pipeline.
No wiring into the protocol stack is done in this patch.

Change-Id: Ic708ef26d92e138f8269a49a2759f01d88085bf1
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-472: Import OpenEXI nagasena-0000.0002.0035.0 93/5493/4
Robert Varga [Sat, 1 Feb 2014 08:26:54 +0000 (09:26 +0100)]
BUG-472: Import OpenEXI nagasena-0000.0002.0035.0

This imports the OpenEXI nagasena library, on top of which the
implementation will be built.

Change-Id: I4ec0fc637f390fe14451c439870ec1846934ebbb
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-731: remove unneeded null check 29/6229/1
Robert Varga [Wed, 16 Apr 2014 09:20:38 +0000 (11:20 +0200)]
BUG-731: remove unneeded null check

Fixes a sonar warning:
https://sonar.opendaylight.org/issue/show/0b9faac8-cbfc-4aed-8749-80fdd53410d5

Change-Id: Ib44157dde70d9c654f6dcb242e1d44619a685ea6
Signed-off-by: Robert Varga <rovarga@cisco.com>