controller.git
8 years agogroovy node-tree integration 93/593/5
Michal Rehak [Mon, 24 Jun 2013 06:31:00 +0000 (08:31 +0200)]
groovy node-tree integration
logging

fixing groovy tree generating

added params for surefire

lazy node2node map fixing

changed api according to dom usage
added lazy implementation of dom
added unit tests of this dom
changed abstract implementation in yang-data-util according to new api

improved groovy generated tree and testing
removed large testing files
added copyright comments
removed maven-surefire-plugin jConsole argument (plugin fails to start, if property not defined)

Change-Id: I00b9fcbc20ce5d120128940b7b569d7a14628a6e
Signed-off-by: Michal Rehak <mirehak@cisco.com>
8 years agoMerge "fix maven warnings regarding missing versions of some plugins"
Giovanni Meo [Thu, 18 Jul 2013 08:02:01 +0000 (08:02 +0000)]
Merge "fix maven warnings regarding missing versions of some plugins"

8 years agoMerge "YANG typedefs generation as class with extends key word In case that YANG...
Giovanni Meo [Thu, 18 Jul 2013 08:00:28 +0000 (08:00 +0000)]
Merge "YANG typedefs generation as class with extends key word In case that YANG typedef isn't specified as base type then corresponding class will be generated with EXTENDS key word and corresponding extended class."

8 years agoMerge "Added more descriptive parsing exceptions."
Giovanni Meo [Thu, 18 Jul 2013 07:59:42 +0000 (07:59 +0000)]
Merge "Added more descriptive parsing exceptions."

8 years agoMerge "Fix for maintaining properties for non-default container. Signed-off-by:...
Alessandro Boch [Thu, 18 Jul 2013 01:50:50 +0000 (01:50 +0000)]
Merge "Fix for maintaining  properties for non-default container. Signed-off-by: Pramila Singh <pramisin@cisco.com>"

8 years agoMerge "Fix for bug 28 https://bugs.opendaylight.org/show_bug.cgi?id=28 Updated surefi...
Alessandro Boch [Thu, 18 Jul 2013 01:04:32 +0000 (01:04 +0000)]
Merge "Fix for bug 28 https://bugs.opendaylight.org/show_bug.cgi?id=28 Updated surefire and failsafe plugin configurations to set heap to 1gb and permgen to 256mb.  These settings allow the Northbound integration tests to pass in both unit test and integration modes."

8 years agoMerge "Changes in DiscoveryService to cope with recently introduced HA active-active...
Alessandro Boch [Wed, 17 Jul 2013 21:04:51 +0000 (21:04 +0000)]
Merge "Changes in DiscoveryService to cope with recently introduced HA active-active model: - Fixed logic in addEdge() when discovery pkt is received. - Added retry mechanism for newly added ports. - Added some user configurable parameters in config.ini."

8 years agoChanges in DiscoveryService to cope with recently introduced HA active-active model: 08/608/1
Jason Ye [Wed, 17 Jul 2013 15:12:03 +0000 (08:12 -0700)]
Changes in DiscoveryService to cope with recently introduced HA active-active model:
- Fixed logic in addEdge() when discovery pkt is received.
- Added retry mechanism for newly added ports.
- Added some user configurable parameters in config.ini.

Signed-off-by: Jason Ye <yisye@cisco.com>
8 years agoFix null pointer exception in FRM 07/607/1
Alessandro Boch [Wed, 17 Jul 2013 01:55:46 +0000 (18:55 -0700)]
Fix null pointer exception in FRM

Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoFix for bug 28 05/605/1
Prasanth Pallamreddy [Tue, 16 Jul 2013 21:16:48 +0000 (14:16 -0700)]
Fix for bug 28
https://bugs.opendaylight.org/show_bug.cgi?id=28
Updated surefire and failsafe plugin configurations to set heap to 1gb and
permgen to 256mb.  These settings allow the Northbound integration tests to
pass in both unit test and integration modes.

Change-Id: I06f5254458db65c06b84076d6f3022cdcd983cf6
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
8 years agoFix for maintaining properties for non-default container. 04/604/1
Pramila Singh [Tue, 16 Jul 2013 21:11:08 +0000 (14:11 -0700)]
Fix for maintaining  properties for non-default container.
Signed-off-by: Pramila Singh <pramisin@cisco.com>
8 years agoYANG typedefs generation as class with extends key word 96/596/4
Jozef Gloncak [Thu, 11 Jul 2013 08:49:23 +0000 (10:49 +0200)]
YANG typedefs generation as class with extends key word
In case that YANG typedef isn't specified as base type then corresponding
class will be generated with EXTENDS key word and corresponding extended
class.

Change-Id: I36143f485b8e68f471e2a3021ceb7ddc4ad9df2f
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
8 years agoAdded more descriptive parsing exceptions. 00/600/1
Martin Vitez [Tue, 16 Jul 2013 08:48:18 +0000 (10:48 +0200)]
Added more descriptive parsing exceptions.

Added module name to all builders to help create detailed exception messages. Added new abstract class AbstracBuilder as base implementation of Builder interface.
Added more tests.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agofix maven warnings regarding missing versions of some plugins 99/599/1
Michal Rehak [Tue, 16 Jul 2013 07:57:47 +0000 (09:57 +0200)]
fix maven warnings regarding missing versions of some plugins

Change-Id: I16a80358435b51d6be2c883a10bf893ea73e20ff
Signed-off-by: Michal Rehak <mirehak@cisco.com>
8 years agoMerge "adding function to modify existing subnets"
Alessandro Boch [Sat, 13 Jul 2013 17:03:51 +0000 (17:03 +0000)]
Merge "adding function to modify existing subnets"

8 years agoadding function to modify existing subnets 72/572/5
Colin Dixon [Fri, 12 Jul 2013 15:23:52 +0000 (10:23 -0500)]
adding function to modify existing subnets

Change-Id: I2b5b3abda4dd4fbf4a872ea7c866d68821ce9bff
Signed-off-by: Colin Dixon <ckd@us.ibm.com>
8 years agoBug fix: flow statistics are not notified if empty 94/594/1
Yevgeny Khodorkovsky [Fri, 12 Jul 2013 01:19:51 +0000 (18:19 -0700)]
Bug fix: flow statistics are not notified if empty

Change-Id: Id685f6205bd75e666972e30a86584a0b4a1498ec
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
8 years agoMerge "Moved parsing of unknown nodes from implementation to abstract classes."
Alessandro Boch [Fri, 12 Jul 2013 00:09:45 +0000 (00:09 +0000)]
Merge "Moved parsing of unknown nodes from implementation to abstract classes."

8 years agoFixed a bug to block the creation of a static host on an ISL port, removed the code... 69/569/4
Diti Bhatia [Fri, 5 Jul 2013 22:13:03 +0000 (15:13 -0700)]
Fixed a bug to block the creation of a static host on an ISL port, removed the code to block more than one host per port

Change-Id: I600f6d51395b072b3d2bdb90d4fb10ad905fc6c7
Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
8 years ago- In SwitchHandler.java, Transmit Thread waits if the priority queue is empty. 90/590/2
Jason Ye [Wed, 10 Jul 2013 22:55:00 +0000 (15:55 -0700)]
- In SwitchHandler.java, Transmit Thread waits if the priority queue is empty.
- Change DiscoveryService timer from 1 sec to 2 sec per tick leading to less CPU utilization. Added enum class for some time intervals.
- MacAddress property was defined as a byte array. XML can not serialize byte array properly. Change it to String.
- SwitchManager osgi cmd "pns" now displays sorted list of nodes.

Signed-off-by: Jason Ye <yisye@cisco.com>
8 years agoMerge "Fix null value put in FRM incativeFlows hash map"
Jason Ye [Thu, 11 Jul 2013 17:49:52 +0000 (17:49 +0000)]
Merge "Fix null value put in FRM incativeFlows hash map"

8 years agoMerge "- Adding hashCode() and equals() method for v6Match - Fixing mac settings...
Alessandro Boch [Thu, 11 Jul 2013 14:40:53 +0000 (14:40 +0000)]
Merge "- Adding hashCode() and equals() method for v6Match - Fixing mac settings in copy constructor"

8 years agoMoved parsing of unknown nodes from implementation to abstract classes. 92/592/1
Martin Vitez [Thu, 11 Jul 2013 12:05:33 +0000 (14:05 +0200)]
Moved parsing of unknown nodes from implementation to abstract classes.

Added more javadocs. Removed unnecessary ConfigNode interface.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoBumped version of yang-prototype to 0.5.4-SNAPSHOT. 83/583/3
Martin Vitez [Wed, 10 Jul 2013 12:01:19 +0000 (14:01 +0200)]
Bumped version of yang-prototype to 0.5.4-SNAPSHOT.

Change-Id: Idacefac91a2d86606debf8a75f6cab2cf1303b98
Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoUpdated PoC APIs of Model-driven SAL 81/581/2
Tony Tkacik [Tue, 9 Jul 2013 15:25:36 +0000 (17:25 +0200)]
Updated PoC APIs of Model-driven SAL

  - Bumped version of YANG tools
  - Added Concepts Lang package with reusable tranformator functionality

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoAdded YANG extensions module 80/580/2
Tony Tkacik [Tue, 9 Jul 2013 15:22:53 +0000 (17:22 +0200)]
Added YANG extensions module

  - Added YANG extensions module which defines
    - Context-aware RPCs
    - Named Augmentations

Change-Id: I7b6cb7f579c519dfa726f966df466ad6c9e6aee1
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoFix null value put in FRM incativeFlows hash map 89/589/2
Alessandro Boch [Thu, 11 Jul 2013 00:23:53 +0000 (17:23 -0700)]
Fix null value put in FRM incativeFlows hash map

- Also renamed ForwardingRulesManagerImpl class to ForwardingRulesManager as already in internal directory
- Minor changes in FlowProgrammerService

Change-Id: I38b46f4ce29b5d6f4dfc0f38db3d3cef960b26ac
Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years ago- Adding hashCode() and equals() method for v6Match 88/588/1
Diti Bhatia [Wed, 10 Jul 2013 23:47:46 +0000 (16:47 -0700)]
- Adding hashCode() and equals() method for v6Match
- Fixing mac settings in copy constructor

Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
8 years agoMerge "Add operational port status"
Alessandro Boch [Wed, 10 Jul 2013 22:42:37 +0000 (22:42 +0000)]
Merge "Add operational port status"

8 years agoBug fixes and styling 86/586/1
Yevgeny Khodorkovsky [Wed, 10 Jul 2013 22:04:10 +0000 (15:04 -0700)]
Bug fixes and styling

- Fix using skiplistset on a non-comparable
- Add missing help in SAL Read Service
- Remove incorrect throws clause

Change-Id: I4c3c192124e03f84d3ba5ac97e2c69ca7defdd03
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
8 years agoAdd operational port status 85/585/1
Andrew Kim [Tue, 9 Jul 2013 17:42:44 +0000 (12:42 -0500)]
Add operational port status

Port status that is operationally down will be colored yellow

Signed-off-by: Andrew Kim <andrekim@cisco.com>
8 years agoMove stats caching to FM StatisticsManager 75/575/7
Yevgeny Khodorkovsky [Mon, 8 Jul 2013 23:36:57 +0000 (16:36 -0700)]
Move stats caching to FM StatisticsManager

This commit is towards HA functionality and includes:
- Cache flow, port, table and description statistics in a cluster
  allocated cache in functional module Statistics Manager
- Add necessary interfaces to allow plugin stats updates
  to propagate up to Stats Manager FM:
  * IOFStatisticsListener - notifies plugin internal components
  * IReadFilterInternalListener - notifies plugin internal
    components (demuxed to containers).
  * IPluginOutReadService - SAL hook for plugins to publish reader
    notifications.
  * IReadServiceListener - SAL service, publishes reader notifications
- Change statistics manager implementation to return cluster
  cached stats instead of calling reader service (Reader service is
  still available).
- Style fixes
- Bug fix: getOFFlowStatistics(switch,match) should consider priority.

Change-Id: I7c7a32102ea43bd4e05444527ad73d2610958603
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
8 years agoFixed bug in RPC and Generics mapping 82/582/2
Tony Tkacik [Wed, 10 Jul 2013 12:05:17 +0000 (14:05 +0200)]
Fixed bug in RPC and Generics mapping

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoMerge "Maping of union leaf a bits leaf YANG type to JAVA inner classes."
Alessandro Boch [Wed, 10 Jul 2013 17:04:36 +0000 (17:04 +0000)]
Merge "Maping of union leaf a bits leaf YANG type to JAVA inner classes."

8 years agoMaping of union leaf a bits leaf YANG type to JAVA inner classes. 46/546/9
Jozef Gloncak [Tue, 2 Jul 2013 13:38:07 +0000 (15:38 +0200)]
Maping of union leaf a bits leaf YANG type to JAVA inner classes.

Implements following mapping:
- YANG union leaf:
-- leaf name -> name of inner class
-- leaf types -> attributes of inner class
- YANG bits leaf:
-- leaf name -> name of inner class
-- leaf concrete bits - attributes of inner class

Bug fix:
- generation of constant list of regular expression also if no pattern in
  string YANG type is specified

Change-Id: I7c52eef34de610877c3dc0c24d44bb89015c953b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
8 years agoMinor code refactoring and improvements. 79/579/2
Martin Vitez [Tue, 9 Jul 2013 15:10:20 +0000 (17:10 +0200)]
Minor code refactoring and improvements.

Change-Id: Ifdc5b45e610037ef14eed6c97885deb1075aa884
Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoProactive static flows have to be allowed in container mode 74/574/4
Alessandro Boch [Mon, 8 Jul 2013 21:06:15 +0000 (14:06 -0700)]
Proactive static flows have to be allowed in container mode

ISSUE: Once container are created, setting the forwarding mode to proactive for newly
       joined switches does not result in having the punt flows installed
CHANGE: - Have filtering check in install/uninstall/modify function allow internal
          generated flows when in container mode
        - Also removing uneeded dependecy on IfIptoHost in forwardingrulesmanager
        - Also fix some dependencies in sal activator regarding FlowProgrammer service

Change-Id: Id8a69abb2f3fa948195700a50c30fb368264adf9
Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoMerge "Added default output directory to CodeGeneratorImpl in maven-sal-api-gen-plugi...
Alessandro Boch [Wed, 10 Jul 2013 00:12:25 +0000 (00:12 +0000)]
Merge "Added default output directory to CodeGeneratorImpl in maven-sal-api-gen-plugin. Removed default output directory from yang-maven-plugin."

8 years agoHA cache sync for switch manager 76/576/3
Pramila Singh [Mon, 8 Jul 2013 23:48:04 +0000 (16:48 -0700)]
HA cache sync for switch manager

Change-Id: I00ab53d62f2c7622311ee07fd934c9ce8c000064
Signed-off-by: Pramila Singh <pramisin@cisco.com>
8 years agoMerge "Fix for the "without any protocolPluginType provided" error"
Chi-Vien Ly [Tue, 9 Jul 2013 17:49:19 +0000 (17:49 +0000)]
Merge "Fix for the "without any protocolPluginType provided" error"

8 years agoMerge "Fixed bug in maven-yang-plugin."
Alessandro Boch [Tue, 9 Jul 2013 14:55:03 +0000 (14:55 +0000)]
Merge "Fixed bug in maven-yang-plugin."

8 years agoMerge "Added more tests for yang parser. Updated current tests."
Alessandro Boch [Tue, 9 Jul 2013 14:53:42 +0000 (14:53 +0000)]
Merge "Added more tests for yang parser. Updated current tests."

8 years agoMerge "first implementation of yang-data-api"
Alessandro Boch [Tue, 9 Jul 2013 14:53:17 +0000 (14:53 +0000)]
Merge "first implementation of yang-data-api"

8 years agoAdded default output directory to CodeGeneratorImpl in maven-sal-api-gen-plugin. 78/578/1
Martin Vitez [Tue, 9 Jul 2013 11:23:28 +0000 (13:23 +0200)]
Added default output directory to CodeGeneratorImpl in maven-sal-api-gen-plugin.
Removed default output directory from yang-maven-plugin.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoFix for the "without any protocolPluginType provided" error 77/577/2
Alessandro Boch [Tue, 9 Jul 2013 02:07:45 +0000 (19:07 -0700)]
Fix for the "without any protocolPluginType provided" error

CHANGE: Add a global constant for the "protocolPluginType" key to prevent the key mispell issue again

Change-Id: Icb76cf8775881d41c1792e0c5ce59925276b7e8e
Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoMerge "Ensuring that SET_DL_* action with openflowj only uses OFP_ETH_ALEN bytes...
Alessandro Boch [Mon, 8 Jul 2013 14:53:10 +0000 (14:53 +0000)]
Merge "Ensuring that SET_DL_* action with openflowj only uses OFP_ETH_ALEN bytes, just in case SAL passes more than that."

8 years agoFixed bug in maven-yang-plugin. 73/573/1
Maros Marsalek [Mon, 8 Jul 2013 10:41:32 +0000 (12:41 +0200)]
Fixed bug in maven-yang-plugin.

Yang files in dependencies were not located properly on windows os.

Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
8 years agofirst implementation of yang-data-api 30/530/2
Michal Rehak [Thu, 27 Jun 2013 14:01:29 +0000 (16:01 +0200)]
first implementation of yang-data-api

created maven project
added basic implementations of api
added unit tests
changed api according to implementation

Change-Id: I888371d5a7afc46c843f882bee9bfcaa19d5ccbc
Signed-off-by: Michal Rehak <mirehak@cisco.com>
8 years agoMerge "adding isBroadcast and isMulticast functions to Ethernet"
Alessandro Boch [Fri, 5 Jul 2013 23:37:21 +0000 (23:37 +0000)]
Merge "adding isBroadcast and isMulticast functions to Ethernet"

8 years agoadding isBroadcast and isMulticast functions to Ethernet 71/571/2
Colin Dixon [Fri, 5 Jul 2013 22:50:23 +0000 (17:50 -0500)]
adding isBroadcast and isMulticast functions to Ethernet

Change-Id: I8777ed281261d062b57cbeae00317c955c4b6385
Signed-off-by: Colin Dixon <ckd@us.ibm.com>
8 years agoMerge "Fixing the style checker to ignore the target directories to fix Bug 29"
Alessandro Boch [Fri, 5 Jul 2013 22:49:07 +0000 (22:49 +0000)]
Merge "Fixing the style checker to ignore the target directories to fix Bug 29"

8 years agoFixing the style checker to ignore the target directories to fix Bug 29 70/570/1
Colin Dixon [Fri, 5 Jul 2013 22:35:30 +0000 (17:35 -0500)]
Fixing the style checker to ignore the target directories to fix Bug 29

Change-Id: I83220b06a13c74b0ea18a278ae1ae5fb72aa6e00
Signed-off-by: Colin Dixon <ckd@us.ibm.com>
8 years agoConfiguration Save event sync mechanism using Clustering services. 68/568/1
Madhu Venugopal [Fri, 5 Jul 2013 06:17:37 +0000 (23:17 -0700)]
Configuration Save event sync mechanism using Clustering services.
Every Controller in the cluster will receive a Config save event and the save is performed locally on each of the Controllers.
This is the first step towards the centralized configuration service.

Change-Id: Icbff65117ccb237a4c31091d392b27de43d8ae1d
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
8 years agoAdded more tests for yang parser. Updated current tests. 66/566/1
Martin Vitez [Thu, 4 Jul 2013 11:50:25 +0000 (13:50 +0200)]
Added more tests for yang parser. Updated current tests.

Improved parsing of deviation statement. Added getDataChildByName method to DataNodeContainerBuilder.
Fixed resolving of pattern constraint.
Renamed YangModelBuilderUtil -> ParserListenerUtils.
Renamed some test files.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoMerge "Added support to generate types from Choices and Cases added by augmentation."
Alessandro Boch [Wed, 3 Jul 2013 20:31:38 +0000 (20:31 +0000)]
Merge "Added support to generate types from Choices and Cases added by augmentation."

8 years agoMerge "Cache Sync for HostTracker"
Alessandro Boch [Wed, 3 Jul 2013 17:21:19 +0000 (17:21 +0000)]
Merge "Cache Sync for HostTracker"

8 years agoMerge "Fix container flow logic in forwarding rules manager"
Chi-Vien Ly [Wed, 3 Jul 2013 16:54:20 +0000 (16:54 +0000)]
Merge "Fix container flow logic in forwarding rules manager"

8 years agoMerge "Implemented ordering of yang module data nodes. Added Comparators utility...
Alessandro Boch [Wed, 3 Jul 2013 16:14:59 +0000 (16:14 +0000)]
Merge "Implemented ordering of yang module data nodes. Added Comparators utility class. Added checking for duplicate nodes. Added getParent() method to Builder interface. Removed unused TypeDefinitionAwareBuilder interface. Fixed bug in processing augmentation of choice node. Added more logs, javadocs, tests."

8 years agoAdded support to generate types from Choices and Cases added by augmentation. 65/565/1
lsedlak [Wed, 3 Jul 2013 15:37:59 +0000 (17:37 +0200)]
Added support to generate types from Choices and Cases added by augmentation.

Added implementation into BindingGeneratorImpl to suppor of generating Generated Types for Choices and Cases from augmentations;
Extended ChoiceNode API and ChoiceNodeBuilder to getCaseNodeByName methods;
Fixed findSchemaNodeForGivenPath in SchemaContextUtil to support of traversal through Choice and Case nodes in data schema tree;

Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
8 years agoImplemented ordering of yang module data nodes. Added Comparators utility class. 44/544/3
Martin Vitez [Tue, 2 Jul 2013 12:13:48 +0000 (14:13 +0200)]
Implemented ordering of yang module data nodes. Added Comparators utility class.
Added checking for duplicate nodes. Added getParent() method to Builder interface.
Removed unused TypeDefinitionAwareBuilder interface.
Fixed bug in processing augmentation of choice node.
Added more logs, javadocs, tests.

Change-Id: I6d7a504cdb516c267d42b99091120649027b453d
Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoMerge "Added topologyNorthbound integration test removed /r Replaced some Assert...
Alessandro Boch [Wed, 3 Jul 2013 01:13:18 +0000 (01:13 +0000)]
Merge "Added topologyNorthbound integration test removed /r Replaced some Assert.assertTrue() with Assert.assertEquaus()"

8 years agoAdded topologyNorthbound integration test 32/532/4
taochang [Fri, 28 Jun 2013 00:21:29 +0000 (17:21 -0700)]
Added topologyNorthbound integration test
removed /r
Replaced some Assert.assertTrue() with Assert.assertEquaus()

Change-Id: I572b10c189372b6f3ece55253fc4eeea80d7f579
Signed-off-by: taochang <taochang@cisco.com>
8 years agoFix container flow logic in forwarding rules manager 45/545/1
Alessandro Boch [Tue, 2 Jul 2013 21:13:06 +0000 (14:13 -0700)]
Fix container flow logic in forwarding rules manager

- In Activator.java:
   + All instances of FRM must be IContainerListener
   + Pass the right cache name in order to have the save config event working in the cluster
- In ForwardingRulesManaerImpl.java:
   + Add container check filtering in the IContainerListener methods
   + In updateFlowsContainerFlow() first uninstall all current flows, then reinstall instead
     of interleave remove/add which could cause conflict failures during installation phase
     as the new entries could conflict with existing old container flow merged flows present
     on the netwrok node
   + minor logs and style changes
- In FlowEntryInstall.java:
   + Fixed a bug where container flow merging was altering the original flow entry

Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoMerge "Added support to generate interfaces from Choices and Cases."
Alessandro Boch [Tue, 2 Jul 2013 19:58:09 +0000 (19:58 +0000)]
Merge "Added support to generate interfaces from Choices and Cases."

8 years agoMerge "Add help menu"
Alessandro Boch [Tue, 2 Jul 2013 17:47:02 +0000 (17:47 +0000)]
Merge "Add help menu"

8 years agoMerge "HA sync for samples simpleforwarding"
Alessandro Boch [Tue, 2 Jul 2013 17:46:52 +0000 (17:46 +0000)]
Merge "HA sync for samples simpleforwarding"

8 years agoMerge "Restoring basic cache syncing for switch manager Signed-off-by: Pramila Singh...
Alessandro Boch [Tue, 2 Jul 2013 17:46:41 +0000 (17:46 +0000)]
Merge "Restoring basic cache syncing for switch manager Signed-off-by: Pramila Singh <pramisin@cisco.com>"

8 years agoMerge "Added annotations to Latency for northbound usage."
Alessandro Boch [Tue, 2 Jul 2013 14:34:50 +0000 (14:34 +0000)]
Merge "Added annotations to Latency for northbound usage."

8 years agoAdded support to generate interfaces from Choices and Cases. 43/543/1
lsedlak [Mon, 1 Jul 2013 15:47:09 +0000 (17:47 +0200)]
Added support to generate interfaces from Choices and Cases.

Added implementation to support generation of generated types from Choice and Case schema nodes from yang models into BindingGeneratorImpl;
Added test case and test files for test of generation of Generated Types;

Fixed bug in GeneratorUtil when imports were generated wrongly if the name of type was same as the name of interface/class.

Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
8 years agoCache Sync for HostTracker 42/542/1
Maurice Qureshi [Tue, 2 Jul 2013 00:34:18 +0000 (17:34 -0700)]
Cache Sync for HostTracker

Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
8 years agoRestoring basic cache syncing for switch manager 39/539/1
Pramila Singh [Tue, 2 Jul 2013 00:09:26 +0000 (17:09 -0700)]
Restoring basic cache syncing for switch manager
Signed-off-by: Pramila Singh <pramisin@cisco.com>
8 years agoWhen containers are present, static flows add/removal/toggling should be blocked... 38/538/2
Alessandro Boch [Mon, 1 Jul 2013 23:40:15 +0000 (16:40 -0700)]
When containers are present, static flows add/removal/toggling should be blocked on default container

    - In FRM have the static flow APIs call the [install/uninstall/modify]FlowEntry() API
      instead of the lower level [add/remove/modify]Entry() functions which do not perform
      the container mode check

Change-Id: I8da638fcc36726f8f2dfe0b6733b49614329c7ab
Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoMerge "On container removal, all container flows should be uninstalled"
Chi-Vien Ly [Mon, 1 Jul 2013 23:38:18 +0000 (23:38 +0000)]
Merge "On container removal, all container flows should be uninstalled"

8 years agoHA sync for samples simpleforwarding 37/537/1
Diti Bhatia [Mon, 1 Jul 2013 23:10:36 +0000 (16:10 -0700)]
HA sync for samples simpleforwarding

Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
8 years agoAdd help menu 35/535/1
Andrew Kim [Mon, 1 Jul 2013 22:35:40 +0000 (17:35 -0500)]
Add help menu

Hidden for now, each modal contains help option.

Signed-off-by: Andrew Kim <andrekim@cisco.com>
8 years agoCannot install flow with Flood action 36/536/1
Alessandro Boch [Mon, 1 Jul 2013 22:25:07 +0000 (15:25 -0700)]
Cannot install flow with Flood action

- Fixed validation check in FlowConfig
Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoOn container removal, all container flows should be uninstalled 34/534/1
Alessandro Boch [Mon, 1 Jul 2013 19:33:23 +0000 (12:33 -0700)]
On container removal, all container flows should be uninstalled

- Have FRM uninstall all the flows on bundle stop

Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoSwitchManager incorrectly treats all ports as span ports and adds them in the spanNo... 33/533/1
Chi-Vien Ly [Mon, 1 Jul 2013 17:51:44 +0000 (10:51 -0700)]
SwitchManager incorrectly treats all ports as span ports  and adds them in the spanNodeConnectors.

Change-Id: I49c2a9c4d583b3aa86f8de8d567f390c721d65ff
Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
8 years agoRefactored parsing of YANG uses statement. 28/528/3
Martin Vitez [Thu, 27 Jun 2013 14:26:12 +0000 (16:26 +0200)]
Refactored parsing of YANG uses statement.

Uses statement now add nodes from referenced grouping to context where uses is defined. Added GroupingMember interface as marker interface for nodes defined in grouping.
Fixed parsing of config statement: when config is not specified, the default is same as parent schema node. If top node does not specify config, default is true.
Added ConfigNode as marker interface for nodes which can contains 'config' statement.
Added AbstractSchemaNodeBuilder as base class for builders of SchemaNode nodes.
Updated tests.

Change-Id: Ibabcf590608bdf482258826fa250692507a71c01
Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoAdded following mapping: 22/522/10
Jozef Gloncak [Wed, 26 Jun 2013 09:45:12 +0000 (11:45 +0200)]
Added following mapping:
from:
- subelement >>PATTERN<< of YANG build-in type string
to:
- constant list string >>PATTERN_CONSTANTS<< which contains list of regular expressions specified in >>PATTENR<<
- member class attribute >>patterns<< which is list of Pattern objects.

Change-Id: I47ec9f4a5cd3e7eef85b78189a3788dd2f9e007f
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
8 years agoAdded annotations to Latency for northbound usage. 31/531/1
patrichu [Thu, 27 Jun 2013 21:05:58 +0000 (14:05 -0700)]
Added annotations to Latency for northbound usage.

Change-Id: Ib5948b3e6a4a5a45863f73c405cb652eba0b5ea7
Signed-off-by: patrichu <patrichu@cisco.com>
8 years agoMerge "Added StatusCode to Response.Status Mapping"
Alessandro Boch [Thu, 27 Jun 2013 19:49:20 +0000 (19:49 +0000)]
Merge "Added StatusCode to Response.Status Mapping"

8 years agoMerge "HA - Cache sync for forwarding.staticrouting"
Alessandro Boch [Thu, 27 Jun 2013 19:48:16 +0000 (19:48 +0000)]
Merge "HA - Cache sync for forwarding.staticrouting"

8 years agoRefactor ForwardingRulesmanager 18/518/4
Alessandro Boch [Fri, 21 Jun 2013 17:09:11 +0000 (10:09 -0700)]
Refactor ForwardingRulesmanager

- Refactor flow entries database in order to remove synchronized methods which hit performance and
  to better accomodate cluster cache syncing:
  - Installed entries as a flat concurrent map of FlowInstallEntry key/elements
  - Modified FlowEntry hashCode function to take into account only the flow parameters which uniquely identify
    a flow entry: node, match and priority. Modified FlowEntryInstall hashCode function to only account install
    FlowEntry hash code.
  - Added a per node and per group index databases for efficiently access node or group flow entries in the flat map
  - Fixed bugs in MatchField hashcode (did not account MAC addresses), added Junit test for hashcode in Match,
    FlowEntry and FlowEntryInstall
- Have flow entries parameter classes implement Serializable so that FRM flow DB is synced across cluster cntroller nodes
- Added api to remove all flows part of a group, uninstallFlowEntryGroup()
- Added a event handler thread in FRM so that FRM does not hog switch handler thread on southbound events processing
- Changed the installation of startup configured static flows from synchronous to asynchronous flow install
- Modified FlowConfig.isValid() to return a status object, changed test code accordingly
- Fixed issue where internal generated static flows (the ones for proactive forwarding switches) were getting removed on container creation
- Fixed Flows GUI which was not showing static flow state correctly
- Minor coding style changes
- Changes tested with 2K static flows on two software switches with a custer of two controllers

Change-Id: Ic4c0167094988c0ebd44763e45541fe728d95ead
Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoMerge "Bumped version of YANG tools to 0.5.3-SNAPSHOT"
Ed Warnicke [Thu, 27 Jun 2013 16:06:14 +0000 (16:06 +0000)]
Merge "Bumped version of YANG tools to 0.5.3-SNAPSHOT"

8 years agoMerge "Fixed bug in GeneratedPropertyBuilderImpl."
Ed Warnicke [Thu, 27 Jun 2013 16:05:54 +0000 (16:05 +0000)]
Merge "Fixed bug in GeneratedPropertyBuilderImpl."

8 years agoFixed bug in GeneratedPropertyBuilderImpl. 29/529/1
lsedlak [Thu, 27 Jun 2013 14:26:15 +0000 (16:26 +0200)]
Fixed bug in GeneratedPropertyBuilderImpl.

Default value for GeneratedProperty is set to true;
Added extends of AbstractBaseType for EnumerationBuilderImpl, AnnotationTypeBuilderImpl, AbstractGeneratedTypeBuilder and AbstractGeneratedType;

Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
8 years agoBumped version of YANG tools to 0.5.3-SNAPSHOT 27/527/1
Tony Tkacik [Thu, 27 Jun 2013 10:56:15 +0000 (12:56 +0200)]
Bumped version of YANG tools to 0.5.3-SNAPSHOT

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoAdded StatusCode to Response.Status Mapping 25/525/1
Pramila Singh [Thu, 27 Jun 2013 00:26:53 +0000 (17:26 -0700)]
Added StatusCode to Response.Status Mapping

Signed-off-by: Pramila Singh <pramisin@cisco.com>
8 years agoTopology discovery is broken in Active/Active controllers 26/526/1
Alessandro Boch [Thu, 27 Jun 2013 00:25:55 +0000 (17:25 -0700)]
Topology discovery is broken in Active/Active controllers

    ISSUE: Edges which endpoints are managed by different controllers cannot be discovered
           This happens because Discovery discards LLDP frames coming from non-local node connectors
    CHANGES:
    - in processDiscoveryPacket():
      + do not discard LLDP frames coming in from non-local node connectors
      + after discovering an edge, put it in the timeout map (pendingMap) keyed by the incoming port (tail node connector)
    - in doDiscovery():
      + do not add local node connectors to the timeout map (pendingMap)
        This map now contains the time (ticks) elapsed since last LLDP frame was received on the respective node connector.
    - Some style and minor static analysis fix changes

Signed-off-by: Alessandro Boch <aboch@cisco.com>
8 years agoMerge "Performance improvements:"
Alessandro Boch [Wed, 26 Jun 2013 23:47:32 +0000 (23:47 +0000)]
Merge "Performance improvements:"

8 years agoHA - Cache sync for forwarding.staticrouting 23/523/1
Diti Bhatia [Wed, 26 Jun 2013 18:45:28 +0000 (11:45 -0700)]
HA - Cache sync for forwarding.staticrouting

Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
8 years agoMerge "Added support for parsing yang models with already resolved context."
Ed Warnicke [Wed, 26 Jun 2013 12:52:16 +0000 (12:52 +0000)]
Merge "Added support for parsing yang models with already resolved context."

8 years agoMerge "Added YANG models for base concepts in the controller"
Ed Warnicke [Wed, 26 Jun 2013 12:51:58 +0000 (12:51 +0000)]
Merge "Added YANG models for base concepts in the controller"

8 years agoAdded support for parsing yang models with already resolved context. 19/519/4
Martin Vitez [Mon, 24 Jun 2013 09:48:14 +0000 (11:48 +0200)]
Added support for parsing yang models with already resolved context.

Added rebuild method to AugmentationTargetBuilder interface to support augmentation of resolved context.
Refactored YangParserImpl to improve readability, internal utility methods moved to ParserUtils class.
Added test to check parsing with context.
Added YangErrorListener to redirect antlr4 error messages from standard error output to logger.
Added more javadocs.

Change-Id: I838646cc4b3593a03420c1b578ee39c043f89e3d
Signed-off-by: Martin Vitez <mvitez@cisco.com>
8 years agoAdded YANG models for base concepts in the controller 97/497/5
Tony Tkacik [Tue, 11 Jun 2013 16:28:05 +0000 (18:28 +0200)]
Added YANG models for base concepts in the controller

  - Added model parent project and model-ietf parent project
  - Added ietf-inet-types and ietf-yang-types YANG modules
    to generate base types defined in YANG
  - Added prototype of topology model in YANG
  - Updated maven sal api gen plugin tu support loading YANG files
    from dependencies.

Change-Id: Id70ef8afd02fbe9d4da5fa844cebe8cb80c3725c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
8 years agoPerformance improvements: 21/521/1
Jason Ye [Wed, 26 Jun 2013 06:24:00 +0000 (23:24 -0700)]
Performance improvements:

Solution: Use LinkedBlockingQueue with fixed capacity. The MAXQUEUESIZE is now set to 50,000. With the change, the system become stable.

Solution: Implemented more efficient way to compute header checksum. As a result, the throughout has more than doubled.See test results below. Used Cbench for testing.

Before:
RESULT: 16 switches 9 tests min/max/avg/stdev =
9598.35/10395.48/10193.23/225.24 responses/s

After:
RESULT: 16 switches 9 tests min/max/avg/stdev =
28767.44/32073.92/30335.74/999.70 responses/s

Solution: Transmit messages in a tight while loop until the Tx queue is empty.

Signed-off-by: Jason Ye <yisye@cisco.com>
8 years agoMerge "Bug #25: Installing/removing flows with ".""
Alessandro Boch [Tue, 25 Jun 2013 13:55:09 +0000 (13:55 +0000)]
Merge "Bug #25: Installing/removing flows with ".""

8 years agoBug #25: Installing/removing flows with "." 20/520/1
Kalvin Hom [Mon, 24 Jun 2013 20:43:23 +0000 (13:43 -0700)]
Bug #25: Installing/removing flows with "."

Fix for bug #25:
Cannot remove or install flows that have a "."
in their name
http://bugs.opendaylight.org/show_bug.cgi?id=25

By default @RequestMapping is parsing for file
extension types, so anything after the "." gets
lost in the flow name.  This overrides that
behavior so the whole name in "a.b" is used.

Change-Id: I4aeba037aa34e3b61190c91cf43e599969fe5106
Signed-off-by: Kalvin Hom <kahom@cisco.com>
8 years agoMerge "Host updates for Topology"
Alessandro Boch [Mon, 24 Jun 2013 18:09:14 +0000 (18:09 +0000)]
Merge "Host updates for Topology"