controller.git
7 years agoMerge "BUG-509: introduce Version concept"
Tony Tkacik [Fri, 23 May 2014 14:09:24 +0000 (14:09 +0000)]
Merge "BUG-509: introduce Version concept"

7 years agoMerge "BUG-509: fix ModifiedNode locking"
Tony Tkacik [Fri, 23 May 2014 14:08:59 +0000 (14:08 +0000)]
Merge "BUG-509: fix ModifiedNode locking"

7 years agoMerge "BUG-509: migrate to TreeNodes"
Tony Tkacik [Fri, 23 May 2014 14:07:44 +0000 (14:07 +0000)]
Merge "BUG-509: migrate to TreeNodes"

7 years agoMerge "BUG-509: create data tree SPI package"
Tony Tkacik [Fri, 23 May 2014 13:56:42 +0000 (13:56 +0000)]
Merge "BUG-509: create data tree SPI package"

7 years agoMerge "BUG-509: add some documentation"
Tony Tkacik [Fri, 23 May 2014 13:56:17 +0000 (13:56 +0000)]
Merge "BUG-509: add some documentation"

7 years agoMerge "Bug 716: Errors on controller shutdown"
Tony Tkacik [Fri, 23 May 2014 12:42:54 +0000 (12:42 +0000)]
Merge "Bug 716: Errors on controller shutdown"

7 years agoMerge "Bug 735 - Part 2 - Modify controller to reference new yang-types bundle and...
Tony Tkacik [Fri, 23 May 2014 12:34:21 +0000 (12:34 +0000)]
Merge "Bug 735 - Part 2 - Modify controller to reference new yang-types bundle and and ietf-bundles."

7 years agoBUG-509: introduce Version concept 51/7351/2
Robert Varga [Thu, 22 May 2014 21:35:02 +0000 (23:35 +0200)]
BUG-509: introduce Version concept

This patch introduces the concept of a Version, which is disconnected
from any ordinal number. This is useful for saving memory, as the
versioning of TreeNodes needs to only detect version mismatches and not
which version is historically newer.

Change-Id: I625d9d945ff3fd416dd82bb3f1ff4268f2001e5a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: fix ModifiedNode locking 50/7350/2
Robert Varga [Thu, 22 May 2014 21:50:05 +0000 (23:50 +0200)]
BUG-509: fix ModifiedNode locking

This removes the 'sealed' flag from ModifiedNode, as it is not a
publicly-visible object. Also drop the synchronized blocks and
reintroduce them in InMemoryDataTreeModification, which is the user
entrypoint.

Change-Id: I6c8be61701134bd8f645b8d4f0a8ef3ae218f0ac
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: migrate to TreeNodes 46/7346/2
Robert Varga [Thu, 22 May 2014 20:58:55 +0000 (22:58 +0200)]
BUG-509: migrate to TreeNodes

This patch performs the switchover to SPI-provided TreeNodes. It also
extracts the information needed for checking applicability of a
modification into a separate interface. Also adds some documentation in
the non-trivial write+merge path.

Change-Id: I83f5ca30bff21774759f9b675b19b6e9622076a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: create data tree SPI package 45/7345/2
Robert Varga [Thu, 22 May 2014 20:49:47 +0000 (22:49 +0200)]
BUG-509: create data tree SPI package

This patch introduces an SPI package, which contains the metadata tree
node abstraction and reference implementation. This will substitute the
StoreMetadataNode class.

Major improvement is the isolation of lifecycle from the rest of the
implementation and major reduction in memory usage, as leaf nodes no
longer need to lug a HashMap around.

Change-Id: I89215672006b1ed6064feaf186c94c05550d299e
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: add some documentation 44/7344/2
Robert Varga [Thu, 22 May 2014 05:38:07 +0000 (07:38 +0200)]
BUG-509: add some documentation

Documents AlwaysFailOperation and DataNodeContainerModificationStrategy

Change-Id: Ibb67dc5f4a829547538ba02c3eac4f995a6fe6ef
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: break up SchemaAwareApplyOperation 43/7343/1
Robert Varga [Wed, 21 May 2014 11:55:41 +0000 (13:55 +0200)]
BUG-509: break up SchemaAwareApplyOperation

This patch breaks up the SchemaAwareApplyOperation class by moving its
abstract subclasses out, allowing their subclasses to be retained within
them. This will allow to better understand the relationships between the
classes.

Change-Id: I0acf48fa7c38d600fe38a8ec9951858f46be18e0
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: move snapshotCache get out of try block 42/7342/1
Robert Varga [Wed, 21 May 2014 13:21:14 +0000 (15:21 +0200)]
BUG-509: move snapshotCache get out of try block

This just moves the get which cannot throw out of the 'catch Exception'
block.

Change-Id: I936e987fa6b9e8b3eecb35656c586e3afb070046
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-868: remove the use of Javassist.init() 22/7322/2
Robert Varga [Wed, 21 May 2014 21:55:18 +0000 (23:55 +0200)]
BUG-868: remove the use of Javassist.init()

The init method, as well as setPool() have been deprecated. Prefer the
in-one-go costructor.

Change-Id: I73298d3b36502c0bad0c09f2f7f2d87bb67bbb37
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Fix for Bug 934 - issue in validations for nuetronPort creation and updatePort"
Ed Warnicke [Thu, 22 May 2014 01:08:59 +0000 (01:08 +0000)]
Merge "Fix for Bug 934 - issue in validations for nuetronPort creation and updatePort"

7 years agoBug 735 - Part 2 - Modify controller to reference new yang-types bundle and and ietf... 50/7250/4
Devin Avery [Tue, 20 May 2014 15:03:07 +0000 (11:03 -0400)]
Bug 735 - Part 2 - Modify controller to reference new yang-types bundle and and ietf-bundles.

Patch 1: Set up the restconf bundle to reference the ietf-restconf and ietf-yangtypes-2013 bundles respectively.

Patch 2: Kick off another jenkins build now that dependent artifacts exist.

Patch 3/4: Fixed version issue.

Change-Id: I68b8edc577f5b2e84661a8a4eaed2078c0623aab
Signed-off-by: Devin Avery <devin.avery@brocade.com>
7 years agoMerge "BUG-509: merge InMemoryDataTreeModification.resolveSnapshot()"
Tony Tkacik [Wed, 21 May 2014 17:24:58 +0000 (17:24 +0000)]
Merge "BUG-509: merge InMemoryDataTreeModification.resolveSnapshot()"

7 years agoMerge "BUG-509: there is only one createRecursively()"
Tony Tkacik [Wed, 21 May 2014 17:23:52 +0000 (17:23 +0000)]
Merge "BUG-509: there is only one createRecursively()"

7 years agoMerge "BUG-509: Remove unused methods"
Tony Tkacik [Wed, 21 May 2014 17:23:08 +0000 (17:23 +0000)]
Merge "BUG-509: Remove unused methods"

7 years agoMerge "BUG-509: node version is always required"
Tony Tkacik [Wed, 21 May 2014 17:22:30 +0000 (17:22 +0000)]
Merge "BUG-509: node version is always required"

7 years agoMerge "Bug 992 - Fix broken netconf xml serialization."
Tony Tkacik [Wed, 21 May 2014 16:18:51 +0000 (16:18 +0000)]
Merge "Bug 992 - Fix broken netconf xml serialization."

7 years agoBUG-509: merge InMemoryDataTreeModification.resolveSnapshot() 95/7295/2
Robert Varga [Wed, 21 May 2014 09:40:36 +0000 (11:40 +0200)]
BUG-509: merge InMemoryDataTreeModification.resolveSnapshot()

This patch adds some minimal documentation and merges the two
resolveSnapshot() methods into one, making the call stack a bit easier
to understand.

Change-Id: Ib23fccdc9d2987aa255483becc63155904ebc332
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: there is only one createRecursively() 94/7294/2
Robert Varga [Tue, 20 May 2014 14:25:33 +0000 (16:25 +0200)]
BUG-509: there is only one createRecursively()

The naming and exposure of two and three arugment variants made things
confusing -- let it be clear there is only one version.

Change-Id: If05620e99c2200ee10c1881de8eecd015f18eb9b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: Remove unused methods 93/7293/2
Robert Varga [Tue, 20 May 2014 14:12:41 +0000 (16:12 +0200)]
BUG-509: Remove unused methods

These two have no users, so let's remove them to make navigating the
code easier.

Change-Id: I515570db5a8a4095ff525f1ca5614f9f627616df
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: node version is always required 92/7292/2
Robert Varga [Tue, 20 May 2014 13:42:32 +0000 (15:42 +0200)]
BUG-509: node version is always required

This just clarifies the requirement to know the node version you are
attempting to build before instantiating a builder. Also remove some
unused methods.

Change-Id: I09406bbedee963624b43a280529d4b8cbc9931c6
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "BUG-509: cleanup StoreMetadataNode"
Tony Tkacik [Wed, 21 May 2014 15:19:53 +0000 (15:19 +0000)]
Merge "BUG-509: cleanup StoreMetadataNode"

7 years agoMerge "BUG-509: Refactor listener walking"
Tony Tkacik [Wed, 21 May 2014 15:19:27 +0000 (15:19 +0000)]
Merge "BUG-509: Refactor listener walking"

7 years agoCouple of warnings 90/7290/1
Robert Varga [Tue, 20 May 2014 10:05:49 +0000 (12:05 +0200)]
Couple of warnings

This fixes a couple of warnings about pom.xml declaring duplicate things
(groupId, version).

Change-Id: Idb6e362a78cfa5d96609db6ebcc581e9349a08a4
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: cleanup StoreMetadataNode 91/7291/1
Robert Varga [Tue, 20 May 2014 13:10:29 +0000 (15:10 +0200)]
BUG-509: cleanup StoreMetadataNode

Removes StoreTreeNode<StoreMetadataNode> interface and tightens
visibility of a few methods.

Change-Id: I3bbf303025046f217bdcea81fcc14c420dbf9478
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: Refactor listener walking 44/7244/3
Robert Varga [Tue, 20 May 2014 08:52:59 +0000 (10:52 +0200)]
BUG-509: Refactor listener walking

This patch creates a proper abstraction for examining a
DataTreeCandidate for changes. This has the nice property of finishing
the hiding of all implementation details behind proper interfaces, such
that our implementation is free to do proper lifecycle as it pleases.

Also gets rid of the AutoCloseable from candidate. It can be
reintroduced in the need appears.

Change-Id: I13301548594d4ae34e929c7202661997ea5aca90
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"
Ed Warnicke [Tue, 20 May 2014 21:55:37 +0000 (21:55 +0000)]
Merge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"

7 years agoMerge "Bug 953 - Change the BindingIndependentConnector to handle RpcInvocationStrate...
Tony Tkacik [Tue, 20 May 2014 14:57:56 +0000 (14:57 +0000)]
Merge "Bug 953 - Change the BindingIndependentConnector to handle RpcInvocationStrategies consistently."

7 years agoMerge "BUG-509: Move ModificationApplyOperation"
Tony Tkacik [Tue, 20 May 2014 13:42:35 +0000 (13:42 +0000)]
Merge "BUG-509: Move ModificationApplyOperation"

7 years agoMerge "BUG-509: remove unused code"
Tony Tkacik [Tue, 20 May 2014 13:42:07 +0000 (13:42 +0000)]
Merge "BUG-509: remove unused code"

7 years agoMerge "BUG-509: Move DataTree concepts into separate package"
Tony Tkacik [Tue, 20 May 2014 13:41:49 +0000 (13:41 +0000)]
Merge "BUG-509: Move DataTree concepts into separate package"

7 years agoMerge "BUG-509: simple cleanup of DataTreeModification"
Tony Tkacik [Tue, 20 May 2014 13:39:41 +0000 (13:39 +0000)]
Merge "BUG-509: simple cleanup of DataTreeModification"

7 years agoMerge "BUG-509: Rename MutableDataTree to DataTreeModification"
Tony Tkacik [Tue, 20 May 2014 13:38:12 +0000 (13:38 +0000)]
Merge "BUG-509: Rename MutableDataTree to DataTreeModification"

7 years agoBug 953 - Change the BindingIndependentConnector to handle RpcInvocationStrategies... 06/6906/6
Devin Avery [Mon, 12 May 2014 15:52:51 +0000 (11:52 -0400)]
Bug 953 - Change the BindingIndependentConnector to handle RpcInvocationStrategies consistently.

Patch Set 1/2/3
*Combined the RpcInvocationStrategies into a single intelligence class that handles the varying strategies since the majority of the intelligence was overlapped.
*Moved some logic out of the BindingIndependentConnector to simplify it.
*Added an RpcInvocationStrategyTest to validate logic in RpcInvocationStrategy.

Patch Set 4
* Removed tabs and trailing whitespace

Patch Set 6
* Addressed NPE that would happen when no input was provided to a method requiring input.

Change-Id: I8d6916819105c5530c9b501e1ae973cdcb769ea7
Signed-off-by: Devin Avery <devin.avery@brocade.com>
7 years agoMerge "BUG-731: fix warnings from missing generic arguments"
Tony Tkacik [Tue, 20 May 2014 13:19:25 +0000 (13:19 +0000)]
Merge "BUG-731: fix warnings from missing generic arguments"

7 years agoMerge "BUG-731: fix unused imports"
Tony Tkacik [Tue, 20 May 2014 13:18:37 +0000 (13:18 +0000)]
Merge "BUG-731: fix unused imports"

7 years agoMerge "BUG-1018 Implement BackwardsCompatible BI broker data notifications"
Tony Tkacik [Tue, 20 May 2014 13:11:24 +0000 (13:11 +0000)]
Merge "BUG-1018 Implement BackwardsCompatible BI broker data notifications"

7 years agoMerge "BUG-868: move to use unified ClassLoaderUtils"
Tony Tkacik [Tue, 20 May 2014 12:51:02 +0000 (12:51 +0000)]
Merge "BUG-868: move to use unified ClassLoaderUtils"

7 years agoMerge "BUG-994: introduce object-cache into distribution"
Tony Tkacik [Tue, 20 May 2014 12:50:42 +0000 (12:50 +0000)]
Merge "BUG-994: introduce object-cache into distribution"

7 years agoMerge "Added .DS_STORE and .metadata to .gitignore"
Tony Tkacik [Tue, 20 May 2014 12:46:51 +0000 (12:46 +0000)]
Merge "Added .DS_STORE and .metadata to .gitignore"

7 years agoBUG-509: Move ModificationApplyOperation 43/7243/1
Robert Varga [Tue, 20 May 2014 07:45:36 +0000 (09:45 +0200)]
BUG-509: Move ModificationApplyOperation

This patch moves ModificationApplyOperation at al. to the data tree
package, improving its isolation.

Change-Id: I37081222e30c149a87baf6f4a5d3ce2e84f13acb
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: remove unused code 42/7242/1
Robert Varga [Tue, 20 May 2014 07:21:43 +0000 (09:21 +0200)]
BUG-509: remove unused code

Removes unused code, writen -> written, adds a FIXME

Change-Id: Id0795edc23f2aef6f73e42d54be877003daf4244
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: Move DataTree concepts into separate package 23/7223/2
Robert Varga [Mon, 19 May 2014 09:56:10 +0000 (11:56 +0200)]
BUG-509: Move DataTree concepts into separate package

Create a new package for the data tree and related concepts to clean out
interactions. Also create and document the API and hide implementation
classes from the user itself.

Change-Id: I69f2a9b7bcac863b531f46f669bfd2fcfcd5b743
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: simple cleanup of DataTreeModification 22/7222/2
Robert Varga [Mon, 19 May 2014 09:38:38 +0000 (11:38 +0200)]
BUG-509: simple cleanup of DataTreeModification

Rename rootModification to rootNode to clarify what it is
Use field updated to fix seals to save some memory

Change-Id: I0fe7f58a3c15613c15198830b77bc28a84a9006a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: Rename MutableDataTree to DataTreeModification 21/7221/2
Robert Varga [Mon, 19 May 2014 09:30:53 +0000 (11:30 +0200)]
BUG-509: Rename MutableDataTree to DataTreeModification

This name better reflects the semantics of the class. Also add some
javadoc documentation.

Change-Id: I7292c134bf87af8c0518e2905c7bd2b628c37a25
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix for Bug 934 - issue in validations for nuetronPort creation and updatePort 34/7234/2
ankit21a [Tue, 20 May 2014 08:48:08 +0000 (14:18 +0530)]
Fix for Bug 934 - issue in validations for nuetronPort creation and updatePort

Change-Id: I642faf51a4e986ba3a379f51edc71b4f1398b95b
Signed-off-by: ankit21a <ankit21.a@tcs.com>
7 years agoBUG-731: fix warnings from missing generic arguments 28/7228/2
Robert Varga [Mon, 19 May 2014 20:20:29 +0000 (22:20 +0200)]
BUG-731: fix warnings from missing generic arguments

This just goes in and adds wildcard generic arguments where appropriate,
removing ~100 eclipse warnings.

Change-Id: I34269906d6b78618646876f6448d3066bf036105
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoCosmetics: check in pom.xml files as _sort_pom_ wants them to be 25/7225/2
Flavio Fernandes [Mon, 19 May 2014 16:52:11 +0000 (12:52 -0400)]
Cosmetics: check in pom.xml files as _sort_pom_ wants them to be

Change-Id: I615dbec09ea84c650853639d5581183a4e63f11a
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
7 years agoBUG-731: fix unused imports 24/7224/1
Robert Varga [Mon, 19 May 2014 16:20:07 +0000 (18:20 +0200)]
BUG-731: fix unused imports

Performs just regular maintenance to get rid of warnings.

Change-Id: Icdaf65e6d92ebb3423187f012c3e931428db092c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-868: move to use unified ClassLoaderUtils 61/7161/2
Robert Varga [Sun, 18 May 2014 14:39:10 +0000 (16:39 +0200)]
BUG-868: move to use unified ClassLoaderUtils

This is a follow-up for yangtools patch
https://git.opendaylight.org/gerrit/#/c/7160/ . It updates the imports
to use the newly exposed version of ClassLoaderUtils.

Change-Id: I7178475ae698c3ba7120cf5ddfe56c4094f23d8b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-994: introduce object-cache into distribution 98/6998/2
Robert Varga [Wed, 14 May 2014 19:38:16 +0000 (21:38 +0200)]
BUG-994: introduce object-cache into distribution

This is the prerequisite for
https://git.opendaylight.org/gerrit/#/c/6926/, which introduces
dependency on object-cache-api. We also add implementation based on
Guava's Cache.

Change-Id: I798750bf95da540ee1c95c4ac18977729322a291
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Bug 624 - Separate netty and exi specific classes from netconf-util."
Ed Warnicke [Mon, 19 May 2014 12:39:04 +0000 (12:39 +0000)]
Merge "Bug 624 - Separate netty and exi specific classes from netconf-util."

7 years agoMerge "Commit generated test files after copyright was removed."
Ed Warnicke [Mon, 19 May 2014 12:36:18 +0000 (12:36 +0000)]
Merge "Commit generated test files after copyright was removed."

7 years agoMerge "Bug 953 - Enable mounted RPC calls via RestConf"
Tony Tkacik [Mon, 19 May 2014 12:35:53 +0000 (12:35 +0000)]
Merge "Bug 953 - Enable mounted RPC calls via RestConf"

7 years agoMerge "Adjust regenerated files to match what latest and greatest yang-tools will...
Ed Warnicke [Mon, 19 May 2014 12:29:24 +0000 (12:29 +0000)]
Merge "Adjust regenerated files to match what latest and greatest yang-tools will produce. This will avoid the annoying experience of having the following files shown as modified in git status."

7 years agoMerge "Store yang store snapshot cache using soft reference."
Ed Warnicke [Mon, 19 May 2014 12:28:20 +0000 (12:28 +0000)]
Merge "Store yang store snapshot cache using soft reference."

7 years agoMerge "Breaking up 6360: Adding base features"
Ed Warnicke [Mon, 19 May 2014 12:03:42 +0000 (12:03 +0000)]
Merge "Breaking up 6360: Adding base features"

7 years agoBug 992 - Fix broken netconf xml serialization. 93/6993/2
Tomas Olvecky [Wed, 14 May 2014 15:34:11 +0000 (17:34 +0200)]
Bug 992 - Fix broken netconf xml serialization.

Empty commit and restart triggered xml deserialization errors
in netconf. The problem is in type and name elements - they
should not be prefixed with 'prefix:'.

This fix triggers other bugs in md-sal modules, tracked
as dependencies of this bug. To test proper (de)serialization
with this fix, 01-netconf-connector.xml and 02-clustering.xml
must be delted.

Change-Id: I54d6ab23ec27ccbed924bf6abff95736f49dd5a3
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoMerge "Trigger a GC once initial configuration has been pushed"
Tony Tkacik [Mon, 19 May 2014 09:50:34 +0000 (09:50 +0000)]
Merge "Trigger a GC once initial configuration has been pushed"

7 years agoMerge "BUG-1027: rework lookup for clarity"
Tony Tkacik [Mon, 19 May 2014 09:28:43 +0000 (09:28 +0000)]
Merge "BUG-1027: rework lookup for clarity"

7 years agoMerge "BUG-1026: workaround race condition"
Tony Tkacik [Mon, 19 May 2014 09:25:07 +0000 (09:25 +0000)]
Merge "BUG-1026: workaround race condition"

7 years agoMerge "BUG-509: reorganize data tree abstractions."
Tony Tkacik [Mon, 19 May 2014 09:16:13 +0000 (09:16 +0000)]
Merge "BUG-509: reorganize data tree abstractions."

7 years agoBUG-1018 Implement BackwardsCompatible BI broker data notifications 14/7214/1
Maros Marsalek [Mon, 19 May 2014 09:10:14 +0000 (11:10 +0200)]
BUG-1018 Implement BackwardsCompatible BI broker data notifications

Finish support for notifying BI data change listeners in backwards compatible broker.

Change-Id: I221a1e6937c8f9c493444afd0756e6c23fd4b18f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "Bug 1029: Remove dead code: sal-binding-spi"
Tony Tkacik [Mon, 19 May 2014 09:08:48 +0000 (09:08 +0000)]
Merge "Bug 1029: Remove dead code: sal-binding-spi"

7 years agoMerge "Bug 1029: Remove dead code: sal-rest-connector-it"
Tony Tkacik [Mon, 19 May 2014 09:08:14 +0000 (09:08 +0000)]
Merge "Bug 1029: Remove dead code: sal-rest-connector-it"

7 years agoMerge "Bug 1029: Remove dead code: sal-dom-demo"
Tony Tkacik [Mon, 19 May 2014 09:07:59 +0000 (09:07 +0000)]
Merge "Bug 1029: Remove dead code: sal-dom-demo"

7 years agoMerge "Bug 1029: Remove dead code: sal-data-api"
Tony Tkacik [Mon, 19 May 2014 09:07:38 +0000 (09:07 +0000)]
Merge "Bug 1029: Remove dead code: sal-data-api"

7 years agoMerge "BUG-868: do not use InstanceIdentifier.getPath()"
Tony Tkacik [Mon, 19 May 2014 08:42:21 +0000 (08:42 +0000)]
Merge "BUG-868: do not use InstanceIdentifier.getPath()"

7 years agoMerge "Bug 1029: Remove dead code: clustered-data-store"
Tony Tkacik [Mon, 19 May 2014 08:12:16 +0000 (08:12 +0000)]
Merge "Bug 1029: Remove dead code: clustered-data-store"

7 years agoBUG-868: do not use InstanceIdentifier.getPath() 13/7213/1
Robert Varga [Mon, 19 May 2014 06:45:47 +0000 (08:45 +0200)]
BUG-868: do not use InstanceIdentifier.getPath()

This simplifies the NodeMapping class significantly by using the
utility methods shipped in InstanceIdentifier itself.

Change-Id: I1bb79bd4a16da9d78c600d21f67e3ca1926a0445
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoReplaced a couple of package imports with class imports 11/7211/1
Brent Salisbury [Mon, 19 May 2014 01:47:30 +0000 (21:47 -0400)]
Replaced a couple of package imports with class imports
in the L2switch sample bundle.

Change-Id: I2dbcf59e974cea99565ab254c528d4f7ea8dcec0
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
7 years agoBug 1029: Remove dead code: sal-binding-spi 08/7208/1
Ed Warnicke [Sun, 18 May 2014 23:01:43 +0000 (18:01 -0500)]
Bug 1029: Remove dead code: sal-binding-spi

opendaylight/md-sal/sal-binding-spi is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.
If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I2698f4bfa687e24e65989c1257c5f80d84ebe262
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBug 1029: Remove dead code: sal-rest-connector-it 93/7193/1
Ed Warnicke [Sun, 18 May 2014 18:00:33 +0000 (13:00 -0500)]
Bug 1029: Remove dead code: sal-rest-connector-it

opendaylight/md-sal/test/sal-rest-connector-it is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I2ab837c661552022792ff7f02a1c2b68f7928501
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBug 1029: Remove dead code: sal-dom-demo 92/7192/1
Ed Warnicke [Sun, 18 May 2014 17:59:02 +0000 (12:59 -0500)]
Bug 1029: Remove dead code: sal-dom-demo

opendaylight/md-sal/sal-dom-demo is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I77357764b8a779c444ed173e9e8a29a227ba3bf7
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBug 1029: Remove dead code: sal-data-api 91/7191/1
Ed Warnicke [Sun, 18 May 2014 17:57:04 +0000 (12:57 -0500)]
Bug 1029: Remove dead code: sal-data-api

opendaylight/md-sal/sal-data-api is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I28d9a8f63ff0398766d0d8c29f18a27d75642d2e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBug 1029: Remove dead code: clustered-data-store 90/7190/1
Ed Warnicke [Sun, 18 May 2014 17:50:40 +0000 (12:50 -0500)]
Bug 1029: Remove dead code: clustered-data-store

opendaylight/md-sal/clustered-data-store/ is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If in the future it needs to be revived it can be retrieved from
git.

Change-Id: Ie8365d5cb48e806a9d9a9fc0175478ef21277cbd
Signed-off-by: Ed Warnicke <eaw@cisco.com>
7 years agoBUG-509: reorganize data tree abstractions. 07/7107/2
Robert Varga [Thu, 15 May 2014 13:14:03 +0000 (15:14 +0200)]
BUG-509: reorganize data tree abstractions.

This patch has no functional changes, it only rearranges code such that
the flow of data and object lifecycle becomes more obvious. This will
make metadata lifecycle easier to manage.

Change-Id: I10fd912433b72e25729d163c27699a5a5c47e305
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-1027: rework lookup for clarity 53/7153/1
Robert Varga [Sun, 18 May 2014 10:10:21 +0000 (12:10 +0200)]
BUG-1027: rework lookup for clarity

This patch gets rid of the nasty 'catch Exception', making the lookup
fail as soon as a DeserializationException is thrown. We account for
most of the checked exceptions, so this should not be a problem.

Change-Id: I3d0440933ebc30ba32a06690ebe326e18addf613
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-1026: workaround race condition 49/7149/1
Robert Varga [Sun, 18 May 2014 08:19:27 +0000 (10:19 +0200)]
BUG-1026: workaround race condition

This patch provides a workaround: move the netconf-connector config past
any other configuration that may be present, such that it initializes
last. This will ensure that any models referenced have been instantiated
by the time the mount instance is announced.

Change-Id: Iba3587806932c307474e708209a39cba1d63ee5d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoChange in sal.connectionservice.notifyNodeDisconnectFromMaster 39/7139/1
Alessandro Boch [Sat, 17 May 2014 20:40:14 +0000 (13:40 -0700)]
Change in sal.connectionservice.notifyNodeDisconnectFromMaster

- On node disconnect from Master, notify the respective protocol plugin, not all of them

Change-Id: I2bfb30d2f649a1bc3f07be60150a814bcd1b8a45
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMerge "Bug 967: Do not translate leaf Instance Identifiers."
Ed Warnicke [Fri, 16 May 2014 15:15:24 +0000 (15:15 +0000)]
Merge "Bug 967: Do not translate leaf Instance Identifiers."

7 years agoBug 967: Do not translate leaf Instance Identifiers. 11/7111/1
Tony Tkacik [Fri, 16 May 2014 11:02:33 +0000 (13:02 +0200)]
Bug 967: Do not translate leaf Instance Identifiers.

Improved extraction of Instance Identifiers from
DOM Data Change Event.

Logs in console are poluted with DeserializationException,
which fails to deserialize DOM Instance Identifier
to Binding Instance Identifier.

Added explicit check against schema context to
see if Instance Identifier is representable
in Binding Format, if not we will not report
is as part of subtree Data Change event.

Change-Id: Iaee2390fd089e0a2d66ec658aab4e7dab2a93a46
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoBug 1022 - Add ability to lookup dependent Module's attribute. 10/7110/1
Tomas Olvecky [Fri, 16 May 2014 11:24:49 +0000 (13:24 +0200)]
Bug 1022 - Add ability to lookup dependent Module's attribute.

Add 2 methods to DependencyResolver to allow modules look up values
of dependent bean attributes.

Change-Id: I2ebee82cc1260a84a16f5e69b32c9234bf576e87
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoBug 624 - Separate netty and exi specific classes from netconf-util. 31/6931/2
Tomas Olvecky [Tue, 13 May 2014 13:26:28 +0000 (15:26 +0200)]
Bug 624 - Separate netty and exi specific classes from netconf-util.

As preparation step for splitting netconf into service and protocol,
create netconf-netty-util bundle with classes dependent on protocol
handlers - netty, exi, ssh.

Change-Id: I22ba17d0fa4f86c5f64cb3258a55f2c54da85dee
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoMerge "Add lispflowmapping specific configuration options"
Giovanni Meo [Fri, 16 May 2014 08:24:09 +0000 (08:24 +0000)]
Merge "Add lispflowmapping specific configuration options"

7 years agoMerge "Node Name in non-default container should default to Node Name in Default...
Andrew Kim [Thu, 15 May 2014 22:00:43 +0000 (22:00 +0000)]
Merge "Node Name in non-default container should default to Node Name in Default Slice"

7 years agoNode Name in non-default container should default to Node Name in Default Slice 04/7004/2
Pramila Singh [Wed, 14 May 2014 22:35:13 +0000 (15:35 -0700)]
Node Name in non-default container should default to Node Name in Default Slice

Change-Id: I81670c824bfcb4d7f400ef224abf329b6bc20abd
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoBug 953 - Enable mounted RPC calls via RestConf 15/6815/15
Devin Avery [Thu, 8 May 2014 13:00:29 +0000 (09:00 -0400)]
Bug 953 - Enable mounted RPC calls via RestConf

Modify RestconfImpl to allow RPC calls via mount points.
===
MountPointImpl - wired pass through call for invokeRpc that was missing.
RestconfImpl - abstract the execution of RPC out to an "RpcExecutor" class.
Remaining classes - added tests to cover new code, including the toaster.yang file (modified from original) to test various RPC calls.

- Patch Set 8 - fixed unit tests which were failing (one failure due to missing future enhancement, another due to missing test rpc in yang file).
- Patch Set 10 - fixed run failure by addressing package import.
- Patch Set 13 - Cleaned up exception throws / used Preconditions checking.
- Patch Set 14 - Rebased
- Patch Set 15 - Added back change that was accidently removed during merge / rebase.

Change-Id: Ib214b4c82ffc487ee2f7b912e65d5c189b82154a
Signed-off-by: Devin Avery <devin.avery@brocade.com>
7 years agoMerge "Bug 509: Improve conflict detection of leaf merges"
Tony Tkacik [Thu, 15 May 2014 15:50:38 +0000 (15:50 +0000)]
Merge "Bug 509: Improve conflict detection of leaf merges"

7 years agoMerge changes Ibe0145be,I0764bfa9
Tony Tkacik [Thu, 15 May 2014 15:50:08 +0000 (15:50 +0000)]
Merge changes Ibe0145be,I0764bfa9

* changes:
  BUG-509: remove DataAndMetadataSnapshot.Builder.getDataTree()
  BUG-509: remove StoreMetadataNode.children()

7 years agoMerge "BUG-509: remove StoreUtils.initialChangeEvent()"
Tony Tkacik [Thu, 15 May 2014 15:49:44 +0000 (15:49 +0000)]
Merge "BUG-509: remove StoreUtils.initialChangeEvent()"

7 years agoMerge "BUG-509: StoreUtils should operate on NormalizedNode"
Tony Tkacik [Thu, 15 May 2014 15:49:11 +0000 (15:49 +0000)]
Merge "BUG-509: StoreUtils should operate on NormalizedNode"

7 years agoBug 509: Improve conflict detection of leaf merges 22/7022/1
Robert Varga [Thu, 15 May 2014 14:55:02 +0000 (16:55 +0200)]
Bug 509: Improve conflict detection of leaf merges

Original conflict detection for merge action on leaves
only looked at node version and subtree version, which
caused the transaction to fail even if the leaf was
unmodified and contained the same value.

Conflict detection now checks if the leaves are not same,
and only in that case it checks for concurrent writes.

Change-Id: I5e43233e86adf96e3dad2a93cdcf512b3d17977a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-509: remove DataAndMetadataSnapshot.Builder.getDataTree() 17/7017/1
Robert Varga [Thu, 15 May 2014 12:37:19 +0000 (14:37 +0200)]
BUG-509: remove DataAndMetadataSnapshot.Builder.getDataTree()

This getter and its associated field is completely unused. Remove it to
improve clarity.

Change-Id: Ibe0145bee610c7a2b147852f43d0492ca5061adc
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Bug 1002 - REST POST transaction is not commited"
Tony Tkacik [Thu, 15 May 2014 12:02:38 +0000 (12:02 +0000)]
Merge "Bug 1002 - REST POST transaction is not commited"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.