controller.git
9 years agoMerge "Ensure that modifications are tracked by ShardTransaction"
Ed Warnicke [Mon, 30 Jun 2014 16:39:04 +0000 (16:39 +0000)]
Merge "Ensure that modifications are tracked by ShardTransaction"

9 years agoMerge "Introducing the Modification classses"
Ed Warnicke [Mon, 30 Jun 2014 16:38:29 +0000 (16:38 +0000)]
Merge "Introducing the Modification classses"

9 years agoMerge "Implement finding a primary based on the shard name and do basic wiring of...
Ed Warnicke [Mon, 30 Jun 2014 16:36:12 +0000 (16:36 +0000)]
Merge "Implement finding a primary based on the shard name and do basic wiring of DistributedDataStore and ShardManager"

9 years agoMerge "Fixing issue with failing to remove 02-clustering.xml"
Devin Avery [Mon, 30 Jun 2014 16:02:09 +0000 (16:02 +0000)]
Merge "Fixing issue with failing to remove 02-clustering.xml"

9 years agoMerge "Partial fix for Bug 1256"
Ed Warnicke [Mon, 30 Jun 2014 15:54:08 +0000 (15:54 +0000)]
Merge "Partial fix for Bug 1256"

9 years agoFixing issue with failing to remove 02-clustering.xml 60/8460/1
Ed Warnicke [Mon, 30 Jun 2014 15:35:51 +0000 (10:35 -0500)]
Fixing issue with failing to remove 02-clustering.xml

https://git.opendaylight.org/gerrit/#/c/8304/
removed the antiquated remoterpc stuff, but
failed to remove the 02-clustering.xml file.

Change-Id: I4b20ee620821ee945fd51b3d37eb7c24b491a0bd
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 1236 - Documented Binding-aware RPC services of MD-SAL 30/8330/6
Tony Tkacik [Wed, 25 Jun 2014 08:47:02 +0000 (10:47 +0200)]
Bug 1236 - Documented Binding-aware RPC services of MD-SAL

Documented Binding-aware RPC API contracts

Added simple example / tutorial for routed RPCs.

Change-Id: I0f3a08a392e148732dc218a8ac67bc6f90ea7b0e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoCreated Proper Feature File for AD-SAL 16/7916/4
Mathieu Lemay [Wed, 11 Jun 2014 18:09:39 +0000 (14:09 -0400)]
Created Proper Feature File for AD-SAL

PatchSet2: Brought in the base-features dependencies
   to the opendaylight-karaf pom file so
   features-adsal doesn't break for lack of it
   still getting the error:

dopendaylight-user@root>feature:install odl-adsal-all
'org.opendaylight.controller.logging.bridge.internal.LogListenerImpl@281cf63e' is removed as a LogListener, since it threw an exception.
Error executing command: Could not start bundle mvn:org.opendaylight.controller/sal.implementation/0.4.2-SNAPSHOT in feature(s) odl-adsal-core-0.8.1-SNAPSHOT: Unresolved constraint in bundle org.opendaylight.controller.sal.implementation [81]: Unable to resolve 81.0: missing requirement [81.0] osgi.wiring.package; (&(osgi.wiring.package=org.eclipse.osgi.framework.console)(version>=1.1.0)(!(version>=2.0.0)))

PatchSet3:  Rebased and fixed the commons.lang.version
to be commons.lang3.version.  Still getting the error
from Patch3.

PatchSet4: Fixed.

Change-Id: I8190b4bbc52fb1c3202570b5f77477e4a0f30c48
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBug 1027: Sort map of instance-identifiers and data by length. 55/8455/1
Tony Tkacik [Mon, 30 Jun 2014 12:53:27 +0000 (14:53 +0200)]
Bug 1027: Sort map of instance-identifiers and data by length.

In order to have more reliable deserialization of Maps
of Bidning-Independented data to Binding-Aware
entries should be sorted by their length, with shorter
ones beforehand, since codecs for them have higher
probability to be known.

Parent codecs also contains references to child-classes
which may be never used in new context so this
makes deserialization more predicable and easier to debug.

Change-Id: Iad1490f893e946a2a019c88570325dcfb11c244d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "Remove remoterpc dead code."
Tony Tkacik [Mon, 30 Jun 2014 11:24:19 +0000 (11:24 +0000)]
Merge "Remove remoterpc dead code."

9 years agoProtocol framework: use pooled ByteBuf allocator 69/7769/6
Robert Varga [Fri, 6 Jun 2014 08:39:35 +0000 (10:39 +0200)]
Protocol framework: use pooled ByteBuf allocator

This should enhance the default performance characteristics by reusing
ByteBufs if possible. With 4.0.19, netty keeps a thread-local cache of
direct buffers, so we should see a reduction in buffer copying, if not
other effects.

Change-Id: I81fcf380f6f3b03187000dbca0dd8507975e8dd1
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Bug:1252 - Fix formatting errors in config code generator"
Tony Tkacik [Mon, 30 Jun 2014 08:22:02 +0000 (08:22 +0000)]
Merge "Bug:1252 - Fix formatting errors in config code generator"

9 years agoMerge "BUG-944 Remove backwards compatibility config from sal-netconf- connector."
Tony Tkacik [Mon, 30 Jun 2014 08:15:21 +0000 (08:15 +0000)]
Merge "BUG-944 Remove backwards compatibility config from sal-netconf- connector."

9 years agoMerge "Bug:1253 - Fix NPE in config pusher"
Tony Tkacik [Mon, 30 Jun 2014 08:09:36 +0000 (08:09 +0000)]
Merge "Bug:1253 - Fix NPE in config pusher"

9 years agoBUG-874 Add none default operation to delete requests (netconf-connector) 97/8297/3
Maros Marsalek [Tue, 24 Jun 2014 11:58:30 +0000 (13:58 +0200)]
BUG-874 Add none default operation to delete requests (netconf-connector)

Delete requests now contain <default-operation>none</default-operation> tag to prevent modification of the data tree on remote device when deleting nested nodes.

Change-Id: Id5cb7945b6845d6ccea7ef71a07d914cdf5f2ed9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-874 Remove rolback cabaility advertised by config netconf 96/8296/4
Maros Marsalek [Tue, 24 Jun 2014 11:54:57 +0000 (13:54 +0200)]
BUG-874 Remove rolback cabaility advertised by config netconf

The rollback on error option is not supported by the netconf server endpoint for config subsystem therefore it cannot advertise rollback on error capability.
If it is present in message, the rpc will fail.

Change-Id: If32113aa77d9ef5d614b143741d1d04fbdc0d22d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoPartial fix for Bug 1256 39/8439/6
Colin Dixon [Sun, 29 Jun 2014 20:19:44 +0000 (15:19 -0500)]
Partial fix for Bug 1256

Patch 0e12a849d33ae3ca3d1a8e2e281e6eac2cc13373 introduced a test for data normalization
that contained comparators for two kinds of nodes (LegacyNodeData) and (Node<?>) that
provided only a partial ordering of nodes and also failed to obey the semantics of
comparators when it comes to equality.

The result is that several tests were not fully specified and while the appear to run
correctly on Windows and Linux, on recent MacOS versions the ambiguity caused the tests
to fail.

This patch fixes the problem as long as only SimpleNodes and CompositeNodes are used.

Change-Id: If5175025fb97e7b8ddb799b27ad7ae9b5026172d
Signed-off-by: Colin Dixon <colin@colindixon.com>
9 years agoBug 1007 - Statistics manager loses threads to uncaught exceptions 38/8438/1
Anil Vishnoi [Sun, 29 Jun 2014 10:32:40 +0000 (16:02 +0530)]
Bug 1007 - Statistics manager loses threads to uncaught exceptions

Change-Id: I214aa0ab2cd55428c7b1ae200e3419cf6a2abc87
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>
9 years agoMerge "ArpHandler to send ARP reply on proper vlan"
Giovanni Meo [Sat, 28 Jun 2014 14:16:36 +0000 (14:16 +0000)]
Merge "ArpHandler to send ARP reply on proper vlan"

9 years agoArpHandler to send ARP reply on proper vlan 29/8429/1
Alessandro Boch [Fri, 27 Jun 2014 17:18:13 +0000 (10:18 -0700)]
ArpHandler to send ARP reply on proper vlan

- Recently ARPHandler has been enhanced to process ARP request received on vlans.
  This further enhancement is for the respective controller generated ARP reply
  to be sent out on the proper vlan.

Change-Id: Ib8e26901f625677ad59302dfd09add4719b7b02d
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoBUG-835 + BUG-1234 logical nodeConnection names 23/8423/2
Michal Rehak [Fri, 27 Jun 2014 20:35:50 +0000 (22:35 +0200)]
BUG-835 + BUG-1234 logical nodeConnection names

- fixed logical nodeConnection names
- added description property to adNode
- added error logging

Change-Id: Idfe5db5f50315f9d4cfde4b9d33e5d559a879b95
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoEnhancements for hosts behing trunks 15/8415/2
Giovanni Meo [Fri, 27 Jun 2014 17:11:58 +0000 (19:11 +0200)]
Enhancements for hosts behing trunks

- Allow to skip dot1Q if present
- Allow to dispatch only to container if there is a match else pass to default

Change-Id: I58c0a11e0e499f2f531f72b803863cf8f996867f
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoMerge "Bug 1245: Dropped Binding prefix from Binding Data APIs."
Devin Avery [Fri, 27 Jun 2014 16:06:05 +0000 (16:06 +0000)]
Merge "Bug 1245: Dropped Binding prefix from Binding Data APIs."

9 years agoMerge "Bug 1227: Removed #close() from Write Transactions."
Devin Avery [Fri, 27 Jun 2014 15:52:38 +0000 (15:52 +0000)]
Merge "Bug 1227: Removed #close() from Write Transactions."

9 years agoBug 484 - Anyxml in sal-rest-connector 67/8067/6
Jozef Gloncak [Tue, 17 Jun 2014 11:22:24 +0000 (13:22 +0200)]
Bug 484 - Anyxml in sal-rest-connector

- RestconfImpl: handled AnyXmlSchemaNode

- JsonMapper: handled AnyXmlSchemaNode

- CnSnToJsonBasicDataTypesTest: added test cases for anyxml.

This commit depends (therefore is commited as draft) on commits:
- Add Anyxml normalized node to yang-data-api -
https://git.opendaylight.org/gerrit/#/c/7771/1
- Implementation of Anyxml builder -
  https://git.opendaylight.org/gerrit/#/c/8061/

Change-Id: Ib3da88cc6af96d98d139f7c1bbc94408ef9e814d
Signed-off-by: tpantelis <tpanteli@brocade.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBug:1252 - Fix formatting errors in config code generator 04/8404/1
Tomas Olvecky [Fri, 27 Jun 2014 11:35:33 +0000 (13:35 +0200)]
Bug:1252 - Fix formatting errors in config code generator

Fix intendation and double semicolons in yang-jmx-generator-plugin.

Change-Id: I77ad31eaa62a41d0149f57754f5ec727e07ad292
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoMerge "AD-SAL: Filter packet-in based on container flow"
Giovanni Meo [Fri, 27 Jun 2014 10:36:10 +0000 (10:36 +0000)]
Merge "AD-SAL: Filter packet-in based on container flow"

9 years agoBug:1253 - Fix NPE in config pusher 03/8403/1
Tomas Olvecky [Fri, 27 Jun 2014 09:38:37 +0000 (11:38 +0200)]
Bug:1253 - Fix NPE in config pusher

Add better error message when ConfigSnapshotHolder contract is voilated.
Fix
org.opendaylight.controller.config.persist.storage.file.xml.model.ConfigSnapshot
to return empty set instead of null in getCapabilities()

Change-Id: I9783cccbe53ae69e322e1d5660ad1f3b52b007fa
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoAD-SAL: Filter packet-in based on container flow 57/8357/4
Alessandro Boch [Tue, 24 Jun 2014 23:52:12 +0000 (16:52 -0700)]
AD-SAL: Filter packet-in based on container flow

- In AD-SAL openflow plugin incoming packets are delivered
  to listeners in respective container only based on incoming port.
- This patch enforces the container flow filtering logic as well

Change-Id: I6a23b114712e63b8ffb18c173bbbaad5fb7634bd
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoBUG-835 Reserve ports should be logical ports - part2 74/8374/1
Michal Rehak [Thu, 26 Jun 2014 14:54:31 +0000 (16:54 +0200)]
BUG-835 Reserve ports should be logical ports - part2

- fixed unit tests

Change-Id: I10bd053fb70c5dfe198d171202b0a7bd7f70ef06
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge "Bug-835:Reserve ports should be logical ports"
Ed Warnicke [Thu, 26 Jun 2014 12:16:48 +0000 (12:16 +0000)]
Merge "Bug-835:Reserve ports should be logical ports"

9 years agoMerge "Adding tunnel ipv4 src/dst flow-base model augmentations"
Ed Warnicke [Thu, 26 Jun 2014 11:24:29 +0000 (11:24 +0000)]
Merge "Adding tunnel ipv4 src/dst flow-base model augmentations"

9 years agoBug 1227: Removed #close() from Write Transactions. 49/8249/5
Tony Tkacik [Mon, 23 Jun 2014 14:17:08 +0000 (16:17 +0200)]
Bug 1227: Removed #close() from Write Transactions.

Termination of write transactions was unclear due
to several terminal methods such as commit, cancel
and close.

Close was removed from write transactions and is only
available for read-only transactions.

Termination methods for write transactions are close
 and commit.

Introduced new interfaces for ReadOnly transactions
to clearly distinguish between read capability
of transaction and read-only semantic (which has
close method).

Change-Id: I74b3fd2066a55160da3b674156fc0dc54ba14a67
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBUG 1211 - deletion non existing target returns 500 98/8298/3
Jozef Gloncak [Tue, 24 Jun 2014 12:29:50 +0000 (14:29 +0200)]
BUG 1211 - deletion non existing target returns 500

It is checked whether data at specified path exists (via method
readConfigurationData). If it isn't so then HTTP response returning code
is set to 200.

Change-Id: I0c0f51c144ffc430ac5bcef118f485f84ae25207
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "BUG-1234 nodeType/ID in adaptors"
Ed Warnicke [Thu, 26 Jun 2014 04:51:59 +0000 (04:51 +0000)]
Merge "BUG-1234 nodeType/ID in adaptors"

9 years agoEnsure that modifications are tracked by ShardTransaction 69/8269/4
Moiz Raja [Fri, 20 Jun 2014 23:42:19 +0000 (16:42 -0700)]
Ensure that modifications are tracked by ShardTransaction

As modifications are made on a ShardTransaction they are applied to the transaction object that ShardTransaction wraps
However the modifications also need to be tracked. This tracking would be used ultimately by the Shard when persisting data.

Change-Id: I4bb76699d251dbdc786416313479f0e6b31962e1
Signed-off-by: Moiz Raja <moraja@cisco.com>
9 years agoIntroducing the Modification classses 89/8189/5
Moiz Raja [Fri, 20 Jun 2014 18:46:53 +0000 (11:46 -0700)]
Introducing the Modification classses

The purpose of these classes is to capture all modifications are done on a transaction.

The reason for capturing these modifications is so that we can persist them to the transaction journal

When a member is restarted or a shard is restarted the "Modifications" will be read from the log and replayed
on the Shard at which point the Shard can create a new transaction and apply it to the current state

Change-Id: I4a9b1c3f28eac5c4d360d743efc44286d8a1acca
Signed-off-by: Moiz Raja <moraja@cisco.com>
9 years agoImplement finding a primary based on the shard name and do basic wiring of Distribute... 63/8163/4
Moiz Raja [Fri, 20 Jun 2014 00:45:15 +0000 (17:45 -0700)]
Implement finding a primary based on the shard name and do basic wiring of DistributedDataStore and ShardManager

Change-Id: I98d22e68335a6f901e0584a1a497519e28c7d241
Signed-off-by: Moiz Raja <moraja@cisco.com>
9 years agoReverted merged changes breaking karaf distribution 02/8102/2
Mathieu Lemay [Wed, 18 Jun 2014 01:06:26 +0000 (21:06 -0400)]
Reverted merged changes breaking karaf distribution

Change-Id: I61fa5a9aa7c60fd0ac21c282ddf6b875cbd5084c
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBUG-1234 nodeType/ID in adaptors 54/8354/1
Michal Rehak [Wed, 25 Jun 2014 15:06:21 +0000 (17:06 +0200)]
BUG-1234 nodeType/ID in adaptors

- node change: type MD_SAL -> OF, nodeId String->Long (=dpid)
- nodeConnector change: type MD_SAL -> OF, nodeConnectorId String->Short (=dpid)
- additional changes to statistic table conversions, topology - regarding type+id
- added unit tests

Change-Id: If7e2d6f49e558b9fe95d0a07cf86ed10eb28ff5a
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoSupport for FIQL queries on REST retreive operations 10/7610/5
Prasanth Pallamreddy [Wed, 14 May 2014 17:03:37 +0000 (10:03 -0700)]
Support for FIQL queries on REST retreive operations

  - Retreive operations can be filtered based on FIQL queries.
  - Spec at http://tools.ietf.org/html/draft-nottingham-atompub-fiql-00
  - Details of the feature can be found at
    https://pad.opendaylight.org/p/rest-search

Change-Id: I3d7cc4350e890148fff5bd086f76ec51e63f2c3b
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
9 years agoMerge "Fixed concurrency bug in DOMTransactionChainTest"
Ed Warnicke [Wed, 25 Jun 2014 16:08:24 +0000 (16:08 +0000)]
Merge "Fixed concurrency bug in DOMTransactionChainTest"

9 years agoMerge "Having InMemoryDOMDatastore in its own bundle.To make it configurable using...
Tony Tkacik [Wed, 25 Jun 2014 13:06:39 +0000 (13:06 +0000)]
Merge "Having InMemoryDOMDatastore in its own bundle.To make it configurable using the config subystem. patch 5 changes: md-sal/pom.xml correction"

9 years agoMerge "Bug:1238 - Revert changes to SshClientAdapter."
Tony Tkacik [Wed, 25 Jun 2014 09:51:20 +0000 (09:51 +0000)]
Merge "Bug:1238 - Revert changes to SshClientAdapter."

9 years agoMerge "BUG 1179 - rpcResult = false but response 200"
Tony Tkacik [Wed, 25 Jun 2014 09:48:07 +0000 (09:48 +0000)]
Merge "BUG 1179 - rpcResult = false but response 200"

9 years agoHaving InMemoryDOMDatastore in its own bundle.To make it configurable 65/8165/7
Basheeruddin Ahmed [Fri, 20 Jun 2014 06:34:15 +0000 (23:34 -0700)]
Having InMemoryDOMDatastore in its own bundle.To make it configurable
using the config subystem.
patch 5 changes:
md-sal/pom.xml correction

patch 4 changes:
Moved data tree api and impl to yang-tools based on earlier comment

Patch 3 changes:
1. Included sal-inmemory-datastore dependency in TestHelper.java for PaxExam
integration test cases [Weird that it was working earlier and my local controller full build were passing]

Patch 2 changes:
1. Keeping schema service as part of opendaylight-dom-broker-impl for backward comptability scenario
2. Initializing InMemoryDOMDataStore by default if config-dom-datastore and
operation-dom-datastore are not found
3. Updated 01-md-sal.xml based on 1.
4. Regarding the comment of moving data tree in yangtools. It shall be done in
separate patch.

This is done to replace InMemoryDOMDatastore with distributed-datastore

The changes done are:
1. Created a new sal-inmemory-datastore bundle and moved the
store/impl source files from sal-dom-broker and the corresponding
InMemoryDOMDatastore test cases.

2. Created two yang config models in sal-dom-spi that represent
the configurable config-dom-datastore and operational-dom-datastore, that
are of service type DOMStore

3. In opendaylight-dom-broker-impl.yang of sal-dom-broker, in the augment of dom-inmemory-data-broker added two container config-data-store and operational-data-store that refer the service implementations of service defined in sal-dom-spi

4.In sal-inmemory-datastore bundle, created a yang model opendaylight-inmemory-datastore that provide the implementation of the sal-dom-spi service definitions mentioned in 2 -- The implementaions are augmented to have schema-service container required by InMemoryDOMDatastore for registering itself for scheam changes

5. Updated the 01-md-sal.xml with the above changes

6. Update the distribution pom.xml to include sal-inmemory-datastore.

Change-Id: Ib2f0f0556869981e7e60b3eeae9b1e5e6cc96a0f
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
9 years agoMerge "Helium: improve contract with ListenerRegistration"
Tony Tkacik [Wed, 25 Jun 2014 07:04:50 +0000 (07:04 +0000)]
Merge "Helium: improve contract with ListenerRegistration"

9 years agoBUG 1179 - rpcResult = false but response 200 36/8236/2
Jozef Gloncak [Mon, 23 Jun 2014 08:59:15 +0000 (10:59 +0200)]
BUG 1179 - rpcResult = false but response 200

Case for case when collection of errors is returned was added to
RestPostOperationTest.

Change-Id: Iea6c830d957001b01996e2640d8869105cf805ca
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "Introducing Protocol Buffers Encoding Required for Distributed Datastore Messa...
Moiz Raja [Wed, 25 Jun 2014 01:07:54 +0000 (01:07 +0000)]
Merge "Introducing Protocol Buffers Encoding Required for Distributed Datastore Messages Serialization"

9 years agoIntroducing Protocol Buffers Encoding 81/8281/5
Basheeruddin Ahmed [Tue, 24 Jun 2014 06:50:49 +0000 (23:50 -0700)]
Introducing Protocol Buffers Encoding
Required for Distributed Datastore Messages Serialization

Change-Id: I9276eb229af464061c149dfb008848ace4f51470
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
9 years agoMerge "Bug 1212: Values of VLAN match fields were wrong."
Alessandro Boch [Tue, 24 Jun 2014 23:01:04 +0000 (23:01 +0000)]
Merge "Bug 1212: Values of VLAN match fields were wrong."

9 years agoBug 1129 - POM Versioning changes for automated weekly releases - Moved all ommon... 96/7996/12
Surekha Bejgam [Fri, 13 Jun 2014 17:57:08 +0000 (10:57 -0700)]
Bug 1129 - POM Versioning changes for automated weekly releases -  Moved all ommon third party dependencies to odlparent

${nexusproxy} variable does not get replaced after introducing odlparent. This is a known bug in maven 2 & 3 where property replacement does not work reliably.

http://stackoverflow.com/questions/1363514/maven-does-not-replace-a-variable-in-settings-xml-when-it-is-invoked

As a workaround, I had to use complete url for nexus in repository and distribution management sections.

Change-Id: I78f31e0446cebec6f84b9d3959645ad7e440989e
Signed-off-by: Surekha Bejgam <sbejgam@cisco.com>
9 years agoRemove remoterpc dead code. 04/8304/1
Ed Warnicke [Tue, 24 Jun 2014 18:59:16 +0000 (13:59 -0500)]
Remove remoterpc dead code.

Change-Id: I4b16a179a93d3ccc65021aafccc2ed9f9e00b7e9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "BUG 484 Anyxml normalized node"
Tony Tkacik [Tue, 24 Jun 2014 15:27:52 +0000 (15:27 +0000)]
Merge "BUG 484 Anyxml normalized node"

9 years agoBug:1238 - Revert changes to SshClientAdapter. 93/8293/1
Tomas Olvecky [Tue, 24 Jun 2014 10:57:14 +0000 (12:57 +0200)]
Bug:1238 - Revert changes to SshClientAdapter.

Fix bug introduced in 412e6b4 by reverting back to previous state.
Also fix a resource leak in writeImpl.

Change-Id: If43741071d1471280491888078f342bc33269c5f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoMerge "Bug 1176: Lower log level when netconf ssh connection fails"
Tony Tkacik [Tue, 24 Jun 2014 09:08:25 +0000 (09:08 +0000)]
Merge "Bug 1176: Lower log level when netconf ssh connection fails"

9 years agoBUG 484 Anyxml normalized node 62/8062/4
Jozef Gloncak [Mon, 16 Jun 2014 12:22:41 +0000 (14:22 +0200)]
BUG 484 Anyxml normalized node

- DataNormalizationOperation: added AnyXmlNormalization for
  AnyXmlSchemaNode

- Moved DataNormalizerTest to sal-common-impl where the source code
  resides and added more tests including coverage for anyxml.

Originally commited under patch set 9
https://git.opendaylight.org/gerrit/#/c/7337/9 by Tom Pantelis

This commit depends (therefore is commited as draft) on commits:
- Add Anyxml normalized node to yang-data-api -
https://git.opendaylight.org/gerrit/#/c/7771/1
- Implementation of Anyxml builder -
  https://git.opendaylight.org/gerrit/#/c/8061/

Change-Id: I8f6febd1738cde3139cc32d8199d1a87c464ba34
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoMerge "BUG 484 - XmlReader improve readability"
Tony Tkacik [Tue, 24 Jun 2014 07:34:49 +0000 (07:34 +0000)]
Merge "BUG 484 - XmlReader improve readability"

9 years agoFixed concurrency bug in DOMTransactionChainTest 82/8282/1
Tony Tkacik [Tue, 24 Jun 2014 07:31:00 +0000 (09:31 +0200)]
Fixed concurrency bug in DOMTransactionChainTest

Delete transaction was commited before read was verified
since transaction commit was done in other thread
there was race-condition between allocating transactions
to verify datastore state.

Change-Id: I1717efbe160e59f42c3baca2f5a5f053d703350e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBUG-944 Remove backwards compatibility config from sal-netconf- 70/8170/7
Maros Marsalek [Fri, 20 Jun 2014 11:14:27 +0000 (13:14 +0200)]
BUG-944 Remove backwards compatibility config from sal-netconf-
connector.

BREAKS BACKWARDS COMPATIBILITY FOR CONNECTOR CONFIGURATION.
SEND EMAIL TO MAILING LIST ABOUT BREAKING COMPATIBILITY FOR NETCONF CONNECTOR BEFORE MERGE!
ALL DISTRIBUTIONS THAT USE NETCONF-CONNECTOR NEED TO UPDATE CONFIGURATION OF CONNECTORS ACCORDING TO 99-netconf-connector INITIAL CONFIG FILE

Deprecated config attributes and code removed.

Extracted common connector modules(threadfactory, threadpool and client dispatcher) from config file 99-netconf-connector into 01-netconf

Change-Id: I77a93a1dc6845414474632f85c93d8a940449ac6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Fix netconf ssh client"
Tony Tkacik [Tue, 24 Jun 2014 07:18:05 +0000 (07:18 +0000)]
Merge "Fix netconf ssh client"

9 years agoBut 1129: Removing hard coded versions from MD-SAL 58/8158/4
Vaishali Mithbaokar [Thu, 19 Jun 2014 21:48:44 +0000 (14:48 -0700)]
But 1129: Removing hard coded versions from MD-SAL

Change-Id: Ic4ea06f1fd644808946dd5111d38152d19b9bf35
Signed-off-by: Vaishali Mithbaokar <vmithbao@cisco.com>
9 years agoMerge "Bug 1129: Removing hard coded versions from config subsystem"
Ed Warnicke [Mon, 23 Jun 2014 20:18:52 +0000 (20:18 +0000)]
Merge "Bug 1129: Removing hard coded versions from config subsystem"

9 years agoMerge "BUG 1129:Removed hard coded version from netconf project as part of the automa...
Ed Warnicke [Mon, 23 Jun 2014 20:17:53 +0000 (20:17 +0000)]
Merge "BUG 1129:Removed hard coded version from netconf project as part of the automated release changes for controller"

9 years agoMerge "Cleanup: Removed unused inventory-config model."
Devin Avery [Mon, 23 Jun 2014 18:48:42 +0000 (18:48 +0000)]
Merge "Cleanup: Removed unused inventory-config model."

9 years agoMerge "API Clarity: Documented Async Data Broker APIs."
Devin Avery [Mon, 23 Jun 2014 16:12:43 +0000 (16:12 +0000)]
Merge "API Clarity: Documented Async Data Broker APIs."

9 years agoMerge "BUG-961 Fix Resource leak error from netty."
Tony Tkacik [Mon, 23 Jun 2014 15:48:17 +0000 (15:48 +0000)]
Merge "BUG-961 Fix Resource leak error from netty."

9 years agoCleanup: Removed unused inventory-config model. 50/8250/1
Tony Tkacik [Mon, 23 Jun 2014 15:43:07 +0000 (17:43 +0200)]
Cleanup: Removed unused inventory-config model.

Change-Id: I67240df394000107025a23d070784f8ed8d25f7f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "Fixed yangtools feature repo, bug with base and lang3 property version"
Ed Warnicke [Mon, 23 Jun 2014 14:53:39 +0000 (14:53 +0000)]
Merge "Fixed yangtools feature repo, bug with base and lang3 property version"

9 years agoFixed yangtools feature repo, bug with base and lang3 property version 98/7998/3
Mathieu Lemay [Fri, 13 Jun 2014 19:03:01 +0000 (15:03 -0400)]
Fixed yangtools feature repo, bug with base and lang3 property version

Change-Id: Ibd5095501b0f9fbe585ad1c6389e0385448f9321
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "Inventory manager: get rid of synchronized blocks"
Tony Tkacik [Mon, 23 Jun 2014 12:24:43 +0000 (12:24 +0000)]
Merge "Inventory manager: get rid of synchronized blocks"

9 years agoMerge "BUG-1138 - wrong value in OFPXMT_OFB_VLAN_VID in FLOW_MOD"
Ed Warnicke [Mon, 23 Jun 2014 12:21:26 +0000 (12:21 +0000)]
Merge "BUG-1138 - wrong value in OFPXMT_OFB_VLAN_VID in FLOW_MOD"

9 years agoMerge "Bug 1112: Updated toaster-it configuration to use InMemory Data Store."
Ed Warnicke [Mon, 23 Jun 2014 11:38:14 +0000 (11:38 +0000)]
Merge "Bug 1112: Updated toaster-it configuration to use InMemory Data Store."

9 years agoMerge "Bug 1144: Fixed mising DataChangeEvents for leaf listeners."
Ed Warnicke [Mon, 23 Jun 2014 11:37:23 +0000 (11:37 +0000)]
Merge "Bug 1144: Fixed mising DataChangeEvents for leaf listeners."

9 years agoBUG-1138 - wrong value in OFPXMT_OFB_VLAN_VID in FLOW_MOD 72/8172/3
Michal Rehak [Fri, 20 Jun 2014 11:52:25 +0000 (13:52 +0200)]
BUG-1138 - wrong value in OFPXMT_OFB_VLAN_VID in FLOW_MOD

- vlanPresent set to true if setting vlanId value
- checkstyle whitespace fix

Change-Id: I667fb667af8d5dcd1bc7216ce1fab9e78b6d2f51
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoMerge changes I0df1f18f,I4f635329
Ed Warnicke [Mon, 23 Jun 2014 11:24:02 +0000 (11:24 +0000)]
Merge changes I0df1f18f,I4f635329

* changes:
  Introduce ShardStrategy and related code
  Initial implementation of ListenerRegistration actor and all related messages

9 years agoMerge "Initial implementation of ShardTransaction and all the messages it handles"
Ed Warnicke [Mon, 23 Jun 2014 11:23:35 +0000 (11:23 +0000)]
Merge "Initial implementation of ShardTransaction and all the messages it handles"

9 years agoMerge "Implement basic ShardTransactionChain#CloseTransactionChain"
Ed Warnicke [Mon, 23 Jun 2014 11:23:06 +0000 (11:23 +0000)]
Merge "Implement basic ShardTransactionChain#CloseTransactionChain"

9 years agoMerge "Initial implementation of ShardTransactionChain"
Ed Warnicke [Mon, 23 Jun 2014 11:20:24 +0000 (11:20 +0000)]
Merge "Initial implementation of ShardTransactionChain"

9 years agoMerge "Add message to update the schema context of the InMemoryDOMDataStore"
Ed Warnicke [Mon, 23 Jun 2014 11:19:19 +0000 (11:19 +0000)]
Merge "Add message to update the schema context of the InMemoryDOMDataStore"

9 years agoMerge "Initial implementation of the Shard Actor"
Ed Warnicke [Mon, 23 Jun 2014 11:18:35 +0000 (11:18 +0000)]
Merge "Initial implementation of the Shard Actor"

9 years agoAPI Clarity: Documented Async Data Broker APIs. 46/8046/10
Devin Avery [Mon, 16 Jun 2014 16:52:14 +0000 (18:52 +0200)]
API Clarity: Documented Async Data Broker APIs.

Documented AsyncDataBroker APIs, which are
base abstract APIs from which Binding and DOM
data broker APIs are derived.

Introduced code-examples illustrating
transaction isollation and conflict detection.

Change-Id: I3c881b1fceb0b68c0cc28a1caa7780b9b6c2af3f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Devin Avery <devin.avery@brocade.com>
9 years agoBUG 484 - XmlReader improve readability 37/8037/2
Jozef Gloncak [Mon, 16 Jun 2014 11:43:38 +0000 (13:43 +0200)]
BUG 484 - XmlReader improve readability

- XmlReader - improve readibility of methods isSimple(Composite) node by
  extracting common logic to method skipCommentsAndWhitespace.

The change comes from patch set
https://git.opendaylight.org/gerrit/#/c/7337/9
which was originally commited by Tom Pantelis. In this commit is selected
only one change which doesn't relate with BUG 484

Change-Id: Icef852da20e8f624b4bc3d61e334d88f4766474d
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoHelium: improve contract with ListenerRegistration 43/6043/9
Robert Varga [Fri, 11 Apr 2014 08:04:02 +0000 (10:04 +0200)]
Helium: improve contract with ListenerRegistration

Change-Id: Ief4a6a5072824ada4cead4f465961e5a08053f8b
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoInventory manager: get rid of synchronized blocks 28/7828/6
Robert Varga [Mon, 9 Jun 2014 15:46:24 +0000 (17:46 +0200)]
Inventory manager: get rid of synchronized blocks

This patch reworks the inventory manager to operate on batches, such
that it does not block notification threads and lowers the pressure on
the datastore.

Change-Id: I1953ce22446853b99a201381ff4d7b64a3cfcee7
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBug 1112: Updated toaster-it configuration to use InMemory Data Store. 67/8167/4
Tony Tkacik [Fri, 20 Jun 2014 09:58:36 +0000 (11:58 +0200)]
Bug 1112: Updated toaster-it configuration to use InMemory Data Store.

As it turned out toaster-it used configuration with legacy data store
and not new one.

Updated controller config for toaster-it to have latest configuration
for MD-SAL.

controller.xml was restructured in such way, it is
easy to compare 01-mdsal.xml with controller.xml using diff
or meld tool.

Change-Id: I96de31c04e914bff0e99d155cb5aa1e4abe9807f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBug 1231 - fix of broken tests in sal-rest-connector 34/8234/1
Jozef Gloncak [Mon, 23 Jun 2014 08:18:59 +0000 (10:18 +0200)]
Bug 1231 - fix of broken tests in sal-rest-connector

Dummy values were added to places where null values as SchemaPath were
presented.

Change-Id: I1a7d109ec4b9dfa24ef77adfc7aa9ccff74482c1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBug 1245: Dropped Binding prefix from Binding Data APIs. 38/8338/8
Tony Tkacik [Wed, 25 Jun 2014 15:46:42 +0000 (17:46 +0200)]
Bug 1245: Dropped Binding prefix from Binding Data APIs.

Dropped Prefix Binding from Data API of Binding-Aware part,
to make it easier for incomming users to find them as entry
point to the system (eg. DataBroker).

Change-Id: I2636cc0b35369a5403e7e6094d1eafa03f1bf919
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBUG-961 Fix Resource leak error from netty. 79/8179/1
Maros Marsalek [Fri, 20 Jun 2014 15:00:50 +0000 (17:00 +0200)]
BUG-961 Fix Resource leak error from netty.

Release ByteBuf instance in ChannelInputStream.

Change-Id: I5fdf9751e05b6975778693f603e1f12b17bb4ee7
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-1200 changed help for agentpath && added comment describing functions.sh 77/8077/4
Michal Rehak [Fri, 20 Jun 2014 13:25:13 +0000 (15:25 +0200)]
BUG-1200 changed help for agentpath && added comment describing functions.sh

- added full path when sourcing functions.sh - now 'run.sh -help' will
  work other then current directory

Change-Id: I5988b86ed0eeab8f6251a694a5c40d48c505966d
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
9 years agoBUG-944 Fix nested union types in config subsystem module attributes 69/8169/2
Maros Marsalek [Fri, 20 Jun 2014 11:06:50 +0000 (13:06 +0200)]
BUG-944 Fix nested union types in config subsystem module attributes

Before this patch only unions of non-union types are supported.

Change-Id: If4aa0980246763b211a1c3fca0168ee84a1e75f9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Fix checkstyle errors in sal-compatibility"
Tony Tkacik [Fri, 20 Jun 2014 12:55:23 +0000 (12:55 +0000)]
Merge "Fix checkstyle errors in sal-compatibility"

9 years agoMerge "Bug 629: Make BindingDataBroker to be visible."
Ed Warnicke [Fri, 20 Jun 2014 12:48:14 +0000 (12:48 +0000)]
Merge "Bug 629: Make BindingDataBroker to be visible."

9 years agoMerge "Bug 629: Make SchemaService required for Data Brokers"
Ed Warnicke [Fri, 20 Jun 2014 12:48:01 +0000 (12:48 +0000)]
Merge "Bug 629: Make SchemaService required for Data Brokers"

9 years agoFix checkstyle errors in sal-compatibility 73/8173/1
Maros Marsalek [Fri, 20 Jun 2014 12:29:26 +0000 (14:29 +0200)]
Fix checkstyle errors in sal-compatibility

Change-Id: I696d3ade9b3b9d5705efa03f2a27dd914ae295ef
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Add copyright messages for java files"
Tony Tkacik [Fri, 20 Jun 2014 12:14:32 +0000 (12:14 +0000)]
Merge "Add copyright messages for java files"

9 years agoMerge "Introducing ShardManager"
Tony Tkacik [Fri, 20 Jun 2014 12:13:07 +0000 (12:13 +0000)]
Merge "Introducing ShardManager"

9 years agoBug 1212: Values of VLAN match fields were wrong. 66/8166/1
Hideyuki Tai [Fri, 20 Jun 2014 09:06:36 +0000 (05:06 -0400)]
Bug 1212: Values of VLAN match fields were wrong.

Values of match fields for VLAN tag were wrong when used AD-SAL OF
plugin and tried to create a flow entry which matched packets without
VLAN tags. V6Match class of AD-SAL OF plugin didn't have code for
handling packets without VLAN tags.

Changes:
 * Added code for handling packets without VLAN tags to V6Match class.
 * Added test cases related to the change of V6Match class.

Change-Id: Ic9c3a6c47c7e99d5273e48ec2ed8d0399289cddb
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
9 years agoMerge "Swagger UI for AD-SAL"
Alessandro Boch [Thu, 19 Jun 2014 19:57:10 +0000 (19:57 +0000)]
Merge "Swagger UI for AD-SAL"

9 years agoBug 629: Make BindingDataBroker to be visible. 16/7116/3
Tony Tkacik [Thu, 19 Jun 2014 14:38:21 +0000 (16:38 +0200)]
Bug 629: Make BindingDataBroker to be visible.

Inroduced support for injecting and retrieving
new BindingDataBroker via config-subsystem,
OSGI.

Note: This patch does not provide access to
BindingDataBroker is still not available via
Consumer/Provider context.

Change-Id: Iaa7e65aeeb873c38fded2fecb45e2f0dca1e7714
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>