controller.git
5 years agoBUG 3555: disable RC4 in mina-sshd 92/21792/2
Tomas Cere [Wed, 3 Jun 2015 14:57:31 +0000 (16:57 +0200)]
BUG 3555: disable RC4 in mina-sshd

There are various security problems with RC4, this removes
RC4 from the ciphers used in the netconf ssh server.

Change-Id: I8973daf2dfb3670f0c77ffc9099eab2cc2a6cd05
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoBug 3067: Enable blocking behaviour 36/21136/3
Tony Tkacik [Tue, 26 May 2015 14:07:15 +0000 (16:07 +0200)]
Bug 3067: Enable blocking behaviour

MD-SAL Binding components will block user threads
till schemas for used binding classes is loaded
or 5sec timeout expires.

Change-Id: Ib1280e0d68e7bda979ad0e944b1e7d199a243399
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBUG-3436 Fix UNION type leaves resolution in config subsystem 47/21547/2
Maros Marsalek [Mon, 1 Jun 2015 11:47:37 +0000 (13:47 +0200)]
BUG-3436 Fix UNION type leaves resolution in config subsystem

The descriptions for comoposite open types were not included in a reconstructed
open type, which affected resolution of subsequent composite attributes with
leaves of type union. Union leaves rely on description in order to find the
artificial JMX attribute in order to pass union value as string.

Change-Id: If6222e25840cb854e565ae476509d21ebc19ab3c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG 2970 : Handle SchemaValidationFailedException instead of IllegalArgumentException 95/21595/1
Moiz Raja [Tue, 2 Jun 2015 01:28:32 +0000 (18:28 -0700)]
BUG 2970 : Handle SchemaValidationFailedException instead of IllegalArgumentException

Switch to handling the more specific SchemaValidationFailedException.

Change-Id: Id2f07aae4f45bb11257906fcc157e679b7e34948
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 3067: Added support for blocking if schema is not available. 07/19607/5
Tony Tkacik [Tue, 5 May 2015 11:57:57 +0000 (13:57 +0200)]
BUG 3067: Added support for blocking if schema is not available.

Codecs are able to send specific exception, which describes
reason of failure for codec failing. If the reason is
missing schema (not yet loaded) we catch it and retry
serialization after schema context is upgraded.

User thread will be blocked maximally for 5 seconds
after that it will be unblocked.

Change-Id: I3494702eae644b495211a1a34c074e268c2f5f46
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoRemove PrimaryShardInfoFutureCache entry on UnreachableMember event 95/21495/2
Tom Pantelis [Sat, 30 May 2015 07:15:10 +0000 (03:15 -0400)]
Remove PrimaryShardInfoFutureCache entry on UnreachableMember event

The ShardManager removes the PrimaryShardInfoFutureCache entry when
leadership changes. We should do the same for UnreachableMember events.

Change-Id: I9582450f1c319e6967f43aacd1b0dd668e2654d6
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBug:3260-Recovery misses flows installed on single node 72/21372/3
Kamal Rameshan [Thu, 28 May 2015 20:54:48 +0000 (13:54 -0700)]
Bug:3260-Recovery misses flows installed on single node

There are 2 bugs which were enountered
1. When akka replays the journal, it replays it from the peristent journal's sequence number present at the time of snapshot success
2. The log entry on which a snapshot capture is triggered does not make it to that snapshot and gets removed from persistent journal as well.
So on recovery, that log entry/data is missing

To fix the first, the snapshotSeqNr() method of UnTypedPersistenActor is overridden, so that akka uses the cached last-sequence-number rather than using its own

To fix the second issue, the capture of snapshot for single node is done after applyState. This ensures that the persistent journal and snapshot are in sync

Also the in-memory journal was replaying all its messages and not honoring the fromSequenceNr, like akka does. So fixed it.

The tests needed to be fixed primarily due to the in-memory journal change.

A new test is added to test out the recovery of single node.

Change-Id: I779d1d6ce9880b19322d831ef5c8696b4c751e3d
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoAddress comments in https://git.opendaylight.org/gerrit/#/c/18392/ 99/21499/2
Tom Pantelis [Sat, 30 May 2015 08:30:34 +0000 (04:30 -0400)]
Address comments in https://git.opendaylight.org/gerrit/#/c/18392/

Patch https://git.opendaylight.org/gerrit/#/c/18392/ was merged with
some minor comments. This follow-up patch addresses them.

Change-Id: I1842a85f35021b598e1ded0b334453fd7751d9f7
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoFix archetype compilation 15/21515/2
Robert Varga [Sun, 31 May 2015 23:16:36 +0000 (01:16 +0200)]
Fix archetype compilation

Change-Id: I9217cb78881118c46c81f7c5d4f8c9bafe82d3fd
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBug 3427 - Websockets: Cannot create stream if path contains predicates 75/21375/4
Jan Hajnar [Thu, 28 May 2015 21:28:46 +0000 (23:28 +0200)]
Bug 3427 - Websockets: Cannot create stream if path contains predicates
or if target is a leaf

* fixed registration of path containing nodes with predicates
* added abillity to listen on leaves

Change-Id: I2e74aa6bbc50137187a5f7ece8de6ca288a1ebbf
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
5 years agoBUG 3340 : Improve logging 86/21286/2
Moiz Raja [Thu, 28 May 2015 02:22:40 +0000 (19:22 -0700)]
BUG 3340 : Improve logging

- In SimpleShardDataTreeCohort we log the contents of the tree at debug level. This
  makes it impossible to turn on debug for the package org.opendaylight.cluster.datastore
- At some point we seem to have lost the feature to include the chain number in the transaction
 identifier. I added that back in.

Change-Id: Ifd6cd4c9f5c49790dfb045d2800b5a8beef19b37
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 3104 - fixed XmlNormalizedNodeBodyReader 94/21394/1
Vaclav Demcak [Fri, 29 May 2015 09:53:14 +0000 (11:53 +0200)]
Bug 3104 - fixed XmlNormalizedNodeBodyReader

Note: add missing key is relevant only for a POST scenario.

Change-Id: Ibe97f83de4411c0fa5e28ced192f69aa65454027
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2970 : Create a PruningDataTreeModification 16/21016/7
Moiz Raja [Sat, 23 May 2015 00:22:02 +0000 (17:22 -0700)]
BUG 2970 : Create a PruningDataTreeModification

The PruningDataTreeModification automatically tries to prune the passed
in NormalizedNode if an IllegalArgumentException is thrown when doing
a write or a merge on the DataTreeModification.

*I know* that doing the pruning on IllegalArgumentException is flaky but
that is the best I can do unless we can change the implementation in yangtools
to throw a more specific exception when the data node does not map to a
the schema context

Change-Id: Iea0cea82eda8bd51c1f3f07b063404458798c348
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 3376: Add debug context for CDS transactions 26/21226/4
Tom Pantelis [Wed, 27 May 2015 06:03:20 +0000 (02:03 -0400)]
Bug 3376: Add debug context for CDS transactions

Added a new setting, transaction-context-debug-enabled, to the config yang
to enable/disable debug context that outputs the call site trace for
TransactionProxy instances for failed transactions.

Change-Id: I8b1a393871be4fa076054681c62c14fd68dc74b7
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoImprove BindingDOMRpcImplementationAdapter performance 18/21318/4
Robert Varga [Thu, 28 May 2015 11:20:30 +0000 (13:20 +0200)]
Improve BindingDOMRpcImplementationAdapter performance

BindingReflections return a non-shared QNameModule instance, which means
that we may end up using suboptimal lookups when comparing QNames.
Furthermore it is not the QNameModule which we need in the fastpath, but
rather QName of the input statement, hence create a cached reference of
that -- leading to minimal object allocation in the fast path.

Change-Id: I97ceb43d80c50d53d21cc66a31bfaae6ff0193e9
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-1135 Improve error reporting in config pusher 81/20781/5
Maros Marsalek [Wed, 20 May 2015 09:05:56 +0000 (11:05 +0200)]
BUG-1135 Improve error reporting in config pusher

Change-Id: I78e9550bf78cf5c5b3d929827f379e9009a4468f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoFix deadlock in AsyncSshHandlerWriter 02/21102/5
Tomas Cere [Mon, 25 May 2015 13:07:19 +0000 (15:07 +0200)]
Fix deadlock in AsyncSshHandlerWriter

Ssh window resize would call write twice, while a write pending was in progress
causing a deadlock because the underlying channelSession was already locked.

Change-Id: I3a1498084327f12b2010744e570644259532b975
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoBUG-3335 Disable keepalives in netconf testtool 44/21044/3
Maros Marsalek [Mon, 25 May 2015 10:37:34 +0000 (12:37 +0200)]
BUG-3335 Disable keepalives in netconf testtool

Change-Id: I607cd0b11555847a30ca57f339bb7d24fc79368e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoGet rid of netconf session preferences after connect 95/21295/2
Maros Marsalek [Wed, 27 May 2015 15:10:56 +0000 (17:10 +0200)]
Get rid of netconf session preferences after connect

Memory usage improvement for sal-netconf-connector: The preferences object was
kept inside the data broker during the entire lifetime of a netconf connector.
This is not necessary as it only needs 3 boolean values from it.

+ intern String representation of capabilities written into datastore.

Change-Id: I46363a3dc079350ccb1db4840b31fdd5342798d3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 3414 - exposed location header in CORS setings 32/21332/2
Jan Hajnar [Thu, 28 May 2015 14:22:36 +0000 (16:22 +0200)]
Bug 3414 - exposed location header in CORS setings

Change-Id: I74e5f363cb931b2b8a792447b5d5d2fa6e0aa5aa
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
5 years agoBug 3104 - fixed XmlNormalizedNodeBodyReader bug when data started at 05/21305/2
Jan Hajnar [Thu, 28 May 2015 09:41:35 +0000 (11:41 +0200)]
Bug 3104 - fixed XmlNormalizedNodeBodyReader bug when data started at
MapEntryNode

Change-Id: I7b19e514846ecfe7a9a29254b6fade8c876247e5
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
5 years agoBUG-2453 Enable nested enums in configuration 46/21146/3
Maros Marsalek [Tue, 26 May 2015 15:18:30 +0000 (17:18 +0200)]
BUG-2453 Enable nested enums in configuration

Nested enums could not be pushed due to an open type issue. Enums had a
composite open type, where the class name of the enum was stored. JMX was
not happy with this open type and expected a SimpleType.STRING.

After the enum is resolved, the open type is changed to SimpleType.

Change-Id: Ifce5bec70c8c3973f560260e93fadba2bd1119fa
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2820 - squashed changes from master. 88/20088/3
Jozef Gloncak [Tue, 17 Mar 2015 10:34:03 +0000 (11:34 +0100)]
Bug 2820 - squashed changes from master.

Squashed changes from master patches:
- Bug 2820 - problem to add second TLV with type 127.
- Bug 2820 - LLDP TLV support and testing
- BUG 2820 - LLDP refactor

into one commit were applied to stable/lithium because patch
 - BUG 2820 - LLDP refactor
was applied as first by mistake.

Change-Id: Ifa1cab17206e1be37022bc8b49f7990649cbd356
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoBUG-2976: Resolve clash between current and feature cfg pusher 56/20656/8
Maros Marsalek [Mon, 18 May 2015 14:11:57 +0000 (16:11 +0200)]
BUG-2976: Resolve clash between current and feature cfg pusher

Current config pusher now stores list of features present in karaf with the
config snapshot itself. Feature pusher now looks at the list and ignores
features listed in current config in the initial push.

A WARN log message is emitted for each ignored config file + feature.

Change-Id: I6e71e692e56d5219cf02cd704dd78215f4a7f5a2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoSet revision of inet-types in ietf-netconf-monitoring 49/21049/3
Maros Marsalek [Mon, 25 May 2015 13:21:36 +0000 (15:21 +0200)]
Set revision of inet-types in ietf-netconf-monitoring

If users introduce new version of inet types into ODL, netconf-monitoring model
fails to load proper class.

Change-Id: I392f160a2fb2cd9ddea3c331b5715fb0694ba391
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG 2820: Fix breakage from Import-Package 76/21276/1
Ed Warnicke [Thu, 28 May 2015 00:07:26 +0000 (17:07 -0700)]
BUG 2820: Fix breakage from Import-Package

Change-Id: I41401d4745c2126ccdc7ed9dffee3299aae9ed0c
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
5 years agoBug -3221 : Adding a new DataStoreUnavailableException for external applications. 59/21259/2
Harman Singh [Mon, 18 May 2015 21:51:46 +0000 (14:51 -0700)]
Bug -3221 : Adding a new DataStoreUnavailableException for external applications.
If cluster member, which is a leader of one or multiple shards becomes unavailable,
Shard re-election happens after certain time period and anyone tries to access datastore,
receives akka.timeout exception. No application can act upon such exception.

DataStoreUnavailableException will help external applications to retry if they see this exception.

Change-Id: Iceb10580bbe73ae91dc8abb4bc6a183cb4fad6f8
Signed-off-by: Harman Singh <harmasin@cisco.com>
(cherry picked from commit 6823ef1fd8f0a2f7ea39a2e85276a73e5de0bf72)

5 years agoInstantiate faster RpcServiceInvokers 23/21223/3
Robert Varga [Wed, 27 May 2015 15:00:07 +0000 (17:00 +0200)]
Instantiate faster RpcServiceInvokers

Now that we have the SchemaPath->Method mapping available and
RpcServiceInvoker can instantiate efficient invokers based on the
QName->Method mapping, switch over to them by creating an intermediate
map.

Change-Id: If5e17924d9deb494045965578cfcec6d321d04d2
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoAdd missing capabilities declaration to toaster test configuration. 03/20803/3
Tony Tkacik [Wed, 20 May 2015 12:39:29 +0000 (14:39 +0200)]
Add missing capabilities declaration to toaster test configuration.

Change-Id: I7055a36adce5e21a80a025f4cf55bdc9224b6879
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBug 2358 - Resources for tests nn to json 71/19771/10
ary [Thu, 7 May 2015 07:56:59 +0000 (09:56 +0200)]
Bug 2358 - Resources for tests nn to json

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl
but we test codec on input data and also with presentation of Rest path.

* fix and add yang files for tests
* fix json and xml files
* rename base folder of csns-to-json to nn-to-json

Change-Id: Id1c88f069d259536d34438d7b68666dd3010adc4
Signed-off-by: Jakub Toth <jatoth@cisco.com>
5 years agoBug 3017 - Error messages and logs missing for this or other RPC failures 12/19712/10
Vaclav Demcak [Wed, 6 May 2015 13:10:14 +0000 (15:10 +0200)]
Bug 3017 - Error messages and logs missing for this or other RPC failures

Note: Restconf doesn't contain logs for more functionality (not only RPC)
so this patch adds better logging for Restconf (BrokerFacade and RestconfImpl).
Administrators are not able to pair user's reports and karaf log without better
logging information and it would help for better problem identify (e.g. bug 3080).

* BrokerFacade - add Logging for lev info for all extra state
* RestconfImpl - add Logging for lev warn for unexpected error state
               - add Logging for lev debug for another extra state

Change-Id: I452dddd4fb9d75a7754be0bc1d92518dcb1eb786
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG-3335 Add keepalive mechanism to netconf-connector 88/20988/3
Maros Marsalek [Fri, 22 May 2015 14:40:58 +0000 (16:40 +0200)]
BUG-3335 Add keepalive mechanism to netconf-connector

Invoke harmless RPC (get-config with empty filter) with a fixed delay to check
whether the netconf session is still active. The RPC is postponed if any other
RPC is invoked by a user/application.

This also prevents the remote device to close session due to being idle.

Change-Id: I013d2641c38d4c8adb5d3198795e337b91c4f95d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2150: Feature wrappers now log parse errors better. 00/21100/2
Maros Marsalek [Mon, 25 May 2015 14:32:13 +0000 (16:32 +0200)]
Bug 2150: Feature wrappers now log parse errors better.

getFeatureConfigSnapshotHolders() logging is now similar
to what XmlDirectoryPersister.fromXmlSnapshot() does.

Also, files not ending with .xml (and not available files)
are filtered out as they do not hold configuration snapshots.

Warn level for config load failure.

Change-Id: I7c9d472bbe0ad031aaf7cc8dead1fd1e41d93306
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoRework BindingDOMRpcImplementationAdapter instantiation 22/21222/2
Robert Varga [Wed, 27 May 2015 11:45:07 +0000 (13:45 +0200)]
Rework BindingDOMRpcImplementationAdapter instantiation

Move the SchemaPath/Method map closer to where we instantiate invokers.
This has the benefit of speeding up registration code very slightly,
but more importantly it allows instantiating more efficient invokers, as
we have the SchemaPath->Method map readily available.

Change-Id: Iefc0faadcfd7df6c40240ce1f78c7b734f06c618
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBug 3104 - Sal Rest Connector: Data already exists for path when adding 30/19530/14
Jan Hajnar [Mon, 4 May 2015 14:57:49 +0000 (16:57 +0200)]
Bug 3104 - Sal Rest Connector: Data already exists for path when adding
new item to list in augmentation

* changed XmlNormalizedNodeBodyReader and JsonNormalizedNodeBodyReader
to return YangInstanceIdentifier pointing to root of payload data.
* changed BrokerFacade datastore functions for PUT and POST to use
returned path from reader without modifications
* modified rest connector tests according to new behavior and added
tests for POST when payload is from augment/choice

Change-Id: Iac6a9853ea4c4529d2f484c464bd27123f4fafa2
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
5 years agoBUG 2970 : Create a utility class which can prune a normalized node based on the... 74/20974/5
Moiz Raja [Fri, 22 May 2015 11:03:00 +0000 (04:03 -0700)]
BUG 2970 : Create a utility class which can prune a normalized node based on the schema context

This will be used when a data modification operation fails because of a missing schema
failure.

Change-Id: I6e07763051cc2181c0c786a0762cbf6a3c5c4eed
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2820 - LLDP refactor. 74/21174/3
Jozef Gloncak [Tue, 17 Mar 2015 12:35:51 +0000 (13:35 +0100)]
BUG 2820 - LLDP refactor.

LLDP class field changed from tlvList to mandatoryTLVs, optionalTLVs, customTLVs
Added new create custom TLV value in order to hold security hint for LLDP topology discovery.
Fixed guava bundle import
Fixed apache-lang3 bundle import

Change-Id: I5d0c6b9a9e29213d3f25aa99ff7edd5b30e6c7a8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit 26dfd63f953982f661e4e72f306c6a6b8e02cfd4)
(cherry picked from commit 2d82dd8cc1845228818c121070548d4784cc65b7)

5 years agoBug 3194: Dynamically update PrimaryShardInfo cache when leader changes 71/20571/9
Tom Pantelis [Thu, 14 May 2015 16:40:48 +0000 (12:40 -0400)]
Bug 3194: Dynamically update PrimaryShardInfo cache when leader changes

Added a PrimaryShardInfoFutureCache class which maintains the cache of
PrimaryShardInfo Future instances per shard. This code was moved from the ActorContext.

The PrimaryShardInfoFutureCache instance is created by the
DistributedDataStore and passed to the ShardManager, as well as to the
ActorContext. The ActorContext uses the cache as before.

On ShardLeaderChanged message, if the leaderId has changed, the
ShardManager calls remove on the PrimaryShardInfoFutureCache to
invalidate the entry for the shard name.

As part of this patch some refactoring was done which removed ShardInfoListeners.

There are a few miscellaneous changes in this patch as well,
- Create the appropriate type of transaction on the datatree for local transactions
- Tracking only read-only transactions which phantom references

Change-Id: I4c7a3845e311e5130d80f22f7cfb3c82c5ad731d
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoFix intermittent ConfigPersisterTest failure 62/20662/3
Tom Pantelis [Fri, 15 May 2015 17:21:13 +0000 (13:21 -0400)]
Fix intermittent ConfigPersisterTest failure

testSuccessConflictingVersionException fails intermittently on Jenkins
with different errors. I think the problem is that it sets up the
"workingService" which the ConfigPusher is accessing createService on
another thread. In reading Mockito FAQs, you may get strange intermittent
results with multi-threading wrt to stubbing. Mocks can be accessed from
multiple threads but it's recommended that you setup all the stubbed
methods ahead of time. So I changed
testSuccessConflictingVersionException to do so.

After the fix, I ran the ConfigPersisterTest 550 times w/o failure.

Change-Id: Ia22936cfad82416e317935bd40b0eb3ccbdb232c
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoTweak notification queue backoff 46/21046/4
Robert Varga [Mon, 25 May 2015 11:57:47 +0000 (13:57 +0200)]
Tweak notification queue backoff

Local testing seems to indicate that the LMAX dispatch gives better
throughput with 16 switches when configured to go blocking.

Change-Id: Id273cccc2cbb19ae91ca799ccabca65d1cfd93c4
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBug 3234: Do not notify empty Rpc implementation change. 08/20708/2
Tony Tkacik [Tue, 19 May 2015 09:48:49 +0000 (11:48 +0200)]
Bug 3234: Do not notify empty Rpc implementation change.

DOMRpcBroker was sending notifications with empty
set of RPC added or removed.

This is possible if registration for RPC already exists
and another one was registered.

Change-Id: Iab92d6f1e5c76a050dc00dee802e1698ca26eccc
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBUG 3121 - destroy topic implementation 35/20235/6
Marian Adamjak [Tue, 12 May 2015 07:15:21 +0000 (09:15 +0200)]
BUG 3121 - destroy topic implementation
   - implementing destroyTopic rpc in EventSourceTopology
   - add rpc dis-join-topic in event-sourec.yang and implement it
   - fixed bugs identified during test with real device
   - revision of code and cleaning up
   - rebased

Change-Id: I0f43ef2ca1f54db5a08c379792a59c3894a77767
Signed-off-by: Marian Adamjak <madamjak@cisco.com>
5 years agoMigrade junit.frawork.Assert 70/21070/1
Robert Varga [Mon, 25 May 2015 15:33:31 +0000 (17:33 +0200)]
Migrade junit.frawork.Assert

The new place s org.junit.Assert, migrate imports to squash eclipse
warnings.

Change-Id: I6900b400b32c7b3fd840497fec99159d6ec779db
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2453 (De)Serialize enum values as defined in yang 28/20028/8
Maros Marsalek [Mon, 11 May 2015 14:53:19 +0000 (16:53 +0200)]
BUG-2453 (De)Serialize enum values as defined in yang

Netconf endpoint for config subsystem did not (de)serialize enum values properly
It assumed the enum constants are identical in yang and in generated binding

Change-Id: If46c770a49653348201cd5d5c9303b5207048252
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoFix maven-archetype-plugin not pulling its dependencies 47/20947/3
Robert Varga [Fri, 22 May 2015 10:04:52 +0000 (12:04 +0200)]
Fix maven-archetype-plugin not pulling its dependencies

commons-lang is needed to run, but it is not pulled automatically. Fix
that.

Change-Id: I95dd2d527eb47d55597bb3d844867f0ca0c50b3f
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoTake advantage of YangInstanceIdentifier methods 02/21002/4
Robert Varga [Fri, 22 May 2015 16:14:47 +0000 (18:14 +0200)]
Take advantage of YangInstanceIdentifier methods

YangInstanceIdentifier provides new, fast methods to acquire parent,
check if it empty and size of path arguments. Take advantage of them.

Change-Id: I527ff8cefb2799cb188ffe294c69e3b81a0d6909
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoIntroduced Lazy DOM Rpc Result future. 02/20902/4
Tony Tkacik [Thu, 21 May 2015 15:08:47 +0000 (17:08 +0200)]
Introduced Lazy DOM Rpc Result future.

Introduced LazyDOMRpcResultFuture which is used
when Binding Aware app invokes Binding Aware Rpc implementation.

  - This future encapsulates original future which
    is deencapsulated without any processing once returned
    back to Binding RPC implementation.

Change-Id: I4b65bdc884925a128db0ec6697ba84f37527593f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBug 3216 - Restconf GET operations functionality are not supported yet 40/20340/3
Vaclav Demcak [Tue, 12 May 2015 08:56:04 +0000 (10:56 +0200)]
Bug 3216 - Restconf GET operations functionality are not supported yet

* missing list of all operations for all modules or for some module

Change-Id: I937890b83fe2bf3198278123373c5d3bad0aa927
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG-3301 Extract additional header properly on each OS 93/20893/2
Maros Marsalek [Thu, 21 May 2015 13:21:10 +0000 (15:21 +0200)]
BUG-3301 Extract additional header properly on each OS

On Windows, the additional header in hello netconf message was no fully
extracted and it left \n byte in front on netconf xml hello message. This
is not allowed as long as the <?xml ... > declaration is present.

Change-Id: I611a5c689e86fb45065e6a9cd3b14cd5718af54f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2961 Disable auth and idle timeout for netconf connector 32/20732/5
Maros Marsalek [Tue, 19 May 2015 14:06:15 +0000 (16:06 +0200)]
BUG-2961 Disable auth and idle timeout for netconf connector

The timeouts appeared in the mina SSHD lib in version 14 and are not suitable
for netconf connector.

Change-Id: I05f0feb58ef30d12a29eefa53ec5ccf300cb3123
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoReduce SchemaContext updates on shutdown 31/20931/2
Tom Pantelis [Mon, 18 May 2015 00:33:53 +0000 (20:33 -0400)]
Reduce SchemaContext updates on shutdown

The GlobalBundleScanningSchemaServiceImpl sends out a ton (hundreds) of
SchemaContext updates on shutdown. This because the removedBundle method
calls tryToUpdateSchemaContext even for bundles that weren't tracked, ie
bundles w/o yang URLs. So I added a check`for # URLs > 0.

Change-Id: I203047f04ba5761c1927102b3cb0f2e309b6bf77
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoFixed Import-Package of clustering. 51/20451/6
Hideyuki Tai [Thu, 14 May 2015 16:19:00 +0000 (09:19 -0700)]
Fixed Import-Package of clustering.

This patch changed sun.reflect into optional import package, since sun.*
packages are not guaranteed to work on all Java-compatible platforms.
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html

Requiring the sun.reflect caused failures of SingleFeatureTest of NIC
project. To pass the test, the sun.reflect package needed to be optional
import package.

Change-Id: I660da18f8ec99b98892dca61c8a9a0cc4f1ec3ae
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
5 years agoUse TransactionCommitOperationTimeout when commiting a Local transaction 16/20916/1
Moiz Raja [Thu, 21 May 2015 18:20:55 +0000 (11:20 -0700)]
Use TransactionCommitOperationTimeout when commiting a Local transaction

This is to make this similar to how we do a remote transaction. The transaction
commit timeout is much larger than the operation timeout and is more appropriate
for committing because the latencies involved in committing are much larger as
committing involves replication which could sometimes be pretty slow.

Change-Id: Ie76e05bf875b4ea5eee9618519d7167f50671c8f
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 2970: Fix GlobalBundleScanningSchemaServiceImpl to get RESOLVED bundles correctly 95/20895/3
Tom Pantelis [Sun, 17 May 2015 14:49:00 +0000 (10:49 -0400)]
Bug 2970: Fix GlobalBundleScanningSchemaServiceImpl to get RESOLVED bundles correctly

The GlobalBundleScanningSchemaServiceImpl uses a BundleTracker to get
all RESOLVED bundles. When BundleTracker#open() is called
on start(), the BundleTracker will notify addingBundles of all current
bundles that pass the state mask. The OSGi container must resolve all
bundles before activating on startup. So after open() is called we
should have all the current bundles that have yang models and a complete
SchemaContext on startup based on the installed bundles from he last run.
However I was seeing some bundles notified during open() but others notified
later. This why CDS and other components may not see a complete
SchemaContext on startup.

The problem is that GlobalBundleScanningSchemaServiceImpl is passing the
wrong state mask constants. It's referencing constants defined in
BundleEvent but the BundleTracker checks bundle.getState() which
corresponds to constants defined in Bundle. The 2 have slightly
different constants and the values differ. When I change it to use
Bundle constants, it works as expected, ie all current bundles are
notified during open() and we have a complete SchemaContext after start().
I really don't see how this worked before at all using the wrong constants.

I also noticed that start() is being called twice, once in
GlobalBundleScanningSchemaServiceImpl#createInstance and then also in
the Activator after it calls createInstance. So 2 instances of
BundleTracker were being created resulting in double the notifications.
I removed the call to start() in the Activator.

Change-Id: I8c8330f75dd1a779af186688aae4cfaee89bd43b
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBug 3206: CDS - issues with direct commit 71/20271/9
Tom Pantelis [Wed, 13 May 2015 11:44:01 +0000 (07:44 -0400)]
Bug 3206: CDS - issues with direct commit

Modified RaftActor#persistData to send the ApplyState message instead of
calling applyState directly in case the Shard tries to persist another
entry during the persist callback.

Modified Shard to use the correct sneder to send the
CommitTransactionReply message.

The third fix is to ensure direct commits in a chain aren't committed
before previous coordinated commits. In the ShardCommitCoordinator, I
changed it to enqueue all CohortEntries when they are readied so they
are processed in that order.

I also included the unit test scenario that caused the issues to occur.

Change-Id: I65ffcbbac37d6be28c4e1c2dc17d3b0ca21847dc
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoMake sure invokeOperation is set once 53/20753/4
Robert Varga [Tue, 19 May 2015 19:16:32 +0000 (21:16 +0200)]
Make sure invokeOperation is set once

This clarifies how it is initialized and make it final to ensure it is
initialized exactly once.

Change-Id: Ib05b58dec492870257da2a8653b5b6b010891312
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoAllow DOMNotificationRouter to be tuneable 35/20835/1
Robert Varga [Wed, 20 May 2015 15:53:21 +0000 (17:53 +0200)]
Allow DOMNotificationRouter to be tuneable

The details of how deep is the queue and how the backoff strategy is
applied should be tuneable. Model them and provide the hooks.

Change-Id: I6eda6bebc2cf506d627e09d3949a73e97ed866e4
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFix CDS serialization failures due to YangInstanceIdentifier change 56/20756/1
Tom Pantelis [Sat, 16 May 2015 19:13:41 +0000 (15:13 -0400)]
Fix CDS serialization failures due to YangInstanceIdentifier change

YangInstanceIdentifier was recently made an abstract class with 2
implementations which broke CDS serialization as it was looking for
an exact match for the YangInstanceIdentifier class.

Change-Id: Iba94dda9584f65f5c8d76a1514d3f9f09d2f0483
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoValue for transactions moved to yang module 12/20512/3
Marian Dubai [Fri, 15 May 2015 13:53:57 +0000 (15:53 +0200)]
Value for transactions moved to yang module

Timeout value for blocking operations within
transactions moved from AbstractWriteTx to yang module
odl-sal-netconf-connector-cfg.yang

Change-Id: I4414a613445c914b0b3262705ca5ceae058b51d5
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoBUG-2976 Generate hash/equals for config generated DTOs 97/20497/2
Maros Marsalek [Fri, 15 May 2015 09:28:27 +0000 (11:28 +0200)]
BUG-2976 Generate hash/equals for config generated DTOs

The DTOs generated by config subsystem did not have hashCode and equals methods
This caused the canReuse instance to return false even if the old module could
be reused.

Change-Id: I11392c2947f570a05d1a5b84fdaaee9e6b89a717
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2358 - Resources for tests json to nn 19/19519/6
ary [Wed, 29 Apr 2015 09:45:31 +0000 (11:45 +0200)]
Bug 2358 - Resources for tests json to nn

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but we test codec on input data and also with presentation of Rest path.

* fix and add yang files for tests
* fix json files
* rename base folder of json-to-cnsn to json-to-nn

Change-Id: Id0a23e655c3ddaaeb60f8652d57a7a5d1458063a
Signed-off-by: ary <jatoth@cisco.com>
5 years agoBug 2358 - Changed modifier of method in AbstractBodyReaderTest to protected 18/19518/5
ary [Wed, 29 Apr 2015 10:00:31 +0000 (12:00 +0200)]
Bug 2358 - Changed modifier of method in AbstractBodyReaderTest to protected

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but we test codec on input data and also with presentation of Rest path.

* changed modifier of method getMediaType() to protected
* fix tests with method getMediaType()
* remove additional assertions

Change-Id: I211c2dc43690b663cada31deb3942e10fcc95366
Signed-off-by: ary <jatoth@cisco.com>
5 years agoBUG 3249 : Operation Limiter not release on completion of operation 80/20680/3
Moiz Raja [Mon, 18 May 2015 21:12:08 +0000 (14:12 -0700)]
BUG 3249 : Operation Limiter not release on completion of operation

The OperationLimiter uses up one permit and per operation done on a
transaction. When that operation is complete the permit must be
released. For Local transactions this was not happening. Due to this
when a local transaction has more operations than the maximum outstanding
operations we would block for the operation timeout period (5 seconds
by default) this can have all sorts of adverse side effects on
transactions.

This patch ensures that for local transactions those permits are freed
up when the operation is complete.

Change-Id: Id8ba99c6ea081c7e37da0b517860dca818a91218
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoFix intermittent RaftActorTest failures 13/20613/2
Tom Pantelis [Fri, 15 May 2015 01:28:14 +0000 (21:28 -0400)]
Fix intermittent RaftActorTest failures

I've seen the following test failure on jenkins several times:

  RaftActorTest.testRealSnapshotWhenReplicatedToAllIndexNotInReplicatedLog:838
expected:<Leader> but was:<Candidate>

This is a result of the short-circuiting of the election timeout scheduling
when there are no peers so it goes from from Follower -> Candidate -> Leader
quickly. The test artificially sets the behavior to Leader but the immediate
ElectionTimeout messages may cause it to switch back to Candidate and
cause assertion failures before the test completes. This didn't happen
before b/c it sets the heartbeat interval really high. To alleviate the
failures, I set a peer to elide the short-circuiting.

Change-Id: I2c086f214baefb826beb898dfe4b11b659cd1eaa
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBug 3258 : Changed the order of condition for OrderedMap and MapNode, 68/20668/1
Harman Singh [Mon, 18 May 2015 18:10:23 +0000 (11:10 -0700)]
Bug 3258 : Changed the order of condition for OrderedMap and MapNode,
same for OrderedLeafSet and LeafSet
Added a test to validate it works for OrderedMap

Change-Id: Ifb0375d47668fcc36d824fb33a8b4684e89dccc8
Signed-off-by: Harman Singh <harmasin@cisco.com>
5 years agoSet weak keys for binding mountpoint cache 95/20495/2
Maros Marsalek [Fri, 15 May 2015 09:28:19 +0000 (11:28 +0200)]
Set weak keys for binding mountpoint cache

Change-Id: Ie3995beb7f2ffe51c882bde411048b2c59780184
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoRename stress-client classifier in netconf-testtool 41/20641/2
Maros Marsalek [Mon, 18 May 2015 11:41:17 +0000 (13:41 +0200)]
Rename stress-client classifier in netconf-testtool

2 shaded jars with same classifier overwrite each other in nexus

Change-Id: If08d83ccda4c716ef12818fd8eb0da2ae37706b9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoDisable failing config persister test 20/20520/3
Maros Marsalek [Fri, 15 May 2015 14:36:03 +0000 (16:36 +0200)]
Disable failing config persister test

The test needs to be redesigned. BundleContext and Concurrency need to be
removed from the test to make it more stable and readable.

Looks like the failure reported by mockito is caused by "wrongly written
multi-threaded tests".

Change-Id: I85a04194573c500ce9c4c4a8cfc4960e66203545
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 3197: Netconf client not reconnecting due address unresolved 15/20415/4
Marian Dubai [Thu, 14 May 2015 16:55:03 +0000 (18:55 +0200)]
Bug 3197: Netconf client not reconnecting due address unresolved

Netconf client not reconnecting, when failed 1st time due
address unresolved. InetSocketAddress remains in state unresolved,
after connection failed first time due address unresolved.
Now recreating InetSocketAddress by each reconnect,
so address is checked by each reconnect attempt.

Change-Id: I29ef130d7bf3f65023a611cee51245a6ae6f9a03
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoBUG 3232 : Fix intermittent failure in ShardTest 82/20582/2
Moiz Raja [Sat, 16 May 2015 00:44:11 +0000 (17:44 -0700)]
BUG 3232 : Fix intermittent failure in ShardTest

Change-Id: Ia556fe4833614080d891dd1edcfa8878152bc595
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMake stable/lithium the default branch 95/20195/4
Moiz Raja [Tue, 12 May 2015 23:47:09 +0000 (16:47 -0700)]
Make stable/lithium the default branch

Note : this should not be cherry picked to master

Change-Id: Idda3ce01773772c67e10b0d5c898d88c1e644834
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 3125 : Set Rate Limit just before acquiring a permit to avoid contention 63/20063/11
Moiz Raja [Mon, 11 May 2015 22:43:43 +0000 (15:43 -0700)]
BUG 3125 : Set Rate Limit just before acquiring a permit to avoid contention

During perfomance test performance is hampered by the rate limiting code. To
avoid the penalty of possible contention when setting the rate limit in a
separate thread from the one acquiring a rate permit this patch calculates the
new rate limit and sets it on the rate limiter on the same thread which
acquires the rate limit.

Moving the setting of the rate limit into the same thread which does the
acquiring of the permit did not have any discernable effect on performance so
I continued playing around and found that simply calculating the rate limit
can cause issues with performance. This happens because the Coda Hale metrics
Timer that we use to help calculate the rate limit is also synchronized
internally with a read write lock and that causes contention.

To fix the situation with the rate limit calculation I do not calculate the rate
limit everytime someone tries to acquire a permit but only after acquiring about 1/2 of
the last calculated rate limit.

To make it easier to understand/test the rate limiting code I have slightly refactored
the code. All the transaction rate limiting code is now in TransactionRateLimiter.

After making these changes I was able to get the same performance in the dsBenchmark
test as you would get from not using a rate limiter at all.

Change-Id: Ia7639ac3acdc08140fbf5eef03120f857dc44994
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoCDS: make sure to assert non-null Exception in test 47/19447/10
Robert Varga [Fri, 1 May 2015 19:57:32 +0000 (21:57 +0200)]
CDS: make sure to assert non-null Exception in test

The exception can be potentially null, make sure we fail the test if it
is.

Change-Id: I6b987e2962abfaa8afa570791e3500fa4916e5c2
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agohotfix Bug 3226 - unable to configure flows 22/20522/2
Vaclav Demcak [Fri, 15 May 2015 14:24:37 +0000 (16:24 +0200)]
hotfix Bug 3226 - unable to configure flows

* NormalizedNodeContainer has NodeIdentifierWithPredicates which
has to contain the map of all node keys
* (new codecs [xml,json] don't populate Attributes)

Change-Id: I5befc6d8ad5a63a04c11ad9102610be9508df672
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBug 3020: Add version to AppendEntries and AppendEntriesReply 65/19165/4
Tom Pantelis [Fri, 24 Apr 2015 15:17:27 +0000 (11:17 -0400)]
Bug 3020: Add version to AppendEntries and AppendEntriesReply

To handle backwards compatibility, a leader needs to know the version of
its followers wrt to the derived RaftActor's payload data. This will
enable
the derived RaftActor to translate its payload data to an older version.
So I added a version field to AppendEntriesReply which the leader stores
in the FollowerLogInformation.

In addition, a follower needs to know the version of its leader so we
can handle backwards compatibility wrt to transactions since we no
longer send the CreateTransaction message to the leader (currently only
for write-only). This patch adds a version field to AppendEntries - a
subsequent patch will utilize it.

Change-Id: I41632024a270206153e7c5d363ee1c79800e4200
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoCDS: Implement front-end support for local transactions 61/20461/4
Robert Varga [Fri, 24 Apr 2015 11:33:24 +0000 (13:33 +0200)]
CDS: Implement front-end support for local transactions

Implemented support on the TransactionProxy front-end for optimizations
where the Shard is local to the controller instance. In this mode, the
Shard's DataTree obtained from the FindPrimaryShard message is used to
prepare the modifications completely on the front-end. On ready, the
DataTreeModification instance is passed to the Shard via
the ReadyLocalTransaction message. The Shard then does a direct commit,
eliding the 3PC from the front-end (it's a no-op as it is for remote
write-only txns).

TransactionContext instances are now obtained via an
AbstractTransactionContextFactory passed to TransactionProxy of which
there are 2 kinds: one for single, unchained txns and one for chained
tnxs. Each creates a different DOM transaction instance to handle
preperation of modifications. The DOM transacton is wrapped in a
LocalTransactionContext which the TransactionProxy interfaces with.

Change-Id: I0322b586f394e4b6c7793b8287ac804b41964378
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBug-2704:Clustering: Fix akka-raft TestDriver logging to run with slf4j 11/20311/3
Kamal Rameshan [Thu, 14 May 2015 00:19:07 +0000 (17:19 -0700)]
Bug-2704:Clustering: Fix akka-raft TestDriver logging to run with slf4j

Change-Id: I5634914b086d87557afb9a851c47958744301253
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoAdd AuthHandler to stresstool 16/19816/3
Tomas Cere [Tue, 5 May 2015 09:21:18 +0000 (11:21 +0200)]
Add AuthHandler to stresstool

Stop bundling BouncyCastle into strestool uber-jar,
JCE certificate gets wiped this way and Oracle JDK refuses to use it.
Instead export them into target/lib dir and setup stresstool jar classpath to point to this directory.

Change-Id: I3c7ab9ea0f5faba2f02f4e0cfa21adda6bce2e4e
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoBug 2981 - POST mismatching IDs data vs URI possibility 81/19681/6
Vaclav Demcak [Fri, 24 Apr 2015 13:14:27 +0000 (15:14 +0200)]
Bug 2981 - POST mismatching IDs data vs URI possibility

fix forgotten validation for check IDs from data and Uri

Change-Id: I465a3550399c5d2d4fcb546b608a9b47e3d97e63
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 3030 - reconnect netconf event source 11/20011/3
Marian Adamjak [Wed, 6 May 2015 10:46:05 +0000 (12:46 +0200)]
BUG 3030 - reconnect netconf event source
   - replay notification
   - publish notification about connection status

(cherry picked from commit 4c147b35d298b281afccb53c7fb8b83b1b96ddfc)
Change-Id: Ia6ead39a2e1a81135dcd86163fb7adb40a3d7d5c
Signed-off-by: Marian Adamjak <madamjak@cisco.com>
5 years agoBUG 3213: Add missing netconf-tcp dependency to mdsal-netconf-connector 58/20358/2
Tomas Cere [Thu, 14 May 2015 10:32:02 +0000 (12:32 +0200)]
BUG 3213: Add missing netconf-tcp dependency to mdsal-netconf-connector

Change-Id: I6d9839e24e994d28f0059c7dfbd2a9e3ab4b4c05
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoBUG 3200 : Serialize a child node even when it is UNMODIFIED 10/20310/1
Moiz Raja [Thu, 14 May 2015 00:11:39 +0000 (17:11 -0700)]
BUG 3200 : Serialize a child node even when it is UNMODIFIED

Change-Id: If1220cd2a84d770ca02bca6a5f070032188b5e21
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoIntroduce DOMNotificationRejectedException 98/20198/2
Robert Varga [Tue, 12 May 2015 23:54:29 +0000 (01:54 +0200)]
Introduce DOMNotificationRejectedException

DOMNotificationPublishService.REJECTED wraps a throwable, which may
cause problems with code which attempts to unwind it, as frameworks tend
to propagate Throwables rather than wrapping them.

Change-Id: I77d7ceeef8213425636dab92f6994fcd3f1443e9
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFix newly-broken javadocs 97/20197/2
Robert Varga [Tue, 12 May 2015 23:54:07 +0000 (01:54 +0200)]
Fix newly-broken javadocs

Self-closing elements are not allowed.

Change-Id: I9d9c655d04c420b575e6ace51aaf2b0af931ecef
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG 3156 : Recreating CDS should not fail 57/19957/6
Moiz Raja [Thu, 7 May 2015 01:43:31 +0000 (18:43 -0700)]
BUG 3156 : Recreating CDS should not fail

When CDS is recreated it can fail because we try to
create actors on a datastore that is already terminated.

To address this issue I have enhanced DistributedDataStoreFactory
as follows,

- Simplified the actor system creation code by synchronizing
  all static methods. Since these methods are anyway not used in
  any fast paths - it is a fair enough solution.
- Added another static field in DistributedDataStoreFactory to
  track the createdInstances. This is so that we can properly
  cleanup the actor system as instances of the data store are destroyed.
- The actor system is now shutdown when there are no datastrore instances.
- Removed actor system shutdown from ActorContext to ensure that we
  use the symmetric method destroyInstance

Now that we do not shutdown actor system till both the data stores
are destroyed it may so happen that we may have a situation where we are
trying to create an actor on the old actor system with an already used name
like shardmnanager-config or shardmanager-operational. To avoid this
I have added a loop when creating shardmanager which catches the thrown
exception and retries 100 times after waiting for 100 milliseconds. This
is to give some time for the actor to properly die.

Change-Id: I3c8b2b3b21a1519610bf2ed5e1af8be93f3120ce
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 3161: Create new UpdateElectionTerm class 69/19969/3
Tom Pantelis [Fri, 8 May 2015 21:18:36 +0000 (17:18 -0400)]
Bug 3161: Create new UpdateElectionTerm class

Deprecated inner class RaftActor.UpdateElectionTerm and created a new
stand-alone UpdateElectionTerm class with serialVersionUID set.

Change-Id: Idf9a67656f0103e4f8e668e0812a80687423bfdd
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBug 3161: Remove serialVersionUID to maintain backwards compatibility 67/19967/2
Tom Pantelis [Fri, 8 May 2015 20:32:41 +0000 (16:32 -0400)]
Bug 3161: Remove serialVersionUID to maintain backwards compatibility

The serialVersionUID field was added earlier in Lithium for
RaftActor.DeleteEntries and RaftActor.UpdateElectionTerm however it
breaks backwards compatibility. We need to remove serialVersionUID.

DeleteEntries has already been deprecated for a new class that has
serialVersionUID set and is not an inner class. I will do that same for
UpdateElectionTerm in another patch.

Change-Id: I8180de5865d89d3fea190e48ebeb825743af959d
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBUG-3183: Extend notification publisher API 91/20091/8
Michal Rehak [Tue, 12 May 2015 08:36:26 +0000 (10:36 +0200)]
BUG-3183: Extend notification publisher API

 - offer methods of notificationPublishService now return ListenableFuture
 - added exception for notification rejected outcome

Change-Id: Iff17e1edd754d49e6c53f97e357c34f5eac6a8ef
Signed-off-by: Michal Rehak <mirehak@cisco.com>
5 years agoAdd missing copyright text 88/19788/3
Thanh Ha [Mon, 19 Jan 2015 02:08:29 +0000 (21:08 -0500)]
Add missing copyright text

Change-Id: Icff91333434dcdcd226327c796b8ab91ce425a8d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
(cherry picked from commit eee7641cc93aa82b9769c6e8799163ef102ace35)

5 years agoBug 2983 - POST operation to list only accepts data for keys 70/19770/2
Jan Hajnar [Thu, 23 Apr 2015 07:15:43 +0000 (09:15 +0200)]
Bug 2983 - POST operation to list only accepts data for keys

* added catch for ResultAlreadySetException in JsonNormalizedNodeBodyReader

Change-Id: I07d8b8b63e5c2de84b0ee7ec66013d38c58c7b49
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
(cherry picked from commit ae1583bfe01bdc3f43fdb6d590ab7c6a32e0be5a)

5 years agoCustom BufferedWriter implementation without newLine() 84/19684/2
Maros Marsalek [Fri, 24 Apr 2015 09:02:45 +0000 (11:02 +0200)]
Custom BufferedWriter implementation without newLine()

This BufferedWriter does not provide newLine() method and does not read the
line.separator property via AccessController when its initialized. Whithout this
expensive call, its allocation is much faster. Used in netconf message encoder
to make the netconf serialization faster.

Change-Id: I88a65c7a82ff7c44b9ad3a3adfe7d7482a5fdc70
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoFix racecondition in AsyncSshHandlerWriter 96/19996/2
Tomas Cere [Thu, 7 May 2015 11:39:51 +0000 (13:39 +0200)]
Fix racecondition in AsyncSshHandlerWriter

Fixed racecondition between releasing of netty ByteBuff and removing the msg from pendingWrites.

Change-Id: I40eff55d9c7858534d105a242d3ec6feb9d950d0
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoUse callbacks while parsing to NormalizedNodes. 26/19226/5
Tomas Cere [Tue, 28 Apr 2015 12:45:42 +0000 (14:45 +0200)]
Use callbacks while parsing to NormalizedNodes.

Implemented custom parsing strategies that handle netconf operations
and manipulation of the data tree in NetconfMDSal.

Change-Id: I99d7f049710393743714d90ac3123041e87040cd
Signed-off-by: Tomas Cere <tcere@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoAdd NetconfXmlUnitRecursiveQualifier to netconf-util. 10/20010/1
Tomas Cere [Mon, 11 May 2015 08:03:18 +0000 (10:03 +0200)]
Add NetconfXmlUnitRecursiveQualifier to netconf-util.

XmlUnit's RecursiveElementNameAndTextQualifier has trouble with non-trivial xml's and
element order in bigger depths.
This adds our own qualifier based on XmlUnit's implementation.

Change-Id: Ie89e84813e11cb2af7c9d3c0c6d80377816f79a7
Signed-off-by: Tomas Cere <tcere@cisco.com>
5 years agoCDS: add backend support for local transactions 55/19255/10
Robert Varga [Sat, 25 Apr 2015 08:44:13 +0000 (10:44 +0200)]
CDS: add backend support for local transactions

Add the message for submitting a DataTreeModification from the frontend
and the logic to apply it to the Shard's DataTree instance. This is
similar to BatchedModifications, except is is always considered ready.

The ReadyLocalTransaction is not directly serializable, but we create a
new serializer, which turns it into BatchedModifications when
serializing to byte stream.

Change-Id: I23a39c7b5997b48a355af73287d19bbf3ab0ae20
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoChange http port for NorthBoundIT tests 77/19977/2
Tom Pantelis [Sat, 9 May 2015 03:36:50 +0000 (23:36 -0400)]
Change http port for NorthBoundIT tests

The NorthBoundIT tests are failing on jenkins due to port http 8080
already in use. I don't know what else would be running on port 8080
on the build machines - maybe a remnant of another test that didn't
cleanup or didn't finish cleaning up in the background. In any event,
I changed the port to 8180 to hopefully avoid the issue so verify
builds can succeed.

Change-Id: Ia11ef1d69c8cd5948063ec6dbfc08fab2492319c
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoBug 3148 - Fixed binding.api.NotificationListener support 29/19829/1
Tony Tkacik [Thu, 7 May 2015 17:24:15 +0000 (19:24 +0200)]
Bug 3148 - Fixed binding.api.NotificationListener support

Change-Id: I5017e502a23f9cdb7d35dc393e84db7c2989f491
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoMerge "BUG-3095 Add EventTime attribute to DOMNotification from netconf" into stable...
Tony Tkacik [Thu, 7 May 2015 10:25:44 +0000 (10:25 +0000)]
Merge "BUG-3095 Add EventTime attribute to DOMNotification from netconf" into stable/lithium

5 years agoMerge "Bug 3135 - Fixed support for InterestListener" into stable/lithium
Ed Warnicke [Wed, 6 May 2015 15:13:00 +0000 (15:13 +0000)]
Merge "Bug 3135 - Fixed support for InterestListener" into stable/lithium

5 years agoMerge "BUG 2954 : Thread local DocumentBuilder's for XmlUtil" into stable/lithium
Tony Tkacik [Wed, 6 May 2015 12:43:19 +0000 (12:43 +0000)]
Merge "BUG 2954 : Thread local DocumentBuilder's for XmlUtil" into stable/lithium

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.