controller.git
5 years agoMerge "Refactor LeaderTest"
Moiz Raja [Thu, 19 Feb 2015 21:34:47 +0000 (21:34 +0000)]
Merge "Refactor LeaderTest"

5 years agoMerge "Bug 2538: Remove redundant Augmentation checks and tests"
Tom Pantelis [Thu, 19 Feb 2015 20:57:45 +0000 (20:57 +0000)]
Merge "Bug 2538: Remove redundant Augmentation checks and tests"

5 years agoBUG-2682: switch sal-binding-dom-it to sal test models 62/15362/2
Michal Rehak [Thu, 5 Feb 2015 11:32:33 +0000 (12:32 +0100)]
BUG-2682: switch sal-binding-dom-it to sal test models

 - DilcardedDataChangeListenerTest
 - ConcurrentImplicitCreateTest
 - BrokerIntegrationTest
 - ChangeOriginatedInDomBrokerTest

Change-Id: I20f2c6d5d93a535f0ccfb0efc484ec099a75f53b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
5 years agoMerge "Bug 2682 - Switch sal-binding-dom-it to sal-test-model"
Tony Tkacik [Thu, 19 Feb 2015 17:09:32 +0000 (17:09 +0000)]
Merge "Bug 2682 - Switch sal-binding-dom-it to sal-test-model"

5 years agoBug 2682 - Switch sal-binding-dom-it to sal-test-model 43/15343/4
Michal Rehak [Thu, 19 Feb 2015 12:39:06 +0000 (13:39 +0100)]
Bug 2682 - Switch sal-binding-dom-it to sal-test-model

* Migration to sal-test-model

Change-Id: If46014ec4cc8b3311a7766bcb2cb9a61b9e71592
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
5 years agoMerge "Initial message bus implementation"
Tony Tkacik [Thu, 19 Feb 2015 08:15:32 +0000 (08:15 +0000)]
Merge "Initial message bus implementation"

5 years agoMerge "BUG-2634 Config binding for netconf server"
Tony Tkacik [Thu, 19 Feb 2015 08:09:00 +0000 (08:09 +0000)]
Merge "BUG-2634 Config binding for netconf server"

5 years agoMerge "BUG-2633 - Netconf northbound mapping."
Tony Tkacik [Thu, 19 Feb 2015 08:07:49 +0000 (08:07 +0000)]
Merge "BUG-2633 - Netconf northbound mapping."

5 years agoMerge "BUG-2633 - Added Operation Service Factory Filtering for Netconf."
Tony Tkacik [Thu, 19 Feb 2015 08:07:18 +0000 (08:07 +0000)]
Merge "BUG-2633 - Added Operation Service Factory Filtering for Netconf."

5 years agoInitial message bus implementation 31/15031/8
Robert Varga [Sat, 7 Feb 2015 21:55:46 +0000 (22:55 +0100)]
Initial message bus implementation

This patch follows up on the API definition and builds a simple
implementation.

Change-Id: Ic128538a02d71a40ea44efe53f3c4b4503c068ac
Signed-off-by: Robert Gallas <rgallas@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoIntroduce message bus models 29/15029/5
Robert Varga [Sat, 7 Feb 2015 20:12:07 +0000 (21:12 +0100)]
Introduce message bus models

This patch introduces the basic mechanics for integrating various event
sources across MD-SAL, effectively forming a message bus.

Change-Id: I5cbaf9c0975f38c3e3c05ab9862aacf20d2b57c6
Signed-off-by: Robert Gallas <rgallas@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRaft behavior logging 36/15036/14
tpantelis [Tue, 10 Feb 2015 06:07:28 +0000 (01:07 -0500)]
Raft behavior logging

Added more logging in the raft behavior classes where appropriate.

Reduced logging in some places to trace or removed redundant logging to
avoid too much output when debug level is enabled.

Removed isDebugEnabled() checks in various places where not needed to
improve test line coverage.

Also I found it useful to see the behavior's state in the log messages.
So I added a logName field and method to AbstractRaftBehavior that
is printed in each log message instead of just context.getId().

Also added/modified toString() in a few RaftRPC message classes.

Change-Id: Ic4d3c93e25d5caf16319b8433d54cab69b26f5c0
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Bug-2692:Real snapshots should use the replicatedToAllIndex for clearing in...
Moiz Raja [Wed, 18 Feb 2015 22:38:50 +0000 (22:38 +0000)]
Merge "Bug-2692:Real snapshots should use the replicatedToAllIndex for clearing in-mem log"

5 years agoMerge "Make ReadData exception logging less noisy"
Tom Pantelis [Wed, 18 Feb 2015 21:51:47 +0000 (21:51 +0000)]
Merge "Make ReadData exception logging less noisy"

5 years agoMerge "Minor enhancements to dummy datastore"
Tom Pantelis [Wed, 18 Feb 2015 21:50:49 +0000 (21:50 +0000)]
Merge "Minor enhancements to dummy datastore"

5 years agoMinor enhancements to dummy datastore 23/15423/2
Moiz Raja [Tue, 17 Feb 2015 17:46:03 +0000 (09:46 -0800)]
Minor enhancements to dummy datastore

- Log Duplicate AppendEntries
- Enhance AppendEntries logging
- Make logging configurable
- Handle append entries with multiple entries
- Do not delay append entry reply for heartbeats, do so only for messages with entries

Change-Id: Ife856bb469e81c42d22ff4a6f13637ee2cf00cce
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMake ReadData exception logging less noisy 24/15424/2
Moiz Raja [Tue, 17 Feb 2015 17:52:33 +0000 (09:52 -0800)]
Make ReadData exception logging less noisy

There is some component (openflow) which is reading data on a ClosedTransaction.
This is causing logging on the datastore side. The component itself seems to handle
the error reported by the datastore quietly, so switching the logging the error to
debug and logging full stack trace at trace level.

Change-Id: I3c118765dca7f4a50d26c8dd50eee96c65de1871
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Introduce message bus models"
Tony Tkacik [Wed, 18 Feb 2015 16:12:06 +0000 (16:12 +0000)]
Merge "Introduce message bus models"

5 years agoMerge "BUG-2573: mark CompositeNode-based RPC APIs obsolete"
Tony Tkacik [Wed, 18 Feb 2015 09:31:01 +0000 (09:31 +0000)]
Merge "BUG-2573: mark CompositeNode-based RPC APIs obsolete"

5 years agoMerge "Marked as deprecated all classes within protocol-framework."
Tony Tkacik [Wed, 18 Feb 2015 09:27:26 +0000 (09:27 +0000)]
Merge "Marked as deprecated all classes within protocol-framework."

5 years agoMigrate to MoreObjects.ToStringHelper 72/15372/3
Robert Varga [Mon, 16 Feb 2015 08:46:53 +0000 (09:46 +0100)]
Migrate to MoreObjects.ToStringHelper

Objects.ToStringHelper has been deprecated and moved to MoreObjects.
Adjust to this change.

Change-Id: Ibcaaebfe8e2cbbd77e624a53fc153d857b373a81
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRefactor LeaderTest 08/15208/3
tpantelis [Tue, 10 Feb 2015 13:15:07 +0000 (08:15 -0500)]
Refactor LeaderTest

Removed the remaining Within blocks in tests.

Changed each test to use the leaderActor and followerActor class members for
consistency. The actors are killed on tearDown. The creation of a
JavaTestKit block is no longer necessary and was removed from each test.

Added a shorcut method createActorContextWithFollower that creates the
leader context and adds a peer follower. This eliminates some duplicate code
in the tests.

Added an expectFirstMatching method to MessageCollector that waits for
the message in contrast to getFirstMatching.

Added some more assertions in some tests.

Change-Id: Id4ee0291352999b31e40abd9895e3d0237acf432
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBug-2692:Real snapshots should use the replicatedToAllIndex for clearing in-mem log 31/15131/12
Kamal Rameshan [Wed, 11 Feb 2015 07:24:55 +0000 (23:24 -0800)]
Bug-2692:Real snapshots should use the replicatedToAllIndex for clearing in-mem log

Similar to fake snapshots, real snapshots should also be using the replicatedToAllIndex.

replicatedToAllIndex is part of the RaftActorBehavior.

A performSnapshotWithoutCapture helper method is part of the AbstractRaftActorBehavior.

On CaptureSnapshotReply, we clear the log based on replicatedToAllIndex and the corresponding term.

Many of the existing tests seem to test out this changes and some were added and enhanced.

Bug-2715: Fix in-mem log cleanup for an Inactive follower

In case if one of the follower is down, rely on the memory usage to clear the log.

This is done in CaptureSnapshotReply

Change-Id: Ifb3ca19691f20735e3f84b968a7adf01398c20e0
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoMerge "Bug-2692 : Eliminate InitiateInstallSnapshot"
Tom Pantelis [Tue, 17 Feb 2015 18:01:19 +0000 (18:01 +0000)]
Merge "Bug-2692 : Eliminate InitiateInstallSnapshot"

5 years agoMarked as deprecated all classes within protocol-framework. 04/15404/1
Dana Kutenicsova [Tue, 17 Feb 2015 10:28:04 +0000 (11:28 +0100)]
Marked as deprecated all classes within protocol-framework.

- this part of controller will be removed between M3 and M5
- if you're using it, rewrite your code to use netty directly

Change-Id: I864b914d885e15029bca903829c683306780a69d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
5 years agoBUG-2634 Config binding for netconf server 04/15104/11
Maros Marsalek [Mon, 9 Feb 2015 14:44:01 +0000 (15:44 +0100)]
BUG-2634 Config binding for netconf server

MD-SAL based netconf northbound is activated using feature: odl-netconf-mdsal

Change-Id: I6b0ae0db30bb239fcd073883ffe76ff7c5fc0143
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2633 - Netconf northbound mapping. 52/15252/4
Maros Marsalek [Mon, 16 Feb 2015 09:36:48 +0000 (10:36 +0100)]
BUG-2633 - Netconf northbound mapping.

Supported operations for now are:
get, get-config - candidate and running datastore, without filtering
edit-config - only on candidate datastore
discard-changes
lock, unlock - supported only for compatibility reasons since we don't support locking of running datastore, and each session has it's own candidate datastore.
commit

Change-Id: Idb0bad09dc1d8925674576290fecb47ccd1e5dbd
Signed-off-by: Tomas Cere <tcere@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2633 - Added Operation Service Factory Filtering for Netconf. 90/15190/9
Maros Marsalek [Mon, 16 Feb 2015 09:36:38 +0000 (10:36 +0100)]
BUG-2633 - Added Operation Service Factory Filtering for Netconf.

Since getting services is done by class name, we needed to add additional filtering by
name to not get controller subsystem netconf operations mixed up with md-sal northbound.

Change-Id: I6aeb161ae0ace977f590d73e4fcb98c0898b1956
Signed-off-by: Tomas Cere <tcere@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoRemove source element from get netconf rpc 68/15368/3
Maros Marsalek [Mon, 16 Feb 2015 16:05:36 +0000 (17:05 +0100)]
Remove source element from get netconf rpc

Change-Id: Ibe30fa36d7cfe86f908a296c7e4f50cc59453c9c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug-2692 : Eliminate InitiateInstallSnapshot 39/15239/5
Kamal Rameshan [Fri, 13 Feb 2015 07:40:38 +0000 (23:40 -0800)]
Bug-2692 : Eliminate InitiateInstallSnapshot

Change-Id: I7b8f68dc4a2fab9cc61776fe9ce0c58c8ded5242
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoFix Guava 18 upgrade issue , Objects to MoreObjects 87/15387/3
Kamal Rameshan [Mon, 16 Feb 2015 22:07:17 +0000 (14:07 -0800)]
Fix Guava 18 upgrade issue , Objects to MoreObjects

Change-Id: I0792fc09fa18614b84a7b24601b08b8b3c2c1abf
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoMerge "Fix reading operaional data for netconf mountpoint"
Tony Tkacik [Mon, 16 Feb 2015 11:26:50 +0000 (11:26 +0000)]
Merge "Fix reading operaional data for netconf mountpoint"

5 years agoMerge "Do not override odlparent properties"
Tony Tkacik [Mon, 16 Feb 2015 09:22:26 +0000 (09:22 +0000)]
Merge "Do not override odlparent properties"

5 years agoMerge "Remove xtend.version property"
Tony Tkacik [Mon, 16 Feb 2015 09:22:13 +0000 (09:22 +0000)]
Merge "Remove xtend.version property"

5 years agoFix reading operaional data for netconf mountpoint 49/15349/2
Maros Marsalek [Mon, 16 Feb 2015 08:44:26 +0000 (09:44 +0100)]
Fix reading operaional data for netconf mountpoint

Change-Id: I3c273500f0df6cfeed626a917a7039c8fc648fbf
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoDo not override odlparent properties 25/15325/2
Robert Varga [Sat, 14 Feb 2015 20:02:34 +0000 (21:02 +0100)]
Do not override odlparent properties

These properties are defined upstream, no need to define them here.

Change-Id: Ieb5e12b74e5d333948410fa5329446ab59ad6967
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRemove xtend.version property 24/15324/2
Robert Varga [Sat, 14 Feb 2015 19:56:51 +0000 (20:56 +0100)]
Remove xtend.version property

It is no longer needed, as odlparent has been fixed.

Change-Id: I56b891e6232e074bb5fed56b819312fb1305c4b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoAdd more context if a config push fails 19/15319/2
Robert Varga [Sat, 14 Feb 2015 09:48:09 +0000 (10:48 +0100)]
Add more context if a config push fails

This adds the current state to the error message.

Change-Id: I3c165d7aae7dcb7dba4a374e17390d643c6ed40b
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFix neutron implicit osgi import 21/15321/1
Robert Varga [Sat, 14 Feb 2015 10:35:09 +0000 (11:35 +0100)]
Fix neutron implicit osgi import

Neutron northbound requires osgi-core but fails to mention it in
pom.xml. Fix that.

Change-Id: Id73bc2550c10268e30a852fb2dbde19a04c8b24d
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-1173: ensure compatibility with Guava 17+ 20/15320/2
Robert Varga [Mon, 9 Jun 2014 17:35:21 +0000 (19:35 +0200)]
BUG-1173: ensure compatibility with Guava 17+

This migrates the sole user to the Guava-15+ API, as the API is removed
in version 17.

Change-Id: I3bf52fb89116024e7305a142e6b1f6fec9985488
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoDefine xtend.version until it is remove from odlparent 16/15316/2
Robert Varga [Sat, 14 Feb 2015 09:16:52 +0000 (10:16 +0100)]
Define xtend.version until it is remove from odlparent

https://git.opendaylight.org/gerrit/15313 will remove references to it,
but until that happens, we need to provide an override.

Change-Id: Idfc7eef4e194d7011a608392de07813d7cc15113
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-1173: ensure compatibility with Guava 17+ 31/7831/8
Robert Varga [Mon, 9 Jun 2014 17:35:21 +0000 (19:35 +0200)]
BUG-1173: ensure compatibility with Guava 17+

This migrates the sole user to the Guava-15+ API, as the API is removed
in version 17.

Change-Id: Ia587465e0289f5d98ec3da83cc3fc6765f8a8b38
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-1173: remove explicit guava version 30/14830/7
Robert Varga [Wed, 4 Feb 2015 15:29:25 +0000 (16:29 +0100)]
BUG-1173: remove explicit guava version

Removes an explicit mention of 14.0.1 in favor of odlparent-provided
version.

Change-Id: Iea11d3a207ae4799ef736ef5804649a11340e3be
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMake sure config-api brings in osgi-core 14/15314/1
Robert Varga [Sat, 14 Feb 2015 07:58:45 +0000 (08:58 +0100)]
Make sure config-api brings in osgi-core

config-api is used in config-generated code, which needs osgi for
compilation. Unfortunately augmenting all current users is prohibitive,
so just make sure all users inherit osgi-core as a compile-time
dependency.

The real fix is to create a parent, which will pull osgi-core into
artifacts which actually invoke yang-jmx-plugin.

Change-Id: I24caf20ea1ab0ce32f9d259ca650f38668a8c7a5
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2573: mark CompositeNode-based RPC APIs obsolete 86/14686/16
Robert Varga [Mon, 2 Feb 2015 17:36:30 +0000 (18:36 +0100)]
BUG-2573: mark CompositeNode-based RPC APIs obsolete

With the advent of the NormalizedNode-based APIs, the users should be
moving towards implementation of those.

This is a placeholder, to be merged once a reference implementation is
available.

Change-Id: I7e321861d5100554dfde30c31ed47e585573be0a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "BUG-2573: create DOMRpcRouter"
Tony Tkacik [Fri, 13 Feb 2015 09:30:12 +0000 (09:30 +0000)]
Merge "BUG-2573: create DOMRpcRouter"

5 years agoMerge "BUG-2626: activate enunciate only on jdk-1.7"
Tony Tkacik [Fri, 13 Feb 2015 09:29:35 +0000 (09:29 +0000)]
Merge "BUG-2626: activate enunciate only on jdk-1.7"

5 years agoMerge "BUG-2626: Do not override enunciate version"
Tony Tkacik [Fri, 13 Feb 2015 09:29:16 +0000 (09:29 +0000)]
Merge "BUG-2626: Do not override enunciate version"

5 years agoMerge "Bug-2674 Notification support for netconf testtool"
Tony Tkacik [Fri, 13 Feb 2015 09:17:59 +0000 (09:17 +0000)]
Merge "Bug-2674 Notification support for netconf testtool"

5 years agoMerge "BUG-2573: add NormalizedNode-based RPC API"
Tony Tkacik [Fri, 13 Feb 2015 09:16:37 +0000 (09:16 +0000)]
Merge "BUG-2573: add NormalizedNode-based RPC API"

5 years agoBug-2674 Notification support for netconf testtool 58/15058/2
Maros Marsalek [Mon, 9 Feb 2015 10:40:57 +0000 (11:40 +0100)]
Bug-2674 Notification support for netconf testtool

Change-Id: Ib301e2cccf85d4eae75629ddf681d9157b0cb585
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "(Fix: Bug 2711) - Match RPC actor system's Netty TCP settings with existing...
Moiz Raja [Fri, 13 Feb 2015 04:15:44 +0000 (04:15 +0000)]
Merge "(Fix: Bug 2711) - Match RPC actor system's Netty TCP settings with existing cluster DATA actor system setting to avoid oversized Gossip RPC messages."

5 years agoMerge "Try to eliminate random failures in RaftActorTest"
Tom Pantelis [Fri, 13 Feb 2015 02:40:13 +0000 (02:40 +0000)]
Merge "Try to eliminate random failures in RaftActorTest"

5 years agoMerge "Add slf4j SimpleLogger properties file for unit tests"
Moiz Raja [Thu, 12 Feb 2015 23:49:20 +0000 (23:49 +0000)]
Merge "Add slf4j SimpleLogger properties file for unit tests"

5 years agoMerge "Added LeaderElectionScenariosTest class"
Moiz Raja [Thu, 12 Feb 2015 23:48:37 +0000 (23:48 +0000)]
Merge "Added LeaderElectionScenariosTest class"

5 years agoTry to eliminate random failures in RaftActorTest 15/15215/3
Moiz Raja [Thu, 12 Feb 2015 20:22:11 +0000 (12:22 -0800)]
Try to eliminate random failures in RaftActorTest

This patch attempts to add the following enhancements,
1. All test actors get created using a TestActorFactory which when closed
   automatically kills the actors created by it
2. Provide a method to auto generate a friendly actor name/id for cases
   where we need to use such names

Change-Id: Ia1fd81f08baf00dfc614dfa8466be2a62f18952d
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years ago(Fix: Bug 2711) 25/15225/1
mark.mozolewski [Thu, 12 Feb 2015 23:22:19 +0000 (15:22 -0800)]
(Fix: Bug 2711)
- Match RPC actor system's Netty TCP settings with existing cluster DATA actor system setting to avoid oversized Gossip RPC messages.

Change-Id: I3e2c13cc23aa29052c5ed5096a887c563469d59e
Signed-off-by: mark.mozolewski <mark.mozolewski@hp.com>
5 years agoMerge "Neutron to return ServiceUnavailable if no providers registered"
Ed Warnicke [Thu, 12 Feb 2015 22:39:52 +0000 (22:39 +0000)]
Merge "Neutron to return ServiceUnavailable if no providers registered"

5 years agoNeutron to return ServiceUnavailable if no providers registered 19/15219/1
Ryan Moats [Thu, 12 Feb 2015 21:40:05 +0000 (15:40 -0600)]
Neutron to return ServiceUnavailable if no providers registered

opNFV interwork revealed that neutron returns 200 in error cases
where no SB providers are registered and if there is an error getting
the list of SB providers.  Close both of these holes by returning
Service Unavailable Status

Change-Id: Iefa092a35bdc178f632373eac3b84578028d3768
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
5 years agoMerge "Mark yang generated source location as a source directory."
Ed Warnicke [Thu, 12 Feb 2015 21:29:54 +0000 (21:29 +0000)]
Merge "Mark yang generated source location as a source directory."

5 years agoMerge "Stop scheduling the Install Snapshot check"
Tom Pantelis [Thu, 12 Feb 2015 21:15:39 +0000 (21:15 +0000)]
Merge "Stop scheduling the Install Snapshot check"

5 years agoMerge "(Bug 2035) - Increasing default Akka config for auto-down of unreachable nodes...
Moiz Raja [Thu, 12 Feb 2015 20:30:03 +0000 (20:30 +0000)]
Merge "(Bug 2035) - Increasing default Akka config for auto-down of unreachable nodes from 10sec to 5min to avoid locking out nodes during transient network blips, etc. "

5 years agoMerge "BUG 2705 : No need to ReadData asynchronously in ShardTransaction"
Tom Pantelis [Thu, 12 Feb 2015 19:38:51 +0000 (19:38 +0000)]
Merge "BUG 2705 : No need to ReadData asynchronously in ShardTransaction"

5 years agoBUG-2626: activate enunciate only on jdk-1.7 14/15214/2
Robert Varga [Thu, 12 Feb 2015 18:16:37 +0000 (19:16 +0100)]
BUG-2626: activate enunciate only on jdk-1.7

The plugin is not supported with JDK8. Create two parent pom.xmls, one
of which defines the activation on JDK7 only and the second one
centralizes the AD-SAL definitions for it.

Change-Id: I791847d6e27dae0f51499b303cbea9163f5f184a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2626: Do not override enunciate version 13/15213/1
Robert Varga [Thu, 12 Feb 2015 18:18:23 +0000 (19:18 +0100)]
BUG-2626: Do not override enunciate version

The overall version is 1.28, so do not downgrade it.

Change-Id: I4611091ab3c2f9ec58debb3a39ed82992e98338e
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG 2705 : No need to ReadData asynchronously in ShardTransaction 82/15182/2
Moiz Raja [Thu, 12 Feb 2015 03:46:39 +0000 (19:46 -0800)]
BUG 2705 : No need to ReadData asynchronously in ShardTransaction

Change-Id: I15a065e5fbc67c0c1d82e98e28252dd4ce0c983c
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Do not duplicate OSGi dependencyManagement"
Tony Tkacik [Thu, 12 Feb 2015 17:36:39 +0000 (17:36 +0000)]
Merge "Do not duplicate OSGi dependencyManagement"

5 years agoMerge "BUG-2673: Introduced new more low-level DOM Data Change APIs"
Tony Tkacik [Thu, 12 Feb 2015 17:14:31 +0000 (17:14 +0000)]
Merge "BUG-2673: Introduced new more low-level DOM Data Change APIs"

5 years agoMerge "BUG-1511 - Datastore: cleanup ListenerTreeAPI"
Tony Tkacik [Thu, 12 Feb 2015 16:53:24 +0000 (16:53 +0000)]
Merge "BUG-1511 - Datastore: cleanup ListenerTreeAPI"

5 years agoMerge "BUG-2632 Netconf connector (optionally) reconnects after a schema change is...
Tony Tkacik [Thu, 12 Feb 2015 15:54:19 +0000 (15:54 +0000)]
Merge "BUG-2632 Netconf connector (optionally) reconnects after a schema change is detected"

5 years agoMerge "BUG-2600 Dynamic schemas in netconf server"
Tony Tkacik [Thu, 12 Feb 2015 15:52:54 +0000 (15:52 +0000)]
Merge "BUG-2600 Dynamic schemas in netconf server"

5 years agoMerge "Bug 2684 - Fixing support for Neutron binding extended attributes"
Ed Warnicke [Thu, 12 Feb 2015 14:53:48 +0000 (14:53 +0000)]
Merge "Bug 2684 - Fixing support for Neutron binding extended attributes"

5 years agoBUG-1511 - Datastore: cleanup ListenerTreeAPI 37/10137/7
Robert Varga [Thu, 21 Aug 2014 12:54:37 +0000 (14:54 +0200)]
BUG-1511 - Datastore: cleanup ListenerTreeAPI

- split ListenerTree two static inner classes to ListenerWalker and ListenerNode
- fix refences [ResolvedDataChangeState]
- improve performance of ListenerWalker.close()

Change-Id: Ide82bc6caeaca1aa5c9080f134d570cf7a1571d6
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2673: Introduced new more low-level DOM Data Change APIs 42/14542/8
Robert Varga [Tue, 27 Jan 2015 14:05:38 +0000 (15:05 +0100)]
BUG-2673: Introduced new more low-level DOM Data Change APIs

As it turned out abstraction provided by Helium Data Change
API was CPU costly and calculated lot of unnecessary data,
and did not provide necessary navigation for some use-cases.

This new API contract defines more low-level data change
APIs, where application is more in control, how it will
process / consume / decompose Data Change by providing
DataTreeCandidate.

Change-Id: I468c9583c7999bc02101a18a8adf5dc1a084f1d9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "BUG-2627: do not duplicate descriptions"
Tony Tkacik [Thu, 12 Feb 2015 12:18:47 +0000 (12:18 +0000)]
Merge "BUG-2627: do not duplicate descriptions"

5 years agoMerge "BUG-2627: JMX interfaces need to be public"
Tony Tkacik [Thu, 12 Feb 2015 12:18:10 +0000 (12:18 +0000)]
Merge "BUG-2627: JMX interfaces need to be public"

5 years agoBUG-2627: do not duplicate descriptions 93/15193/1
Robert Varga [Thu, 12 Feb 2015 10:36:08 +0000 (11:36 +0100)]
BUG-2627: do not duplicate descriptions

This class effectively creates a repeateable annotation. Unfortunately
in Java 8, we get twice as many annotations, which leads to duplicate
entries. Instantiate an intermediate Set, so we suppress potential
duplicates.

Change-Id: I0377d439260c2b3793c972c73373f5f6c6a7f119
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2627: JMX interfaces need to be public 92/15192/1
Robert Varga [Thu, 12 Feb 2015 10:18:32 +0000 (11:18 +0100)]
BUG-2627: JMX interfaces need to be public

Java 8 enforces the specification's required for MXBean interfaces to be
public. The mock interfaces were not public, hence were failing the test
automatically.

Change-Id: I4a358ff750da6c91571847b650ef0746e9da3621
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Initial heartbeats not sent by Leader"
Moiz Raja [Thu, 12 Feb 2015 03:45:37 +0000 (03:45 +0000)]
Merge "Initial heartbeats not sent by Leader"

5 years agoStop scheduling the Install Snapshot check 73/15173/1
Moiz Raja [Wed, 11 Feb 2015 22:31:38 +0000 (14:31 -0800)]
Stop scheduling the Install Snapshot check

We only schedule it once and even that is unneccessary
because we check if a snapshot needs to be triggered in
sendUpdatesToFollower and that should be good enough

Change-Id: I4da5d3452dbdb261738587f41201611ef891bec1
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge topic 'bug/2676'
Tom Pantelis [Wed, 11 Feb 2015 22:00:53 +0000 (22:00 +0000)]
Merge topic 'bug/2676'

* changes:
  Store the datastore type in dataStoreContext
  Refactor DataStoreContext
  BUG 2676 : Apply backpressure when creating transactions

5 years agoMerge "Run SingleFeatureTest on features/netconf"
Tony Tkacik [Wed, 11 Feb 2015 21:06:51 +0000 (21:06 +0000)]
Merge "Run SingleFeatureTest on features/netconf"

5 years agoAdd a diagnostic message to figure out why test fails 61/15161/1
Moiz Raja [Wed, 11 Feb 2015 19:53:08 +0000 (11:53 -0800)]
Add a diagnostic message to figure out why test fails

Adding a message to figure out why testFakeSnapshotsForLeaderWithInInitiateSnapshots
fails sometimes

Change-Id: I5c6f7d33e429a7497fa28ad99c316be2def59422
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoStore the datastore type in dataStoreContext 47/14947/9
Moiz Raja [Thu, 5 Feb 2015 23:38:38 +0000 (15:38 -0800)]
Store the datastore type in dataStoreContext

This way we do not need to pass it to DistributedDataStoreFactory,
DistributedDataStore and ShardManager as it is already present in
dataStoreContext

Change-Id: Id9aa1541728f3632a46d67f3bdbacb87fd39783f
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoRefactor DataStoreContext 36/14936/10
Moiz Raja [Thu, 5 Feb 2015 19:58:06 +0000 (11:58 -0800)]
Refactor DataStoreContext

It was getting difficult to maintain because we had the same field defined
in the Builder and the DatastoreContext and we were passing the fields along
using the DatastoreContext constructor. This meant that every new setting that
we added required multiple changes to be made to DatastoreContext.

Refactored for the Builder to create the DatastoreContext upfront and directly set
it's fields.

Change-Id: I8060c4ea3dfd02a5cac20e28fb5be2f26b1e1dbd
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2676 : Apply backpressure when creating transactions 70/14870/11
Moiz Raja [Thu, 5 Feb 2015 02:19:14 +0000 (18:19 -0800)]
BUG 2676 : Apply backpressure when creating transactions

This patch uses a rate limiter to limit the number of write transactions
that can be created on the datastore at any given point of time (within a
second).

We also have added a metric that is trackable using JMX which will show
exactly how much time we take in committing a transaction.

Could this rate limiter have been on the DataBroker? Yes it could have been
but I think we need to go granular on this one. Ideally the ratelimiter would
be for every shard transaction but it's not trivial to do in a way that would
actually block the consumer for now - this is because creating a transaction on
Shard itself is an async operation.

Change-Id: I3d8e3baeb892ba494c0ab0d13a0d6226c1516511
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years ago(Bug 2035) 17/15117/2
mark.mozolewski [Tue, 10 Feb 2015 18:51:01 +0000 (10:51 -0800)]
(Bug 2035)
- Increasing default Akka config for auto-down of unreachable nodes from 10sec to 5min to avoid locking out nodes during transient network blips, etc.

Change-Id: I3528b34373af192ff6b58b214ba9313b379e9828
Signed-off-by: mark.mozolewski <mark.mozolewski@hp.com>
5 years agoRun SingleFeatureTest on features/netconf 54/15154/1
Ed Warnicke [Wed, 11 Feb 2015 16:59:15 +0000 (09:59 -0700)]
Run SingleFeatureTest on features/netconf

Change-Id: Ibc60948413f633b4954ff603ad6a951658a95132
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoBUG-2632 Netconf connector (optionally) reconnects after a schema change is detected 23/14923/6
Maros Marsalek [Thu, 5 Feb 2015 14:49:44 +0000 (15:49 +0100)]
BUG-2632 Netconf connector (optionally) reconnects after a schema change is detected

A notification listener is used for schema change detection

Change-Id: Ieab4eaf9e87b2b88dd2dc5429039494c8f9b5731
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2538: Remove redundant Augmentation checks and tests 25/14525/2
Kiran Sreenivasa [Mon, 26 Jan 2015 22:08:36 +0000 (14:08 -0800)]
Bug 2538: Remove redundant Augmentation checks and tests

Change-Id: Ifa19661df9d3ba9cc8b93e0203bb760b792d8689
Signed-off-by: Kiran Sreenivasa <kkoushik@brocade.com>
5 years agoMerge "Fix issue with TransactionProxy throttling test failures"
Tom Pantelis [Fri, 13 Feb 2015 13:49:13 +0000 (13:49 +0000)]
Merge "Fix issue with TransactionProxy throttling test failures"

5 years agoMerge "Bring features/neutron into the same parent dir as everything else"
Tony Tkacik [Fri, 13 Feb 2015 13:40:23 +0000 (13:40 +0000)]
Merge "Bring features/neutron into the same parent dir as everything else"

5 years agoFix issue with TransactionProxy throttling test failures 17/15217/2
Moiz Raja [Thu, 12 Feb 2015 20:52:42 +0000 (12:52 -0800)]
Fix issue with TransactionProxy throttling test failures

Make the measurement a little bit more precise by using nanoTime
instead of currentTimeMillis

Change-Id: I983ea1d176b65dacdb28e74a50f32623632442cf
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBring features/neutron into the same parent dir as everything else 23/15223/1
Ed Warnicke [Thu, 12 Feb 2015 22:25:58 +0000 (15:25 -0700)]
Bring features/neutron into the same parent dir as everything else

This will ease breaking the code out to the neutron northbound project

Change-Id: Idf887c14cdbc7e77b74f4964b516ac16ab6877e6
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoBUG-2600 Dynamic schemas in netconf server 22/14922/6
Maros Marsalek [Tue, 10 Feb 2015 08:15:15 +0000 (09:15 +0100)]
BUG-2600 Dynamic schemas in netconf server

Netconf server does not preserve snapshots of schema contexts for each netconf session anymore

Every netconf session is using current SchemaContext
+ Use notification manager to notify about capability changes

Change-Id: Ie47125e1eb6851b54b09d5e4afe38fee323850de
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoReduce ShardManager logging 56/15256/1
tpantelis [Wed, 11 Feb 2015 03:55:50 +0000 (22:55 -0500)]
Reduce ShardManager logging

ShardManager emits info logging on SchemaContext changes which yields a
lof of output that isn't that useful. Reduce to debug.

Change-Id: I2200bbffa26a2dd9af2cf76a9efcab31bf77c348
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBug 2701: Fixed dependencies for features-netconf. 24/15124/2
Hideyuki Tai [Wed, 11 Feb 2015 00:35:54 +0000 (19:35 -0500)]
Bug 2701: Fixed dependencies for features-netconf.

Change-Id: I2b853145cbcd9a24b6cc029ab4d61d34a32a3dfe
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
5 years agoMerge "Bug 2669: Use slf4j Logger instead of akka LoggingAdapter"
Moiz Raja [Tue, 10 Feb 2015 22:11:40 +0000 (22:11 +0000)]
Merge "Bug 2669: Use slf4j Logger instead of akka LoggingAdapter"

5 years agoMerge "BUG-2679 Workaround for wrong nagasena encode/decode with reused transmogrifier"
Tony Tkacik [Tue, 10 Feb 2015 21:13:46 +0000 (21:13 +0000)]
Merge "BUG-2679 Workaround for wrong nagasena encode/decode with reused transmogrifier"

5 years agoMerge "BUG-2310 - widen yang model for netconf-node."
Tony Tkacik [Tue, 10 Feb 2015 21:13:18 +0000 (21:13 +0000)]
Merge "BUG-2310 - widen yang model for netconf-node."

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.