controller.git
5 years agoMerge "Startup arch - add odlparent to root pom."
Tony Tkacik [Wed, 25 Feb 2015 09:56:13 +0000 (09:56 +0000)]
Merge "Startup arch - add odlparent to root pom."

5 years agoMerge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"
Tony Tkacik [Wed, 25 Feb 2015 09:29:54 +0000 (09:29 +0000)]
Merge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"

5 years agoMerge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"
Tony Tkacik [Wed, 25 Feb 2015 09:29:26 +0000 (09:29 +0000)]
Merge "BUG 2412 - restconf @GET getModule(identifier,uri) method migration"

5 years agoMerge "BUG 2412 - restconf @GET getModule(uri) method migration"
Tony Tkacik [Wed, 25 Feb 2015 09:28:42 +0000 (09:28 +0000)]
Merge "BUG 2412 - restconf @GET getModule(uri) method migration"

5 years agoMerge "Removing { } from NormalizedNodeJsonBodyWriter"
Tony Tkacik [Wed, 25 Feb 2015 08:04:44 +0000 (08:04 +0000)]
Merge "Removing { } from NormalizedNodeJsonBodyWriter"

5 years agoBUG 2412 - restconf @GET getModule(identifier,uri) method migration 71/14971/7
Vaclav Demcak [Fri, 6 Feb 2015 13:14:09 +0000 (14:14 +0100)]
BUG 2412 - restconf @GET getModule(identifier,uri) method migration

    * migration to new faster Infrastructure API and Codecs for method
    @GET getModules(String,UriInfo) on @Path {/modules/module/identifier}

    New faster Infrastructure API works with NormizedNodeContext and
    we are replacing first method getModule(URI) from RestconfService
    to use NormalizedNodeContext.

Change-Id: I7ae36a13ce4533598bbc3abf73d9090e1922abdb
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf @GET getModule(identifier,uri) method migration 70/14970/9
Vaclav Demcak [Fri, 6 Feb 2015 13:01:30 +0000 (14:01 +0100)]
BUG 2412 - restconf @GET getModule(identifier,uri) method migration

* migration to new faster Infrastructure API and Codecs for method
@GET getModules(String,UriInfo) on @Path {/modules/identifier}

New faster Infrastructure API works with NormizedNodeContext and
we are replacing first method getModule(URI) from RestconfService
to use NormalizedNodeContext.

* add yang models for fix tests (mountpoint tests - TestUtility
loads modules from local directory only)

Change-Id: I394d6d31f650e086ce302a0ba973f1e4a4599ef8
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - restconf @GET getModule(uri) method migration 69/14969/11
Vaclav Demcak [Tue, 24 Feb 2015 16:34:02 +0000 (17:34 +0100)]
BUG 2412 - restconf @GET getModule(uri) method migration

    * migration to new faster Infrastructure API and Codecs for method
    @GET getModules(UriInfo) on @Path {/modules}

    New faster Infrastructure API works with NormizedNodeContext and
    we are replacing first method getModule(URI) from RestconfService
    to use NormalizedNodeContext.

Change-Id: I9327badeac38a82c9e50721dc47338fc7ae164a1
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2412 - Restconf migration - marking deprecated classes 67/15667/1
Vaclav Demcak [Tue, 24 Feb 2015 13:33:44 +0000 (14:33 +0100)]
BUG 2412 - Restconf migration - marking deprecated classes

* mark basic deprecated classes and functionality which has to
be overwirte by this commit chain.

New faster Infrastructure API works with NormizedNodeContext
and it provides read/write REST msg body (JSON & XML) direct
to NormalizedNodeContext. So we have to replace all places
where we use StructuredData, CompositeNode, NodeWrapper and
all relevant REST codecs (e.g. XmlToCompositeNodeProvider...)

Change-Id: I33ff24e5a8de2876dfdb6ea263fc9cb659fc3db8
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBug 2365: YIN Schema download support for Restconf 26/13126/3
Vaclav Demcak [Tue, 24 Feb 2015 12:27:55 +0000 (13:27 +0100)]
Bug 2365: YIN Schema download support for Restconf

Implementation of Restconf 03 Draft Schema download
functionality with additional support for downloading
runtime-generated YIN schema and mount points.

Introduced new endpoints which are:
  /restconf/modules/module/{module}/{revision}/schema

and
  /restconf/modules/module/{mount}/{module}/{revision}/schema

For downloading supplied YANG module in YIN format (default)
or YANG format if Accept header contains application/yang
mime-type.

depends on:
yangtools -  https://git.opendaylight.org/gerrit/#/c/15258/

patch set 3:
 * SchemaExportContentYniBodyWriter : fix reference YinUtils
to YinExportUtils
 * create RestconfValidationUtils + move validation from
SchemaRetrievalServiceImpl
 * pom.xml - add private package
                org.opendaylight.controller.md.sal.rest.common

Change-Id: Ibd2956472ad35d13cb65e305df377f98518b4738
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoFix a race in PingPong transaction scheduling 36/15636/3
Robert Varga [Mon, 23 Feb 2015 22:56:38 +0000 (23:56 +0100)]
Fix a race in PingPong transaction scheduling

We have failed to re-check inflighTx after taking the lock, which meant
that completion and readiness may have raced resulting in warnings about
transaction being submitted while there are others in-flight.

Fix also the shutdown case, which could trigger an unexpected warnings
if there is an inflight transaction.

Change-Id: Ie3a3845335754860a831070d5a73dbc9a4d67d3c
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Bug 2697: Improvement wrong response handling, missing message"
Tony Tkacik [Tue, 24 Feb 2015 09:39:47 +0000 (09:39 +0000)]
Merge "Bug 2697: Improvement wrong response handling, missing message"

5 years agoMerge "Bug 2731: Discard changes only when transaction exist."
Tony Tkacik [Tue, 24 Feb 2015 09:39:34 +0000 (09:39 +0000)]
Merge "Bug 2731: Discard changes only when transaction exist."

5 years agoMerge "Sharded implementation of DOMDataTreeService"
Tony Tkacik [Tue, 24 Feb 2015 09:36:11 +0000 (09:36 +0000)]
Merge "Sharded implementation of DOMDataTreeService"

5 years agoMerge "Fix race condition in get/get-config netconf rpcs for config subsystem"
Tony Tkacik [Tue, 24 Feb 2015 08:50:15 +0000 (08:50 +0000)]
Merge "Fix race condition in get/get-config netconf rpcs for config subsystem"

5 years agoSharded implementation of DOMDataTreeService 99/15199/13
Robert Varga [Thu, 12 Feb 2015 14:09:54 +0000 (15:09 +0100)]
Sharded implementation of DOMDataTreeService

This patch adds a simplistic implementation of a DOMDataTreeService and
a DOMDataTreeShardingService.

Change-Id: Ibb76c99d0fa842b1034a2b747c4ec57816f99c7d
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Make DOMDataTreeIdentifier implement Comparable"
Tony Tkacik [Tue, 24 Feb 2015 08:27:55 +0000 (08:27 +0000)]
Merge "Make DOMDataTreeIdentifier implement Comparable"

5 years agoMerge "Pass down a collection of cohorts"
Tony Tkacik [Tue, 24 Feb 2015 08:27:33 +0000 (08:27 +0000)]
Merge "Pass down a collection of cohorts"

5 years agoMerge "Startup archetype - move impl under 'impl' namespace to prevent exporting."
Tony Tkacik [Tue, 24 Feb 2015 08:26:34 +0000 (08:26 +0000)]
Merge "Startup archetype - move impl under 'impl' namespace to prevent exporting."

5 years agoMerge "Startup arch - Add scm section to root pom."
Tony Tkacik [Tue, 24 Feb 2015 08:26:20 +0000 (08:26 +0000)]
Merge "Startup arch - Add scm section to root pom."

5 years agoMerge "Startup arch - feature cleanup"
Tony Tkacik [Tue, 24 Feb 2015 08:26:05 +0000 (08:26 +0000)]
Merge "Startup arch - feature cleanup"

5 years agoMerge "Skip install and deploy of karaf artifact."
Tony Tkacik [Tue, 24 Feb 2015 08:25:49 +0000 (08:25 +0000)]
Merge "Skip install and deploy of karaf artifact."

5 years agoMake DOMDataTreeIdentifier implement Comparable 34/15634/3
Robert Varga [Mon, 23 Feb 2015 21:45:52 +0000 (22:45 +0100)]
Make DOMDataTreeIdentifier implement Comparable

We can easily define total ordering on this class, which is useful for
maintaining order so that we can find the longest-prefix match easily by
iterating over the keys in the natural ordering.

Change-Id: Ie2f83ea494fe278df4acc1cb6059dae440ef8f37
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoPass down a collection of cohorts 24/15624/3
Robert Varga [Mon, 23 Feb 2015 17:30:31 +0000 (18:30 +0100)]
Pass down a collection of cohorts

Rather than using an iterable, use a Collection. This saves a bit of
code and makes the size available wherever the collection goes.

Change-Id: I7ab9fa594676c221c8a4a0b3e227625af462c338
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "BUG 2676 : Use notification-dispatcher for DataChangeListener actors"
Tom Pantelis [Tue, 24 Feb 2015 00:47:32 +0000 (00:47 +0000)]
Merge "BUG 2676 : Use notification-dispatcher for DataChangeListener actors"

5 years agoMerge "BUG 2676 : Use transaction-dispatcher for ShardTransaction"
Tom Pantelis [Tue, 24 Feb 2015 00:47:19 +0000 (00:47 +0000)]
Merge "BUG 2676 : Use transaction-dispatcher for ShardTransaction"

5 years agoMerge "BUG 2676 : Use shard-dispatcher for ShardManager and Shard actors"
Tom Pantelis [Tue, 24 Feb 2015 00:47:03 +0000 (00:47 +0000)]
Merge "BUG 2676 : Use shard-dispatcher for ShardManager and Shard actors"

5 years agoMerge "BUG 2676 : Use custom client-dispatcher when configured"
Tom Pantelis [Tue, 24 Feb 2015 00:46:52 +0000 (00:46 +0000)]
Merge "BUG 2676 : Use custom client-dispatcher when configured"

5 years agoMerge "BUG 2676 : Introduce API for accessing akka dispatchers"
Tom Pantelis [Mon, 23 Feb 2015 23:13:35 +0000 (23:13 +0000)]
Merge "BUG 2676 : Introduce API for accessing akka dispatchers"

5 years agoMerge "BUG 2718 : Create a diagnostic utility to track append entries replies"
Tom Pantelis [Mon, 23 Feb 2015 23:11:02 +0000 (23:11 +0000)]
Merge "BUG 2718 : Create a diagnostic utility to track append entries replies"

5 years agoMerge "BUG 2741 : Fix issue with real snapshotting when replicatedToAllIndex=-1"
Tom Pantelis [Mon, 23 Feb 2015 19:20:51 +0000 (19:20 +0000)]
Merge "BUG 2741 : Fix issue with real snapshotting when replicatedToAllIndex=-1"

5 years agoStartup archetype - move impl under 'impl' namespace to prevent exporting. 28/15128/3
Nathan Harmon [Wed, 11 Feb 2015 01:07:50 +0000 (17:07 -0800)]
Startup archetype - move impl under 'impl' namespace to prevent exporting.

Change-Id: I2767080af78569a2af8d0c1114d1471a62cbc302
Signed-off-by: Nathan Harmon <nathan.harmon@hp.com>
5 years agoMerge "Bug 2673: Binding cursor-based data change API"
Ed Warnicke [Mon, 23 Feb 2015 18:42:41 +0000 (18:42 +0000)]
Merge "Bug 2673: Binding cursor-based data change API"

5 years agoStartup arch - add odlparent to root pom. 26/15626/1
Nathan Harmon [Mon, 23 Feb 2015 18:07:43 +0000 (10:07 -0800)]
Startup arch - add odlparent to root pom.

Change-Id: I50b9a58aee797f6821816f19984005e9e347c3d9
Signed-off-by: Nathan Harmon <nathan.harmon@hp.com>
5 years agoStartup arch - Add scm section to root pom. 29/15429/3
Nathan Harmon [Tue, 17 Feb 2015 18:45:42 +0000 (10:45 -0800)]
Startup arch - Add scm section to root pom.

Change-Id: Ie20d9f6f0e2201c0c1f7995e451c583c085e689c
Signed-off-by: Nathan Harmon <nathan.harmon@hp.com>
5 years agoStartup arch - feature cleanup 27/15127/2
Nathan Harmon [Wed, 11 Feb 2015 01:32:02 +0000 (17:32 -0800)]
Startup arch - feature cleanup

Change-Id: I8a6c19cb8bfdb21dfa7bab8b427d8b7922fc9a9c
Signed-off-by: Nathan Harmon <nathan.harmon@hp.com>
5 years agoMerge "Re-enable running of SingleFeaturesTest"
Tony Tkacik [Mon, 23 Feb 2015 16:52:26 +0000 (16:52 +0000)]
Merge "Re-enable running of SingleFeaturesTest"

5 years agoSkip install and deploy of karaf artifact. 64/14864/3
Nathan Harmon [Wed, 4 Feb 2015 22:21:23 +0000 (14:21 -0800)]
Skip install and deploy of karaf artifact.

Change-Id: Ib96201b9408216c58b3d573c593a523ef65eafd0
Signed-off-by: Nathan Harmon <nathan.harmon@hp.com>
5 years agoMerge "Startup archetype: remove 'Impl' from config subsystem Module name."
Tony Tkacik [Mon, 23 Feb 2015 16:14:16 +0000 (16:14 +0000)]
Merge "Startup archetype: remove 'Impl' from config subsystem Module name."

5 years agoMerge "Startup archetype: Add basic unit tests for impl."
Tony Tkacik [Mon, 23 Feb 2015 16:14:06 +0000 (16:14 +0000)]
Merge "Startup archetype: Add basic unit tests for impl."

5 years agoMerge "Startup arch - remove artifactId prefix from dir names."
Tony Tkacik [Mon, 23 Feb 2015 16:12:47 +0000 (16:12 +0000)]
Merge "Startup arch - remove artifactId prefix from dir names."

5 years agoMerge "Cleanup root pom "name"."
Tony Tkacik [Mon, 23 Feb 2015 16:08:58 +0000 (16:08 +0000)]
Merge "Cleanup root pom "name"."

5 years agoMerge "Serialize capabilities for notification properly"
Tony Tkacik [Mon, 23 Feb 2015 11:18:23 +0000 (11:18 +0000)]
Merge "Serialize capabilities for notification properly"

5 years agoMerge "BUG-2600 Proper reset caching of notifications upon disconnect"
Tony Tkacik [Mon, 23 Feb 2015 11:18:02 +0000 (11:18 +0000)]
Merge "BUG-2600 Proper reset caching of notifications upon disconnect"

5 years agoMerge "BUG-2635 Netconf monitoring for md-sal netconf northbound"
Tony Tkacik [Mon, 23 Feb 2015 11:17:50 +0000 (11:17 +0000)]
Merge "BUG-2635 Netconf monitoring for md-sal netconf northbound"

5 years agoMerge "DOMDataTree APIs"
Tony Tkacik [Mon, 23 Feb 2015 11:12:25 +0000 (11:12 +0000)]
Merge "DOMDataTree APIs"

5 years agoMerge "Update JMX generator"
Tony Tkacik [Mon, 23 Feb 2015 10:46:08 +0000 (10:46 +0000)]
Merge "Update JMX generator"

5 years agoMerge "xsql should pull junit directly"
Tony Tkacik [Mon, 23 Feb 2015 10:45:09 +0000 (10:45 +0000)]
Merge "xsql should pull junit directly"

5 years agoSerialize capabilities for notification properly 55/15555/2
Maros Marsalek [Fri, 20 Feb 2015 14:13:03 +0000 (15:13 +0100)]
Serialize capabilities for notification properly

Added and removed capabilities in capabilities change notification were serialized as QName.toString but should be na Uri

Change-Id: Id9783c060ecf45d3a7f506cf605051c779a6d21a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2600 Proper reset caching of notifications upon disconnect 29/15529/4
Maros Marsalek [Fri, 20 Feb 2015 09:40:12 +0000 (10:40 +0100)]
BUG-2600 Proper reset caching of notifications upon disconnect

Change-Id: I9269aef2fee21138b30552ffb0762d73ba98d4be
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2635 Netconf monitoring for md-sal netconf northbound 68/15468/5
Maros Marsalek [Wed, 18 Feb 2015 16:31:39 +0000 (17:31 +0100)]
BUG-2635 Netconf monitoring for md-sal netconf northbound

Monitoring for mdsal's netconf stores all available monitoring data in the datastore and provides get-schema operation

Change-Id: I573c5d57e5cf25d7688f3355b602327c7af75c65
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Migrate JMX plugin's use of BindingGeneratorUtil"
Tony Tkacik [Mon, 23 Feb 2015 10:44:52 +0000 (10:44 +0000)]
Merge "Migrate JMX plugin's use of BindingGeneratorUtil"

5 years agoMerge "Migrate deprecated guava methods"
Tony Tkacik [Mon, 23 Feb 2015 10:43:45 +0000 (10:43 +0000)]
Merge "Migrate deprecated guava methods"

5 years agoMerge "Do not override artifact versions"
Tony Tkacik [Mon, 23 Feb 2015 10:43:27 +0000 (10:43 +0000)]
Merge "Do not override artifact versions"

5 years agoMerge "Use Preconditions"
Tony Tkacik [Mon, 23 Feb 2015 10:43:13 +0000 (10:43 +0000)]
Merge "Use Preconditions"

5 years agoMerge "Do not override jsr305 version"
Tony Tkacik [Mon, 23 Feb 2015 10:43:00 +0000 (10:43 +0000)]
Merge "Do not override jsr305 version"

5 years agoFix race condition in get/get-config netconf rpcs for config subsystem 54/15554/3
Maros Marsalek [Fri, 20 Feb 2015 13:21:26 +0000 (14:21 +0100)]
Fix race condition in get/get-config netconf rpcs for config subsystem

The read and transformation of modules from config subsystem is performed in a couple of steps. Each step queried the config subsystem on its own so it was possible to cause inconsistencies among these steps if get/get-config was executed while another transaction was being committed. This race condition, if hit, caused the rpcs to fail with an exception of a missing MBean.

After recent introduction of "optional reconnect after capability changed" feature into sal-netconf-connector, this race condition caused get rpc invoked by the connector to fail.
Scenario:
odl-netconf-connector-all is installed,
after the loopback is connected any other feature with configuration is installed e.g. odl-restconf-all,
loopback connector reconnects and as it comes back executes get rpc (to query ietf-netconf-monitoring)
get rpc in config-netconf-connector fails to transform the modules into xml due to mentioned race condition as the initial config file for restconf has been pushed

Now the get/get-config read the data from a dedicated transaction started just for the read.
Note: get rpc reads the runtime beans that are part of no transaction, so there is still possibility for this race condition regarding runtime beans.

Change-Id: I0822bc48745f9f680b116095693052dff752dee3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2731: Discard changes only when transaction exist. 04/15504/5
Marian Dubai [Thu, 19 Feb 2015 16:18:14 +0000 (17:18 +0100)]
Bug 2731: Discard changes only when transaction exist.

Change-Id: I2aef83475092e75cc87d3a5edcb37e985ef132f6
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoDOMDataTree APIs 98/14998/12
Robert Varga [Thu, 5 Feb 2015 17:30:28 +0000 (18:30 +0100)]
DOMDataTree APIs

This patch introduces the end-user visible API model for interacting
with the conceptual data tree. Unlike our previous APIs, these revolve
around applications explicitly binding their inputs (former data change
listeners) and outputs (former explicit writes). This allows efficient
inter-datastore interactions to be maintained by understanding what
sort of output applications make and what sort of indexes are required
to feed them the data they require. Beryllium evolution will see the
DOMDataTreeListener being subscribed to an XQuery expression, thus
providing a dense definition of what data the applciation actually
extracts out of the subtree.

Change-Id: I11446ce7f8dbd7cf61540f72e463460b483ff15f
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2635 Prepare netconf monitoring service for md-sal monitoring. 54/15254/8
Maros Marsalek [Fri, 13 Feb 2015 12:32:17 +0000 (13:32 +0100)]
BUG-2635 Prepare netconf monitoring service for md-sal monitoring.

So that the monitoring service provides all the information in one place.

Also move get-schema rpc into netconf-monitoring from netconf-impl.

Change-Id: Ia7dc47ea4997df417795f079a7c045709dbaaf47
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoRemove required source element from Get operation for MDSAL 96/15496/4
Maros Marsalek [Thu, 19 Feb 2015 12:53:38 +0000 (13:53 +0100)]
Remove required source element from Get operation for MDSAL

Change-Id: I2c1495dfac8ecad00605f4df98b310b3d99ac4ed
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Make reconnect on capability changed truly optional"
Tony Tkacik [Mon, 23 Feb 2015 08:50:12 +0000 (08:50 +0000)]
Merge "Make reconnect on capability changed truly optional"

5 years agoMerge "Prevent multiple config pushers"
Tony Tkacik [Mon, 23 Feb 2015 08:49:48 +0000 (08:49 +0000)]
Merge "Prevent multiple config pushers"

5 years agoBUG 2741 : Fix issue with real snapshotting when replicatedToAllIndex=-1 04/15604/2
Moiz Raja [Sun, 22 Feb 2015 18:17:44 +0000 (10:17 -0800)]
BUG 2741 : Fix issue with real snapshotting when replicatedToAllIndex=-1

Change-Id: I59b236fd88a329021365f204077170ca260e0b32
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoUse Config Admin to overlay datastore properties 85/15485/11
tpantelis [Wed, 18 Feb 2015 12:37:53 +0000 (07:37 -0500)]
Use Config Admin to overlay datastore properties

Added functionality to configure DatastoreContext settings via a
properties file, org.opendaylight.controller.cluster.datastore.cfg, in the karaf
etc dir. The properties are overlayed onto the DatastoreContext that is
initialized via the config yang XML file. This allows for separation of
the wiring in the config yang XML from the user-facing config settings
to facilitate preserving the user-facing config settings on upgrade
while applying wiring changes.

The DatastoreContextIntrospector class is responsible for applying the
property key/values obtained from the Config Admin Configuration to the
current DatastoreContext.

The DatastoreContextConfigAdminOverlay class interfaces with the
ConfigurationAdmin OSGi service to obtain the configuration and calls
into the DatastoreContextIntrospector.

Modified DatastoreContext.Builder to support loading from an existing
DatastoreContext instance and applying changes to it to yield a new
instance on build.

Added a DatastoreConfigurationMXBean that reports the DatastoreContext
settings via JXM. This is useful to see what settings are currently
applied.

Most of the other changes were to wire the new classes from the Module
class to the DistributedDatastore.

Added new unit tests to cover the new code.

Change-Id: I9427907dac576bd416bad677a56fa8259af59a09
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
5 years agoMerge "Bug 2597: Batch modification operations in TransactionProxy"
Moiz Raja [Wed, 25 Feb 2015 00:52:17 +0000 (00:52 +0000)]
Merge "Bug 2597: Batch modification operations in TransactionProxy"

5 years agoMerge "Create odl-nsf-service feature, which excludes neutron feature"
Ed Warnicke [Tue, 24 Feb 2015 20:00:10 +0000 (20:00 +0000)]
Merge "Create odl-nsf-service feature, which excludes neutron feature"

5 years agoFix spurious failures in RaftActorTest due to RecoveryComplete 99/15599/2
tpantelis [Fri, 20 Feb 2015 10:23:09 +0000 (05:23 -0500)]
Fix spurious failures in RaftActorTest due to RecoveryComplete

testSaveSnapshotSuccessCallsDataPersistence fails sporadically due
to RecoveryComplete interfering with the test. In
handleCaptureSnapshotReply it sets replicatedToAllIndex in the
behavior. On RecoveryCompleted, it initializes the behavior which
creates a new Follower with replicatedToAllIndex initialized to -1.
Recovery is done asyn so if RecoveryCompleted occurs after
CaptureSnapshotReply, the test fails because replicatedToAllIndex
isn't the expected value.

We need to call waitForInitializeBehaviorComplete after creating the
MockRaftActor so recovery and behavior initialization is complete before
starting the tests.

Change-Id: I3176afbf7ac937550c33bdb57d14d6968dbc2514
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Fix RaftActorTest.testRaftRoleChangeNotifier failure"
Moiz Raja [Sat, 21 Feb 2015 21:45:00 +0000 (21:45 +0000)]
Merge "Fix RaftActorTest.testRaftRoleChangeNotifier failure"

5 years agoBUG 2733 : Leader should always schedule heartbeats 76/15476/5
Moiz Raja [Wed, 18 Feb 2015 20:33:53 +0000 (12:33 -0800)]
BUG 2733 : Leader should always schedule heartbeats

This ensures that lagging or new followers are not starved as this
can potentially destabilize the cluster

Change-Id: Ic83d9d595a1222550286f3eb29d4cdef7bf1bccd
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 2597: Batch modification operations in TransactionProxy 95/15095/7
tpantelis [Sun, 8 Feb 2015 17:17:16 +0000 (12:17 -0500)]
Bug 2597: Batch modification operations in TransactionProxy

Modified TransactionContextImpl to batch write, merge, delete modification
operations into a single BatchedModifications message and send the batch when a
count threshold is reached.

Instead of using the current WriteData, MergeData, DeleteData message classes
in BatchedModifications, I reused the Modification classes that are used
as the payload for peristence and replication. BatchedModifications
derives from MutableCompositeModification.

The ShardWriteTransaction now simply transfers the Modification
instances in the BatchedModifications instance to its internal
MutableCompositeModification and applies the Modifications to its
transaction.

The Modification classes were refactored a little wrt to versioning.
The Write/Merge/DeleteModifications no longer read/write the version
from the stream. The version is read/written by MutableCompositeModification
so it's redundant to also do so in the data Modification classes.

The WriteData, MergeData, DeleteData and associated reply classes were
deprecated. I did refactor them a little (along with ReadDataReply) as I
was originally going to use them. The VersionedSerializableMessage interface
was removed as I realized it makes more sense to pass the version in the WriteData,
MergeData, DeleteData constructors instead of passing the version via
toSerializable. This made it easier in TransactionContextImpl to transition it
to use BatchedModifications. I created a VersionedExternalizableMessage
base class that reads/write the version.

To handle backwards compatibility with Helium, I derived a
LegacyTransactionContextImpl class from TransactionContextImpl that overrides
writeData, mergeData and deleteData to send WriteData, MergeData,
DeleteData messages. TransactionProxy creates this instance if the
remote tx versions is < Lithium version.

Change-Id: I28df1f89e97667eaca114b991355a6e9d0160a59
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBUG 2676 : Use notification-dispatcher for DataChangeListener actors 96/15596/1
Moiz Raja [Sat, 21 Feb 2015 17:59:06 +0000 (09:59 -0800)]
BUG 2676 : Use notification-dispatcher for DataChangeListener actors

Change-Id: I154e1598a3058a978902fd6db5512d51dff36a62
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2676 : Use transaction-dispatcher for ShardTransaction 95/15595/1
Moiz Raja [Sat, 21 Feb 2015 17:19:14 +0000 (09:19 -0800)]
BUG 2676 : Use transaction-dispatcher for ShardTransaction

Change-Id: If70e141ff4e0eae0bd41ba70d4b0c126eb752fa1
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2676 : Use shard-dispatcher for ShardManager and Shard actors 94/15594/1
Moiz Raja [Sat, 21 Feb 2015 17:00:42 +0000 (09:00 -0800)]
BUG 2676 : Use shard-dispatcher for ShardManager and Shard actors

Change-Id: Ib6aed392eb861bb1da16d4780f08b27fad6d17db
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2676 : Use custom client-dispatcher when configured 93/15593/1
Moiz Raja [Sat, 21 Feb 2015 16:43:33 +0000 (08:43 -0800)]
BUG 2676 : Use custom client-dispatcher when configured

Use a client dispatcher for all code which originates at the client
end and requires a dispatcher for completion of a Future that was
created by an ask

Change-Id: If2c1fa064e368152539ad21622985cc044f305d3
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoRe-enable running of SingleFeaturesTest 90/15590/1
Ed Warnicke [Sat, 21 Feb 2015 16:41:33 +0000 (09:41 -0700)]
Re-enable running of SingleFeaturesTest

For reasons I have not yet figured out, depending on the
yangtools version of features-test causes features tests
to no longer run.  This patch changes controller
to depending on the features-tests from odlparent

Change-Id: I45397f042cc367addde2ada74a27aba98fc98126
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoBUG 2676 : Introduce API for accessing akka dispatchers 92/15592/1
Moiz Raja [Sat, 21 Feb 2015 14:58:33 +0000 (06:58 -0800)]
BUG 2676 : Introduce API for accessing akka dispatchers

Change-Id: I2a9b0f0848da1a6181a3e6c8d61d0d96499a61d0
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2718 : Create a diagnostic utility to track append entries replies 81/15581/2
Moiz Raja [Sat, 21 Feb 2015 01:59:40 +0000 (17:59 -0800)]
BUG 2718 : Create a diagnostic utility to track append entries replies

This patch introduces a utility to keep track of all messages that were
processed between the time a certain message is received. It is used for
tracking why AppendEntriesReply do not come in a timely manner. This is
important to know because if a leader will switch to IsolatedLeader if
these messages do not arrive within the ElectionTimeout interval causing
disruption in service.

Change-Id: I13bab798aad8a225d22d2ebd3775cbf0bf1d1592
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Fix for Bug 2727 - Upgrade Akka from 2.3.4 to 2.3.9"
Tom Pantelis [Sat, 21 Feb 2015 13:36:49 +0000 (13:36 +0000)]
Merge "Fix for Bug 2727 - Upgrade Akka from 2.3.4 to 2.3.9"

5 years agoUpdate JMX generator 38/15538/2
Robert Varga [Fri, 20 Feb 2015 11:09:37 +0000 (12:09 +0100)]
Update JMX generator

This takes advantage of the fact maven 3.1.1 supports slf4j natively.
Also fixup some of the coding style issues still present.

Change-Id: I37724cc0a5c194fc333c577f39deaf550c341d34
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoxsql should pull junit directly 89/15589/1
Robert Varga [Sat, 21 Feb 2015 10:20:45 +0000 (11:20 +0100)]
xsql should pull junit directly

Currently we pull junit transitively, which means it will break once the
transitive dependencies change.

Change-Id: I50ad5143811fb21d4719bd47085f366899ae7409
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "BUG 2702 : Switch to a low impact scheduling mechanism for IsolatedLeaderCheck"
Tom Pantelis [Sat, 21 Feb 2015 05:18:44 +0000 (05:18 +0000)]
Merge "BUG 2702 : Switch to a low impact scheduling mechanism for IsolatedLeaderCheck"

5 years agoMerge "BUG 2676 : Add a diagnostic log message to detect delay in ApplyState processing"
Tom Pantelis [Sat, 21 Feb 2015 05:17:41 +0000 (05:17 +0000)]
Merge "BUG 2676 : Add a diagnostic log message to detect delay in ApplyState processing"

5 years agoMerge "Revert "BUG-2637: migrate features""
Ed Warnicke [Sat, 21 Feb 2015 05:09:23 +0000 (05:09 +0000)]
Merge "Revert "BUG-2637: migrate features""

5 years agoRevert "BUG-2637: migrate features" 88/15588/1
Ed Warnicke [Sat, 21 Feb 2015 04:34:14 +0000 (04:34 +0000)]
Revert "BUG-2637: migrate features"

This reverts commit 300d247c3c68387bf0bed3fc9dd90558ebe01f3f.

300d247c3c68387bf0bed3fc9dd90558ebe01f3f broke because the flow-features were not migrated properly to openflowplugin.

Change-Id: I6502a93b10b4c5ee41d037da216092cdf003d17f
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoMerge "BUG-2637: migrate features"
Anil Vishnoi [Fri, 20 Feb 2015 20:01:18 +0000 (20:01 +0000)]
Merge "BUG-2637: migrate features"

5 years agoBUG 2702 : Switch to a low impact scheduling mechanism for IsolatedLeaderCheck 48/15548/3
Moiz Raja [Fri, 20 Feb 2015 12:37:46 +0000 (04:37 -0800)]
BUG 2702 : Switch to a low impact scheduling mechanism for IsolatedLeaderCheck

Using the akka scheduler's schedule mechanism to schedule tasks can cause
disruption in processing messages as scheduled messages can get processed before
other messages. To avoid this we now generate an isolated leader check from
the heartbeat processor and avoid an extra scheduled task.

Change-Id: Ied6b518796da92742e2c61eebcd1e0a3415df66a
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2676 : Add a diagnostic log message to detect delay in ApplyState processing 47/15547/3
Moiz Raja [Fri, 20 Feb 2015 12:15:27 +0000 (04:15 -0800)]
BUG 2676 : Add a diagnostic log message to detect delay in ApplyState processing

Log a message when ApplyState is processed 50 milliseconds after being generated

Change-Id: I7e101dab292b4a72d23904798dc2362a740e4c04
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "BUG 2676 : Add more context to the Initiate snapshot capture log message"
Tom Pantelis [Fri, 20 Feb 2015 19:18:47 +0000 (19:18 +0000)]
Merge "BUG 2676 : Add more context to the Initiate snapshot capture log message"

5 years agoMerge "BUG 2676 : Reduce default logging in Dummy Data Store"
Tom Pantelis [Fri, 20 Feb 2015 19:17:17 +0000 (19:17 +0000)]
Merge "BUG 2676 : Reduce default logging in Dummy Data Store"

5 years agoCreate odl-nsf-service feature, which excludes neutron feature 66/15566/1
Flavio Fernandes [Fri, 20 Feb 2015 19:16:19 +0000 (14:16 -0500)]
Create odl-nsf-service feature, which excludes neutron feature

Deprecated neutron interfaces in controller, as they are now moved to the neutron repo.

With this change, odl-nsf-service provides an upgrade path, so that projects can migrate to the new neutron
feature w/out changing the other features associated with the soon to be retired odl-nsf-all.

The new neutron features are available via: odl-neutron-service

Change-Id: Ifabf60e62d1f8c512165a8d32d25093e13ff9107
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
5 years agoMerge "BUG 2676 : Add diagnostic message when AppendEntriesReply comes in very late"
Tom Pantelis [Fri, 20 Feb 2015 19:16:09 +0000 (19:16 +0000)]
Merge "BUG 2676 : Add diagnostic message when AppendEntriesReply comes in very late"

5 years agoMerge "BUG 2676 : Add some tuning parameters to improve performance of CDS"
Tom Pantelis [Fri, 20 Feb 2015 19:14:47 +0000 (19:14 +0000)]
Merge "BUG 2676 : Add some tuning parameters to improve performance of CDS"

5 years agoBUG-2637: migrate features 64/14464/10
Michal Rehak [Fri, 23 Jan 2015 21:12:26 +0000 (22:12 +0100)]
BUG-2637: migrate features

 - remove migrated features
 - integration test fix:
   - commented out dependencies to models affected by migration
   - adapted sal-binding-it in order not to push those models
     into pax-exam context
   - adapted sal-binding-broker-impl to use those models only in
     test scope
 - cleaned commented code/config

Change-Id: I8e09a7cd9ff9ba0f041abe1bf739be755aed3e8d
Signed-off-by: Michal Rehak <mirehak@cisco.com>
5 years agoBUG 2676 : Add more context to the Initiate snapshot capture log message 46/15546/2
Moiz Raja [Fri, 20 Feb 2015 11:57:36 +0000 (03:57 -0800)]
BUG 2676 : Add more context to the Initiate snapshot capture log message

Add more context in the Initiate snapshot capture log message so that when
a snapshot capture occurs due to lack of memory we can get a little more
detail from the logs.

Change-Id: I85647adcf74d7eb36f767ba5dd6824e64a802811
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2676 : Reduce default logging in Dummy Data Store 43/15543/2
Moiz Raja [Fri, 20 Feb 2015 11:49:03 +0000 (03:49 -0800)]
BUG 2676 : Reduce default logging in Dummy Data Store

Reduce the default log level to error and added a diagnostic
log message to detect situations where an append entries does
not get sent in a reasonable amount of time (5 seconds)

Change-Id: I46b7b20688207318dcfec2b209519761ecf1d93d
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2676 : Add diagnostic message when AppendEntriesReply comes in very late 42/15542/2
Moiz Raja [Fri, 20 Feb 2015 11:38:18 +0000 (03:38 -0800)]
BUG 2676 : Add diagnostic message when AppendEntriesReply comes in very late

Log an error message when an AppendEntriesReply arrives beyond the ElectionTimeout
period. This may help detect cases where messages are not being processed
fast enough by the actor system. This particular condition can cause a Leader to
become an IsolatedLeader even if the remote Follower is receiving heartbeats.

Change-Id: Id6a797820b63cb4f18c3d1bbd2781e72674aa9d8
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMigrate JMX plugin's use of BindingGeneratorUtil 41/15541/1
Robert Varga [Fri, 20 Feb 2015 11:45:15 +0000 (12:45 +0100)]
Migrate JMX plugin's use of BindingGeneratorUtil

The functionality was moved to BindingMapping, so migrate this user.

Change-Id: I23581636182b1e63a82d8b50595c5aba5e5ffc5a
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG 2676 : Add some tuning parameters to improve performance of CDS 36/15536/1
Moiz Raja [Fri, 20 Feb 2015 11:20:38 +0000 (03:20 -0800)]
BUG 2676 : Add some tuning parameters to improve performance of CDS

Added two parameters,
- throughput = 1 this is to make the dispatcher fair, which helps in preventing
  actor starvation
- SingleConsumerOnlyUnboundedMailbox which is a more efficient and recommended
  Mailbox to use in our case

I've tested both these settings and they seem to work pretty well and do not
contribute to destabilization

Change-Id: I5072f7dad7ad862eaafaada3e88d78600fb3665d
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2734 : Use the 95th percentile number to determine backpressure 35/15535/1
Moiz Raja [Fri, 20 Feb 2015 10:53:20 +0000 (02:53 -0800)]
BUG 2734 : Use the 95th percentile number to determine backpressure

When running tests with OpenFlow I see the following transaction completion
times consistently for 127 and 255 switches with statistics on.

50% - 5-6 ms
75% - 7-8 ms
95% - 20-60 ms
98% - 100-160 ms

By using the 95th percentile number to determine transaction creation backpressure
we can safely increase our throughput without causing timeouts due to outliers.

Change-Id: I0d9739b3045afb389583f2dd18ac431215a28f84
Signed-off-by: Moiz Raja <moraja@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.