controller.git
7 years agoMerge "Fix a typo in javadoc"
Tony Tkacik [Fri, 7 Nov 2014 10:29:10 +0000 (10:29 +0000)]
Merge "Fix a typo in javadoc"

7 years agoMerge "Bug 2233 - RPC register exception when rpc has no input"
Tony Tkacik [Fri, 7 Nov 2014 10:18:49 +0000 (10:18 +0000)]
Merge "Bug 2233 - RPC register exception when rpc has no input"

7 years agoMerge "BUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance...
Tony Tkacik [Fri, 7 Nov 2014 10:12:42 +0000 (10:12 +0000)]
Merge "BUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance attribute with namespaces"

7 years agoMerge "Fix logback-config warnings"
Tony Tkacik [Fri, 7 Nov 2014 10:06:13 +0000 (10:06 +0000)]
Merge "Fix logback-config warnings"

7 years agoMerge "Remove duplicate groupId"
Tony Tkacik [Fri, 7 Nov 2014 10:06:00 +0000 (10:06 +0000)]
Merge "Remove duplicate groupId"

7 years agoMerge "Fix warnings in netconfig-netty-util"
Tony Tkacik [Fri, 7 Nov 2014 10:05:48 +0000 (10:05 +0000)]
Merge "Fix warnings in netconfig-netty-util"

7 years agoMerge "Fix warnings in netconfig-monitoring"
Tony Tkacik [Fri, 7 Nov 2014 10:05:34 +0000 (10:05 +0000)]
Merge "Fix warnings in netconfig-monitoring"

7 years agoMerge "Fix cluster test warnings"
Tony Tkacik [Fri, 7 Nov 2014 10:05:22 +0000 (10:05 +0000)]
Merge "Fix cluster test warnings"

7 years agoMerge "Add serialversionUUID to cluster/datastore/modification"
Tony Tkacik [Fri, 7 Nov 2014 10:05:04 +0000 (10:05 +0000)]
Merge "Add serialversionUUID to cluster/datastore/modification"

7 years agoMerge "Fix raw Class in sal-distributed-datastore messages"
Tony Tkacik [Fri, 7 Nov 2014 10:04:46 +0000 (10:04 +0000)]
Merge "Fix raw Class in sal-distributed-datastore messages"

7 years agoMerge "Fix warnings in clustering"
Tony Tkacik [Fri, 7 Nov 2014 10:03:58 +0000 (10:03 +0000)]
Merge "Fix warnings in clustering"

7 years agoMerge "Fix warnings in config-manager"
Tony Tkacik [Fri, 7 Nov 2014 10:03:30 +0000 (10:03 +0000)]
Merge "Fix warnings in config-manager"

7 years agoMerge "Fix warnings in config-util"
Tony Tkacik [Fri, 7 Nov 2014 10:01:01 +0000 (10:01 +0000)]
Merge "Fix warnings in config-util"

7 years agoMerge "Fix warnings in neconf-util"
Tony Tkacik [Fri, 7 Nov 2014 10:00:48 +0000 (10:00 +0000)]
Merge "Fix warnings in neconf-util"

7 years agoMerge "Fix warnings in config-api tests"
Tony Tkacik [Fri, 7 Nov 2014 10:00:01 +0000 (10:00 +0000)]
Merge "Fix warnings in config-api tests"

7 years agoMerge "Do not override managed versions"
Tony Tkacik [Fri, 7 Nov 2014 09:59:34 +0000 (09:59 +0000)]
Merge "Do not override managed versions"

7 years agoFix a typo in javadoc 79/12579/1
Robert Varga [Thu, 6 Nov 2014 14:30:54 +0000 (15:30 +0100)]
Fix a typo in javadoc

Simple typo.

Change-Id: I9934e8674b0bb9c2dc8a28dcb189c213e7709cb9
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix logback-config warnings 70/12570/1
Robert Varga [Thu, 6 Nov 2014 12:40:50 +0000 (13:40 +0100)]
Fix logback-config warnings

We do not need to use raw types, so use proper generic arguments.

Change-Id: Ifcbce1eb924067db8077f43246f33e3f2ae746bb
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove duplicate groupId 69/12569/1
Robert Varga [Thu, 6 Nov 2014 12:39:52 +0000 (13:39 +0100)]
Remove duplicate groupId

Specified groupId is the same as parent's -- so we do not need to
re-declare it.

Change-Id: I7610f6f4bbc4b303b0f3b6971822f8e715bf1a2e
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix warnings in netconfig-netty-util 57/12557/2
Robert Varga [Thu, 6 Nov 2014 10:48:33 +0000 (11:48 +0100)]
Fix warnings in netconfig-netty-util

Removes the use of deprecated junit classes and raw types.

Change-Id: Ibde538ae563a82a89b865d1ef9303a6e24a026f5
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix warnings in netconfig-monitoring 56/12556/2
Robert Varga [Thu, 6 Nov 2014 10:48:03 +0000 (11:48 +0100)]
Fix warnings in netconfig-monitoring

Removes the use of deprecated junit classes and raw types.

Change-Id: I594f2cc10771d8a5291cbab3f651a6fb01ac7a4c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix cluster test warnings 55/12555/3
Robert Varga [Thu, 6 Nov 2014 10:11:36 +0000 (11:11 +0100)]
Fix cluster test warnings

Remove use of raw types, suppress serialVersionUUID warnings and the use
of deprecated junit classes.

Change-Id: I14f8e28b4bd27944b7001cbc1018479ae7b24f12
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoAdd serialversionUUID to cluster/datastore/modification 54/12554/3
Robert Varga [Thu, 6 Nov 2014 10:16:41 +0000 (11:16 +0100)]
Add serialversionUUID to cluster/datastore/modification

Serializable classes need to define this field. Also fixes the use of
raw NormalizedNode type.

Change-Id: I674b57d0eea60c1e015cd35eba6c407d29826216
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix raw Class in sal-distributed-datastore messages 53/12553/3
Robert Varga [Thu, 6 Nov 2014 10:06:51 +0000 (11:06 +0100)]
Fix raw Class in sal-distributed-datastore messages

Fixes the use of Class in the messages. Also makes sure exported
constants are really constant.

Change-Id: Ibc0f688e95e8a2c26d30407897aaf7c51323032e
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix warnings in clustering 52/12552/2
Robert Varga [Thu, 6 Nov 2014 10:03:05 +0000 (11:03 +0100)]
Fix warnings in clustering

Fixes the use of raw types.

Change-Id: I06d7935e6686bfceb3c574c9465a76adff2c825c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix warnings in config-manager 51/12551/2
Robert Varga [Thu, 6 Nov 2014 10:01:16 +0000 (11:01 +0100)]
Fix warnings in config-manager

Fix the use of raw types, unnecessary casts and use of deprecated junit
classes.

Change-Id: I137793ccf28f62b0e477f6042293b8c3a50e98fe
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix warnings in config-util 50/12550/2
Robert Varga [Thu, 6 Nov 2014 09:59:52 +0000 (10:59 +0100)]
Fix warnings in config-util

Fix use of deprecated junit classes and unused imports.

Change-Id: I5262ac6e870edbd83d86cd56ecfc08c17eee1490
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix warnings in neconf-util 49/12549/2
Robert Varga [Thu, 6 Nov 2014 09:56:53 +0000 (10:56 +0100)]
Fix warnings in neconf-util

Remove use of raw types, unnecessary casts and use of deprecated junit
classes.

Change-Id: If7fb8b107a5b3086dc5f37d495def7db17363ced
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix warnings in config-api tests 48/12548/2
Robert Varga [Thu, 6 Nov 2014 09:55:01 +0000 (10:55 +0100)]
Fix warnings in config-api tests

Move to non-deprecated classes and fix the use of raw types.

Change-Id: I9ef7d36d1f294b634787738292deedc2546d4097
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoDo not override managed versions 47/12547/2
Robert Varga [Thu, 6 Nov 2014 09:52:49 +0000 (10:52 +0100)]
Do not override managed versions

Versions managed by parent, no need to specify them.

Change-Id: I70718711d3894c5edc6fd9ac66c453165124cac6
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoQuickfix: Changed used feature to odl-aaa-netconf-plugin 59/12559/3
Tony Tkacik [Thu, 6 Nov 2014 11:41:44 +0000 (12:41 +0100)]
Quickfix: Changed used feature to odl-aaa-netconf-plugin

AAA project renamed their netconf related feature without
introducing proper patchset into controller. This fixes
features.xml to reference properly new feature.

Change-Id: Ic0d512804a87f20f058462541cd061f83a8f52e7
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoMerge "Remove l2switch sample"
Tony Tkacik [Thu, 6 Nov 2014 08:20:06 +0000 (08:20 +0000)]
Merge "Remove l2switch sample"

7 years agoBUG 2090 : Clustering : Bring akka-raft unit test coverage upto 80% 22/12522/1
Moiz Raja [Thu, 16 Oct 2014 23:51:46 +0000 (16:51 -0700)]
BUG 2090 : Clustering : Bring akka-raft unit test coverage upto 80%

Change-Id: I7b2b16aa42b655e924942f356602c64ccf6d86b7
Signed-off-by: Moiz Raja <moizr@dhcp-10-154-140-127.cisco.com>
7 years agoBUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance attrib... 86/12286/3
Maros Marsalek [Wed, 5 Nov 2014 13:29:55 +0000 (14:29 +0100)]
BUG-2254 Make runtime rpcs in config subsystem/netconf handle context-instance attribute with namespaces

Change-Id: I9ca4accdb10ba5a6b52ce9b8f7ad02a8cbe8743d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "Fix for Bug 2290."
Devin Avery [Tue, 4 Nov 2014 20:07:31 +0000 (20:07 +0000)]
Merge "Fix for Bug 2290."

7 years agoMerge "Introduce a benchmark for databroker"
Tony Tkacik [Tue, 4 Nov 2014 12:11:52 +0000 (12:11 +0000)]
Merge "Introduce a benchmark for databroker"

7 years agoBug 2337: Fix Tx already sealed failure on Tx commit 81/12581/2
tpantelis [Sat, 1 Nov 2014 21:55:34 +0000 (17:55 -0400)]
Bug 2337: Fix Tx already sealed failure on Tx commit

Details outlined in bug 2337.

Moved the publishing of the TransactonContext instance in
TransactionFutureCallback#onComplete after the cached operations are
executed.

Also fixed a timing issue in
DistributedDataStoreIntegrationTest#testChangeListenerRegistration that
caused intermittent failures. This was an issue with the test. The
listener registration is done async in the shard so the notification for
the first write commit could occur in the initial notification on
registration which screwed up the test. So I moved the first write
commit before the registration so we expect an initial notification.

Change-Id: Ied2af93be8165208b853c48e57312c3a5acbdaea
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoMerge "Bug 2318: Ensure previous Tx in chain is readied before creating the next"
Moiz Raja [Thu, 6 Nov 2014 23:17:04 +0000 (23:17 +0000)]
Merge "Bug 2318: Ensure previous Tx in chain is readied before creating the next"

7 years agoBUG 2325 : Value type of byte[] not recognized by the NormalizedNodeSerializer 40/12540/2
Moiz Raja [Wed, 5 Nov 2014 19:09:06 +0000 (11:09 -0800)]
BUG 2325 : Value type of byte[] not recognized by the NormalizedNodeSerializer

Change-Id: I16eab6cdbf7712624f2c1fafb5bf41107b6ae379
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 819b04091a3d4d96612a1036228638a3b4e85d09)

7 years agoBug 2318: Ensure previous Tx in chain is readied before creating the next 35/12535/2
tpantelis [Sat, 1 Nov 2014 08:10:20 +0000 (04:10 -0400)]
Bug 2318: Ensure previous Tx in chain is readied before creating the next

In TransactionChainProxy, subclassed TransactionProxy (ChainedTransactionProxy)
to hook into the TransactionProxy to capture the cohort Futures on ready
and to customize the returned create shard Tx Future.

The previous Tx's ready Futures are captured and cached in the enclosing
TransactionChainProxy instance. When the client creates the next Tx in
the chain, the Future from the shard Tx create message is wrapped by a
sequence Future that combines all the previous ready Futures. Thus, when
the previous ready Futures complete, the shard Tx create is sent and
that Future is used to complete the returned Promise.

Change-Id: If002e4d705510aee3f560c506318d25f386768e5
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoIntroduce a benchmark for databroker 08/12408/3
Robert Varga [Tue, 7 Oct 2014 18:08:12 +0000 (20:08 +0200)]
Introduce a benchmark for databroker

Change-Id: Ica44433b1dd1c863e1c255cc5ec297c56e705fd8
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix for Bug 2290. 30/12430/1
Ryan Moats [Fri, 31 Oct 2014 22:14:01 +0000 (17:14 -0500)]
Fix for Bug 2290.

Wrap existing IPv4 code with version test.
Add new IPv6 code with version test.

Change-Id: I30ed4c510dbc79f3e40cdafea4dd46cf37a20f39
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoRemove l2switch sample 98/12398/2
Robert Varga [Fri, 31 Oct 2014 11:14:36 +0000 (12:14 +0100)]
Remove l2switch sample

This sample is openflow-specific and creates confusion with the l2switch
project. Remove it.

Change-Id: I03b08bbe08c98c0bd712470c4fb2c29ba65467a3
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBug 2233 - RPC register exception when rpc has no input 01/12401/1
Jan Hajnar [Fri, 31 Oct 2014 12:59:08 +0000 (13:59 +0100)]
Bug 2233 - RPC register exception when rpc has no input

* added check that should prevent non routed Rpcs being treated as
routed and and failing at context resolution.

Change-Id: I281152879429f2020f48894753f1d57aea85bde6
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
7 years agoMerge "BUG-1953: fix SAL compatility layer"
Tony Tkacik [Fri, 31 Oct 2014 12:57:24 +0000 (12:57 +0000)]
Merge "BUG-1953: fix SAL compatility layer"

7 years agoMerge "Bug 2065 - fixed typo in leaf name"
Tony Tkacik [Fri, 31 Oct 2014 10:19:45 +0000 (10:19 +0000)]
Merge "Bug 2065 - fixed typo in leaf name"

7 years agoFix intermittent failure in DataChangeListenerTest 60/12460/1
tpantelis [Fri, 31 Oct 2014 06:12:10 +0000 (02:12 -0400)]
Fix intermittent failure in DataChangeListenerTest

Fixed an intermittent failure in testDataChangedWithNoSender due to timing if a
DeadLetter is received due to the Monitor message being dropped as the
unit tests don't set up the termination monitor actor. The test expects
no DeadLetter for DataChangedReply so added chanhes to ignore
DeadLetters for other messages.

Change-Id: I39ddc888de7fbff9201ac9f785baa6fec7cb8f2c
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoBUG 2296 : TransactionProxy should support the ability to accept a local TPC actor... 51/12451/1
Moiz Raja [Sun, 2 Nov 2014 16:14:03 +0000 (08:14 -0800)]
BUG 2296 : TransactionProxy should support the ability to accept a local TPC actor path

In Helium when the ShardTransaction processes a Ready message it sends back a the path of a ThreePhaseCommitCohort actor in the ReadyReply. This path is actually a local actor path, this local actor path is then converted into a remote path by the TransactionProxy.

The fix for Bug 1607 breaks this capability which is required to support forward compatibility in a cluster where a transaction request originates in a node that has been upgraded to Helium-1 and the actual transaction is happening on a node which has not yet been upgraded to Helium-1.

Change-Id: I857384bdd61b3492ea270dcf04d14883811c37c2
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoMerge "Bug 2294: Handle Shard backwards compatibility"
Moiz Raja [Sun, 2 Nov 2014 21:48:34 +0000 (21:48 +0000)]
Merge "Bug 2294: Handle Shard backwards compatibility"

7 years agoMerge "Bug 2134: Fix intermittent RaftActorTest failure"
Moiz Raja [Sat, 1 Nov 2014 20:33:07 +0000 (20:33 +0000)]
Merge "Bug 2134: Fix intermittent RaftActorTest failure"

7 years agoBUG 2134 : Make persistence configurable at the datastore level 52/12352/5
Moiz Raja [Fri, 17 Oct 2014 23:42:41 +0000 (16:42 -0700)]
BUG 2134 : Make persistence configurable at the datastore level

- Added a peristent flag in the config sub-system
- If persistent in not true then we ignore recovery messages and not use the
  akka persistence apis for persisting anything
- The unit tests
    - assume that persistence is on by default (which it is)
    - test that if recovery is applicable only then the ShardManager and RaftActor process the recovoery messages.
    - test that when persisting the data-persistence API is used in the appropriate places (see RaftActorTest/ShardManagerTest)

Change-Id: I19913bcd32e609ccde6ad8e35209788315504426
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoBug 2065 - fixed typo in leaf name 81/12381/1
Martin Bobak [Thu, 30 Oct 2014 13:54:14 +0000 (14:54 +0100)]
Bug 2065 - fixed typo in leaf name

Change-Id: I9f0f201078ffc3d7c08f57108b4d113f87df9ac4
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoBug 2294: Handle Shard backwards compatibility 44/12444/2
tpantelis [Thu, 30 Oct 2014 11:30:32 +0000 (07:30 -0400)]
Bug 2294: Handle Shard backwards compatibility

Implemented as outlined in Bug 2294.

Change-Id: I14aa8ef5f320f9d165492396ece4ea63cce9b0c3
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoMerge "Bug 2055: Handle Tx create in TransactionProxy resiliently"
Moiz Raja [Thu, 30 Oct 2014 01:59:53 +0000 (01:59 +0000)]
Merge "Bug 2055: Handle Tx create in TransactionProxy resiliently"

7 years agoBug 2134: Fix intermittent RaftActorTest failure 29/12429/1
tpantelis [Wed, 29 Oct 2014 16:05:05 +0000 (12:05 -0400)]
Bug 2134: Fix intermittent RaftActorTest failure

We need to wait for akka's recovery to complete before we perform our
tests as akka's recovery runs async and may interfere with our tests and
cause them to fail if the timing is right. This was seen once on
jenkins.

Change-Id: Ia748d17f662d64235881005e6522441b384c78ea
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoMerge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"
Devin Avery [Wed, 29 Oct 2014 14:17:58 +0000 (14:17 +0000)]
Merge "Cosmetics: check in pom.xml files as _sort_pom_ wants them to be"

7 years agoCosmetics: check in pom.xml files as _sort_pom_ wants them to be 12/12312/1
Flavio Fernandes [Wed, 29 Oct 2014 10:07:12 +0000 (06:07 -0400)]
Cosmetics: check in pom.xml files as _sort_pom_ wants them to be

Change-Id: I08fc2c0284e0396605cec7d218ea4470a312bfc8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
7 years agoMerge "Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools...
Moiz Raja [Wed, 29 Oct 2014 09:00:27 +0000 (09:00 +0000)]
Merge "Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools interface"

7 years agoMerge "Bug 2252: Terminate ShardWriteTransaction actor on ready"
Moiz Raja [Wed, 29 Oct 2014 08:59:51 +0000 (08:59 +0000)]
Merge "Bug 2252: Terminate ShardWriteTransaction actor on ready"

7 years agoMerge "BUG 2221 : Add metering to ShardTransaction actor"
Moiz Raja [Wed, 29 Oct 2014 03:05:09 +0000 (03:05 +0000)]
Merge "BUG 2221 : Add metering to ShardTransaction actor"

7 years agoMerge "Bug 2086: Adding normalized node stream reader and writer."
Tom Pantelis [Tue, 28 Oct 2014 15:55:45 +0000 (15:55 +0000)]
Merge "Bug 2086: Adding normalized node  stream reader and writer."

7 years agoMerge "BUG-2195 Enable features test for netconf connector"
Tony Tkacik [Tue, 28 Oct 2014 11:46:23 +0000 (11:46 +0000)]
Merge "BUG-2195 Enable features test for netconf connector"

7 years agoBUG-2195 Enable features test for netconf connector 34/12234/5
Maros Marsalek [Fri, 24 Oct 2014 13:06:47 +0000 (15:06 +0200)]
BUG-2195 Enable features test for netconf connector

Change-Id: I85eca361a8af13a87f09477781405dbcb9f721b4
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBug 2086: Adding normalized node stream reader and writer. 84/12284/1
Harman Singh [Tue, 21 Oct 2014 21:50:04 +0000 (14:50 -0700)]
Bug 2086: Adding normalized node  stream reader and writer.

Normalized node and its children are written in recursive manner. Besides the leafNode, leafSetEntryNode and anyxmlNode, all other nodes must call endNode method
while writing object to data stream. This helps to recreate the object.

Recursion  runs in opposite direction while reading the object.

Updated code with review comments

Change-Id: Ibb822e11fc76f52b5be78596ed979c3b97d51de8
Signed-off-by: Harman Singh <harmasin@cisco.com>
7 years agoBug 2055: Handle Tx create in TransactionProxy resiliently 15/12215/7
tpantelis [Sun, 12 Oct 2014 14:44:35 +0000 (10:44 -0400)]
Bug 2055: Handle Tx create in TransactionProxy resiliently

    Modified TransactionProxy to utilize the FindPrimaryShard
functionality
    to wait until the shard is initialized. Also added retries to
    the CreateTransaction operation to wait a period of time for the
shard
    to elect a leader. This makes it more resilient to avoid transient
    timing/sequencing failures, particularly on startup.

    In addition, the FindPrimaryShard and CreateTransaction operations
are now
    done async (non-blocking). The futures are combined to yield the
    CreateTransactionReply which is passed to a new class
    TransactionFutureCallback on completion. The
TransactionFutureCallback
    class creates and stores the TransactionContext which subsequent
    read/write/delete/ready transaction operations can access. If a
    transaction operation occurs before CreateTransaction completes, the
    operation is cached in TransactionFutureCallback and executed when
    the CreateTransaction future completes.

Change-Id: Id9cdc9641038922d6209c44d924bd168658a71fb
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoMerge "Bug-2098- sal-compatibility not get up-to-date flow information"
Moiz Raja [Mon, 27 Oct 2014 23:20:21 +0000 (23:20 +0000)]
Merge "Bug-2098- sal-compatibility not get up-to-date flow information"

7 years agoBug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools interface 93/12293/2
tpantelis [Mon, 27 Oct 2014 21:13:58 +0000 (17:13 -0400)]
Bug 2265: Modified NormalizedNodeOutputStreamWriter to implement yangtools interface

The NormalizedNodeOutputStreamWriter was originally written to implement
a NormalizedNodeStreamWriter interface class that was copied from
yangtools. This was done to get access to the NodeWithValue in the
leafSetEntryNode method which isn't specified in the yangtools
interface. However it turns out we don't actually need the NodeWithValue so
NormalizedNodeOutputStreamWriter was changed to implement the yangtols interface
and the copied NormalizedNodeStreamWriter interface was removed.

Change-Id: I72f0c96359e4fe96e8e183aa7afba9291c5d519d
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoBug-2098- sal-compatibility not get up-to-date flow information 31/11631/7
Kamal Rameshan [Sat, 27 Sep 2014 19:08:12 +0000 (12:08 -0700)]
Bug-2098- sal-compatibility not get up-to-date flow information

When cached is passed in as false, we attempt to collect all the notifications in a guava cache and
return the results after we get the last notification.

Depends on the OFP Patch : https://git.opendaylight.org/gerrit/#/c/11655/

Change-Id: I78d911648957f30d0ae0c92945ad3ac4cf7fc483
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
7 years agoMerge "Bug 2055: Handle shard not initialized resiliently"
Moiz Raja [Mon, 27 Oct 2014 17:14:58 +0000 (17:14 +0000)]
Merge "Bug 2055: Handle shard not initialized resiliently"

7 years agoMerge changes I8b1a0281,Ib6342c74
Tony Tkacik [Mon, 27 Oct 2014 11:23:18 +0000 (11:23 +0000)]
Merge changes I8b1a0281,Ib6342c74

* changes:
  BUG-1612 Remove ganymed third party ssh lib (replaced by mina ssh)
  BUG-1612 Remove ganymed implementation of SSH server wrapper.

7 years agoMerge "BUG 1839 - HTTP delete of non existing data"
Tony Tkacik [Mon, 27 Oct 2014 10:22:29 +0000 (10:22 +0000)]
Merge "BUG 1839 - HTTP delete of non existing data"

7 years agoMerge "Fix checkstyle warnings"
Tony Tkacik [Mon, 27 Oct 2014 09:58:19 +0000 (09:58 +0000)]
Merge "Fix checkstyle warnings"

7 years agoMerge "Convert netconf to use artifacts"
Tony Tkacik [Mon, 27 Oct 2014 09:28:44 +0000 (09:28 +0000)]
Merge "Convert netconf to use artifacts"

7 years agoMerge "Import yangtools-artifacts"
Tony Tkacik [Mon, 27 Oct 2014 09:28:29 +0000 (09:28 +0000)]
Merge "Import yangtools-artifacts"

7 years agoMerge "Cleanup RpcRoutingStrategy definition"
Tony Tkacik [Mon, 27 Oct 2014 09:28:04 +0000 (09:28 +0000)]
Merge "Cleanup RpcRoutingStrategy definition"

7 years agoBUG-1612 Remove ganymed third party ssh lib (replaced by mina ssh) 97/11997/7
Maros Marsalek [Thu, 16 Oct 2014 06:10:07 +0000 (08:10 +0200)]
BUG-1612 Remove ganymed third party ssh lib (replaced by mina ssh)

Change-Id: I8b1a0281161f29345f1ee1af646a5fca504ad823
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG-1612 Remove ganymed implementation of SSH server wrapper. 41/11841/7
Maros Marsalek [Tue, 7 Oct 2014 17:17:56 +0000 (19:17 +0200)]
BUG-1612 Remove ganymed implementation of SSH server wrapper.

Change-Id: Ib6342c74ff9335265d1fe7a12ca8caecbd72d94f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "BUG-1612 Update netconf testtool to use new ssh server wrapper"
Tony Tkacik [Mon, 27 Oct 2014 09:17:26 +0000 (09:17 +0000)]
Merge "BUG-1612 Update netconf testtool to use new ssh server wrapper"

7 years agoMerge "BUG-1612 Implement mina ssh netconf server endpoint"
Tony Tkacik [Mon, 27 Oct 2014 09:17:14 +0000 (09:17 +0000)]
Merge "BUG-1612 Implement mina ssh netconf server endpoint"

7 years agoMerge "Fix failing reconnect test."
Tony Tkacik [Mon, 27 Oct 2014 08:27:13 +0000 (08:27 +0000)]
Merge "Fix failing reconnect test."

7 years agoMerge "BUG-2184 Fix subtree filtering for identity-ref leaves"
Tony Tkacik [Mon, 27 Oct 2014 08:26:36 +0000 (08:26 +0000)]
Merge "BUG-2184 Fix subtree filtering for identity-ref leaves"

7 years agoMerge "BUG-2184 Fix config.yang module(add type as a key for modules list)"
Tony Tkacik [Mon, 27 Oct 2014 08:26:25 +0000 (08:26 +0000)]
Merge "BUG-2184 Fix config.yang module(add type as a key for modules list)"

7 years agoBug 2210: Fixed initial DCL notification on registration 88/12088/6
tpantelis [Thu, 9 Oct 2014 17:54:18 +0000 (13:54 -0400)]
Bug 2210: Fixed initial DCL notification on registration

On RegisterChangeListener message, if the shard isn't the leader, the
listener proxy isn't registered with the IMDS yet, instead a
DelayedListenerRegistration innstance is created and added to a
delayedListenerRegistrations list. When the shard becomes the leader, in
onStateChange, the DelayedListenerRegistration instances in the
delayedListenerRegistrations list are registered with the IMDS.

Change-Id: Id5fbfc3e452e9843f6977139d101e71f4022dc0a
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoBug 2252: Terminate ShardWriteTransaction actor on ready 62/12262/2
tpantelis [Sun, 26 Oct 2014 21:15:19 +0000 (17:15 -0400)]
Bug 2252: Terminate ShardWriteTransaction actor on ready

Change-Id: I16f9dcf370aab1e23073163e0e055a40f1415a1a
Signed-off-by: tpantelis <tpanteli@brocade.com>
7 years agoConvert netconf to use artifacts 60/12060/4
Robert Varga [Fri, 17 Oct 2014 23:23:01 +0000 (01:23 +0200)]
Convert netconf to use artifacts

Change-Id: I23feabe96c7fc3e0d1ca59b6773abeb97e9467f9
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoImport yangtools-artifacts 42/11942/5
Robert Varga [Sun, 12 Oct 2014 11:33:52 +0000 (13:33 +0200)]
Import yangtools-artifacts

This patch makes use of artifacts exported by yangtools, simplifying the
dependencyManagement section.

Change-Id: Id00030f6f4134c6bebc573cf3c14fe271e59e61a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Bug-2136 : Clustering : When a transaction is local then do not serialize...
Tom Pantelis [Fri, 24 Oct 2014 21:39:29 +0000 (21:39 +0000)]
Merge "Bug-2136 : Clustering : When a transaction is local then do not serialize the Reading/Writing of data"

7 years agoBUG-1612 Update netconf testtool to use new ssh server wrapper 42/11842/4
Maros Marsalek [Tue, 7 Oct 2014 17:44:35 +0000 (19:44 +0200)]
BUG-1612 Update netconf testtool to use new ssh server wrapper

Change-Id: I8625f8d34df65f6d7e47ad77d393f482afa1abdf
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG-1612 Implement mina ssh netconf server endpoint 40/11840/4
Maros Marsalek [Mon, 6 Oct 2014 16:09:10 +0000 (18:09 +0200)]
BUG-1612 Implement mina ssh netconf server endpoint

Extract sessionCloseCallback and readHandler from AsyncSshHandlerReader

Change-Id: I0e09341fd59f74f7ac57688414a6dac7c9823b8a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoFix failing reconnect test. 33/12233/1
Maros Marsalek [Fri, 24 Oct 2014 13:34:16 +0000 (15:34 +0200)]
Fix failing reconnect test.

Test verified that session that was dropped during negotiation was not reconnected.
This is no longer true, so the test is failing. However not on jenkins.

Change-Id: I5f416a3397c33607e5004dc48f9569d9da992326
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "[Fix for Bug 1631] - Refactored RaftActorBehavior#handleMessage (and related...
Moiz Raja [Fri, 24 Oct 2014 06:23:22 +0000 (06:23 +0000)]
Merge "[Fix for Bug 1631] - Refactored RaftActorBehavior#handleMessage (and related methods) to return RaftActorBehavior   instead of RaftActorState. - Moved behavior switching from RaftActor based on requested state to the implementations of the   behaviors that should control that switch (Leader/Follower/Candidate) based on the type of   message received. - Pull up logger reference for concrete RAFT behaviors to parent for a common LOG reference. - Updated all logger calls to:   - Use substitution instead of String concatenation.  - Debug logger calls are gated by isDebugEnabled check.  - Correctly use Akka logging API for stack trace on exception.  - Avoid toString() calls during logging.  - Use assigned logger instance (LOG) instead of call to context.getLogger()"

7 years ago[Fix for Bug 1631] 65/11965/5
mark.mozolewski [Tue, 14 Oct 2014 23:05:57 +0000 (16:05 -0700)]
[Fix for Bug 1631]
- Refactored RaftActorBehavior#handleMessage (and related methods) to return RaftActorBehavior
  instead of RaftActorState.
- Moved behavior switching from RaftActor based on requested state to the implementations of the
  behaviors that should control that switch (Leader/Follower/Candidate) based on the type of
  message received.
- Pull up logger reference for concrete RAFT behaviors to parent for a common LOG reference.
- Updated all logger calls to:
  - Use substitution instead of String concatenation.
- Debug logger calls are gated by isDebugEnabled check.
- Correctly use Akka logging API for stack trace on exception.
- Avoid toString() calls during logging.
- Use assigned logger instance (LOG) instead of call to context.getLogger()

Change-Id: I376e21734a0540aae714fe9ef1562d74e73e558b
Signed-off-by: mark.mozolewski <mark.mozolewski@hp.com>
7 years agoBug 2002: Classpath error when loading neutron northbound api 88/12188/1
Sam Hague [Wed, 22 Oct 2014 01:51:27 +0000 (21:51 -0400)]
Bug 2002: Classpath error when loading neutron northbound api

Add the org.eclipse.persistence.antlr to the odl-pseristence feture. There are weird timing issues where if the antlr bundle is not loaded before core and moxy then the classes in antlr cannot be found.

Change-Id: I8fd30b5fb215b8a25512deac45e80099c91c539e
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit 3ee4966ad2d840a907fae33ff74037d599765742)

7 years agoBUG-2184 Fix subtree filtering for identity-ref leaves 65/12165/1
Maros Marsalek [Wed, 22 Oct 2014 15:49:19 +0000 (17:49 +0200)]
BUG-2184 Fix subtree filtering for identity-ref leaves

Change-Id: I7d367c793a461ae26f56ddf611f7e45a723f28fc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG-2184 Fix config.yang module(add type as a key for modules list) 69/12069/2
Maros Marsalek [Mon, 20 Oct 2014 10:46:28 +0000 (12:46 +0200)]
BUG-2184 Fix config.yang module(add type as a key for modules list)

Netconf server requires the type and name when e.g. deleting data so the yang model did not fully reflect the implementation

Change-Id: If4b04fe1ec427cff0f52d743cc1440fc7fe143d2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "BUG-2207 Make reconnect promise reconnect even if session was dropped during...
Tony Tkacik [Wed, 22 Oct 2014 13:09:27 +0000 (13:09 +0000)]
Merge "BUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation"

7 years agoMerge "BUG-2217 Add missing namespace to serialized inner runtime beans"
Tony Tkacik [Wed, 22 Oct 2014 11:52:44 +0000 (11:52 +0000)]
Merge "BUG-2217 Add missing namespace to serialized inner runtime beans"

7 years agoBUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation 58/11858/4
Maros Marsalek [Thu, 9 Oct 2014 15:23:25 +0000 (17:23 +0200)]
BUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation

Change-Id: I58adc2e42bb8ce09bfb8b5cd214a91300bb2bbb0
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoBUG 1833 : Remove all unused code from sal-clustering-commons 30/12130/1
Moiz Raja [Tue, 21 Oct 2014 21:12:19 +0000 (14:12 -0700)]
BUG 1833 : Remove all unused code from sal-clustering-commons

Change-Id: I7ce05b4ee77b6151f361091b18d1a7bbd8ed408a
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 4861f2406206bf208a07a703ad8d6808072c6e45)

7 years agoMerge "Bug2174: XSQL log file is hardcode to /tmp/xql.log"
Moiz Raja [Tue, 21 Oct 2014 19:51:29 +0000 (19:51 +0000)]
Merge "Bug2174: XSQL log file is hardcode to /tmp/xql.log"