controller.git
6 years agoMerge "Changed read to be type-safe in ReadTransaction"
Devin Avery [Fri, 18 Jul 2014 12:00:29 +0000 (12:00 +0000)]
Merge "Changed read to be type-safe in ReadTransaction"

6 years agoMerge "BUG-1384: YangStoreServiceImpl.refresh() should never block"
Tony Tkacik [Fri, 18 Jul 2014 09:07:03 +0000 (09:07 +0000)]
Merge "BUG-1384: YangStoreServiceImpl.refresh() should never block"

6 years agoMerge "Improve RpcProviderRegistry loading"
Tony Tkacik [Fri, 18 Jul 2014 08:45:04 +0000 (08:45 +0000)]
Merge "Improve RpcProviderRegistry loading"

6 years agoMerge "BUG-692 Replace strings with ModifyAction enum"
Tony Tkacik [Fri, 18 Jul 2014 08:39:08 +0000 (08:39 +0000)]
Merge "BUG-692 Replace strings with ModifyAction enum"

6 years agoMerge "Bug-1376 Add caching for premature notifications in netconf connector"
Tony Tkacik [Fri, 18 Jul 2014 08:38:32 +0000 (08:38 +0000)]
Merge "Bug-1376 Add caching for premature notifications in netconf connector"

6 years agoMerge "BUG-1291 Fix executor for netconf-connector rejecting tasks."
Tony Tkacik [Fri, 18 Jul 2014 07:33:48 +0000 (07:33 +0000)]
Merge "BUG-1291 Fix executor for netconf-connector rejecting tasks."

6 years agoMerge "BUG-1365 Check if channel was closed when negotiation fails"
Tony Tkacik [Fri, 18 Jul 2014 07:33:35 +0000 (07:33 +0000)]
Merge "BUG-1365 Check if channel was closed when negotiation fails"

6 years agoBUG-692 Replace strings with ModifyAction enum 80/9080/3
Maros Marsalek [Wed, 16 Jul 2014 14:35:58 +0000 (16:35 +0200)]
BUG-692 Replace strings with ModifyAction enum

Change-Id: Ie2564240eed76711437afd0428d02af26cb81cff
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBug-1376 Add caching for premature notifications in netconf connector 50/9050/5
Maros Marsalek [Wed, 16 Jul 2014 08:29:47 +0000 (10:29 +0200)]
Bug-1376 Add caching for premature notifications in netconf connector

If a notification is received before schema context is fully built for device, it is cached and forwarded when schema is present.

Change-Id: Ib21fc0fab9cf83a1102ccbb5c9dc98330aa95577
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBUG-1384: YangStoreServiceImpl.refresh() should never block 18/9118/3
Robert Varga [Thu, 17 Jul 2014 14:19:32 +0000 (16:19 +0200)]
BUG-1384: YangStoreServiceImpl.refresh() should never block

As descirbed in the bug, we are seeing large amounts of contention on
the monitor when calling refresh(). Rework the safety such that the
refresh path does not block and perform checking for refresh in the
get() path, which is forced to retry should a refresh occur.

With this patch reported contention disappears completely and startup
time is improved by about 8 seconds on stock SP edition.

Change-Id: I4c6109d77324d3d1b700041b54a95dc346e3d372
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Added SingleThreadedExecutors to data store instance."
Devin Avery [Thu, 17 Jul 2014 14:17:35 +0000 (14:17 +0000)]
Merge "Added SingleThreadedExecutors to data store instance."

6 years agoMerge "Bug 1380 - Fix NullPointerException when match is null"
Devin Avery [Thu, 17 Jul 2014 14:12:46 +0000 (14:12 +0000)]
Merge "Bug 1380 - Fix NullPointerException when match is null"

6 years agoBUG-1291 Fix executor for netconf-connector rejecting tasks. 49/9049/4
Maros Marsalek [Wed, 16 Jul 2014 08:27:53 +0000 (10:27 +0200)]
BUG-1291 Fix executor for netconf-connector rejecting tasks.

Flexible threadpool rejected tasks with SynchronousQueue and did not spawn threads with LinkedBlockingQueue.
Added custom Queue that makes the underlying threadpool to spawn threads as expected.

Change-Id: I28d27316cf63b3370aa802bbd31ee976aa54fbf7
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Bug 1367 - Fix NPE in cors filter"
Tony Tkacik [Thu, 17 Jul 2014 08:30:08 +0000 (08:30 +0000)]
Merge "Bug 1367 - Fix NPE in cors filter"

6 years agoBUG-1365 Check if channel was closed when negotiation fails 29/9029/3
Maros Marsalek [Tue, 15 Jul 2014 13:55:34 +0000 (15:55 +0200)]
BUG-1365 Check if channel was closed when negotiation fails

Also set state only if promise is not yet finished.
Replace custom EOM aggregator with implementation provided by netty.

Change-Id: Iffb740fff1512ca14efe58ed5112f74ce5e75c97
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoFixed to config,netconf,mdsal features files 63/8963/4
Surekha Bejgam [Thu, 10 Jul 2014 22:40:43 +0000 (17:40 -0500)]
Fixed to config,netconf,mdsal features files

This patch requires:
https://git.opendaylight.org/gerrit/#/c/8962/

Things done here (apologies for it all at once
but it was the result of a lot of experimenting):

1) Moved config/mdsal/netconf features projects under
controller/features
2) Created controller/features/pom.xml to make rebuilding
features easier
3) Created netconf features project
4) Created protocol-framework features project
5) Removed 02-clustering.xml as its no longer used.

Note: These features are intentionally done in a lean
manner... very little overinclusion involved.

State of things:
Hit a snag around karaf's new JMX RBAC.
If you do
feature:install odl-config-startup
and wait for a minute or so you will get an error like:

http://pastebin.com/8J886kK9

which looks pretty bad, but is really just telling us that
when the config subsytem went to push features to JMX,
karaf's JMX RBAC blocked us.

I've filed https://bugs.opendaylight.org/show_bug.cgi?id=1359
on this, which describes two possible solutions to the problem.

Further information for onces 1359 is resolved:

The four config files its looking to push are:
ls opendaylight-karaf/target/distribution.opendaylight-karaf-1.4.2-SNAPSHOT/configuration/initial
00-netty.xml 01-md-sal.xml 03-toaster-sample.xml

You can get the requisite capabilities for 00-netty.xml should be installed
by doing
feature:install odl-config-netty
(which depends on odl-config-startup).
For 01-md-sal.xml to be processed you will need to fix up the md-sal
features.  To get 03-toaster-sample.xml processed you will need a feature
for toaster.  I recommend deleting 01-md-sal.xml and 03-toaster-sample.xml
and just playing with 00-netty.xml till you can get past the stuck
places with JMX.

Once you *think* you are past 1359, verify by pointing
jconsole at karaf and looking at MBeans and drilling down under
org.opendaylight until you find the Modules.  You should see more
than 'shutdown' there.

Recommended Next steps:
1)  Fix bug 1359 -  picked option1 to proceed
2)  Fix up the md-sal feature at least enough to get 01-md-sal.xml
working - Done
3)  Get a controller/features/toaster going and get 03-toaster-sample.xml
working. - Toaster is working

********* Had to install in this order to get features installed correctly ********

feature:install yangtools-all

feature:install base-all

feature:install odl-mdsal-commons

feature:install odl-config-api

feature:install odl-config-netty-config-api

feature:install odl-protocol-framework

feature:install odl-netconf-api

feature:install odl-netconf-mapping-api

feature:install odl-netconf-util

feature:install odl-netconf-netty-util

feature:install odl-netconf-impl

feature:install odl-config-core

feature:install odl-config-manager

feature:install odl-config-persister

feature:install odl-config-api

feature:install odl-config-netty-api

feature:install odl-config-netty-config-api

feature:install odl-config-netty

feature:install odl-config-startup

feature:install odl-config-netconf-connector

feature:install odl-mdsal-all

feature:install odl-mdsal-toaster

feature:install yangtools-restconf

feature:install odl-adsal-all

feature:install odl-netconf-misc

feature:install odl-config-dispatcher

feature:install odl-mdsal-misc

********************************************************************

I apologize for the size and complexity of this patch.  But it seemed
important to get it out to folks.  Please feel free to break it down
into more managable pieces if you are so inclined.

Change-Id: I6384d57d4fe623221e9c81d8bfb547277ab0e051
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Surekha Bejgam <sbejgam@cisco.com>
6 years agoImprove RpcProviderRegistry loading 93/9093/1
Robert Varga [Wed, 16 Jul 2014 20:22:42 +0000 (22:22 +0200)]
Improve RpcProviderRegistry loading

Profiling monitor usage at startup has shown that we spend about 19s of
CPU time over ~50 second bootup waiting in getRpcService(). Instead of a
home-grown cache, let's use a guava Loading cache, which allows us to
concurrently instantiate multiple rpc services at the same time.

Change-Id: Ieaaedd7da61cd0b03b05a44ee2a6285bc8eb46ac
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 1380 - Fix NullPointerException when match is null 92/9092/1
Rob Adams [Wed, 16 Jul 2014 19:18:06 +0000 (12:18 -0700)]
Bug 1380 - Fix NullPointerException when match is null

Change-Id: I728a90054642302d3157e1da4bfa7df3fb63087d
Signed-off-by: Rob Adams <readams@readams.net>
6 years agoMerge "Bug 1225: Fixed bug in registration of default RPC implementation."
Devin Avery [Wed, 16 Jul 2014 19:07:04 +0000 (19:07 +0000)]
Merge "Bug 1225: Fixed bug in registration of default RPC implementation."

6 years agoMerge "Deprecated Rpcs and RpcErrors helper classes"
Devin Avery [Wed, 16 Jul 2014 18:31:51 +0000 (18:31 +0000)]
Merge "Deprecated Rpcs and RpcErrors helper classes"

6 years agoMerge "Bug 1093: Extracted static inner classes from SchemaAwareRpcBroker."
Devin Avery [Wed, 16 Jul 2014 17:58:46 +0000 (17:58 +0000)]
Merge "Bug 1093: Extracted static inner classes from SchemaAwareRpcBroker."

6 years agoAdded SingleThreadedExecutors to data store instance. 88/9088/1
Tony Tkacik [Wed, 16 Jul 2014 17:31:44 +0000 (19:31 +0200)]
Added SingleThreadedExecutors to data store instance.

Change-Id: I18900f4db121fe7728ecd3c0aae90cbd6e83fee2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Added comments to the opendaylight-inventory.yang file to help describe the...
Tom Pantelis [Wed, 16 Jul 2014 15:28:33 +0000 (15:28 +0000)]
Merge "Added comments to the opendaylight-inventory.yang file to help describe the purpose of the various fields"

6 years agoBug 1093: Extracted static inner classes from SchemaAwareRpcBroker. 54/9054/2
Tony Tkacik [Wed, 16 Jul 2014 10:58:21 +0000 (12:58 +0200)]
Bug 1093: Extracted static inner classes from SchemaAwareRpcBroker.

Change-Id: I68bc1d3e4a3b279877e5ece19bcc9e1bfcd0c3dc
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoAdded comments to the opendaylight-inventory.yang file to help describe 55/8255/6
Devin Avery [Mon, 23 Jun 2014 19:14:30 +0000 (15:14 -0400)]
Added comments to the opendaylight-inventory.yang file to help describe
the purpose of the various fields

Change-Id: I1e368b94c9b0c030bb8f7d266019fdeaa97abc80
Signed-off-by: Devin Avery <devin.avery@brocade.com>
6 years agoBug 1225: Fixed bug in registration of default RPC implementation. 30/9030/2
Tony Tkacik [Tue, 15 Jul 2014 16:17:38 +0000 (18:17 +0200)]
Bug 1225: Fixed bug in registration of default RPC implementation.

Change-Id: I302bd0c9aa75e844864d0b7dd692c1d331a563ed
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Bug 1355: Fixed incorrect input keyword use in rpc"
Tony Tkacik [Wed, 16 Jul 2014 07:52:49 +0000 (07:52 +0000)]
Merge "Bug 1355: Fixed incorrect input keyword use in rpc"

6 years agoFixed class-cast when Netconf registered RPC implementations. 32/9032/1
Tony Tkacik [Tue, 15 Jul 2014 16:43:02 +0000 (18:43 +0200)]
Fixed class-cast when Netconf registered RPC implementations.

Change-Id: I0803f7ec0d23bcf195c2fbac49e916c4f30110e1
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 1355: Fixed incorrect input keyword use in rpc 18/9018/1
Lukas Sedlak [Tue, 15 Jul 2014 11:57:27 +0000 (13:57 +0200)]
Bug 1355: Fixed incorrect input keyword use in rpc

Fixed incorrect evaluation in method flattenInput in NetconfMessageTransformUtil.
Added test for testing toRpcRequest and flattenInput methods.
Added test model for test.

Change-Id: Id6938b39f0bd06b315f4820a6c1008fa371416d0
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoMerge "Bug 1303: BindingIndependentConnector splitted."
Tony Tkacik [Tue, 15 Jul 2014 10:35:27 +0000 (10:35 +0000)]
Merge "Bug 1303: BindingIndependentConnector splitted."

6 years agoMerge "BUG-1317 BUG-1351 Fix duplicate connections from netconf connector"
Tony Tkacik [Tue, 15 Jul 2014 09:36:11 +0000 (09:36 +0000)]
Merge "BUG-1317 BUG-1351 Fix duplicate connections from netconf connector"

6 years agoMerge "Bug 1125: Added regression test"
Tony Tkacik [Tue, 15 Jul 2014 08:56:21 +0000 (08:56 +0000)]
Merge "Bug 1125: Added regression test"

6 years agoBug 1367 - Fix NPE in cors filter 08/9008/1
Tomas Olvecky [Tue, 15 Jul 2014 08:52:21 +0000 (10:52 +0200)]
Bug 1367 - Fix NPE in cors filter

Null was returned by request.getPathInfo, correct method
that decodes relative path to resource is
request.getDecodedRequestURI .

Change-Id: I74964bea07df8fa0e9a37af0effaa2525c6b8b2c
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBUG-1317 BUG-1351 Fix duplicate connections from netconf connector 94/8994/2
Maros Marsalek [Mon, 14 Jul 2014 16:04:53 +0000 (18:04 +0200)]
BUG-1317 BUG-1351 Fix duplicate connections from netconf connector

Change-Id: I2c3135f3f84ef25f0005744c03003462c96812c1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBug 1125: Added regression test 85/8985/2
Tony Tkacik [Mon, 14 Jul 2014 11:40:13 +0000 (13:40 +0200)]
Bug 1125: Added regression test

Change-Id: I455134dc95b8af4f4f0c79b11e55fd01b58731e4
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoApply style rules on whole sal-rest-connector 27/8927/3
Jozef Gloncak [Fri, 11 Jul 2014 08:26:07 +0000 (10:26 +0200)]
Apply style rules on whole sal-rest-connector

No changes in function of code, just formatting.

Change-Id: I52bf10a3b84fa61ec35c31145acbbc6b9bf349ec
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoChanged read to be type-safe in ReadTransaction 35/8735/8
Tony Tkacik [Mon, 7 Jul 2014 12:39:49 +0000 (14:39 +0200)]
Changed read to be type-safe in ReadTransaction

Removed declaration of read method from common
superinterface, which is now only marker interface
for read capabilities.

Defined read method in specialization of interface
for Binding and DOM interfaces, which makes
use of specific features of format.

This change is source-code compatible
and users of read method needs to update
their code appropriatelly as shown in
Toaster example.

Change-Id: I8c783fc5f276722a5a762eea7c769c3f54a31855
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoDeprecated Rpcs and RpcErrors helper classes 64/8964/4
tpantelis [Thu, 10 Jul 2014 06:49:07 +0000 (02:49 -0400)]
Deprecated Rpcs and RpcErrors helper classes

With the new RpcResultBuilder class, we can deprecate the Rpcs and
RpcErrors classes.

Also migrate all uses of the deprecated classes to RpcResultBuilder in
the controller code.

Change-Id: I86408bba0ce19e70c7d7a41555e94052e54e93f8
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoMerge "BUG 1330 - list key counts|values diff in payload and URI"
Tom Pantelis [Fri, 11 Jul 2014 14:55:36 +0000 (14:55 +0000)]
Merge "BUG 1330 - list key counts|values diff in payload and URI"

6 years agoBug 1303: BindingIndependentConnector splitted. 96/8896/2
Lukas Sedlak [Thu, 10 Jul 2014 08:16:46 +0000 (10:16 +0200)]
Bug 1303: BindingIndependentConnector splitted.

Inner private classes in BindingIndependentConnector extracted into standalone package protected classes.
Fixed bug in BindingToDomTransaction class - domOpenedTransactions management.

Change-Id: I69173db2bf4e6746eac4fa67c57f65095f45c603
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoMerge "Introducing simple merge strategy for config subsystem"
Tony Tkacik [Fri, 11 Jul 2014 11:35:41 +0000 (11:35 +0000)]
Merge "Introducing simple merge strategy for config subsystem"

6 years agoBug 1225: Added DataBroker and DataChangeListener test suite. 26/8926/2
Tony Tkacik [Thu, 10 Jul 2014 15:24:07 +0000 (17:24 +0200)]
Bug 1225: Added DataBroker and DataChangeListener test suite.

Change-Id: I53a06845024936253f576e5095b3d00c15a47e99
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 1284: Fixed serialization of Augment Instance Identifier 65/8865/5
Tony Tkacik [Wed, 9 Jul 2014 15:42:59 +0000 (17:42 +0200)]
Bug 1284: Fixed serialization of Augment Instance Identifier

Instance Identifier pointing to Augmentation, which pointed
to augmentation with leafs only, was not properly
serialized to DOM Instance Identifier and this caused
subscription for parent node.

Instance Identifier Codec was updated to detect
this case and use different algorithm to serialize
last argument.

Change-Id: Ie47ec7a5ebc86e10a7e1b3ddbc8921bf089466b2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Bug 1223: Cleaned up BindingTestContext from unsupported components."
Ed Warnicke [Fri, 11 Jul 2014 09:35:26 +0000 (09:35 +0000)]
Merge "Bug 1223: Cleaned up BindingTestContext from unsupported components."

6 years agoMerge "IEEE802.1q Packet returns incorrect header size"
Alessandro Boch [Fri, 11 Jul 2014 08:14:28 +0000 (08:14 +0000)]
Merge "IEEE802.1q Packet returns incorrect header size"

6 years agoMerge "Bug 1139 Modify cors-config according to request"
Tony Tkacik [Fri, 11 Jul 2014 07:56:30 +0000 (07:56 +0000)]
Merge "Bug 1139 Modify cors-config according to request"

6 years agoMerge "Clarified the AsyncDataChangeEvent message - stated you must not block the...
Tony Tkacik [Fri, 11 Jul 2014 07:38:16 +0000 (07:38 +0000)]
Merge "Clarified the AsyncDataChangeEvent message - stated you must not block the thread."

6 years agoIEEE802.1q Packet returns incorrect header size 88/8888/4
Yevgeny Khodorkovsky [Thu, 10 Jul 2014 05:13:57 +0000 (22:13 -0700)]
IEEE802.1q Packet returns incorrect header size

IEEE8021Q class uses the Packet.getHeaderSize() which iterates through
header fields to determine the size. .1Q header is fixed in size and
should return the correct value

Change-Id: I4b0123dd943f6e833f14782f2ed7cc0e6e184e87
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoMerge "Add generic exception mapper"
Chi-Vien Ly [Thu, 10 Jul 2014 18:37:12 +0000 (18:37 +0000)]
Merge "Add generic exception mapper"

6 years agoClarified the AsyncDataChangeEvent message - stated you must not block the thread. 06/8906/1
Devin Avery [Thu, 10 Jul 2014 18:05:43 +0000 (14:05 -0400)]
Clarified the AsyncDataChangeEvent message - stated you must not block the thread.

Change-Id: I311b7c37f5848beb351d59fc830798d10302a3bb
Signed-off-by: Devin Avery <devin.avery@brocade.com>
6 years agoBug 1139 Modify cors-config according to request 95/8895/1
Tomas Olvecky [Thu, 10 Jul 2014 12:58:27 +0000 (14:58 +0200)]
Bug 1139 Modify cors-config according to request

Change-Id: I6276e6a41c43ffb430f520911cd8366a55dc8930
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoIntroducing simple merge strategy for config subsystem 05/8705/4
Tomas Olvecky [Wed, 9 Jul 2014 13:27:09 +0000 (15:27 +0200)]
Introducing simple merge strategy for config subsystem

MergeEditStrategy wasn't really merging.
Now it is, but only for ObjectName[].
However, since ObjectName[] is 90% of the interesting
cases, this should get us a long way.

This is needed to be able to handle reasonably
extension, with the ability to wire in multiple
extension modules independently, as we need to do
for things like OF extension.

Change-Id: Ieca579cbc6781d77f489f5f754490c8da8f65188
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBug 1223: Cleaned up BindingTestContext from unsupported components. 49/8849/2
Tony Tkacik [Wed, 9 Jul 2014 10:47:28 +0000 (12:47 +0200)]
Bug 1223: Cleaned up BindingTestContext from unsupported components.

Change-Id: I26123a2a9d56c85dcc329fda0727e7e3e664c829
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Add BGPCEP logging configuration"
Tony Tkacik [Thu, 10 Jul 2014 08:42:25 +0000 (08:42 +0000)]
Merge "Add BGPCEP logging configuration"

6 years agoMerge "Bug 1341 - Make RESTConf websocket port configurable"
Tony Tkacik [Thu, 10 Jul 2014 08:04:31 +0000 (08:04 +0000)]
Merge "Bug 1341 - Make RESTConf websocket port configurable"

6 years agoBUG 1330 - list key counts|values diff in payload and URI 89/8889/3
Jozef Gloncak [Thu, 10 Jul 2014 08:02:00 +0000 (10:02 +0200)]
BUG 1330 - list key counts|values diff in payload and URI

Adds validation whether list key counts or list key values are different
between payload and URI. It difference occures then
RestconfDocumentedException is raised.

Change-Id: I93aaa352cfb8daee298ebf16375cb70987328dbb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoMerge "Deprecate model-flow-management as it was never used and is confusing people."
Devin Avery [Wed, 9 Jul 2014 20:36:32 +0000 (20:36 +0000)]
Merge "Deprecate model-flow-management as it was never used and is confusing people."

6 years agoExtra Features for Controller (Akka, Spray and Scala) 66/7266/14
Mathieu Lemay [Fri, 23 May 2014 20:17:18 +0000 (16:17 -0400)]
Extra Features for Controller (Akka, Spray and Scala)

PatchSet14: Cliped out spray as its not used in controller.

Change-Id: I20a9d9efb5e26686d29bed88c732c397258be7a0
Signed-off-by: Jonathan Fok kan <jfokkan@inocybe.ca>
Signed-off-by: Gabriel Robitaille-Montpetit <grmontpetit@inocybe.com>
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
6 years agoAdd generic exception mapper 63/8863/3
mrajvaid [Wed, 9 Jul 2014 15:44:49 +0000 (08:44 -0700)]
Add generic exception mapper

Change-Id: Ia3fbf4bcea6095e5c0eb6e56e8c886b38e66cd65
Signed-off-by: mrajvaid <mrajvaid@cisco.com>
6 years agoBug 1341 - Make RESTConf websocket port configurable 66/8866/1
Richard Kosegi [Wed, 9 Jul 2014 13:31:05 +0000 (15:31 +0200)]
Bug 1341 - Make RESTConf websocket port configurable

Change-Id: I54f4bcadd864eb264b92f00b82b81489e9ebecf0
Signed-off-by: Richard Kosegi <rkosegi@cisco.com>
6 years agoMerge "Improve documentation of BindingAware{Provider,Consumer}"
Tony Tkacik [Wed, 9 Jul 2014 15:09:54 +0000 (15:09 +0000)]
Merge "Improve documentation of BindingAware{Provider,Consumer}"

6 years agoMerge "Bug 1293 - Switch packaging of config-util to bundle"
Tony Tkacik [Wed, 9 Jul 2014 09:09:32 +0000 (09:09 +0000)]
Merge "Bug 1293 - Switch packaging of config-util to bundle"

6 years agoMerge "Re-added config.version to config-module-archetype."
Tony Tkacik [Wed, 9 Jul 2014 09:03:55 +0000 (09:03 +0000)]
Merge "Re-added config.version to config-module-archetype."

6 years agoMerge "Bug 1112: Update toaster to use async best practices"
Tony Tkacik [Wed, 9 Jul 2014 08:46:11 +0000 (08:46 +0000)]
Merge "Bug 1112: Update toaster to use async best practices"

6 years agoMerge "Implement PortNumberBuilder"
Tony Tkacik [Wed, 9 Jul 2014 08:44:07 +0000 (08:44 +0000)]
Merge "Implement PortNumberBuilder"

6 years agoMerge "Bug 1292: Fix for NPE after notification get."
Tony Tkacik [Wed, 9 Jul 2014 08:43:14 +0000 (08:43 +0000)]
Merge "Bug 1292: Fix for NPE after notification get."

6 years agoBug 1292: Fix for NPE after notification get. 43/8843/1
Lukas Sedlak [Tue, 8 Jul 2014 10:00:23 +0000 (12:00 +0200)]
Bug 1292: Fix for NPE after notification get.

Fixed incorrect pass of SchemaContext in toNotification method in NetconfMessageTransformer class.
Added test for proper testing of resolving of notficiation message.
Added test models and test notification xml payload for testing purposes.

Change-Id: I4ada2fdf976003f4a2809d6cef53816ec39be364
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoBug 1339: Added doublecheck for RPC registration 39/8839/1
Lukas Sedlak [Wed, 9 Jul 2014 07:21:35 +0000 (09:21 +0200)]
Bug 1339: Added doublecheck for RPC registration

Change-Id: I786934b6cc690817688e60fd3d422293f37056be
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoDeprecate model-flow-management as it was never used and is 29/8829/1
Ed Warnicke [Tue, 8 Jul 2014 21:44:07 +0000 (16:44 -0500)]
Deprecate model-flow-management as it was never used and is
confusing people.

Change-Id: I29adb62375a814a290635f7ab8cae4a3f41b8069
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoMerge "Bug 1224, Bug 1221: Added Test case scenarios for Data Change Events."
Ed Warnicke [Tue, 8 Jul 2014 18:45:45 +0000 (18:45 +0000)]
Merge "Bug 1224, Bug 1221: Added Test case scenarios for Data Change Events."

6 years agoMerge "BUG 1204 - exception if multiple container node occures"
Tom Pantelis [Tue, 8 Jul 2014 18:19:55 +0000 (18:19 +0000)]
Merge "BUG 1204 - exception if multiple container node occures"

6 years agoMerge "Bug 1328: Improved argument checks in generated RPC Router"
Ed Warnicke [Tue, 8 Jul 2014 16:51:05 +0000 (16:51 +0000)]
Merge "Bug 1328: Improved argument checks in generated RPC Router"

6 years agoBug 1328: Improved argument checks in generated RPC Router 74/8774/2
Tony Tkacik [Tue, 8 Jul 2014 07:43:24 +0000 (09:43 +0200)]
Bug 1328: Improved argument checks in generated RPC Router

Change-Id: I5e4bd55a4a31b4b671b44163286c6b3ebe7707bf
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 1224, Bug 1221: Added Test case scenarios for Data Change Events. 07/8807/2
Tony Tkacik [Tue, 8 Jul 2014 15:29:26 +0000 (17:29 +0200)]
Bug 1224, Bug 1221: Added Test case scenarios for Data Change Events.

Added suite of test-cases which tests Data Change Events
and their contents for various combination of
  - initial state of data store
  - performed operation (e.g. write sibling, child, delete child)
  - various level of data change listener
    eg. (/top or /top/top-level-list/top-level-list[*])
  - various data change scope (BASE, ONE, SUBTREE)

Change-Id: Ic43ba3863e2954574ddec946f33512021839acfd
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoFixed duplicate 'uses' statement in node-errors.yang 02/8802/1
Martin Vitez [Tue, 8 Jul 2014 14:32:27 +0000 (16:32 +0200)]
Fixed duplicate 'uses' statement in node-errors.yang

Change-Id: I2cc1116416cdfd559fdd3ef3c243040750e0df9b
Signed-off-by: Martin Vitez <mvitez@cisco.com>
6 years agoImprove documentation of BindingAware{Provider,Consumer} 01/8301/3
Ed Warnicke [Tue, 24 Jun 2014 15:13:45 +0000 (10:13 -0500)]
Improve documentation of BindingAware{Provider,Consumer}

Change-Id: I39899f68f91a5c54099a404f00b944fa9cf3cec3
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoMerge "Add netconf-cli temporary files to .gitignore"
Ed Warnicke [Tue, 8 Jul 2014 13:36:07 +0000 (13:36 +0000)]
Merge "Add netconf-cli temporary files to .gitignore"

6 years agoMerge "Exclude protocol buffer generated source from Sonar renamed package to exclude...
Tony Tkacik [Tue, 8 Jul 2014 13:13:52 +0000 (13:13 +0000)]
Merge "Exclude protocol buffer generated source from Sonar renamed package to exclude from sonar included warning and note in readme_first for the same Rebased with master Change-Id: I065cb38eba7b84c059a351e0145ce23247e57915 Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>"

6 years agoMerge changes I6e8805e1,I4df698a0,I41e0e30d
Devin Avery [Tue, 8 Jul 2014 12:50:20 +0000 (12:50 +0000)]
Merge changes I6e8805e1,I4df698a0,I41e0e30d

* changes:
  Minor cleanup of test suites in MD-SAL
  Moved data test model to sal-test-model
  Bug 1280: Ensure list parent if written item is list item

6 years agoMerge "Bug 1283: Made return types of AsyncDataChangeEvent consistent"
Devin Avery [Tue, 8 Jul 2014 12:36:06 +0000 (12:36 +0000)]
Merge "Bug 1283: Made return types of AsyncDataChangeEvent consistent"

6 years agoBUG 1204 - exception if multiple container node occures 80/8280/10
Jozef Gloncak [Tue, 24 Jun 2014 06:13:53 +0000 (08:13 +0200)]
BUG 1204 - exception if multiple container node occures

Container schema node + multiple data nodes ->
 exception RestconfDocumentedException is raised.
List schema node + one data node (e. g. in json is specified as container
"list-name":{} and not "list-name":[{},{}...,{}] -> this is acceptable case because
list can have even only one entry.
Leaf schema node + multiple data nodes -> special check whether at
equal objects is everytime uniqe key. If it isn't so then
RestconfDocumentedException is raised. For Json specific JsonParser was
implemented which is catch duplicity at object level an time of parsing.
For XML this duplicity name check is done during normalization phase.

Change-Id: I0b544c015bcf817e82206276bd24c783093308d6
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoBug 1293 - Switch packaging of config-util to bundle 63/8663/2
Tomas Olvecky [Tue, 8 Jul 2014 09:17:19 +0000 (11:17 +0200)]
Bug 1293 - Switch packaging of config-util to bundle

Add new bundle to the distribution - config-util, that was previously
packaged as regular jar and copied into where it was required.

Change-Id: I8a28b4a0b19e4dc6cbc2d71e60cf714cca188a84
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoImplement PortNumberBuilder 85/8785/1
Tomas Olvecky [Tue, 8 Jul 2014 09:15:46 +0000 (11:15 +0200)]
Implement PortNumberBuilder

Change-Id: I9f4f662a7a0f595046c213ea64332ce70b280a78
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoAdd netconf-cli temporary files to .gitignore 84/8784/1
Tomas Olvecky [Tue, 8 Jul 2014 09:11:40 +0000 (11:11 +0200)]
Add netconf-cli temporary files to .gitignore

Change-Id: Ic5eeab930ad0508a7e373b227d9a814ab4ae0010
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoExclude protocol buffer generated source from Sonar 45/8745/2
Basheeruddin Ahmed [Mon, 7 Jul 2014 18:30:46 +0000 (11:30 -0700)]
Exclude protocol buffer generated source from Sonar
renamed package to exclude from sonar
included warning and note in readme_first for the same
Rebased with master
Change-Id: I065cb38eba7b84c059a351e0145ce23247e57915
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
6 years agoBug 1112: Update toaster to use async best practices 97/8797/1
tpantelis [Tue, 8 Jul 2014 05:53:29 +0000 (01:53 -0400)]
Bug 1112: Update toaster to use async best practices

Change-Id: Icc4f51e588d524e1c545c7530072209b8f5c36fd
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoChanging the ovsdb.of.version to 1.3 by default in config.ini 61/8761/1
Madhu Venugopal [Mon, 7 Jul 2014 21:29:35 +0000 (14:29 -0700)]
Changing the ovsdb.of.version to 1.3 by default in config.ini

This gerrit must be merged first prior to
https://git.opendaylight.org/gerrit/#/c/7842
in order to keep the ovsdb project dependency assumptions intact.

Change-Id: I47480b5255b4a595aabcac68900726e45319b178
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
6 years agoMerge "Bug 1235: Documented Notification services of MD-SAL"
Tom Pantelis [Mon, 7 Jul 2014 17:42:47 +0000 (17:42 +0000)]
Merge "Bug 1235: Documented Notification services of MD-SAL"

6 years agoMinor cleanup of test suites in MD-SAL 42/8742/1
Tony Tkacik [Mon, 7 Jul 2014 14:19:00 +0000 (16:19 +0200)]
Minor cleanup of test suites in MD-SAL

- Added SuppressWarning("deprecation") to test suites
  which test backwards compatibility with Hydrogen APIs
- Marked test which needs to be rewritten for new DataBroker API
- Removed superflous version for test dependencies

Change-Id: I6e8805e1895bc2171aa5c653d8d87fd8b5c9055b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Bug 1316: Fixed loop in global RPC forwarding."
Tony Tkacik [Mon, 7 Jul 2014 15:02:18 +0000 (15:02 +0000)]
Merge "Bug 1316: Fixed loop in global RPC forwarding."

6 years agoBug 1316: Fixed loop in global RPC forwarding. 40/8740/1
Lukas Sedlak [Mon, 7 Jul 2014 14:36:52 +0000 (16:36 +0200)]
Bug 1316: Fixed loop in global RPC forwarding.

Change-Id: Ic133471d4883e367230901c8596ccd46f2e9dc08
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoMerge "BUG 1016 - JSON|XML output with|without white chars"
Devin Avery [Mon, 7 Jul 2014 11:04:56 +0000 (11:04 +0000)]
Merge "BUG 1016 - JSON|XML output with|without white chars"

6 years agoMoved data test model to sal-test-model 27/8727/2
Tony Tkacik [Mon, 7 Jul 2014 09:47:56 +0000 (11:47 +0200)]
Moved data test model to sal-test-model

Change-Id: I4df698a07919178e130cb5d390d80f9fe032f09c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Cleanup: Removed unused code"
Ed Warnicke [Mon, 7 Jul 2014 10:45:37 +0000 (10:45 +0000)]
Merge "Cleanup: Removed unused code"

6 years agoBug 1280: Ensure list parent if written item is list item 19/8619/3
Tony Tkacik [Thu, 3 Jul 2014 11:49:38 +0000 (13:49 +0200)]
Bug 1280: Ensure list parent if written item is list item

One of properties of Java Binding is that it is imposible
to represent list as a whole and thus it was possible
to create put operation, which was correct by Binding Spec
but failed.

This fixes behaviour, if user is writing list item (MapEntryNode),
and whole list (MapNode) does not exists, list is automatically
added.

Change-Id: I41e0e30d349720f50697a6f555bab5850ec7d30c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 1283: Made return types of AsyncDataChangeEvent consistent 95/8595/2
Tony Tkacik [Thu, 3 Jul 2014 07:54:52 +0000 (09:54 +0200)]
Bug 1283: Made return types of AsyncDataChangeEvent consistent

Change-Id: I3ba1209809cc4b374fbb561537e2684682495774
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Bug 560: Fixed Mount Point RPC registration service"
Tony Tkacik [Mon, 7 Jul 2014 09:44:06 +0000 (09:44 +0000)]
Merge "Bug 560: Fixed Mount Point RPC registration service"

6 years agoMerge "Created Proper Feature File for AD-SAL"
Ed Warnicke [Fri, 4 Jul 2014 22:36:57 +0000 (22:36 +0000)]
Merge "Created Proper Feature File for AD-SAL"

6 years agoMerge "Introduce SimpleNormalizedNodeMessage for serialization of NormalizedNode...
Ed Warnicke [Fri, 4 Jul 2014 22:25:13 +0000 (22:25 +0000)]
Merge "Introduce SimpleNormalizedNodeMessage for serialization of NormalizedNode using protobuff Introduce EncoderDecoderUtil that helps in encode/decode of NormalizedNode usig protobuff Created Distributed Datastore messages in protobuff Included command to remove trailing spaces in the generated java sources of protobuf"

6 years agoMerge "Initial MD-SAL XML for Distributed Data Store"
Ed Warnicke [Fri, 4 Jul 2014 22:24:43 +0000 (22:24 +0000)]
Merge "Initial MD-SAL XML for Distributed Data Store"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.