controller.git
5 years agoMerge "Cleanup RpcRoutingStrategy definition"
Tony Tkacik [Mon, 27 Oct 2014 09:28:04 +0000 (09:28 +0000)]
Merge "Cleanup RpcRoutingStrategy definition"

5 years agoMerge "BUG-1612 Update netconf testtool to use new ssh server wrapper"
Tony Tkacik [Mon, 27 Oct 2014 09:17:26 +0000 (09:17 +0000)]
Merge "BUG-1612 Update netconf testtool to use new ssh server wrapper"

5 years agoMerge "BUG-1612 Implement mina ssh netconf server endpoint"
Tony Tkacik [Mon, 27 Oct 2014 09:17:14 +0000 (09:17 +0000)]
Merge "BUG-1612 Implement mina ssh netconf server endpoint"

5 years agoMerge "Fix failing reconnect test."
Tony Tkacik [Mon, 27 Oct 2014 08:27:13 +0000 (08:27 +0000)]
Merge "Fix failing reconnect test."

5 years agoMerge "BUG-2184 Fix subtree filtering for identity-ref leaves"
Tony Tkacik [Mon, 27 Oct 2014 08:26:36 +0000 (08:26 +0000)]
Merge "BUG-2184 Fix subtree filtering for identity-ref leaves"

5 years agoMerge "BUG-2184 Fix config.yang module(add type as a key for modules list)"
Tony Tkacik [Mon, 27 Oct 2014 08:26:25 +0000 (08:26 +0000)]
Merge "BUG-2184 Fix config.yang module(add type as a key for modules list)"

5 years agoMerge "Bug-2136 : Clustering : When a transaction is local then do not serialize...
Tom Pantelis [Fri, 24 Oct 2014 21:39:29 +0000 (21:39 +0000)]
Merge "Bug-2136 : Clustering : When a transaction is local then do not serialize the Reading/Writing of data"

5 years agoBUG-1612 Update netconf testtool to use new ssh server wrapper 42/11842/4
Maros Marsalek [Tue, 7 Oct 2014 17:44:35 +0000 (19:44 +0200)]
BUG-1612 Update netconf testtool to use new ssh server wrapper

Change-Id: I8625f8d34df65f6d7e47ad77d393f482afa1abdf
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-1612 Implement mina ssh netconf server endpoint 40/11840/4
Maros Marsalek [Mon, 6 Oct 2014 16:09:10 +0000 (18:09 +0200)]
BUG-1612 Implement mina ssh netconf server endpoint

Extract sessionCloseCallback and readHandler from AsyncSshHandlerReader

Change-Id: I0e09341fd59f74f7ac57688414a6dac7c9823b8a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoFix failing reconnect test. 33/12233/1
Maros Marsalek [Fri, 24 Oct 2014 13:34:16 +0000 (15:34 +0200)]
Fix failing reconnect test.

Test verified that session that was dropped during negotiation was not reconnected.
This is no longer true, so the test is failing. However not on jenkins.

Change-Id: I5f416a3397c33607e5004dc48f9569d9da992326
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "[Fix for Bug 1631] - Refactored RaftActorBehavior#handleMessage (and related...
Moiz Raja [Fri, 24 Oct 2014 06:23:22 +0000 (06:23 +0000)]
Merge "[Fix for Bug 1631] - Refactored RaftActorBehavior#handleMessage (and related methods) to return RaftActorBehavior   instead of RaftActorState. - Moved behavior switching from RaftActor based on requested state to the implementations of the   behaviors that should control that switch (Leader/Follower/Candidate) based on the type of   message received. - Pull up logger reference for concrete RAFT behaviors to parent for a common LOG reference. - Updated all logger calls to:   - Use substitution instead of String concatenation.  - Debug logger calls are gated by isDebugEnabled check.  - Correctly use Akka logging API for stack trace on exception.  - Avoid toString() calls during logging.  - Use assigned logger instance (LOG) instead of call to context.getLogger()"

5 years ago[Fix for Bug 1631] 65/11965/5
mark.mozolewski [Tue, 14 Oct 2014 23:05:57 +0000 (16:05 -0700)]
[Fix for Bug 1631]
- Refactored RaftActorBehavior#handleMessage (and related methods) to return RaftActorBehavior
  instead of RaftActorState.
- Moved behavior switching from RaftActor based on requested state to the implementations of the
  behaviors that should control that switch (Leader/Follower/Candidate) based on the type of
  message received.
- Pull up logger reference for concrete RAFT behaviors to parent for a common LOG reference.
- Updated all logger calls to:
  - Use substitution instead of String concatenation.
- Debug logger calls are gated by isDebugEnabled check.
- Correctly use Akka logging API for stack trace on exception.
- Avoid toString() calls during logging.
- Use assigned logger instance (LOG) instead of call to context.getLogger()

Change-Id: I376e21734a0540aae714fe9ef1562d74e73e558b
Signed-off-by: mark.mozolewski <mark.mozolewski@hp.com>
5 years agoBug 2002: Classpath error when loading neutron northbound api 88/12188/1
Sam Hague [Wed, 22 Oct 2014 01:51:27 +0000 (21:51 -0400)]
Bug 2002: Classpath error when loading neutron northbound api

Add the org.eclipse.persistence.antlr to the odl-pseristence feture. There are weird timing issues where if the antlr bundle is not loaded before core and moxy then the classes in antlr cannot be found.

Change-Id: I8fd30b5fb215b8a25512deac45e80099c91c539e
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit 3ee4966ad2d840a907fae33ff74037d599765742)

5 years agoBUG-2184 Fix subtree filtering for identity-ref leaves 65/12165/1
Maros Marsalek [Wed, 22 Oct 2014 15:49:19 +0000 (17:49 +0200)]
BUG-2184 Fix subtree filtering for identity-ref leaves

Change-Id: I7d367c793a461ae26f56ddf611f7e45a723f28fc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-2184 Fix config.yang module(add type as a key for modules list) 69/12069/2
Maros Marsalek [Mon, 20 Oct 2014 10:46:28 +0000 (12:46 +0200)]
BUG-2184 Fix config.yang module(add type as a key for modules list)

Netconf server requires the type and name when e.g. deleting data so the yang model did not fully reflect the implementation

Change-Id: If4b04fe1ec427cff0f52d743cc1440fc7fe143d2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "BUG-2207 Make reconnect promise reconnect even if session was dropped during...
Tony Tkacik [Wed, 22 Oct 2014 13:09:27 +0000 (13:09 +0000)]
Merge "BUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation"

5 years agoMerge "BUG-2217 Add missing namespace to serialized inner runtime beans"
Tony Tkacik [Wed, 22 Oct 2014 11:52:44 +0000 (11:52 +0000)]
Merge "BUG-2217 Add missing namespace to serialized inner runtime beans"

5 years agoBUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation 58/11858/4
Maros Marsalek [Thu, 9 Oct 2014 15:23:25 +0000 (17:23 +0200)]
BUG-2207 Make reconnect promise reconnect even if session was dropped during negotiation

Change-Id: I58adc2e42bb8ce09bfb8b5cd214a91300bb2bbb0
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG 1833 : Remove all unused code from sal-clustering-commons 30/12130/1
Moiz Raja [Tue, 21 Oct 2014 21:12:19 +0000 (14:12 -0700)]
BUG 1833 : Remove all unused code from sal-clustering-commons

Change-Id: I7ce05b4ee77b6151f361091b18d1a7bbd8ed408a
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 4861f2406206bf208a07a703ad8d6808072c6e45)

5 years agoMerge "Bug2174: XSQL log file is hardcode to /tmp/xql.log"
Moiz Raja [Tue, 21 Oct 2014 19:51:29 +0000 (19:51 +0000)]
Merge "Bug2174: XSQL log file is hardcode to /tmp/xql.log"

5 years agoMerge "Add support for metadata to the Match/Action classes"
Alessandro Boch [Mon, 20 Oct 2014 16:12:08 +0000 (16:12 +0000)]
Merge "Add support for metadata to the Match/Action classes"

5 years agoBUG-2217 Add missing namespace to serialized inner runtime beans 71/12071/1
Maros Marsalek [Mon, 20 Oct 2014 11:17:22 +0000 (13:17 +0200)]
BUG-2217 Add missing namespace to serialized inner runtime beans

Change-Id: I267c23ec620bacbd800ee171f37413d4f5997f69
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Add get-config commit edit-config to testtool"
Tony Tkacik [Mon, 20 Oct 2014 09:19:04 +0000 (09:19 +0000)]
Merge "Add get-config commit edit-config to testtool"

5 years agoMerge "Issue fix for config subsystem"
Tony Tkacik [Mon, 20 Oct 2014 09:18:40 +0000 (09:18 +0000)]
Merge "Issue fix for config subsystem"

5 years agoAdd get-config commit edit-config to testtool 46/12046/6
Maros Marsalek [Fri, 17 Oct 2014 09:58:07 +0000 (11:58 +0200)]
Add get-config commit edit-config to testtool

Change-Id: Ie85c839c2077b9d7ca560dc42120268501acb8b0
Signed-off-by: Andrej Socha <ansocha@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug2174: XSQL log file is hardcode to /tmp/xql.log 90/11890/2
Christopher O'Shea [Fri, 10 Oct 2014 17:18:46 +0000 (10:18 -0700)]
Bug2174: XSQL log file is hardcode to /tmp/xql.log

Change XSQL to point to java.io.tmpdir which should be data\tmp\xql.log

Change-Id: I811064dd28ce2f4cdb661c7bf968a1cee21d32be
Signed-off-by: Christopher O'Shea <christopher.o.shea@ericsson.com>
5 years agoIssue fix for config subsystem 99/11999/1
Filip Tehlar [Thu, 16 Oct 2014 10:42:12 +0000 (12:42 +0200)]
Issue fix for config subsystem

Change-Id: I73d02158accb65c92dabc76eb8b353b052ac2d05
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
5 years agoMerge "Bug 1577: Gates access to Shard actor until its initialized"
Moiz Raja [Wed, 15 Oct 2014 19:36:01 +0000 (19:36 +0000)]
Merge "Bug 1577: Gates access to Shard actor until its initialized"

5 years agoMerge "Fixes bug 2114"
Devin Avery [Wed, 15 Oct 2014 16:25:07 +0000 (16:25 +0000)]
Merge "Fixes bug 2114"

5 years agoAdd support for metadata to the Match/Action classes 55/11755/2
Giovanni Meo [Mon, 6 Oct 2014 10:09:25 +0000 (12:09 +0200)]
Add support for metadata to the Match/Action classes

- Allow to attach some property to Match and Action so they can be
used for passing extra informations, that applications can use.

Change-Id: I4225271d7cd3429b11adb191ae178f541bbd635d
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
5 years agoMerge "BUG 720 - YANG leaf as JSON input *<*:* couldn't be saved"
Devin Avery [Wed, 15 Oct 2014 09:38:56 +0000 (09:38 +0000)]
Merge "BUG 720 - YANG leaf as JSON input *<*:* couldn't be saved"

5 years agoBUG 720 - YANG leaf as JSON input *<*:* couldn't be saved 66/11566/3
Jozef Gloncak [Thu, 25 Sep 2014 08:18:02 +0000 (10:18 +0200)]
BUG 720 - YANG leaf as JSON input *<*:* couldn't be saved

If input value for leaf in JSON format contained opending angle bracket
(<) followed by collon (:) then exception was raised.

Because schema isn't present at time of JSON input reading it was also
supposed that data could be of type leafref which is specified in format
module:value. Module part is then transformed to instance of URI object.

Chracter < isn't permitted in URI according RFC2396 for URI and while
creating instance of URI class the exception which wasn't caught was
raised and transformed to returning error message.

Change-Id: I46bb949b38623f62a02daf4390c373371775ae1f
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoCleanup RpcRoutingStrategy definition 08/11308/5
Robert Varga [Wed, 17 Sep 2014 12:44:20 +0000 (14:44 +0200)]
Cleanup RpcRoutingStrategy definition

Adds preconditions and final keywords as appropriate, removes single-use
private static constructors.

Change-Id: If3bc7c46cb46edb1e2059453f42e1bfc521af46d
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoFix compilation after jacoco version bump 41/11941/1
Robert Varga [Tue, 14 Oct 2014 09:34:11 +0000 (11:34 +0200)]
Fix compilation after jacoco version bump

The plugin configuration for 0.6.3+ has been changed incompatibly, so
fix it up.

Change-Id: Ia8e96f9a98e18810680e18f9bd59cbb54873c331
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBug-2136 : Clustering : When a transaction is local then do not serialize the Reading... 34/11934/8
Kamal Rameshan [Wed, 22 Oct 2014 03:06:09 +0000 (20:06 -0700)]
Bug-2136 : Clustering : When a transaction is local then do not serialize the Reading/Writing of data

Ensured that the TransactionContext created for each shard within the transaction has a flag isShardLocal.
if the flag is false, we would be using ProfoBuf to serialize.

Change-Id: I3dc754ae58566212237a6ce385e5f5bb63afd4e0
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoMerge "Update the XSQL jdbc driver to support pentaho"
Moiz Raja [Fri, 10 Oct 2014 17:34:00 +0000 (17:34 +0000)]
Merge "Update the XSQL jdbc driver to support pentaho"

5 years agoAdding restconf to the opendaylight-karaf distribution 62/11862/2
Colin Dixon [Thu, 9 Oct 2014 19:46:35 +0000 (14:46 -0500)]
Adding restconf to the opendaylight-karaf distribution

Change-Id: I91cbee656e2f4da2af62f8a26e7800401f9c6aa4
Signed-off-by: Colin Dixon <colin@colindixon.com>
5 years agoMerge "Bug 2003: CDS serialization improvements"
Moiz Raja [Thu, 9 Oct 2014 19:24:19 +0000 (19:24 +0000)]
Merge "Bug 2003: CDS serialization improvements"

5 years agoBug 2135: Create ShardInformation on startup 33/12033/5
tpantelis [Wed, 8 Oct 2014 11:21:43 +0000 (07:21 -0400)]
Bug 2135: Create ShardInformation on startup

Modified the ShardManager to create the ShardInformation map on startup,
but without creating the shard actors yet, instead of when the SchemaContext is initialized.

When the SchemaContext is fully initialized then create the shard actors.

On FindLocalShard and FindPrimaryShard messages, only return a valid
response if the shard actor is created and it's initialized.

Change-Id: I361f2af9e53878f62c5890350afd7a5f2877b95c
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Bug 2160: Added concurrent 3-phase commit coordinator"
Moiz Raja [Fri, 17 Oct 2014 16:20:25 +0000 (16:20 +0000)]
Merge "Bug 2160: Added concurrent 3-phase commit coordinator"

5 years agoMerge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."
Tony Tkacik [Fri, 17 Oct 2014 15:01:54 +0000 (15:01 +0000)]
Merge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."

5 years agoMerge "Bug 2038: Ensure only one concurrent 3-phase commit in Shard"
Moiz Raja [Fri, 17 Oct 2014 14:56:16 +0000 (14:56 +0000)]
Merge "Bug 2038: Ensure only one concurrent 3-phase commit in Shard"

5 years agoBug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods. 51/12051/1
Tony Tkacik [Fri, 17 Oct 2014 14:05:21 +0000 (16:05 +0200)]
Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods.

Some components in controller still used methods which was deprecated
before Helium and was removed after Helium was released to accomodate
API changes for 0.7.0 Yangtools. This patch migrates code to replacement
methods.

Change-Id: Ia7ef044eb3af4f5652dc71d9cba2bb64efd95187
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoMerge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."
Tony Tkacik [Fri, 17 Oct 2014 13:35:10 +0000 (13:35 +0000)]
Merge "Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods."

5 years agoBug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods. 47/12047/4
Tony Tkacik [Fri, 17 Oct 2014 12:05:06 +0000 (14:05 +0200)]
Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods.

Some components in controller still used methods which was deprecated
before Helium and was removed after Helium was released to accomodate
API changes for 0.7.0 Yangtools. This patch migrates code to replacement
methods.

Change-Id: I146a08caefeb0d666223cf66600a4342a5b49165
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoMerge "Migrate netconf testtool to work with karaf distribution"
Tony Tkacik [Fri, 17 Oct 2014 13:00:50 +0000 (13:00 +0000)]
Merge "Migrate netconf testtool to work with karaf distribution"

5 years agoMerge "Bug 1764 - added service for pushing default node configuration"
Tony Tkacik [Fri, 17 Oct 2014 10:56:13 +0000 (10:56 +0000)]
Merge "Bug 1764 - added service for pushing default node configuration"

5 years agoMerge "Add features-netconf-connector to controller karaf distro"
Tony Tkacik [Fri, 17 Oct 2014 10:13:30 +0000 (10:13 +0000)]
Merge "Add features-netconf-connector to controller karaf distro"

5 years agoMerge "BUG-2006: Rework state tracking"
Tony Tkacik [Fri, 17 Oct 2014 09:17:35 +0000 (09:17 +0000)]
Merge "BUG-2006: Rework state tracking"

5 years agoMigrate netconf testtool to work with karaf distribution 32/11532/4
Maros Marsalek [Thu, 16 Oct 2014 15:41:07 +0000 (17:41 +0200)]
Migrate netconf testtool to work with karaf distribution

Make testtool part of default build process.

Change-Id: Ie957bcf2a38405fee979a6f8547b328d3bd8e2ea
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoAdd features-netconf-connector to controller karaf distro 27/12027/2
Maros Marsalek [Thu, 16 Oct 2014 15:40:37 +0000 (17:40 +0200)]
Add features-netconf-connector to controller karaf distro

Change-Id: I44bf8d82f35586a03950d5ef2f26a321931cb8c6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2038: Ensure only one concurrent 3-phase commit in Shard 95/11795/10
tpantelis [Sun, 5 Oct 2014 03:05:16 +0000 (23:05 -0400)]
Bug 2038: Ensure only one concurrent 3-phase commit in Shard

Added a ShardCommitCoordinator class that ensures there's only one
concurrent 3-phase commit.

The following outlines the new commit workflow:

- On ready, the ShardTransaction creates the dom store cohort and
forwards a new ForwardedReadyTransaction message to the shard.

- The shard calls its ShardCommitCoordinator to add the cohort and
modificaton to a cached keyed by transaction ID.

- On CanCommitTransaction message, the ShardCommitCoordinator looks up and removes
the cohort entry from the cache corresponding to the transaction ID
passed via the CanCommit message. The ShardCommitCoordinator also caches
the cohort entry for the current transaction in progress. If there's no
transaction in progress, the committing transaction becomes the current
transaction and canCommit is called on the cohort. Otherwise, the cohort
entry is queued to be processed after the current tranaction completes.

- On CommitTransaction message, if the transaction ID passed via the
Commit message matches the currently cached cohort entry, the preCommit
and commit phases are performed. When complete, the ShardCommitCoordinator
dequeues the next waiting transaction cohort entry, if any, and process
it.

If a Tx is aborted and it is the current transaction, the
ShardCommitCoordinator handles it as a completed Tx.

Implemented a timeout mechanism using the akka scheduler such that if
the commit message isn't received after a period of time (default 30 s)
after the canCommit message, the transaction is aborted so that the next
transaction can proceed. This is to handle remote node or network
failures during a 3-phrase commit.

The ThreePhaseCommitCohort actor was removed along with the
ForwardedCommitTransaction.

Change-Id: Iaa5692ca45cd7635d1a06a609f4bf98bec50df14
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoMerge "Bug 1965: Fixed DataChangedReply sent to deadletters"
Moiz Raja [Thu, 16 Oct 2014 20:51:59 +0000 (20:51 +0000)]
Merge "Bug 1965: Fixed DataChangedReply sent to deadletters"

5 years agoMerge "Bug-1607: Clustering : Remove actorFor (deprecated) call from TransactionProx...
Moiz Raja [Thu, 16 Oct 2014 17:03:23 +0000 (17:03 +0000)]
Merge "Bug-1607:  Clustering : Remove actorFor (deprecated) call from TransactionProxy.java"

5 years agoBug 1764 - added service for pushing default node configuration 00/12000/4
Martin Bobak [Thu, 16 Oct 2014 05:29:05 +0000 (07:29 +0200)]
Bug 1764 - added service for pushing default node configuration

Change-Id: I8018c639ce05118722c8f33ca842436cca44372e
Signed-off-by: Martin Bobak <mbobak@cisco.com>
5 years agoMerge "BUG 2047 - HTTP GET - no returning error message"
Tony Tkacik [Thu, 16 Oct 2014 13:21:40 +0000 (13:21 +0000)]
Merge "BUG 2047 - HTTP GET - no returning error message"

5 years agoMerge "BUG 1966 - change message logging level (info -> trace)"
Tony Tkacik [Thu, 16 Oct 2014 13:03:16 +0000 (13:03 +0000)]
Merge "BUG 1966 - change message logging level (info -> trace)"

5 years agoMerge "Bug 2131 - NPE when starting controller"
Tony Tkacik [Thu, 16 Oct 2014 13:02:09 +0000 (13:02 +0000)]
Merge "Bug 2131 - NPE when starting controller"

5 years agoBUG-2006: Rework state tracking 17/11417/5
Robert Varga [Thu, 18 Sep 2014 13:53:24 +0000 (15:53 +0200)]
BUG-2006: Rework state tracking

Separate out the two embedded classes to allow easier analysis of
interactions. Introduce a state-tracking class within
DOMStoreTransactionChainImpl with three distinct states: Idle, Allocated
and Shutdown. The allocated state has an internal sub-state when the
transaction has been readied. Perform atomic state transitions using
compare-and-swap.

Change-Id: I4b852d42455d7e07076c56af3626f804ba572770
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge changes I879118ce,I664b391e
Tony Tkacik [Thu, 16 Oct 2014 10:09:05 +0000 (10:09 +0000)]
Merge changes I879118ce,I664b391e

* changes:
  BUG-2017 Fix possible concurrent modification ex in config subsystem
  BUG-1520 Set correct factory in ImmediateEventExecutorModuleTest

5 years agoMerge "BUG-1958 Fix leafref path in config-yang module."
Tony Tkacik [Thu, 16 Oct 2014 10:08:50 +0000 (10:08 +0000)]
Merge "BUG-1958 Fix leafref path in config-yang module."

5 years agoMerge "BUG-1521 netconf-impl & netconf-monitoring line coverage."
Tony Tkacik [Thu, 16 Oct 2014 10:08:13 +0000 (10:08 +0000)]
Merge "BUG-1521 netconf-impl & netconf-monitoring line coverage."

5 years agoBug-1607: Clustering : Remove actorFor (deprecated) call from TransactionProxy.java 34/11834/4
Kamal Rameshan [Wed, 8 Oct 2014 21:09:37 +0000 (14:09 -0700)]
Bug-1607:  Clustering : Remove actorFor (deprecated) call from TransactionProxy.java

1. Changes to use ActorSelection instead of ActorPath
2. Removed actorFor usage
3. Removed resolvePath calls
4. Changes in test classes.

Rebased.

Change-Id: I8fdc18a1ac18d75d1b6d5c8cd0da986e19d08280
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoUpdate the XSQL jdbc driver to support pentaho 24/11724/5
Sharon Aicler [Fri, 3 Oct 2014 15:36:10 +0000 (08:36 -0700)]
Update the XSQL jdbc driver to support pentaho

Change-Id: I72f54b36a87c84c9fa493a1d35300b241a53ec34
Signed-off-by: Sharon Aicler <saichler@cisco.com>
5 years agoBug 1965: Fixed DataChangedReply sent to deadletters 32/11932/3
tpantelis [Mon, 6 Oct 2014 22:31:18 +0000 (18:31 -0400)]
Bug 1965: Fixed DataChangedReply sent to deadletters

Change-Id: I3a579823d57e113597aabeb647c883d8811f29f1
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoBug 2160: Added concurrent 3-phase commit coordinator 66/11966/3
tpantelis [Tue, 7 Oct 2014 13:34:01 +0000 (09:34 -0400)]
Bug 2160: Added concurrent 3-phase commit coordinator

Added a new class DOMConcurrentDataCommitCoordinator which is an
implementation of DOMDataCommitExecutor that allows multiple concurrent
3-phase transaction commits. The 3 phases are still performed serially and
non-blocking per transaction.

A new flag, "allow-concurrent-commits", was added to the DOM in-memory
data broker's yang config. If true, the new
DOMConcurrentDataCommitCoordinator implementation is used, otherwise the
current implementation is used. The default is false.

The distributed data store will use the concurrent coordinator.

Change-Id: Ie21947d6f9c1086f89686a73442c854c08c07100
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoIncrement the AAA dependency by 0.1.0 for post-Helium master branch 66/11766/2
Colin Dixon [Tue, 7 Oct 2014 02:57:14 +0000 (21:57 -0500)]
Increment the AAA dependency by 0.1.0 for post-Helium master branch

This patch is the second half of the post-Helium version bump patch. It
does two things:
* Increments the version of the depenency on AAA from 0.1.0-SNAPSHOT to
  0.2.0-SNAPSHOT.
* Re-enables the feature tests for the restconf and netconf-conector
  features.

Change-Id: I3160e429a4368ee142a41deb23631f6c1455d358
Signed-off-by: Colin Dixon <colin@colindixon.com>
5 years agoIncrementing versions by 0.1.0 for post-Helium master branch 39/11739/4
Colin Dixon [Fri, 3 Oct 2014 22:55:46 +0000 (17:55 -0500)]
Incrementing versions by 0.1.0 for post-Helium master branch

* The only version not incrmented is aaa.version, which is left at
  0.1.0-SNAPSHOT since they depend on controller and can't update yet.
* To break the cyclic dependency, this patch temporarily stops running
  the netconf-connector and restconf feature tests.
* Also fixing a bug causing Errors like "Choice has two nodes case with
  same qnames".

A second patch (to be run after AAA increments their versions to
0.2.0-SNAPSHOT) wiil update aaa.version and re-enable these tests.

Change-Id: I70a3987d32504e798c5ed05a67a0a1174338844b
Signed-off-by: Colin Dixon <colin@colindixon.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBug 2131 - NPE when starting controller 09/11709/2
Jan Hajnar [Wed, 1 Oct 2014 14:49:25 +0000 (16:49 +0200)]
Bug 2131 - NPE when starting controller

* made InvenroryAndReadAdapter wait for BindingAwareBroker because it
was calling DeteBrokerService before it was available

Change-Id: Ie38415194544997bc12d2dd3acfc57bfa8918730
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
5 years agoBug 2107: Use DataCommitListeners for inventory events 05/11705/5
Ed Warnicke [Wed, 1 Oct 2014 16:40:29 +0000 (09:40 -0700)]
Bug 2107: Use DataCommitListeners for inventory events

Change-Id: I648bba5e7585cc9d1a70f3dcaf6f8fdbcfeb1787
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoFixes bug 2114 88/11688/1
Abhishek Kumar [Wed, 1 Oct 2014 05:16:08 +0000 (22:16 -0700)]
Fixes bug 2114

Adds handling of "leaf" node at the module level.

Change-Id: I55efb47b57d2f33b136b0dae8c82effe04ad706b
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
5 years agoMerge changes I95a821aa,I4a90a3b6,I9f77a16a
Tony Tkacik [Tue, 30 Sep 2014 17:17:39 +0000 (17:17 +0000)]
Merge changes I95a821aa,I4a90a3b6,I9f77a16a

* changes:
  BUG-2078  Stats not being collected from all nodes, dangling nodes left in oper data store after mininet disconnects BUG-2049  DataStore failure in StatisticsManager
  Bug 2106: Refactored FlowCapableInventoryProvider to properly work with failures.
  Bug 2103: Revert "Bug 2101: Do not block processing on transaction submit."

5 years agoBUG-2109 : removed final modifier to allow overriding of negotiationFailed() method 69/11669/1
Dana Kutenicsova [Tue, 30 Sep 2014 13:16:21 +0000 (15:16 +0200)]
BUG-2109 : removed final modifier to allow overriding of negotiationFailed() method

Change-Id: Iffe9dcf061480844ceb8a8278997c28000ec329d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
5 years agoBUG-2078 Stats not being collected from all nodes, dangling nodes left in oper data... 64/11664/4
Vaclav Demcak [Mon, 29 Sep 2014 20:47:24 +0000 (22:47 +0200)]
BUG-2078  Stats not being collected from all nodes, dangling nodes left in oper data store after mininet disconnects
BUG-2049  DataStore failure in StatisticsManager

* fix performance issues
* fix occurrence zombie nodes
* fix NPE for StatCollector
* fix NPE for Meter/Group lists

Change-Id: I95a821aaf308bdb6e989c4a740aa014d5aaab4c2
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBug 2106: Refactored FlowCapableInventoryProvider to properly work with failures. 63/11663/2
Tony Tkacik [Mon, 29 Sep 2014 17:04:40 +0000 (19:04 +0200)]
Bug 2106: Refactored FlowCapableInventoryProvider to properly work with failures.

FlowCapableInventoryProvider was unable to continue if transaction chain
failed during construction of new transaction.

Refactored it in way, that it is able to reconstruct and retry transaction,
which failed because of previous transaction and retries it once
in new transaction chain. If it fails again, it continues with next batch.

Change-Id: I4a90a3b60b0a49d562c8648a779e790f55840b5d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBug 2103: Revert "Bug 2101: Do not block processing on transaction submit." 59/11659/1
Ed Warnicke [Mon, 29 Sep 2014 07:06:35 +0000 (00:06 -0700)]
Bug 2103: Revert "Bug 2101: Do not block processing on transaction submit."

Turns out that the get was throttling the stats manager so
it didn't overwhelm the queue.

This reverts commit 6b3c2a9e446bf91942a48427e5592909a173a399.

Change-Id: I9f77a16a959594c65ed3e61b1265c56da620c1ba
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoMerge "Bug 2103: Make sure InventoryManager survives Transaction failure."
Ed Warnicke [Sat, 27 Sep 2014 23:09:49 +0000 (23:09 +0000)]
Merge "Bug 2103: Make sure InventoryManager survives Transaction failure."

5 years agoMerge "Bug 2101: Do not block processing on transaction submit."
Ed Warnicke [Sat, 27 Sep 2014 22:47:17 +0000 (22:47 +0000)]
Merge "Bug 2101: Do not block processing on transaction submit."

5 years agoMerge "BUG 2049 DataStore failure in StatisticsManager BUG 2101 When L2 switch...
Ed Warnicke [Sat, 27 Sep 2014 22:46:50 +0000 (22:46 +0000)]
Merge "BUG 2049  DataStore failure in StatisticsManager BUG 2101  When L2 switch installed, its flows are interpreted as new flows with each stats request"

5 years agoBug 2103: Make sure InventoryManager survives Transaction failure. 28/11628/1
Tony Tkacik [Sat, 27 Sep 2014 16:13:21 +0000 (18:13 +0200)]
Bug 2103: Make sure InventoryManager survives Transaction failure.

Change-Id: I5896a0b7c3e63d2828361dc93d3582843a35b35d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBug 2101: Do not block processing on transaction submit. 27/11627/3
Tony Tkacik [Sat, 27 Sep 2014 15:25:23 +0000 (17:25 +0200)]
Bug 2101: Do not block processing on transaction submit.

Change-Id: Ibdc75aa670254f84aa70647d655e4e1438edd9e9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
5 years agoBUG 2049 DataStore failure in StatisticsManager 98/11598/13
Vaclav Demcak [Thu, 25 Sep 2014 21:03:30 +0000 (23:03 +0200)]
BUG 2049  DataStore failure in StatisticsManager
BUG 2101  When L2 switch installed, its flows are interpreted as new flows with each stats request

* hashCode is not safe in general so we'd like to prevent Collisions how we can
* we change HashBuilding to KeyBuilding from toString method
* toString is generated in CompileTime
* it can not be change during JVM run
* every one use same YANG model version and jar files
* and the same aproach could by use across claster
* add cleaning disconnected Node from StatListeningCommiter implementers

Change-Id: I645e9f07382af0b293bc43698446b7b84b95bbde
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG 2074 : clustering.services-implementation failed to register listner. 21/11621/1
Moiz Raja [Sat, 27 Sep 2014 00:53:10 +0000 (17:53 -0700)]
BUG 2074 : clustering.services-implementation failed to register listner.

The adsal feature depends on both the stub and implementaton of clustering.
This causes a problem when deployed because sometimes the stub is wired in first
which leads to createCache requests going to that implementation. Subsequently
the real implementation gets wired in and add listener calls go there but since
the caches were created on the stub this fails.

This patch removes the stub as a dependency with the assumption that it is not
required in production.

Change-Id: I42203bbf31b46560c23f283ddd83e56bd950830b
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 1577: Gates access to Shard actor until its initialized 15/11415/4
Abhishek Kumar [Sat, 20 Sep 2014 08:19:11 +0000 (01:19 -0700)]
Bug 1577: Gates access to Shard actor until its initialized

1. Shard manager creates Shard and mark them un-initialized.
   Shard completes recovery and onRecoveryComplete, sends a
   message to Shard manager to mark it initialized.
   If a request for Shard comes to Shard manager and the
   shard is not initialized, it sends ActorNotInitialized
   message.

2. Normalizes and refactors ActorContext.

3. Adds AbstractUntypedPersistentActorWithMetering to meter
   ShardManager.

Change-Id: Ibf15a2ef56422bda53067039d2271a719b6b2ce3
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
5 years agoBUG-1958 Fix leafref path in config-yang module. 88/11588/1
Maros Marsalek [Thu, 25 Sep 2014 15:29:57 +0000 (17:29 +0200)]
BUG-1958 Fix leafref path in config-yang module.

When using a condition in the path, the value that is compared has to be a leaf reaf

Change-Id: I898b9448099fd7240aea49cc1c3fe40e9ee7c3d0
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG 2047 - HTTP GET - no returning error message 63/11563/1
Jozef Gloncak [Thu, 25 Sep 2014 06:19:36 +0000 (08:19 +0200)]
BUG 2047 - HTTP GET - no returning error message

Error message was added to NormalizedNodeXmlBodyWriter.

Change-Id: I43914eaa62149b66303cef956f73e694fae9217f
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoBUG-2049: DataStore failure in StatisticsManager 39/11539/2
Michal Rehak [Wed, 24 Sep 2014 16:21:38 +0000 (18:21 +0200)]
BUG-2049: DataStore failure in StatisticsManager

!WORKAROUND ONLY

- during node reconciliation statsManager could join together 2 similar
  sets of statistics notifications and hit duplicate values during
  processing - here we just skip those duplicates in order not to loose
  stats working thread and finish actual multipart

Change-Id: I526ab5439055ac565bfaa08e84e5043e8764846a
Signed-off-by: Michal Rehak <mirehak@cisco.com>
5 years agoBUG 1966 - change message logging level (info -> trace) 22/11522/1
Jozef Gloncak [Wed, 24 Sep 2014 13:11:31 +0000 (15:11 +0200)]
BUG 1966 - change message logging level (info -> trace)

Change-Id: Idff363361f5d283edf25ac656a519bc8232a9393
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoMerge "Bug 1948: Finish separating out restconf features"
Moiz Raja [Wed, 24 Sep 2014 05:20:26 +0000 (05:20 +0000)]
Merge "Bug 1948: Finish separating out restconf features"

5 years agoMerge "Bug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid...
Ed Warnicke [Wed, 24 Sep 2014 03:39:14 +0000 (03:39 +0000)]
Merge "Bug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid cross origin error"

5 years agoBug 1948: Finish separating out restconf features 74/11474/3
Ed Warnicke [Tue, 23 Sep 2014 02:24:47 +0000 (21:24 -0500)]
Bug 1948: Finish separating out restconf features

In order to avoid a maven project cycle in solving
Bug 1948, we needed to separate restconf features.
Note, this is the second step, removing the suffix
 -new.

Change-Id: I3cad2e72141bd78a212dda71b4ef81ba6ab6555a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoMerge "Pulled the RPC query out of the data schema loop, so that modules that only...
Ed Warnicke [Wed, 24 Sep 2014 03:04:12 +0000 (03:04 +0000)]
Merge "Pulled the RPC query out of the data schema loop, so that modules that only contain RPCs will also be picked up."

5 years agoBug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid cross... 04/11504/3
Harman Singh [Tue, 23 Sep 2014 23:26:58 +0000 (16:26 -0700)]
Bug 2030 : Adding jetty corsfilter in restconf and docgen bundles to avoid cross origin error

Change-Id: I47b860b5c092d54e0ae106b2b832c021502ad52f
Signed-off-by: Harman Singh <harmasin@cisco.com>
5 years agoMerge "Bug 2019: Have FeatureConfigPusher retry installedFeature check until it succe...
Moiz Raja [Tue, 23 Sep 2014 20:06:31 +0000 (20:06 +0000)]
Merge "Bug 2019: Have FeatureConfigPusher retry installedFeature check until it succeeds (or 100ms pass)."

5 years agoBug#2056 odl:xsql karaf command is throwing NPE when empty args 98/11498/1
Sharon Aicler [Tue, 23 Sep 2014 18:40:46 +0000 (11:40 -0700)]
Bug#2056 odl:xsql karaf command is throwing NPE when empty args

Change-Id: I60b6321aea4e02e4a7b409645bc8ebcec9a39112
Signed-off-by: Sharon Aicler <saichler@cisco.com>
5 years agoBug 2019: Have FeatureConfigPusher retry installedFeature check 96/11496/1
Ed Warnicke [Tue, 23 Sep 2014 17:08:42 +0000 (12:08 -0500)]
Bug 2019: Have FeatureConfigPusher retry installedFeature check
until it succeeds (or 100ms pass).

Karaf reports FeatureEvents before it marks the features
installed.  It also only guarantees complete info about
the features when you read the installed ones.  This
is causing a race condition that is at the root of 2019.

So this patch retries at 1ms intervals until we see

Change-Id: I67080475fc4b2dc2f053a286424f676f89164b6e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoMerge "Bug 1948: Separate out restconf features."
Devin Avery [Tue, 23 Sep 2014 16:44:11 +0000 (16:44 +0000)]
Merge "Bug 1948: Separate out restconf features."

5 years agoBUG-1521 netconf-impl & netconf-monitoring line coverage. 79/11479/2
Filip Tehlar [Tue, 23 Sep 2014 08:24:06 +0000 (10:24 +0200)]
BUG-1521 netconf-impl & netconf-monitoring line coverage.

Change-Id: Iad7fdaffb3ffeda331f487e2725e2500c6f31c86
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
5 years agoPulled the RPC query out of the data schema loop, so that 75/11475/1
David K. Bainbridge [Tue, 23 Sep 2014 03:35:45 +0000 (20:35 -0700)]
Pulled the RPC query out of the data schema loop, so that
modules that only contain RPCs will also be picked up.

Signed-off-by: David K. Bainbridge <dbainbri@ciena.com>
Change-Id: I63981d2126209263a762acbc190f4ad15f4dd725

5 years agoMerge "Bug 2026: Fix for Neutron REST API NullPointer exception on POST Port when...
Ed Warnicke [Tue, 23 Sep 2014 02:35:06 +0000 (02:35 +0000)]
Merge "Bug 2026: Fix for Neutron REST API NullPointer exception on POST Port when no fisxed-ips are present"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.