controller.git
7 years agoMerge "Remove unused DefaultNetconfOperation marker"
Ed Warnicke [Wed, 12 Feb 2014 15:29:27 +0000 (15:29 +0000)]
Merge "Remove unused DefaultNetconfOperation marker"

7 years agoRemoved redundant dependency on configuration artifact 82/5282/1
Martin Bobak [Wed, 12 Feb 2014 12:51:51 +0000 (13:51 +0100)]
Removed redundant dependency on configuration artifact

Change-Id: Ifae0e3071c08ddc7363af1fdb05d97e2b22e4329
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoMerge "Fixed removals from data store did not clean direct-match indexes to child...
Ed Warnicke [Wed, 12 Feb 2014 06:57:08 +0000 (06:57 +0000)]
Merge "Fixed removals from data store did not clean direct-match indexes to child nodes."

7 years agoMerge "Fixed bug when publisher's thread was blocked until all notifications were...
Ed Warnicke [Wed, 12 Feb 2014 06:56:15 +0000 (06:56 +0000)]
Merge "Fixed bug when publisher's thread was blocked until all notifications were delivered."

7 years agoAuthenticatedUser not to expose internal implementation 79/5279/2
Alessandro Boch [Wed, 12 Feb 2014 04:55:12 +0000 (20:55 -0800)]
AuthenticatedUser not to expose internal implementation

Update unit test

Change-Id: I9606742fbdfe3bbbae8bbf789e130d24bd946d82
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFixed removals from data store did not clean direct-match indexes to child 70/5270/1
Tony Tkacik [Wed, 12 Feb 2014 00:19:23 +0000 (01:19 +0100)]
Fixed removals from data store did not clean direct-match indexes to child
nodes.

  - Added deepRemoveStrategy, which checks for all quick indexes
    if they are removed correctly.

Change-Id: Icb7a231ca0308774f76b43ac40ab4eaf47e68937
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoProvide Switch Information in Troubleshooting Tab 69/5269/1
Sapan Shah [Tue, 11 Feb 2014 22:51:27 +0000 (14:51 -0800)]
Provide Switch Information in Troubleshooting Tab

Change-Id: I5fc02b4c6ac5babbe21cc082aa4723882846568a
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoFixed bug when publisher's thread was blocked until all notifications were delivered. 66/5266/1
Tony Tkacik [Tue, 11 Feb 2014 18:35:42 +0000 (19:35 +0100)]
Fixed bug when publisher's thread was blocked until all notifications were delivered.

Change-Id: Ieb083feec0ac6a64877fb045fa4fa6ba6e3fa412
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoRemove unused DefaultNetconfOperation marker 12/5212/4
Robert Varga [Sun, 9 Feb 2014 15:48:01 +0000 (16:48 +0100)]
Remove unused DefaultNetconfOperation marker

DefaultCloseSession and DefaultGetSchema do not need the netconf
session. so drop their use of DefaultNetconfOperation.

Change-Id: I724bd56d913b0f836c88ca8d1b436be308852a30
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix yangtools API incompatibility 57/5257/1
Robert Varga [Tue, 11 Feb 2014 14:42:42 +0000 (15:42 +0100)]
Fix yangtools API incompatibility

Change-Id: Ia6883492a49765f1ffcd38128fcd6084636bc470
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Do not use deprecated StringBufferInputStream"
Ed Warnicke [Tue, 11 Feb 2014 01:51:42 +0000 (01:51 +0000)]
Merge "Do not use deprecated StringBufferInputStream"

7 years agoMerge "Fix a warning"
Ed Warnicke [Tue, 11 Feb 2014 01:51:11 +0000 (01:51 +0000)]
Merge "Fix a warning"

7 years agoMerge "Remove deprecated API elements from protocol framework"
Ed Warnicke [Tue, 11 Feb 2014 01:47:28 +0000 (01:47 +0000)]
Merge "Remove deprecated API elements from protocol framework"

7 years agoMerge "Fix typo in match types yang model"
Ed Warnicke [Tue, 11 Feb 2014 01:34:35 +0000 (01:34 +0000)]
Merge "Fix typo in match types yang model"

7 years agoMerge "Changed model versions to dependencies"
Ed Warnicke [Tue, 11 Feb 2014 01:31:00 +0000 (01:31 +0000)]
Merge "Changed model versions to dependencies"

7 years agoDo not use deprecated StringBufferInputStream 16/5216/2
Robert Varga [Sun, 9 Feb 2014 21:02:56 +0000 (22:02 +0100)]
Do not use deprecated StringBufferInputStream

Change-Id: I745529dd05f2a4156dab98535ba73b81de44872b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix a warning 11/5211/3
Robert Varga [Sun, 9 Feb 2014 15:16:06 +0000 (16:16 +0100)]
Fix a warning

Change-Id: I8605ada63c471d9446ebf7fe31fb518138422cd4
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRewrite POSSIBLE_ENDS and POSSIBLE_STARTS 99/5199/3
Robert Varga [Sat, 8 Feb 2014 02:45:52 +0000 (03:45 +0100)]
Rewrite POSSIBLE_ENDS and POSSIBLE_STARTS

These two are really simple byte arrays, initialized them as such
withouth going through strings/UTF8.

Change-Id: Id80151d9ff57df4b7a5595f76f30a379d89af3dd
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Some methods should be final"
Ed Warnicke [Tue, 11 Feb 2014 00:08:29 +0000 (00:08 +0000)]
Merge "Some methods should be final"

7 years agoMerge "Expose ChannelFuture from sendMessage()"
Ed Warnicke [Mon, 10 Feb 2014 23:50:32 +0000 (23:50 +0000)]
Merge "Expose ChannelFuture from sendMessage()"

7 years agoMerge "Getter methods should be final"
Ed Warnicke [Mon, 10 Feb 2014 23:49:36 +0000 (23:49 +0000)]
Merge "Getter methods should be final"

7 years agoMerge "Fix a warning and make field final"
Ed Warnicke [Mon, 10 Feb 2014 23:44:58 +0000 (23:44 +0000)]
Merge "Fix a warning and make field final"

7 years agoMerge "Remove use of deprecated Exceptions"
Ed Warnicke [Mon, 10 Feb 2014 23:44:08 +0000 (23:44 +0000)]
Merge "Remove use of deprecated Exceptions"

7 years agoMerge "minor pom cleanup to eliminate duplicate group ID specification when the group...
Ed Warnicke [Mon, 10 Feb 2014 23:42:49 +0000 (23:42 +0000)]
Merge "minor pom cleanup to eliminate duplicate group ID specification when the group ID is the same as the parent pom, just removes some warnings from eclipse, should not be any functional difference"

7 years agoSome methods should be final 98/5198/2
Robert Varga [Sat, 8 Feb 2014 04:18:06 +0000 (05:18 +0100)]
Some methods should be final

Change-Id: I8969a8d099222f8360c07e621b9157c4bb5fb8f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Fix warnings reported in toaster"
Ed Warnicke [Mon, 10 Feb 2014 23:36:51 +0000 (23:36 +0000)]
Merge "Fix warnings reported in toaster"

7 years agoMerge "Fix a few eclipse-reported warnings"
Ed Warnicke [Mon, 10 Feb 2014 23:36:04 +0000 (23:36 +0000)]
Merge "Fix a few eclipse-reported warnings"

7 years agoExpose ChannelFuture from sendMessage() 97/5197/2
Robert Varga [Sat, 8 Feb 2014 04:17:00 +0000 (05:17 +0100)]
Expose ChannelFuture from sendMessage()

Change-Id: If76f0c3ab7ce290d50ed7177c08af78cb9f7a354
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGetter methods should be final 96/5196/2
Robert Varga [Fri, 7 Feb 2014 23:40:38 +0000 (00:40 +0100)]
Getter methods should be final

Change-Id: I24eafd9b1319e9296de5680220802820944fe333
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agominor pom cleanup to eliminate duplicate group ID specification when the group ID... 37/5237/1
David K. Bainbridge [Mon, 10 Feb 2014 20:03:51 +0000 (12:03 -0800)]
minor pom cleanup to eliminate duplicate group ID specification when the group ID is the same as the parent pom, just removes some warnings from eclipse, should not be any functional difference

Change-Id: I396126408fff54d7120d3ae94b2a5c447d14f8d2
Signed-off-by: David K. Bainbridge <dbainbri@ciena.com>
7 years agoMerge "Get rid of NetconfMessageFactory"
Ed Warnicke [Mon, 10 Feb 2014 19:44:20 +0000 (19:44 +0000)]
Merge "Get rid of NetconfMessageFactory"

7 years agoMerge "Get rid of DeserializerException"
Ed Warnicke [Mon, 10 Feb 2014 19:44:01 +0000 (19:44 +0000)]
Merge "Get rid of DeserializerException"

7 years agoMerge "Get rid of using ProtocolHandlerFactory, part 2"
Ed Warnicke [Mon, 10 Feb 2014 19:43:32 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 2"

7 years agoMerge "Get rid of using ProtocolHandlerFactory, part 1"
Ed Warnicke [Mon, 10 Feb 2014 19:43:22 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 1"

7 years agoMerge "Cleanup dependencyManagement section"
Ed Warnicke [Mon, 10 Feb 2014 19:42:50 +0000 (19:42 +0000)]
Merge "Cleanup dependencyManagement section"

7 years agoMerge "Remove repositories/pluginRepositories/distributionManagement"
Ed Warnicke [Mon, 10 Feb 2014 19:41:45 +0000 (19:41 +0000)]
Merge "Remove repositories/pluginRepositories/distributionManagement"

7 years agoMerge "Remove duplicate properties"
Ed Warnicke [Mon, 10 Feb 2014 19:41:24 +0000 (19:41 +0000)]
Merge "Remove duplicate properties"

7 years agoMerge "SwitchMgrNB: URL does not allow nodeconnectorId with forward slash"
Alessandro Boch [Mon, 10 Feb 2014 19:33:00 +0000 (19:33 +0000)]
Merge "SwitchMgrNB: URL does not allow nodeconnectorId with forward slash"

7 years agoFix for BUG 410 32/5232/3
Ryan Moats [Mon, 10 Feb 2014 18:02:16 +0000 (12:02 -0600)]
Fix for BUG 410

Ensure lower case alpha hex representation is included in MAC
regex match in all cases.

Change-Id: Ic2da17146cf8f9325cc5d951f70d614ec61762a0
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoSwitchMgrNB: URL does not allow nodeconnectorId with forward slash 06/5206/2
Pramila Singh [Sun, 9 Feb 2014 00:15:10 +0000 (16:15 -0800)]
SwitchMgrNB: URL does not allow nodeconnectorId with forward slash

Change-Id: I489d5ae559b8c1e35a3c7b9749f7476618b2765b
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoMerge "Fixed bugs in getUnsigned methods of NetUtils class."
Alessandro Boch [Mon, 10 Feb 2014 16:49:34 +0000 (16:49 +0000)]
Merge "Fixed bugs in getUnsigned methods of NetUtils class."

7 years agoCleanup dependencyManagement section 44/4744/4
Robert Varga [Fri, 24 Jan 2014 22:37:13 +0000 (23:37 +0100)]
Cleanup dependencyManagement section

Change-Id: I48ab30fc7f96ab0a30e1094f8f9ca5097be0975b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove repositories/pluginRepositories/distributionManagement 43/4743/4
Robert Varga [Fri, 24 Jan 2014 22:30:03 +0000 (23:30 +0100)]
Remove repositories/pluginRepositories/distributionManagement

Change-Id: I1d005ee4ea4881d79c368a009ae2dfa1d643746a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove deprecated API elements from protocol framework 91/5191/2
Robert Varga [Fri, 7 Feb 2014 22:50:42 +0000 (23:50 +0100)]
Remove deprecated API elements from protocol framework

The use of these concepts has been deprecated in version 0.4.0, which
was released. The only in-tree user was netconf, which was refactored to
not to rely on these concepts, so bump the version to 0.5.0 and purge
the  code.

Change-Id: Ibf2195b51bf12ea99b8b21f3da322d666b103b5e
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix a warning and make field final 90/5190/2
Robert Varga [Fri, 7 Feb 2014 22:20:04 +0000 (23:20 +0100)]
Fix a warning and make field final

Drive-by fix
- additionalHeader should be final,
- the class is not serializable, no uuid is needed

Change-Id: I484b07e64942179d153e7c42ca32d753fb2a5b23
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove use of deprecated Exceptions 89/5189/2
Robert Varga [Fri, 7 Feb 2014 22:19:04 +0000 (23:19 +0100)]
Remove use of deprecated Exceptions

DocumentedException and DeserializerException are deprecated and were
only used by deprecated interfaces which we no longer use. Stop using
them.

Change-Id: I899beb6d08be2c4a0b17ecbe6e1ca2be334e12a9
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of NetconfMessageFactory 88/5188/2
Robert Varga [Fri, 7 Feb 2014 22:15:56 +0000 (23:15 +0100)]
Get rid of NetconfMessageFactory

This removes the use of deprecated ProtocolMessageFactory and
ProtocolHandlerFactory. Just instantiate appropriate Netty handlers
instead.

Change-Id: I98b6424af0256483be21c92dfdbe4c0ddbac7a9d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of DeserializerException 87/5187/2
Robert Varga [Fri, 7 Feb 2014 21:19:43 +0000 (22:19 +0100)]
Get rid of DeserializerException

We can throw anything, so use NetconfDeserializerException instead.

Change-Id: Ibf2b7f2778217b19e7b4aaf22571f19fdf3f610f
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of using ProtocolHandlerFactory, part 2 86/5186/2
Robert Varga [Fri, 7 Feb 2014 21:08:39 +0000 (22:08 +0100)]
Get rid of using ProtocolHandlerFactory, part 2

Now that we do not rely on passing it around, we can safely keep
NetconfHandlerFactory wired directly to the
ProtocolMessageEncoder/Decoder.

Change-Id: I47a9b76f8d9bbb98304e06960e5a85d2730994f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of using ProtocolHandlerFactory, part 1 85/5185/3
Robert Varga [Fri, 7 Feb 2014 20:57:07 +0000 (21:57 +0100)]
Get rid of using ProtocolHandlerFactory, part 1

This gets rid of completely dead code in NetconfSshClientDispatcher. It
already talks directly to the initializer.

Change-Id: Ieaac37a3335e87032730cfa65e94bb59f26dd3c1
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove duplicate properties 42/4742/4
Robert Varga [Fri, 24 Jan 2014 22:28:48 +0000 (23:28 +0100)]
Remove duplicate properties

Change-Id: If079f0051241989a4f71e0ac8fa42f3a80e27182
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Cleanup imports/whitespace in MD-SAL"
Ed Warnicke [Mon, 10 Feb 2014 12:20:21 +0000 (12:20 +0000)]
Merge "Cleanup imports/whitespace in MD-SAL"

7 years agoMerge "Adding FlowRef,GroupRef and MeterRef for the ErrorNotification Message"
Ed Warnicke [Mon, 10 Feb 2014 11:56:41 +0000 (11:56 +0000)]
Merge "Adding FlowRef,GroupRef and MeterRef for the ErrorNotification Message"

7 years agoMerge "BUG-362: add some diagnostic information Changed Remote RPC Server Implementat...
Ed Warnicke [Mon, 10 Feb 2014 11:55:41 +0000 (11:55 +0000)]
Merge "BUG-362: add some diagnostic information Changed Remote RPC Server Implementation to log an error when host IP address is not found and stop itself. Earlier it would raise exception that the configuration subsystem could not handle."

7 years agoCleanup imports/whitespace in MD-SAL 83/5183/3
Robert Varga [Fri, 7 Feb 2014 20:01:21 +0000 (21:01 +0100)]
Cleanup imports/whitespace in MD-SAL

Change-Id: I0f18ffe229ed213308a0cd5cf343fd64ff79a17c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "BUG 408"
Ed Warnicke [Mon, 10 Feb 2014 11:53:48 +0000 (11:53 +0000)]
Merge "BUG 408"

7 years agoFixed bugs in getUnsigned methods of NetUtils class. 21/5021/2
Hideyuki Tai [Thu, 30 Jan 2014 10:17:25 +0000 (02:17 -0800)]
Fixed bugs in getUnsigned methods of NetUtils class.

 * Fixed bugs that getUnsignedByte(byte) and getUnsignedShort(short)
   handled 0 incorrectly.
 * Added tests for getUnsignedByte(byte) and getUnsignedShort(short).

Change-Id: Ie67fb5c07bed31d16d4a52068dda7735fb7cd5e2
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
7 years agoFix typo in match types yang model 20/5220/1
Lorand Jakab [Mon, 10 Feb 2014 06:27:16 +0000 (08:27 +0200)]
Fix typo in match types yang model

Change-Id: Ieb1d4e0808042d8278d67e400db02f8141d7425d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoChanged model versions to dependencies 94/5194/1
Tony Tkacik [Sat, 8 Feb 2014 03:20:13 +0000 (04:20 +0100)]
Changed model versions to dependencies

Change-Id: Ib0c5f2f87d82c512302c98159d3b7f6ccb28b547
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoMerge "Fix incorrect validation in SwitchConfig"
Andrew Kim [Sat, 8 Feb 2014 01:11:35 +0000 (01:11 +0000)]
Merge "Fix incorrect validation in SwitchConfig"

7 years agoFix incorrect validation in SwitchConfig 72/5172/2
Alessandro Boch [Fri, 7 Feb 2014 14:20:03 +0000 (06:20 -0800)]
Fix incorrect validation in SwitchConfig

Change-Id: Ie9267b97b8742f9bd5ebbd85a4f0dc05bf1cebd9
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoFix warnings reported in toaster 93/5193/2
Robert Varga [Fri, 7 Feb 2014 23:15:28 +0000 (00:15 +0100)]
Fix warnings reported in toaster

Change-Id: I965594edcd686a5e322cd724ef19c969600077b7
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix a few eclipse-reported warnings 92/5192/2
Robert Varga [Fri, 7 Feb 2014 23:01:27 +0000 (00:01 +0100)]
Fix a few eclipse-reported warnings

- unused suppresswarnings
- missing serialVersionUuid
- missing generic arguments

Change-Id: Ie741e88bfe161a9e4613b4076892cbcabdd0375c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Lower logger level in OF1.0 Discovery Service"
Andrew Kim [Fri, 7 Feb 2014 17:12:01 +0000 (17:12 +0000)]
Merge "Lower logger level in OF1.0 Discovery Service"

7 years agoBUG 408 74/5174/1
Michal Rehak [Fri, 7 Feb 2014 15:37:35 +0000 (16:37 +0100)]
BUG 408

- added null safe comparison
- added unit test
- added SLF4j
- added log message in method StrIpToIntIp in case of exception

Change-Id: Id15dc4f80d419df5e73ab79fea4e8ab25ec82968
Signed-off-by: Michal Rehak <mirehak@cisco.com>
7 years agooperation, store, path and data properties added to Data change event model 18/5118/5
Martin Bobak [Tue, 4 Feb 2014 13:27:57 +0000 (14:27 +0100)]
operation, store, path and data properties added to Data change event model

Change-Id: I0b1c39e23506988528614b33c4a49cf8e00802ea
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoMerge "Fixed publishDataChangeEvent in 2phase commit"
Ed Warnicke [Fri, 7 Feb 2014 06:36:35 +0000 (06:36 +0000)]
Merge "Fixed publishDataChangeEvent in 2phase commit"

7 years agoMerge "Increase timeout for waiting for broker service in sal-binding-it."
Ed Warnicke [Fri, 7 Feb 2014 06:35:34 +0000 (06:35 +0000)]
Merge "Increase timeout for waiting for broker service in sal-binding-it."

7 years agoMerge "Remove unnecessary warn log from config subsystem"
Ed Warnicke [Fri, 7 Feb 2014 06:34:42 +0000 (06:34 +0000)]
Merge "Remove unnecessary warn log from config subsystem"

7 years agoMerge "Fix for bug #236 and bug #240 Have made changes in opendaylight-table-types...
Ed Warnicke [Fri, 7 Feb 2014 06:14:47 +0000 (06:14 +0000)]
Merge "Fix for bug #236 and bug #240 Have made changes in opendaylight-table-types.yang"

7 years agoMerge "Improve netconf negotiator messages"
Ed Warnicke [Fri, 7 Feb 2014 06:14:16 +0000 (06:14 +0000)]
Merge "Improve netconf negotiator messages"

7 years agoMerge "Improve logging in NetconfClient, logging-bridge. Increase connection timeout...
Ed Warnicke [Fri, 7 Feb 2014 06:13:46 +0000 (06:13 +0000)]
Merge "Improve logging in NetconfClient, logging-bridge. Increase connection timeout in sal-netconf-connector."

7 years agoMerge "Maven archetype for config subsystem aware bundles"
Ed Warnicke [Fri, 7 Feb 2014 06:12:23 +0000 (06:12 +0000)]
Merge "Maven archetype for config subsystem aware bundles"

7 years agoMerge "Fix of bug in Notificator class"
Ed Warnicke [Fri, 7 Feb 2014 06:11:23 +0000 (06:11 +0000)]
Merge "Fix of bug in Notificator class"

7 years agoMerge "Fix Plugin execution not covered in Eclipse for config subsystem"
Ed Warnicke [Fri, 7 Feb 2014 06:10:44 +0000 (06:10 +0000)]
Merge "Fix Plugin execution not covered in Eclipse for config subsystem"

7 years agoLower logger level in OF1.0 Discovery Service 60/5160/1
Alessandro Boch [Fri, 7 Feb 2014 00:40:09 +0000 (16:40 -0800)]
Lower logger level in OF1.0 Discovery Service

- Discovery Service has a function to attempt to snoop
  non controller generated or malformed LLDP frames.
  The whole function block is in a try catch block,
  as exceptions are well expected.
  In case an exception is hit though, the function logs
  it as a warn.
- Change the log level to debug, do not print a stack trace,
  print the source MAC and the port on which it was received.

Change-Id: I82b459b16356b0a57934b3c26c993d20a2b53dc2
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoImprove netconf negotiator messages 24/5124/6
Robert Varga [Wed, 5 Feb 2014 07:36:23 +0000 (08:36 +0100)]
Improve netconf negotiator messages

Change-Id: I8b36f2fa6173055e5fc34783873a55cdf240589d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Requestor FRM to update the sw views on remote execution"
Giovanni Meo [Fri, 7 Feb 2014 00:02:44 +0000 (00:02 +0000)]
Merge "Requestor FRM to update the sw views on remote execution"

7 years agoMerge "Minor change to resource name regex"
Andrew Kim [Thu, 6 Feb 2014 20:33:01 +0000 (20:33 +0000)]
Merge "Minor change to resource name regex"

7 years agoMerge "Fix for BUG 402: Subnet creation with NeutronAPIService sometimes fails with...
Giovanni Meo [Thu, 6 Feb 2014 20:23:00 +0000 (20:23 +0000)]
Merge "Fix for BUG 402: Subnet creation with NeutronAPIService sometimes fails with a 409 error"

7 years agoMinor change to resource name regex 55/5155/2
Alessandro Boch [Thu, 6 Feb 2014 18:32:14 +0000 (10:32 -0800)]
Minor change to resource name regex

Change-Id: Ia087f56b7fd51406e1e81a4b1e7aaf3996f0250d
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMerge "The Switch Event thread is the thread that processes events coming from all...
Jason Ye [Thu, 6 Feb 2014 20:01:43 +0000 (20:01 +0000)]
Merge "The Switch Event thread is the thread that processes events coming from all switches. Right now its very fragile as an unhandled exception can cause the thread to die causing the controller to be unusable. Making the thread more tolerant of exceptions and making the shutdown of the thread more deterministic."

7 years agoFix Plugin execution not covered in Eclipse for config subsystem 52/5152/1
Maros Marsalek [Thu, 6 Feb 2014 15:52:04 +0000 (16:52 +0100)]
Fix Plugin execution not covered in Eclipse for config subsystem

yang-test, yang-test-plugin

Change-Id: I9be015e1221ad9ff143370bb68837e0c55558a3e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoFix of bug in Notificator class 03/5103/4
Jozef Gloncak [Mon, 3 Feb 2014 14:58:26 +0000 (15:58 +0100)]
Fix of bug in Notificator class

Deleting of listner from listenersByStreamName map was corrected
try, finally block was added for locking, unlocking of access to map

Change-Id: I60ecb9c247af18436f348d4f4827c7f75fdfaeaa
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoThe Switch Event thread is the thread that processes events coming from all switches. 42/5142/1
Asad Ahmed [Wed, 5 Feb 2014 23:44:31 +0000 (15:44 -0800)]
The Switch Event thread is the thread that processes events coming from all switches.
Right now its very fragile as an unhandled exception can cause the thread to die causing
the controller to be unusable. Making the thread more tolerant of exceptions and making
the shutdown of the thread more deterministic.

Change-Id: I31c31f012229de8e124c0c13fa651513daaf6776
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
7 years agoMerge changes I8290457c,If84199a1
Jason Ye [Wed, 5 Feb 2014 20:11:38 +0000 (20:11 +0000)]
Merge changes I8290457c,If84199a1

* changes:
  Stats Mgr to skip equality check on flow stats
  Apply configs' name convention to authorization roles and resource groups

7 years agoFix for BUG 402: Subnet creation with NeutronAPIService sometimes fails 34/5134/2
Ryan Moats [Wed, 5 Feb 2014 17:07:35 +0000 (11:07 -0600)]
Fix for BUG 402: Subnet creation with NeutronAPIService sometimes fails
with a 409 error

Correct typo and bring hostRoutes out as own init block

Change-Id: I7f6f83cb6a63aa81a057b40c377ac49132a9fcb9
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoRequestor FRM to update the sw views on remote execution 50/5050/8
Alessandro Boch [Wed, 5 Feb 2014 07:20:09 +0000 (23:20 -0800)]
Requestor FRM to update the sw views on remote execution

- When FRM relay the flow add/remove/modify action to an executor
  FRM on another cluster node, it should be in charge of updating
  the sw view caches. As this happens inside the caller application's transaction.
  Currently the executor updates the cache, update which is not
  reflected in the requestor until the caller application commits the transaction.

Change-Id: I36f3efa2770e71c24e0d059d6bf08eee2c1684f5
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoImprove logging in NetconfClient, logging-bridge. Increase connection timeout in... 26/5126/4
Tomas Olvecky [Wed, 5 Feb 2014 10:55:39 +0000 (11:55 +0100)]
Improve logging in NetconfClient, logging-bridge. Increase connection timeout in sal-netconf-connector.

Stop polluting log file with unnecessary 'Exception' messages by logging-bridge, print stack trace with exceptions using slf4j.
Increase connection timeout in sal-netconf-client from 5s to 20s.
Include label in NetconfClient exceptions.

Change-Id: If6819029fb79ea6ebead6b6745adf2c439d107da
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
7 years agoFix unintentional breakage 30/5130/3
Robert Varga [Wed, 5 Feb 2014 13:06:39 +0000 (14:06 +0100)]
Fix unintentional breakage

Yangtools commit 6e7a42bd344f5928343ad67328bc8a8a734bea2e introduced a
new method which broke the controller-side proxy. Fix it up by simply
forwarning it through the delegate.

Change-Id: I4582acb3a6987d9d87d422a86283984a38cd31ba
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Added resource /streams/stream/<streamName>"
Ed Warnicke [Wed, 5 Feb 2014 06:37:28 +0000 (06:37 +0000)]
Merge "Added resource /streams/stream/<streamName>"

7 years agoMerge "Added support for /modules, /modules/module, /operations resources"
Ed Warnicke [Wed, 5 Feb 2014 06:36:47 +0000 (06:36 +0000)]
Merge "Added support for /modules, /modules/module, /operations resources"

7 years agoMerge "Handle uncaught exceptions from Clustering Services in HostTracker"
Chi-Vien Ly [Wed, 5 Feb 2014 02:43:13 +0000 (02:43 +0000)]
Merge "Handle uncaught exceptions from Clustering Services in HostTracker"

7 years agoHandle uncaught exceptions from Clustering Services in HostTracker 81/5081/5
Maurice Qureshi [Fri, 31 Jan 2014 23:18:44 +0000 (15:18 -0800)]
Handle uncaught exceptions from Clustering Services in HostTracker

There are couple of timer tasks in host tracker which use caches
provided by clustening services. If a container is deleted, then
the cache allocated to that container is also removed. Although
TimerTasks do get cancelled when container is deleted, but if it
happens during the execution of timer thread, then the task will
run to completion (even though it was cancelled) and may try to
access a cache which has already been deallocated.

The accessing of this deallocated cache will result in clustering
service exception which needs to be handled by timer tasks

Also adding toString methods to IPHostId and IPMacHostId for more
readable output when diplaying hosttracker data structures

Change-Id: Id1c481360a4ff71b6eb0afab3c030ef011ca7dcd
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
7 years agoAdded resource /streams/stream/<streamName> 94/5094/9
Martin Sunal [Sun, 2 Feb 2014 23:26:58 +0000 (00:26 +0100)]
Added resource /streams/stream/<streamName>

- added netty web socket server - port 8181

Subscriber can be registered for notifications in this flow:
1. Subscriber invokes RPC create-data-change-event-subscription with input element regarding to module sal-remote revision "2014-01-14"
2. Subscriber gets sream name as a response from server
3. Subscriber calls GET operation on /streams/stream/<streamName>
4. Subscriber gets response with status code 200 OK and header field Location contains URI of web socket server
5. Subscriber creates web socket http connection to obtained URI in step 4.
6. Subscriber can be unregistered from receiving notifications by sending CloseWebSocketFrame with reasonText containing stream name

Change-Id: I92925f5a50b2ceadf2cc8f0eaee2c99dd6a63d8d
Signed-off-by: Martin Sunal <msunal@cisco.com>
7 years agoAdded support for /modules, /modules/module, /operations resources 47/4847/6
Jozef Gloncak [Mon, 3 Feb 2014 12:56:13 +0000 (13:56 +0100)]
Added support for /modules, /modules/module, /operations resources

support for:
/restconf/modules
/restconf/modules/pathToMountPoint/yang-ext:mount
/restconf/modules/module/moduleName/revision
/restconf/modules/module/pathToMountPoint/yang-ext:mount/moduleName/revision
/restconf/operations
/restconf/operations/pathToMountPoint/yang-ext:mount

revision must be in format "yyyy-MM-dd"

test for URIs:
- /modules
- /modules/module/<module_name>/<module_revision>
- /operations
- /modules/......./yang-ext:mount
- /modules/module/........../yang-ext:mount/<module_name>/<module_revision>
- /operations/........../yang-ext:mount

Change-Id: I7169a25024598dd3b49d7960d1ef90bc40c5d1d5
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
7 years agoStats Mgr to skip equality check on flow stats 21/5121/2
Alessandro Boch [Tue, 4 Feb 2014 17:20:32 +0000 (09:20 -0800)]
Stats Mgr to skip equality check on flow stats

- Statistics Manager runs an equality check on the list of flow statistics
  received from the protocol plugin with its cached ones to decide whether
  to update or not, in order to avoid a cluster cache update.
  In presence of flows on the switch, the flow updated statistics are always
  different becasue of the milli and nano secs duration fields they contain

Change-Id: I8290457c1d0a43294e2449cb16c14d6c1e36481e
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMaven archetype for config subsystem aware bundles 64/5064/3
Maros Marsalek [Fri, 31 Jan 2014 13:35:27 +0000 (14:35 +0100)]
Maven archetype for config subsystem aware bundles

Change-Id: I0b109770f03917b923de3d4fd78d91f43eded4e2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoApply configs' name convention to authorization roles and resource groups 11/5011/5
Alessandro Boch [Wed, 29 Jan 2014 19:14:32 +0000 (11:14 -0800)]
Apply configs' name convention to authorization roles and resource groups

- Also include Switch config

Change-Id: If84199a1db6e1fc35c02c4b92493f99aeb8d8af8
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMerge "Fix end of TLV in LLDP packet"
Alessandro Boch [Tue, 4 Feb 2014 02:56:44 +0000 (02:56 +0000)]
Merge "Fix end of TLV in LLDP packet"