controller.git
9 years agoBUG-938 Fix negotiation error when using exi 50/6650/2
Maros Marsalek [Fri, 2 May 2014 08:43:07 +0000 (10:43 +0200)]
BUG-938 Fix negotiation error when using exi

EXIConfirmation handler is now added to pipeline before start-exi is sent.

Add test with secure netconf server + exi

Change-Id: Ie975a2ecf31cfbb8c1fd4e25e8f41876e0552a00
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBug 946: Fixed eclipse errors in sal-binding-dom-it 62/6662/2
tpantelis [Fri, 2 May 2014 03:26:54 +0000 (23:26 -0400)]
Bug 946: Fixed eclipse errors in sal-binding-dom-it

Enabled the yang-maven-plugin to run by defult in eclipse

Change-Id: I3137cbe790891333b7526c832c9a173f6e591d0c
Signed-off-by: tpantelis <tpanteli@brocade.com>
9 years agoMerge "BUG-633: allow overriding of channelFactory"
Ed Warnicke [Thu, 1 May 2014 16:36:16 +0000 (16:36 +0000)]
Merge "BUG-633: allow overriding of channelFactory"

9 years agoBUG-633: allow overriding of channelFactory 37/6637/1
Robert Varga [Thu, 1 May 2014 15:55:00 +0000 (17:55 +0200)]
BUG-633: allow overriding of channelFactory

It turns out netty does not let us override an already-set
channelFactory. Reorder customization to detect when such an override is
necessary.

Change-Id: I99de69b98e4034d4701313942d9ed2a09923375d
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "BUG-634: introduce netty ChannelFactory wrapper"
Ed Warnicke [Thu, 1 May 2014 15:18:12 +0000 (15:18 +0000)]
Merge "BUG-634: introduce netty ChannelFactory wrapper"

9 years agoMerge "BUG 274 REST response instead of NumberFormatException"
Ed Warnicke [Thu, 1 May 2014 15:17:55 +0000 (15:17 +0000)]
Merge "BUG 274 REST response instead of NumberFormatException"

9 years agoMerge "Modify config code generator to write JmxAttribute as static fields."
Ed Warnicke [Thu, 1 May 2014 14:55:29 +0000 (14:55 +0000)]
Merge "Modify config code generator to write JmxAttribute as static fields."

9 years agoMerge "Bug 618 - convert xtend to java in md-sal/inventory-manager"
Ed Warnicke [Thu, 1 May 2014 14:53:30 +0000 (14:53 +0000)]
Merge "Bug 618 - convert xtend to java in md-sal/inventory-manager"

9 years agoMerge "fix for BUG-621 - convertion from xtend to java in compatibility/flow-manageme...
Ed Warnicke [Thu, 1 May 2014 14:53:22 +0000 (14:53 +0000)]
Merge "fix for BUG-621 - convertion from xtend to java in compatibility/flow-management-compatibility"

9 years agoBug 933: Fixed datastore processing of nested augmentations. 33/6633/1
Tony Tkacik [Thu, 1 May 2014 12:33:31 +0000 (14:33 +0200)]
Bug 933: Fixed datastore processing of nested augmentations.

Change-Id: I500e2a16666dfc7730da728c0cd47076c01343b0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBug 933: Changed Topology Compatibility to use DataChangeEvent 32/6632/1
Tony Tkacik [Thu, 1 May 2014 12:22:41 +0000 (14:22 +0200)]
Bug 933: Changed Topology Compatibility to use DataChangeEvent

Topology Compatibility adapter used commit handler to receive
change events and also reading from datastore, which may leaded
to some desynchronization issues. Changed topology Compatibility
to data change listener, which ensures data store is up to date,
when read occurs.

Change-Id: I052c9c79d99bdc8ba70e32c4421073c581901adc
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "Bug 930 - Add bound to queue in SingletonHandler#NOTIFICATION_EXECUTOR ."
Tony Tkacik [Thu, 1 May 2014 11:22:17 +0000 (11:22 +0000)]
Merge "Bug 930 - Add bound to queue in SingletonHandler#NOTIFICATION_EXECUTOR ."

9 years agoMerge changes I4a9861ed,I61c130b9
Ed Warnicke [Thu, 1 May 2014 11:16:13 +0000 (11:16 +0000)]
Merge changes I4a9861ed,I61c130b9

* changes:
  Bug 509: Fixed DataTransactionListener support.
  Bug 509: Fixed Backwards compatibility bugs with datastore.

9 years agoBug 509: Fixed DataTransactionListener support. 31/6631/1
Tony Tkacik [Thu, 1 May 2014 10:41:27 +0000 (12:41 +0200)]
Bug 509: Fixed DataTransactionListener support.

Change-Id: I4a9861ed543ce01e349737f7e779c2cfb5b1f107
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMaking it easier for cygwin users to run OpenDaylight using run.sh. 29/6629/1
Srini Seetharaman [Wed, 30 Apr 2014 23:47:37 +0000 (16:47 -0700)]
Making it easier for cygwin users to run OpenDaylight using run.sh.
With this change, the users will only have to add the following line
to their .bashrc to make it run: export CLASSPATH=".;lib/*;"

Change-Id: Icc1576ea1c46568d43f11d90eebecb06c74db184
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
9 years agoSkip from the surefire execution plugins that can step over guava feet 25/6625/1
Giovanni Meo [Sun, 27 Apr 2014 00:09:40 +0000 (02:09 +0200)]
Skip from the surefire execution plugins that can step over guava feet

Seems like the com.google.common.collect.* package has been reused in
several jars like:

- guava
- google-collection
- pax-url-aether

Now the netconf-it in the classpath of contains via transitive the 3
of them but only guava is usable by yang-bindings used by the netconf
client test. The presence of the 3 cause unreliability on the test
pass based on who comes first in the classpath of surefire. The fix is
to make sure surefire ignore the other two libraries except guava.

Change-Id: I77260989a19f60db94286434444530bacb1947d4
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoBUG-832 Add schemaContext to notification parsing process in sal-netcon-connector 23/6623/1
Maros Marsalek [Wed, 30 Apr 2014 13:42:11 +0000 (15:42 +0200)]
BUG-832 Add schemaContext to notification parsing process in sal-netcon-connector

Change-Id: I3161bde1635837676e75fdc0e1bb5c59fcb4a542
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBug 618 - convert xtend to java in md-sal/inventory-manager 87/6387/2
Vaclav Demcak [Fri, 25 Apr 2014 11:44:51 +0000 (13:44 +0200)]
Bug 618 - convert xtend to java in md-sal/inventory-manager

Change-Id: I53ecde22fc659d34cd1e8b076efb5e129a040bbe
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
9 years agofix for BUG-621 - convertion from xtend to java in compatibility/flow-management... 81/6381/5
Vaclav Demcak [Thu, 24 Apr 2014 15:58:31 +0000 (17:58 +0200)]
fix for BUG-621 - convertion from xtend to java in compatibility/flow-management-compatibility

Change-Id: I171d673230c0e5212f4902e2bd33f12691fc2444
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
9 years agoBUG-634: introduce netty ChannelFactory wrapper 25/6425/4
Robert Varga [Sun, 27 Apr 2014 15:55:42 +0000 (17:55 +0200)]
BUG-634: introduce netty ChannelFactory wrapper

Adds a wrapper for services exposing ChannelFactory. Needed for
protocols which need to extended netty functionality.

Change-Id: I8b29e3a91380519f03e5a2c5299077876d1c9edf
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Bug 740: Forwardingrules-Manager support for DataChangeListeners"
Ed Warnicke [Wed, 30 Apr 2014 12:24:20 +0000 (12:24 +0000)]
Merge "Bug 740: Forwardingrules-Manager support for DataChangeListeners"

9 years agoMerge "BUG-509: remove the key/value datastore"
Ed Warnicke [Wed, 30 Apr 2014 12:12:46 +0000 (12:12 +0000)]
Merge "BUG-509: remove the key/value datastore"

9 years agoMerge "BUG-509: make the tree-based datastore the default"
Ed Warnicke [Wed, 30 Apr 2014 12:12:33 +0000 (12:12 +0000)]
Merge "BUG-509: make the tree-based datastore the default"

9 years agoMerge "BUG-509: Cleanup datastore switching configuration"
Ed Warnicke [Wed, 30 Apr 2014 11:58:20 +0000 (11:58 +0000)]
Merge "BUG-509: Cleanup datastore switching configuration"

9 years agoMerge "Clean up yang-test to stop modifying source files during build."
Ed Warnicke [Wed, 30 Apr 2014 11:57:49 +0000 (11:57 +0000)]
Merge "Clean up yang-test to stop modifying source files during build."

9 years agoMerge "Default auth parameters in config.ini."
Ed Warnicke [Wed, 30 Apr 2014 11:57:27 +0000 (11:57 +0000)]
Merge "Default auth parameters in config.ini."

9 years agoBug 930 - Add bound to queue in SingletonHandler#NOTIFICATION_EXECUTOR . 18/6618/1
Tomas Olvecky [Wed, 30 Apr 2014 10:36:49 +0000 (12:36 +0200)]
Bug 930 - Add bound to queue in SingletonHandler#NOTIFICATION_EXECUTOR .

Add queue capacity with hardcoded value 10. When maxPoolSize + queue capacity
is reached, caller thread will be blocked.
Mark thread as interrupted when catching InterruptedException, propagate it
to caller.
Remove code that pushed first two runnables to queue when core size was
reached - saturate whole threadpool capacity first.

Change-Id: I9c52b52eac127bea0cbb2abf7a65c0165daf8895
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoBug 740: Forwardingrules-Manager support for DataChangeListeners 55/6255/5
Vaclav Demcak [Tue, 15 Apr 2014 16:26:20 +0000 (18:26 +0200)]
Bug 740: Forwardingrules-Manager support for DataChangeListeners

+ Bug 619 - Eliminate the use of xtend in md-sal/forwardingrules-manager

migration from xtend to java files FRM
add DataChangeListener to FRM (Flow, Meter, Group)
remove FRM handlers (Flow, Meter, Group)
fix delete changes registration (in ImmutableDataChangeEvent -> old DataStore)

Change-Id: I56003833519d9689a489ed5f77b3f7fc4ac2e204
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
9 years agoBUG-832 Fix exception from sal-netconf-connector. 17/6617/1
Maros Marsalek [Wed, 30 Apr 2014 08:20:28 +0000 (10:20 +0200)]
BUG-832 Fix exception from sal-netconf-connector.

Exception:
Ommiting from BA transaction: /(urn:opendaylight:inventory?revision=2013-08-19)nodes/(urn:opendaylight:inventory?revision=2013-08-19)node[{(urn:opendaylight:inventory?revision=2013-08-19)id=ios-xr-105}].

Fixed by treating capabilities from remote device as String instead of QName

Change-Id: I5cb59e111433ca60703bcf9a78d5b4578fc3b956
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG 274 REST response instead of NumberFormatException 58/6358/2
Jozef Gloncak [Thu, 24 Apr 2014 13:57:14 +0000 (15:57 +0200)]
BUG 274 REST response instead of NumberFormatException

Raised NumberFormatException is now catched and thrown next as
WebApplicationException which is displayed as return message for REST
call.

Change-Id: I1b4ee74c6a953fe3b64ef47c07477c29d892a87c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBug: 627 74/6574/3
Abhishek Kumar [Mon, 28 Apr 2014 23:37:53 +0000 (16:37 -0700)]
Bug: 627
Added RESTConf API Explorer that dynamically generates API documentation and serves it through swagger UI.
Details are documented in this wiki:
https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Restconf_API_Explorer

Change-Id: I11bcf95a8ab3ba0591a06070259c53cf5d7113b0
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
9 years agoBug 509: Fixed Backwards compatibility bugs with datastore. 05/6605/1
Tony Tkacik [Tue, 29 Apr 2014 16:57:08 +0000 (18:57 +0200)]
Bug 509: Fixed Backwards compatibility bugs with datastore.

Fixed bug in write and merge of leaf set children,
which prevented update of leaf sets.

Change-Id: I61c130b9d40876ae50468ebfbd2cf15208f1249c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "Statistics-Manager - Performance Improvement 1) Introduced statistics request...
Ed Warnicke [Tue, 29 Apr 2014 15:08:14 +0000 (15:08 +0000)]
Merge "Statistics-Manager - Performance Improvement 1) Introduced statistics request scheduler, to schedule request based on the current transaction load on MD-SAL DataStore. Each node submit all individual statistics request to schedular for execution 2) Send statistics request if there is no MD-SAL trasaction pending. It just keep tracks of the MD-SAL trasaction triggered by statistics-manager 3) Removal of stale statistics is now done based on counter rather then time values. Time based removal will break in case of clustered environment. 4) Code clean up Change-Id: Ie7522d0c60f2c7051dbfcdf9a6657843ef4da743 Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>"

9 years agoMerge "Fixing an unsorted pom change"
Giovanni Meo [Tue, 29 Apr 2014 14:18:45 +0000 (14:18 +0000)]
Merge "Fixing an unsorted pom change"

9 years agoBUG-509: remove the key/value datastore 78/5978/4
Robert Varga [Tue, 8 Apr 2014 17:28:07 +0000 (19:28 +0200)]
BUG-509: remove the key/value datastore

This patch puts the legacy buggy datastore to rest.

Change-Id: If87f8801fe6d370a9244ce8c2d9a586df1502285
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-509: make the tree-based datastore the default 77/5977/4
Robert Varga [Tue, 8 Apr 2014 17:25:41 +0000 (19:25 +0200)]
BUG-509: make the tree-based datastore the default

This patch switches the default datastore implementation to the
tree-based one.

Change-Id: Ibec4b2ba7f879bcd5a1c9676a59d9984cd7b4371
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-509: Cleanup datastore switching configuration 11/5911/6
Robert Varga [Fri, 4 Apr 2014 16:42:32 +0000 (18:42 +0200)]
BUG-509: Cleanup datastore switching configuration

This cleans up the configuration, relying on the fact that we can have
the two worlds existing concurrently and only expose one of them.

Change-Id: I9e2c0ecbdce3fb10940e1ff9fb88fc5148b42fc7
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoModify config code generator to write JmxAttribute as static fields. 95/6595/1
Tomas Olvecky [Tue, 29 Apr 2014 12:32:51 +0000 (14:32 +0200)]
Modify config code generator to write JmxAttribute as static fields.

Make JmxAttribute fields static so that name of the attribute can be
referenced and used to read from JMX.

Change-Id: Ibf2afbdfd8ae78e6ca46025671128bc7256f78d9
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoMerge "Resolve Bug:853 - remove groovy from config code generator."
Ed Warnicke [Tue, 29 Apr 2014 12:13:46 +0000 (12:13 +0000)]
Merge "Resolve Bug:853 - remove groovy from config code generator."

9 years agoClean up yang-test to stop modifying source files during build. 90/6590/1
Tomas Olvecky [Tue, 29 Apr 2014 09:40:42 +0000 (11:40 +0200)]
Clean up yang-test to stop modifying source files during build.

In yang-test-plugin remove auto generated headers so that things
like timestamp changes will not be reported as changed files
after build.
Also move an artifact definition in commons pom and sal-binding-it
as enforced by the sort plugin.

Change-Id: I5d851d65c149611800a1f7418eb4b642e3fd8260
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoFixing an unsorted pom change 88/6588/1
Giovanni Meo [Tue, 29 Apr 2014 09:00:35 +0000 (11:00 +0200)]
Fixing an unsorted pom change

- This would cause changes every time someone builds

Change-Id: I134067fe52d9405f20b777db05e5710d10c12666
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoMerge changes Ie84ea1ff,Ifa0a97da
Tony Tkacik [Tue, 29 Apr 2014 08:32:33 +0000 (08:32 +0000)]
Merge changes Ie84ea1ff,Ifa0a97da

* changes:
  BUG-848 Make base capabilities from netconf server configurable
  BUG-848 Fix netconf communication while using CHUNK encoding

9 years agoDefault auth parameters in config.ini. 23/6023/14
Martin Bobak [Thu, 10 Apr 2014 09:10:35 +0000 (11:10 +0200)]
Default auth parameters in config.ini.

    Hardcoded default username and password for ssh authenticaton moved from AuthProvider.java to config.ini
    IUSerManager in AuthProvider.java is not static anymore.

Change-Id: Ia4fd2cddf42d17842869d599d645881b77d2afbd
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "Allow to disable default gw feature"
Giovanni Meo [Tue, 29 Apr 2014 08:15:35 +0000 (08:15 +0000)]
Merge "Allow to disable default gw feature"

9 years agoBUG-848 Make base capabilities from netconf server configurable 44/6544/2
Maros Marsalek [Mon, 28 Apr 2014 13:41:35 +0000 (15:41 +0200)]
BUG-848 Make base capabilities from netconf server configurable

Refactor ConcurrentClientsTest, add cases for different netconf server configuration (EXI/CHUNK)

Change-Id: Ie84ea1ff716b11b0da49e0498127a0defc86f41f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBUG-848 Fix netconf communication while using CHUNK encoding 43/6543/2
Maros Marsalek [Mon, 28 Apr 2014 09:12:08 +0000 (11:12 +0200)]
BUG-848 Fix netconf communication while using CHUNK encoding

Cause:
When using Chunk encoding, the negotiation process lasts longer due to pipeline manipulation.
Messages received while still in negotiation were not processed correctly (This is incorrect, messages should not be processed while still in negotiation).

Fix:
Introduce a message barrier that will forward only hello message until negotiation is completed (implemented in NetconfXmlToHelloMessageDecoder).
Modify SessionNegotiators to replace message barier/hello decoder when negotiation is finished and to process non-hello messages stopped by the barier.

* Exclude pax-url-aether dependency in netconf-it

Change-Id: Ifa0a97da75ac3cdca29e29bf40138b637e08ff45
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Fixed typo in test name. Temporary ignore test."
Ed Warnicke [Mon, 28 Apr 2014 12:30:31 +0000 (12:30 +0000)]
Merge "Fixed typo in test name. Temporary ignore test."

9 years agoMerge "Resolve Bug:748 - Remove test resources from netconf-impl."
Ed Warnicke [Mon, 28 Apr 2014 12:28:30 +0000 (12:28 +0000)]
Merge "Resolve Bug:748 - Remove test resources from netconf-impl."

9 years agoMerge changes I8e90a7d5,I25249fe8
Ed Warnicke [Mon, 28 Apr 2014 12:21:45 +0000 (12:21 +0000)]
Merge changes I8e90a7d5,I25249fe8

* changes:
  Resolve Bug:807 - Keep ModuleFactory references shutdown purposes.
  Resolve Bug:681 - Fix config module registration to Service Registry.

9 years agoMerge "BUG 652 leafref CCE & BUG 720 colons problem"
Ed Warnicke [Mon, 28 Apr 2014 12:21:21 +0000 (12:21 +0000)]
Merge "BUG 652 leafref CCE & BUG 720 colons problem"

9 years agoMerge "Bug 460 - Fix warning throughout netconf subsystem"
Ed Warnicke [Mon, 28 Apr 2014 12:18:40 +0000 (12:18 +0000)]
Merge "Bug 460 - Fix warning throughout netconf subsystem"

9 years agoMerge "Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery"
Ed Warnicke [Mon, 28 Apr 2014 12:16:33 +0000 (12:16 +0000)]
Merge "Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery"

9 years agoMerge "BUG-732 Fix sal-netconf-connector unable to download schemas"
Tony Tkacik [Mon, 28 Apr 2014 12:01:53 +0000 (12:01 +0000)]
Merge "BUG-732 Fix sal-netconf-connector unable to download schemas"

9 years agoResolve Bug:853 - remove groovy from config code generator. 35/6535/1
Tomas Olvecky [Mon, 28 Apr 2014 12:01:23 +0000 (14:01 +0200)]
Resolve Bug:853 - remove groovy from config code generator.

Replace 3 groovy classes with java equivalents.

Change-Id: I625f0498c3ccaedf0441c637ac61a9653c98e579
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoMerge "Cleaned Commons POM prerequisites for Karaf distribution"
Giovanni Meo [Mon, 28 Apr 2014 10:10:35 +0000 (10:10 +0000)]
Merge "Cleaned Commons POM prerequisites for Karaf distribution"

9 years agoBUG-732 Fix sal-netconf-connector unable to download schemas 56/6356/7
Maros Marsalek [Thu, 24 Apr 2014 12:09:02 +0000 (14:09 +0200)]
BUG-732 Fix sal-netconf-connector unable to download schemas

BUG#1 NetconfDeviceListener used wrong method to parse rpc results
BUG#2 Parsing rpc result in NetconfMapping was looking for schema to response even if it was not needed
BUG#3 Netconf client sent base netconf capability in wrong format

Change-Id: I4798b29bb8cd7361d24188b6d5ac40a612a0c6c8
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoBug 460 - Fix warning throughout netconf subsystem 99/5599/14
Martin Bobak [Mon, 10 Mar 2014 16:11:35 +0000 (17:11 +0100)]
Bug 460 - Fix warning throughout netconf subsystem

Change-Id: I461a7bab47ef67c13c6fd5864d8938cdd47c3c8b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoStatistics-Manager - Performance Improvement 85/5785/5
Anil Vishnoi [Tue, 25 Mar 2014 21:49:09 +0000 (03:19 +0530)]
Statistics-Manager - Performance Improvement
1) Introduced statistics request scheduler, to schedule request based on the current transaction load on MD-SAL DataStore.
Each node submit all individual statistics request to schedular for execution
2) Send statistics request if there is no MD-SAL trasaction pending.
It just keep tracks of the MD-SAL trasaction triggered by statistics-manager
3) Removal of stale statistics is now done based on counter rather then time values.
Time based removal will break in case of clustered environment.
4) Code clean up
Change-Id: Ie7522d0c60f2c7051dbfcdf9a6657843ef4da743
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>
9 years agoBug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery 41/6441/1
Debolina Bandyopadhyay [Fri, 25 Apr 2014 21:50:53 +0000 (14:50 -0700)]
Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery

Change-Id: Iec8335fadd5f1529b3f04288805bda2f5594cc94
Signed-off-by: Debolina Bandyopadhyay <dbandyop@cisco.com>
Bug 616 - Eliminate the use of xtend in md-sal/topology-lldp-discovery

Change-Id: Ie5d82011676aac2b8750fe1e6e46b89da8c3b4eb
Signed-off-by: Debolina Bandyopadhyay <dbandyop@cisco.com>
Removed @SuppressWarnings("all")

Change-Id: I4e012890813f94ec1edc66b538904a7c8bd2e41c
Signed-off-by: Debolina Bandyopadhyay <dbandyop@cisco.com>
9 years agoAllow to disable default gw feature 29/6429/2
Alessandro Boch [Sun, 27 Apr 2014 17:08:03 +0000 (10:08 -0700)]
Allow to disable default gw feature

- Default gateway is a good feature for having host discovery, and
  consequently hosts' pings, work out of the box.
  But in real scenarios a controlled network node may be connected to a
  legacy switch's trunk port which exposes thousand of hosts which ARP
  packets would easily stress controller functionality.
  Even though today this can be prevented by configuring a more
  specific subnet gateway, the issue is very much possible at first
  controller boot, and can always re-occur during subnet config manipulation
  if at any point of time we have no user configured subnet gateways.
- This patch provides a way to disable he default gw feature by mean of
  a property in config.ini. Property addition is not included, current
  behavior is unchanged.

Change-Id: I15b63233e3ed46a8a9fb57bb0988a0d4a2984b11
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoCleaned Commons POM prerequisites for Karaf distribution 07/6407/6
Mathieu Lemay [Fri, 25 Apr 2014 21:51:45 +0000 (17:51 -0400)]
Cleaned Commons POM prerequisites for Karaf distribution

Change-Id: I747b29407c853f72f532cedbe9044b93b66dcb6c
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
9 years agoFix Operation not permitted warning. 90/6390/1
Martin Bobak [Fri, 25 Apr 2014 14:05:48 +0000 (16:05 +0200)]
Fix Operation not permitted warning.

This fix removes warning
WARN  o.o.c.n.c.m.c.ModuleElementDefinition - Operation not permitted on
current strategy  while default strategy is merge. Element definition
strategy set to default

that occured on osgi startup.

Change-Id: Ic12ce37e9bfa08cfffd0cac0e591fc49ffe227c6
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "Bug 451 - Fix netconf exception handling"
Tony Tkacik [Fri, 25 Apr 2014 08:56:45 +0000 (08:56 +0000)]
Merge "Bug 451 - Fix netconf exception handling"

9 years agoMerge "BUG-832 Add initial configuration for controller self mount"
Tony Tkacik [Fri, 25 Apr 2014 08:02:04 +0000 (08:02 +0000)]
Merge "BUG-832 Add initial configuration for controller self mount"

9 years agoBug 451 - Fix netconf exception handling 12/5512/22
Martin Bobak [Mon, 3 Mar 2014 10:17:50 +0000 (11:17 +0100)]
Bug 451 - Fix netconf exception handling

Change-Id: I815b34da996cf2660650577edb2e8ca623ae96df
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoMerge "Bug-590: Packet loss on first time ping test"
Giovanni Meo [Thu, 24 Apr 2014 13:06:05 +0000 (13:06 +0000)]
Merge "Bug-590: Packet loss on first time ping test"

9 years agoBUG-832 Add initial configuration for controller self mount 52/6352/2
Maros Marsalek [Thu, 24 Apr 2014 07:56:48 +0000 (09:56 +0200)]
BUG-832 Add initial configuration for controller self mount

Netconf server for config subsystem is mounted to restconf under id "controller-config" by default

This illustrates the usage of sal-netconf-connector

Change-Id: I3f324b41995dc094bac0d316788dfdb05e18ef60
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Bug 509: Added support for merge operation to InMemoryData Store"
Ed Warnicke [Thu, 24 Apr 2014 11:56:27 +0000 (11:56 +0000)]
Merge "Bug 509: Added support for merge operation to InMemoryData Store"

9 years agoBug-590: Packet loss on first time ping test 54/6354/1
Flavio Fernandes [Thu, 24 Apr 2014 11:06:37 +0000 (07:06 -0400)]
Bug-590: Packet loss on first time ping test

In this commit, we are addressing a race that could cause the exception (ie first ip packet) to
be lost. What is observed with this bug is that the non-arp packet -- in this case the icmp packet --
is being 'exceptioned' to the SimpleForwarding code path because the node has not yet been programmed
with flows that would allow it to forward the packet to its destination w/out involving the controller.

The race in this case is caused by the exceptioned packet being received before the rulesDB member
in simpleForwarding module is updated. That member -- rulesDB -- is updated via the
hostTracker::notifyHTClient() callback shortly after. In this particular race, the hostTracker is already
updated with the proper information, and rulesDB is 'stale'. Thus, the proposed fix is to make the forwarding
less strict (ie. ignore rulesDB). Note that both routing and hostTracker are all simpleForwarding needs to
know how to forward the packet.

Change-Id: Icfb909ca89abff6031212b4fcd0f5d1bd1a27d6b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoBUG 652 leafref CCE & BUG 720 colons problem 35/6335/4
Jozef Gloncak [Wed, 23 Apr 2014 12:56:10 +0000 (14:56 +0200)]
BUG 652 leafref CCE & BUG 720 colons problem

BUG 652 leafref Class cast exception
By default if input data were in format which was possible to parse as
XPath if was done like this. It caused that for leafref which indexed to
instance-identifier the value was parsed as XPath and not as string.

BUG 720 colons problem in JSON
If input string contained colon (:) then it was dealed as namespace:value
and object of type IdentityValuesDTO was created (it is probable that
data could be of type identityref). If data wasn't of type leafref then it
was incorrectly processed as leafref.
The RestCodec was updated to correctly translate data (cases when data
contains ':' but aren't of type leafref)

Change-Id: I0cba06bce1b1c69f6901cc90d2b30a3735e5f57e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoBug 509: Added support for merge operation to InMemoryData Store 38/6338/3
Tony Tkacik [Wed, 23 Apr 2014 14:17:31 +0000 (16:17 +0200)]
Bug 509: Added support for merge operation to InMemoryData Store

Merge operation support is critical for backwards compatibility
and for Binding-Aware mapping and Restconf, which are not aware
of Mixin nodes representing lists, leaflists and choices.

Semantics of merge operation are similar to subtree modified,
but when node is not existing it creates one based on
state provided by user of the Data Broker APIs.

Merge operation also fixes concurrent creations of mixin nodes
as demonstrated in ConcurrentImplicitCreateTest,
where two separate applications may indirectly create same
root node.

Change-Id: I9ab290b512601bd99750a68ee53564e67ef0c879
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoBug 722 - nagasena version bumped to 0000.0002.0038 51/6351/3
Martin Bobak [Wed, 23 Apr 2014 12:43:32 +0000 (14:43 +0200)]
Bug 722 - nagasena version bumped to 0000.0002.0038

Change-Id: Ie755a9a613096aed6f134005d216716c59b90563
Signed-off-by: Martin Bobak <mbobak@cisco.com>
9 years agoFixed typo in test name. Temporary ignore test. 25/6225/2
Martin Vitez [Wed, 16 Apr 2014 07:37:24 +0000 (09:37 +0200)]
Fixed typo in test name. Temporary ignore test.

Change-Id: Icdae59971bded5e76a181d4ab63132e011a561ca
Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoMerge "Bug 781: Statistics manager is throwing IllegalStateException"
Ed Warnicke [Wed, 23 Apr 2014 11:58:13 +0000 (11:58 +0000)]
Merge "Bug 781: Statistics manager is throwing IllegalStateException"

9 years agoMerge changes I67420353,I6851f9b9
Tony Tkacik [Wed, 23 Apr 2014 11:48:59 +0000 (11:48 +0000)]
Merge changes I67420353,I6851f9b9

* changes:
  Bug:701-Have Typed ErrorNotification for different node errors
  Bug:645 - MDSAL Notification pool threads not getting spawned besides the core threads

9 years agoResolve Bug:807 - Keep ModuleFactory references shutdown purposes. 12/6312/2
Tomas Olvecky [Tue, 22 Apr 2014 10:32:19 +0000 (12:32 +0200)]
Resolve Bug:807 - Keep ModuleFactory references shutdown purposes.

Retain ModuleFactory instances even if they disappear from OSGi SR,
so that the already committed instances can be closed cleanly. Also
remove shutdown customization (stopping config-manager as first bundle)
from shutdown-impl.

Change-Id: I8e90a7d593b7e4cc84c7a9a7d3f8bb804daf5f41
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoBUG-732 Add rollback-on-error error-option to edit-config rpcs from netconf-connector 05/6205/3
Maros Marsalek [Tue, 15 Apr 2014 14:00:27 +0000 (16:00 +0200)]
BUG-732 Add rollback-on-error error-option to edit-config rpcs from netconf-connector

Just in case rollback-on-error capability is supported

+ Add error response warning to netconf-connector

Change-Id: I16251a12b270bd0ed89b39bfccc5251b4b3fe934
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoResolve Bug:681 - Fix config module registration to Service Registry. 64/5964/6
Tomas Olvecky [Tue, 8 Apr 2014 14:22:48 +0000 (16:22 +0200)]
Resolve Bug:681 - Fix config module registration to Service Registry.

Rework OSGi service registration during second phase commit: only service references
will be registered into SR, instead of old behaviour when each module's service
interfaces were used. Only one key-value entry is persisted in registration:
{name: name of service reference} .

Change-Id: I25249fe8f9e51570cd3ea963e91145b7e44da57d
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoMerge "BUG-732 Fix netconf client deadlock when downloading yang schemas from remote...
Tony Tkacik [Wed, 23 Apr 2014 08:14:48 +0000 (08:14 +0000)]
Merge "BUG-732 Fix netconf client deadlock when downloading yang schemas from remote device"

9 years agoMerge "BUG-758 Eliminate xtend from sal-netconf-connector"
Tony Tkacik [Wed, 23 Apr 2014 08:14:25 +0000 (08:14 +0000)]
Merge "BUG-758 Eliminate xtend from sal-netconf-connector"

9 years agoMerge "fix for BUG-709 - mixed up flow cookie and connection cookie"
Tony Tkacik [Wed, 23 Apr 2014 08:11:13 +0000 (08:11 +0000)]
Merge "fix for BUG-709 - mixed up flow cookie and connection cookie"

9 years agoFixed typo in SnapshotBackedWriteTransaction class 26/6226/2
Lukas Sedlak [Wed, 16 Apr 2014 08:32:34 +0000 (10:32 +0200)]
Fixed typo in SnapshotBackedWriteTransaction class

Fixed type in SnapshotBackedWriteTransaction class name.

Change-Id: I51e13023e33f95a0f36c56659664b59dff56048b
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
9 years agoBug 781: Statistics manager is throwing IllegalStateException 98/6298/3
Anil Vishnoi [Mon, 21 Apr 2014 23:05:57 +0000 (04:35 +0530)]
Bug 781: Statistics manager is throwing IllegalStateException

Change-Id: I418bd4b86bbe9802be3ec7ed904a14ce537f085e
Signed-off-by: Anil Vishnoi <avishnoi@in.ibm.com>
9 years agoMerge "Bug-590: Packet loss on first time ping test"
Giovanni Meo [Tue, 22 Apr 2014 18:32:03 +0000 (18:32 +0000)]
Merge "Bug-590: Packet loss on first time ping test"

9 years agoBug-590: Packet loss on first time ping test 16/6316/3
Flavio Fernandes [Tue, 22 Apr 2014 15:39:36 +0000 (11:39 -0400)]
Bug-590: Packet loss on first time ping test

In this commit, we are addressing 2 issues that could cause the exception (ie first ip packet) to
be lost. What is observed with this bug is that the non-arp packet -- in this case the icmp packet --
is being 'exceptioned' to the SimpleForwarding code path because the node has not yet been programmed
with flows that would allow it to forward the packet to its destination w/out involving the controller.

Change #1: In cases when the src and dst ip are of hosts in the same node, the getRoute() call is going
to return 'null'. That is because the IRouting lookup will not find a path when src and dst nodes are
the same.

Change #2: When looking up the rulesDB, the key used was using the destHost and the node of the incoming
connector. It should be the destHost and the node of the destHost. Kudos go 100% to Giovanni on this.

Change-Id: I4861acd6ab6d7efe14b50d7537e4b920bffc8a75
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoResolve Bug:748 - Remove test resources from netconf-impl. 01/6201/2
Tomas Olvecky [Tue, 15 Apr 2014 12:15:48 +0000 (14:15 +0200)]
Resolve Bug:748 - Remove test resources from netconf-impl.

Remove old testing resources that are not required in tests.

Change-Id: Idba3be129aa177fa2eb362032719c79fb30331ba
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoBUG-509, BUG-808: Added datastore support for lists without keys. 11/6311/1
Robert Varga [Tue, 22 Apr 2014 12:54:04 +0000 (14:54 +0200)]
BUG-509, BUG-808: Added datastore support for lists without keys.

The datastore needs to support users who do not specify a list key, but
how expect the item ordering to be retained.

Added test which test all three possible behaviours of list
statement: ordered map, unordered map and list without keys.

Change-Id: I9e136267f57a88e4d2a6a4476025c33497373518
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoBUG-732 Fix netconf client deadlock when downloading yang schemas from remote device 53/6253/2
Maros Marsalek [Thu, 17 Apr 2014 10:12:25 +0000 (12:12 +0200)]
BUG-732 Fix netconf client deadlock when downloading yang schemas from remote device

Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Change-Id: Ic70085655e38ebc1e159fd4ba4b93172e468f4ad

9 years agoBUG-758 Eliminate xtend from sal-netconf-connector 52/6252/2
Maros Marsalek [Wed, 16 Apr 2014 09:29:09 +0000 (11:29 +0200)]
BUG-758 Eliminate xtend from sal-netconf-connector

Change-Id: I6add3e5ef2790aab5f0cda886f40bc400ff81f8d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "BUG-732 Fix netconf-connector unable to detect monitoring capability"
Ed Warnicke [Tue, 22 Apr 2014 12:26:11 +0000 (12:26 +0000)]
Merge "BUG-732 Fix netconf-connector unable to detect monitoring capability"

9 years agoMerge "Update to new version of the artifacts proposed by jenkins-controller-version...
Giovanni Meo [Tue, 22 Apr 2014 08:19:07 +0000 (08:19 +0000)]
Merge "Update to new version of the artifacts proposed by jenkins-controller-version-changes-30"

9 years agoMerge "Bug-780: potential lock release being missed if error code path happens in...
Giovanni Meo [Tue, 22 Apr 2014 08:17:51 +0000 (08:17 +0000)]
Merge "Bug-780: potential lock release being missed if error code path happens in SimpleBroadcastHandlerImpl.java"

9 years agoMerge "tomcat Session manager to support clustering using infinispan"
Giovanni Meo [Tue, 22 Apr 2014 08:15:50 +0000 (08:15 +0000)]
Merge "tomcat Session manager to support clustering using infinispan"

9 years agoBug-780: potential lock release being missed if error code path happens in SimpleBroa... 97/6297/1
Flavio Fernandes [Mon, 21 Apr 2014 22:52:56 +0000 (18:52 -0400)]
Bug-780: potential lock release being missed if error code path happens in SimpleBroadcastHandlerImpl.java

Change-Id: Ie8749e5dfcb04042922293ed45e8f06d42de90ab
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoMerge "Bug 509: Improve logging in InMemoryDataStore."
Ed Warnicke [Mon, 21 Apr 2014 21:35:07 +0000 (21:35 +0000)]
Merge "Bug 509: Improve logging in InMemoryDataStore."

9 years agotomcat Session manager to support clustering using infinispan 66/6266/3
Harman Singh [Thu, 17 Apr 2014 23:43:22 +0000 (16:43 -0700)]
tomcat Session manager to support clustering using infinispan

Change-Id: I65faff3a62f5c2cf3098e87b52649bf58a6e873a
Signed-off-by: Harman Singh <harmasin@cisco.com>
9 years agoUpdate to new version of the artifacts proposed by jenkins-controller-version-changes-30 93/6293/1
jenkins-controller [Sun, 20 Apr 2014 00:58:14 +0000 (00:58 +0000)]
Update to new version of the artifacts proposed by jenkins-controller-version-changes-30

Change-Id: I78f3db52695a984cfde7aee159f4bf2c40582b9d
Signed-off-by: jenkins-controller <jenkins-controller@opendaylight.org>
9 years agoRemove last instance of controller.version 85/6285/2
Giovanni Meo [Fri, 18 Apr 2014 15:48:21 +0000 (17:48 +0200)]
Remove last instance of controller.version

controller.version was still used in the config.ini so made sure to
fix it

Change-Id: I7739df2c16dae6ce0e2f26aa991ff0984963cc63
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoRemoved duplication of the yang-jmx-generator-plugin 84/6284/2
Giovanni Meo [Fri, 18 Apr 2014 15:25:11 +0000 (17:25 +0200)]
Removed duplication of the yang-jmx-generator-plugin

- Removed unnecessary duplications or a dependency of
yang-maven-plugin which would cause issues in the release process

Change-Id: I858d96d298d2ce6a3a6be87a0261a7f23c2d70e8
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoRemove unnecessary variable in netconf-it 83/6283/2
Giovanni Meo [Fri, 18 Apr 2014 14:09:09 +0000 (16:09 +0200)]
Remove unnecessary variable in netconf-it

- Another roadblock to release of artifact mdsal.version is used as
variable in netconf-it, remove it

Change-Id: I955b7796c46a0852fd74d2ce2d77a033669f5922
Signed-off-by: Giovanni Meo <gmeo@cisco.com>