controller.git
6 years agoMerge "Use same memory settings for surefire and failsafe plugins"
Alessandro Boch [Thu, 27 Feb 2014 23:01:42 +0000 (23:01 +0000)]
Merge "Use same memory settings for surefire and failsafe plugins"

6 years agoMerge "FlowConfig to only run syntactic validation"
Jason Ye [Thu, 27 Feb 2014 20:25:04 +0000 (20:25 +0000)]
Merge "FlowConfig to only run syntactic validation"

6 years agoMerge "Exception for URI /restconf/operations/module_name:rpc ended with slash"
Tony Tkacik [Thu, 27 Feb 2014 16:06:03 +0000 (16:06 +0000)]
Merge "Exception for URI /restconf/operations/module_name:rpc ended with slash"

6 years agoMerge "We already have a merged and validated flow entry. There is no need for extrac...
Alessandro Boch [Thu, 27 Feb 2014 15:33:01 +0000 (15:33 +0000)]
Merge "We already have a merged and validated flow entry. There is no need for extracting the original flow entry and then validating and merging it again with the containerflow."

6 years agoMerge "Centralize yang-maven-plugin version"
Tony Tkacik [Thu, 27 Feb 2014 14:59:24 +0000 (14:59 +0000)]
Merge "Centralize yang-maven-plugin version"

6 years agoMerge "Deprecate org.opendaylight.controller.sal.common.util.Futures"
Tony Tkacik [Thu, 27 Feb 2014 14:57:41 +0000 (14:57 +0000)]
Merge "Deprecate org.opendaylight.controller.sal.common.util.Futures"

6 years agoUse same memory settings for surefire and failsafe plugins 34/5234/2
Prasanth Pallamreddy [Mon, 10 Feb 2014 19:33:42 +0000 (11:33 -0800)]
Use same memory settings for surefire and failsafe plugins

  - This addresses the OOME issue seen during the tail end
    of the build when running unit tests.

Change-Id: I054e1dfa502bca19a62521a3b714f1a072b59ded
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
6 years agoFixed order of applying changes when forwarding transactions 84/5484/1
Robert Varga [Thu, 27 Feb 2014 11:44:18 +0000 (12:44 +0100)]
Fixed order of applying changes when forwarding transactions

Commit 5659f588f80522a5be5c80d0e5ff34068b5f4786 changed the semantics of
remove/update operations such that the order of application became
significant: remove, then put.

Unfortunately we failed to notice that there are two places which apply
the operations in wrong order, thus breaking clients who perform a
remove/put in a single transaction -- e.g. replacing data without
merging it.

Fix DataStore and Binding->DOM connector.

Change-Id: I4fb12730e8256d3614846adb1fa5a1096284e0eb
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoCentralize yang-maven-plugin version 81/5481/1
Robert Varga [Thu, 27 Feb 2014 12:05:29 +0000 (13:05 +0100)]
Centralize yang-maven-plugin version

There is no reason for individual projects to define the version over
and over again -- let's keep it in one place.

Change-Id: I4ea6ccbc51e31cf3cef3b7c1304ea7dcc02667f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDeprecate org.opendaylight.controller.sal.common.util.Futures 80/5480/1
Robert Varga [Thu, 27 Feb 2014 11:11:34 +0000 (12:11 +0100)]
Deprecate org.opendaylight.controller.sal.common.util.Futures

We use guava throughout -- and those are better.

Change-Id: I0013f8fc0c10742791159abdf151662eaae5629f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoWe already have a merged and validated flow entry. There is no need 76/5476/1
Asad Ahmed [Thu, 27 Feb 2014 00:45:15 +0000 (16:45 -0800)]
We already have a merged and validated flow entry. There is no need
for extracting the original flow entry and then validating and merging it again
with the containerflow.

Change-Id: I131abdefc3bde14b148af0264cd220ea0c61c528
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoAdding routed RPC support in Remote RPC Router 83/4683/8
Abhishek Kumar [Fri, 24 Jan 2014 08:31:49 +0000 (00:31 -0800)]
Adding routed RPC support in Remote RPC Router

 - Updated RoutingTable to add a new routed RPC cache
 - Updated sal-core-api to add Remote RPC Router as default delegate in SchemaAwareRpcBroker
 - Refactored RemoteRpcProvider code.
 - Added unit tests for routing table
 - Removed RouteIdentifier <-> JSON conversion. Its not used anymore
 - Rebased with master

Change-Id: Id13a0a6a9ae6ded7ea9068b7a613a9e196c89a7b
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoMerge "Migrate toaster samples to config-subsystem"
Tony Tkacik [Wed, 26 Feb 2014 13:41:31 +0000 (13:41 +0000)]
Merge "Migrate toaster samples to config-subsystem"

6 years agoMerge "Add reverse() method in Edge and Path classes"
Alessandro Boch [Tue, 25 Feb 2014 23:51:11 +0000 (23:51 +0000)]
Merge "Add reverse() method in Edge and Path classes"

6 years agoFlowConfig to only run syntactic validation 63/5463/1
Alessandro Boch [Tue, 25 Feb 2014 02:03:34 +0000 (18:03 -0800)]
FlowConfig to only run syntactic validation

- The validate function of FlowConfig class should only run syntactic validation
  The opearational validation like input/output/enqueue port presence, flood
  action on non default container check, etc. should be run only at installation
  time. Also this validation should be run for all the flow installation requests
  either they come from static flow config or from Flow Entry install/modify
  request coming from other bundles.
- With the above change at controller restart, static flow configurations which
  were valid at controller stop but no longer after reboot (for ex. switch sdn
  enabled ports have changed) will still show on the Flow GUI as non installed,
  and their toggling with fail with proper message.

Change-Id: I49d97af49d58102e51a3c8c12db915b60bcb6f4b
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoMerge "Refactor configuration for ConfigPersister."
Tony Tkacik [Tue, 25 Feb 2014 18:40:06 +0000 (18:40 +0000)]
Merge "Refactor configuration for ConfigPersister."

6 years agoMerge "Fix for bugs 446 and 456"
Tony Tkacik [Tue, 25 Feb 2014 18:39:17 +0000 (18:39 +0000)]
Merge "Fix for bugs 446 and 456"

6 years agoMigrate toaster samples to config-subsystem 33/5133/8
Maros Marsalek [Wed, 5 Feb 2014 15:18:08 +0000 (16:18 +0100)]
Migrate toaster samples to config-subsystem

 - Fix integration test for toaster samples.
 - The toaster is now disabled by default in distribution
   in order to enable it, you must change configure toaster module
   as in opendaylight/md-sal/samples/toaster-it/src/test/resources/controller.xml

Change-Id: I7c70704c2faea8d39b0f9ad32394e78bca6c80dc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Suppress unchecked cast warnings"
Tony Tkacik [Tue, 25 Feb 2014 18:15:54 +0000 (18:15 +0000)]
Merge "Suppress unchecked cast warnings"

6 years agoMerge "Prune long-deprecated APIs"
Tony Tkacik [Tue, 25 Feb 2014 18:13:31 +0000 (18:13 +0000)]
Merge "Prune long-deprecated APIs"

6 years agoSuppress unchecked cast warnings 34/5434/3
Robert Varga [Tue, 18 Feb 2014 10:45:26 +0000 (11:45 +0100)]
Suppress unchecked cast warnings

These casts are either safe, or we need to throw an exception --
ClassCast is as good an exception as any.

Change-Id: I74026fee5004984bfc18d990a3b6fee68a1fb479
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoPrune long-deprecated APIs 33/5433/4
Robert Varga [Wed, 19 Feb 2014 10:44:06 +0000 (11:44 +0100)]
Prune long-deprecated APIs

These APIs are from prototype days and have never properly worked. Prune
them to reduce the baggage we carry around.

Change-Id: I9ac89552edf76f0740c660c100ec0426627b413a
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix logging arguments in two-phase commit 57/5457/2
Robert Varga [Tue, 25 Feb 2014 13:35:32 +0000 (14:35 +0100)]
Fix logging arguments in two-phase commit

Change-Id: I0be572998f4ce5d30dca5178f946fab15ed925ca
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix comments and remove use of deprecated class 06/5406/3
Robert Varga [Wed, 19 Feb 2014 02:55:48 +0000 (03:55 +0100)]
Fix comments and remove use of deprecated class

This primarily removes SchemaServiceListener, as that is deprecated and
implied by SchemaContextListener, which is replacing it.

Change-Id: I977e818ff466ab27f6cd213d1e0e255e2f1b59a4
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdd reverse() method in Edge and Path classes 53/5453/2
Chi-Vien Ly [Mon, 24 Feb 2014 20:23:31 +0000 (12:23 -0800)]
Add reverse() method in Edge and Path classes

Change-Id: I27ada22079999facf6e9f00e05b60aa480e4f2b9
Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
6 years agoMerge "Close Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem."
Tony Tkacik [Tue, 25 Feb 2014 15:38:06 +0000 (15:38 +0000)]
Merge "Close Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem."

6 years agoMerge "Add watchdog thread to detect illegal blocking calls during second phase commit."
Tony Tkacik [Tue, 25 Feb 2014 14:59:52 +0000 (14:59 +0000)]
Merge "Add watchdog thread to detect illegal blocking calls during second phase commit."

6 years agoMerge "Better exception handling when instantiating YangModelBindingProvider, fix...
Tony Tkacik [Tue, 25 Feb 2014 14:58:10 +0000 (14:58 +0000)]
Merge "Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator."

6 years agoClose Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem. 36/5436/4
Tomas Olvecky [Fri, 21 Feb 2014 10:46:42 +0000 (11:46 +0100)]
Close Bug:443 - Implement ImmediateEventExecutor wrapper to config-subsystem.

Change-Id: I7b633407ce186507379c0008408deae3775fd0df
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoAdd watchdog thread to detect illegal blocking calls during second phase commit. 70/4870/5
Tomas Olvecky [Fri, 14 Feb 2014 15:22:10 +0000 (16:22 +0100)]
Add watchdog thread to detect illegal blocking calls during second phase commit.

Add a thread that starts when second phase commit starts, that will monitor if
a module instance occupies the commit thread for more than 5 seconds. If so, log
a warning every second informing about possible misuse of config subsystem to
block on external resources.
Added a proxy module that caches Module#getInstance() call as this method is
idempotent.

Change-Id: Ia1e56386bdd8c6b7a6dc625cfc69253b927c92a9
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBetter exception handling when instantiating YangModelBindingProvider, fix confignetc... 58/5458/1
Tomas Olvecky [Tue, 25 Feb 2014 13:44:26 +0000 (14:44 +0100)]
Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator.

Do not just log exception if it occurs while calling getModuleInfo, but add it as nested exception.
Fix confignetconfconnector activator: if activator fails to find ConfigRegistry, stop method should interrupt searching for it.

Change-Id: I0b97e5a044be0fd2304b35d34f46a1c540aac248
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "fix bug 431"
Tony Tkacik [Tue, 25 Feb 2014 12:02:03 +0000 (12:02 +0000)]
Merge "fix bug 431"

6 years agoMerge "Integration test added to netconf-it to test identity (de)serialization."
Tony Tkacik [Tue, 25 Feb 2014 11:58:13 +0000 (11:58 +0000)]
Merge "Integration test added to netconf-it to test identity (de)serialization."

6 years agoMerge "Accept agentpath as a parameter to the run script"
Tony Tkacik [Tue, 25 Feb 2014 11:56:20 +0000 (11:56 +0000)]
Merge "Accept agentpath as a parameter to the run script"

6 years agoMerge changes I1b834def,Iece78be2
Tony Tkacik [Tue, 25 Feb 2014 11:54:25 +0000 (11:54 +0000)]
Merge changes I1b834def,Iece78be2

* changes:
  Removed duplicated dependency declaration: ietf-netconf-monitoring,ietf-netconf-monitoring-extension from commons.opendaylight.
  Move xtend dependency definition from md-sal pom to commons.opendaylight

6 years agoSalRemoteClientDeployer - instantiate SalRemoteClient for given URL. 87/5387/6
Milos Fabian [Tue, 18 Feb 2014 09:44:24 +0000 (10:44 +0100)]
SalRemoteClientDeployer - instantiate SalRemoteClient for given URL.

SalRemoteClient:
-Creates schema context.
-Initialize mapping service
-Creates restconf client
-Starts sal remote service broker
-Provides consumer registaration

Change-Id: Idc0d8be4c088bac8a4df24b98e482184a6e54665
Signed-off-by: Milos Fabian <milfabia@cisco.com>
6 years agoMerge "Reuse AbstractListenerRegistration"
Tony Tkacik [Tue, 25 Feb 2014 11:24:49 +0000 (11:24 +0000)]
Merge "Reuse AbstractListenerRegistration"

6 years agoRemoved duplicated dependency declaration: ietf-netconf-monitoring,ietf-netconf-monit... 26/5426/2
Tomas Olvecky [Thu, 20 Feb 2014 13:30:10 +0000 (14:30 +0100)]
Removed duplicated dependency declaration: ietf-netconf-monitoring,ietf-netconf-monitoring-extension from commons.opendaylight.

Change-Id: I1b834def2831acfae7749b24a6778f5811aca182
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMove xtend dependency definition from md-sal pom to commons.opendaylight 25/5425/3
Tomas Olvecky [Thu, 20 Feb 2014 12:59:28 +0000 (13:59 +0100)]
Move xtend dependency definition from md-sal pom to commons.opendaylight

Change-Id: Iece78be2da9a8797deb082a7d81030a2c85dac26
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "Fix some sonar bugs in config-api and config-manager."
Tony Tkacik [Tue, 25 Feb 2014 11:10:25 +0000 (11:10 +0000)]
Merge "Fix some sonar bugs in config-api and config-manager."

6 years agoRpcRegistration.close() should not throw 55/5455/1
Robert Varga [Tue, 25 Feb 2014 10:12:14 +0000 (11:12 +0100)]
RpcRegistration.close() should not throw

Closing an RPC registration is an atomic act, e.g. it should never be
allowed to throw exceptions.

Change-Id: Ie49c67691540db4d4a8a21814e01d3287c5f31cd
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoReuse AbstractListenerRegistration 05/5405/2
Robert Varga [Wed, 19 Feb 2014 02:54:03 +0000 (03:54 +0100)]
Reuse AbstractListenerRegistration

No sense in defining a new class -- just reuse what's already there.
Also uncovers the fact that we're losing an underlying registration --
but let's deal with that once the ListenerRegistration API changes not
to throw exceptions on close().

Change-Id: I5a12b1d7ca89f1608bc54b3f1a520223e650d53f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agofix bug 431 54/5454/1
Vaclav Demcak [Mon, 24 Feb 2014 21:52:44 +0000 (22:52 +0100)]
fix bug 431

Change-Id: Ifd972d7e8acfbc8ed2b9d64391f156b09617d304
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
6 years agoRefactor configuration for ConfigPersister. 86/5286/8
Maros Marsalek [Tue, 11 Feb 2014 16:40:39 +0000 (17:40 +0100)]
Refactor configuration for ConfigPersister.

Pulled Configuration class from ConfigPusher that contains all the delays, timeouts and attempts numbers.

Add tests for config perister.

Change-Id: I187e721e0120931d0cca519353db840905816a20
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Modify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT."
Tony Tkacik [Mon, 24 Feb 2014 17:22:10 +0000 (17:22 +0000)]
Merge "Modify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT."

6 years agoException for URI /restconf/operations/module_name:rpc ended with slash 94/5394/4
Jozef Gloncak [Tue, 18 Feb 2014 13:05:44 +0000 (14:05 +0100)]
Exception for URI /restconf/operations/module_name:rpc ended with slash

If URI of type /restconf/operations/module_name:rpc ends with slash
character (/) then exception with HTTP return code 404 and text
"Identifier IDENTIFIER_NAME can't contain slash character (/). If slash is
part of identifier name then use %2F placeholder."

Change-Id: Idbed90515280b414c10d28dc608faeee24986a29
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoFix for bugs 446 and 456 52/5452/1
Ryan Moats [Mon, 24 Feb 2014 15:39:03 +0000 (09:39 -0600)]
Fix for bugs 446 and 456

Fix for "Null pointer exception on remove_router_interface" (Bug 446)
and "Return better error messages from NeutronAPIService" (Bug 456)

Change-Id: I60c24ac37a91653e4c6f5ff2d654e8f85ad78d44
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
6 years agoAdded support to register of RPC Implementation. 49/5449/1
Lukas Sedlak [Mon, 24 Feb 2014 10:00:40 +0000 (11:00 +0100)]
Added support to register of RPC Implementation.

NetconfDevice has now has capability to support of rpc implementation which adds support for ODL to send rpcs towards netconf server.
Added fix for commit handler registration. Now the commit handler is registered only and only when mount instance is availible.

Change-Id: I11eced0fda40b3c0cd66fd6477c4df45304d3e18
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoAdded documentation into web socket in RestConf 39/5439/2
Ladislav Borak [Fri, 21 Feb 2014 12:19:50 +0000 (13:19 +0100)]
Added documentation into web socket in RestConf

Change-Id: I36fae4c8916c6d25a1b9619390467e48b64e8a3d
Signed-off-by: Ladislav Borak <lborak@cisco.com>
6 years agoMerge "Backward compatibility for User management"
Andrew Kim [Sun, 23 Feb 2014 01:50:47 +0000 (01:50 +0000)]
Merge "Backward compatibility for User management"

6 years agoModify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT. 61/5261/6
Maros Marsalek [Tue, 11 Feb 2014 15:36:32 +0000 (16:36 +0100)]
Modify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT.

Change ConflictingVersionException and ValidationException to be checked instead of
runtime exceptions.
Fix ConfigPusher's ConflictVersionException handling that was introduced when IOException was
used to wrap RuntimeException.
Small fixes in netconf, more refactoring of exception handling will be needed there.

Maros Marsalek: Rebase commit + fix compliation issue in ShutdownTest

Change-Id: Iab89de6ef6ced0de0a267470f860912ae3c56892
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoIntegration test added to netconf-it to test identity (de)serialization. 37/5437/1
Maros Marsalek [Fri, 21 Feb 2014 10:48:44 +0000 (11:48 +0100)]
Integration test added to netconf-it to test identity (de)serialization.

Change-Id: I637011107edea916aaab35e8d2298bbbbabed653
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Fix message aggregator for chunked netconf messages."
Tony Tkacik [Fri, 21 Feb 2014 10:44:16 +0000 (10:44 +0000)]
Merge "Fix message aggregator for chunked netconf messages."

6 years agoFix message aggregator for chunked netconf messages. 23/5423/3
Maros Marsalek [Thu, 20 Feb 2014 12:19:03 +0000 (13:19 +0100)]
Fix message aggregator for chunked netconf messages.

Aggregator did not work with 1 message in multiple chunks.

Change-Id: I03cc89c3fc56a52f077fd21f77bd98e47ea358a9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoFix some sonar bugs in config-api and config-manager. 15/5415/2
Tomas Olvecky [Wed, 19 Feb 2014 14:43:41 +0000 (15:43 +0100)]
Fix some sonar bugs in config-api and config-manager.

Change-Id: I417bb4bdd649606d871382e7bf561d35daafc11b
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMake use of new sendMessage method in AbstractNegotiator 93/5393/2
Maros Marsalek [Tue, 18 Feb 2014 11:58:47 +0000 (12:58 +0100)]
Make use of new sendMessage method in AbstractNegotiator

Change-Id: Ieeb104aa34b8140936a1daf8011ba3b0effc79d5
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "ConfigurationService to create default config dir"
Alessandro Boch [Wed, 19 Feb 2014 21:42:43 +0000 (21:42 +0000)]
Merge "ConfigurationService to create default config dir"

6 years agoAccept agentpath as a parameter to the run script 18/5418/1
Moiz Raja [Wed, 19 Feb 2014 20:04:36 +0000 (12:04 -0800)]
Accept agentpath as a parameter to the run script

This is to be used when you want to start open daylight with say the yourkit profiling agent

Usage would be something like this,

./run.sh -agentpath:"/Applications/Yourkit.app/bin/mac/agent.lib"

Change-Id: I0034adab46dc5185e54dfb22c85985324f82d0fb
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoConfigurationService to create default config dir 07/5407/5
Yevgeny Khodorkovsky [Wed, 19 Feb 2014 03:16:15 +0000 (19:16 -0800)]
ConfigurationService to create default config dir

- Have ConfigurationService create a default startup config directory,
  so that container unaware apps/modules can initiate and individual
  save.
- Semantic fixes in IConfigurationContainerService
- Bump configuration api rev since methods were added since last rev

Change-Id: Ifec274c258859a402f6dad7394c43c28ed162b95
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoMerge "bug 433 NPE in onGlobalContextUpdated of ControllerContext class"
Tony Tkacik [Wed, 19 Feb 2014 15:29:03 +0000 (15:29 +0000)]
Merge "bug 433 NPE in onGlobalContextUpdated of ControllerContext class"

6 years agoAdd ModuleInfoBackedContext loading strategy to RuntimeGeneratedMapping service. 14/5414/2
Maros Marsalek [Tue, 18 Feb 2014 15:51:09 +0000 (16:51 +0100)]
Add ModuleInfoBackedContext loading strategy to RuntimeGeneratedMapping service.

RuntimeGeneratedMappingServiceImpl is now started by the config-manager.
ModuleInfoBackedContext is filled by BundleTracker in config-manager.

This fix allows use of yang identities in netconf and restconf.

Change-Id: Id59d9d2ce08bfc9216d90cb5673e2d02aafd9151
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "BUG-421: Define multipart-transaction-aware"
Tony Tkacik [Wed, 19 Feb 2014 14:41:07 +0000 (14:41 +0000)]
Merge "BUG-421: Define multipart-transaction-aware"

6 years agobug 433 NPE in onGlobalContextUpdated of ControllerContext class 12/5412/1
Jozef Gloncak [Wed, 19 Feb 2014 12:32:51 +0000 (13:32 +0100)]
bug 433 NPE in onGlobalContextUpdated of ControllerContext class

Input parameter of type SchemaContext of method onGlobalContextUpdated is
now checked if is different from null to be able to call getOperations method.
In addition clearing of map of rpcs was added.

Change-Id: I2b69d7f50acba041ade17acba8b3f2af7b3e4d9c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoStop config-manager as first bundle when shutting down container. 11/5411/1
Tomas Olvecky [Wed, 19 Feb 2014 10:58:33 +0000 (11:58 +0100)]
Stop config-manager as first bundle when shutting down container.

If config-manager is stopped after a configured module's bundle has been stopped, config-manager will be unable to cleanly
close other instances, so it needs to be stopped as first bundle.
GlobalEventExecutorModule (netty-global-event-executor) is singleton, enforce it in only allowing one instance
called 'singleton'.
Make shutdown grace period smaller in order to close netty threads sooner that shutdown issues System.exit(1).

Change-Id: I042c606a5bedc49492784dcb0a5ad4dcbdcb0939
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBackward compatibility for User management 04/5404/1
Sapan Shah [Wed, 19 Feb 2014 02:45:48 +0000 (18:45 -0800)]
Backward compatibility for User management

Change-Id: I844d959852cd40fa242ac56b6efa36b2982e73ec
Signed-off-by: Sapan Shah <sapshah@cisco.com>
6 years agoAdd logging for HashMapDataStore 95/5395/1
Robert Varga [Tue, 18 Feb 2014 15:36:36 +0000 (16:36 +0100)]
Add logging for HashMapDataStore

Change-Id: Icea99ff59317cc387a1143762840795149d4058e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "bug 344 interpretation of slashes ('/') in URI"
Tony Tkacik [Tue, 18 Feb 2014 15:18:53 +0000 (15:18 +0000)]
Merge "bug 344 interpretation of slashes ('/') in URI"

6 years agoMerge "Switch from using xtend to java in md-sal adapters"
Tony Tkacik [Tue, 18 Feb 2014 15:18:22 +0000 (15:18 +0000)]
Merge "Switch from using xtend to java in md-sal adapters"

6 years agoMerge "Activate enforcement of Path type"
Tony Tkacik [Tue, 18 Feb 2014 12:30:44 +0000 (12:30 +0000)]
Merge "Activate enforcement of Path type"

6 years agobug 344 interpretation of slashes ('/') in URI 68/5368/3
Jozef Gloncak [Mon, 17 Feb 2014 14:13:56 +0000 (15:13 +0100)]
bug 344 interpretation of slashes ('/') in URI

If slash (/) should be part of path parameter from URI it can be specified with %2F
placeholder.
e.g. list which key is "ke/y_1" CAN'T be specified as
list_name/ke/y_1
but should be constructed as
list_name/ke%2Fy_1

It is also necessary to add to target distribution folder
/opendaylight/configuration/config.ini
following line
org.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true

Change-Id: Id07e7969247f3b60a44b808c95dac6375cebc011
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoMerge "Introduce checked sendMessage() method"
Tony Tkacik [Tue, 18 Feb 2014 12:23:33 +0000 (12:23 +0000)]
Merge "Introduce checked sendMessage() method"

6 years agoActivate enforcement of Path type 92/5392/1
Robert Varga [Tue, 18 Feb 2014 11:33:01 +0000 (12:33 +0100)]
Activate enforcement of Path type

This activates pre-prepared requirement of P to be of type Path<P>,
which had prerequisites in generated DTOs. Yangtools have been updated,
so it should be safe to activate this now.

Change-Id: I68ad3a77311e44db2e6bee1d7e2b3684090e5cbd
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix warnings in netconf-api and netconf-util 67/5367/4
Maros Marsalek [Mon, 17 Feb 2014 14:03:57 +0000 (15:03 +0100)]
Fix warnings in netconf-api and netconf-util

Change-Id: Icd7f605796ddb38cc01ac08c4de7e3c62cc8da39
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoImprove NETCONF encoding performance 80/5380/3
Robert Varga [Sat, 15 Feb 2014 17:24:21 +0000 (18:24 +0100)]
Improve NETCONF encoding performance

This changes the protocol encoder such that it is piped directly into
the output buffer rather than constructing intermediate buffers and
strings.

Change-Id: I4938b2fd72b2321d21617c4e9c8a4d491778b657
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Untangle the XML/Hello message decoders"
Tony Tkacik [Tue, 18 Feb 2014 11:05:27 +0000 (11:05 +0000)]
Merge "Untangle the XML/Hello message decoders"

6 years agoMerge "Do not instantiate multiple DocumentBuilderFactories"
Tony Tkacik [Tue, 18 Feb 2014 11:01:13 +0000 (11:01 +0000)]
Merge "Do not instantiate multiple DocumentBuilderFactories"

6 years agoMerge "Split message aggregators"
Tony Tkacik [Tue, 18 Feb 2014 10:59:36 +0000 (10:59 +0000)]
Merge "Split message aggregators"

6 years agoMerge "Correct encoding"
Tony Tkacik [Tue, 18 Feb 2014 10:58:25 +0000 (10:58 +0000)]
Merge "Correct encoding"

6 years agoMerge "Cleanup framing mechanisms"
Tony Tkacik [Tue, 18 Feb 2014 10:57:13 +0000 (10:57 +0000)]
Merge "Cleanup framing mechanisms"

6 years agoIntroduce checked sendMessage() method 90/5390/1
Robert Varga [Tue, 18 Feb 2014 10:39:14 +0000 (11:39 +0100)]
Introduce checked sendMessage() method

This method send a message down the socket and makes sure that
negotiation fails if the message does not reach the peer for any reason.
Subclasses should use this method instead of talking directly to the
underlying channel.

Change-Id: I5b8201caef1c4ba655dad12fb139b054b9e75f06
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix a few more warnings 86/5386/1
Robert Varga [Tue, 18 Feb 2014 08:53:30 +0000 (09:53 +0100)]
Fix a few more warnings

- Remove unused string constants
- Add type arguments
- Removed unused field

Change-Id: I8fbbd238a805d9445eecc4d7c65176ce4ff36b6d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoOptimize empty transactions 84/5384/3
Robert Varga [Tue, 18 Feb 2014 08:34:14 +0000 (09:34 +0100)]
Optimize empty transactions

This is a micro-optimization: if we know there are no affected paths,
we used to spin an entire transaction -- which ended up revalidating an
empty delta. Let's skip the entire circus and proceed to commit
directly.

Change-Id: Ia6250663c01348dd08610c2a44dc01743761a05c
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAnother round of warnings fixes 82/5382/3
Robert Varga [Tue, 18 Feb 2014 07:34:56 +0000 (08:34 +0100)]
Another round of warnings fixes

Removes one unused method
Fixes raw type usage where possible
Organize imports to get rid of unused/duplicate imports
Remove the use of deprecated InstanceIdentifier methods

Change-Id: I75bac5eae1e8cffcf88ab01451d3e4a8afa8c43e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoPlace an upper bound on notification concurrency 81/5381/3
Robert Varga [Tue, 18 Feb 2014 06:43:15 +0000 (07:43 +0100)]
Place an upper bound on notification concurrency

In Cbench tests we have seen as many as 2000 threads being created. This
is certainly an overkill and thus let's place an upper bound on the
number of threads we create.

Change-Id: I6a7f429080504cbfa75679cc5879264a0622f140
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove unused ganymed.version property 83/5383/3
Robert Varga [Tue, 18 Feb 2014 07:47:06 +0000 (08:47 +0100)]
Remove unused ganymed.version property

Change-Id: Ifffaa15f77bed86c04909b5f6aee8ec389779994
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoUntangle the XML/Hello message decoders 79/5379/1
Robert Varga [Sun, 16 Feb 2014 05:46:06 +0000 (06:46 +0100)]
Untangle the XML/Hello message decoders

The tie between these classes was completely unnecessary -- we had this
complicated contract just for the sake of reusing couple of lines of
code. Untangle and optimize.

Change-Id: I6fd29ba0ff5d87a5fb2362e87e4fb1361544429f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDo not instantiate multiple DocumentBuilderFactories 78/5378/1
Robert Varga [Sun, 16 Feb 2014 05:44:49 +0000 (06:44 +0100)]
Do not instantiate multiple DocumentBuilderFactories

We're instantiating builders themsenves, so we can safely reuse a single
factory. No sense in initiating it more than once.

Change-Id: I70dfa2d5cc51a09722bb7ad41ce4d61f8691ac3d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoSplit message aggregators 77/5377/1
Robert Varga [Sun, 16 Feb 2014 04:29:51 +0000 (05:29 +0100)]
Split message aggregators

This splits the EOM aggregator and the chunked encoding aggregator. The
chunked encoding can be much more efficient and hardened as it allows
for proper stream processing.

We do not go the entire way here, just tighten the chunk header parsing
by keeping an explicit state machine. We still need to gather the entire
message before shifting it, as our downstream expects to see the message
in its entirety.

Change-Id: I60947b6d018b73581a56adda5212d3482dda61ea
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCorrect encoding 76/5376/1
Robert Varga [Sun, 16 Feb 2014 03:31:16 +0000 (04:31 +0100)]
Correct encoding

NETCONF chunked encoding is transferred in US_ASCII, not UTF-8.

Change-Id: I33d45b0d2806c91aaf5c22fcaf3731fdad6cf7f6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCleanup framing mechanisms 75/5375/1
Robert Varga [Sat, 15 Feb 2014 22:21:51 +0000 (23:21 +0100)]
Cleanup framing mechanisms

This gets rid of pre-instantiated NetconfMessageHeader in favor of
creating a static constructor method.

Furthermore allow our output chunking to be variable and bump the
default from 1K to 8K. The upper limit on chunk size is 16M.

Change-Id: I0ab4405fc7d750cca5875049f03b053aa80037ef
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoUpdate UserConfig with salt value while changing roles 74/5374/1
Sapan Shah [Tue, 18 Feb 2014 01:31:20 +0000 (17:31 -0800)]
Update UserConfig with salt value while changing roles

Change-Id: If99955c69cbf374e891db37c7a7f584f37acc047
Signed-off-by: Sapan Shah <sapshah@cisco.com>
6 years agoSwitch from using xtend to java in md-sal adapters 73/5373/3
Moiz Raja [Mon, 17 Feb 2014 23:55:59 +0000 (15:55 -0800)]
Switch from using xtend to java in md-sal adapters

This is part of my effort to switch all xtend code in the adapters to java

Change-Id: I10c679fbe5f7980facd1b5e5d2e0a5c3ae997ff6
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Fix eclipse warnings about maven-enforcer-plugin"
Tony Tkacik [Mon, 17 Feb 2014 17:03:54 +0000 (17:03 +0000)]
Merge "Fix eclipse warnings about maven-enforcer-plugin"

6 years agoMerge "CHange log level from warn to debug in ProtocolSessionPromise when connection...
Tony Tkacik [Mon, 17 Feb 2014 16:31:35 +0000 (16:31 +0000)]
Merge "CHange log level from warn to debug in ProtocolSessionPromise when connection attempt fails"

6 years agoFix eclipse warnings about maven-enforcer-plugin 58/5358/2
Robert Varga [Sun, 16 Feb 2014 11:53:22 +0000 (12:53 +0100)]
Fix eclipse warnings about maven-enforcer-plugin

This patch adds an ignore lifecycle mapping, letting eclipse know it
should ignore the plugin.

Change-Id: I6508c5a929a30042197af3a390fe34378a348b9a
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge changes I393151af,I0a302cde
Tony Tkacik [Mon, 17 Feb 2014 16:30:03 +0000 (16:30 +0000)]
Merge changes I393151af,I0a302cde

* changes:
  Fix unused field warnings
  Fix warnings about overriden versions

6 years agoMerge "Add support for multiple choice case statements within one augument in config...
Tony Tkacik [Mon, 17 Feb 2014 16:28:11 +0000 (16:28 +0000)]
Merge "Add support for multiple choice case statements within one augument in config yang files"

6 years agoMerge "Fix namespaces for netconf monitoring extensions."
Tony Tkacik [Mon, 17 Feb 2014 16:19:09 +0000 (16:19 +0000)]
Merge "Fix namespaces for netconf monitoring extensions."

6 years agoFix typo in switchmanager log message in word 'available' 66/5366/1
Alissa Bonas [Mon, 17 Feb 2014 12:49:20 +0000 (14:49 +0200)]
Fix typo in switchmanager log message in word 'available'

Change-Id: I97bd3d69109b9fec460793758f9a56459a5226b0
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoFix unused field warnings 57/5357/2
Robert Varga [Sun, 16 Feb 2014 11:22:03 +0000 (12:22 +0100)]
Fix unused field warnings

Removes affected fields, add @Override annotations and make constant
fields final.

Change-Id: I393151af1459e31eeded0786cf32223068635172
Signed-off-by: Robert Varga <rovarga@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.