8 years agoMerge "Fixed namespace of yang testing file."
Tony Tkacik [Tue, 5 Aug 2014 10:09:13 +0000 (10:09 +0000)]
Merge "Fixed namespace of yang testing file."

8 years agoMerge "Bug 1354: Fixed rpc request/result transformation."
Tony Tkacik [Tue, 5 Aug 2014 09:28:44 +0000 (09:28 +0000)]
Merge "Bug 1354: Fixed rpc request/result transformation."

8 years agoFixed typo in restconf, which caused classcast in datastore. 61/9661/2
Tony Tkacik [Mon, 4 Aug 2014 17:46:39 +0000 (19:46 +0200)]
Fixed typo in restconf, which caused classcast in datastore.

Change-Id: I51eb1fc2e4056dc84feb3b720c3ee844ee4ffdea
Signed-off-by: Tony Tkacik <>
8 years agoDowngraded to hamcrest 1.1 to fix the build 76/9676/1
Ed Warnicke [Mon, 4 Aug 2014 22:14:23 +0000 (17:14 -0500)]
Downgraded to hamcrest 1.1 to fix the build

Change-Id: I5dc385ed61e8290eb81c50973417bd6ceb1c7508
Signed-off-by: Ed Warnicke <>
8 years agoMerge "BUG 1162 - ensure data for all path arguments in datastore."
Tony Tkacik [Mon, 4 Aug 2014 14:11:50 +0000 (14:11 +0000)]
Merge "BUG 1162 - ensure data for all path arguments in datastore."

8 years agoBUG 1162 - ensure data for all path arguments in datastore. 41/9641/3
Jozef Gloncak [Mon, 4 Aug 2014 06:28:14 +0000 (08:28 +0200)]
BUG 1162 - ensure data for all path arguments in datastore.

1) It is possible to specify path to data (including lists with
keys) via unexisting nodes and store payload data to this path.
Missing nodes in datastore are created before storing payload data.
2) InstanceIdentifier is now correctly created via

Change-Id: If795a930015fef39a0029e808355d51357e2d5d5
Signed-off-by: Jozef Gloncak <>
8 years agoFixed namespace of yang testing file. 40/9640/1
Martin Vitez [Mon, 4 Aug 2014 09:57:12 +0000 (11:57 +0200)]
Fixed namespace of yang testing file.

This test used 2 different yang files with same namespace, which is incorrect and can cause test fail later.

Change-Id: I87a78e36d1d8812bb92f71c82722f87559907423
Signed-off-by: Martin Vitez <>
8 years agoBug 1354: Fixed rpc request/result transformation. 33/9233/3
Lukas Sedlak [Fri, 18 Jul 2014 09:40:23 +0000 (11:40 +0200)]
Bug 1354: Fixed rpc request/result transformation.

This commit is dependent on commit in Yangtools project.
Fixed proper data transformation in toRpcRequest method in NetconfMessageTransformer.
Now every rpc request (edit-config, get and get-config) will be transformed for given Schema Context.

Change-Id: I08da9200c0ba680b36a445978e7de748e94b654d
Signed-off-by: Lukas Sedlak <>
8 years agoReturn a NoOpTransactionContext when the Primary for a shard is not found 36/9636/1
Moiz Raja [Sun, 3 Aug 2014 19:23:16 +0000 (12:23 -0700)]
Return a NoOpTransactionContext when the Primary for a shard is not found

A NoOpTransactionContext is returned when a request to create a transaction
results in the primary not being found or when the request times out.

A CanCommit on the NoOpTransaction will always false. A read
will always return an empty result. The consumer will need to deal with this situation.

Change-Id: Id6f7d0688921acac718b9bb06fbf03d5e345d7ac
Signed-off-by: Moiz Raja <>
8 years agoKeep DataChange registrations and notifications local 27/9627/2
Moiz Raja [Sun, 3 Aug 2014 13:36:13 +0000 (06:36 -0700)]
Keep DataChange registrations and notifications local

Here is how it works
When a consumer registers for a datachange notification we first check if the Shard
to which this registration needs to be sent is local. If it is then we send the
registration to it. If it is not then we simply return a NoOpRegistration to the consumer.
This ensures that a DataChange registration stays local to a cluster member.

Now let's say we have 3 replicas and in all those replicas we do find a local shard for a
given module and we have 3 listener registrations. At this time we do not want all 3 members
to be notified of the change. We only want the node which is the Leader to notify it's listeners
of the change. To restrict that the DataChangeListener will only forward events to the listener
if the Shard sends it a message enabling notifications

Change-Id: I035bbdf34e2509047f4bcb475c443a761b08e68d
Signed-off-by: Moiz Raja <>
8 years agoFix a couple of issues with replication 96/9596/4
Moiz Raja [Fri, 1 Aug 2014 23:14:05 +0000 (16:14 -0700)]
Fix a couple of issues with replication

- First the data that was being sent from the primary was not being deserialized on the followers
- The state on the followers was not being applied correctly
- Add sal-distributed-datastore to the distribution

Added a test for CompositeModificationPayload to ensure that serialization works correctly
Also added a set of integration test programs to test the serialization

Change-Id: Id67d2c4fe471003d9dd3b42a8376c90fd23492ce
Signed-off-by: Moiz Raja <>
8 years agoBUG-1473: update model.util.InstanceIdentifier users 23/9623/4
Robert Varga [Sun, 3 Aug 2014 11:31:05 +0000 (13:31 +0200)]
BUG-1473: update model.util.InstanceIdentifier users

Companion patch to, updates
users to use the new name. Also make the code a tiny bit more readable.

Fixed conversion to checked Future.

Change-Id: If8da3639e656214713d3680951cd9ae724c5ad6f
Signed-off-by: Robert Varga <>
8 years agoMerge "Bug 1392: Change ReadTransaction#read to return CheckedFuture"
Tony Tkacik [Sun, 3 Aug 2014 18:17:46 +0000 (18:17 +0000)]
Merge "Bug 1392: Change ReadTransaction#read to return CheckedFuture"

8 years agoMerge "BUG-1281: share filters between instances"
Tony Tkacik [Sun, 3 Aug 2014 18:14:29 +0000 (18:14 +0000)]
Merge "BUG-1281: share filters between instances"

8 years agoMerge "BUG-1281: use SchemaContext lookups"
Tony Tkacik [Sun, 3 Aug 2014 18:14:14 +0000 (18:14 +0000)]
Merge "BUG-1281: use SchemaContext lookups"

8 years agoMerge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"
Tony Tkacik [Sun, 3 Aug 2014 18:10:03 +0000 (18:10 +0000)]
Merge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"

8 years agoBUG-1281: share filters between instances 03/9403/4
Robert Varga [Mon, 28 Jul 2014 19:53:51 +0000 (21:53 +0200)]
BUG-1281: share filters between instances

The filters are invariants, so lets share them accross instances and not
instantiate them each time we need them.

Change-Id: Ib632efe758c22bd782fca0536c2fe7e9c6e831c3
Signed-off-by: Robert Varga <>
8 years agoBUG-1281: use SchemaContext lookups 02/9402/4
Robert Varga [Mon, 28 Jul 2014 19:45:12 +0000 (21:45 +0200)]
BUG-1281: use SchemaContext lookups

SchemaContext provides efficient module lookup services. Use those
instead of homegrown versions.

Change-Id: I4406438b137c8742a5265036f84a66d7f0f441c0
Signed-off-by: Robert Varga <>
8 years agoAdded test cases for each .proto file to ensure 95/9595/2
Basheeruddin Ahmed [Fri, 1 Aug 2014 23:06:18 +0000 (16:06 -0700)]
Added test cases for each .proto file to ensure
that test case fail in case incompatible version
of the protocol buffer is utilized.

New Patch: Updated with copyright header

Change-Id: Ib7fe9e212c6319f46202506d96544d149da28004
Signed-off-by: Basheeruddin Ahmed <>
8 years agoMerge "OS Neutron FWaaS api/jaxrs and associated bindings"
Madhu Venugopal [Sun, 3 Aug 2014 06:41:19 +0000 (06:41 +0000)]
Merge "OS Neutron FWaaS api/jaxrs and associated bindings"

8 years agoOS Neutron FWaaS api/jaxrs and associated bindings 26/9526/3
Brent Salisbury [Thu, 31 Jul 2014 11:01:53 +0000 (07:01 -0400)]
OS Neutron FWaaS api/jaxrs and associated bindings

-Removed and cleaned up some comments.
-Fixed null check on Firewall Rules

The Neutron v2.0 API document can be viewed at:

Sample API calls that can be imported into Postman
are located in the OVSDB directory at:
Directory: [ovsdb] / resources / openstack /
File: Neutron-v2.0-API-Examples.json.postman_collection

Change-Id: If37a0dd702aa02db9e94811c9a414718d25f42a7
Signed-off-by: Brent Salisbury <>
8 years agoMerge "Created Sample Feature Test Class for Base Feature Repository"
Madhu Venugopal [Sat, 2 Aug 2014 08:34:32 +0000 (08:34 +0000)]
Merge "Created Sample Feature Test Class for Base Feature Repository"

8 years agoMerge "added feature topology manager shell"
Madhu Venugopal [Sat, 2 Aug 2014 07:36:26 +0000 (07:36 +0000)]
Merge "added feature topology manager shell"

8 years agoMerge "Added hosttracker shell for karaf (rebased)"
Madhu Venugopal [Sat, 2 Aug 2014 07:33:30 +0000 (07:33 +0000)]
Merge "Added hosttracker shell for karaf (rebased)"

8 years agoMerge "Ignore generated journal directory"
Moiz Raja [Sat, 2 Aug 2014 04:17:41 +0000 (04:17 +0000)]
Merge "Ignore generated journal directory"

8 years agoMerge "Configuration Interface for Raft"
Moiz Raja [Fri, 1 Aug 2014 23:24:56 +0000 (23:24 +0000)]
Merge "Configuration Interface for Raft"

8 years agoMerge "Snapshot changes"
Moiz Raja [Fri, 1 Aug 2014 23:22:09 +0000 (23:22 +0000)]
Merge "Snapshot changes"

8 years agoMerge "Adding a constant file for actor names and paths."
Moiz Raja [Fri, 1 Aug 2014 23:19:31 +0000 (23:19 +0000)]
Merge "Adding a constant file for actor names and paths."

8 years agoConfiguration Interface for Raft 56/9556/2
Kamal Rameshan [Fri, 1 Aug 2014 02:38:48 +0000 (19:38 -0700)]
Configuration Interface for Raft

A default implementation for the ConfigParams is provided.

The client can override and provide an impl of ConfigParams.

For now only 4 parameters have been introduced. More can be added.

ExampleActor and TestDriver provide examples.

Change-Id: I42a46a521ad9364d535de479c58873dc70740c9f
Signed-off-by: Kamal Rameshan <>
8 years agoadded feature topology manager shell 42/7542/5
Jonathan Fok kan [Thu, 31 Jul 2014 21:05:01 +0000 (17:05 -0400)]
added feature topology manager shell

The shell is installed when odl-nsf-managers is installed

Change-Id: I460c71231ed54342983271304356737a1cb6c377
Signed-off-by: Jonathan Fok Kan <>
8 years agoAdded hosttracker shell for karaf (rebased) 09/9409/6
Gabriel Robitaille-Montpetit [Thu, 31 Jul 2014 19:59:52 +0000 (15:59 -0400)]
Added hosttracker shell for karaf (rebased)

Change-Id: I6c8eec9fddcd1a7d82e12e27f232fdaad65607b2
Signed-off-by: Gabriel Robitaille-Montpetit <>
8 years agoBUG 1082 Migrate sal-rest-connector to Async Data Broker API 57/8457/18
Jozef Gloncak [Mon, 30 Jun 2014 13:58:56 +0000 (15:58 +0200)]
BUG 1082 Migrate sal-rest-connector to Async Data Broker API

Rework of sal-rest-connector project to support Async Data Broker API

Change-Id: I73804418a04445b236d12693e493a11850dd94dd
Signed-off-by: Jozef Gloncak <>
8 years agoIgnore generated journal directory 72/9572/1
Ed Warnicke [Fri, 1 Aug 2014 11:23:17 +0000 (06:23 -0500)]
Ignore generated journal directory

Change-Id: I3557f3d2b3aee5ee553fa9b7b1f63428043ef2b3
Signed-off-by: Ed Warnicke <>
8 years agoAdded configfile to config-netty feature. 54/9554/2
Ed Warnicke [Fri, 1 Aug 2014 01:14:07 +0000 (20:14 -0500)]
Added configfile to config-netty feature.

Change-Id: Id5fea6efd0c65f4391e2c3e772611db74f6bc71c
Signed-off-by: Ed Warnicke <>
8 years agoMoved all config subsystem config files to mvn projects. 51/9551/3
Ed Warnicke [Thu, 31 Jul 2014 23:19:46 +0000 (18:19 -0500)]
Moved all config subsystem config files to mvn projects.

Change-Id: I98f4ab29fd57b800d5c9272e866ead3519e09264
Signed-off-by: Ed Warnicke <>
8 years agoMerge "Bug 1333: Regression Test suite."
Ed Warnicke [Fri, 1 Aug 2014 10:25:31 +0000 (10:25 +0000)]
Merge "Bug 1333: Regression Test suite."

8 years agoMerge "BUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector"
Tony Tkacik [Fri, 1 Aug 2014 09:44:05 +0000 (09:44 +0000)]
Merge "BUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector"

8 years agoMerge "Fix xsql compilation failure"
Tony Tkacik [Fri, 1 Aug 2014 09:43:54 +0000 (09:43 +0000)]
Merge "Fix xsql compilation failure"

8 years agoMerge "Bug 1369: Use separate single threadpool for data operations on binding mountp...
Ed Warnicke [Fri, 1 Aug 2014 09:35:31 +0000 (09:35 +0000)]
Merge "Bug 1369: Use separate single threadpool for data operations on binding mountpoint."

8 years agoBUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector 71/9471/2
Maros Marsalek [Tue, 29 Jul 2014 12:44:50 +0000 (14:44 +0200)]
BUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector

When a failed rpc is detected, issue a discard changes rpc to keep device (candidate) configuration consistant (if candidate is supported).

Change-Id: Ia752ee33043b3159fd71b01eef34e6e79baf18be
Signed-off-by: Maros Marsalek <>
8 years agoFix xsql compilation failure 68/9568/1
Maros Marsalek [Fri, 1 Aug 2014 08:51:27 +0000 (10:51 +0200)]
Fix xsql compilation failure

Change-Id: I89fe87b64dd1377a89caad86d5a3bf91e3e40402
Signed-off-by: Maros Marsalek <>
8 years agoMerge "ControllerContext.dataNodeChildByQName method refactoring"
Tony Tkacik [Fri, 1 Aug 2014 08:35:13 +0000 (08:35 +0000)]
Merge "ControllerContext.dataNodeChildByQName method refactoring"

8 years agoMerge "Notificator create stream name method don't remove trailing slash"
Tony Tkacik [Fri, 1 Aug 2014 08:33:53 +0000 (08:33 +0000)]
Merge "Notificator create stream name method don't remove trailing slash"

8 years agoMerge "BUG-628 Allow configuration to override module based capabilities from remote...
Tony Tkacik [Fri, 1 Aug 2014 08:27:50 +0000 (08:27 +0000)]
Merge "BUG-628 Allow configuration to override module based capabilities from remote netconf device"

8 years agoMerge "BUG-868: Migrate to SchemaContextListener"
Tony Tkacik [Fri, 1 Aug 2014 08:00:43 +0000 (08:00 +0000)]
Merge "BUG-868: Migrate to SchemaContextListener"

8 years agoMerge "BUG-190 Simplify reconnect logic in protocol-framework."
Tony Tkacik [Fri, 1 Aug 2014 07:54:59 +0000 (07:54 +0000)]
Merge "BUG-190 Simplify reconnect logic in protocol-framework."

8 years agoMerge "Add XSQL into default compilation"
Tony Tkacik [Fri, 1 Aug 2014 07:50:52 +0000 (07:50 +0000)]
Merge "Add XSQL into default compilation"

8 years agoControllerContext.dataNodeChildByQName method refactoring 06/9306/3
Jozef Gloncak [Fri, 25 Jul 2014 05:48:29 +0000 (07:48 +0200)]
ControllerContext.dataNodeChildByQName method refactoring

ControllerContext.dataNodeChildByQName() is used only in childByQName()
methods with DataNodeContainer input parameters:
- ContainerSchemaNode
- ListSchemaNode
- Module
Therefore child node of these DataNodeContainers can't be ChoiceCaseNode
(because it can be only child node of ChoiceNode)
and original branch >if (node instanceof ChoiceCaseNode)< couldn't be
I think that it was typo.

Change-Id: Ieb85ad8acaf047b47813542d8968c399a4e30b50
Signed-off-by: Jozef Gloncak <>
8 years agoFix bug in test for distributed datastore 40/9540/2
Maros Marsalek [Thu, 31 Jul 2014 14:50:37 +0000 (16:50 +0200)]
Fix bug in test for distributed datastore

The test compared two normalized nodes using toString representation.
This is wrong since these nodes contain hash map and their order(also toString) changes depending on their content.
THe test compared two normalized nodes that did not contain same values. There was Integer in one and Long in the other.

The test failed for me on (due to hash map ordering):
java version "1.7.0_60"
Java(TM) SE Runtime Environment (build 1.7.0_60-b19)
Java HotSpot(TM) 64-Bit Server VM (build 24.60-b09, mixed mode)

Change-Id: Ib72c871077f79cff8327da9c57cc1faa8677a298
Signed-off-by: Maros Marsalek <>
8 years agoMerge "Fixed for bug : 1171 - issue while creating subnet"
Ed Warnicke [Fri, 1 Aug 2014 02:33:46 +0000 (02:33 +0000)]
Merge "Fixed for bug : 1171 - issue while creating subnet"

8 years agoMerge "Fixed for bug 1197"
Ed Warnicke [Fri, 1 Aug 2014 02:31:30 +0000 (02:31 +0000)]
Merge "Fixed for bug 1197"

8 years agoMerge "Fixed for bug 1168 : Issue while update subnet"
Ed Warnicke [Fri, 1 Aug 2014 02:30:50 +0000 (02:30 +0000)]
Merge "Fixed for bug 1168 : Issue while update subnet"

8 years agoSnapshot changes 20/9520/7
Kamal Rameshan [Thu, 31 Jul 2014 06:00:36 +0000 (23:00 -0700)]
Snapshot changes

Fixed adjusted index logic.
Added tests
Added Reinstate Node in TestDriver.
Changes related to recovery from snapshot
Review changes
Rebased with latest

Tasks to be done:
1. Snapshot capture criteria
2. Handling Snapshot failure
3. Configuration Interface
4. Install snapshot

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
Reinstate from snapshot + review changes

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
TestDriver changes

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
Log interpolation change

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
8 years agoAdding a constant file for actor names and paths. 55/9555/1
Harman Singh [Fri, 1 Aug 2014 01:17:19 +0000 (18:17 -0700)]
Adding a constant file for actor names and paths.

Easier to change the names in future if we have to

Change-Id: Ic57bab8b817e5367d694be12cef0e04aa23fd175
Signed-off-by: Harman Singh <>
8 years agoMerge "Add replication capability to Shard"
Ed Warnicke [Fri, 1 Aug 2014 01:26:27 +0000 (01:26 +0000)]
Merge "Add replication capability to Shard"

8 years agoAdding the wrongly removed module back in pom.xml 52/9552/1
Harman Singh [Fri, 1 Aug 2014 00:37:13 +0000 (17:37 -0700)]
Adding the wrongly removed module back in pom.xml

Change-Id: I242bc87cbf193ed65b6a7f5ffc8e2d466a48b80e
Signed-off-by: Harman Singh <>
8 years agoAdding actor supervisor, more logs and tests 15/9515/2
Harman Singh [Thu, 31 Jul 2014 01:42:26 +0000 (18:42 -0700)]
Adding actor supervisor, more logs and tests

Actor Supervisor will start rpcRegistry and rpcBroker actors and will resume them in case of exception
More logs have been added along with some unit test cases of xmlutil

Change-Id: I30101bd3b8ac6821b58b3e1a2421f7f1af26bcd1
Signed-off-by: Harman Singh <>
8 years agoUpdating cluster RPC code making it work 60/9460/3
Harman Singh [Wed, 30 Jul 2014 02:03:08 +0000 (19:03 -0700)]
Updating cluster RPC code making it work

Added XMLUtils to serialize and deserialize instance identifier objects and the values insides path arguments with proper object type. This code use Yangtools existing utility, but modify that code to make sure
right type is picked up. We can think of adding it directly in yang tools also and remove it from here
Added Preconditions check for pojos

Change-Id: Ieb73b4ee660d2e058d0a62952799fc6f39d4c6b5
Signed-off-by: Harman Singh <>
8 years agoRemoving unused org.objectweb.asm from northbound.commons 49/9549/2
Madhu Venugopal [Thu, 31 Jul 2014 21:04:47 +0000 (14:04 -0700)]
Removing unused org.objectweb.asm from northbound.commons

Change-Id: Ie5789f1574ea5565be66a3a4dd007fa976a920f0
Signed-off-by: Madhu Venugopal <>
8 years agoAdd XSQL into default compilation 43/9443/4
Robert Varga [Tue, 29 Jul 2014 16:20:26 +0000 (18:20 +0200)]
Add XSQL into default compilation

This adds XSQL into the default build.

Change-Id: I484f14d2633af5fc1ddc3aeec269757a4dee0dd6
Signed-off-by: Robert Varga <>
8 years agoAdd replication capability to Shard 23/9523/5
Moiz Raja [Thu, 31 Jul 2014 09:02:55 +0000 (02:02 -0700)]
Add replication capability to Shard

This commit integrates the distributed data store with our Raft implementation.

Shard now extends RaftActor which provides it the replication capabilities required.

Other notable changes are,
- The FindPrimary algorithm has been changed to find the first replica for a shard.
  The shard then forwards requests to create a transaction or transaction chain to
  the leader
- Changed the package name for Raft internal messages from "internal" to "base" to be
  more BND tool friendly
- Fix some issues with Serialization of Raft messages
- Create a NoOpTransaction when no Primary can be found. The commit for this transaction
  will always fail. The NoOpTransaction returns absent for reads in all cases.
- Add PeerAddressResolution capability to Raft. What this basically does is given a static
  configuration where a shard has 'n' peers, you can pass the names of those peers
  to the shard and resolve their addresses at a later time. This allows the Shard to ensure
  consensus even in a situation where it is the first one to come up but it's peers are still
  not running

Change-Id: I3087deb5eb4418cd629a707ba14f43858db1f463
Signed-off-by: Moiz Raja <>
8 years agoMerge "broken build - missing implementation of method getAnyXmlNodeSerializer"
Moiz Raja [Thu, 31 Jul 2014 14:19:12 +0000 (14:19 +0000)]
Merge "broken build - missing implementation of method getAnyXmlNodeSerializer"

8 years agoBUG-868: Migrate to SchemaContextListener 39/5939/9
Robert Varga [Sun, 9 Mar 2014 18:34:51 +0000 (19:34 +0100)]
BUG-868: Migrate to SchemaContextListener

SchemaServiceListener is deprecated, SchemaContextListener is its new
name. The class hierarchy allows for incremental migration.

Change-Id: I15d495d805eb7a08c3bcd3ab0cf8b5a8d2797db5
Signed-off-by: Robert Varga <>
8 years agobroken build - missing implementation of method getAnyXmlNodeSerializer 34/9534/1
Jozef Gloncak [Thu, 31 Jul 2014 13:47:40 +0000 (15:47 +0200)]
broken build - missing implementation of method getAnyXmlNodeSerializer

Change-Id: Ib7f22015462cb224e11c3c267cfbac7627eeb800
Signed-off-by: Jozef Gloncak <>
8 years agoBUG-628 Allow configuration to override module based capabilities from remote netconf... 90/9490/2
Maros Marsalek [Wed, 30 Jul 2014 14:11:39 +0000 (16:11 +0200)]
BUG-628 Allow configuration to override module based capabilities from remote netconf device

Suitable for devices that do not provide module based capabilities in hello message (most likely do not support ietf-netconf-monitoring).
User can place yang files into cache/schema folder and set the capabilities for these modules into config attribute for netconf-connector.

Change-Id: I541ef08bb5c0328e293f9c732353282ffaf0474d
Signed-off-by: Maros Marsalek <>
8 years agoNotificator create stream name method don't remove trailing slash 56/9256/2
Jozef Gloncak [Wed, 23 Jul 2014 11:12:20 +0000 (13:12 +0200)]
Notificator create stream name method don't remove trailing slash

Change-Id: I512879ce1b39b80b29a167147ef73e2ecef64afa
Signed-off-by: Jozef Gloncak <>
8 years agoBUG-1228: Optimize AbstractForwardedDataBroker a bit 04/9504/1
Robert Varga [Wed, 30 Jul 2014 18:42:00 +0000 (20:42 +0200)]
BUG-1228: Optimize AbstractForwardedDataBroker a bit

Profiling OFP with datastore backend has revealed that we spend about 9%
of CPU in AbstractForwardedDataBroker$ This turns out to be
a comparator, which compares two YangInstanceIdentifiers by their path
length -- and to do that it iterates fully through both of them.

We perform three optimizations:
- make the comparator itself shareable, so we do not instantiate it
  (6000 during the profiling run)
- make the .sortedEntries() smart about empty maps
- teach the comparator to abort iteration as soon as the result is

At the same time we import YangInstanceIdentifier, making the code a bit
more readable.

Change-Id: I38d3629ab33dac9e2e29b092e3a89d0821d09b07
Signed-off-by: Robert Varga <>
8 years agoMerge "Make Raft messages serializable"
Ed Warnicke [Wed, 30 Jul 2014 16:08:50 +0000 (16:08 +0000)]
Merge "Make Raft messages serializable"

8 years agoCreated Sample Feature Test Class for Base Feature Repository 97/9397/2
Mathieu Lemay [Mon, 28 Jul 2014 19:13:34 +0000 (15:13 -0400)]
Created Sample Feature Test Class for Base Feature Repository

Change-Id: I9553bc264080abd013c9c9ef8c6a29356e2ac7fd
Signed-off-by: Mathieu Lemay <>
8 years agoMerge "Serialization/Deserialization and a host of other fixes"
Ed Warnicke [Wed, 30 Jul 2014 12:05:21 +0000 (12:05 +0000)]
Merge "Serialization/Deserialization and a host of other fixes"

8 years agoMerge "Fix the build errors due to the class change of InstanceIdentifier to YangInst...
Tony Tkacik [Wed, 30 Jul 2014 08:05:09 +0000 (08:05 +0000)]
Merge "Fix the build errors due to the class change of InstanceIdentifier to YangInstanceIdentifier"

8 years agoBUG-1416 clean up flow statistic models 93/9293/4
Michal Rehak [Thu, 24 Jul 2014 15:25:32 +0000 (17:25 +0200)]
BUG-1416 clean up flow statistic models

- duplicate flow model removed from statistics augment
- statistics notification processing adapted
- sal-binding-dom-it fixed

Change-Id: I7ad5bae45b47f5ea8ed918459fc83cbd839b0e3a
Signed-off-by: Michal Rehak <>
8 years agoMerge "Created Network Service Functions Features"
Madhu Venugopal [Wed, 30 Jul 2014 02:24:07 +0000 (02:24 +0000)]
Merge "Created Network Service Functions Features"

8 years agoMake Raft messages serializable 00/9300/8
Kamal Rameshan [Thu, 24 Jul 2014 20:21:52 +0000 (13:21 -0700)]
Make Raft messages serializable

- Make AppendEntries a protocol buffer message
- Create the Payload extension mechanism to be used for AppendEntries by extensions
  of RaftActors to define their custom Payloads
- Modified tests etc as appropriate

Change-Id: I2d5af41b7ca8ad7a8b94515ebc5adaa78803ad15
Signed-off-by: Kamal Rameshan <>
Signed-off-by: Moiz Raja <>
8 years agoSerialization/Deserialization and a host of other fixes 55/9455/2
Moiz Raja [Thu, 10 Jul 2014 10:39:22 +0000 (03:39 -0700)]
Serialization/Deserialization and a host of other fixes

- Hande Cluster MemberUp and MemberRemoved events in ShardManager

- Cohort messages and close listener messages switched
to use protobuff

- Distributed Datastore switch messages to use protobuff
CreateTransactionChainReply distributed datastore messages
switched to protobuff

- ShardManager messages switch to protobuff

- DataChanged and other messages switch to protobuf in
distributed datastore

- Fixed few things found during testing
1. ShardStrategy - setting of configuration
2. NodeToNormalizedNodeBuilder - leaf node/leafsetentry node checks
3. DataChanged event - passing of scope instanceidentifier used during deserialization

- Introducing JMX MBeans for distributed datastore

-Fixed issues which were preventing remote Shards from talking to each other

- Fixed a number of issues related to deserialization

- Add distributed datastore to the build

- Switch from InstanceIdentifier to YangInstanceIdentifier

Change-Id: I0d15dc482cb2b0fb2170b1344bad9fa3b421e8e0
Signed-off-by: Moiz Raja <>
8 years agoMerge "Fixed unneeded wrapping of guava for karaf"
Moiz Raja [Tue, 29 Jul 2014 21:56:13 +0000 (21:56 +0000)]
Merge "Fixed unneeded wrapping of guava for karaf"

8 years agoBug 1392: Change ReadTransaction#read to return CheckedFuture 78/9178/12
tpantelis [Mon, 14 Jul 2014 16:35:57 +0000 (12:35 -0400)]
Bug 1392: Change ReadTransaction#read to return CheckedFuture

Added a ReadFailedException that is used with the CheckedFuture.
Moved the RpcError list from TransactionCommitFailedException to a new base
OperationFailedException in yangtools and also derived ReadFailedException from

Added a static MAPPER in ReadFailedException class using the new generalized base
ExceptionMapper class in yangtools. Also derived
TransactionCommitFailedExceptionMapper from ExceptionMapper.

Modified uses of Futures#makeChecked in the read Tx and write Tx submit
to use the new MappingCheckedFuture class in yangtools (see for details).

Change-Id: I5c4f717f0b8664b7d39c1e6f0366525f04e6634d
Signed-off-by: tpantelis <>
8 years agoFix the build errors due to the class change of InstanceIdentifier to YangInstanceIde... 44/9444/1
Sharon Aicler [Tue, 29 Jul 2014 16:29:55 +0000 (09:29 -0700)]
Fix the build errors due to the class change of InstanceIdentifier to YangInstanceIdentifier

Change-Id: I208aee4e916230ef87053d17f02e5096fbbc8a1d
Signed-off-by: Sharon Aicler <>
8 years agoBUG-1092: adjust to YangInstanceIdentifier 28/9428/5
Robert Varga [Tue, 29 Jul 2014 10:15:49 +0000 (12:15 +0200)]
BUG-1092: adjust to YangInstanceIdentifier

This is a compation to I1e30a0df93d8bfb891d047c58abcb117d4006c76,
adjusting the components to use the new name.

Change-Id: I615763240581e850f7752f82e44d752c8fceb169
Signed-off-by: Robert Varga <>
8 years agoMerge "Modify the FindPrimary implementation so that it works correctly with a config...
Ed Warnicke [Tue, 29 Jul 2014 11:30:19 +0000 (11:30 +0000)]
Merge "Modify the FindPrimary implementation so that it works correctly with a configuration"

8 years agoMerge "Implementation of ModuleShardStrategy"
Ed Warnicke [Tue, 29 Jul 2014 11:30:00 +0000 (11:30 +0000)]
Merge "Implementation of ModuleShardStrategy"

8 years agoMerge changes I1d768b2b,I9302e88a
Tony Tkacik [Tue, 29 Jul 2014 10:48:46 +0000 (10:48 +0000)]
Merge changes I1d768b2b,I9302e88a

* changes:
  Fix identity-ref serialization in netconf.
  BUG-1083 Netconf connector rework sal facade.

8 years agoMerge changes Ifd28301d,I38220acb,I9bad24df
Tony Tkacik [Tue, 29 Jul 2014 09:29:39 +0000 (09:29 +0000)]
Merge changes Ifd28301d,I38220acb,I9bad24df

* changes:
  WIP: Backwards compatible MountPointService
  Fix children element lookup in XmlElement
  Fix config attributes with same names for different modules.

8 years agoMerge "BUG-1410 Fix config yang generator parsing dependency containers"
Tony Tkacik [Tue, 29 Jul 2014 09:28:17 +0000 (09:28 +0000)]
Merge "BUG-1410 Fix config yang generator parsing dependency containers"

8 years agoMerge changes I442a0ee9,I11825b90
Tony Tkacik [Tue, 29 Jul 2014 08:04:05 +0000 (08:04 +0000)]
Merge changes I442a0ee9,I11825b90

* changes:
  Fix a typo
  BUG-1281: call static methods

8 years agoBUG-1410 Fix config yang generator parsing dependency containers 23/9423/1
Maros Marsalek [Tue, 29 Jul 2014 07:58:10 +0000 (09:58 +0200)]
BUG-1410 Fix config yang generator parsing dependency containers

Check if the grouping used is of type service-ref.
Until now, any container containing grouping was considered a dependency.
Add test for this case.

Change-Id: I9299b2b39e393d940c71a41f8d33d737564f2530
Signed-off-by: Maros Marsalek <>
8 years agoFix identity-ref serialization in netconf. 71/9371/6
Maros Marsalek [Mon, 28 Jul 2014 08:33:33 +0000 (10:33 +0200)]
Fix identity-ref serialization in netconf.

Identity-ref attributes did not contain their namespace.

Change-Id: I1d768b2b59073d9fa322b66b002eddf39270bf17
Signed-off-by: Maros Marsalek <>
8 years agoWIP: Backwards compatible MountPointService 50/9150/19
Maros Marsalek [Fri, 18 Jul 2014 12:29:39 +0000 (14:29 +0200)]
WIP: Backwards compatible MountPointService

Change-Id: Ifd28301ddd08d4edba93dba04a4d38c2ee13078a
Signed-off-by: Maros Marsalek <>
8 years agoBUG-1083 Netconf connector rework sal facade. 34/9234/18
Maros Marsalek [Tue, 22 Jul 2014 13:02:25 +0000 (15:02 +0200)]
BUG-1083 Netconf connector rework sal facade.

Change-Id: I9302e88ac3e831e2966e2baec9493a03e0a96be4
Signed-off-by: Maros Marsalek <>
8 years agoFix children element lookup in XmlElement 11/9311/4
Maros Marsalek [Fri, 25 Jul 2014 11:13:47 +0000 (13:13 +0200)]
Fix children element lookup in XmlElement

Change-Id: I38220acbfedf8f1b8554516f6abda4c1a16dd2ee
Signed-off-by: Maros Marsalek <>
8 years agoFix config attributes with same names for different modules. 91/9291/9
Maros Marsalek [Thu, 24 Jul 2014 15:09:53 +0000 (17:09 +0200)]
Fix config attributes with same names for different modules.

Yang does not allow attributes in different cases to have the same name.
In yang modules for config, the configuration is located in cases and if 2 cases in same yang module contain child with same name, the transformation of data from CompositeNode to NormalizedNode

NOTE: This might break bgpcep and SP distribution, check.

Change-Id: I9bad24df9ac149da74b745ff648c72345e33deb1
Signed-off-by: Maros Marsalek <>
8 years agoMerge "Fix for -Pintegrationtest profile"
Moiz Raja [Tue, 29 Jul 2014 04:26:34 +0000 (04:26 +0000)]
Merge "Fix for -Pintegrationtest profile"

8 years agoFix for -Pintegrationtest profile 20/9420/1
Ed Warnicke [Tue, 29 Jul 2014 00:44:57 +0000 (19:44 -0500)]
Fix for -Pintegrationtest profile

The -Pintegrationtest profile was not including
the restconf config file.

Change-Id: Ic62da8f4532aeeda19a1836c08214fa795d84b98
Signed-off-by: Ed Warnicke <>
8 years agoModify the FindPrimary implementation so that it works correctly with a configuration 87/8887/6
Moiz Raja [Thu, 10 Jul 2014 03:18:14 +0000 (20:18 -0700)]
Modify the FindPrimary implementation so that it works correctly with a configuration

Change-Id: Ie41b688adf54de06332bbe5add7aba8107eb4264
Signed-off-by: Moiz Raja <>
8 years agoImplementation of ModuleShardStrategy 83/8883/7
Moiz Raja [Thu, 10 Jul 2014 02:03:54 +0000 (19:03 -0700)]
Implementation of ModuleShardStrategy

ModuleShardStrategy finds a shard based on a module name only. This will allow it partition a single
large DOM tree into multiple shards based on configuration

Change-Id: I6e287fc48a08da58d261e80b59419d4311164aa3
Signed-off-by: Moiz Raja <>
8 years agoInitial support for multiple-shards 82/8882/6
Moiz Raja [Wed, 9 Jul 2014 22:11:23 +0000 (15:11 -0700)]
Initial support for multiple-shards

Change-Id: Ic58d2dc9198b88c689143a9d85a612016b6bfa22
Signed-off-by: Moiz Raja <>
8 years agoChanged RegisterChangeListener and RegisterChangeListenerReply 71/8871/6
Basheeruddin Ahmed [Wed, 9 Jul 2014 19:41:38 +0000 (12:41 -0700)]
Changed RegisterChangeListener and RegisterChangeListenerReply
in distributed datastore to be based on protocol buffer

Change-Id: Ia1e427ca4d60336bb1cbf774c19fada4a1d0aed1
Signed-off-by: Basheeruddin Ahmed <>
8 years agoReadData and ReadDataReply protobuff messages 67/8867/6
Basheeruddin Ahmed [Wed, 9 Jul 2014 17:36:48 +0000 (10:36 -0700)]
ReadData and ReadDataReply protobuff messages
in distributed datastore
Signed-off-by: Basheeruddin Ahmed <>
Change-Id: Ia8353fc70d7af8589de855fee82ec79f06c7a36b
Signed-off-by: Basheeruddin Ahmed <>
8 years agoMake CompositeModification serializable using protocol buffers 34/8834/7
Moiz Raja [Wed, 9 Jul 2014 00:20:55 +0000 (17:20 -0700)]
Make CompositeModification serializable using protocol buffers

Change-Id: I3e91452b0244c6adec84c000e83d7f993b2a59b7
Signed-off-by: Moiz Raja <>
8 years agoSwitch to using protocol buffer serialization for the WriteData message 28/8828/7
Moiz Raja [Tue, 8 Jul 2014 21:57:48 +0000 (14:57 -0700)]
Switch to using protocol buffer serialization for the WriteData message

- This commit also fixes an issues with the NodeToNormalizedNodeBuilder where an empty container node was decode with a leaf node within
- MergeData and WriteData are passed in their serialized forms from the TransactionProxy as well

Change-Id: I22eab6059becd427a9f0fae1a9273c8c4e293ee5
Signed-off-by: Moiz Raja <>