controller.git
5 years agoMerge "Optimizations, Monitoring and Logging"
Ed Warnicke [Tue, 12 Aug 2014 23:09:32 +0000 (23:09 +0000)]
Merge "Optimizations, Monitoring and Logging"

5 years agoMerge "Fixed remove rpc api in rpc registry"
Moiz Raja [Tue, 12 Aug 2014 20:59:42 +0000 (20:59 +0000)]
Merge "Fixed remove rpc api in rpc registry"

5 years agoMerge "Working md-sal features, including restconf, toaster, flow-services"
Devin Avery [Tue, 12 Aug 2014 15:49:37 +0000 (15:49 +0000)]
Merge "Working md-sal features, including restconf, toaster, flow-services"

5 years agoMerge "Fix to topology-lldp-discovery to allow for clean karaf feature"
Devin Avery [Tue, 12 Aug 2014 15:49:19 +0000 (15:49 +0000)]
Merge "Fix to topology-lldp-discovery to allow for clean karaf feature"

5 years agoMerge "config-persister-feature-adapter to push configs from karaf features"
Devin Avery [Tue, 12 Aug 2014 15:48:31 +0000 (15:48 +0000)]
Merge "config-persister-feature-adapter to push configs from karaf features"

5 years agoMerge "Minor changes to config-persister to allow for karaf"
Devin Avery [Tue, 12 Aug 2014 15:48:07 +0000 (15:48 +0000)]
Merge "Minor changes to config-persister to allow for karaf"

5 years agoFixed remove rpc api in rpc registry 31/9831/6
Abhishek Kumar [Fri, 8 Aug 2014 21:42:06 +0000 (14:42 -0700)]
Fixed remove rpc api in rpc registry

Added tests

Change-Id: Ib5204f5226d11a1d8cdec7cf99809333bd1f1457
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
5 years agoMerge "Updated RpcRegistry to accept a list of route identifiers while adding or...
Moiz Raja [Tue, 12 Aug 2014 15:12:24 +0000 (15:12 +0000)]
Merge "Updated RpcRegistry to accept a list of route identifiers while adding or removing routes."

5 years agoOptimizations, Monitoring and Logging 25/9825/9
Moiz Raja [Fri, 8 Aug 2014 17:56:08 +0000 (10:56 -0700)]
Optimizations, Monitoring and Logging

- Made identifiers type-safe
- Changed logging so that most of it is done at debug level instead of info
- Make cluster logging configurable via logback.xml
- Add Bean for looking at the local shards on shard manager
- Add Preconditions in a places where it matters

Change-Id: Ie2b17e89bd88edde1366d0a4d23abf9fb97e6e55
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Missing capability in 10-rest-connector.xml file"
Moiz Raja [Tue, 12 Aug 2014 13:18:08 +0000 (13:18 +0000)]
Merge "Missing capability in 10-rest-connector.xml file"

5 years agoHandling ShardTransaction Failure Scenarios 81/9881/1
Basheeruddin Ahmed [Tue, 12 Aug 2014 06:31:45 +0000 (23:31 -0700)]
Handling ShardTransaction Failure Scenarios
and corresponding test cases

Note: Cohort failures handling is being worked on
and will be taken care in separate commit

Change-Id: I7ef165b9cb8c91088b4f20ae6c19418f92edb37c
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
5 years agoUpdated RpcRegistry to accept a list of route identifiers while 20/9820/5
Abhishek Kumar [Fri, 8 Aug 2014 18:51:37 +0000 (11:51 -0700)]
Updated RpcRegistry to accept a list of route identifiers while
adding or removing routes.

Removed few redundant defensive null checks.

Change-Id: I24310d2a3871a4bff2afa5a06b3657f4d2709794
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
5 years agoInclude lastCommittedTransactionTime in Shard JMX 50/9850/7
Basheeruddin Ahmed [Mon, 11 Aug 2014 06:43:50 +0000 (23:43 -0700)]
Include lastCommittedTransactionTime in Shard JMX
MBean
Changed the maximum-frame-size to a larger value

patch 2: rebased
patch 3: merge with other changes
patch 4: commit not returning if cohort was null, included failedTransactionsCount
patch 5/patch6: updated with review comments
patch 7: reformatted based on comment

Change-Id: I85218131dc8edb51f4c2c9fcbb34be79b547789c
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
5 years agoWorking md-sal features, including restconf, toaster, flow-services 48/9848/3
Ed Warnicke [Mon, 11 Aug 2014 04:56:11 +0000 (23:56 -0500)]
Working md-sal features, including restconf, toaster, flow-services

Note: DO NOT MERGE until
https://git.opendaylight.org/gerrit/9847 (yangtools)
is merged as it is needed for this change.

Change-Id: Iad975cfb63b62930465edcd9e415856873b5acde
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoFix to topology-lldp-discovery to allow for clean karaf feature 46/9846/3
Ed Warnicke [Mon, 11 Aug 2014 04:19:06 +0000 (23:19 -0500)]
Fix to topology-lldp-discovery to allow for clean karaf feature

Change-Id: Ife3388610a2d816f7bb8e5214cc98d123c4b604b
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoconfig-persister-feature-adapter to push configs from karaf features 45/9845/3
Ed Warnicke [Mon, 11 Aug 2014 03:01:08 +0000 (22:01 -0500)]
config-persister-feature-adapter to push configs from karaf features

Change-Id: I66063a44210d1a6d7804903f17bc8fc0b2995af8
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoMinor changes to config-persister to allow for karaf 44/9844/2
Ed Warnicke [Mon, 11 Aug 2014 02:43:06 +0000 (21:43 -0500)]
Minor changes to config-persister to allow for karaf

These minor changes expose a ConfigPusher service for use
by a config-persister-feature-adapter (to follow) that
can push configs attached to features.

Change-Id: I382d2ab578d19ea9c24afa521a9a5a047360fc50
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoMerge "Fix broken 05-clustering.xml"
Ed Warnicke [Mon, 11 Aug 2014 16:05:03 +0000 (16:05 +0000)]
Merge "Fix broken 05-clustering.xml"

5 years agoMerge " Expose more information about a Shard via JMX"
Ed Warnicke [Mon, 11 Aug 2014 16:04:41 +0000 (16:04 +0000)]
Merge " Expose more information about a Shard via JMX"

5 years agoMerge "Bug 1430: Off-load notifications from single commit thread"
Devin Avery [Mon, 11 Aug 2014 15:28:26 +0000 (15:28 +0000)]
Merge "Bug 1430: Off-load notifications from single commit thread"

5 years agoMerge "BUG 907 distinguish augmented nodes"
Devin Avery [Mon, 11 Aug 2014 14:05:57 +0000 (14:05 +0000)]
Merge "BUG 907 distinguish augmented nodes"

5 years agoMerge "BUG-1511: add FIXME markers"
Ed Warnicke [Mon, 11 Aug 2014 13:01:37 +0000 (13:01 +0000)]
Merge "BUG-1511: add FIXME markers"

5 years agoBUG 907 distinguish augmented nodes 14/9014/8
Jozef Gloncak [Tue, 15 Jul 2014 09:10:57 +0000 (11:10 +0200)]
BUG 907 distinguish augmented nodes

All nodes and their child contains also information about module from
which they comes from (module_name:node_name)

Change-Id: I7b146e820da1b5d3bdb62510a48e6845a78c80a2
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoMissing capability in 10-rest-connector.xml file 51/9851/2
Jozef Gloncak [Mon, 11 Aug 2014 09:33:06 +0000 (11:33 +0200)]
Missing capability in 10-rest-connector.xml file

This missing capability could probably cause problem and restconf isn't
started.

Change-Id: I6ea2dc6236948c7e77b9cddf7d015fcf4e5b7357
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoBUG 1162 - problem to post list data 84/9684/3
Jozef Gloncak [Tue, 5 Aug 2014 08:59:55 +0000 (10:59 +0200)]
BUG 1162 - problem to post list data

If last path arguments of instance identifier are list with keys then in
POST operation it is necessary to append it to instance identifier as
nodeWithKey.

This code was part of RestconfImpl but it was probably deleted
accidentaly.

Change-Id: I117cbcc39dcb97e8bc5ecc852ce2e9e7da7070cf
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
5 years agoFix broken 05-clustering.xml 24/9824/3
Moiz Raja [Fri, 8 Aug 2014 19:30:39 +0000 (12:30 -0700)]
Fix broken 05-clustering.xml

Change-Id: Id9a08202816836ab55ffb1510db66316b0ab74cb
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years ago Expose more information about a Shard via JMX 99/9799/4
Moiz Raja [Thu, 7 Aug 2014 19:13:49 +0000 (12:13 -0700)]
 Expose more information about a Shard via JMX

Change-Id: I4185cbf9d1399b90aa7b635bdbb4a82bce122a1a
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG-1511: add FIXME markers 34/9834/1
Robert Varga [Sat, 9 Aug 2014 10:38:17 +0000 (12:38 +0200)]
BUG-1511: add FIXME markers

Fixes a simple typo and drops marker FIXMEs for future implementation.

Change-Id: Ic4f67afd978f4bb43314d161afcfe1e56c831be6
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Fix usage of StringBuilder when getting parent path in PathUtils Making consta...
Moiz Raja [Sat, 9 Aug 2014 02:05:52 +0000 (02:05 +0000)]
Merge "Fix usage of StringBuilder when getting parent path in PathUtils Making constants final timing encode/decode in a test case"

5 years agoMerge "Neutron LBaaS v2.0 API support"
Madhu Venugopal [Fri, 8 Aug 2014 23:56:04 +0000 (23:56 +0000)]
Merge "Neutron LBaaS v2.0 API support"

5 years agoFix usage of StringBuilder when getting parent path 30/9830/1
Basheeruddin Ahmed [Fri, 8 Aug 2014 21:39:25 +0000 (14:39 -0700)]
Fix usage of StringBuilder when getting parent path
in PathUtils
Making constants final
timing encode/decode in a test case

Change-Id: Ia552163dfe35dcd268bd8a0620c6b34c910f47b2
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
5 years agoAdding SLF4J logging 63/9763/2
Abhishek Kumar [Wed, 6 Aug 2014 22:04:32 +0000 (15:04 -0700)]
Adding SLF4J logging

Change-Id: I0dbb80f947d44846dc0ee2b340e06aed94630490
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
5 years agoGossip based eventually consistent RPC Registry. 13/9713/12
Abhishek Kumar [Thu, 31 Jul 2014 21:18:28 +0000 (14:18 -0700)]
Gossip based eventually consistent RPC Registry.

There are 2 main components
1. Bucket Store:
   Stores data in buckets. Each cluster node gets a bucket. These buckets are sync'ed
   across nodes using Gossip protocol.
   Bucket Store uses a Gossiper that implements the protocol to sync data.

2. Rpc Registry:
   This uses the bucket store to store routing table. Routing table maintains mapping of
   RPC <--> Node
   Rpc Broker uses this regitry to route rpc requests to remote nodes.

Change-Id: Ifaf8955dbf6e3074d4d2951d6f503ecc0624d141
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
5 years agoMerge "Fix config-manager activator"
Tony Tkacik [Fri, 8 Aug 2014 10:07:24 +0000 (10:07 +0000)]
Merge "Fix config-manager activator"

5 years agoFix config-manager activator 05/9805/1
Maros Marsalek [Fri, 8 Aug 2014 08:49:10 +0000 (10:49 +0200)]
Fix config-manager activator

Change-Id: Ic81c28e100c0ec334f66376392c02d6fb6d7d01a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "BUG-1495: fail future when no local RPC is found"
Tony Tkacik [Fri, 8 Aug 2014 07:19:52 +0000 (07:19 +0000)]
Merge "BUG-1495: fail future when no local RPC is found"

5 years agoMerge "BUG-997 Consult QNames of yang modules with ietf-netconf-monitoring/netconf...
Tony Tkacik [Thu, 7 Aug 2014 20:20:24 +0000 (20:20 +0000)]
Merge "BUG-997 Consult QNames of yang modules with ietf-netconf-monitoring/netconf-state/schemas"

5 years agoMerge "BUG-1423 Fix distributed datastore error in config schemas(double case child)"
Tony Tkacik [Thu, 7 Aug 2014 20:19:36 +0000 (20:19 +0000)]
Merge "BUG-1423 Fix distributed datastore error in config schemas(double case child)"

5 years agoMerge "BUG-868: migrate ListenerRegistry"
Tony Tkacik [Thu, 7 Aug 2014 20:17:21 +0000 (20:17 +0000)]
Merge "BUG-868: migrate ListenerRegistry"

5 years agoMerge "Bug 1308 - Unable to publish NodeUpdated message via NotificationService"
Tony Tkacik [Thu, 7 Aug 2014 20:05:07 +0000 (20:05 +0000)]
Merge "Bug 1308 - Unable to publish NodeUpdated message via NotificationService"

5 years agoMerge "Migrate to junit 4.11"
Tony Tkacik [Thu, 7 Aug 2014 20:02:30 +0000 (20:02 +0000)]
Merge "Migrate to junit 4.11"

5 years agoMerge "BUG-1493: do not instantiate HashSet"
Tony Tkacik [Thu, 7 Aug 2014 19:57:53 +0000 (19:57 +0000)]
Merge "BUG-1493: do not instantiate HashSet"

5 years agoMigrate to junit 4.11 70/9670/6
Robert Varga [Mon, 4 Aug 2014 20:47:39 +0000 (22:47 +0200)]
Migrate to junit 4.11

Removes the version override and drags tests into 4.11. Also reverts
29ad7ba749eac80e6514b1ca37aa850c30649b55 for a proper fix.

Change-Id: I981163ee2c1d036ab04331eeba36f24a7e6f8002
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoExpose the Raft State of a Shard and the name of it's Leader via JMX 81/9781/3
Moiz Raja [Thu, 7 Aug 2014 11:22:17 +0000 (04:22 -0700)]
Expose the Raft State of a Shard and the name of it's Leader via JMX

Change-Id: Id8b57706902e93e0021db44533622fde283d82b4
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoTune replication and stabilize tests 41/9741/5
Moiz Raja [Wed, 6 Aug 2014 11:28:43 +0000 (04:28 -0700)]
Tune replication and stabilize tests

Made following changes for replication
- Increased Heartbeat timeout to 500 milliseconds.
- Send only one entry from the replicated log to the follower in append entries

Both of these tweaks have been made to prevent election timeouts and frequent switching of leaders

Changes to tests
- Added a duration when constructing an ExpectMsg. This prevents ExpectMsg from waiting forever when
  and expected event does not occur
- Removed all Thread.sleep from the tests and replace them with waiting for a specific LogEvent this is
  a more deterministic.

Change-Id: Ie9ce0c9c73bf1b170a78879b1e2dab76f1de64df
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoDo not encode/decode DataChange registrations and notifications 40/9740/4
Moiz Raja [Tue, 5 Aug 2014 19:48:37 +0000 (12:48 -0700)]
Do not encode/decode DataChange registrations and notifications

DataChange notifications are never sent over the wire so they do not need
to be proto-buf encoded/decoded

Change-Id: Ief591bb2a2a17039c9b3ae21379eea3d562f4d98
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoFixed issue where a shard for a defined module is not found 80/9680/8
Moiz Raja [Tue, 5 Aug 2014 01:07:13 +0000 (18:07 -0700)]
Fixed issue where a shard for a defined module is not found

Change-Id: I5f6c82ce39f900a55519ec04a739a83ccb834e59
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoInitial Configuration for Clustering 77/9677/9
Moiz Raja [Mon, 4 Aug 2014 22:44:35 +0000 (15:44 -0700)]
Initial Configuration for Clustering

To try out clustering do the following,

1. Rename configuration/initial/05-clustering.xml.conf to configuration/initial/05-clustering.xml
2. Run the controller with these options

    ./run.sh -XX:MaxPermSize=512m

Change-Id: I61ede6cc083ce5fc722c44f0c127f4a03e2869d0
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG-1495: fail future when no local RPC is found 83/9783/3
Robert Varga [Thu, 7 Aug 2014 12:15:45 +0000 (14:15 +0200)]
BUG-1495: fail future when no local RPC is found

Instead of checking state, we return a failed future, which will have a
RpcImplementationUnavailableException as its cause. The current call
site is the remote broker, which is the provider of last resort and it
throws it when it has no foreign system available.

Change-Id: Ib9d8534ca75e60f1867a7c275ee653a70dbd7a00
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-1493: do not instantiate HashSet 60/9760/5
Robert Varga [Wed, 6 Aug 2014 18:01:24 +0000 (20:01 +0200)]
BUG-1493: do not instantiate HashSet

This HashSet is used to track processed nodes -- but the parent node is
already giving us a method, which checks if it contains a particular
node ID. Let's use that instead of maintaining the set.

Based on traces, this should speed the datastore up by about 4.8%.

Change-Id: I09e1135f51c8967b9fe8c520a0e166918472de7d
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-997 Consult QNames of yang modules with ietf-netconf-monitoring/netconf-state... 84/9484/4
Maros Marsalek [Tue, 29 Jul 2014 15:06:44 +0000 (17:06 +0200)]
BUG-997 Consult QNames of yang modules with ietf-netconf-monitoring/netconf-state/schemas

Change-Id: Ie0fcb6d9ba44207cb14d31d51c1f3068983d514e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBUG-1423 Fix distributed datastore error in config schemas(double case child) 99/9699/3
Maros Marsalek [Tue, 5 Aug 2014 13:53:34 +0000 (15:53 +0200)]
BUG-1423 Fix distributed datastore error in config schemas(double case child)

Change-Id: I44c220c577f57354a6a1dfd38c08ec2a1a75f9ca
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Fix test coverage not being reported in Sonar"
Tony Tkacik [Thu, 7 Aug 2014 06:09:50 +0000 (06:09 +0000)]
Merge "Fix test coverage not being reported in Sonar"

5 years agoBug 1430: Off-load notifications from single commit thread 22/9422/12
tpantelis [Tue, 29 Jul 2014 10:42:14 +0000 (06:42 -0400)]
Bug 1430: Off-load notifications from single commit thread

Modified the InMemoryDOMDataStore to use the new
QueuedNotificationManager class added to yangtools common util for
DataChangeListener notifications.

Modified DOMDataCommitCoordinatorImpl's ListeningExecutorService to one
that off-loads ListenableFuture Runnable callbacks on a separate
executor.

Change-Id: I31f2fb002131c6d91b205d33255dd1bbc6433d9b
Signed-off-by: tpantelis <tpanteli@brocade.com>
5 years agoUtilize transaction type to create read-only or 64/9764/2
Basheeruddin Ahmed [Wed, 6 Aug 2014 22:38:35 +0000 (15:38 -0700)]
Utilize transaction type to create read-only or
write-only or read-write transaction instead of always
creating read-write transaction

patch 2: updated based on review comments

Change-Id: I36390ab348c5774cf4bf180ea1608fe04f75d073
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
6 years agoMerge "Created sal-clustering-commons and moved sal-protobuff-encoding files to sal...
Moiz Raja [Wed, 6 Aug 2014 22:49:44 +0000 (22:49 +0000)]
Merge "Created sal-clustering-commons and moved sal-protobuff-encoding files to sal-clustering-commons"

6 years agoMerge "Remove old dependencies"
Ed Warnicke [Wed, 6 Aug 2014 19:21:31 +0000 (19:21 +0000)]
Merge "Remove old dependencies"

6 years agoCreated sal-clustering-commons and moved 79/9679/6
Basheeruddin Ahmed [Tue, 5 Aug 2014 00:18:27 +0000 (17:18 -0700)]
Created sal-clustering-commons and moved
sal-protobuff-encoding files to sal-clustering-commons

updated sal-distributed-datastore pom with the above change

removed sal-clustering-commons as part of distribution as it is embedded currently as part of distributed-datastore

Note - after this is merged we need to move
 out the .proto from  akka-raft to sal-clustering-commons
and add dependency of sal-akka-raft on sal-clustering-commons
and embed the same
rebased
Change-Id: I7d4ac51628cef96ffb16acfcfd596dfd3129e0fa
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
6 years agoMerge "Bug 1386: Avoid commit deadlock"
Tony Tkacik [Wed, 6 Aug 2014 17:05:10 +0000 (17:05 +0000)]
Merge "Bug 1386: Avoid commit deadlock"

6 years agoFix test coverage not being reported in Sonar 33/9733/8
Robert Varga [Wed, 6 Aug 2014 05:45:21 +0000 (07:45 +0200)]
Fix test coverage not being reported in Sonar

Change-Id: Id8ff02a986b1bfdab01a481fcb11cef111757de9
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Optimilization the method datastoreNormalizedNodeToCompositeNode"
Tony Tkacik [Wed, 6 Aug 2014 15:52:19 +0000 (15:52 +0000)]
Merge "Optimilization the method datastoreNormalizedNodeToCompositeNode"

6 years agoMerge "A little extra protection against nulls in ConfigPusher"
Tony Tkacik [Wed, 6 Aug 2014 14:54:41 +0000 (14:54 +0000)]
Merge "A little extra protection against nulls in ConfigPusher"

6 years agoMerge changes If78d8143,Id8d04f24
Tony Tkacik [Wed, 6 Aug 2014 12:10:12 +0000 (12:10 +0000)]
Merge changes If78d8143,Id8d04f24

* changes:
  BUG-1281: eliminate thread-unsafe lookup
  BUG-1281: make methods static

6 years agoOptimilization the method datastoreNormalizedNodeToCompositeNode 42/9742/1
Jozef Gloncak [Wed, 6 Aug 2014 11:21:40 +0000 (13:21 +0200)]
Optimilization the method datastoreNormalizedNodeToCompositeNode

Origin method used schema context (which isn't necessary) and additionaly
doesn't cover all cases. + fixing of incorrect corresponding tests

Change-Id: Idbead2696de9102a202cad03c78f4a1a14a2d1d3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoMerge "Bug 1418 - onDataChange notification is not returning any data to the getCrea...
Tony Tkacik [Wed, 6 Aug 2014 09:25:10 +0000 (09:25 +0000)]
Merge "Bug 1418 - onDataChange notification is not returning any data to  the getCreatedData and getModifiedData function calls. Data change  notification does not seem to work."

6 years agoBug 1418 - onDataChange notification is not returning any data to 87/9687/4
Jan Hajnar [Tue, 5 Aug 2014 10:25:44 +0000 (12:25 +0200)]
Bug 1418 - onDataChange notification is not returning any data to
the getCreatedData and getModifiedData function calls. Data change
notification does not seem to work.

* Changed normalized to binding data change event translation call to
include event listener path. This path is then used to decode leaf or
mixin only augmentation because it can't be injected through children.
* Added verification tests.

Change-Id: Ia9d936f17b30b94fe4878e343cff7babb8d29d0f
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
6 years agoA little extra protection against nulls in ConfigPusher 29/9729/1
Ed Warnicke [Wed, 6 Aug 2014 04:24:02 +0000 (23:24 -0500)]
A little extra protection against nulls in ConfigPusher

Change-Id: I4aab592b028b8336370c23924fcbf69858b7a6bd
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoBug 1386: Avoid commit deadlock 10/9210/10
tpantelis [Mon, 14 Jul 2014 12:01:16 +0000 (08:01 -0400)]
Bug 1386: Avoid commit deadlock

Changed the executor in DOMDataCommitCoordinatorImpl to a new
class DeadlockDetectingListeningExecutorService added to yangtools util.
This detects deadlock if another blocking commit is done by a client
notified from the single commit thread.

Change-Id: Icdc2b835fd336a1bbc37953828126b57253929c0
Signed-off-by: tpantelis <tpanteli@brocade.com>
6 years agoBUG-1281: eliminate thread-unsafe lookup 28/9628/4
Robert Varga [Sun, 3 Aug 2014 13:39:11 +0000 (15:39 +0200)]
BUG-1281: eliminate thread-unsafe lookup

The URI/name lookup map was not safe when context was reloaded. Get rid
of it for now, as SchemaContext can maintain reasonably-fast lookups. At
the same time make sure we share codepaths as much as possible.

Change-Id: If78d8143e94446fe9b38da894611b1c8b61f57f3
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-1281: make methods static 04/9404/7
Robert Varga [Mon, 28 Jul 2014 20:02:40 +0000 (22:02 +0200)]
BUG-1281: make methods static

As it turns out ControllerContext has a few methods which do not touch
instance state -- make those static and fixup callers.

Change-Id: Id8d04f2426435528ee754f56b34f91d25a49d3ee
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove old dependencies 92/9692/3
Giovanni Meo [Mon, 4 Aug 2014 16:22:11 +0000 (18:22 +0200)]
Remove old dependencies

- Remove stale dependencies that prevent releasing of artifacts
- Remove unused flow-management-compatibility and
inventory-topology-compatibility modules
- Make sure that if a dependency is on module with a version defined
by a variable, lets specify the version in the dependency management
in common pom
- Replace in netconf-cli the reference from yang-data-json to
yang-data-composite-node because yang-data-json has been removed
- Removed whitespaces in config-netty-config that would cause
checkstyle issues downstream otherwise

Change-Id: I866e4b36e71c004b925bd181412ff4df91b3091f
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoBUG-868: migrate ListenerRegistry 82/9682/2
Robert Varga [Tue, 5 Aug 2014 07:16:49 +0000 (09:16 +0200)]
BUG-868: migrate ListenerRegistry

yangtools.concepts.util is being migrated to yangtools.util, so adjust
users to lower the number of warnings.

Change-Id: I652f0131a59fdb2481d779c181861f7ed7674b03
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMigrate to junit 4.11 - failing test 85/9685/2
Jozef Gloncak [Tue, 5 Aug 2014 10:49:11 +0000 (12:49 +0200)]
Migrate to junit 4.11 - failing test

Corrected test which caused problems in
https://git.opendaylight.org/gerrit/#/c/9670/

Change-Id: Ife89b83bbc1d2df4dc34327e5f27ed47509a8b48
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoMerge "Fix failing IT tests"
Tony Tkacik [Tue, 5 Aug 2014 15:18:02 +0000 (15:18 +0000)]
Merge "Fix failing IT tests"

6 years agoMerge "Adding remoterpc connector to distribution and Updating actor system creation"
Moiz Raja [Tue, 5 Aug 2014 14:54:59 +0000 (14:54 +0000)]
Merge "Adding remoterpc connector to distribution and Updating actor system creation"

6 years agoFix failing IT tests 83/9683/3
Maros Marsalek [Tue, 5 Aug 2014 08:54:23 +0000 (10:54 +0200)]
Fix failing IT tests

- Binding Test Helper did not spefied object-cache as dependency
  and it was already part of distribution
- API Doc plugin was using invalid YANG files for positive
  test scenario.

Change-Id: I06c174408df6073d887f5c307cf1b70c34c442b1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Fixed namespace of yang testing file."
Tony Tkacik [Tue, 5 Aug 2014 10:09:13 +0000 (10:09 +0000)]
Merge "Fixed namespace of yang testing file."

6 years agoMerge "Bug 1354: Fixed rpc request/result transformation."
Tony Tkacik [Tue, 5 Aug 2014 09:28:44 +0000 (09:28 +0000)]
Merge "Bug 1354: Fixed rpc request/result transformation."

6 years agoNeutron LBaaS v2.0 API support 45/9645/3
Brent Salisbury [Mon, 4 Aug 2014 10:43:35 +0000 (06:43 -0400)]
Neutron LBaaS v2.0 API support

Patch#2:
-Changed Pool Memebers to its own CRUD interface.

Patch#1
-Added LBaaS support per the v2.0 API Doc
http://docs.openstack.org/api/openstack-network/2.0/content/

-There are four root API members as defined by the API spec:
Load Balancer, LB Pools, LB Listeners and Health Monitors.

-Members are nested underneath LB Pools. The URL API path
is defined in the patch but needs to be wired into the binding.
That work wouldnt change the API just the implementation.

-The patch is getting huge so unloading for review. LBaaS
will have a lot of moving parts o0. The postman collection
for testing this is at:
[ovsdb.git] / resources / openstack
/ Neutron-v2.0-API-Examples.json.postman_collection

Change-Id: I6acb234e7f246a98c57a9cab97af405c028b708d
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
6 years agoAdding remoterpc connector to distribution and Updating actor system creation 99/9599/3
Harman Singh [Sat, 2 Aug 2014 01:35:58 +0000 (18:35 -0700)]
Adding remoterpc connector to distribution and Updating actor system creation

Actor system will be created with in bundle class loader now. This change has been made to avoid any conflict with other actor systems.
We faced one class cast exception earlier and this fixes that

Change-Id: Iad55e60ee950fdcff8698270445f0da31bc39c5e
Signed-off-by: Harman Singh <harmasin@cisco.com>
6 years agoFixed typo in restconf, which caused classcast in datastore. 61/9661/2
Tony Tkacik [Mon, 4 Aug 2014 17:46:39 +0000 (19:46 +0200)]
Fixed typo in restconf, which caused classcast in datastore.

Change-Id: I51eb1fc2e4056dc84feb3b720c3ee844ee4ffdea
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoDowngraded to hamcrest 1.1 to fix the build 76/9676/1
Ed Warnicke [Mon, 4 Aug 2014 22:14:23 +0000 (17:14 -0500)]
Downgraded to hamcrest 1.1 to fix the build

Change-Id: I5dc385ed61e8290eb81c50973417bd6ceb1c7508
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoMerge "BUG 1162 - ensure data for all path arguments in datastore."
Tony Tkacik [Mon, 4 Aug 2014 14:11:50 +0000 (14:11 +0000)]
Merge "BUG 1162 - ensure data for all path arguments in datastore."

6 years agoBUG 1162 - ensure data for all path arguments in datastore. 41/9641/3
Jozef Gloncak [Mon, 4 Aug 2014 06:28:14 +0000 (08:28 +0200)]
BUG 1162 - ensure data for all path arguments in datastore.

Fixes
1) It is possible to specify path to data (including lists with
keys) via unexisting nodes and store payload data to this path.
Missing nodes in datastore are created before storing payload data.
2) InstanceIdentifier is now correctly created via
DataNormalizer.toNormalized()

Change-Id: If795a930015fef39a0029e808355d51357e2d5d5
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoFixed namespace of yang testing file. 40/9640/1
Martin Vitez [Mon, 4 Aug 2014 09:57:12 +0000 (11:57 +0200)]
Fixed namespace of yang testing file.

This test used 2 different yang files with same namespace, which is incorrect and can cause test fail later.

Change-Id: I87a78e36d1d8812bb92f71c82722f87559907423
Signed-off-by: Martin Vitez <mvitez@cisco.com>
6 years agoBug 1354: Fixed rpc request/result transformation. 33/9233/3
Lukas Sedlak [Fri, 18 Jul 2014 09:40:23 +0000 (11:40 +0200)]
Bug 1354: Fixed rpc request/result transformation.

This commit is dependent on https://git.opendaylight.org/gerrit/9232 commit in Yangtools project.
Fixed proper data transformation in toRpcRequest method in NetconfMessageTransformer.
Now every rpc request (edit-config, get and get-config) will be transformed for given Schema Context.

Change-Id: I08da9200c0ba680b36a445978e7de748e94b654d
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
6 years agoReturn a NoOpTransactionContext when the Primary for a shard is not found 36/9636/1
Moiz Raja [Sun, 3 Aug 2014 19:23:16 +0000 (12:23 -0700)]
Return a NoOpTransactionContext when the Primary for a shard is not found

A NoOpTransactionContext is returned when a request to create a transaction
results in the primary not being found or when the request times out.

A CanCommit on the NoOpTransaction will always false. A read
will always return an empty result. The consumer will need to deal with this situation.

Change-Id: Id6f7d0688921acac718b9bb06fbf03d5e345d7ac
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoKeep DataChange registrations and notifications local 27/9627/2
Moiz Raja [Sun, 3 Aug 2014 13:36:13 +0000 (06:36 -0700)]
Keep DataChange registrations and notifications local

Here is how it works
--------------------
When a consumer registers for a datachange notification we first check if the Shard
to which this registration needs to be sent is local. If it is then we send the
registration to it. If it is not then we simply return a NoOpRegistration to the consumer.
This ensures that a DataChange registration stays local to a cluster member.

Now let's say we have 3 replicas and in all those replicas we do find a local shard for a
given module and we have 3 listener registrations. At this time we do not want all 3 members
to be notified of the change. We only want the node which is the Leader to notify it's listeners
of the change. To restrict that the DataChangeListener will only forward events to the listener
if the Shard sends it a message enabling notifications

Change-Id: I035bbdf34e2509047f4bcb475c443a761b08e68d
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoFix a couple of issues with replication 96/9596/4
Moiz Raja [Fri, 1 Aug 2014 23:14:05 +0000 (16:14 -0700)]
Fix a couple of issues with replication

- First the data that was being sent from the primary was not being deserialized on the followers
- The state on the followers was not being applied correctly
- Add sal-distributed-datastore to the distribution

Added a test for CompositeModificationPayload to ensure that serialization works correctly
Also added a set of integration test programs to test the serialization

Change-Id: Id67d2c4fe471003d9dd3b42a8376c90fd23492ce
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoBUG-1473: update model.util.InstanceIdentifier users 23/9623/4
Robert Varga [Sun, 3 Aug 2014 11:31:05 +0000 (13:31 +0200)]
BUG-1473: update model.util.InstanceIdentifier users

Companion patch to https://git.opendaylight.org/gerrit/9622, updates
users to use the new name. Also make the code a tiny bit more readable.

Fixed conversion to checked Future.

Change-Id: If8da3639e656214713d3680951cd9ae724c5ad6f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Bug 1392: Change ReadTransaction#read to return CheckedFuture"
Tony Tkacik [Sun, 3 Aug 2014 18:17:46 +0000 (18:17 +0000)]
Merge "Bug 1392: Change ReadTransaction#read to return CheckedFuture"

6 years agoMerge "BUG-1281: share filters between instances"
Tony Tkacik [Sun, 3 Aug 2014 18:14:29 +0000 (18:14 +0000)]
Merge "BUG-1281: share filters between instances"

6 years agoMerge "BUG-1281: use SchemaContext lookups"
Tony Tkacik [Sun, 3 Aug 2014 18:14:14 +0000 (18:14 +0000)]
Merge "BUG-1281: use SchemaContext lookups"

6 years agoMerge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"
Tony Tkacik [Sun, 3 Aug 2014 18:10:03 +0000 (18:10 +0000)]
Merge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"

6 years agoBUG-1281: share filters between instances 03/9403/4
Robert Varga [Mon, 28 Jul 2014 19:53:51 +0000 (21:53 +0200)]
BUG-1281: share filters between instances

The filters are invariants, so lets share them accross instances and not
instantiate them each time we need them.

Change-Id: Ib632efe758c22bd782fca0536c2fe7e9c6e831c3
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-1281: use SchemaContext lookups 02/9402/4
Robert Varga [Mon, 28 Jul 2014 19:45:12 +0000 (21:45 +0200)]
BUG-1281: use SchemaContext lookups

SchemaContext provides efficient module lookup services. Use those
instead of homegrown versions.

Change-Id: I4406438b137c8742a5265036f84a66d7f0f441c0
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoAdded test cases for each .proto file to ensure 95/9595/2
Basheeruddin Ahmed [Fri, 1 Aug 2014 23:06:18 +0000 (16:06 -0700)]
Added test cases for each .proto file to ensure
that test case fail in case incompatible version
of the protocol buffer is utilized.

New Patch: Updated with copyright header

Change-Id: Ib7fe9e212c6319f46202506d96544d149da28004
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
6 years agoMerge "OS Neutron FWaaS api/jaxrs and associated bindings"
Madhu Venugopal [Sun, 3 Aug 2014 06:41:19 +0000 (06:41 +0000)]
Merge "OS Neutron FWaaS api/jaxrs and associated bindings"

6 years agoOS Neutron FWaaS api/jaxrs and associated bindings 26/9526/3
Brent Salisbury [Thu, 31 Jul 2014 11:01:53 +0000 (07:01 -0400)]
OS Neutron FWaaS api/jaxrs and associated bindings

Patch#2:
-Removed and cleaned up some comments.
-Fixed null check on Firewall Rules

Patch#1:
The Neutron v2.0 API document can be viewed at:
http://docs.openstack.org/api/openstack-network/2.0/content/

Sample API calls that can be imported into Postman
are located in the OVSDB directory at:
Directory: [ovsdb] / resources / openstack /
File: Neutron-v2.0-API-Examples.json.postman_collection

Change-Id: If37a0dd702aa02db9e94811c9a414718d25f42a7
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
6 years agoMerge "Created Sample Feature Test Class for Base Feature Repository"
Madhu Venugopal [Sat, 2 Aug 2014 08:34:32 +0000 (08:34 +0000)]
Merge "Created Sample Feature Test Class for Base Feature Repository"

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.