7 years agoMerge "Add generic arguments"
Moiz Raja [Fri, 10 Apr 2015 16:08:56 +0000 (16:08 +0000)]
Merge "Add generic arguments"

7 years agoMerge "Update lispflowmapping options in"
Moiz Raja [Fri, 10 Apr 2015 15:29:20 +0000 (15:29 +0000)]
Merge "Update lispflowmapping options in"

7 years agoMerge "Fixes Bug 2935"
Moiz Raja [Fri, 10 Apr 2015 15:28:23 +0000 (15:28 +0000)]
Merge "Fixes Bug 2935"

7 years agoMerge changes I114cbac1,I45c2e7cd
Moiz Raja [Fri, 10 Apr 2015 15:21:28 +0000 (15:21 +0000)]
Merge changes I114cbac1,I45c2e7cd

* changes:
  Calculate replicated log data size on recovery
  Refactor snapshot message processing to RaftActorSnapshotMessageSupport

7 years agoMerge "Verify BatchedModifications messages sent vs received"
Moiz Raja [Fri, 10 Apr 2015 15:20:04 +0000 (15:20 +0000)]
Merge "Verify BatchedModifications messages sent vs received"

7 years agoMerge "Use BatchedModifications message in place of ReadyTransaction message"
Moiz Raja [Fri, 10 Apr 2015 15:19:30 +0000 (15:19 +0000)]
Merge "Use BatchedModifications message in place of ReadyTransaction message"

7 years agoVerify BatchedModifications messages sent vs received 91/17891/5
Tom Pantelis [Wed, 8 Apr 2015 03:48:14 +0000 (23:48 -0400)]
Verify BatchedModifications messages sent vs received

A previous patch removed the verification of the response
Futures for BatchedModifications messages sent in
TransactionContextImpl. This was used to verify all modifications
were successfully received and processed by the transaction actor.

In lieu of that, this patch adds a totalMessagesSent field to
BatchedModifications and the transaction actor verifies it matches
the total number of messages received and successfully processed.

Change-Id: I247d3a09794142813cdca67b63d77412261a282b
Signed-off-by: Tom Pantelis <>
7 years agoUse BatchedModifications message in place of ReadyTransaction message 84/17884/5
Tom Pantelis [Tue, 7 Apr 2015 23:54:51 +0000 (19:54 -0400)]
Use BatchedModifications message in place of ReadyTransaction message

For the optimized write transactions (currently disabled), we used the
last BatchedModifications message with the ready flag set to elide
sending the ReadyTransaction message. We can do this in general for both
read-write and write-only.

In ShardWriteTransaction, if the BatchedModifications indicates ready,
it simply calls readyTransaction to send ForwardedReadyTransaction
message to the shard, same as with the ReadyTransacton message.

Instead of returning a BatchedModificationsReply with the cohort path,
I kept the ReadyTransactionReply so the Shard code mostly remains the
same - otherwise we'd have to introduce an equivalent
batched ForwardedReadyTransaction message.

I also made ReadyTransactionReply Externalizable so we don't have to
deal with sending it serialized or not (except for backwards
compatibility - had to keep the protobuff class).

TransactionContextImpl#readyTransaction is now the same as
WriteTransactionContextImpl#readyTransaction so
WriteTransactionContextImpl is no longer needed and was removed.

Change-Id: I5175c77ca08a1877af9593a28e7c4cb46f03287a
Signed-off-by: Tom Pantelis <>
7 years agoMerge "Refactor raft recovery code to a RaftActorRecoverySupport class"
Moiz Raja [Fri, 10 Apr 2015 13:04:08 +0000 (13:04 +0000)]
Merge "Refactor raft recovery code to a RaftActorRecoverySupport class"

7 years agoMerge "Remove recorded modification Futures from TransactionContext"
Moiz Raja [Fri, 10 Apr 2015 12:10:23 +0000 (12:10 +0000)]
Merge "Remove recorded modification Futures from TransactionContext"

7 years agoMerge "BUG 1848 : Use OrderedNormalizedNodeWriter in rpc transformation."
Tony Tkacik [Fri, 10 Apr 2015 09:59:33 +0000 (09:59 +0000)]
Merge "BUG 1848 : Use OrderedNormalizedNodeWriter in rpc transformation."

7 years agoMerge "BUG-1848 : OrderedNormalizedNodeWriter implementation"
Tony Tkacik [Fri, 10 Apr 2015 09:56:01 +0000 (09:56 +0000)]
Merge "BUG-1848 : OrderedNormalizedNodeWriter implementation"

7 years agoMerge "BUG-2953 : Unable to read from datastore root with clustering enabled"
Tom Pantelis [Fri, 10 Apr 2015 01:46:38 +0000 (01:46 +0000)]
Merge "BUG-2953 : Unable to read from datastore root with clustering enabled"

7 years agoUpdate lispflowmapping options in 21/17021/2
Lorand Jakab [Mon, 23 Mar 2015 19:40:51 +0000 (21:40 +0200)]
Update lispflowmapping options in

One property changed default and a new property was added, see

Change-Id: Icf91d2ddcc63ee13d2e23ad9a5673ca1bc1efb93
Signed-off-by: Lorand Jakab <>
7 years agoBUG-2953 : Unable to read from datastore root with clustering enabled 50/18050/2
Moiz Raja [Thu, 9 Apr 2015 17:53:55 +0000 (10:53 -0700)]
BUG-2953 : Unable to read from datastore root with clustering enabled

This patch adds a NormalizedNodeAggregator which makes it possible to read
from the root of the datastore tree.

Writing, merging and checking for the existence of the root path is not
supported yet but we could in a future patches if needed.

Change-Id: I892bdc733ec316f41926d8bbccdbbdc6c31a5c25
Signed-off-by: Moiz Raja <>
7 years agoBUG 1848 : Use OrderedNormalizedNodeWriter in rpc transformation. 98/17998/2
Tomas Cere [Wed, 8 Apr 2015 13:25:30 +0000 (15:25 +0200)]
BUG 1848 : Use OrderedNormalizedNodeWriter in rpc transformation.

Makes the rpc processing in netconf northbound and sal-netconf-connector use
the new ordered writer.

Change-Id: I1367ba07069fa5b6525358f265fe664d00d71500
Signed-off-by: Tomas Cere <>
7 years agoBUG-1848 : OrderedNormalizedNodeWriter implementation 97/17997/2
Tomas Cere [Wed, 8 Apr 2015 08:50:33 +0000 (10:50 +0200)]
BUG-1848 : OrderedNormalizedNodeWriter implementation

Writes nodes in the order defined in yang files.

Change-Id: I72b2a867ad47b2c9de0444a8a0a2f279a8360021
Signed-off-by: Tomas Cere <>
7 years agoRemove recorded modification Futures from TransactionContext 77/17777/3
Tom Pantelis [Fri, 3 Apr 2015 09:39:56 +0000 (05:39 -0400)]
Remove recorded modification Futures from TransactionContext

This removes the recorded batched modification message Futures
from TransactionContext to avoid the overhead of waiting for
the Futures to complete on ready and transforming them. The
Futures were recorded to ensure all modification messages
were successfully processed before committing the transaction
but we can do that by including the count of modification
messages sent in the ready message for the transaction actor
to verify (later patch).

Change-Id: I8d6ad80cac3e8e13fde48fbf5c57a476cca003dd
Signed-off-by: Tom Pantelis <>
7 years agoBUG-2967: Expose before-state from DataObjectModification 00/18000/1
Robert Varga [Thu, 9 Apr 2015 09:32:48 +0000 (11:32 +0200)]
BUG-2967: Expose before-state from DataObjectModification

Not exposing the before-state requires users to track this state
themselves. The problem is most visible in the delete case, if
the user needs some attributes to reconstruct keys to other structures
in order to perform cleanup -- they would effectively have to retain
a InstanceIdentifier->data map to efficiently perform deletes.

Rather than forcing everyone to duplicate data, expose the before-state,
as best available. Note that applications still need to deal with the
fact that the before-state in delete can be null -- at least by issuing
a warning to the operator.

Change-Id: I72c886f384254a6808159eaee612b07083073492
Signed-off-by: Robert Varga <>
7 years agoFix DataTreeIdentifier losing type 99/17999/1
Robert Varga [Thu, 9 Apr 2015 09:16:49 +0000 (11:16 +0200)]
Fix DataTreeIdentifier losing type

DataTreeIdentifier needs to retain the type of encapsulated
InstanceIdentifier, otherwise the users cannot really use it (or have to
suppress warnings/cast).

Change-Id: Icc7214923531f9ffeafe55b12a8ad6813d431573
Signed-off-by: Robert Varga <>
7 years agoRemove non-existant features-flow from dependencies 78/17978/1
Thanh Ha [Thu, 9 Apr 2015 01:38:03 +0000 (21:38 -0400)]
Remove non-existant features-flow from dependencies

Change-Id: I9018abd2e4c185cdfed92b5c7040360cf03cb394
Signed-off-by: Thanh Ha <>
7 years agoMerge "BUG 2799: SPI for EventSources"
Tony Tkacik [Wed, 8 Apr 2015 19:04:09 +0000 (19:04 +0000)]
Merge "BUG 2799: SPI for EventSources"

7 years agoAdd generic arguments 54/17254/3
Robert Varga [Fri, 27 Mar 2015 17:31:02 +0000 (18:31 +0100)]
Add generic arguments

This patch silences a few eclipse warnings about use of generic types
without proper arguments.

Change-Id: Ia260593e7b5b5fa4cb49894752a286c47aa7c049
Signed-off-by: Robert Varga <>
7 years agoMerge "Fixed NPE when RuntimeRpc could not find module in schemaContext."
Tony Tkacik [Wed, 8 Apr 2015 09:10:09 +0000 (09:10 +0000)]
Merge "Fixed NPE when RuntimeRpc could not find module in schemaContext."

7 years agoMerge "BUG 2889 : migration of netconf-cli to NormalizedNode api's"
Tony Tkacik [Wed, 8 Apr 2015 09:09:47 +0000 (09:09 +0000)]
Merge "BUG 2889 : migration of netconf-cli to NormalizedNode api's"

7 years agoMerge "Add DOMDataTreeIdentifier.toString()"
Tony Tkacik [Wed, 8 Apr 2015 09:06:14 +0000 (09:06 +0000)]
Merge "Add DOMDataTreeIdentifier.toString()"

7 years agoCalculate replicated log data size on recovery 09/17309/2
Tom Pantelis [Sat, 28 Mar 2015 14:23:40 +0000 (10:23 -0400)]
Calculate replicated log data size on recovery

We maintain the replicated log data size at runtme but we should also
calculate the data size for recovered entries on startup.

I changed the AbstractReplicatedLogImpl#append method to also add to the
dataSize. Previously dataSize was adjusted in ReplicatedLogImpl#appendAndPersist
after it was persisted. I'm not sure why it was done this way but if
persistence failed then the entry would've been added to the in-memory
log without increasing the dataSize. This seems inconsistent - if we add
to the log we should always increase the dataSize.

The same with removing entries from the log - ReplicatedLogImpl re-calculated
the dataSize after it was persisted. So I changed removeFrom to adjust
dataSize and changed ReplicatedLogImpl#removeFromAndPersist to call
AbstractReplicatedLogImpl#removeFrom (code was duplicated).

To avoid out-of-band changes to dataSize I made it private. Same with
journal. I think this is safer - these should be owned by
AbstractReplicatedLogImpl and derived classes shouldn't modify these

Change-Id: I114cbac1d6a450bc0a1c8c6ee60042ad28a89bf4
Signed-off-by: Tom Pantelis <>
7 years agoRefactor snapshot message processing to RaftActorSnapshotMessageSupport 66/17266/4
Tom Pantelis [Thu, 26 Mar 2015 18:07:48 +0000 (14:07 -0400)]
Refactor snapshot message processing to RaftActorSnapshotMessageSupport

Refactored the snapshot message handling to a new class
RaftActorSnapshotMessageSupport.  To handle the callbacks to the
RaftActor, the RaftAciorRecoverySupport takes a RaftActorSnapshotCohort interface.
The abstract on* methods in RaftActor are now defined in the
RaftActorSnapshotCohort interface. The derived RaftActor class
implements an abstract method to return a RaftActorSnapshotCohort

Shard returns an instance of a new class ShardSnapshotCohort. For
createSnapshot, it needs to create a Shard transaction actor so I
refactored out a ShardTransactionActorFactory from Shard which is
also used for transaction create messages.

The ShardTransaction constructor previously took a SchemaContext is no
longer used. Rather than storing the SchemaContext in
ShardTransactionActorFactory and keeoing it up to date, I removed
SchemaContext from ShardTransaction which cascaded changes down to the
derived actor classes and unit tests.

Change-Id: I45c2e7cd31b07fec10585b8e5e0495b96842d37c
Signed-off-by: Tom Pantelis <>
7 years agoRefactor raft recovery code to a RaftActorRecoverySupport class 47/17247/6
Tom Pantelis [Thu, 26 Mar 2015 10:23:07 +0000 (06:23 -0400)]
Refactor raft recovery code to a RaftActorRecoverySupport class

Moved the RaftActor recovery message handling to a new class
RaftActorRecoverySupport. To handle the callbacks to the RaftActor,
the RaftActorRecoverySupport takes a RaftActorRecoveryCohort interface.
The abstract on* methods in RaftActor are now defined in the
RaftActorRecoveryCohort interface. The derived RaftActor class
implements an abstract method to return a RaftActorRecoveryCohort
instance. Shard returns a ShardRecoveryCoordinator instance (modified to
implement RaftActorRecoveryCohort).

Change-Id: I07a068aad277b6f677d7703c4e10686efe0cf0cc
Signed-off-by: Tom Pantelis <>
7 years agoMerge "Bug 2933: BidningDOMDataBrokerAdaper implements DataTreeChangeService"
Tom Pantelis [Tue, 7 Apr 2015 18:17:20 +0000 (18:17 +0000)]
Merge "Bug 2933: BidningDOMDataBrokerAdaper implements DataTreeChangeService"

7 years agoMerge "Bug 2933: Make DataTreeModification and Listeners type-safe"
Tom Pantelis [Tue, 7 Apr 2015 18:16:32 +0000 (18:16 +0000)]
Merge "Bug 2933: Make DataTreeModification and Listeners type-safe"

7 years agoMerge "Bug 2933: Implemented DataTreeChangeService"
Tom Pantelis [Tue, 7 Apr 2015 18:15:31 +0000 (18:15 +0000)]
Merge "Bug 2933: Implemented  DataTreeChangeService"

7 years agoMerge "Make TransactionProxyCleanupPhantomReference self-contained"
Tom Pantelis [Tue, 7 Apr 2015 16:06:12 +0000 (16:06 +0000)]
Merge "Make TransactionProxyCleanupPhantomReference self-contained"

7 years agoMerge "CDS: introduce AbstractThreePhaseCommitCohort"
Tom Pantelis [Tue, 7 Apr 2015 16:05:00 +0000 (16:05 +0000)]
Merge "CDS: introduce AbstractThreePhaseCommitCohort"

7 years agoMerge "CDS: fix TransactionProxy close()/ready() interaction"
Tom Pantelis [Tue, 7 Apr 2015 16:01:49 +0000 (16:01 +0000)]
Merge "CDS: fix TransactionProxy close()/ready() interaction"

7 years agoMerge "Bug 2942: odl-mdsal-apidocs feature is not protected through AAA"
Tom Pantelis [Tue, 7 Apr 2015 14:01:54 +0000 (14:01 +0000)]
Merge "Bug 2942: odl-mdsal-apidocs feature is not protected through AAA"

7 years agoMake TransactionProxyCleanupPhantomReference self-contained 33/17533/18
Robert Varga [Wed, 1 Apr 2015 11:27:25 +0000 (13:27 +0200)]
Make TransactionProxyCleanupPhantomReference self-contained

This tracker can be broken out cleanly, if we clean up interactions with
TransactionProxy and TransactionFutureCallback. That allows us to split
the class out, making it self-contained. Leaking fields from
TransactionProxy will be fixed up in a follow-up patch.

Change-Id: I14dbb44a2c94e758ad492222eaa9d038f5b6b858
Signed-off-by: Robert Varga <>
7 years agoCDS: introduce AbstractThreePhaseCommitCohort 18/17618/8
Robert Varga [Thu, 2 Apr 2015 10:52:08 +0000 (12:52 +0200)]
CDS: introduce AbstractThreePhaseCommitCohort

This is a rework of ChainedTransactionProxy/TransactionProxy
interactions. Rather than invoking a callback from TransactionProxy to
ChainedTransactionProxy, wrap the ready() call in
ChainedTransactionProxy and extract the required information from the
returned cohort object. Also make sure we preallocate the cohort future

Change-Id: I539ffb085800e4d62f1eab5bc8dae284e73c6aab
Signed-off-by: Robert Varga <>
7 years agoCDS: fix TransactionProxy close()/ready() interaction 12/17612/6
Robert Varga [Thu, 2 Apr 2015 09:58:48 +0000 (11:58 +0200)]
CDS: fix TransactionProxy close()/ready() interaction

TransactionProxy is vulnerable to wrong use of close() after ready().
Fix this up so we detect this condition and make it explicit what
happens when.

Change-Id: Id966b57ce53cdc92bc3e53cb0d38b77303ba1c54
Signed-off-by: Robert Varga <>
7 years agoFixed NPE when RuntimeRpc could not find module in schemaContext. 40/17840/1
Tomas Cere [Tue, 7 Apr 2015 13:15:58 +0000 (15:15 +0200)]
Fixed NPE when RuntimeRpc could not find module in schemaContext.

Change-Id: I40c72d413f23753e95fd5f0bb42cc78046a6494f
Signed-off-by: Tomas Cere <>
7 years agoBug 2933: BidningDOMDataBrokerAdaper implements DataTreeChangeService 28/17528/4
Tony Tkacik [Wed, 1 Apr 2015 10:52:45 +0000 (12:52 +0200)]
Bug 2933: BidningDOMDataBrokerAdaper implements DataTreeChangeService

Change-Id: Ia28d8452a6c203c88c7d1e18208362cf779a7b20
Signed-off-by: Tony Tkacik <>
7 years agoBug 2933: Make DataTreeModification and Listeners type-safe 27/17527/4
Tony Tkacik [Wed, 1 Apr 2015 10:50:57 +0000 (12:50 +0200)]
Bug 2933: Make DataTreeModification and Listeners type-safe

Introduced generic to DataTreeModification, DataTreeChangeListener
and DataTreeIdentifier which captures target type from InstanceIdentifier
so users does not have to deal with casts by themselves.

Added utility walker methods to DataObjectModification, which
are possible thanks to DataTreeModification capturing target type.

Change-Id: Ia3566ae3dbe98fb118b49cc8ac8e1925fc111d8b
Signed-off-by: Tony Tkacik <>
7 years agoBug 2933: Implemented DataTreeChangeService 26/17526/4
Tony Tkacik [Wed, 1 Apr 2015 10:37:52 +0000 (12:37 +0200)]
Bug 2933: Implemented  DataTreeChangeService

DataTreeChangeService implementation is based on DOM Data Tree
change service and serves only as an adapter, which lazily
translates events and data in events as they are accessed
by user code.

This is rather different behaviour from DataChangeListener
where API contract required semi-eager deserialization
of supplied instance identifier.

Change-Id: If4954e966acc21ffec36e8cc37f95717492a1675
Signed-off-by: Tony Tkacik <>
7 years agoMerge "Refactor ReplicatedLogImpl to separate class"
Moiz Raja [Tue, 7 Apr 2015 02:17:34 +0000 (02:17 +0000)]
Merge "Refactor ReplicatedLogImpl to separate class"

7 years agoMerge "Bug 2588: Fix read transaction failures"
Moiz Raja [Tue, 7 Apr 2015 01:51:30 +0000 (01:51 +0000)]
Merge "Bug 2588: Fix read transaction failures"

7 years agoMerge "Fix bug bug 2651 - XSQL does not pickup augmentation data "
Moiz Raja [Tue, 7 Apr 2015 01:48:15 +0000 (01:48 +0000)]
Merge "Fix bug  bug 2651 - XSQL does not pickup augmentation data "

7 years agoBug 2903: Turning on clustering by default 13/14313/10
Ed Warnicke [Tue, 3 Mar 2015 17:04:47 +0000 (09:04 -0800)]
Bug 2903: Turning on clustering by default

See Weather event:

Change-Id: I36b64d7eb657641bacfe2fd6e53a595baf2ad4a0
Signed-off-by: Ed Warnicke <>
7 years agoFix bug bug 2651 - XSQL does not pickup augmentation data 47/16847/5
Sharon Aicler [Thu, 19 Mar 2015 17:51:59 +0000 (10:51 -0700)]
Fix bug  bug 2651 - XSQL does not pickup augmentation data

Change-Id: I350de6ccf5efd8e427c5823a0f03c91e0df33f19
Signed-off-by: Sharon Aicler <>
7 years agoBug 2942: odl-mdsal-apidocs feature is not protected through AAA 09/17709/2
Ryan Goulding [Fri, 3 Apr 2015 14:44:59 +0000 (10:44 -0400)]
Bug 2942: odl-mdsal-apidocs feature is not protected through AAA

This change enforces AAA on the URL endpoints supported by odl-mdsal-apidocs.
The security model prohibits any access to the controller without
authentication.  This change mandates AAA for odl-mdsal-apidocs URLs.

Change-Id: I74226e702568077d769353d5fe49fe21cd187266
Signed-off-by: Ryan Goulding <>
7 years agoAdd DOMDataTreeIdentifier.toString() 53/17453/2
Robert Varga [Tue, 31 Mar 2015 14:10:33 +0000 (16:10 +0200)]
Add DOMDataTreeIdentifier.toString()

A proper toString() method is needed for debugging.

Change-Id: Iab13a38f6134aafa982fa5a9127fc5ccdd179416
Signed-off-by: Robert Varga <>
7 years agoMerge "Remove SimpleDataTreeCandidate"
Tony Tkacik [Thu, 2 Apr 2015 20:46:28 +0000 (20:46 +0000)]
Merge "Remove SimpleDataTreeCandidate"

7 years agoFixes Bug 2935 81/17581/3
Abhishek Kumar [Wed, 1 Apr 2015 19:01:08 +0000 (12:01 -0700)]
Fixes Bug 2935

Details for the issue is documented here:

This patch updates mapException implementation to
appropriately handle exceptions.

Change-Id: I104ea62453517e2c6a74955f6b3cce342274a9e5
Signed-off-by: Abhishek Kumar <>
7 years agoBug 2588: Fix read transaction failures 82/17682/1
Tom Pantelis [Thu, 2 Apr 2015 19:45:30 +0000 (15:45 -0400)]
Bug 2588: Fix read transaction failures

TransactionContextImpl#read now sends the ReadData message immediately
instead of waiting for the previous modification operation Futures to
complete. This ensures the read will be performed by the actor before
the transaction is readied. Also did the same for dataExists.

Change-Id: I9c56b32162a957e27f9ff01485686e90ebec77a7
Signed-off-by: Tom Pantelis <>
7 years agoBUG 2799: SPI for EventSources 01/16401/9
Marian Adamjak [Thu, 26 Mar 2015 11:07:33 +0000 (12:07 +0100)]
BUG 2799: SPI for EventSources

Introduced SPI for Event Sources

 - created separate messagebus-spi module
 - moved Netconf Event Source implementation
   to separate package

Change-Id: I13d55f803a80c655c71137414265041d99b11aa0
Signed-off-by: Marian Adamjak <>
7 years agoMerge "Split out ChainedTransactionProxy"
Tom Pantelis [Thu, 2 Apr 2015 11:33:59 +0000 (11:33 +0000)]
Merge "Split out ChainedTransactionProxy"

7 years agoMerge "Split out NoOpDOMStoreThreePhaseCommitCohort"
Tom Pantelis [Thu, 2 Apr 2015 11:33:08 +0000 (11:33 +0000)]
Merge "Split out NoOpDOMStoreThreePhaseCommitCohort"

7 years agoMerge "Speed up class check"
Tom Pantelis [Thu, 2 Apr 2015 11:32:05 +0000 (11:32 +0000)]
Merge "Speed up class check"

7 years agoMerge "Speed up enumeration lookups"
Tom Pantelis [Thu, 2 Apr 2015 11:30:14 +0000 (11:30 +0000)]
Merge "Speed up enumeration lookups"

7 years agoMerge "Add ForwardingDOMStoreThreePhaseCommitCohort"
Tom Pantelis [Thu, 2 Apr 2015 11:26:41 +0000 (11:26 +0000)]
Merge "Add ForwardingDOMStoreThreePhaseCommitCohort"

7 years agoSplit out ChainedTransactionProxy 30/17530/10
Robert Varga [Wed, 1 Apr 2015 10:47:27 +0000 (12:47 +0200)]
Split out ChainedTransactionProxy

Rather than having it as a inner class, move it into its own file,
increasing clarity.

Change-Id: I83d667db353cc01a950ac24da7ee68fc66ceb46d
Signed-off-by: Robert Varga <>
7 years agoSplit out NoOpDOMStoreThreePhaseCommitCohort 29/17529/10
Robert Varga [Wed, 1 Apr 2015 10:41:39 +0000 (12:41 +0200)]
Split out NoOpDOMStoreThreePhaseCommitCohort

This is an independent class, which has a single instance.

Change-Id: Icc16b6a9b83e5820e9031a2f73666142abe26256
Signed-off-by: Robert Varga <>
7 years agoSpeed up class check 36/17536/7
Robert Varga [Wed, 1 Apr 2015 11:55:04 +0000 (13:55 +0200)]
Speed up class check

Class.equals() returns the same, but calling it on a constant very
obvious to JIT that it can inline things.

Change-Id: I9e13a4b55ec194f51c8a39302433e22194a44b64
Signed-off-by: Robert Varga <>
7 years agoSpeed up enumeration lookups 31/17531/8
Robert Varga [Wed, 1 Apr 2015 11:17:56 +0000 (13:17 +0200)]
Speed up enumeration lookups

All enumeration types have a static values() method, which returns an
array of possible values. Use that instead of cascading ifs to get the
appropriate enum value.

Change-Id: Ic91cd04ac3e64e7d8263e6535e354f7ef2d713cf
Signed-off-by: Robert Varga <>
7 years agoUse isEmpty() instead of size() == 0 05/17605/3
Robert Varga [Thu, 2 Apr 2015 09:03:00 +0000 (11:03 +0200)]
Use isEmpty() instead of size() == 0

isEmpty() is a simpler check and a bit more explicit.

Change-Id: I336acfba64da299d00ccff5abcd850058c85c9e0
Signed-off-by: Robert Varga <>
7 years agoSplit out TransactionOperation 04/17604/2
Robert Varga [Thu, 2 Apr 2015 09:11:44 +0000 (11:11 +0200)]
Split out TransactionOperation

This splits the interface out and makes it an abstract class for faster
method dispatch.

Change-Id: Idcdd0f0edcf184abc54b4c3b44cf82d289abe7a7
Signed-off-by: Robert Varga <>
7 years agoFix AbstractTransactionContext field visibility 37/17537/8
Robert Varga [Wed, 1 Apr 2015 12:43:04 +0000 (14:43 +0200)]
Fix AbstractTransactionContext field visibility

Make fields final and add proper lifecycle, so we do not have to leak
the collection to potential mutators.

Change-Id: Ia7c793475c41d3aadf928804f78c39dda2a6b1ef
Signed-off-by: Robert Varga <>
7 years agoMake sure to pull trie library 85/17585/1
Robert Varga [Wed, 1 Apr 2015 21:32:02 +0000 (23:32 +0200)]
Make sure to pull trie library

This library is no longer embedded in yangtools, so we need to pull it

Change-Id: I1a6daeae653508f0b177b6ec70e3f7b23c6748ec
Signed-off-by: Robert Varga <>
7 years agoAdd ForwardingDOMStoreThreePhaseCommitCohort 25/17525/2
Robert Varga [Wed, 1 Apr 2015 10:16:27 +0000 (12:16 +0200)]
Add ForwardingDOMStoreThreePhaseCommitCohort

This class is useful for decorator pattern, so publish it as a beta SPI.

Change-Id: I69707067da4935d68ca41ed7ad1764d5ddf9812e
Signed-off-by: Robert Varga <>
7 years agoMove AbstractDOMStoreTransaction into SPI 24/17524/1
Robert Varga [Wed, 1 Apr 2015 09:56:55 +0000 (11:56 +0200)]
Move AbstractDOMStoreTransaction into SPI

It is a useful base for DOMStoreTransaction implementations, with some
debugging capabilities. Publish it as a beta SPI.

Change-Id: Iea3551720b2a8df7c268ce003147fc3a734f3871
Signed-off-by: Robert Varga <>
7 years agoRemove SimpleDataTreeCandidate 08/17408/1
Robert Varga [Tue, 31 Mar 2015 09:12:53 +0000 (11:12 +0200)]
Remove SimpleDataTreeCandidate

yangtools already exposes a utility class which does the same thing, so
let's use DefaultDataTreeCandidate instead.

Change-Id: Id8a6d6c0a5b817e4c3f5cdbb3bfdadcd596c0030
Signed-off-by: Robert Varga <>
7 years agoMerge "Adjust Tx rate limiter for unused transactions"
Moiz Raja [Mon, 30 Mar 2015 23:13:25 +0000 (23:13 +0000)]
Merge "Adjust Tx rate limiter for unused transactions"

7 years agoMerge "Export BindingNormalizedNodeSerializer via Config Subsystem."
Ed Warnicke [Mon, 30 Mar 2015 17:39:42 +0000 (17:39 +0000)]
Merge "Export BindingNormalizedNodeSerializer via Config Subsystem."

7 years agoMerge changes I34538a22,I520b0d83
Moiz Raja [Mon, 30 Mar 2015 17:13:38 +0000 (17:13 +0000)]
Merge changes I34538a22,I520b0d83

* changes:
  Refactor ElectionTermImpl into separate class
  Refactor DataPersistenceProviders and RaftActor#persistence

7 years agoMerge "Increase unit test coverage in SnapshotManager"
Moiz Raja [Mon, 30 Mar 2015 16:37:41 +0000 (16:37 +0000)]
Merge "Increase unit test coverage in SnapshotManager"

7 years agoExport BindingNormalizedNodeSerializer via Config Subsystem. 54/17354/1
Tony Tkacik [Mon, 30 Mar 2015 14:51:19 +0000 (16:51 +0200)]
Export BindingNormalizedNodeSerializer via Config Subsystem.

Change-Id: I2cabdc89b01739ef2ffdbedeff9b11038e0fa41f
Signed-off-by: Tony Tkacik <>
7 years agoIncrease unit test coverage in SnapshotManager 24/17324/2
Tom Pantelis [Sun, 29 Mar 2015 01:35:43 +0000 (21:35 -0400)]
Increase unit test coverage in SnapshotManager

Added more unit test cases to SnapshotManager and added more assertions
to existing tests.

Change-Id: I35446caa38eb25393a592583e8e3218b53b30e6c
Signed-off-by: Tom Pantelis <>
7 years agoMerge "BUG 2743 - Added support for runtime RPC's to netconf mdsal northbound."
Tony Tkacik [Mon, 30 Mar 2015 08:27:43 +0000 (08:27 +0000)]
Merge "BUG 2743 - Added support for runtime RPC's to netconf mdsal northbound."

7 years agoMerge "Avoid IllegalArgument on missing source"
Tony Tkacik [Mon, 30 Mar 2015 08:27:31 +0000 (08:27 +0000)]
Merge "Avoid IllegalArgument on missing source"

7 years agoMerge "Increase default negotiation timeout for netconf server to 30s"
Tony Tkacik [Mon, 30 Mar 2015 08:25:17 +0000 (08:25 +0000)]
Merge "Increase default negotiation timeout for netconf server to 30s"

7 years agoMerge "Set unable-to-connect(netconf node) if no sources are available"
Tony Tkacik [Mon, 30 Mar 2015 08:22:19 +0000 (08:22 +0000)]
Merge "Set unable-to-connect(netconf node) if no sources are available"

7 years agoMerge "BUG-1567 Expose sources for submodules in netconf"
Tony Tkacik [Mon, 30 Mar 2015 08:20:45 +0000 (08:20 +0000)]
Merge "BUG-1567 Expose sources for submodules in netconf"

7 years agoMerge "BUG-2877: Allow hello message with no namespace"
Tony Tkacik [Mon, 30 Mar 2015 08:19:46 +0000 (08:19 +0000)]
Merge "BUG-2877: Allow hello message with no namespace"

7 years agoRefactor ReplicatedLogImpl to separate class 11/17211/6
Tom Pantelis [Thu, 26 Mar 2015 05:25:11 +0000 (01:25 -0400)]
Refactor ReplicatedLogImpl to separate class

To reduce the size of the RaftActor class for improved readability.

Change-Id: I845cfeb4bc48f0c5eb96ba2cc0a925d9ce5fa416
Signed-off-by: Tom Pantelis <>
7 years agoMake LeaderLocalDelegateFactory a bit more useful 27/17227/9
Robert Varga [Fri, 27 Mar 2015 11:35:37 +0000 (12:35 +0100)]
Make LeaderLocalDelegateFactory a bit more useful

It seems that the two isntantiations use functionality which can be
easily abstracted out, simplifying code.

Change-Id: Id5e7cb71055ef14b2139be2ba74e29f9cd10da60
Signed-off-by: Robert Varga <>
7 years agoMerge "CDS: Move DataChangeListener into a support class"
Tom Pantelis [Tue, 31 Mar 2015 17:33:14 +0000 (17:33 +0000)]
Merge "CDS: Move DataChangeListener into a support class"

7 years agoMerge "BUG-2673: make CDS implement DOMDataTreeChangeListener"
Tom Pantelis [Tue, 31 Mar 2015 17:27:52 +0000 (17:27 +0000)]
Merge "BUG-2673: make CDS implement DOMDataTreeChangeListener"

7 years agoCDS: Move DataChangeListener into a support class 26/17226/8
Robert Varga [Fri, 27 Mar 2015 11:10:04 +0000 (12:10 +0100)]
CDS: Move DataChangeListener into a support class

This patch follows up the pattern set by DataTreeChangeListener and
moves the related code out.

Change-Id: Ib945dc308c2264f21c0a7df8152c1f9f8f908a43
Signed-off-by: Robert Varga <>
7 years agoBUG-2673: make CDS implement DOMDataTreeChangeListener 90/16690/25
Robert Varga [Tue, 17 Mar 2015 10:18:53 +0000 (11:18 +0100)]
BUG-2673: make CDS implement DOMDataTreeChangeListener

This patch adds the base support for registering
DOMDataTreeChangeListeners. These are delivered only on the local node,
as efficient serialization requires interaction with the cluster
topology and shard leadership handoff. That functionality will be
delivered in a follow-up patch.

It also introduces a bit common infrastructure to be used by
DataChangeListener code, as it performs a very similar function.

Change-Id: Ifb91d08857684fb160fd923bc25c294d2fca4bc3
Signed-off-by: Robert Varga <>
7 years agoMerge "Tune NotificationRouter wait strategy"
Tony Tkacik [Tue, 31 Mar 2015 08:01:00 +0000 (08:01 +0000)]
Merge "Tune NotificationRouter wait strategy"

7 years agoTune NotificationRouter wait strategy 47/17347/1
Robert Varga [Mon, 30 Mar 2015 13:59:54 +0000 (15:59 +0200)]
Tune NotificationRouter wait strategy

CPU traces show we are seeing NotificationRouter spin for more work even
when there are no notifications being generated. Change the strategy so
we end up block the thread after a period of spinning/yielding. The
default spin period is set to 1ms, followed by 30ms of yielding,
followed by a block.

This should provide reasonable throughput on notification-heavy
workloads as well as not waste a lot of CPU when there are no

Change-Id: Ia1de5ff2616392609a0868b9b8ba3bce15baa105
Signed-off-by: Robert Varga <>
7 years agoAdjust Tx rate limiter for unused transactions 82/17182/4
Tom Pantelis [Wed, 25 Mar 2015 19:25:48 +0000 (15:25 -0400)]
Adjust Tx rate limiter for unused transactions

I have a test that submits an arbitrary number of config transactions
and I noticed it can take an unusually long time depending on the
initial Tx rate limit setting. With the default setting of 100 it was
very slow even though I could see the adjusted limit increasing where
the elapsed time should've been much shorter.

It turns out the config datastore rate limit wasn't issue. When a
front-end Tx is created, a Tx instance is created in each data store.
The operation Tx's were unused but they artificially limited the config
rate since the operational rate wasn't getting updated, ie it stayed at

I made changes to adjust the rate limit for unused Tx's if there have
been no prior "real" Tx's for that data store. In this case, the
percentile metrics will be 0 so I basically adjust to the current rate
from the other data store. I think this makes sense if we have no other
data to go by.

This required some infa changes so the ActorContext could get access to
the metrics timer for the other data store. Mainly, we need a global
MericsRegistry and JmxReporter across both data stores. I reused the
MetricsReporter class for this to get the static instance (with changes to
support multiple MetricsReporters per domain name). I also added
a static method to get all the data store names.

I found it useful to see the current rate limit via JMX so I added a new
DatastoreInfoMXBean to report it.

Change-Id: I09def94e40a1fe57779e76763e48696140f3a125
Signed-off-by: Tom Pantelis <>
7 years agoMerge "Add dependency on config file to startup archetype"
Tony Tkacik [Fri, 27 Mar 2015 14:48:34 +0000 (14:48 +0000)]
Merge "Add dependency on config file to startup archetype"

7 years agoBUG 2889 : migration of netconf-cli to NormalizedNode api's 33/17233/1
Tomas Cere [Mon, 23 Mar 2015 16:13:47 +0000 (17:13 +0100)]
BUG 2889 : migration of netconf-cli to NormalizedNode api's

Change-Id: I5311a5c37ed5b5be214ab9aa4e7328df3470fde1
Signed-off-by: Tomas Cere <>
7 years agoMerge "BUG 2792 : ThreePhaseCommitCohortProxy should serialize CanCommit"
Tom Pantelis [Fri, 27 Mar 2015 12:56:43 +0000 (12:56 +0000)]
Merge "BUG 2792 : ThreePhaseCommitCohortProxy should serialize CanCommit"

7 years agoMerge "BUG 2773 : Transition Shard to Leader state when it has no peers"
Tom Pantelis [Fri, 27 Mar 2015 12:52:22 +0000 (12:52 +0000)]
Merge "BUG 2773 : Transition Shard to Leader state when it has no peers"

7 years agoAdd dependency on config file to startup archetype 16/17116/2
Ed Warnicke [Wed, 25 Mar 2015 16:02:14 +0000 (12:02 -0400)]
Add dependency on config file to startup archetype

Change-Id: Ie41e8c47826789b53811c6a92279abaec510d3b9
Signed-off-by: Ed Warnicke <>
7 years agoMerge "BUG-2424 Bump mina sshd-core version to 0.14"
Tony Tkacik [Fri, 27 Mar 2015 12:40:28 +0000 (12:40 +0000)]
Merge "BUG-2424 Bump mina sshd-core version to 0.14"

7 years agoMerge "BUG 2584 : Datastore is ready when all local shards have a leader"
Tom Pantelis [Fri, 27 Mar 2015 12:05:08 +0000 (12:05 +0000)]
Merge "BUG 2584 : Datastore is ready when all local shards have a leader"

7 years agoBUG-1567 Expose sources for submodules in netconf 23/17223/1
Maros Marsalek [Fri, 27 Mar 2015 10:24:54 +0000 (11:24 +0100)]
BUG-1567 Expose sources for submodules in netconf

Yang submodules were not exposed by netconf monitoring in netconf server (for
both config and mdsal servers).

Change-Id: I7adfa5ccf20199a8b8310286ef5194af8545b2e8
Signed-off-by: Maros Marsalek <>
7 years agoMerge "Make FollowerLogInformationImpl fields non-volatile"
Moiz Raja [Fri, 27 Mar 2015 10:17:33 +0000 (10:17 +0000)]
Merge "Make FollowerLogInformationImpl fields non-volatile"