controller.git
6 years agoMerge "524 bug - %2F slashes translation behind mount point (unit test)"
Tony Tkacik [Tue, 8 Apr 2014 09:44:35 +0000 (09:44 +0000)]
Merge "524 bug - %2F slashes translation behind mount point (unit test)"

6 years agoMerge "BUG-672 Make Xml directory adapter skip initial config files with invalid...
Tony Tkacik [Tue, 8 Apr 2014 09:39:35 +0000 (09:39 +0000)]
Merge "BUG-672 Make Xml directory adapter skip initial config files with invalid xml."

6 years agoMerge changes I6029bd48,Ie8eb4152
Tony Tkacik [Tue, 8 Apr 2014 09:39:15 +0000 (09:39 +0000)]
Merge changes I6029bd48,Ie8eb4152

* changes:
  BUG-672 Add includeExtensions property to Xml directory persister adapter.
  BUG-672 Remove deprecated plaintext/autodetect persister adapters.

6 years agoMerge "bug - missing excaping of % character in String.format() method"
Tony Tkacik [Tue, 8 Apr 2014 09:38:45 +0000 (09:38 +0000)]
Merge "bug - missing excaping of % character in String.format() method"

6 years agoMerge "Fix bug 666 - Neutron Subnet Creation Error"
Madhu Venugopal [Mon, 7 Apr 2014 22:38:36 +0000 (22:38 +0000)]
Merge "Fix bug 666 - Neutron Subnet Creation Error"

6 years agoBUG-672 Make Xml directory adapter skip initial config files with invalid xml. 44/5944/1
Maros Marsalek [Mon, 7 Apr 2014 15:28:36 +0000 (17:28 +0200)]
BUG-672 Make Xml directory adapter skip initial config files with invalid xml.

Issue a warning and continue to next file.

Change-Id: I1950eddc80b958f5887458ebeaa53b590506c31c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBUG-672 Add includeExtensions property to Xml directory persister adapter. 42/5942/1
Maros Marsalek [Mon, 7 Apr 2014 12:48:15 +0000 (14:48 +0200)]
BUG-672 Add includeExtensions property to Xml directory persister adapter.

This property allows to filter initial config files by extension.
Property supports multiple extensions separated by ','.
This property is optional, and if not present, all files are picked up regardless of their extension.

Change-Id: I6029bd48fa3b576006a4409d8f19e0c4956de036
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBUG-672 Remove deprecated plaintext/autodetect persister adapters. 41/5941/1
Maros Marsalek [Mon, 7 Apr 2014 11:04:39 +0000 (13:04 +0200)]
BUG-672 Remove deprecated plaintext/autodetect persister adapters.

Xml adapters are the default adapters now for configuration persister.

Change-Id: Ie8eb41520671bb00503a340f6b4b55ebe1ef7bf1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "BUG-509: make sure datastore commits are visible"
Tony Tkacik [Mon, 7 Apr 2014 09:04:13 +0000 (09:04 +0000)]
Merge "BUG-509: make sure datastore commits are visible"

6 years agoMerge "Edges are left in TopologyManager database when nodes disconnect"
Giovanni Meo [Mon, 7 Apr 2014 08:06:17 +0000 (08:06 +0000)]
Merge "Edges are left in TopologyManager database when nodes disconnect"

6 years agobug - missing excaping of % character in String.format() method 32/5932/1
Jozef Gloncak [Mon, 7 Apr 2014 06:27:19 +0000 (08:27 +0200)]
bug - missing excaping of % character in String.format() method

Change-Id: Ic44ff0cf558efbba9c465ac760da13fcf3add2cb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoFix bug 666 - Neutron Subnet Creation Error 30/5930/1
Dave Tucker [Sun, 6 Apr 2014 16:48:33 +0000 (17:48 +0100)]
Fix bug 666 - Neutron Subnet Creation Error

When a neutron subnet is created on the Northbound API, containing the
new "ipv6_address_mode" or "ipv6_ra_mode" fields with "null" values
Jersey will fail to deserialise the object correctly and throw an HTTP
500 error with a NullPointerException.

This commit adds the above fields to the NeutronSubnet object and
permits these fields to be nillable.

Change-Id: I225581b57a1698a5e5c17f91b117fba556b70976
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
6 years agoBUG-509: make sure datastore commits are visible 13/5913/2
Robert Varga [Fri, 4 Apr 2014 17:50:57 +0000 (19:50 +0200)]
BUG-509: make sure datastore commits are visible

This wraps the datastore root in an AtomicReference, which makes sure
started transactions see the latest published commit. This will make
the datastore handling more robust under tight conditions.

Also uncovers the fact that we are invoking user code under lock, which
we fix by reusing the executor used by the commit machinery.

Finally it uncovers thread-unsafe listener list manipuation. This will
need to be addressed in a follow-up patch.

Change-Id: Ic7efd266ef680701c1f0944ee675122d8527568b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: internal cleanup 12/5912/2
Robert Varga [Fri, 4 Apr 2014 17:14:57 +0000 (19:14 +0200)]
BUG-509: internal cleanup

Spell-check internal class and make it static
Make sure we don't have null name in contructor
Make sure we don't have null executor in constructor
getIdentifier() should be final

Change-Id: Ib8ebe82106d953581738bccbe1d4b878f9520b5b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoEdges are left in TopologyManager database when nodes disconnect 19/5919/1
Maurice Qureshi [Sat, 5 Apr 2014 03:17:22 +0000 (20:17 -0700)]
Edges are left in TopologyManager database when nodes disconnect

When nodes are disconnected from ODL Controller, some edges are left
in TopologyManager's database. As a result GUI (and possibly REST APIs0
still shows some switches to be connected even when there are no
switches connected to the controller.

Change-Id: Ia4a5ae0160b07ba0207bf763dbc234e34dcf5816
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
6 years agoBug 510: Updated initial configuration to easily enable new datastore 79/5879/11
Robert Varga [Fri, 4 Apr 2014 13:25:41 +0000 (15:25 +0200)]
Bug 510: Updated initial configuration to easily enable new datastore

In order to enable new in-memory datastore (and to wire it with clients)
initial configuration of md-sal (01-md-sal.xml) needs to be updated
to unwire old services and wire new one to the actual MD-SAL brokers.

This could be done by commenting out all DATA-BROKER sections
and uncommenting NEW-DATA-BROKER sections.

Change-Id: I072a65785593b82ec4b1ff6e3dae4c0af7497659
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Bug 510: Implementation of Forwarded Binding Data Broker"
Ed Warnicke [Fri, 4 Apr 2014 17:05:09 +0000 (17:05 +0000)]
Merge "Bug 510: Implementation of Forwarded Binding Data Broker"

6 years agoMerge "Resolve Bug:654 - Fix config-persister exception handling."
Ed Warnicke [Fri, 4 Apr 2014 16:41:22 +0000 (16:41 +0000)]
Merge "Resolve Bug:654 - Fix config-persister exception handling."

6 years agoBug 510: Implementation of Forwarded Binding Data Broker 24/5624/23
Robert Varga [Fri, 28 Mar 2014 21:23:07 +0000 (22:23 +0100)]
Bug 510: Implementation of Forwarded Binding Data Broker

Initial implementation of Forwarded Binding Data Broker
and Forwarded Backwards Compatible Data Broker,
which provides access to new data broker via original
API.

Added sample configuration which enables new
DOM Data Broker, In-memory Data Broker and
ForwardedCompatibleDataBroker.

Change-Id: I3569da20a9873edf352a54622be7a01fd329aa9b
Signed-off-by: Moiz Raja <moraja@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoResolve Bug:654 - Fix config-persister exception handling. 05/5905/3
Tomas Olvecky [Fri, 4 Apr 2014 10:29:19 +0000 (12:29 +0200)]
Resolve Bug:654 - Fix config-persister exception handling.

Modify NetconfUtil to fail on any <rpc-error>, not detecting transaction conflicts. Move
exception handling to ConfigPusher.
Also fix bug when config-netconf-connector detects discrepancy between yang store and
config manager factories: persister will retry as if some capabilities were not found.

Change-Id: Ibd80fd3859031ae41301481dad9b50f74207e64c
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBug 499: Fixed normalization of InstanceIdentifier for backwards compatibility 49/5849/4
Robert Varga [Wed, 26 Mar 2014 18:29:13 +0000 (19:29 +0100)]
Bug 499: Fixed normalization of InstanceIdentifier for backwards compatibility

Change-Id: I633eb004729c6013df49c3f82420adf6d2417ea9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 499: Improved data change listener tree management 48/5848/3
Robert Varga [Fri, 21 Mar 2014 12:30:45 +0000 (13:30 +0100)]
Bug 499: Improved data change listener tree management

Change-Id: I62843c3c4df32dd5a5849511d41352fa6822550b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agofix for BUG 663 - causing derived IT to fail 04/5904/1
Michal Rehak [Fri, 4 Apr 2014 10:44:38 +0000 (12:44 +0200)]
fix for BUG 663 - causing derived IT to fail

- added version to netty-config-api test dependency

Change-Id: I6653522e447283f28d5d89884427473973eb508b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
6 years agoAdd Flood and FloodAll supported actions 98/5898/1
Andrew Kim [Thu, 3 Apr 2014 22:42:35 +0000 (17:42 -0500)]
Add Flood and FloodAll supported actions

This patch will return Flood and FloodAll as supported actions when a switch is queried for its supported flow actions

Change-Id: I8c4b8821bd773e3eb654f35a60a9f41e08deadb6
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoMerge changes I6bc37e88,I0514b26e
Ed Warnicke [Wed, 2 Apr 2014 23:28:41 +0000 (23:28 +0000)]
Merge changes I6bc37e88,I0514b26e

* changes:
  Fixed missing keys in sal-compatibility flows.
  Bug 508: Fixed concurrent conflicting commits by InventoryManager.

6 years agoAdded a comment that briefly describes the ArpHander service and explains some design... 62/5862/2
Michael Bredel [Wed, 2 Apr 2014 09:26:59 +0000 (11:26 +0200)]
Added a comment that briefly describes the ArpHander service and explains some design decisions.

Change-Id: I2dd3877e5a12ad59f4c5057de09ecab2b4e9f768
Signed-off-by: Michael Bredel <michael.bredel@cern.ch>
6 years ago524 bug - %2F slashes translation behind mount point (unit test) 63/5863/1
Jozef Gloncak [Wed, 2 Apr 2014 09:43:31 +0000 (11:43 +0200)]
524 bug - %2F slashes translation behind mount point (unit test)

New test getDataWithSlashesBehindMountPoint() tests whether URI identifier
which contains slashes encoded as %2F (e.g. in key part of URI) is translated to identifier with simple slash
characters (/).

It is checked whether InstanceIdentifier instance is created with simple
slashes. The instance is then used as input parameter of method
BrokerFacade.readOperationalDataBehindMountPoint() to get data from
datastore.

If %2F are correctly replaced with / test is succesful.

Change-Id: I131bda42fb568af23d6a1b0bbb72c505db8748e3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoMerge "BUG-467: reconnect-strategy configuration moved into controller/commons/protoc...
Tony Tkacik [Wed, 2 Apr 2014 08:59:58 +0000 (08:59 +0000)]
Merge "BUG-467: reconnect-strategy configuration moved into controller/commons/protocol-framework -changed reconnect-strategy service and modules to reconnect-strategy-factory - configuration of ReconnectStrategyFactory."

6 years agoFixed missing keys in sal-compatibility flows. 47/5847/1
Tony Tkacik [Tue, 1 Apr 2014 06:59:49 +0000 (08:59 +0200)]
Fixed missing keys in sal-compatibility flows.

Change-Id: I6bc37e88b6191701369e2b6c0e821c1433ca122d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 508: Fixed concurrent conflicting commits by InventoryManager. 46/5846/1
Tony Tkacik [Tue, 1 Apr 2014 15:23:37 +0000 (17:23 +0200)]
Bug 508: Fixed concurrent conflicting commits by InventoryManager.

Change-Id: I0514b26e6ccdf456ec8ffb570056db43cebc89d0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Bug 499: Added support for old DOM Broker APIs."
Ed Warnicke [Tue, 1 Apr 2014 15:22:45 +0000 (15:22 +0000)]
Merge "Bug 499: Added support for old DOM Broker APIs."

6 years agoMerge "Bug 499: Added support for change listeners."
Ed Warnicke [Tue, 1 Apr 2014 15:22:27 +0000 (15:22 +0000)]
Merge "Bug 499: Added support for change listeners."

6 years agoMerge "Bug 499: Initial draft of in-memory datastore and data broker"
Ed Warnicke [Tue, 1 Apr 2014 15:21:25 +0000 (15:21 +0000)]
Merge "Bug 499: Initial draft of in-memory datastore and data broker"

6 years agoMerge "Updater toaster to use datastore"
Tony Tkacik [Tue, 1 Apr 2014 11:07:44 +0000 (11:07 +0000)]
Merge "Updater toaster to use datastore"

6 years agoMerge "Initial commit for new Match classes"
Giovanni Meo [Tue, 1 Apr 2014 09:02:40 +0000 (09:02 +0000)]
Merge "Initial commit for new Match classes"

6 years agoMerge "Bug 499: Initial implementation of data tree modifications"
Ed Warnicke [Mon, 31 Mar 2014 20:13:53 +0000 (20:13 +0000)]
Merge "Bug 499: Initial implementation of data tree modifications"

6 years agoMerge "Bug 499: Initial implementation of supporting tree structures"
Ed Warnicke [Mon, 31 Mar 2014 20:09:54 +0000 (20:09 +0000)]
Merge "Bug 499: Initial implementation of supporting tree structures"

6 years agoUpdater toaster to use datastore 23/5823/1
Robert Varga [Mon, 31 Mar 2014 16:06:20 +0000 (18:06 +0200)]
Updater toaster to use datastore

This patch adds the ability to expose the toaster status into MD-SAL, as
expected by the module. It further tweaks a thinko: dark toasts take
longer to make!

Change-Id: I3054ec52f53272c3fb08494517c6c86524403949
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-467: reconnect-strategy configuration moved into controller/commons/protocol... 09/5609/11
Milos Fabian [Mon, 17 Mar 2014 06:40:14 +0000 (07:40 +0100)]
BUG-467: reconnect-strategy configuration moved into controller/commons/protocol-framework
-changed reconnect-strategy service and modules to reconnect-strategy-factory - configuration of ReconnectStrategyFactory.

Change-Id: I863cf4f7cf559504d05e14293af9d2c5e9373ca7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
6 years agoMerge "Fix small resource leak in config-manager."
Tony Tkacik [Mon, 31 Mar 2014 07:31:16 +0000 (07:31 +0000)]
Merge "Fix small resource leak in config-manager."

6 years agoMerge "Update toaster example to emit lifecycle logs"
Tony Tkacik [Mon, 31 Mar 2014 07:26:27 +0000 (07:26 +0000)]
Merge "Update toaster example to emit lifecycle logs"

6 years agoMerge changes I28d517fe,Ia6f0b6ce
Tony Tkacik [Mon, 31 Mar 2014 07:25:44 +0000 (07:25 +0000)]
Merge changes I28d517fe,Ia6f0b6ce

* changes:
  Remove getPort API from sal-port.yang
  Avoid nullpointer exception on starting up the TopologyProvider and the InventorReadAdapter

6 years agoMerge "Do not use InstanceIdentifier.builder()"
Tony Tkacik [Mon, 31 Mar 2014 07:23:02 +0000 (07:23 +0000)]
Merge "Do not use InstanceIdentifier.builder()"

6 years agoMerge "Bug 564 - add missing sal-remote dependency."
Tony Tkacik [Mon, 31 Mar 2014 07:20:57 +0000 (07:20 +0000)]
Merge "Bug 564 - add missing sal-remote dependency."

6 years agoFix yang-parser-impl not being pulled 15/5815/1
Robert Varga [Sun, 30 Mar 2014 21:17:32 +0000 (23:17 +0200)]
Fix yang-parser-impl not being pulled

sal-netconf-connect depends on it, but relies on in transiently via
yang-data-impl. That transient dependency is going away, so introduce a
proper dependency.

Change-Id: I9efbec70e5630c98d19cd113a7d7096739f90dac
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoInitial commit for new Match classes 25/2725/6
Alessandro Boch [Tue, 10 Dec 2013 17:42:10 +0000 (09:42 -0800)]
Initial commit for new Match classes

- Existing match classes rely on a static enum of match types.
  This change is to allow extensibility for new matching fields.
- This commit introduces new classes without replacing old ones
  and without migrating any code to use the new ones yet.

Change-Id: I76531c10ae480123044ec1023bce8750ce7906ba
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoBug 499: Added support for old DOM Broker APIs. 44/5744/5
Tony Tkacik [Wed, 26 Mar 2014 18:29:13 +0000 (19:29 +0100)]
Bug 499: Added support for old DOM Broker APIs.

Added implementation of BackwardsCompatibleBroker
which exposes sal.core.api.DataBrokerService
using new DOMDataBroker and Data Store.

Enabled configuration which allows for configuring
specificing which implementation of Data DOM Broker
should be used in the MD-SAL.

Change-Id: I6ad7172e62eac1ae0af9be08684b2ae4adba6005
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 499: Added support for change listeners. 43/5743/3
Tony Tkacik [Fri, 21 Mar 2014 12:30:45 +0000 (13:30 +0100)]
Bug 499: Added support for change listeners.

Change-Id: I9e9c46f13f77ac8b1bda459c35724a5e0b24d91f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 499: Initial draft of in-memory datastore and data broker 65/5665/5
Tony Tkacik [Tue, 18 Mar 2014 16:18:37 +0000 (17:18 +0100)]
Bug 499: Initial draft of in-memory datastore and data broker

Initial implementation of InMemoryDOMDataStore with support
for commits to the store and conflict checking

  - DOMDataBrokerImpl - initial implementation of DOM Data Broker which
       uses InMemoryDOMDataStore instances as store for Operational
       and Configuration data

  - InMemoryDOMDataStore - implementation of in-memory DOM Data Store
      which uses MutableDataTree

  - Updated SchemaAwareApplyOperation to provide
    more granular operations as
       - verifyStructure - verify if correct tree node types are used
       - isApplicable - verifies if modification is applicable to other
           snapshot

  Added test suite which tests InMemoryDOMStore, performance
  of DOMDataBroker and DOM Data Broker.

Change-Id: Ia7f8659aa128e1dc1e9a8580ac46452dfe66289a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 499: Initial implementation of data tree modifications 64/5664/4
Tony Tkacik [Tue, 18 Mar 2014 16:10:14 +0000 (17:10 +0100)]
Bug 499: Initial implementation of data tree modifications

Initial implementation of data tree modifications using
StoreMetadataNode and NodeModification.

  - DataAndMetadataSnapshot - helper class, which
      contains immutable snapshot of data and metadata

  - ModificationApplyOperation - interface definition
      of composite hierarchical operation, which
      is responsible for applying changes to provided
      subtree

  - SchemaAwareApplyOperation - implementations of
      ModificationApplyOperation based on parsed
      SchemaContext

  - MutableDataTree - class which integrates
     Data tree, Metadata tree, Node Modification tree
     and ModificationApplyOperations into mutable logical
     tree, which will serves as a basis for read-write
     transactions.

  - Unit test for MutableDataTree in following scenarios
      - Create empty MutableDataTree, write subtree, read nested nodes
      - Create empty MutableDataTree, write subtree, modify subtree
      - Create MutableDataTree with existing date, write changes and deletes

Change-Id: I5c0c84764f93d150eac6d227c4bc367b67652f9d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 499: Initial implementation of supporting tree structures 63/5663/5
Robert Varga [Tue, 18 Mar 2014 16:00:55 +0000 (17:00 +0100)]
Bug 499: Initial implementation of supporting tree structures

  - StoreTreeNode - interface defining common interface to tree
    structures used by data store.

  - TreeNodeUtils - utility methods which uses StoreTreeNode
      as tree definitions and provides functionality such
      as retrieval of deep nodes.

  - StoreMetadataNode - immutable tree node (and tree), representing
        versioning metadata and data.

  - NodeModification - mutable tree node (and tree),
       representing modification (diff) which should be applied to
       data tree. Tree is lazily populated by invoking client
       operations to be maded.

This patchset requires https://git.opendaylight.org/gerrit/#/c/5646/
to be merged.

Change-Id: I2d2437ea64ba54565ba60826fe0e7c14f071598e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP."
Tony Tkacik [Fri, 28 Mar 2014 19:13:21 +0000 (19:13 +0000)]
Merge "Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP."

6 years agoUpdate toaster example to emit lifecycle logs 05/5805/1
Robert Varga [Fri, 28 Mar 2014 18:58:38 +0000 (19:58 +0100)]
Update toaster example to emit lifecycle logs

Change-Id: I8a73f71d315489d349aa3f2b701c5cbf2ef5a2c6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Add Enqueue validation check in FlowConfig"
Alessandro Boch [Fri, 28 Mar 2014 18:10:20 +0000 (18:10 +0000)]
Merge "Add Enqueue validation check in FlowConfig"

6 years agoAdd Enqueue validation check in FlowConfig 98/5798/3
Andrew Kim [Fri, 28 Mar 2014 02:44:47 +0000 (21:44 -0500)]
Add Enqueue validation check in FlowConfig

Backend validation to check enqueue queue is within range 0 - 2147483647

Change-Id: Ib17f3259a75fe3553455775bf7f26649ced40612
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoMerge changes Id6b8ba01,Ic4081b36
Tony Tkacik [Fri, 28 Mar 2014 16:47:30 +0000 (16:47 +0000)]
Merge changes Id6b8ba01,Ic4081b36

* changes:
  Bug:553 - RPC providers are not cleaned up on bundle stop, causing bundle restart to fail
  Bug:441-closing listener on stop of md-topologymaneger bundle

6 years agoMerge "fixed IT after netty version bump"
Tony Tkacik [Fri, 28 Mar 2014 16:14:47 +0000 (16:14 +0000)]
Merge "fixed IT after netty version bump"

6 years agofixed IT after netty version bump 02/5802/1
Michal Rehak [Fri, 28 Mar 2014 15:01:45 +0000 (08:01 -0700)]
fixed IT after netty version bump

- we need access to sun.nio.ch
- netty is needed before protocol-framework
- netty bundles internal order changed

Change-Id: I2ac25af6a559d935a733d8d28f05d95539ddc00b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
6 years agoFix IPluginInBridgeDomainConfigService API 41/5341/7
Robert Varga [Sat, 15 Feb 2014 02:39:22 +0000 (03:39 +0100)]
Fix IPluginInBridgeDomainConfigService API

IPluginInBridgeDomainConfigService protomoted Throwable into a
checked-exception status. This also includes Errors, which is not a good
thing, as Errors are not something we can handle gracefully.

Introduce a dedicated exception which implementations can use to report
instantiation problems.

Change-Id: Ib16d792acfcf77c68b92b35526ed7471e2172cbe
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Bug 500: DOMStore SPI"
Ed Warnicke [Fri, 28 Mar 2014 01:01:22 +0000 (01:01 +0000)]
Merge "Bug 500: DOMStore SPI"

6 years agoMerge "Bug 500: Type capture for DOM and Binding APIs"
Ed Warnicke [Fri, 28 Mar 2014 00:59:11 +0000 (00:59 +0000)]
Merge "Bug 500: Type capture for DOM and Binding APIs"

6 years agoMerge "Bug 500: Updated data APIs with new concepts."
Ed Warnicke [Fri, 28 Mar 2014 00:57:35 +0000 (00:57 +0000)]
Merge "Bug 500: Updated data APIs with new concepts."

6 years agoFix Enqueue Action in Flow UI 97/5797/2
Andrew Kim [Thu, 27 Mar 2014 20:53:17 +0000 (15:53 -0500)]
Fix Enqueue Action in Flow UI

Enqueue flow action accepts port and queue is optional

Change-Id: I7e6330106ed54c0ef8c3c93ffee12ded1ddf4a04
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoRemove getPort API from sal-port.yang 95/5795/1
Moiz Raja [Thu, 27 Mar 2014 18:59:23 +0000 (11:59 -0700)]
Remove getPort API from sal-port.yang

This API is not in use and it has not been properly modeled.

An RPC needs to have an input to be properly routed otherwise an exception will be thrown when registering.

Also see,

 - Bug 596
 - Gerrit https://git.opendaylight.org/gerrit/#/c/5781/

Change-Id: I28d517fe86ed63590fbd8fa17be712b581141869
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoAvoid nullpointer exception on starting up the TopologyProvider and the InventorReadA... 99/5699/2
Moiz Raja [Thu, 20 Mar 2014 19:58:16 +0000 (12:58 -0700)]
Avoid nullpointer exception on starting up the TopologyProvider and the InventorReadAdapter

The TopologyProvider and InventoryAndReadAdapter are Felix services which get started when all it's
dependencies are resolved (that is their start method gets called). The MD-SAL DataProviderService is not
or cannot be injected into them and so when start is called and the dataProviderService is used it throws an NPE

To fix this I simply moved most of the startup code into a separate method which I then call from the ComponentActivator
instead of start

Change-Id: Ia6f0b6cebd38f4af7f03c9da8a5e26e05c13f664
Signed-off-by: Moiz Raja <moraja@cisco.com>
6 years agoMerge "Bug 141: Connection Manager special characters"
Andrew Kim [Thu, 27 Mar 2014 16:59:07 +0000 (16:59 +0000)]
Merge "Bug 141: Connection Manager special characters"

6 years agoBug 500: DOMStore SPI 04/5604/7
Robert Varga [Tue, 11 Mar 2014 18:20:00 +0000 (19:20 +0100)]
Bug 500: DOMStore SPI

This is the API which needs to be implemented by a single logical tree
store, such that it can be plugged into the in-memory datastore
prototype.

The prototype keeps one logical data store for each of operational and
configuration subtrees. A front-end (client-visible) transaction results
in two back-end (data store) transactions. State transitions between the
three are coordinated using three-phase-commit protocol (3PC), with the
frontend transaction acting as the coordinator and the backend
transactions acting as cohorts.

Change-Id: Idfce04553e7c36ae6a1bb8c8b2699ca78c458bb4
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 500: Type capture for DOM and Binding APIs 13/5613/4
Robert Varga [Wed, 12 Mar 2014 14:54:52 +0000 (15:54 +0100)]
Bug 500: Type capture for DOM and Binding APIs

This commit introduces the type captures of new interfaces introduced in
the preceding commit.

Change-Id: I8da8ecd0a0404e89ae20d0d85894fc9da59e9903
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 500: Updated data APIs with new concepts. 95/5595/9
Robert Varga [Tue, 11 Mar 2014 12:28:59 +0000 (13:28 +0100)]
Bug 500: Updated data APIs with new concepts.

  - Logical Datastore Type idenfier
  - Asynchronous Data Broker contracts - some data broker contracts
    were synchronous which could misslead consumers of APIs

  - New Transaction subtypes with support for Asynchronous reads
    - read-only transaction
    - write-only transaction
    - read-write transaction
  - Scoped Data Change Publisher - client code is able
    to specify scope of changes and logical datastore
    type on which it is listening.

Change-Id: I2367e7df633dd07b08550014bed7a35c3e88a7ba
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Added explicit revision date import of ietf-inet-types to opendaylight-statist...
Ed Warnicke [Thu, 27 Mar 2014 16:09:12 +0000 (16:09 +0000)]
Merge "Added explicit revision date import of ietf-inet-types to opendaylight-statistics-type."

6 years agoBump netty.io to 4.0.17.Final 30/5630/4
Robert Varga [Sun, 9 Mar 2014 13:57:41 +0000 (14:57 +0100)]
Bump netty.io to 4.0.17.Final

Change-Id: I0f8c3d6ec41561c9c85cba5f36119a0f1b635347
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoDo not use InstanceIdentifier.builder() 61/5761/2
Robert Varga [Tue, 25 Mar 2014 21:07:14 +0000 (22:07 +0100)]
Do not use InstanceIdentifier.builder()

Stop using the type-usafe identifier builder. This eradicates the
obvious places. The leftover now are just the BI connector.

Change-Id: Iff1d1fc58e638d02e08951dbddead067d3e746e1
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "1. Delete TLS KeyStore password from system property so that it won't be shown...
Chi-Vien Ly [Wed, 26 Mar 2014 21:25:39 +0000 (21:25 +0000)]
Merge "1. Delete TLS KeyStore password from system property so that it won't be shown by getprop command. 2. Add a default location for TLS KeyStore files when the arguments are not provided."

6 years agoBug:553 - RPC providers are not cleaned up on bundle stop, causing bundle restart... 82/5782/1
Kamal Rameshan [Wed, 26 Mar 2014 21:12:19 +0000 (14:12 -0700)]
Bug:553 - RPC providers are not cleaned up on bundle stop, causing bundle restart to fail

Change-Id: Id6b8ba01194d71d2eb7ea97ca70088dec8b29d6e
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
6 years agoBug:441-closing listener on stop of md-topologymaneger bundle 01/5701/2
Kamal Rameshan [Thu, 20 Mar 2014 20:36:09 +0000 (13:36 -0700)]
Bug:441-closing listener on stop of md-topologymaneger bundle

Change-Id: Ic4081b36a557110f6daeb7a6fb8a3b39ee1be8b2
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
6 years agoAdd Flow actions to UI 68/5768/4
Andrew Kim [Tue, 25 Mar 2014 21:16:37 +0000 (16:16 -0500)]
Add Flow actions to UI

Flow UI now exposes only supported flow actions for particular network element

Change-Id: Ic7e251628192a48d47350d39ecf007df25cfeb37
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoResolve Bug:593. Persister should communicate via OSGi SR instead of TCP. 71/5771/1
Tomas Olvecky [Wed, 26 Mar 2014 09:11:26 +0000 (10:11 +0100)]
Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP.

Config persister now pushes configuration to netconf service directly by
java calls instead of using TCP connection to localhost. This allows
removing netconf client dependency from config-netconf-connector and
removes confusion when running more than one ODL process with same
configuration.

Change-Id: I96426b0fd1fe7110a59111a2b563e7494ebb811b
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years ago1. Delete TLS KeyStore password from system property so that it won't be shown by... 64/5764/1
Jason Ye [Tue, 25 Mar 2014 23:53:36 +0000 (16:53 -0700)]
1. Delete TLS KeyStore password from system property so that it won't be shown by getprop command.
2. Add a default location for TLS KeyStore files when the arguments are not provided.

Change-Id: I017d20d460f755ddb94a18c8a30c037aec76de54
Signed-off-by: Jason Ye <yisye@cisco.com>
6 years agoBug 141: Connection Manager special characters 63/5763/1
Sapan Shah [Tue, 25 Mar 2014 21:43:58 +0000 (14:43 -0700)]
Bug 141: Connection Manager special characters

Change-Id: I6778e0f9e20ab2cd22d01d77b43e6a1e3bade5bd
Signed-off-by: Sapan Shah <sapshah@cisco.com>
6 years agoUpdate to use yang concepts 57/5757/1
Robert Varga [Tue, 25 Mar 2014 12:00:56 +0000 (13:00 +0100)]
Update to use yang concepts

Change-Id: I529ec122c54d51efe10128985e8b1b0cd715461b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix sal-binding-api dependencies 52/5752/1
Robert Varga [Tue, 25 Mar 2014 01:32:15 +0000 (02:32 +0100)]
Fix sal-binding-api dependencies

Remove unused dependencies on sal-common and add used dependencies on
yang concepts and guava.

Change-Id: Ifb2b16f00b9af2bb8716412b4e6d4fa0fd5bdc54
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 564 - add missing sal-remote dependency. 50/5750/3
Milos Fabian [Tue, 25 Mar 2014 08:44:40 +0000 (09:44 +0100)]
Bug 564 - add missing sal-remote dependency.

Change-Id: Ic6968699f0214226dd9881d08684febeaf031525
Signed-off-by: Milos Fabian <milfabia@cisco.com>
6 years agoMerge "Add MountInstance client documentation and promote to ListenableFuture"
Tony Tkacik [Tue, 25 Mar 2014 05:24:51 +0000 (05:24 +0000)]
Merge "Add MountInstance client documentation and promote to ListenableFuture"

6 years agoMerge "Fix sal-common-api dependencies"
Tony Tkacik [Tue, 25 Mar 2014 05:20:41 +0000 (05:20 +0000)]
Merge "Fix sal-common-api dependencies"

6 years agoMerge "Do not catch Throwables, but rather Exceptions"
Tony Tkacik [Tue, 25 Mar 2014 05:11:38 +0000 (05:11 +0000)]
Merge "Do not catch Throwables, but rather Exceptions"

6 years agoFix sal-common-api dependencies 41/5741/1
Robert Varga [Tue, 25 Mar 2014 01:27:36 +0000 (02:27 +0100)]
Fix sal-common-api dependencies

sal-common-api should not depend on org.osgi.core nor sal-common. Remove
these dependencies and fix users which relied on org.osgi.core being
brought into compilation transitively.

Change-Id: Idf27f78e0c52c8a93e38c1fb7f8bba6615c3b745
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Moving simple fwding logic from ARPHandler into SimpleForwarding"
Giovanni Meo [Tue, 25 Mar 2014 01:23:09 +0000 (01:23 +0000)]
Merge "Moving simple fwding logic from ARPHandler into SimpleForwarding"

6 years agoAdd FLOOD_ALL action to FlowConfig 18/5718/1
Andrew Kim [Sun, 23 Mar 2014 01:40:52 +0000 (20:40 -0500)]
Add FLOOD_ALL action to FlowConfig

Change-Id: I8222562e0f76b33f7c992a426f86d912358ed2c1
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoMoving simple fwding logic from ARPHandler into SimpleForwarding 86/5586/5
Yevgeny Khodorkovsky [Mon, 10 Mar 2014 19:49:39 +0000 (14:49 -0500)]
Moving simple fwding logic from ARPHandler into SimpleForwarding

- Per Colin's idea, moving reactive fwding logic into SimpleForwarding
- SimpleForwarding listens to packet-in. Forwards IP packets
  between known hosts to dest (assuming a simple path will be installed).
- Some cleanup and debug stmts

Change-Id: Ib0f29af34d6dead26f7393b4238d62fe1935ecdf
Signed-off-by: Colin Dixon <ckd@us.ibm.com>
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoFix small resource leak in config-manager. 98/5698/1
Tomas Olvecky [Thu, 20 Mar 2014 15:47:45 +0000 (16:47 +0100)]
Fix small resource leak in config-manager.

When transaction is aborted, its ObjectName was not unregistered from platform mbean server.

Change-Id: Ia9b70ca68622fc187ed3db734d9344bd0d7b4ce9
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoFix sal-netconf-connector's pom.xml 97/5697/1
Tomas Olvecky [Thu, 20 Mar 2014 15:10:19 +0000 (16:10 +0100)]
Fix sal-netconf-connector's pom.xml

The offending pom was not configured to use sal generator, so there was no way
how to get required capability for netconf southbound plugin.

Change-Id: I4b266fde7c8f78347138755db8cbbafe7970d584
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoFix sal-remoterpc-connector's Import-Packages. 96/5696/1
Tomas Olvecky [Thu, 20 Mar 2014 13:05:32 +0000 (14:05 +0100)]
Fix sal-remoterpc-connector's Import-Packages.

BND version 2.4.0 produces illegal manifest with the old code - inserts
com.google.common.collect twice. This will propagate as persister failure.
Remove offending line, format distribution.opendaylight pom.xml,
move sal-remoterpc-connector version to common's distribution management.

Change-Id: I2b2a6e81855834648923e1b21e3c443d9ac48562
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "Fixed the problem in which different containers could have different mac addre...
Alessandro Boch [Thu, 20 Mar 2014 01:14:43 +0000 (01:14 +0000)]
Merge "Fixed the problem in which different containers could have different mac addresses. This caused problems such as a gateway appearing as host, host appearing on isl's etc."

6 years agoFix for Bug #533 86/5686/1
Ryan Moats [Wed, 19 Mar 2014 16:23:07 +0000 (11:23 -0500)]
Fix for Bug #533

Ensure start of Allocation Pool is set properly in all cases

Change-Id: Ie51dd0e019588b2769663b950527b8558db3624d
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
6 years agoDo not catch Throwables, but rather Exceptions 39/5339/6
Robert Varga [Fri, 14 Feb 2014 23:08:05 +0000 (00:08 +0100)]
Do not catch Throwables, but rather Exceptions

This turns catch Throwable into catch Exception, as doing the former
catches Errors, which are documented to be pretty much irrecoverable
conditions. Looking at
http://docs.oracle.com/javase/7/docs/api/java/lang/Error.html non of
these call sites can recover from an Error happening, so they should
never catch them.

Change-Id: I85237594f307a5a8778fb5a63f9dad4d120fc9d7
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFixed the problem in which different containers could have different mac addresses... 68/5668/2
Asad Ahmed [Tue, 18 Mar 2014 21:06:22 +0000 (14:06 -0700)]
Fixed the problem in which different containers could have different mac addresses. This caused problems such as a gateway appearing as host, host appearing on isl's etc.

Change-Id: I8b9d4f4c632d89a1379f08f281838772379c9d5c
Signed-off-by: Asad Ahmed<asaahmed@cisco.com>
6 years agoMerge "Resolve Bug:448 - Remove yang-store api and impl."
Tony Tkacik [Tue, 18 Mar 2014 10:45:26 +0000 (10:45 +0000)]
Merge "Resolve Bug:448 - Remove yang-store api and impl."

6 years agoMerge "Take advantage of MultipartTransactionAware"
Tony Tkacik [Tue, 18 Mar 2014 10:42:51 +0000 (10:42 +0000)]
Merge "Take advantage of MultipartTransactionAware"

6 years agoAdd MountInstance client documentation and promote to ListenableFuture 22/5622/2
Robert Varga [Thu, 13 Mar 2014 08:23:27 +0000 (09:23 +0100)]
Add MountInstance client documentation and promote to ListenableFuture

This adds documentation to MountInstance interface. Also promote
Future<> to ListenableFuture<>, as there is only a single implementation
anyway.

Change-Id: I9346f1f38c633b32fa7039f143d6c7634cb97359
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoupdate the pom files to enable the nexus repository path to be configured by properti... 19/5619/1
David K. Bainbridge [Wed, 12 Mar 2014 20:16:43 +0000 (13:16 -0700)]
update the pom files to enable the nexus repository path to be configured by properties such that if can be overriden via the command line to support deployment to alternative locations

Change-Id: Ie96244a1a2a3f6b2f3760f366899017a44aa381d
Signed-off-by: David K. Bainbridge <dbainbri@ciena.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.