8 years agoMerge "Fix test coverage not being reported in Sonar"
Tony Tkacik [Thu, 7 Aug 2014 06:09:50 +0000 (06:09 +0000)]
Merge "Fix test coverage not being reported in Sonar"

8 years agoUtilize transaction type to create read-only or 64/9764/2
Basheeruddin Ahmed [Wed, 6 Aug 2014 22:38:35 +0000 (15:38 -0700)]
Utilize transaction type to create read-only or
write-only or read-write transaction instead of always
creating read-write transaction

patch 2: updated based on review comments

Change-Id: I36390ab348c5774cf4bf180ea1608fe04f75d073
Signed-off-by: Basheeruddin Ahmed <>
8 years agoMerge "Created sal-clustering-commons and moved sal-protobuff-encoding files to sal...
Moiz Raja [Wed, 6 Aug 2014 22:49:44 +0000 (22:49 +0000)]
Merge "Created sal-clustering-commons and moved sal-protobuff-encoding files to sal-clustering-commons"

8 years agoMerge "Remove old dependencies"
Ed Warnicke [Wed, 6 Aug 2014 19:21:31 +0000 (19:21 +0000)]
Merge "Remove old dependencies"

8 years agoCreated sal-clustering-commons and moved 79/9679/6
Basheeruddin Ahmed [Tue, 5 Aug 2014 00:18:27 +0000 (17:18 -0700)]
Created sal-clustering-commons and moved
sal-protobuff-encoding files to sal-clustering-commons

updated sal-distributed-datastore pom with the above change

removed sal-clustering-commons as part of distribution as it is embedded currently as part of distributed-datastore

Note - after this is merged we need to move
 out the .proto from  akka-raft to sal-clustering-commons
and add dependency of sal-akka-raft on sal-clustering-commons
and embed the same
Change-Id: I7d4ac51628cef96ffb16acfcfd596dfd3129e0fa
Signed-off-by: Basheeruddin Ahmed <>
8 years agoMerge "Bug 1386: Avoid commit deadlock"
Tony Tkacik [Wed, 6 Aug 2014 17:05:10 +0000 (17:05 +0000)]
Merge "Bug 1386: Avoid commit deadlock"

8 years agoFix test coverage not being reported in Sonar 33/9733/8
Robert Varga [Wed, 6 Aug 2014 05:45:21 +0000 (07:45 +0200)]
Fix test coverage not being reported in Sonar

Change-Id: Id8ff02a986b1bfdab01a481fcb11cef111757de9
Signed-off-by: Robert Varga <>
8 years agoMerge "Optimilization the method datastoreNormalizedNodeToCompositeNode"
Tony Tkacik [Wed, 6 Aug 2014 15:52:19 +0000 (15:52 +0000)]
Merge "Optimilization the method datastoreNormalizedNodeToCompositeNode"

8 years agoMerge "A little extra protection against nulls in ConfigPusher"
Tony Tkacik [Wed, 6 Aug 2014 14:54:41 +0000 (14:54 +0000)]
Merge "A little extra protection against nulls in ConfigPusher"

8 years agoMerge changes If78d8143,Id8d04f24
Tony Tkacik [Wed, 6 Aug 2014 12:10:12 +0000 (12:10 +0000)]
Merge changes If78d8143,Id8d04f24

* changes:
  BUG-1281: eliminate thread-unsafe lookup
  BUG-1281: make methods static

8 years agoOptimilization the method datastoreNormalizedNodeToCompositeNode 42/9742/1
Jozef Gloncak [Wed, 6 Aug 2014 11:21:40 +0000 (13:21 +0200)]
Optimilization the method datastoreNormalizedNodeToCompositeNode

Origin method used schema context (which isn't necessary) and additionaly
doesn't cover all cases. + fixing of incorrect corresponding tests

Change-Id: Idbead2696de9102a202cad03c78f4a1a14a2d1d3
Signed-off-by: Jozef Gloncak <>
8 years agoMerge "Bug 1418 - onDataChange notification is not returning any data to the getCrea...
Tony Tkacik [Wed, 6 Aug 2014 09:25:10 +0000 (09:25 +0000)]
Merge "Bug 1418 - onDataChange notification is not returning any data to  the getCreatedData and getModifiedData function calls. Data change  notification does not seem to work."

8 years agoBug 1418 - onDataChange notification is not returning any data to 87/9687/4
Jan Hajnar [Tue, 5 Aug 2014 10:25:44 +0000 (12:25 +0200)]
Bug 1418 - onDataChange notification is not returning any data to
the getCreatedData and getModifiedData function calls. Data change
notification does not seem to work.

* Changed normalized to binding data change event translation call to
include event listener path. This path is then used to decode leaf or
mixin only augmentation because it can't be injected through children.
* Added verification tests.

Change-Id: Ia9d936f17b30b94fe4878e343cff7babb8d29d0f
Signed-off-by: Jan Hajnar <>
8 years agoA little extra protection against nulls in ConfigPusher 29/9729/1
Ed Warnicke [Wed, 6 Aug 2014 04:24:02 +0000 (23:24 -0500)]
A little extra protection against nulls in ConfigPusher

Change-Id: I4aab592b028b8336370c23924fcbf69858b7a6bd
Signed-off-by: Ed Warnicke <>
8 years agoBug 1386: Avoid commit deadlock 10/9210/10
tpantelis [Mon, 14 Jul 2014 12:01:16 +0000 (08:01 -0400)]
Bug 1386: Avoid commit deadlock

Changed the executor in DOMDataCommitCoordinatorImpl to a new
class DeadlockDetectingListeningExecutorService added to yangtools util.
This detects deadlock if another blocking commit is done by a client
notified from the single commit thread.

Change-Id: Icdc2b835fd336a1bbc37953828126b57253929c0
Signed-off-by: tpantelis <>
8 years agoBUG-1281: eliminate thread-unsafe lookup 28/9628/4
Robert Varga [Sun, 3 Aug 2014 13:39:11 +0000 (15:39 +0200)]
BUG-1281: eliminate thread-unsafe lookup

The URI/name lookup map was not safe when context was reloaded. Get rid
of it for now, as SchemaContext can maintain reasonably-fast lookups. At
the same time make sure we share codepaths as much as possible.

Change-Id: If78d8143e94446fe9b38da894611b1c8b61f57f3
Signed-off-by: Robert Varga <>
8 years agoBUG-1281: make methods static 04/9404/7
Robert Varga [Mon, 28 Jul 2014 20:02:40 +0000 (22:02 +0200)]
BUG-1281: make methods static

As it turns out ControllerContext has a few methods which do not touch
instance state -- make those static and fixup callers.

Change-Id: Id8d04f2426435528ee754f56b34f91d25a49d3ee
Signed-off-by: Robert Varga <>
8 years agoRemove old dependencies 92/9692/3
Giovanni Meo [Mon, 4 Aug 2014 16:22:11 +0000 (18:22 +0200)]
Remove old dependencies

- Remove stale dependencies that prevent releasing of artifacts
- Remove unused flow-management-compatibility and
inventory-topology-compatibility modules
- Make sure that if a dependency is on module with a version defined
by a variable, lets specify the version in the dependency management
in common pom
- Replace in netconf-cli the reference from yang-data-json to
yang-data-composite-node because yang-data-json has been removed
- Removed whitespaces in config-netty-config that would cause
checkstyle issues downstream otherwise

Change-Id: I866e4b36e71c004b925bd181412ff4df91b3091f
Signed-off-by: Giovanni Meo <>
8 years agoMigrate to junit 4.11 - failing test 85/9685/2
Jozef Gloncak [Tue, 5 Aug 2014 10:49:11 +0000 (12:49 +0200)]
Migrate to junit 4.11 - failing test

Corrected test which caused problems in

Change-Id: Ife89b83bbc1d2df4dc34327e5f27ed47509a8b48
Signed-off-by: Jozef Gloncak <>
8 years agoMerge "Fix failing IT tests"
Tony Tkacik [Tue, 5 Aug 2014 15:18:02 +0000 (15:18 +0000)]
Merge "Fix failing IT tests"

8 years agoMerge "Adding remoterpc connector to distribution and Updating actor system creation"
Moiz Raja [Tue, 5 Aug 2014 14:54:59 +0000 (14:54 +0000)]
Merge "Adding remoterpc connector to distribution and Updating actor system creation"

8 years agoFix failing IT tests 83/9683/3
Maros Marsalek [Tue, 5 Aug 2014 08:54:23 +0000 (10:54 +0200)]
Fix failing IT tests

- Binding Test Helper did not spefied object-cache as dependency
  and it was already part of distribution
- API Doc plugin was using invalid YANG files for positive
  test scenario.

Change-Id: I06c174408df6073d887f5c307cf1b70c34c442b1
Signed-off-by: Maros Marsalek <>
8 years agoMerge "Fixed namespace of yang testing file."
Tony Tkacik [Tue, 5 Aug 2014 10:09:13 +0000 (10:09 +0000)]
Merge "Fixed namespace of yang testing file."

8 years agoMerge "Bug 1354: Fixed rpc request/result transformation."
Tony Tkacik [Tue, 5 Aug 2014 09:28:44 +0000 (09:28 +0000)]
Merge "Bug 1354: Fixed rpc request/result transformation."

8 years agoAdding remoterpc connector to distribution and Updating actor system creation 99/9599/3
Harman Singh [Sat, 2 Aug 2014 01:35:58 +0000 (18:35 -0700)]
Adding remoterpc connector to distribution and Updating actor system creation

Actor system will be created with in bundle class loader now. This change has been made to avoid any conflict with other actor systems.
We faced one class cast exception earlier and this fixes that

Change-Id: Iad55e60ee950fdcff8698270445f0da31bc39c5e
Signed-off-by: Harman Singh <>
8 years agoFixed typo in restconf, which caused classcast in datastore. 61/9661/2
Tony Tkacik [Mon, 4 Aug 2014 17:46:39 +0000 (19:46 +0200)]
Fixed typo in restconf, which caused classcast in datastore.

Change-Id: I51eb1fc2e4056dc84feb3b720c3ee844ee4ffdea
Signed-off-by: Tony Tkacik <>
8 years agoDowngraded to hamcrest 1.1 to fix the build 76/9676/1
Ed Warnicke [Mon, 4 Aug 2014 22:14:23 +0000 (17:14 -0500)]
Downgraded to hamcrest 1.1 to fix the build

Change-Id: I5dc385ed61e8290eb81c50973417bd6ceb1c7508
Signed-off-by: Ed Warnicke <>
8 years agoMerge "BUG 1162 - ensure data for all path arguments in datastore."
Tony Tkacik [Mon, 4 Aug 2014 14:11:50 +0000 (14:11 +0000)]
Merge "BUG 1162 - ensure data for all path arguments in datastore."

8 years agoBUG 1162 - ensure data for all path arguments in datastore. 41/9641/3
Jozef Gloncak [Mon, 4 Aug 2014 06:28:14 +0000 (08:28 +0200)]
BUG 1162 - ensure data for all path arguments in datastore.

1) It is possible to specify path to data (including lists with
keys) via unexisting nodes and store payload data to this path.
Missing nodes in datastore are created before storing payload data.
2) InstanceIdentifier is now correctly created via

Change-Id: If795a930015fef39a0029e808355d51357e2d5d5
Signed-off-by: Jozef Gloncak <>
8 years agoFixed namespace of yang testing file. 40/9640/1
Martin Vitez [Mon, 4 Aug 2014 09:57:12 +0000 (11:57 +0200)]
Fixed namespace of yang testing file.

This test used 2 different yang files with same namespace, which is incorrect and can cause test fail later.

Change-Id: I87a78e36d1d8812bb92f71c82722f87559907423
Signed-off-by: Martin Vitez <>
8 years agoBug 1354: Fixed rpc request/result transformation. 33/9233/3
Lukas Sedlak [Fri, 18 Jul 2014 09:40:23 +0000 (11:40 +0200)]
Bug 1354: Fixed rpc request/result transformation.

This commit is dependent on commit in Yangtools project.
Fixed proper data transformation in toRpcRequest method in NetconfMessageTransformer.
Now every rpc request (edit-config, get and get-config) will be transformed for given Schema Context.

Change-Id: I08da9200c0ba680b36a445978e7de748e94b654d
Signed-off-by: Lukas Sedlak <>
8 years agoReturn a NoOpTransactionContext when the Primary for a shard is not found 36/9636/1
Moiz Raja [Sun, 3 Aug 2014 19:23:16 +0000 (12:23 -0700)]
Return a NoOpTransactionContext when the Primary for a shard is not found

A NoOpTransactionContext is returned when a request to create a transaction
results in the primary not being found or when the request times out.

A CanCommit on the NoOpTransaction will always false. A read
will always return an empty result. The consumer will need to deal with this situation.

Change-Id: Id6f7d0688921acac718b9bb06fbf03d5e345d7ac
Signed-off-by: Moiz Raja <>
8 years agoKeep DataChange registrations and notifications local 27/9627/2
Moiz Raja [Sun, 3 Aug 2014 13:36:13 +0000 (06:36 -0700)]
Keep DataChange registrations and notifications local

Here is how it works
When a consumer registers for a datachange notification we first check if the Shard
to which this registration needs to be sent is local. If it is then we send the
registration to it. If it is not then we simply return a NoOpRegistration to the consumer.
This ensures that a DataChange registration stays local to a cluster member.

Now let's say we have 3 replicas and in all those replicas we do find a local shard for a
given module and we have 3 listener registrations. At this time we do not want all 3 members
to be notified of the change. We only want the node which is the Leader to notify it's listeners
of the change. To restrict that the DataChangeListener will only forward events to the listener
if the Shard sends it a message enabling notifications

Change-Id: I035bbdf34e2509047f4bcb475c443a761b08e68d
Signed-off-by: Moiz Raja <>
8 years agoFix a couple of issues with replication 96/9596/4
Moiz Raja [Fri, 1 Aug 2014 23:14:05 +0000 (16:14 -0700)]
Fix a couple of issues with replication

- First the data that was being sent from the primary was not being deserialized on the followers
- The state on the followers was not being applied correctly
- Add sal-distributed-datastore to the distribution

Added a test for CompositeModificationPayload to ensure that serialization works correctly
Also added a set of integration test programs to test the serialization

Change-Id: Id67d2c4fe471003d9dd3b42a8376c90fd23492ce
Signed-off-by: Moiz Raja <>
8 years agoBUG-1473: update model.util.InstanceIdentifier users 23/9623/4
Robert Varga [Sun, 3 Aug 2014 11:31:05 +0000 (13:31 +0200)]
BUG-1473: update model.util.InstanceIdentifier users

Companion patch to, updates
users to use the new name. Also make the code a tiny bit more readable.

Fixed conversion to checked Future.

Change-Id: If8da3639e656214713d3680951cd9ae724c5ad6f
Signed-off-by: Robert Varga <>
8 years agoMerge "Bug 1392: Change ReadTransaction#read to return CheckedFuture"
Tony Tkacik [Sun, 3 Aug 2014 18:17:46 +0000 (18:17 +0000)]
Merge "Bug 1392: Change ReadTransaction#read to return CheckedFuture"

8 years agoMerge "BUG-1281: share filters between instances"
Tony Tkacik [Sun, 3 Aug 2014 18:14:29 +0000 (18:14 +0000)]
Merge "BUG-1281: share filters between instances"

8 years agoMerge "BUG-1281: use SchemaContext lookups"
Tony Tkacik [Sun, 3 Aug 2014 18:14:14 +0000 (18:14 +0000)]
Merge "BUG-1281: use SchemaContext lookups"

8 years agoMerge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"
Tony Tkacik [Sun, 3 Aug 2014 18:10:03 +0000 (18:10 +0000)]
Merge "BUG 1082 Migrate sal-rest-connector to Async Data Broker API"

8 years agoBUG-1281: share filters between instances 03/9403/4
Robert Varga [Mon, 28 Jul 2014 19:53:51 +0000 (21:53 +0200)]
BUG-1281: share filters between instances

The filters are invariants, so lets share them accross instances and not
instantiate them each time we need them.

Change-Id: Ib632efe758c22bd782fca0536c2fe7e9c6e831c3
Signed-off-by: Robert Varga <>
8 years agoBUG-1281: use SchemaContext lookups 02/9402/4
Robert Varga [Mon, 28 Jul 2014 19:45:12 +0000 (21:45 +0200)]
BUG-1281: use SchemaContext lookups

SchemaContext provides efficient module lookup services. Use those
instead of homegrown versions.

Change-Id: I4406438b137c8742a5265036f84a66d7f0f441c0
Signed-off-by: Robert Varga <>
8 years agoAdded test cases for each .proto file to ensure 95/9595/2
Basheeruddin Ahmed [Fri, 1 Aug 2014 23:06:18 +0000 (16:06 -0700)]
Added test cases for each .proto file to ensure
that test case fail in case incompatible version
of the protocol buffer is utilized.

New Patch: Updated with copyright header

Change-Id: Ib7fe9e212c6319f46202506d96544d149da28004
Signed-off-by: Basheeruddin Ahmed <>
8 years agoMerge "OS Neutron FWaaS api/jaxrs and associated bindings"
Madhu Venugopal [Sun, 3 Aug 2014 06:41:19 +0000 (06:41 +0000)]
Merge "OS Neutron FWaaS api/jaxrs and associated bindings"

8 years agoOS Neutron FWaaS api/jaxrs and associated bindings 26/9526/3
Brent Salisbury [Thu, 31 Jul 2014 11:01:53 +0000 (07:01 -0400)]
OS Neutron FWaaS api/jaxrs and associated bindings

-Removed and cleaned up some comments.
-Fixed null check on Firewall Rules

The Neutron v2.0 API document can be viewed at:

Sample API calls that can be imported into Postman
are located in the OVSDB directory at:
Directory: [ovsdb] / resources / openstack /
File: Neutron-v2.0-API-Examples.json.postman_collection

Change-Id: If37a0dd702aa02db9e94811c9a414718d25f42a7
Signed-off-by: Brent Salisbury <>
8 years agoMerge "Created Sample Feature Test Class for Base Feature Repository"
Madhu Venugopal [Sat, 2 Aug 2014 08:34:32 +0000 (08:34 +0000)]
Merge "Created Sample Feature Test Class for Base Feature Repository"

8 years agoMerge "added feature topology manager shell"
Madhu Venugopal [Sat, 2 Aug 2014 07:36:26 +0000 (07:36 +0000)]
Merge "added feature topology manager shell"

8 years agoMerge "Added hosttracker shell for karaf (rebased)"
Madhu Venugopal [Sat, 2 Aug 2014 07:33:30 +0000 (07:33 +0000)]
Merge "Added hosttracker shell for karaf (rebased)"

8 years agoMerge "Ignore generated journal directory"
Moiz Raja [Sat, 2 Aug 2014 04:17:41 +0000 (04:17 +0000)]
Merge "Ignore generated journal directory"

8 years agoMerge "Configuration Interface for Raft"
Moiz Raja [Fri, 1 Aug 2014 23:24:56 +0000 (23:24 +0000)]
Merge "Configuration Interface for Raft"

8 years agoMerge "Snapshot changes"
Moiz Raja [Fri, 1 Aug 2014 23:22:09 +0000 (23:22 +0000)]
Merge "Snapshot changes"

8 years agoMerge "Adding a constant file for actor names and paths."
Moiz Raja [Fri, 1 Aug 2014 23:19:31 +0000 (23:19 +0000)]
Merge "Adding a constant file for actor names and paths."

8 years agoConfiguration Interface for Raft 56/9556/2
Kamal Rameshan [Fri, 1 Aug 2014 02:38:48 +0000 (19:38 -0700)]
Configuration Interface for Raft

A default implementation for the ConfigParams is provided.

The client can override and provide an impl of ConfigParams.

For now only 4 parameters have been introduced. More can be added.

ExampleActor and TestDriver provide examples.

Change-Id: I42a46a521ad9364d535de479c58873dc70740c9f
Signed-off-by: Kamal Rameshan <>
8 years agoadded feature topology manager shell 42/7542/5
Jonathan Fok kan [Thu, 31 Jul 2014 21:05:01 +0000 (17:05 -0400)]
added feature topology manager shell

The shell is installed when odl-nsf-managers is installed

Change-Id: I460c71231ed54342983271304356737a1cb6c377
Signed-off-by: Jonathan Fok Kan <>
8 years agoAdded hosttracker shell for karaf (rebased) 09/9409/6
Gabriel Robitaille-Montpetit [Thu, 31 Jul 2014 19:59:52 +0000 (15:59 -0400)]
Added hosttracker shell for karaf (rebased)

Change-Id: I6c8eec9fddcd1a7d82e12e27f232fdaad65607b2
Signed-off-by: Gabriel Robitaille-Montpetit <>
8 years agoBUG 1082 Migrate sal-rest-connector to Async Data Broker API 57/8457/18
Jozef Gloncak [Mon, 30 Jun 2014 13:58:56 +0000 (15:58 +0200)]
BUG 1082 Migrate sal-rest-connector to Async Data Broker API

Rework of sal-rest-connector project to support Async Data Broker API

Change-Id: I73804418a04445b236d12693e493a11850dd94dd
Signed-off-by: Jozef Gloncak <>
8 years agoIgnore generated journal directory 72/9572/1
Ed Warnicke [Fri, 1 Aug 2014 11:23:17 +0000 (06:23 -0500)]
Ignore generated journal directory

Change-Id: I3557f3d2b3aee5ee553fa9b7b1f63428043ef2b3
Signed-off-by: Ed Warnicke <>
8 years agoAdded configfile to config-netty feature. 54/9554/2
Ed Warnicke [Fri, 1 Aug 2014 01:14:07 +0000 (20:14 -0500)]
Added configfile to config-netty feature.

Change-Id: Id5fea6efd0c65f4391e2c3e772611db74f6bc71c
Signed-off-by: Ed Warnicke <>
8 years agoMoved all config subsystem config files to mvn projects. 51/9551/3
Ed Warnicke [Thu, 31 Jul 2014 23:19:46 +0000 (18:19 -0500)]
Moved all config subsystem config files to mvn projects.

Change-Id: I98f4ab29fd57b800d5c9272e866ead3519e09264
Signed-off-by: Ed Warnicke <>
8 years agoMerge "Bug 1333: Regression Test suite."
Ed Warnicke [Fri, 1 Aug 2014 10:25:31 +0000 (10:25 +0000)]
Merge "Bug 1333: Regression Test suite."

8 years agoMerge "BUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector"
Tony Tkacik [Fri, 1 Aug 2014 09:44:05 +0000 (09:44 +0000)]
Merge "BUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector"

8 years agoMerge "Fix xsql compilation failure"
Tony Tkacik [Fri, 1 Aug 2014 09:43:54 +0000 (09:43 +0000)]
Merge "Fix xsql compilation failure"

8 years agoMerge "Bug 1369: Use separate single threadpool for data operations on binding mountp...
Ed Warnicke [Fri, 1 Aug 2014 09:35:31 +0000 (09:35 +0000)]
Merge "Bug 1369: Use separate single threadpool for data operations on binding mountpoint."

8 years agoBUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector 71/9471/2
Maros Marsalek [Tue, 29 Jul 2014 12:44:50 +0000 (14:44 +0200)]
BUG-732 Detect commit failure (and also put/delete/merge) in netconf-connector

When a failed rpc is detected, issue a discard changes rpc to keep device (candidate) configuration consistant (if candidate is supported).

Change-Id: Ia752ee33043b3159fd71b01eef34e6e79baf18be
Signed-off-by: Maros Marsalek <>
8 years agoFix xsql compilation failure 68/9568/1
Maros Marsalek [Fri, 1 Aug 2014 08:51:27 +0000 (10:51 +0200)]
Fix xsql compilation failure

Change-Id: I89fe87b64dd1377a89caad86d5a3bf91e3e40402
Signed-off-by: Maros Marsalek <>
8 years agoMerge "ControllerContext.dataNodeChildByQName method refactoring"
Tony Tkacik [Fri, 1 Aug 2014 08:35:13 +0000 (08:35 +0000)]
Merge "ControllerContext.dataNodeChildByQName method refactoring"

8 years agoMerge "Notificator create stream name method don't remove trailing slash"
Tony Tkacik [Fri, 1 Aug 2014 08:33:53 +0000 (08:33 +0000)]
Merge "Notificator create stream name method don't remove trailing slash"

8 years agoMerge "BUG-628 Allow configuration to override module based capabilities from remote...
Tony Tkacik [Fri, 1 Aug 2014 08:27:50 +0000 (08:27 +0000)]
Merge "BUG-628 Allow configuration to override module based capabilities from remote netconf device"

8 years agoMerge "BUG-868: Migrate to SchemaContextListener"
Tony Tkacik [Fri, 1 Aug 2014 08:00:43 +0000 (08:00 +0000)]
Merge "BUG-868: Migrate to SchemaContextListener"

8 years agoMerge "BUG-190 Simplify reconnect logic in protocol-framework."
Tony Tkacik [Fri, 1 Aug 2014 07:54:59 +0000 (07:54 +0000)]
Merge "BUG-190 Simplify reconnect logic in protocol-framework."

8 years agoMerge "Add XSQL into default compilation"
Tony Tkacik [Fri, 1 Aug 2014 07:50:52 +0000 (07:50 +0000)]
Merge "Add XSQL into default compilation"

8 years agoControllerContext.dataNodeChildByQName method refactoring 06/9306/3
Jozef Gloncak [Fri, 25 Jul 2014 05:48:29 +0000 (07:48 +0200)]
ControllerContext.dataNodeChildByQName method refactoring

ControllerContext.dataNodeChildByQName() is used only in childByQName()
methods with DataNodeContainer input parameters:
- ContainerSchemaNode
- ListSchemaNode
- Module
Therefore child node of these DataNodeContainers can't be ChoiceCaseNode
(because it can be only child node of ChoiceNode)
and original branch >if (node instanceof ChoiceCaseNode)< couldn't be
I think that it was typo.

Change-Id: Ieb85ad8acaf047b47813542d8968c399a4e30b50
Signed-off-by: Jozef Gloncak <>
8 years agoFix bug in test for distributed datastore 40/9540/2
Maros Marsalek [Thu, 31 Jul 2014 14:50:37 +0000 (16:50 +0200)]
Fix bug in test for distributed datastore

The test compared two normalized nodes using toString representation.
This is wrong since these nodes contain hash map and their order(also toString) changes depending on their content.
THe test compared two normalized nodes that did not contain same values. There was Integer in one and Long in the other.

The test failed for me on (due to hash map ordering):
java version "1.7.0_60"
Java(TM) SE Runtime Environment (build 1.7.0_60-b19)
Java HotSpot(TM) 64-Bit Server VM (build 24.60-b09, mixed mode)

Change-Id: Ib72c871077f79cff8327da9c57cc1faa8677a298
Signed-off-by: Maros Marsalek <>
8 years agoMerge "Fixed for bug : 1171 - issue while creating subnet"
Ed Warnicke [Fri, 1 Aug 2014 02:33:46 +0000 (02:33 +0000)]
Merge "Fixed for bug : 1171 - issue while creating subnet"

8 years agoMerge "Fixed for bug 1197"
Ed Warnicke [Fri, 1 Aug 2014 02:31:30 +0000 (02:31 +0000)]
Merge "Fixed for bug 1197"

8 years agoMerge "Fixed for bug 1168 : Issue while update subnet"
Ed Warnicke [Fri, 1 Aug 2014 02:30:50 +0000 (02:30 +0000)]
Merge "Fixed for bug 1168 : Issue while update subnet"

8 years agoSnapshot changes 20/9520/7
Kamal Rameshan [Thu, 31 Jul 2014 06:00:36 +0000 (23:00 -0700)]
Snapshot changes

Fixed adjusted index logic.
Added tests
Added Reinstate Node in TestDriver.
Changes related to recovery from snapshot
Review changes
Rebased with latest

Tasks to be done:
1. Snapshot capture criteria
2. Handling Snapshot failure
3. Configuration Interface
4. Install snapshot

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
Reinstate from snapshot + review changes

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
TestDriver changes

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
Log interpolation change

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>

Change-Id: Ie0d8341f501fef87f48e8ea6f5d6b6e878d1abe3
Signed-off-by: Kamal Rameshan <>
8 years agoAdding a constant file for actor names and paths. 55/9555/1
Harman Singh [Fri, 1 Aug 2014 01:17:19 +0000 (18:17 -0700)]
Adding a constant file for actor names and paths.

Easier to change the names in future if we have to

Change-Id: Ic57bab8b817e5367d694be12cef0e04aa23fd175
Signed-off-by: Harman Singh <>
8 years agoMerge "Add replication capability to Shard"
Ed Warnicke [Fri, 1 Aug 2014 01:26:27 +0000 (01:26 +0000)]
Merge "Add replication capability to Shard"

8 years agoAdding the wrongly removed module back in pom.xml 52/9552/1
Harman Singh [Fri, 1 Aug 2014 00:37:13 +0000 (17:37 -0700)]
Adding the wrongly removed module back in pom.xml

Change-Id: I242bc87cbf193ed65b6a7f5ffc8e2d466a48b80e
Signed-off-by: Harman Singh <>
8 years agoAdding actor supervisor, more logs and tests 15/9515/2
Harman Singh [Thu, 31 Jul 2014 01:42:26 +0000 (18:42 -0700)]
Adding actor supervisor, more logs and tests

Actor Supervisor will start rpcRegistry and rpcBroker actors and will resume them in case of exception
More logs have been added along with some unit test cases of xmlutil

Change-Id: I30101bd3b8ac6821b58b3e1a2421f7f1af26bcd1
Signed-off-by: Harman Singh <>
8 years agoUpdating cluster RPC code making it work 60/9460/3
Harman Singh [Wed, 30 Jul 2014 02:03:08 +0000 (19:03 -0700)]
Updating cluster RPC code making it work

Added XMLUtils to serialize and deserialize instance identifier objects and the values insides path arguments with proper object type. This code use Yangtools existing utility, but modify that code to make sure
right type is picked up. We can think of adding it directly in yang tools also and remove it from here
Added Preconditions check for pojos

Change-Id: Ieb73b4ee660d2e058d0a62952799fc6f39d4c6b5
Signed-off-by: Harman Singh <>
8 years agoRemoving unused org.objectweb.asm from northbound.commons 49/9549/2
Madhu Venugopal [Thu, 31 Jul 2014 21:04:47 +0000 (14:04 -0700)]
Removing unused org.objectweb.asm from northbound.commons

Change-Id: Ie5789f1574ea5565be66a3a4dd007fa976a920f0
Signed-off-by: Madhu Venugopal <>
8 years agoAdd XSQL into default compilation 43/9443/4
Robert Varga [Tue, 29 Jul 2014 16:20:26 +0000 (18:20 +0200)]
Add XSQL into default compilation

This adds XSQL into the default build.

Change-Id: I484f14d2633af5fc1ddc3aeec269757a4dee0dd6
Signed-off-by: Robert Varga <>
8 years agoAdd replication capability to Shard 23/9523/5
Moiz Raja [Thu, 31 Jul 2014 09:02:55 +0000 (02:02 -0700)]
Add replication capability to Shard

This commit integrates the distributed data store with our Raft implementation.

Shard now extends RaftActor which provides it the replication capabilities required.

Other notable changes are,
- The FindPrimary algorithm has been changed to find the first replica for a shard.
  The shard then forwards requests to create a transaction or transaction chain to
  the leader
- Changed the package name for Raft internal messages from "internal" to "base" to be
  more BND tool friendly
- Fix some issues with Serialization of Raft messages
- Create a NoOpTransaction when no Primary can be found. The commit for this transaction
  will always fail. The NoOpTransaction returns absent for reads in all cases.
- Add PeerAddressResolution capability to Raft. What this basically does is given a static
  configuration where a shard has 'n' peers, you can pass the names of those peers
  to the shard and resolve their addresses at a later time. This allows the Shard to ensure
  consensus even in a situation where it is the first one to come up but it's peers are still
  not running

Change-Id: I3087deb5eb4418cd629a707ba14f43858db1f463
Signed-off-by: Moiz Raja <>
8 years agoMerge "broken build - missing implementation of method getAnyXmlNodeSerializer"
Moiz Raja [Thu, 31 Jul 2014 14:19:12 +0000 (14:19 +0000)]
Merge "broken build - missing implementation of method getAnyXmlNodeSerializer"

8 years agoBUG-868: Migrate to SchemaContextListener 39/5939/9
Robert Varga [Sun, 9 Mar 2014 18:34:51 +0000 (19:34 +0100)]
BUG-868: Migrate to SchemaContextListener

SchemaServiceListener is deprecated, SchemaContextListener is its new
name. The class hierarchy allows for incremental migration.

Change-Id: I15d495d805eb7a08c3bcd3ab0cf8b5a8d2797db5
Signed-off-by: Robert Varga <>
8 years agobroken build - missing implementation of method getAnyXmlNodeSerializer 34/9534/1
Jozef Gloncak [Thu, 31 Jul 2014 13:47:40 +0000 (15:47 +0200)]
broken build - missing implementation of method getAnyXmlNodeSerializer

Change-Id: Ib7f22015462cb224e11c3c267cfbac7627eeb800
Signed-off-by: Jozef Gloncak <>
8 years agoBUG-628 Allow configuration to override module based capabilities from remote netconf... 90/9490/2
Maros Marsalek [Wed, 30 Jul 2014 14:11:39 +0000 (16:11 +0200)]
BUG-628 Allow configuration to override module based capabilities from remote netconf device

Suitable for devices that do not provide module based capabilities in hello message (most likely do not support ietf-netconf-monitoring).
User can place yang files into cache/schema folder and set the capabilities for these modules into config attribute for netconf-connector.

Change-Id: I541ef08bb5c0328e293f9c732353282ffaf0474d
Signed-off-by: Maros Marsalek <>
8 years agoNotificator create stream name method don't remove trailing slash 56/9256/2
Jozef Gloncak [Wed, 23 Jul 2014 11:12:20 +0000 (13:12 +0200)]
Notificator create stream name method don't remove trailing slash

Change-Id: I512879ce1b39b80b29a167147ef73e2ecef64afa
Signed-off-by: Jozef Gloncak <>
8 years agoBUG-1228: Optimize AbstractForwardedDataBroker a bit 04/9504/1
Robert Varga [Wed, 30 Jul 2014 18:42:00 +0000 (20:42 +0200)]
BUG-1228: Optimize AbstractForwardedDataBroker a bit

Profiling OFP with datastore backend has revealed that we spend about 9%
of CPU in AbstractForwardedDataBroker$ This turns out to be
a comparator, which compares two YangInstanceIdentifiers by their path
length -- and to do that it iterates fully through both of them.

We perform three optimizations:
- make the comparator itself shareable, so we do not instantiate it
  (6000 during the profiling run)
- make the .sortedEntries() smart about empty maps
- teach the comparator to abort iteration as soon as the result is

At the same time we import YangInstanceIdentifier, making the code a bit
more readable.

Change-Id: I38d3629ab33dac9e2e29b092e3a89d0821d09b07
Signed-off-by: Robert Varga <>
8 years agoMerge "Make Raft messages serializable"
Ed Warnicke [Wed, 30 Jul 2014 16:08:50 +0000 (16:08 +0000)]
Merge "Make Raft messages serializable"

8 years agoCreated Sample Feature Test Class for Base Feature Repository 97/9397/2
Mathieu Lemay [Mon, 28 Jul 2014 19:13:34 +0000 (15:13 -0400)]
Created Sample Feature Test Class for Base Feature Repository

Change-Id: I9553bc264080abd013c9c9ef8c6a29356e2ac7fd
Signed-off-by: Mathieu Lemay <>
8 years agoMerge "Serialization/Deserialization and a host of other fixes"
Ed Warnicke [Wed, 30 Jul 2014 12:05:21 +0000 (12:05 +0000)]
Merge "Serialization/Deserialization and a host of other fixes"

8 years agoMerge "Fix the build errors due to the class change of InstanceIdentifier to YangInst...
Tony Tkacik [Wed, 30 Jul 2014 08:05:09 +0000 (08:05 +0000)]
Merge "Fix the build errors due to the class change of InstanceIdentifier to YangInstanceIdentifier"

8 years agoBUG-1416 clean up flow statistic models 93/9293/4
Michal Rehak [Thu, 24 Jul 2014 15:25:32 +0000 (17:25 +0200)]
BUG-1416 clean up flow statistic models

- duplicate flow model removed from statistics augment
- statistics notification processing adapted
- sal-binding-dom-it fixed

Change-Id: I7ad5bae45b47f5ea8ed918459fc83cbd839b0e3a
Signed-off-by: Michal Rehak <>
8 years agoMerge "Created Network Service Functions Features"
Madhu Venugopal [Wed, 30 Jul 2014 02:24:07 +0000 (02:24 +0000)]
Merge "Created Network Service Functions Features"

8 years agoMake Raft messages serializable 00/9300/8
Kamal Rameshan [Thu, 24 Jul 2014 20:21:52 +0000 (13:21 -0700)]
Make Raft messages serializable

- Make AppendEntries a protocol buffer message
- Create the Payload extension mechanism to be used for AppendEntries by extensions
  of RaftActors to define their custom Payloads
- Modified tests etc as appropriate

Change-Id: I2d5af41b7ca8ad7a8b94515ebc5adaa78803ad15
Signed-off-by: Kamal Rameshan <>
Signed-off-by: Moiz Raja <>
8 years agoSerialization/Deserialization and a host of other fixes 55/9455/2
Moiz Raja [Thu, 10 Jul 2014 10:39:22 +0000 (03:39 -0700)]
Serialization/Deserialization and a host of other fixes

- Hande Cluster MemberUp and MemberRemoved events in ShardManager

- Cohort messages and close listener messages switched
to use protobuff

- Distributed Datastore switch messages to use protobuff
CreateTransactionChainReply distributed datastore messages
switched to protobuff

- ShardManager messages switch to protobuff

- DataChanged and other messages switch to protobuf in
distributed datastore

- Fixed few things found during testing
1. ShardStrategy - setting of configuration
2. NodeToNormalizedNodeBuilder - leaf node/leafsetentry node checks
3. DataChanged event - passing of scope instanceidentifier used during deserialization

- Introducing JMX MBeans for distributed datastore

-Fixed issues which were preventing remote Shards from talking to each other

- Fixed a number of issues related to deserialization

- Add distributed datastore to the build

- Switch from InstanceIdentifier to YangInstanceIdentifier

Change-Id: I0d15dc482cb2b0fb2170b1344bad9fa3b421e8e0
Signed-off-by: Moiz Raja <>
8 years agoMerge "Fixed unneeded wrapping of guava for karaf"
Moiz Raja [Tue, 29 Jul 2014 21:56:13 +0000 (21:56 +0000)]
Merge "Fixed unneeded wrapping of guava for karaf"

8 years agoBug 1392: Change ReadTransaction#read to return CheckedFuture 78/9178/12
tpantelis [Mon, 14 Jul 2014 16:35:57 +0000 (12:35 -0400)]
Bug 1392: Change ReadTransaction#read to return CheckedFuture

Added a ReadFailedException that is used with the CheckedFuture.
Moved the RpcError list from TransactionCommitFailedException to a new base
OperationFailedException in yangtools and also derived ReadFailedException from

Added a static MAPPER in ReadFailedException class using the new generalized base
ExceptionMapper class in yangtools. Also derived
TransactionCommitFailedExceptionMapper from ExceptionMapper.

Modified uses of Futures#makeChecked in the read Tx and write Tx submit
to use the new MappingCheckedFuture class in yangtools (see for details).

Change-Id: I5c4f717f0b8664b7d39c1e6f0366525f04e6634d
Signed-off-by: tpantelis <>