controller.git
9 years agoTopology Manager to skip redundant edge updates 23/1623/1
Alessandro Boch [Wed, 2 Oct 2013 21:22:38 +0000 (14:22 -0700)]
Topology Manager to skip redundant edge updates

ISSUE: In a cluster of controllers when one controller is brought down, when the switches
that were actively controlled by this node switch-over to another node in the cluster, on the
new node Connection Manager let openflow plugin Controller know the cluster view has changed.
OF plugin Controller then replay the switch added event for all the local tcp conencted
switches to InventoryShim. InventoryShim checks with CM service if the switches are now
to be considered local to this controller, they are, so it updates inventory service listeners
inside OF plugin (these are cluster unaware classes which need to know the switch is there now,
like data packet serv, discovery, of stats mgr, ...). These moduels inside the plugin during their
processing because this (to them) newly added switches generate notifications toward SAL in their
respective service. Listeners above SAL are cluster aware, they are already aware of those switches,
their properties and edges and so on, they should discard these updates. But in most of the cases
they don't, they accept these redundant updates upfront. As a consequence they generate unnecessary
updates toward their service listeners, causing unnecessary chains of events and recomputations.

CHANGE: This change is to fix the above issue in the topology service, in topology manager bundle.

Change-Id: I04d1fa81758238dfb9ada9940abc3d07ed1fc9cb
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoSimple Sanity Test to validate that all the bundles in a distribution are active... 14/1614/3
Moiz Raja [Wed, 2 Oct 2013 17:43:54 +0000 (10:43 -0700)]
Simple Sanity Test to validate that all the bundles in a distribution are active and resolved

The idea behind the Sanity Test is to ultimately fail a build when the test fails. The test would
launch run.sh but with a slightly modified config.ini where the sanitytest bundle would be injected
as a framework bundle.

The test waits for 30 seconds for the container to finish loading all the bundles. It then gets all the
bundles from the BundleContext and checks if they are ACTIVE or RESOLVED. If they are neither it prints
out the name of the bundle and it's state and returns an error code.

Change-Id: Ia6905318f1cf63e852791ba107193094a83fddf1
Signed-off-by: Moiz Raja <moraja@cisco.com>
9 years agoRevert "Newcomers that register with TopologyManager should get all the existing... 18/1618/2
Giovanni Meo [Wed, 2 Oct 2013 19:33:49 +0000 (19:33 +0000)]
Revert "Newcomers that register with TopologyManager should get all the existing edges"

This reverts commit 72fae1984afe741a93435269545f0346671cf305.

Reverting because it has some cascaded effects.

Change-Id: Iba8490a80ee2343d4875b1a2c5e17da7713099ee
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoChanged groupId for FCAPS to org.opendaylight.controller 05/1605/2
Tony Tkacik [Wed, 2 Oct 2013 15:00:30 +0000 (17:00 +0200)]
Changed groupId for FCAPS to org.opendaylight.controller

Change-Id: I65b82f7322e21cd9007f650a0d38c982923784a9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoAdd curly braces to for and if statements. 72/1572/2
Alissa Bonas [Tue, 1 Oct 2013 11:35:12 +0000 (14:35 +0300)]
Add curly braces to for and if statements.

Change-Id: I1a681f0de1fe3f2b442d71612b4f15171df48ea2
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoInitial code drop of yang model driven configuration system 62/1462/5
Tomas Olvecky [Fri, 27 Sep 2013 13:38:10 +0000 (15:38 +0200)]
Initial code drop of yang model driven configuration system

Configuration system employs two phase commit to validate and push configuration changes to a running system. It allows changing simple attributes, complex transfer objects, and also provides dependency injection between configured modules.
Module config-api contains base yang model config.yang, defining language extensions and other elements required by all configuration models. Other than that it contains both apis implemented by config-manager and spis to be implemeted by configuration providers. Since the configuration system is internally driven by JMX, package org.opendaylight.controller.config.api.jmx contains all M(X)Bean interfaces exposed by config-manager.
Module config-manager is implementation of config-api.
Module config-util contains clients (both JMX and jolokia, which is http based bridge to JMX) of configuration system.
Module yang-jmx-generator parses yang models and creates java representation of configuration models and service interfaces.
Module yang-jmx-generator-plugin is connector to yangtools yang-maven-plugin that generates skeletons of java files needed by configuration providers.
Module yang-test contains example yang file, from which code is being generated.
Module yang-jmx-generator-it tests yang-test.
Module yang-store-api contains api for a registry of all yang models parsed by yang-jmx-generator.
Module yang-store-impl uses OSGi extender pattern to read META-INF/yang/*.yang from all bundles and provides snapshot view of currently available configuration models.

Change-Id: Icf3201f9754e4ca28ebce3411d2a667dcd7e75c8
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
9 years agoFixed incorrect manifests for newly added MD-SAL components 95/1595/2
Tony Tkacik [Wed, 2 Oct 2013 09:57:35 +0000 (11:57 +0200)]
Fixed incorrect manifests for newly added MD-SAL components

Change-Id: I03e38cab3301f7ad801c91b777e08c114c28f917
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoAdded Binding-Aware APIs for Mount YANG extension 85/1585/2
Tony Tkacik [Tue, 1 Oct 2013 17:34:46 +0000 (19:34 +0200)]
Added Binding-Aware APIs for Mount YANG extension

Change-Id: If9e68625b38962e0f5432d605cb2e0300b217472
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoNewcomers that register with TopologyManager should get all the existing edges 79/1579/1
Giovanni Meo [Tue, 1 Oct 2013 15:39:11 +0000 (17:39 +0200)]
Newcomers that register with TopologyManager should get all the existing edges

- When an application wants to get topology updates by topology
manager, it may come after the topology manager has started to push
them around, in that case the app should retrieve the exisiting
topology. Some applications may not do that so topology manager can
still take care of this lazy one by pushing a snapshot of the existing
edges as soon as the listener is registered.

Change-Id: I919350b2ddfddfaa9186e09bd5167d7d810e3bcd
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoAdded flow capable node and augmentations to inventory 16/1516/3
Tony Tkacik [Mon, 30 Sep 2013 16:44:49 +0000 (18:44 +0200)]
Added flow capable node and augmentations to inventory

Change-Id: Iea8b826880fb56d6d52ea3b0ac18e630be05138b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoAdd first integration test for the TopologyManager bundle 21/1521/4
Moiz Raja [Mon, 30 Sep 2013 21:25:14 +0000 (14:25 -0700)]
Add first integration test for the TopologyManager bundle

Change-Id: I9a5230f0f72ba51a88bb36141773b4d00885a774
Signed-off-by: Moiz Raja <moraja@cisco.com>
9 years agoUpdated SAL Binding APIs 12/1512/3
Tony Tkacik [Mon, 30 Sep 2013 13:33:31 +0000 (15:33 +0200)]
Updated SAL Binding APIs

  Data Services
    - Added DataModification contract which is used to track
      reads and writes regarding configuration change.

    - Updated Transaction APIs to use nwe DataModification object
    - Deprecated old APIs for Data Modification which supported
      only one unsubmitted transaction per consumer / provider

  Rpc Services
    - Added Registration for Routed Rpcs
    - Added Registration for Mounted Rpcs

  Util classes
    - Updated implementation of AbstractBindingAwareConsumer
    - Updated implementation of AbstractBindingAwareProvider

Change-Id: I0adb98ae6faf6d214484e4b276d6c3df930ca4e9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMigrated dom.BrokerImpl to xtend code. 27/1427/6
Tony Tkacik [Wed, 25 Sep 2013 17:02:02 +0000 (19:02 +0200)]
Migrated dom.BrokerImpl to xtend code.

Change-Id: Ibf2a63c2d26be8dfa2f10f5467040dc753418362
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoAdded opendaylight-l2-types to the common parent 75/1575/1
Tony Tkacik [Tue, 1 Oct 2013 12:40:58 +0000 (14:40 +0200)]
Added opendaylight-l2-types to the common parent

Opendaylight-l2-types is dependency required by Flow Service models

Fixed version of ietf-inet-types, ietf-yang-types, opendaylight-types
to the release version.

Change-Id: I950c7f858187d113ef49fb8ff66e03282f04ab3b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoFix installInHw handling in FlowConfig 68/1568/1
Alessandro Boch [Tue, 1 Oct 2013 02:25:08 +0000 (19:25 -0700)]
Fix installInHw handling in FlowConfig

Change-Id: I1a78614e04c0d2b1c345c7d4538003aa790ea8ec
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoFix build failure in usermanager.implementation 20/1520/3
Alessandro Boch [Mon, 30 Sep 2013 18:57:18 +0000 (11:57 -0700)]
Fix build failure in usermanager.implementation

ISSUE:
Current usermanager.implementation junit code assumes test functions are run in order.
There is a add function and then a remove function to add/remove an object from a map.
In some machines consistently the remove function is invoked by junit first.
This leads to a failure/succes/failure/success... pattern for usermanager.implementation
builds.

Change-Id: Ie5041c6980f9dad0aeb1f11a27c0c3e9bab9dbcf
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoContainer Manager to expose inContainerMode() 17/1517/2
Alessandro Boch [Mon, 30 Sep 2013 17:33:37 +0000 (10:33 -0700)]
Container Manager to expose inContainerMode()

- So that IContainerLocalListener can poll the information when starting in default container

Change-Id: I3d8ceec9adef58915379eda3d3adc752175ea74c
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoRemove unused local variable in DataPacketService. 85/1485/3
Alissa Bonas [Sun, 29 Sep 2013 13:57:03 +0000 (16:57 +0300)]
Remove unused local variable in DataPacketService.

Change-Id: I24104b358142061724bcf09b451bad821680028a
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoMiscelanous fixes after the release of the artifacts 14/1514/2
Giovanni Meo [Mon, 30 Sep 2013 15:14:12 +0000 (17:14 +0200)]
Miscelanous fixes after the release of the artifacts

1) Made sure that the target directory from where the controller runs
doesn't include the version else after every release we need to change
the launchers and all the jenkins jobs
2) Change config.ini to pick the new snapshot
3) Change the launchers to use the new target directory containing the
controller
4) Avoid to build the third-party given they are mostly unchanged
since a while, that will save build time.

Change-Id: Ic1eb2dc9b84ad270c2cdadbb5af3ced8b8f4258b
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoAvoid javadoc breakages to break the whole build 15/1515/1
Giovanni Meo [Mon, 30 Sep 2013 15:47:58 +0000 (17:47 +0200)]
Avoid javadoc breakages to break the whole build

- Currently simple javadoc failures, like because there are no public
classes will break the whole build, that  should not be the case.

Change-Id: I44fd6b5a7870354f3f024872bd94288750d77776
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoChanged TopologyManager to ignore edges that contain invalid node connectors. 02/1502/2
Hideyuki Tai [Mon, 30 Sep 2013 18:26:29 +0000 (14:26 -0400)]
Changed TopologyManager to ignore edges that contain invalid node connectors.

- Changed TopologyManager to add only edges whose tail and head node connectors exist.
- Added a method to ISwitchManager to check whether a node connector exists.
- Added tests for the above changes.

Change-Id: Ib17ce94afea9ba16379ce454f48d5d8b1a1970b2
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
9 years agoAdded sal-connector-* skeletons (REST connector, MB, Netconf). 26/1426/5
Tony Tkacik [Wed, 25 Sep 2013 16:52:19 +0000 (18:52 +0200)]
Added sal-connector-* skeletons (REST connector, MB, Netconf).

FIxed version of YANG Tools to 0.5.8 release

Change-Id: Id20c9cd8798948f79c655b4d7f8ecad0d1dd392c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoRemove unused private method and unused imports. 95/1395/4
Alissa Bonas [Tue, 24 Sep 2013 12:02:33 +0000 (15:02 +0300)]
Remove unused private method and unused imports.

Change-Id: Icc46cacdb0b929df5dbbf460248a43483f4747d6
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoRemove unecessary instantiation of Integer 84/1484/3
Alissa Bonas [Sun, 29 Sep 2013 13:52:15 +0000 (16:52 +0300)]
Remove unecessary instantiation of Integer

Change-Id: I057e2df2cc6bf59c8a73ecabee9235c6615f0287
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoAdd curly braces in for loops in DeviceManagerImpl 82/1482/2
Alissa Bonas [Sun, 29 Sep 2013 13:37:49 +0000 (16:37 +0300)]
Add curly braces in for loops in DeviceManagerImpl

Change-Id: I9802573f086a1715687590c6478e486fee06c09f
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoAdd curly braces to if statements in StaticRouteConfig 83/1483/2
Alissa Bonas [Sun, 29 Sep 2013 13:44:10 +0000 (16:44 +0300)]
Add curly braces to if statements in StaticRouteConfig

Change-Id: I85ddb4b0e0a2a3b604b4eb6c5c526990127b2f4e
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoStop concatination inside append of StringBuffer 86/1486/2
Alissa Bonas [Sun, 29 Sep 2013 14:08:12 +0000 (17:08 +0300)]
Stop concatination inside append of StringBuffer

Change-Id: Ic62d273a6b401fb06e0299e36dcd0b428304a799
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoDeclare junit version and use junit dependencyManagement section. 81/1481/3
Alissa Bonas [Sun, 29 Sep 2013 11:52:50 +0000 (14:52 +0300)]
Declare junit version and use junit dependencyManagement section.

Change-Id: Ic290c0055ea0b3385d92a493ddc42decc0a4b12f
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoFrom SAL conversion test. 52/1452/3
Jozef Gloncak [Fri, 27 Sep 2013 09:35:36 +0000 (11:35 +0200)]
From SAL conversion test.

The test was added.

Change-Id: Ic1931aef40418b1b48849be4c6f6518548d9f8cf
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoFix Authorization class to be compatible with using clustered cache 91/1491/3
Yevgeny Khodorkovsky [Mon, 30 Sep 2013 02:07:46 +0000 (19:07 -0700)]
Fix Authorization class to be compatible with using clustered cache

Change-Id: I25b5a588648afcb79c56a26545ecb785afd0d3a3
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
9 years agoPort and statistics models updated. 69/1469/3
Prasanna Huddar [Fri, 27 Sep 2013 17:12:23 +0000 (22:42 +0530)]
Port and statistics models updated.
Will add port service types later

Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com>
Change-Id: I590fc1b1f2d1f6d2524c3754448d1dc1c4e671c0

9 years agoRevert "Changed TopologyManager to ignore edges that contain invalid node connectors." 99/1499/2
Giovanni Meo [Mon, 30 Sep 2013 08:21:20 +0000 (10:21 +0200)]
Revert "Changed TopologyManager to ignore edges that contain invalid node connectors."

This reverts commit d12862677a44f5bf66f8319a8f0e871c35797326.

Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Change-Id: Iaeca384ce8a2ef7c7d59263209d00214e2fa15b4

9 years agoMerge "Changed TopologyManager to ignore edges that contain invalid node connectors."
Giovanni Meo [Mon, 30 Sep 2013 07:32:17 +0000 (07:32 +0000)]
Merge "Changed TopologyManager to ignore edges that contain invalid node connectors."

9 years agoCall the flow programmer synchronously but in a different 90/1490/1
Asad Ahmed [Sun, 29 Sep 2013 19:29:03 +0000 (12:29 -0700)]
Call the flow programmer synchronously but in a different
thread so that the FRM event handler thread does not get blocked

Change-Id: Ide1e166a15f9619cd9e273feaa8d32a390b5cfb0
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
9 years ago[maven-release-plugin] prepare for next development iteration
jenkins-controller [Sun, 29 Sep 2013 08:43:50 +0000 (08:43 +0000)]
[maven-release-plugin] prepare for next development iteration

9 years ago[maven-release-plugin] prepare release releasepom-0.1.0 releasepom-0.1.0
jenkins-controller [Sun, 29 Sep 2013 08:43:46 +0000 (08:43 +0000)]
[maven-release-plugin] prepare release releasepom-0.1.0

9 years agoMerge "Move host refresh related variable from SwitchManager to HostTracker"
Madhu Venugopal [Sun, 29 Sep 2013 02:24:11 +0000 (02:24 +0000)]
Merge "Move host refresh related variable from SwitchManager to HostTracker"

9 years agoMove host refresh related variable from SwitchManager to HostTracker 80/1480/1
Maurice Qureshi [Sun, 29 Sep 2013 01:00:29 +0000 (18:00 -0700)]
Move host refresh related variable from SwitchManager to HostTracker

Change-Id: I30921217c33dd33923cf51e8a24841c744b8b115
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
9 years agoUI: Change TOS to ToS 79/1479/1
Andrew Kim [Sat, 28 Sep 2013 21:29:58 +0000 (16:29 -0500)]
UI: Change TOS to ToS

Change-Id: I2101134e7c3a8333376fdefa84796ed55b1c3827
Signed-off-by: Andrew Kim <andrekim@cisco.com>
9 years agoMerge "CORS support for ContainerManager Northbound APIs"
Giovanni Meo [Sat, 28 Sep 2013 18:52:45 +0000 (18:52 +0000)]
Merge "CORS support for ContainerManager Northbound APIs"

9 years agoFix bug in FRM 75/1475/2
Alessandro Boch [Fri, 27 Sep 2013 23:11:10 +0000 (16:11 -0700)]
Fix bug in FRM

ISSUE: Accessing workOrder mapping providing the wrong key object

Change-Id: I70c704566c6adede3f11348019f0d1da2f7eb43e
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoMerge "Decouple IContainerListener to avoid parallel computation in cluster"
Madhu Venugopal [Fri, 27 Sep 2013 19:14:18 +0000 (19:14 +0000)]
Merge "Decouple IContainerListener to avoid parallel computation in cluster"

9 years agoCORS support for ContainerManager Northbound APIs 70/1470/1
Madhu Venugopal [Fri, 27 Sep 2013 17:46:25 +0000 (10:46 -0700)]
CORS support for ContainerManager Northbound APIs

Change-Id: Iec1f37a249f92e39ede1ff3796b8d88cd2f510f5
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
9 years agoDecouple IContainerListener to avoid parallel computation in cluster 68/1468/1
Alessandro Boch [Fri, 27 Sep 2013 15:39:49 +0000 (08:39 -0700)]
Decouple IContainerListener to avoid parallel computation in cluster

ISSUE: On Container configuration change, or when they register with ContainerManager,
IContainerListener classes are notified locally and on all cluster nodes.
While cluster unaware classes like the Shim classes in the protocol plugin need this
notification on all the nodes to keep their local container related info up to date,
Functional Modules like FRM which are cluster aware do not need to be notified as they
react on these notifications performing flow operations. Currently all the FRMs in the
cluster reacts in parallel on Container Flow changes...

CHANGE: From Container config notification prespective, decouple the cluster aware classes
from the cluster unaware ones having the former register to a new IContainerLocal interface
instead of IContainerListener. On Container config changes, IContainerLocalListener will be
notified only on the controller node on which the configuration was applied (from GUI or NB).
On the remote controllers, where ContainerManager replays the configuration events, only
cluster unaware listeners will be notified.
Also, on IContainerLocalListener registration callback, in contrast with IContainerListener
registration callback, no container configurations bulk update will be pushed.
Simply because the FMs do not need to keep a local container information copy, they do not
care about the past events, they only need to be notified about a live config change event
which they use as a trigger to perform whatever task on their DB. If the task requires the
knowledge of the container config, they directly request it to Container Manager on the fly.

Change-Id: Icbaca58e04d60463b3aa54a61a4a1a467222d18e
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoChanged TopologyManager to ignore edges that contain invalid node connectors. 50/1450/1
Hideyuki Tai [Fri, 27 Sep 2013 13:46:01 +0000 (09:46 -0400)]
Changed TopologyManager to ignore edges that contain invalid node connectors.

- Changed TopologyManager to add only edges whose tail and head node connectors exist.
- Added a method to ISwitchManager to check whether a node connector exists.
- Added tests for the above changes.

Change-Id: I55b746eb007f58c38ab245cad3faa9ea47bc25cf
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
9 years agoJGroups AUTH handler in Clustering Services 57/1457/1 topic/codeshare/of1.3
Madhu Venugopal [Fri, 27 Sep 2013 12:48:38 +0000 (05:48 -0700)]
JGroups AUTH handler in Clustering Services

It is possible to add Jgroups AUTH as part of the protocol stack below infinispan if the deployment requires
more secured clustered controllers. Failing on such Authentication must be treated critical and the controller
must exit.

Change-Id: Ifa2b5cb2588b82038dcd6fcf7785a48ae2af8bf4
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
9 years agoMerge "Introduce ASYNC caches and use them in FRM"
Alessandro Boch [Fri, 27 Sep 2013 00:47:33 +0000 (00:47 +0000)]
Merge "Introduce ASYNC caches and use them in FRM"

9 years agoMerge "Update devices page"
Alessandro Boch [Fri, 27 Sep 2013 00:46:06 +0000 (00:46 +0000)]
Merge "Update devices page"

9 years agoMerge "Make FRM cleanup only local entries"
Alessandro Boch [Fri, 27 Sep 2013 00:44:29 +0000 (00:44 +0000)]
Merge "Make FRM cleanup only local entries"

9 years agoMerge "In case of an error event, cleanup the config too"
Alessandro Boch [Thu, 26 Sep 2013 21:41:24 +0000 (21:41 +0000)]
Merge "In case of an error event, cleanup the config too"

9 years agoIn case of an error event, cleanup the config too 49/1449/1
Asad Ahmed [Thu, 26 Sep 2013 21:21:55 +0000 (14:21 -0700)]
In case of an error event, cleanup the config too

Change-Id: Id413fbc230e0aa6df5682a8f0f70f0fb4c71243f
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
9 years agoUpdate devices page 28/1428/2
Andrew Kim [Wed, 25 Sep 2013 18:22:50 +0000 (13:22 -0500)]
Update devices page

- Minor enhancements to device page
- MAC Address in proper format
- Update examples in device page
- Update examples in flows page
- Hide first legend in add flows modal for cleaner look

Change-Id: I12c17804a9900f37a3f2fe610b58dbc7964e1ae0
Signed-off-by: Andrew Kim <andrekim@cisco.com>
9 years agoMake FRM cleanup only local entries 45/1445/1
Giovanni Meo [Thu, 26 Sep 2013 15:58:12 +0000 (17:58 +0200)]
Make FRM cleanup only local entries

- FRM when shutting down should only clean local entries and avoid to
trigger remote deletion because that cleanup will also be initiated on
the remote controller
- On shutdown make sure to wake up who may still be sleeping

Change-Id: I15346f73a761c71014c02762e44ccdae8e95edef
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoMerge "To SAL conversion test."
Giovanni Meo [Thu, 26 Sep 2013 08:27:30 +0000 (08:27 +0000)]
Merge "To SAL conversion test."

9 years agoPorting Tristate logic to SAL Connection Service and make use of it in Inventory... 31/1431/1
Madhu Venugopal [Thu, 26 Sep 2013 01:01:01 +0000 (18:01 -0700)]
Porting Tristate logic to SAL Connection Service and make use of it in Inventory Service Shim

ConnectionManager's locality status was moved from a binary state to tristate to address timing issues.
With this push, it is ported to the SAL Connection Service so that the protocol-plugins can make use of it as well.

Change-Id: I07a495a8c1d2606f6ae11ccdb73ec3445a438769
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
9 years agoFix wrong dependency 29/1429/1
Giovanni Meo [Wed, 25 Sep 2013 20:42:57 +0000 (22:42 +0200)]
Fix wrong dependency

Change-Id: I98afe96161a785fe5c5aca1114d77bdd804332b4
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoMerge "Silent false positive, and enhance real error message"
Madhu Venugopal [Wed, 25 Sep 2013 15:13:18 +0000 (15:13 +0000)]
Merge "Silent false positive, and enhance real error message"

9 years agoMerge "Stop overriding method just to call super."
Giovanni Meo [Wed, 25 Sep 2013 14:37:25 +0000 (14:37 +0000)]
Merge "Stop overriding method just to call super."

9 years agoMerge "Stop creating new Boolean, move to use valueOf method"
Giovanni Meo [Wed, 25 Sep 2013 14:36:16 +0000 (14:36 +0000)]
Merge "Stop creating new Boolean, move to use valueOf method"

9 years agoMerge "Add SCM section to all the poms"
Giovanni Meo [Wed, 25 Sep 2013 14:35:37 +0000 (14:35 +0000)]
Merge "Add SCM section to all the poms"

9 years agoTo SAL conversion test. 24/1424/1
Jozef Gloncak [Wed, 25 Sep 2013 12:44:24 +0000 (14:44 +0200)]
To SAL conversion test.

The test was added

Change-Id: I19988b3e8b4090cef504bc4edff16dc9d5ff7e4c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
9 years agoDeclare version property for maven bundle plugin, reuse it in poms and 41/1341/3
Alissa Bonas [Mon, 23 Sep 2013 11:58:34 +0000 (14:58 +0300)]
Declare version property for maven bundle plugin, reuse it in poms and
use version 2.3.7 instead of 2.3.6 and 2.4.0 used in parallel.

Change-Id: I3749f69ea38edbcacbe217386ac8accb19837c50
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoStop overriding method just to call super. 17/1417/1
Alissa Bonas [Wed, 25 Sep 2013 12:12:28 +0000 (15:12 +0300)]
Stop overriding method just to call super.

Change-Id: Ia0128d0d324378260b9eedb4c91a6e1b17e8c615
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoAdd SCM section to all the poms 14/1414/1
Giovanni Meo [Wed, 25 Sep 2013 11:52:38 +0000 (13:52 +0200)]
Add SCM section to all the poms

- For the release process we need SCM section to all the poms, some
are still missing it so adding them.

Change-Id: Id401e8502e9fc183e9b15ed5e28b7374ad86d80e
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoStop creating new Boolean, move to use valueOf method 12/1412/1
Alissa Bonas [Wed, 25 Sep 2013 11:24:03 +0000 (14:24 +0300)]
Stop creating new Boolean, move to use valueOf method

Change-Id: Ieecece68265b60a93b638204bae58a043ed3264b
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoMerge "Strong password check to consider underscore as a special character"
Giovanni Meo [Wed, 25 Sep 2013 10:03:18 +0000 (10:03 +0000)]
Merge "Strong password check to consider underscore as a special character"

9 years agoIntroduce ASYNC caches and use them in FRM 10/1410/1
Giovanni Meo [Wed, 25 Sep 2013 07:43:39 +0000 (09:43 +0200)]
Introduce ASYNC caches and use them in FRM

- Add the option in clustering.services contract to allocate caches
that are async
- Use them for FRM workOrder and workStatus
- Add unit tests for sync/async incompatibility

Change-Id: Icfc8d9b8a9277d97b095805cb4323a950c82ef78
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoSilent false positive, and enhance real error message 09/1409/1
Giovanni Meo [Wed, 25 Sep 2013 08:35:03 +0000 (10:35 +0200)]
Silent false positive, and enhance real error message

- With gerrit https://git.opendaylight.org/gerrit/#/c/1366/ i have
introduced a log error, to spot inconsistent hashcode but indeed it
turn out is getting exercised also during a normal code path,
basically when:
 <command orginator> --> <key owner> --> <all the other members>

all the other members when getting the replication from the non-key
owner will end up in this case. So that cannot be actually considered
an error.

Change-Id: Id38b45066164cb4998fdcdbb356bdf7af720b8c5
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoFix: Flows are deleted when another controller is started 06/1406/1
Pramila Singh [Tue, 24 Sep 2013 23:35:45 +0000 (16:35 -0700)]
Fix: Flows are deleted when another controller is started

Change-Id: I9f6c78bb80c4d7f988cc5fd760918f89436f2bf3
Signed-off-by: Pramila Singh <pramisin@cisco.com>
9 years agoStrong password check to consider underscore as a special character 05/1405/1
Alessandro Boch [Tue, 24 Sep 2013 17:03:19 +0000 (10:03 -0700)]
Strong password check to consider underscore as a special character

ISSUE:
Current strong password check regular expression does not consider '_' as a special character

Change-Id: Ib64fe2e94c1e6c76f24d42bd256f3e708f40d1cc
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoMerge "Add to jboss repository snapshot and release properties"
Giovanni Meo [Tue, 24 Sep 2013 14:48:45 +0000 (14:48 +0000)]
Merge "Add to jboss repository snapshot and release properties"

9 years agoMerge "Remove unused class member SAVE"
Giovanni Meo [Tue, 24 Sep 2013 14:35:45 +0000 (14:35 +0000)]
Merge "Remove unused class member SAVE"

9 years agoAdd to jboss repository snapshot and release properties 42/1342/2
Alissa Bonas [Mon, 23 Sep 2013 12:25:05 +0000 (15:25 +0300)]
Add to jboss repository snapshot and release properties

Change-Id: I7e639c369c9e6b16a8e525c51a13e29d50d12f19
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoTimeout ForwardingRulesManager workOrder 65/1365/2
Giovanni Meo [Mon, 23 Sep 2013 20:02:40 +0000 (22:02 +0200)]
Timeout ForwardingRulesManager workOrder

- Before this patch is an FRM request was submitted and no answer was
received by a remote controller, that would indefinitively stuck the
caller, clearly a bad practice. This patch is introducing a default
timeout of 30 second (very bad scenario) and a log.error is being
raised if that happens.
- Cleaned workMonitor cache on workStatus coming back or timeout.
- Make timeout tunable via system properties

Change-Id: I59ac402b30101e3cf1cf1b1beacf03fbc9add6c9
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoMerge "Action mapping To|From SAL conversion."
Giovanni Meo [Tue, 24 Sep 2013 13:55:23 +0000 (13:55 +0000)]
Merge "Action mapping To|From SAL conversion."

9 years agoMerge "Added sal-compability to build"
Giovanni Meo [Tue, 24 Sep 2013 13:50:50 +0000 (13:50 +0000)]
Merge "Added sal-compability to build"

9 years agoAction mapping To|From SAL conversion. 49/1349/3
Tony Tkacik [Tue, 24 Sep 2013 09:19:30 +0000 (11:19 +0200)]
Action mapping To|From SAL conversion.

- action was defined in flow-type.yang file according to actions in SAL
- action mapping was added to FromSalConversionsUtils.actionFrom
- action mapping was added to ToSalConversionsUtils.actionFrom

Change-Id: I3bd1c2eba896fb3a305da6ad698db9f0275d6f50
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoAdded sal-compability to build 46/1346/4
Tony Tkacik [Mon, 23 Sep 2013 12:50:12 +0000 (14:50 +0200)]
Added sal-compability to build

Change-Id: I64f8963760a6a6110e000e22c148919eaa841e77
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoAdd project.reporting.outputEncoding property to prevent maven warning 54/1354/2
Alissa Bonas [Mon, 23 Sep 2013 14:25:48 +0000 (17:25 +0300)]
Add project.reporting.outputEncoding property to prevent maven warning

Change-Id: Iaf0153b345a9ff5bade329d37f1377fa1226a99a
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoMerge "Enhance debug capabilities"
Madhu Venugopal [Tue, 24 Sep 2013 13:00:48 +0000 (13:00 +0000)]
Merge "Enhance debug capabilities"

9 years agoRemove unused class member SAVE 94/1394/1
Alissa Bonas [Tue, 24 Sep 2013 11:43:16 +0000 (14:43 +0300)]
Remove unused class member SAVE

Change-Id: If56dcd30aeaa49a400fd5a14b955268b9c7f6105
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoMoved MD SAL from sal/yang-prototype to md-sal 40/1340/2
Tony Tkacik [Mon, 23 Sep 2013 11:54:29 +0000 (13:54 +0200)]
Moved MD SAL from sal/yang-prototype to md-sal

Moved MD SAL sources, artefacts from
 opendaylight/sal/yang-prototype to opendaylight/md-sal

Change-Id: Ic3a6dca94faff8cef0dffe830a767d3ad5f0f21a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoEnhance debug capabilities 66/1366/2
Giovanni Meo [Mon, 23 Sep 2013 20:57:03 +0000 (22:57 +0200)]
Enhance debug capabilities

- Make sure infinispan complains very loud when it think an hashcode
is not consistent in the cluster.
- For now this patch is controller specific, but i will propose to
upstream in infinispan as well.
- Given BaseDistributionInterceptor.java came from version 5.3.0.Final
enforce it in the build

Change-Id: I029abac8d311ec3f49795ba325f075541fd3784b
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoFix occasional NPEs in Connection manager 88/1388/1
Yevgeny Khodorkovsky [Mon, 16 Sep 2013 18:02:03 +0000 (11:02 -0700)]
Fix occasional NPEs in Connection manager

- This fixes an issue where ConnectionManager bundle start/stop
  callbacks don't have the required dependenicies available, which
  causes occasional NPEs.

Change-Id: I3f9f17a4a500915cf72419bb352a40233506b846
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
9 years agoMerge "UI: Fix broken html literals"
Andrew Kim [Tue, 24 Sep 2013 01:12:15 +0000 (01:12 +0000)]
Merge "UI: Fix broken html literals"

9 years agoMerge "Minor log msg changes"
Alessandro Boch [Tue, 24 Sep 2013 00:21:43 +0000 (00:21 +0000)]
Merge "Minor log msg changes"

9 years agoAdded null check in FRM error handling and also formatting of OF ErrorMessage in... 84/1384/1
Asad Ahmed [Mon, 23 Sep 2013 22:59:40 +0000 (15:59 -0700)]
Added null check in FRM error handling and also formatting of OF ErrorMessage in the log statement

Change-Id: I2b32318284e74df51719786762499016831789ef
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
9 years agoMinor log msg changes 71/1371/1
Jason Ye [Mon, 23 Sep 2013 21:37:02 +0000 (14:37 -0700)]
Minor log msg changes

Change-Id: I289d031ff8157d1c0652d8471d4e5f017188dcf9
Signed-off-by: Jason Ye <yisye@cisco.com>
9 years agoUI: Fix broken html literals 68/1368/2
Yevgeny Khodorkovsky [Mon, 23 Sep 2013 21:17:12 +0000 (14:17 -0700)]
UI: Fix broken html literals

- Fix html literals that don't have correct apostrophes,
  resulting in breakage when user enters strings with spaces

Change-Id: Id2cb05ff4b3b5207602b2c27873f2c4ca9b48dad
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
9 years agoMerge "Remove unused spring dependency and wrong version in web pom"
Giovanni Meo [Mon, 23 Sep 2013 19:31:20 +0000 (19:31 +0000)]
Merge "Remove unused  spring dependency and wrong version in web pom"

9 years agoRemove unused spring dependency and wrong version in web pom 62/1362/1
Alissa Bonas [Mon, 23 Sep 2013 17:29:43 +0000 (20:29 +0300)]
Remove unused  spring dependency and wrong version in web pom

Change-Id: I1bc3b413b04ed7d706b89a0449b21df00ec18923
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoInitial push of Neutron interface 94/1294/8
Ryan Moats [Fri, 20 Sep 2013 17:51:39 +0000 (12:51 -0500)]
Initial push of Neutron interface

Two bundles included in this:
-networkconfig.neutron (contains JAXB annotated classes, *CRUD
interfaces with an implementation [for storing objects], and
Aware interfaces [for other bundles to register services])
-networkconfig.neutron.northbound (contains the JAXRS annotated
classes along with JAXB annotated request specific classes)

Commit amended to refactor .internal package to separate
implementation bundle and package

Commit re-amended to clean up issues in commons/opendaylight
and distribution/opendaylight poms

Commit re-re-amended to fix conflicts on rebase (I hope)

Getting close to just abandoning the change and starting over

Commit re-re-re-amended to fix parent issues in pom

amend to remove leaked CRs in distribution pom

- Cleanup of some duplicates artifact and of commons-net in modules
dependencies, anyway they get in via the commons.opendaylight

Change-Id: I15724c55e843237c010dfaec1e1e523560174f51
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
9 years agoMove mockito to dependencyManagement section in parent pom. 38/1338/2
Alissa Bonas [Mon, 23 Sep 2013 09:18:11 +0000 (12:18 +0300)]
Move mockito to dependencyManagement section in parent pom.

Change-Id: I6eeb91e1b5713db11b7ffdc9054eb6f316737079
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoMerge "Declare osgi.core.version in one pom and reuse it."
Giovanni Meo [Mon, 23 Sep 2013 13:11:59 +0000 (13:11 +0000)]
Merge "Declare osgi.core.version in one pom and reuse it."

9 years agoMerge "Move init and destroy empty impl from Activator classes. Have only one empty...
Giovanni Meo [Mon, 23 Sep 2013 13:10:49 +0000 (13:10 +0000)]
Merge "Move init and destroy empty impl from Activator classes. Have only one empty implementation in parent class instead of having it in more than 20 classes. Only one class actually has a non empty implementation and it overrides the empty implementation from the parent."

9 years agoDeclare osgi.core.version in one pom and reuse it. 37/1337/2
Alissa Bonas [Mon, 23 Sep 2013 09:13:18 +0000 (12:13 +0300)]
Declare osgi.core.version in one pom and reuse it.

Change-Id: Ice2e727b5228a38208a355cc677f2779e8e69f0a
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoMove init and destroy empty impl from Activator classes. Have only one 27/1327/1
Alissa Bonas [Sun, 22 Sep 2013 19:10:09 +0000 (22:10 +0300)]
Move init and destroy empty impl from Activator classes. Have only one
empty implementation in parent class instead of having it in more than
20 classes. Only one class actually has a non empty implementation and
it overrides the empty implementation from the parent.

Change-Id: Ibbe43ba3e48e4eb80402c158cd45be0afc497fae
Signed-off-by: Alissa Bonas <abonas@redhat.com>
9 years agoMerge "Removing the Container Aware dependency from Clustering Services."
Giovanni Meo [Sun, 22 Sep 2013 13:38:07 +0000 (13:38 +0000)]
Merge "Removing the Container Aware dependency from Clustering Services."

9 years agoMerge "FRM to remove flows on switchport admin down"
Giovanni Meo [Sun, 22 Sep 2013 13:04:33 +0000 (13:04 +0000)]
Merge "FRM to remove flows on switchport admin down"

9 years agoMerge "Conversion class FromSalConversionsUtils."
Giovanni Meo [Sun, 22 Sep 2013 13:01:25 +0000 (13:01 +0000)]
Merge "Conversion class FromSalConversionsUtils."