controller.git
6 years agoMerge "Bug 509: Improve logging in InMemoryDataStore."
Ed Warnicke [Mon, 21 Apr 2014 21:35:07 +0000 (21:35 +0000)]
Merge "Bug 509: Improve logging in InMemoryDataStore."

6 years agoRemove last instance of controller.version 85/6285/2
Giovanni Meo [Fri, 18 Apr 2014 15:48:21 +0000 (17:48 +0200)]
Remove last instance of controller.version

controller.version was still used in the config.ini so made sure to
fix it

Change-Id: I7739df2c16dae6ce0e2f26aa991ff0984963cc63
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoRemoved duplication of the yang-jmx-generator-plugin 84/6284/2
Giovanni Meo [Fri, 18 Apr 2014 15:25:11 +0000 (17:25 +0200)]
Removed duplication of the yang-jmx-generator-plugin

- Removed unnecessary duplications or a dependency of
yang-maven-plugin which would cause issues in the release process

Change-Id: I858d96d298d2ce6a3a6be87a0261a7f23c2d70e8
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoRemove unnecessary variable in netconf-it 83/6283/2
Giovanni Meo [Fri, 18 Apr 2014 14:09:09 +0000 (16:09 +0200)]
Remove unnecessary variable in netconf-it

- Another roadblock to release of artifact mdsal.version is used as
variable in netconf-it, remove it

Change-Id: I955b7796c46a0852fd74d2ce2d77a033669f5922
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoRemove dependencyManagement from MDSAL 82/6282/3
Giovanni Meo [Fri, 18 Apr 2014 13:56:31 +0000 (15:56 +0200)]
Remove dependencyManagement from MDSAL

- MDSAL dependencyManagement has been removed in favor of commons.opendaylight

Change-Id: Ia744c3a24cebb5bc218991037359e69071575fdc
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "sal-dom-binding-it is not a bundle but is marked so"
Alessandro Boch [Sat, 19 Apr 2014 19:50:05 +0000 (19:50 +0000)]
Merge "sal-dom-binding-it is not a bundle but is marked so"

6 years agosal-dom-binding-it is not a bundle but is marked so 86/6286/2
Giovanni Meo [Fri, 18 Apr 2014 16:05:40 +0000 (18:05 +0200)]
sal-dom-binding-it is not a bundle but is marked so

- The wrong type of bundle causes the bundle to fail to compile

Change-Id: I41571c45d25262bc5af0b65f1cab9fa6587ce290
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim"
Alessandro Boch [Sat, 19 Apr 2014 19:08:22 +0000 (19:08 +0000)]
Merge "bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim"

6 years agoMerge "Remove hardcode yang.jmx.plugin"
Alessandro Boch [Sat, 19 Apr 2014 18:33:10 +0000 (18:33 +0000)]
Merge "Remove hardcode yang.jmx.plugin"

6 years agoMerge " Remove version mismatch in config.version"
Alessandro Boch [Fri, 18 Apr 2014 23:07:49 +0000 (23:07 +0000)]
Merge " Remove version mismatch in config.version"

6 years agoMerge "Ignore some auto-generated files"
Alessandro Boch [Fri, 18 Apr 2014 23:07:20 +0000 (23:07 +0000)]
Merge "Ignore some auto-generated files"

6 years agoMerge " Removed controller.version variable"
Madhu Venugopal [Fri, 18 Apr 2014 19:04:20 +0000 (19:04 +0000)]
Merge " Removed controller.version variable"

6 years agoMerge "Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statis...
Giovanni Meo [Fri, 18 Apr 2014 17:42:05 +0000 (17:42 +0000)]
Merge "Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics"

6 years agoRemove hardcode yang.jmx.plugin 81/6281/1
Giovanni Meo [Fri, 18 Apr 2014 13:40:51 +0000 (15:40 +0200)]
Remove hardcode yang.jmx.plugin

- Remove stale hardcode dependency

Change-Id: Ide87fd574cf6987a5d89bf31f9b078cad2033473
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years ago Remove version mismatch in config.version 80/6280/1
Giovanni Meo [Fri, 18 Apr 2014 13:32:50 +0000 (15:32 +0200)]
 Remove version mismatch in config.version

 - End goal was to remove several config.version present in the pom, in
 the making i cleaned some of the repetition in config parent pom and
 aligned with the commons.opendaylight
- Removed some more warning on the pom files

Change-Id: I6717ceb915fe90fa7313472eb03884de9d09235d
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoIgnore some auto-generated files 79/6279/1
Giovanni Meo [Fri, 18 Apr 2014 08:55:10 +0000 (10:55 +0200)]
Ignore some auto-generated files

- Some files under yang-test are autogenerated, ignore them

Change-Id: If8eebca103fffef50d11c2871e68530713e43d81
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years ago Removed controller.version variable 78/6278/1
Giovanni Meo [Fri, 18 Apr 2014 11:13:23 +0000 (13:13 +0200)]
 Removed controller.version variable

- controller.version doesn't make much sense given the BOM is composed
of different modules and the version of the pom.xml at root decide the
version of the whole while each component keeps his versioning.

Change-Id: I9cf6a0e8334cf2725f8e487148fe29cacdbec512
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "Bug 773: SimpleForwardingImpl hits NPE when .frm member is null and new host...
Giovanni Meo [Fri, 18 Apr 2014 07:59:05 +0000 (07:59 +0000)]
Merge "Bug 773:  SimpleForwardingImpl hits NPE when .frm member is null and new host is discovered"

6 years agoMerge "BUG-472: fix integration test breakage"
Giovanni Meo [Fri, 18 Apr 2014 07:58:31 +0000 (07:58 +0000)]
Merge "BUG-472: fix integration test breakage"

6 years agoIncorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics 68/6268/1
Pramila Singh [Fri, 18 Apr 2014 03:24:12 +0000 (20:24 -0700)]
Incorrect OFStatisticsType(OFStatisticsType.FLOW) is used to query Port Statistics

Change-Id: I6d146d946e721540f70065de4ca8d1b8be73d838
Signed-off-by: Pramila Singh <pramisin@cisco.com>
6 years agoBug 773: SimpleForwardingImpl hits NPE when .frm member is null and new host is... 67/6267/1
Flavio Fernandes [Fri, 18 Apr 2014 02:26:03 +0000 (22:26 -0400)]
Bug 773:  SimpleForwardingImpl hits NPE when .frm member is null and new host is discovered

Change-Id: Iba0986cec7f8cc999b2d9852b2bf21b2c5ba3c6f
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
6 years agoMerge "BUG-509: use dedicated executor for notifications"
Tony Tkacik [Thu, 17 Apr 2014 17:16:19 +0000 (17:16 +0000)]
Merge "BUG-509: use dedicated executor for notifications"

6 years agoBUG-509: use dedicated executor for notifications 62/6262/2
Robert Varga [Thu, 17 Apr 2014 16:48:22 +0000 (18:48 +0200)]
BUG-509: use dedicated executor for notifications

This dedicates a thread to datastore notifications, such that they are
delivered outside of the invoking threads. Also adds proper headers.

Change-Id: I44aeb9c4fefb8784d22ded9ae591d38993905ffa
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Enhance the LLDPTLV.java to handle the LLDP port ID subtypes 3 (MAC) in additi...
Jason Ye [Thu, 17 Apr 2014 16:21:34 +0000 (16:21 +0000)]
Merge "Enhance the LLDPTLV.java to handle the LLDP port ID subtypes 3 (MAC) in addition to 7 (Local). Many Ethernet switches take MAC addresses as the port IDs."

6 years agoAdding auto-sorting plugin to all Controller via parent/pom.xml 47/6247/2
jameshall03885 [Wed, 16 Apr 2014 18:18:57 +0000 (14:18 -0400)]
Adding auto-sorting plugin to all Controller via parent/pom.xml

leveraging google's sortpom plugin, all controller poms are sorted
at build time as per the opendaylight/commons/parent/pom.xml configuration.

Sorted lists of properties, dependencies, and plugins will increase pom readability
and help prevent duplicate entry errors.

This first submission is huge as I changed one pom.xml and all are then sorted.
Only if the sortpom plugin is reconfigured will all pom's again be changed.

Note that if any pom.xml is pushed without having been through a build ... folks are
going to see pom.xml files showup as modified unintentionally.

Change-Id: I8553f38b9f0e5f6d27177ad6b9b9c35a4b43d55a
Signed-off-by: jameshall03885 <ghall@brocade.com>
6 years agoBUG-472: fix integration test breakage 56/6256/1
Robert Varga [Thu, 17 Apr 2014 14:27:56 +0000 (16:27 +0200)]
BUG-472: fix integration test breakage

This makes sure IT using TestHelper do not break due to openexi not
being pulled in.

Change-Id: Iccf465f017d8a651e703d516d8142ef3dba4a24d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoUnify jacoco versions to 0.6.2.201302030002 24/5824/3
Maros Marsalek [Mon, 31 Mar 2014 16:30:55 +0000 (18:30 +0200)]
Unify jacoco versions to 0.6.2.201302030002

This cleans up previously unused pluginManagement sections and bumps
jacoco version 0.6.2.201302030002 (previously used by config subsys).

Change-Id: I027b219e7fd0225fe2ef12cbdcc1f7d47509e993
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoEnhance the LLDPTLV.java to handle the LLDP port ID 12/3812/2
Paiwei Wang [Wed, 18 Dec 2013 11:00:55 +0000 (03:00 -0800)]
Enhance the LLDPTLV.java to handle the LLDP port ID
subtypes 3 (MAC) in addition to 7 (Local).
Many Ethernet switches take MAC addresses as the
port IDs.

Change-Id: I8a0d0e5cf0e914a9fe77acd3d0d4787a2ac98760
Signed-off-by: Paiwei Wang <pwwang@itri.org.tw>
6 years agoAllow abilitiy to boot controller with non-default admin credentials 48/6248/2
Prasanth Pallamreddy [Wed, 16 Apr 2014 18:48:08 +0000 (11:48 -0700)]
Allow abilitiy to boot controller with non-default admin credentials

  - Default admin password can be overridden using the reset
    mechanism. NETWORK_ADMIN_PASSWORD_RECOVERY can optionally
    contain the password to be reset to.
  - Provide optional configuration to disallow factory default
    password. (-Dusermanager.disable-default-admin-password=true)
  - Convert ATN & ATZ security sensitive messages to 'trace' level
    instead of 'info' level

Change-Id: I7dcaf15e8d562f61a3a4636a8abc244b0d6365ae
Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
6 years agoMerge "BUG-731: remove unneeded null check"
Tony Tkacik [Wed, 16 Apr 2014 17:07:44 +0000 (17:07 +0000)]
Merge "BUG-731: remove unneeded null check"

6 years agoMerge "BUG-731: do not do String.toString()"
Tony Tkacik [Wed, 16 Apr 2014 17:07:18 +0000 (17:07 +0000)]
Merge "BUG-731: do not do String.toString()"

6 years agoMerge "BUG-731: do not catch Throwable"
Tony Tkacik [Wed, 16 Apr 2014 17:07:00 +0000 (17:07 +0000)]
Merge "BUG-731: do not catch Throwable"

6 years agoMerge "Bug 615: Removed xtend from Topology Manager"
Ed Warnicke [Wed, 16 Apr 2014 16:55:24 +0000 (16:55 +0000)]
Merge "Bug 615: Removed xtend from Topology Manager"

6 years agoMerge "Bug 509: Fixed incorrect merging of Data Store Writes / Events"
Ed Warnicke [Wed, 16 Apr 2014 16:44:35 +0000 (16:44 +0000)]
Merge "Bug 509: Fixed incorrect merging of Data Store Writes / Events"

6 years agoChange OpenEXI version to -SNAPSHOT 37/6237/4
Robert Varga [Wed, 16 Apr 2014 15:15:53 +0000 (17:15 +0200)]
Change OpenEXI version to -SNAPSHOT

This fixes the merge job failing because it cannot publish a released
artifact.

Change-Id: I6e2eeb5ef8e9e521df40a77c12ff8ae94436d16d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-472 Initial EXI encoder/decoder implementation in Netconf 78/5678/15
Maros Marsalek [Wed, 19 Mar 2014 14:58:03 +0000 (15:58 +0100)]
BUG-472 Initial EXI encoder/decoder implementation in Netconf

according to http://tools.ietf.org/html/draft-varga-netconf-exi-capability-02

Change-Id: I861c126a8df1b26f477aa354ed1f8dba59d651cd
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBUG-472: Add EXI codecs without wiring them 94/5494/6
Robert Varga [Sat, 8 Feb 2014 03:06:48 +0000 (04:06 +0100)]
BUG-472: Add EXI codecs without wiring them

This patch implements the EXI codecs to be used in the NETCONF pipeline.
No wiring into the protocol stack is done in this patch.

Change-Id: Ic708ef26d92e138f8269a49a2759f01d88085bf1
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-472: Import OpenEXI nagasena-0000.0002.0035.0 93/5493/4
Robert Varga [Sat, 1 Feb 2014 08:26:54 +0000 (09:26 +0100)]
BUG-472: Import OpenEXI nagasena-0000.0002.0035.0

This imports the OpenEXI nagasena library, on top of which the
implementation will be built.

Change-Id: I4ec0fc637f390fe14451c439870ec1846934ebbb
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: remove unneeded null check 29/6229/1
Robert Varga [Wed, 16 Apr 2014 09:20:38 +0000 (11:20 +0200)]
BUG-731: remove unneeded null check

Fixes a sonar warning:
https://sonar.opendaylight.org/issue/show/0b9faac8-cbfc-4aed-8749-80fdd53410d5

Change-Id: Ib44157dde70d9c654f6dcb242e1d44619a685ea6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: do not do String.toString() 28/6228/1
Robert Varga [Wed, 16 Apr 2014 09:17:18 +0000 (11:17 +0200)]
BUG-731: do not do String.toString()

Fixes a sonar warning. Also adds missing copyright headers.

Change-Id: If16eebc39e7f0d7e9787529995b666f04d239cdf
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: do not catch Throwable 27/6227/1
Robert Varga [Wed, 16 Apr 2014 09:07:46 +0000 (11:07 +0200)]
BUG-731: do not catch Throwable

This fixes the bad practice of catching Throwable, and uses logger
instead of e.printStackTrace().

Change-Id: I44541f7c71dda0bcf633d22d9a46b3959ed3001f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Resolve Bug:745 - remove windows line endings from config and netconf."
Tony Tkacik [Wed, 16 Apr 2014 08:28:40 +0000 (08:28 +0000)]
Merge "Resolve Bug:745 - remove windows line endings from config and netconf."

6 years agoBug 509: Improve logging in InMemoryDataStore. 24/6224/1
Tony Tkacik [Wed, 16 Apr 2014 07:14:34 +0000 (09:14 +0200)]
Bug 509: Improve logging in InMemoryDataStore.

Change-Id: Ia83fd9f68fde9cf082f5571f42b265a323638fb2
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 509: Fixed incorrect merging of Data Store Writes / Events 17/6217/2
Tony Tkacik [Tue, 15 Apr 2014 15:48:56 +0000 (17:48 +0200)]
Bug 509: Fixed incorrect merging of Data Store Writes / Events

ForwardedBackwardsCompatibleDataBroker:

In old Data API only way to replace element was to use
remove/put combination, which changed with new Async DOM Broker
APIs where put is actually add/replace so previous delete is not
neccessary.

BackwardsCompatibleTransaction keeps track of such remove/put
operations and propagates put-only to new Async Data Transaction.

DOMImmutableDataChangeEvent:

Builder for DOMImmutableDataChange event used ImmutableMap builder
which throws IllegalArgumentException when same key/value combo
is overriden, which made impossible to merge some events. Switched
Builder implementation to use combination of HashMap and
ImmutableMap.copyOf() in order to prevent this
IllegalArgumentException to fail commit process.

Change-Id: I935bd4f5499c26190c52adcaee1df6335640bfaf
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "BUG-509: add missing copyright headers"
Ed Warnicke [Tue, 15 Apr 2014 16:19:23 +0000 (16:19 +0000)]
Merge "BUG-509: add missing copyright headers"

6 years agoMerge "Bug 509: Fixed small discrepancies in Binding Data Change Events."
Ed Warnicke [Tue, 15 Apr 2014 16:15:53 +0000 (16:15 +0000)]
Merge "Bug 509: Fixed small discrepancies in Binding Data Change Events."

6 years agoMerge "Bug 509: Added In-memory datastore support for wildcarded change listeners"
Ed Warnicke [Tue, 15 Apr 2014 16:13:12 +0000 (16:13 +0000)]
Merge "Bug 509: Added In-memory datastore support for wildcarded change listeners"

6 years agoBUG-509: add missing copyright headers 96/6196/3
Robert Varga [Tue, 15 Apr 2014 09:13:52 +0000 (11:13 +0200)]
BUG-509: add missing copyright headers

Change-Id: Idb205cb5e14364661de24b0c9a8008a5995ba08b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 509: Fixed small discrepancies in Binding Data Change Events. 60/6160/6
Robert Varga [Mon, 14 Apr 2014 15:46:07 +0000 (17:46 +0200)]
Bug 509: Fixed small discrepancies in Binding Data Change Events.

DataNormalizer which was responsible to render representation
of Instance Identifier in original format was introducing
additional node, when translation happened from normalized
to legacy, which is only triggered by Data Change Events.

Implementation of responsible algorithm was changed to
use schema in order to derive legacy InstanceIdentifier.

Data Change Events

 - Translated Data Change events were deserialized from
   DOM format on each access to fields, which may introduced
   CPU time overhead.

   Immutability of backing Data Change Events allows to
   add lazy caching of translated TOs, since event and data
   contained in Event Object are immutable.

 - getUpdated*Data in original Binding APIs returned
   both created and modified, so backwards-compatible fix
   was introduced.

Change-Id: Idab3dffb8651d50cca79a22ddcd43af29561b80e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agobug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim 02/6202/1
Giovanni Meo [Tue, 15 Apr 2014 12:45:18 +0000 (14:45 +0200)]
bug 741 - Make sure to stop threads on bundle stop on TopologyServiceShim

- Cleanup of threads on bundle stop as well adjust of the logging
level during InterruptException

Change-Id: I3ae7aa5f50f76fae72c3119d00459f11ffa5a4ee
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoBug 491 - Use XmlUnit for xml comparing in junit tests. 56/6156/3
Milos Fabian [Mon, 14 Apr 2014 09:22:59 +0000 (11:22 +0200)]
Bug 491 - Use XmlUnit for xml comparing in junit tests.

-comparing XMLs as DOM Documents with XmlUnit
-added XmlUnit util class - contains common assertion tests

Change-Id: I505c7896e7243873b45c93ea3bf59c941a68924e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
6 years agoResolve Bug:745 - remove windows line endings from config and netconf. 00/6200/1
Tomas Olvecky [Tue, 15 Apr 2014 11:26:05 +0000 (13:26 +0200)]
Resolve Bug:745 - remove windows line endings from config and netconf.

Change-Id: Id60c44a5f3fd4979f4e13cb00e6537998718e94f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "Resolve Bug:717 - Remove fragment version requirement from config-persister-*"
Tony Tkacik [Tue, 15 Apr 2014 10:43:10 +0000 (10:43 +0000)]
Merge "Resolve Bug:717 - Remove fragment version requirement from config-persister-*"

6 years agoMerge "Bug 714 - Fixed creating DOM Document's element with namespace"
Tony Tkacik [Tue, 15 Apr 2014 10:40:30 +0000 (10:40 +0000)]
Merge "Bug 714 - Fixed creating DOM Document's element with namespace"

6 years agoMerge "Resolve Bug:445 Remove freemarker from config code generator."
Tony Tkacik [Tue, 15 Apr 2014 10:26:02 +0000 (10:26 +0000)]
Merge "Resolve Bug:445 Remove freemarker from config code generator."

6 years agoMerge "BUG 718: changed codec for URI parsing"
Tony Tkacik [Tue, 15 Apr 2014 10:25:03 +0000 (10:25 +0000)]
Merge "BUG 718: changed codec for URI parsing"

6 years agoMerge "Resolve Bug:713 - Open snapshot only once per session."
Tony Tkacik [Tue, 15 Apr 2014 10:09:26 +0000 (10:09 +0000)]
Merge "Resolve Bug:713 - Open snapshot only once per session."

6 years agoMerge "Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX...
Tony Tkacik [Tue, 15 Apr 2014 08:49:27 +0000 (08:49 +0000)]
Merge "Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean."

6 years agoResolve Bug:713 - Open snapshot only once per session. 57/6157/2
Tomas Olvecky [Mon, 14 Apr 2014 08:22:26 +0000 (10:22 +0200)]
Resolve Bug:713 - Open snapshot only once per session.

Rework NetconfOperationServiceSnapshot lifecycle: Open it when
session negotiator is requested, thus at entry point where both
hello message and session listener is created. Close the snapshot
when NetconfSessionListener receives down/terminated event.

Change-Id: Id491110524ab635e552a49f48e4938dd7113d8bf
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoResolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean. 26/6026/2
Tomas Olvecky [Thu, 10 Apr 2014 12:13:14 +0000 (14:13 +0200)]
Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean.

Fixes race condition that was observed in ITs, where config pusher started pushing
empty configuration and immediately registered itself as notification listener of
a JMX bean that was not yet present. Fix waits both for netconf-impl and
config-netconf-connector services so that both dependencies are activated before
pushing of configuration can occur.

Change-Id: Id328dc3bd7e41bad59bb84b03461d89f5faeeea4
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBug 591: Minimize the use of Xtend in sal-binding-broker-impl 84/5984/5
Raghurama Bhat [Tue, 8 Apr 2014 20:48:25 +0000 (13:48 -0700)]
Bug 591: Minimize the use of Xtend in sal-binding-broker-impl

Change-Id: I3b21ccdf42685c7b10bf66fadf99ae82692149cf
Signed-off-by: Raghurama Bhat <ragbhat@cisco.com>
6 years agoMerge "Cleanup utility classes"
Tony Tkacik [Tue, 15 Apr 2014 07:46:03 +0000 (07:46 +0000)]
Merge "Cleanup utility classes"

6 years agoMerge "BUG-459 Remove deprecated NetconfClient class."
Tony Tkacik [Tue, 15 Apr 2014 07:45:31 +0000 (07:45 +0000)]
Merge "BUG-459 Remove deprecated NetconfClient class."

6 years agoMerge "BUG-372: Rework sal-netconf-connector"
Tony Tkacik [Tue, 15 Apr 2014 07:45:11 +0000 (07:45 +0000)]
Merge "BUG-372: Rework sal-netconf-connector"

6 years agoMerge "Change RpcImplementation contract to asynchronous"
Tony Tkacik [Tue, 15 Apr 2014 07:43:39 +0000 (07:43 +0000)]
Merge "Change RpcImplementation contract to asynchronous"

6 years agoMerge "BUG702: RPC Router fails to acquire IP address of the host"
Tony Tkacik [Tue, 15 Apr 2014 07:28:02 +0000 (07:28 +0000)]
Merge "BUG702: RPC Router fails to acquire IP address of the host"

6 years agoBug 509: Added In-memory datastore support for wildcarded change listeners 43/6143/6
Tony Tkacik [Thu, 10 Apr 2014 13:39:31 +0000 (15:39 +0200)]
Bug 509: Added In-memory datastore support for wildcarded change listeners

Added support for wildcarded data change listeners,
which may register to updates of list entries (and their
subentries) without specifying key for list items.

Support for Wildcarded Data Change Listneners is done by
refactoring DataChangeEventResolver into Map/Reduce processing.

Map phase:
When visiting each modified node (with key) we also
looks for listener listening on same level without key.
This actually may trigger creation (mapping) of multiple events
for same listeners (eg. two flows we're added at the same time).

Reduce phase:
We walked thru all listeners to be notified and if they have
multiple events assigned, we merge them into one even to be
delivered.

Change-Id: Ic05ddae10bd0b316009cc5bafdeca76350f00390
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBUG-509: improve normalization error reporting 66/6166/3
Robert Varga [Mon, 14 Apr 2014 16:13:00 +0000 (18:13 +0200)]
BUG-509: improve normalization error reporting

This patch introduces an explicit checked exception for reporting
normalization errors, declares it at strategic places and makes use of
it for generating better error reports than:

Caused by: java.lang.IllegalArgumentException: Supplied QName (urn:opendaylight:params:xml:ns:yang:pcep:crabbe:initiated:00?revision=2014-01-13)initiation is not valid according to schema container stateful

Change-Id: I2020c9e6ef85035259558a32f141a132b6321e0e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: Fail forwarning write if read fails. 65/6165/2
Robert Varga [Mon, 14 Apr 2014 13:12:45 +0000 (15:12 +0200)]
BUG-509: Fail forwarning write if read fails.

This primarily gets rid of e.printStackTrace(), but as part of that it
defines an important thing: if a read fails while we're building up the
path, we should not try to continue with the operation.

Change-Id: I48cb6cd304a98684a6984d26b6fc8dd5d14963c5
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-459 Remove deprecated NetconfClient class. 14/5514/8
Maros Marsalek [Mon, 3 Mar 2014 12:35:48 +0000 (13:35 +0100)]
BUG-459 Remove deprecated NetconfClient class.

NetconfClient moved to test sources, now will be used only by tests.

Change-Id: Ia98abe3f6fa4f05566b71d57c519c2149726bcb6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBug 651 - Added back IDE profile and changed target for yang sources 14/5914/5
jameshall03885 [Wed, 9 Apr 2014 14:30:03 +0000 (10:30 -0400)]
Bug 651 - Added back IDE profile and changed target for yang sources

- The IDE maven profile was added back based on feedback from Giovanni Meo

- To avoid devs from having to run the IDE profile so eclipse can see the yang
generated source files, the yang source files are now generated under src/main/yang-gen-sals
or src/main/yang-gen-config instead of target/target-ide.

- The maven-clean-plugin was moved to the commons base pom and removed from
all child poms where it was specified. Thus, it will be automatically run for all
projects. The plugin's execution will clean all xtend and yang generated source dirs.

- The build-helper-maven-plugin was also moved to the commons base pom and removed from
all child poms. It will automatically run for all projects and no longer needs to be
specified in child poms. The plugin's execution will created eclipse source folders
for all xtend and yang generated source.

Tom P and Devin A really did all this work, Greg just gets credit unfairly.

Conflicts:
        opendaylight/config/config-module-archetype/src/main/resources/archetype-resources/pom.xml

Change-Id: I8d9e403629cab2e48d03d5c7a417a02f1d878ca7
Signed-off-by: tpantelis <tpanteli@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
Signed-off-by: dbavery <devin.avery@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
6 years agoBug 714 - Fixed creating DOM Document's element with namespace 55/6155/2
Milos Fabian [Mon, 14 Apr 2014 08:05:15 +0000 (10:05 +0200)]
Bug 714 - Fixed creating DOM Document's element with namespace

Change-Id: Ic7449e11a9b2057d350dc889fcb81872d9ce24f8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
6 years agoCleanup utility classes 89/5489/7
Robert Varga [Thu, 27 Feb 2014 16:26:21 +0000 (17:26 +0100)]
Cleanup utility classes

Do not allow them to be instantiated, add a few comments and eliminate
e.printStackTrace();

Change-Id: I2e84bd81f2b91431791305fb61ca597337e98ae8
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-372: Rework sal-netconf-connector 58/5258/16
Robert Varga [Tue, 11 Feb 2014 07:44:46 +0000 (08:44 +0100)]
BUG-372: Rework sal-netconf-connector

This makes the connector truly asynchronous and able to work with
backing datastore going away. It will retry connecting infintely to the
backed device, too.

Change-Id: I843620bf63eeade231698c22592aaec0521a09ad
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoChange RpcImplementation contract to asynchronous 85/5485/9
Robert Varga [Thu, 27 Feb 2014 08:02:42 +0000 (09:02 +0100)]
Change RpcImplementation contract to asynchronous

This changes the method used to invoke RPCs such that they need not be
synchronous anymore, but rather return a ListenableFuture. If an
implementation is synchronous, it should use Futures.immediateFuture()
as a wrapper.

Change-Id: I0623d2afda038ba49afa83ed6020910b74b4911e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix run script always emitting a warning 46/6146/1
Robert Varga [Fri, 11 Apr 2014 16:21:26 +0000 (18:21 +0200)]
Fix run script always emitting a warning

This fixes a typo which resulted in the "memory not set" warning always
being omitted.

Change-Id: I7a9479adc6dde9be3d09e10d6e05e22004a876e6
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Remove unused code"
Tony Tkacik [Fri, 11 Apr 2014 14:49:47 +0000 (14:49 +0000)]
Merge "Remove unused code"

6 years agoMerge "BUG-592: Fix InstanceIdentifier instantiation"
Tony Tkacik [Fri, 11 Apr 2014 14:45:56 +0000 (14:45 +0000)]
Merge "BUG-592: Fix InstanceIdentifier instantiation"

6 years agoAdd async addStaticFlow api to FRM 86/5886/3
Alessandro Boch [Thu, 3 Apr 2014 06:22:47 +0000 (23:22 -0700)]
Add async addStaticFlow api to FRM

Change-Id: I6189ab2f617895a780bd14b9a620250476058da5
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoRemove unused code 44/6144/1
Giovanni Meo [Fri, 11 Apr 2014 13:19:12 +0000 (15:19 +0200)]
Remove unused code

- Cleanup some unused code from opendaylight/sal directory

Change-Id: I2a1197f9221c68bbd742584c1bd13ee3adf23af3
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoBUG 718: changed codec for URI parsing 48/6048/1
Martin Sunal [Fri, 11 Apr 2014 10:54:51 +0000 (12:54 +0200)]
BUG 718: changed codec for URI parsing

Change-Id: Ida06cb8d662ada99d67b994049228c7844d9d41e
Signed-off-by: Martin Sunal <msunal@cisco.com>
6 years agoResolve Bug:717 - Remove fragment version requirement from config-persister-* 46/6046/1
Tomas Olvecky [Fri, 11 Apr 2014 09:24:19 +0000 (11:24 +0200)]
Resolve Bug:717 - Remove fragment version requirement from config-persister-*

Remove Fragment-Host version requirement, because it does not map well
with maven versioning.

Change-Id: Ibec7a858e97d86ddf2c1f296d5bb0d36be30ff86
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "BUG-509: improve memory efficiency of ListenerTree"
Tony Tkacik [Fri, 11 Apr 2014 08:52:59 +0000 (08:52 +0000)]
Merge "BUG-509: improve memory efficiency of ListenerTree"

6 years agoMerge "BUG-509: Encapsulate ListenerTree"
Tony Tkacik [Fri, 11 Apr 2014 08:52:42 +0000 (08:52 +0000)]
Merge "BUG-509: Encapsulate ListenerTree"

6 years agoBUG-592: Fix InstanceIdentifier instantiation 87/5987/3
Robert Varga [Wed, 26 Mar 2014 23:54:48 +0000 (00:54 +0100)]
BUG-592: Fix InstanceIdentifier instantiation

This is a follow-up patch for
https://git.opendaylight.org/gerrit/#/c/5778 and gets rid of using
direct constructor use.

Change-Id: I09310b71c595a99bb09038f129b47b5b28aaaa33
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 615: Removed xtend from Topology Manager 68/5968/5
Robert Varga [Tue, 8 Apr 2014 14:59:37 +0000 (16:59 +0200)]
Bug 615: Removed xtend from Topology Manager

Rewriten Topology Exporter to Java code, added synchronized blocks
to critical pieces of code, which created conflicting transactions

Change-Id: I8d9cad2e0f6edfd2440d134ec0e2b670c16470b4
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoreadAllNodeTable() API in readServiceFilter.java queries for wrong OFStatisticsType 42/6042/1
Pramila Singh [Fri, 11 Apr 2014 00:42:52 +0000 (17:42 -0700)]
readAllNodeTable() API in readServiceFilter.java queries for wrong OFStatisticsType

Change-Id: I5551970f89587cbc6adae931d65c164aad8b0ca1
Signed-off-by: Pramila Singh <pramisin@cisco.com>
6 years agoBUG-509: improve memory efficiency of ListenerTree 32/6032/1
Robert Varga [Thu, 10 Apr 2014 16:59:45 +0000 (18:59 +0200)]
BUG-509: improve memory efficiency of ListenerTree

As it turns out, we do not need a Set<>, but rather a collection. We do
not expect major modifications of listeners, but memory efficiency and
iteration speed are required. Thus turn the HashSet into an ArrayList.

Also rename DataChangeListenerRegistration to
DataChangeListenerRegistrationImpl, so that the interface itself can be
imported and used as a shortname. This has the nice effect of rendering
a nasty SuppressWarnings completely unneeded.

Change-Id: I100337651c3b42c715978708bc98cf24ce5bf703
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: Encapsulate ListenerTree 30/6030/1
Robert Varga [Thu, 10 Apr 2014 10:28:24 +0000 (12:28 +0200)]
BUG-509: Encapsulate ListenerTree

This patch encapsulates the ListenerTree. This provides the
infrastructure needed to make listener registration/unregistration scale
and work in face of asynchronous commits.

Whenever a listener is about to be registered, the tree is write-locked,
the apropriate structure is created and the registration is enqueued.
When a registration is closed, the removeListener() callback re-takes
the appropriate lock and removes the listener.

When the last listener is removed from a node, and that node is unused,
it is cascaded up to its parent for removal, which recursively does the
same. This means that the tree is of unused nodes as soon as they are
freed. The backreference to parent is kept weak, which makes sure we are
able to finalize as much as we can in case of funky references lying
around.

Write locks are never leaked outside of the ListenerTree class, e.g.
they are always released before we return to the caller.

When a transaction is being committed, the ListenerTree is asked for a
Walker, which is an AutoCloseable resource. A Walker is the only way how
foreign code can get hold of a listener tree root node. Each walker is
backed by a reference to a read-lock, e.g. listener
registration/unregistration cannot occur while such a lock is held. This
makes sure the commit process sees a point-in-time view of the listener
tree. When a Walker is closed, the tree lock is read-unlocked. The
close() method is idempotent.

Change-Id: I6ea9b2e00f8ab21a5d8bd3b8c82c193c2069d683
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Upgrading clustermanager to use infinispan 6.0.2Final."
Giovanni Meo [Thu, 10 Apr 2014 16:18:31 +0000 (16:18 +0000)]
Merge "Upgrading clustermanager to use infinispan 6.0.2Final."

6 years agoMerge "BUG-694: Disable DataReader registration for BA Broker"
Tony Tkacik [Thu, 10 Apr 2014 12:10:24 +0000 (12:10 +0000)]
Merge "BUG-694: Disable DataReader registration for BA Broker"

6 years agoBUG-694: Disable DataReader registration for BA Broker 07/6007/3
Robert Varga [Wed, 9 Apr 2014 16:23:19 +0000 (18:23 +0200)]
BUG-694: Disable DataReader registration for BA Broker

The DataReader's semantic contract with its users, data merge,
when working with Binding-Aware DTOs.

The existing DataReaders implementations need to be rewritten as
datastores, which deal with the same problem in Binding Independent
format, such as the BI Data Broker.

Change-Id: I91b4516bb04a570acb6bf2b381860e9ae3fbbd43
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG702: RPC Router fails to acquire IP address of the host 86/5986/3
Abhishek Kumar [Tue, 8 Apr 2014 22:58:15 +0000 (15:58 -0700)]
BUG702: RPC Router fails to acquire IP address of the host

Removed the check that only picked private address space addresses. Now we pick IPv4 address belonging in any category that is not loopback address.

Change-Id: Idf98d1c64306059029bc4a6347d1ff952d45a6ba
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
6 years agoMerge "Bug 664 Update security.xml in web bundle"
Andrew Kim [Wed, 9 Apr 2014 16:27:28 +0000 (16:27 +0000)]
Merge "Bug 664 Update security.xml in web bundle"

6 years agoMerge "Document why we are using Virgo ExtensionsHookConfigurator"
Giovanni Meo [Wed, 9 Apr 2014 15:11:28 +0000 (15:11 +0000)]
Merge "Document why we are using Virgo ExtensionsHookConfigurator"

6 years agoMerge "Bug 698 - Confingured controller script to set max memory to 1 GB if not defined"
Giovanni Meo [Wed, 9 Apr 2014 14:38:39 +0000 (14:38 +0000)]
Merge "Bug 698 - Confingured controller script to set max memory to 1 GB if not defined"

6 years agoDocument why we are using Virgo ExtensionsHookConfigurator 03/6003/1
Robert Varga [Wed, 9 Apr 2014 14:26:39 +0000 (16:26 +0200)]
Document why we are using Virgo ExtensionsHookConfigurator

Change-Id: I289f091262c238985a83ea69df1b6b57fb29c2e1
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoUpgrading clustermanager to use infinispan 6.0.2Final. 57/5957/4
Ravikumar Chiguruvada [Tue, 8 Apr 2014 10:34:56 +0000 (16:04 +0530)]
Upgrading clustermanager to use infinispan 6.0.2Final.

- Removed unnecessary BaseInterceptor clone which was needed for 5.3.0
version
- Bumped services_implementation implementation version to indicate
this is actually different.
- Modified the parent pom version so version propagate in other places

Signed-off-by: Ravikumar Chiguruvada <ravikumar.chiguruvada@ericsson.com>
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Change-Id: I062c72153a2ffe6949f3a3c8d2f0cdaa826bb65c

6 years agoBug 698 - Confingured controller script to set max memory to 1 GB if not defined 80/5980/3
dbavery [Tue, 8 Apr 2014 18:45:14 +0000 (14:45 -0400)]
Bug 698 - Confingured controller script to set max memory to 1 GB if not defined

Modified the run.sh and run.bat scripts to configure the java max memory to be
 1 GB if it is not defined on the command line.

NOTE: Java generally sets the memory to be 1/4th the total memory of your system
so it is possible that this will result in LESS memory being allocate (change of
behavior). Once this work item is committed we should encourage a best practice
of defining max memory.

A message will be printed out notifying the users that the max memory was not
specified.

Change-Id: I39225f28c4aed3636a1db0cdb41fbe802f5b5b54
Signed-off-by: dbavery <devin.avery@brocade.com>
6 years agoBUG-509: improve safety of MutableDataTree 95/5995/2
Robert Varga [Wed, 9 Apr 2014 04:37:06 +0000 (06:37 +0200)]
BUG-509: improve safety of MutableDataTree

This limits field visibility and improves seal operation with respect to
other operations. Also make sure to check for multiple seals.

Change-Id: I2c91e59e3308010f8c95a3fb3898bace97b2db97
Signed-off-by: Robert Varga <rovarga@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.