controller.git
4 years agoRemove netconf from commons/opendaylight pom 30/24630/5
Maros Marsalek [Thu, 30 Jul 2015 14:05:28 +0000 (16:05 +0200)]
Remove netconf from commons/opendaylight pom

Change-Id: Id558bf0ac35c661be028eb9cea436b6728b414de
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
4 years agoBUG 2185 : Add JMX API to change the state of a Shard 31/26331/1
Moiz Raja [Fri, 24 Jul 2015 02:19:16 +0000 (19:19 -0700)]
BUG 2185 : Add JMX API to change the state of a Shard

Added two APIs to the ShardManager MBeans
- switchAllLocalShardsState
- switchShardState

Change-Id: I896e421f322f487b4f8eb321708e01cc93bbd48f
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 3a59e9f47466fbf150b6b14a44f4d6c775f79ee9)

4 years agoBUG 2185 : Disable all internal switching of behavior 90/26290/1
Moiz Raja [Mon, 3 Aug 2015 23:20:31 +0000 (16:20 -0700)]
BUG 2185 : Disable all internal switching of behavior

Since we do not depend on Raft for changing behavior when elections
are disabled we need to disable all internal switching of behaviors.

Added specific Leader tests to check the following,
1. Do not switch to Follower when you receive an AppendEntriesReply
   from a Follower with a higher term
2. Do not switch to IsolatedLeader even when no Follower is sending
   AppendEntriesReply

Change-Id: Ic2b4f76813f35db190e108306a62af5397d31658
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 9baf6a2a5e494f70af407f04631980857a26daf9)

4 years agoBug 3708 - APIdoc explorer URLs contain extra 'node' in REST calls 31/25531/2
Jan Hajnar [Thu, 25 Jun 2015 12:06:33 +0000 (14:06 +0200)]
Bug 3708 - APIdoc explorer URLs contain extra 'node' in REST calls

* fixed mount point path builder that added each list qname twice

Change-Id: I96d541ea8b40ab5003f82a9e5981e11e1f0fd0d2
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
(cherry picked from commit 523e75af81fa6537117ceae53c7cdb2b1881aa10)

4 years agoBug 3822: Improve error reporting for restconf PUT 37/25337/2
Tom Pantelis [Sat, 20 Jun 2015 08:09:47 +0000 (04:09 -0400)]
Bug 3822: Improve error reporting for restconf PUT

A runtime exception can be emitted by the netconf mount point which
should be reported to the user, otherwise you get a 500 response with
no error info which isn't very helpful.

Also the fucntionality to output the error-info field was ommitted with
the conversion from CompositeNode to NormalizedNode so I re-implemeneted
it. It was originally ommitted with a TODO b/c the
NormalizedNodeStreamWriters validate against the schema and error-info
is defined as an empty container in the restconf yang. So there's no way
to create a ContainerNode to represent the error-info data that conforms
to the schema. To work around this, I created a leaf node and special-cased
error-info in the stream writer to elide schema validation.

I also added a regression unit test for the case where the URL contains
an identityref.

Change-Id: I93b4aea25c829af1232d539180f02dd61e252d50
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
4 years agoBUG 2185 : Introduce the SwitchBehavior message 64/25164/2
Moiz Raja [Thu, 23 Jul 2015 03:34:30 +0000 (20:34 -0700)]
BUG 2185 : Introduce the SwitchBehavior message

RaftActor processes the SwitchBehavior message to change the behavior
Candidate and IsolatedLeader behaviors are not allowed.

Change-Id: Id8d758c6574a5c58927927b83bc5985081b19c50
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 26c4b15f6b55f012e7e7cf6e94d335386615af5c)

4 years agoBUG 2185 : Make the Custom Raft Policy externally configurable 10/24810/4
Moiz Raja [Wed, 22 Jul 2015 02:11:10 +0000 (19:11 -0700)]
BUG 2185 : Make the Custom Raft Policy externally configurable

A class which implements RaftPolicy needs to be set
to customize the behavior. I am hoping that this will be a barrier
to people unintentionally breaking the default raft policy as
they would need to know the internals of clustering in order to
supply a valid class.

I added two configurable raft policy classes for the two known
use cases,

- org.opendaylight.controller.cluster.datastore.policy.TestOnlyRaftPolicy
- org.opendaylight.controller.cluster.datastore.policy.TwoNodeClusterRaftPolicy.

Change-Id: Ic3cc2f27754c37e85c3be8a863764fc88ec84399
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 1ef2f7321202ef77b5cfd0ca430e6a58cb07331e)

4 years agofeatures-config is missing scope=test 45/26245/1
Robert Varga [Mon, 31 Aug 2015 16:41:29 +0000 (18:41 +0200)]
features-config is missing scope=test

opendaylight-karaf-empty is used only in tests, hence the dependency
should have a proper scope.

Change-Id: I54b7c84c4c732d63c49b251b960c511711470bbc
Signed-off-by: Robert Varga <rovarga@cisco.com>
4 years agoBug 2461 : Adding capture snapshot JMX operation. 32/26132/2
Harman Singh [Fri, 28 Aug 2015 01:28:23 +0000 (18:28 -0700)]
Bug 2461 : Adding capture snapshot JMX operation.

Also, updated Snapshot manager code, which may throw null pointer exception, if last log entry is null

Change-Id: I4363a3da38af99a4193b8ad2b1c0a5cbaf714a32
Signed-off-by: Harman Singh <harmasin@cisco.com>
4 years agoBUG 4212 : Follower should not reschedule election timeout in certain cases. 11/26111/5
Moiz Raja [Thu, 27 Aug 2015 17:34:36 +0000 (10:34 -0700)]
BUG 4212 : Follower should not reschedule election timeout in certain cases.

Before:
Follower rescheduled election whenever it received any message

Now:
Followe reschedules election only if
    - The message received is a RaftRPC message
    - If the RaftRPC message is a RequestVote then only reschedule
      if vote is granted

Change-Id: Ia59c65e4896d72dfc49e86e59b6a9e9331a945ca
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit bf63fbc347b7cf055e22c3711f22af9d286c6281)

4 years agoBUG 4213 : Candidate should switch to Follower when it receives AppendEntries from... 07/26107/1
Moiz Raja [Thu, 27 Aug 2015 18:07:08 +0000 (11:07 -0700)]
BUG 4213 : Candidate should switch to Follower when it receives AppendEntries from new Leader

Multiple peers might become candidates in a single election term. If one peer happened
to become a Leader it will send AppendEntries to all it's peers. When a Candidate receives
an AppendEntries and finds its term to be the same as the AppendEntries term then it should
switch to Follower.

Change-Id: Ia4ce41d4f3eefed50297b90107ad7429bb950ad8
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 6b66fc7266ea909427b612da16a587936890b77b)

4 years agoMoved non MD-SAL models outside of MD-SAL folder 75/25475/4
Tony Tkacik [Wed, 19 Aug 2015 12:35:34 +0000 (14:35 +0200)]
Moved non MD-SAL models outside of MD-SAL folder

This is just simple file movement without changing
group-ids and packages to better reflect their use.

This models are general purpose and are not part of MD-SAL,
but rather used on top of MD-SAL.

Change-Id: I4ed842ae878e5470ac16348a4f7e92231ae67f8e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoSwitched model-parent to use binding-parent. 74/25474/4
Tony Tkacik [Wed, 19 Aug 2015 12:29:33 +0000 (14:29 +0200)]
Switched model-parent to use binding-parent.

model-parent originaly used sal-parent which did not contained
sections necessary for model-only packages.

Switched to binding-parent, which actually simplifies pom
file.

Change-Id: I2efea28799dfbd541b2b12468a6aec3472dbb240
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoAdd missing odl-config-netty feature into odl-netconf-mdsal 32/25532/3
Tomas Cere [Thu, 20 Aug 2015 12:07:05 +0000 (14:07 +0200)]
Add missing odl-config-netty feature into odl-netconf-mdsal

Change-Id: I6a37e285f9fd74b24123830634a33dbcdfad3414
Signed-off-by: Tomas Cere <tcere@cisco.com>
4 years agoFix license header violations in controller 81/25881/2
Thanh Ha [Mon, 24 Aug 2015 14:12:28 +0000 (10:12 -0400)]
Fix license header violations in controller

Change-Id: I78161e69d30773bb4d8e7943316cd988e1a7b81b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoAdd missing messagebus-netconf dependency 83/25483/2
Tomas Cere [Wed, 19 Aug 2015 14:13:22 +0000 (16:13 +0200)]
Add missing messagebus-netconf dependency

features-netconf-connector was missing messagebus-netconf dependency
and breaking downstream projects.

Change-Id: Ife784fde73e590add08fcdec9027cc1784327beb
Signed-off-by: Tomas Cere <tcere@cisco.com>
4 years agoBug 4035: MD-SAL: Remove unused dependencies & declarations 63/24463/6
Tony Tkacik [Thu, 23 Jul 2015 09:09:25 +0000 (11:09 +0200)]
Bug 4035: MD-SAL: Remove unused dependencies & declarations

After config-related code movement some of the dependencies
& declarations are unnecesary anymore, which actually
simplifies pom files for affected components.

Removed unused import of binding config in restconf.

Change-Id: I83dd04c5ac161f45d246abbbe896ddb66b066fef
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoRemove unused MD-SAL utilities and interfaces. 77/24477/5
Tony Tkacik [Thu, 23 Jul 2015 13:48:06 +0000 (15:48 +0200)]
Remove unused MD-SAL utilities and interfaces.

This utilities & interfaces were deprecated before
Lithium or were describing internal contracts
of MD-SAL prior to Lithium, thus they are unneeded
in Beryllium.

None of removed classes is used in public Lithium
Opendaylight codebase.

Change-Id: Ie5f51cf3dc15f0f70efe3e51e0fe0d0c2b8da713
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoBug 4035: Remove deprecated Hydrogen interfaces 76/24476/5
Tony Tkacik [Thu, 23 Jul 2015 13:07:38 +0000 (15:07 +0200)]
Bug 4035: Remove deprecated Hydrogen interfaces

This remove set of interfaces which
is safe to remove without breaking projects which did not
yet migrated from Hydrogen interfaces to Helium / Lithium one.

Also removes some related methods in such interfaces which
are unused in current public Beryllium codebase in
projects using MD-SAL.

Change-Id: I2ac67ead4ea4d9d97d0198d62910e667318dc03a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoBug 4035: Fixed some sonar warnings in md.sal.binding.impl 13/19213/11
Tony Tkacik [Tue, 28 Apr 2015 13:41:05 +0000 (15:41 +0200)]
Bug 4035: Fixed some sonar warnings in md.sal.binding.impl

Change-Id: I7b850b65a7bfc40ef757115ae37a031fa88bebeb
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoBug 4035: Remove unused implementations from sal-common-impl 70/24470/5
Tony Tkacik [Thu, 23 Jul 2015 12:23:26 +0000 (14:23 +0200)]
Bug 4035: Remove unused implementations from sal-common-impl

Removed  left-overs from Hydrogen and Helium which are
not used anymore in Lithium codebase and will be unnecessary
in Beryllium codebase.

Removed classes were never part of public API contracts
outside of MD-SAL.

Change-Id: I2d19373b270e539598fe31b7e493db494b017100
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoBug 4035: Removed sal-common which is unused since Helium. 67/24467/8
Tony Tkacik [Thu, 23 Jul 2015 11:26:08 +0000 (13:26 +0200)]
Bug 4035: Removed sal-common which is unused since Helium.

Change-Id: Ia6e15cc1e94fcf5794a56fbf61d260644dcb457b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoBug 4035: Fixed some sonar / findbugs issues in DOM MD-SAL. 65/24465/9
Tony Tkacik [Thu, 23 Jul 2015 11:11:08 +0000 (13:11 +0200)]
Bug 4035: Fixed some sonar / findbugs issues in DOM MD-SAL.

Change-Id: Id0ab9f65e4f1663f9e6cd85a6235a0a5fdee6f88
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoBug 4035: Remove references to not present artefacts. 64/24464/7
Tony Tkacik [Thu, 23 Jul 2015 09:13:27 +0000 (11:13 +0200)]
Bug 4035: Remove references to not present artefacts.

Change-Id: Id0308a4b544572df16bf01b1742eed60246dde54
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoBug 4035: Extract dom-config from core-api and broker-impl 92/24392/9
Tony Tkacik [Wed, 22 Jul 2015 12:59:20 +0000 (14:59 +0200)]
Bug 4035: Extract dom-config from core-api and broker-impl

This patch introduces two new artefacts sal-dom-config
and sal-dom-broker-config which hosts all config subsystem
related MD-SAL DOM Broker implementation.

This patch is required for MD-SAL split in order to
not have cyclic dependency between controller and md-sal
project.

Change-Id: Ic93c583c07ae3e088dcf0e74cbdaaf627a8e79f6
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoEnabling Data Change Notifications for all nodes in cluster. 96/24496/6
Harman Singh [Fri, 24 Jul 2015 01:32:46 +0000 (18:32 -0700)]
Enabling Data Change Notifications for all nodes in cluster.

Two new interfaces are introduced ClusteredDataChangeListener and ClusteredDOMDataChangeListener and external applications will have to implement any of that interface,
if those applications want to listen to remote data change notifications.

Datastore registers listeners, which are instance of that interface, even on followers.

Change-Id: I0e29cdf2a08a2051de5fc8ce73b9ec8ac408e45b
Signed-off-by: Harman Singh <harmasin@cisco.com>
4 years agoRemoving missing features-base 68/25168/2
Thanh Ha [Tue, 11 Aug 2015 17:53:54 +0000 (13:53 -0400)]
Removing missing features-base

Change-Id: I2b841e5ba388c5c676e9d4da0b11b65c426cb5c7
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoRemoving the redundant configuration reader in the distributed datastore. 39/25139/3
kalaiselvik [Tue, 11 Aug 2015 06:46:16 +0000 (12:16 +0530)]
Removing the redundant configuration reader in the distributed datastore.
Having a common configuration reader in the clustering common for use
by both distributed datastore and remote rpc.

Change-Id: Id40295301d76dad40189fb45ffc2917260ba2925
Signed-off-by: kalaiselvik <Kalaiselvi_K@Dell.com>
4 years agoCDS: Include CAN_COMMIT phase in rate limiter time period 59/25259/1
Tom Pantelis [Thu, 2 Jul 2015 02:53:56 +0000 (22:53 -0400)]
CDS: Include CAN_COMMIT phase in rate limiter time period

I was testing with simulated latency in the followers. With a high enough
latency and tx thru-put, the pending commit queue in the
ShardCommitCoordinator got increasingly behind until latencies built up
enough to cause AskTimeoutExeption's on the front-end.

The rate limiter was throttling but not enough. I realized that the rate
limiter times the commit phase but not the canCommit phase. The latter is
what times out with pending tx's sitting in the queue waiting for canCommit.
So I changed ThreePhaseCommitCohortProxy to also time the canCommit
phase. This alleviated the timeouts - even with a really high max latency of
500 ms and 100 tx / sec client thru-put. The rate limiter thru-put
reduced it to about 3 / sec.

Change-Id: I6dc73d1d657519b9410ad034c69d26f19a0cb263
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit 1783b656d3b1712c73c6596f3ae15e54e801d5e5)

4 years agoDecouple message bus from netconf connector 12/24612/10
Tomas Cere [Thu, 13 Aug 2015 09:06:22 +0000 (11:06 +0200)]
Decouple message bus from netconf connector

Change-Id: I6a143e868adc1e5c7a9b114798e7009bb6ef8675
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Tomas Cere <tcere@cisco.com>
4 years agoDecouple config and netconf subsystems. 13/23413/26
Tomas Cere [Thu, 13 Aug 2015 09:06:54 +0000 (11:06 +0200)]
Decouple config and netconf subsystems.

Extract a common mapping for config pusher and config subsystem netconf
Add a ConfigPersisterFacade for XML that allows reads/writes from/to config
subsystem using XML format
Push notifications from YangStoreService to NetconfNotificationManager instead
of using custom listeners
Migrate netconf features from controller features, untangle features

Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca
Signed-off-by: Tomas Cere <tcere@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
4 years agoCDS: Add stress test RPC to the cars model 45/25145/1
Tom Pantelis [Tue, 7 Jul 2015 20:07:38 +0000 (16:07 -0400)]
CDS: Add stress test RPC to the cars model

For stress testing the CDS, I've been using an RPC that continuously
creates cars at a specified per second rate. I thought it might be
useful to submit it.

Change-Id: I33b9c2e304884b9541774a12ee248082de60f72e
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit b6a63eea6eb164a0c925716ae398bf64b06958c3)

4 years agoFix license header violations in liblldp 93/24993/1
Thanh Ha [Sun, 9 Aug 2015 05:44:50 +0000 (01:44 -0400)]
Fix license header violations in liblldp

Change-Id: Id95bd1cef35d256e79a3303c6559405364ae4ced
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in concepts 92/24992/1
Thanh Ha [Sun, 9 Aug 2015 05:39:31 +0000 (01:39 -0400)]
Fix license header violations in concepts

Change-Id: Ia575c2e64b4ce50990e0fadada34f257189c3370
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in mdsal-it-base 91/24991/1
Thanh Ha [Sun, 9 Aug 2015 05:36:42 +0000 (01:36 -0400)]
Fix license header violations in mdsal-it-base

Change-Id: I87d699dbf60cccc3445664fc23650c155d5cb229
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-binding-dom-it 90/24990/1
Thanh Ha [Sun, 9 Aug 2015 05:35:30 +0000 (01:35 -0400)]
Fix license header violations in sal-binding-dom-it

Change-Id: I542ab52fd8bdbedfee3e469c8672a7981340d153
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in messagebus 89/24989/1
Thanh Ha [Sun, 9 Aug 2015 05:34:42 +0000 (01:34 -0400)]
Fix license header violations in messagebus

Change-Id: I3b5f5b3e96716552562498590988097c5d3c1308
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-remoterpc-connector 88/24988/1
Thanh Ha [Sun, 9 Aug 2015 05:32:53 +0000 (01:32 -0400)]
Fix license header violations in sal-remoterpc-connector

Change-Id: I25d95f37c1ddd238bb79d15e2bf3e2d07069f319
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-karaf-xsql 87/24987/1
Thanh Ha [Sun, 9 Aug 2015 05:30:11 +0000 (01:30 -0400)]
Fix license header violations in sal-karaf-xsql

Change-Id: I756176da2ef6f617298ef1474a08ab3707b8c0d2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-dom-xsql 86/24986/1
Thanh Ha [Sun, 9 Aug 2015 05:29:11 +0000 (01:29 -0400)]
Fix license header violations in sal-dom-xsql

Change-Id: I4fbbbdf7c3aa280f20efe6ffe6c0a0571b6a38a0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-distributed-datastore 85/24985/1
Thanh Ha [Sun, 9 Aug 2015 05:19:52 +0000 (01:19 -0400)]
Fix license header violations in sal-distributed-datastore

Change-Id: I519e80cb6329f752b6b533de067ea3fd6277bedf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-akka-raft 84/24984/1
Thanh Ha [Sun, 9 Aug 2015 01:48:01 +0000 (21:48 -0400)]
Fix license header violations in sal-akka-raft

Change-Id: I03efdc517a21827e27ebdb359384c575f975ff4c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-clustering-commons 83/24983/1
Thanh Ha [Sun, 9 Aug 2015 01:26:24 +0000 (21:26 -0400)]
Fix license header violations in sal-clustering-commons

Change-Id: I1b76464cd875fdaaedeebc22cf35cae11714990d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-rest-docgen 82/24982/1
Thanh Ha [Sun, 9 Aug 2015 01:22:15 +0000 (21:22 -0400)]
Fix license header violations in sal-rest-docgen

Change-Id: I03c4b7ef9397224d649e9387ed895bca74672ec9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-netconf-connector 81/24981/1
Thanh Ha [Sun, 9 Aug 2015 01:20:30 +0000 (21:20 -0400)]
Fix license header violations in sal-netconf-connector

Change-Id: I8235e1cbe1ed7bce9d017276dd6d9f4fb26ead70
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-rest-connector 80/24980/1
Thanh Ha [Sun, 9 Aug 2015 01:09:32 +0000 (21:09 -0400)]
Fix license header violations in sal-rest-connector

Change-Id: I2dfda9fe6b3185d20386cc9f6078c0b53f7be40b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in netconf 69/24969/2
Thanh Ha [Sat, 8 Aug 2015 06:12:29 +0000 (02:12 -0400)]
Fix license header violations in netconf

Change-Id: Ie5c541b03a342bec33257b13b985b89e9ca835a0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in config-it-base 79/24979/1
Thanh Ha [Sun, 9 Aug 2015 00:52:27 +0000 (20:52 -0400)]
Fix license header violations in config-it-base

Change-Id: Ida3d92c44afe0e8dd52e1ecc6c4130d6b81697eb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in config-persister-file-xml-adapter 78/24978/2
Thanh Ha [Sun, 9 Aug 2015 00:43:31 +0000 (20:43 -0400)]
Fix license header violations in config-persister-file-xml-adapter

Change-Id: I2b3bd61dedfb1d178754fe899acc4657e527daa5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in config-manager 68/24968/1
Thanh Ha [Sat, 8 Aug 2015 06:10:54 +0000 (02:10 -0400)]
Fix license header violations in config-manager

Change-Id: I8144512cd8093fbcc0851de66490f866ec8bb7c4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in config-util 67/24967/1
Thanh Ha [Sat, 8 Aug 2015 06:07:13 +0000 (02:07 -0400)]
Fix license header violations in config-util

Change-Id: I0c6868425ca51d9b815b4e961316e4a009502374
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in toaster-provider 66/24966/1
Thanh Ha [Sat, 8 Aug 2015 06:05:16 +0000 (02:05 -0400)]
Fix license header violations in toaster-provider

Change-Id: I90d2fe2487789796e173e116a81edda40e7a1385
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in toaster-consumer 65/24965/1
Thanh Ha [Sat, 8 Aug 2015 06:03:10 +0000 (02:03 -0400)]
Fix license header violations in toaster-consumer

Change-Id: Ib522fe2ed5a47fefaed18554badde343368f306d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-binding-broker 64/24964/1
Thanh Ha [Sat, 8 Aug 2015 06:00:33 +0000 (02:00 -0400)]
Fix license header violations in sal-binding-broker

Change-Id: If6b75f466f97149ce4f0290135a754ca6cba1034
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-dom-broker 63/24963/1
Thanh Ha [Sat, 8 Aug 2015 05:53:27 +0000 (01:53 -0400)]
Fix license header violations in sal-dom-broker

Change-Id: I78a5b836b7ea5053ede25a31e8a40319d365fe60
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-inmemory-datastore 62/24962/1
Thanh Ha [Sat, 8 Aug 2015 05:45:08 +0000 (01:45 -0400)]
Fix license header violations in sal-inmemory-datastore

Change-Id: I160d107a813c28ac75f1e5e21121068de9ccc7b8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-binding-api 61/24961/1
Thanh Ha [Sat, 8 Aug 2015 05:43:04 +0000 (01:43 -0400)]
Fix license header violations in sal-binding-api

Change-Id: I877608c114bf4479c760f5b5dafed5d100d12cf5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-dom-spi 60/24960/1
Thanh Ha [Sat, 8 Aug 2015 05:41:23 +0000 (01:41 -0400)]
Fix license header violations in sal-dom-spi

Change-Id: I82f4796c933a6cec89950d4c474a0053637b2646
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-dom-api 59/24959/1
Thanh Ha [Sat, 8 Aug 2015 05:39:55 +0000 (01:39 -0400)]
Fix license header violations in sal-dom-api

Change-Id: I08a3d973bb56d6ee267576b691a32bfe27db6820
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-common-impl 58/24958/1
Thanh Ha [Sat, 8 Aug 2015 05:19:29 +0000 (01:19 -0400)]
Fix license header violations in sal-common-impl

Change-Id: I0702d7954d59f92ab62f6887a780db8a80f42ffa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in sal-common-api 57/24957/1
Thanh Ha [Sat, 8 Aug 2015 05:17:07 +0000 (01:17 -0400)]
Fix license header violations in sal-common-api

Change-Id: I58fdef120495514ef94f2e9681790786ba4e0841
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in yang-jmx-generator-plugin 56/24956/1
Thanh Ha [Sat, 8 Aug 2015 05:14:51 +0000 (01:14 -0400)]
Fix license header violations in yang-jmx-generator-plugin

Change-Id: Iac866a580e9d07e9f2614a7c5c25e91e755cb4ba
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix license header violations in config-api 55/24955/1
Thanh Ha [Sat, 8 Aug 2015 05:08:58 +0000 (01:08 -0400)]
Fix license header violations in config-api

Change-Id: I61723cf4794fbbc16549f06f284b8f1dacbce588
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoClean up pom.xml file 52/24852/2
Thanh Ha [Thu, 6 Aug 2015 05:23:10 +0000 (01:23 -0400)]
Clean up pom.xml file

- Remove unnecessary commented code

Change-Id: Id4ceca0174ba5883059c52cbcee11aafb67c74ea
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoFix akka logging initialization timeout on startup 83/24883/1
Tom Pantelis [Wed, 5 Aug 2015 22:57:22 +0000 (18:57 -0400)]
Fix akka logging initialization timeout on startup

We've seen CDS internittently failing to startup b/c akka fails to
initialize its logging system - it times out after 5 sec. It seems
on startup threads may be busy enough to prevent akka's message
to inialize the logging actor to timeout. Interestingly, We're only
seeing this on RedHat. The timeout is configured via
logger-startup-timeout which defaults to 5 sec. Increasing it fixes
the issue. I made it really high, 5 min, since if it times out we're
dead in the water anyway.

Change-Id: Ic95d7298b9320f03f664e9f2b171f980546ca95d
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit 94c2eb2becdb561032e62a2897b15f52bd8e3643)

4 years agoSeparation of ARP Responder from config.ini. It is an l3.fwd associated feature enabl... 56/22056/5
evvy [Thu, 11 Jun 2015 20:42:57 +0000 (02:12 +0530)]
Separation of ARP Responder from config.ini. It is an l3.fwd associated feature enabled by default

Change-Id: Ie29a751bcb372ef2f3dfd6b8f5e3ca7531359310
Signed-off-by: evvy <dhiraviam.natarajan@gmail.com>
4 years agoSmall fix to IT in startup archetype. 28/24728/1
Ed Warnicke [Mon, 3 Aug 2015 16:49:27 +0000 (09:49 -0700)]
Small fix to IT in startup archetype.

Change-Id: I3407e23af6228bbe7d881f9b9884e698186f533e
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
4 years agoAdd yangui to -ui features in startup archetype. 63/24563/4
Ed Warnicke [Sun, 26 Jul 2015 19:01:45 +0000 (12:01 -0700)]
Add yangui to -ui features in startup archetype.

Change-Id: Iaf3fb8d5c92615c97e65ae572affeea5094ee472
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
4 years agoChanges to startup archetype to incorporate IT testing 59/24559/7
Ed Warnicke [Sat, 25 Jul 2015 21:42:37 +0000 (14:42 -0700)]
Changes to startup archetype to incorporate IT testing

Note: The onSessionInitiated unit test can't every really work in a
realistic system because of the absence of an MD-SAL to work with,
thus its deleted so people can build real MD-SAL based Providers.

Change-Id: Ie635752b6e2eec8ce1c65b737871be8c0b6bd870
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
4 years agoBase projects and parents for IT tests. 94/16294/13
Ed Warnicke [Wed, 11 Mar 2015 00:31:03 +0000 (17:31 -0700)]
Base projects and parents for IT tests.

This provides a very very simple working basis for IT tests.

Change-Id: I16fae750c32ffe6fce356c8036b6d74988aa4f99
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
4 years agoFix AppendEntry logic when prevLogIndex and prevLogTerm is -1 46/24546/2
Moiz Raja [Mon, 13 Jul 2015 20:31:42 +0000 (13:31 -0700)]
Fix AppendEntry logic when prevLogIndex and prevLogTerm is -1

When an AppendEntry arrives at a Follower with the prevLogIndex and
prevLogTerm = -1 the Follower will accept that append entry and add it
to the log. For a newly started Follower this can be problematic
because this will be the first entry in that Followers log and so
applying this entry to the Follower's state can end up corrupting the
state or cause failures in committing transactions.

To fix this we now verify if the replicatedToAllIndex is present in the
Followers log. If it is present then the log is considered in sync else
not.

Change-Id: I09bead430f1a4556182263de54846792668cd27c
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 0efdc8e538815024cc54955be0b55ebec0321be6)

4 years agoBUG 2185 : Introduce RaftPolicy & DefaultRaftPolicy 49/24549/1
Moiz Raja [Tue, 21 Jul 2015 23:42:47 +0000 (16:42 -0700)]
BUG 2185 : Introduce RaftPolicy & DefaultRaftPolicy

These allow for simple customization of the Raft algorithm. The intention is
to support the 2-Node clustering scenario in which leaders for a Shard will need
to be specified externally and where weak(er) consistency may be considered ok

Change-Id: I16bc69a67ac3096082324f11e62565a7b9d7cc57
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit 0717961816253536d0ca107f4094de7f00c1ee54)

4 years agoBug 4035: Invert dependency binding-impl -> binding-config 85/24385/6
Tony Tkacik [Wed, 22 Jul 2015 09:24:03 +0000 (11:24 +0200)]
Bug 4035: Invert dependency binding-impl -> binding-config

Dependency between sal-binding-broker-impl and sal-binding-config
was inverted in order to ease split-off and to provide config
wiring outside of implementation.

This is required for separation of MD-SAL Binding implementation
into MD-SAL Project.

Change-Id: Id18567b2c51045461ed12500fe5cb2f324f55b0c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoExpose default module instances into OSGi 86/24186/2
Maros Marsalek [Thu, 16 Jul 2015 08:56:09 +0000 (10:56 +0200)]
Expose default module instances into OSGi

Default modules are now registered as services in config subsystem thus making
them available in the OSGi service registry.

Change-Id: I2a3b85ea6aab0d9c98d0b5dfb5b8efd392292042
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
4 years agoAdd config subsystem binding to netconf-auth API 85/24185/2
Maros Marsalek [Wed, 15 Jul 2015 13:20:08 +0000 (15:20 +0200)]
Add config subsystem binding to netconf-auth API

Change-Id: Ie04d9a7cb72bfcbeae6c7ca7dc0dbb2bdeadef0d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
4 years agoBug 2358 - Remove tests cnsn to json and add tests nn to json 18/22618/6
Jakub Toth [Wed, 27 May 2015 09:41:45 +0000 (11:41 +0200)]
Bug 2358 - Remove tests cnsn to json and add tests nn to json

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove CnSnToJsonNotExistingLeafTypeTest.java test
* add NnToJsonNotExistingLeafTypeTest.java to nn/to/json/test/
  * test with not existing leaf type

Change-Id: Id7a1256b42a3a754e13343613dcad7059a2316c4
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 1fa839d51563b9588bf7502e86a5e9c2425fab2f)

4 years agoBug 2358 - Remove tests cnsn to json and add tests nn to json 17/22617/6
Jakub Toth [Wed, 27 May 2015 10:44:31 +0000 (12:44 +0200)]
Bug 2358 - Remove tests cnsn to json and add tests nn to json

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove CnSnToJsonWithAugmentTest test
* add NnToJsonWithAugmentTest to nn/to/json/test/
  * positive test for test augmented elements

Change-Id: I4c8b92e828ade1d43a5af5384ec7938854fda9ce
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit 6b97753fc17bb2d9d73047038105754fcebe029d)

4 years agoBug 2358 - Remove tests json to cnsn and add tests json to nn 90/19290/7
ary [Wed, 29 Apr 2015 10:09:41 +0000 (12:09 +0200)]
Bug 2358 - Remove tests json to cnsn and add tests json to nn

Tests of codecs are included in codecs yangtools yang-data-codec-gson and yang-data-impl but
we test codec on input data and also with presentation of Rest path.

* remove all tests json to composite node and simple node
* rewrite json leafref input tests from comp and simple node to normalized node
  * we're testing REST provider URI path translator with payload
* add test for test data in json with identityref to normalized node
  * positive test
  * test data in builded normalized node with data in json
    * used identityref type to reference an existing identity
* add test for test data in json with leafref to normalized node
  * positive test
  * test data in builded normalized node with data in json
    * used leafref type to reference particular leaf instance in the data tree
* add test for test data in json with more type of nodes and values
  * positive tests
    * test normalized node from json with:
      * simple data in list
      * simple data in container
      * multiple items in leaf-list
      * multiple items in list
      * empty leaf
      * augmented data
  * negative tests
    * test fail on bad top level elements
      * contains 3 situations
    * test fail for null data
      * empty leaf-list
      * leaf without any value
    * test on build normalized node with blank json
    * test fail with different namespaces
    * test fail because of unsupported format of json
    * test on invalid URI character

Change-Id: Icb5ff5d11843123c79859a0c75d7df7bad8a0b44
Signed-off-by: Jakub Toth <jatoth@cisco.com>
(cherry picked from commit a3fd2b66c8121a8603d684b97c1fb7076d933d99)

4 years agoCLEANUP : Fix javadoc warnings in sal-akka-raft code 53/24453/1
Moiz Raja [Wed, 22 Jul 2015 00:23:19 +0000 (17:23 -0700)]
CLEANUP : Fix javadoc warnings in sal-akka-raft code

Change-Id: Id26cdcac3c4bc7f998483e4078cd1891d0783e8d
Signed-off-by: Moiz Raja <moraja@cisco.com>
(cherry picked from commit a6db8d8fcb55e6b9a7a2102c9ec0b7e8ba752b50)

4 years agoFixed wrong format in ShardedDOMDataTree 91/18991/4
Tony Tkacik [Thu, 23 Apr 2015 14:09:28 +0000 (16:09 +0200)]
Fixed wrong format in ShardedDOMDataTree

Change-Id: Ie32ff9ad72e4bbae9a5ef1290ff63d5780c92313
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
4 years agoRemove deprecated constructors from RemoteDeviceId 99/24099/5
Maros Marsalek [Tue, 14 Jul 2015 12:26:15 +0000 (14:26 +0200)]
Remove deprecated constructors from RemoteDeviceId

Change-Id: I26d48930a16213d2264de964f60103e67f80b9bd
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
4 years agoImprove performance of notification emitting in netconf testtool 26/23826/2
Maros Marsalek [Mon, 8 Jun 2015 15:22:45 +0000 (17:22 +0200)]
Improve performance of notification emitting in netconf testtool

- pre-parse all notifications beforehand
- remove unwanted outputs

Change-Id: I6dd823786fd0d5f9ab04943633f8aa3b61a540e8
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit 7392728edfe0b150833c7af47c3bc8d4b0ce101a)

4 years agoImprove performance of netconf notification processing 21/23721/3
Maros Marsalek [Mon, 8 Jun 2015 15:21:22 +0000 (17:21 +0200)]
Improve performance of netconf notification processing

Couple of minor performance fixes e.g:
- create QName without revision when not needed
- delete unnecessary logs
- parse event time using QName.parseRevision

Change-Id: Ic099e40fb5fdb7001af946e5f3e053911e54053f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit 07797c1f8e35731ca7dce1d4524f669a171b731e)

4 years agoBug 3887 - Autogenerated API documentation doesn't show application/xml 78/24378/2
Jan Hajnar [Wed, 1 Jul 2015 09:03:44 +0000 (11:03 +0200)]
Bug 3887 - Autogenerated API documentation doesn't show application/xml
as an option for RPC operations

* added xml input option for rpcs, put and post methods

Change-Id: I1f73bcb7d1127e4b4324d779aec40907ca627073
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
(cherry picked from commit e57d9461b79dedd8ef9edf8f249b066540fd0e9d)

4 years agoBUG-3963 Remove netconf-usermanager 92/24092/2
Maros Marsalek [Tue, 14 Jul 2015 08:56:59 +0000 (10:56 +0200)]
BUG-3963 Remove netconf-usermanager

This way of authentication relied on AD-SAL and thats deprecated/removed now
from ODL.

Change-Id: I0daeee09ff88b1c4677206c1b7216e972d34f01c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
4 years agoBUG-2652: Remove inventory related code from netconf connector 65/23165/2
Tomas Cere [Tue, 23 Jun 2015 13:16:39 +0000 (15:16 +0200)]
BUG-2652: Remove inventory related code from netconf connector

Also removed unused BundleContext fields since registerProvider
method does not use BundleContext anymore.

Change-Id: Ia5bc5b7148a981b5a132676dd78bc351b637d9d1
Signed-off-by: Tomas Cere <tcere@cisco.com>
4 years agoBug 1500 - Null pointer exception when using mounted resources tab to 07/23807/2
Jan Hajnar [Tue, 7 Jul 2015 09:38:33 +0000 (11:38 +0200)]
Bug 1500 - Null pointer exception when using mounted resources tab to
see the operations on mount point

* added check for when revision is null in modules comparator

Change-Id: I3bdc4ed798297d31ea25001d25918e298c8124bb
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
4 years agoBUG-3878 Prevent null pointer in nc for unresolved addresses 95/24095/4
Maros Marsalek [Tue, 14 Jul 2015 11:27:23 +0000 (13:27 +0200)]
BUG-3878 Prevent null pointer in nc for unresolved addresses

Unresolved address is not a reason for config pusher failure. Use host string
instead of resolved address string representation.

Change-Id: Ieba345077860cd55325ca49980c3fb9edd66051c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
4 years agoCDS: Changes to Tx abort in Shard 62/24262/2
Tom Pantelis [Wed, 1 Jul 2015 22:59:51 +0000 (18:59 -0400)]
CDS: Changes to Tx abort in Shard

I noticed when a tx times out on the front-end during CAN_COMMIT, it
tries to abort the tx but it may not get aborted in the Shard and the
front-end gets an AskTimeoutEx on the abort. The reason is that the
Shard only processes the abort request if the tx is the current tx being
committed. If it isn't, the request is ignored and no response is sent,
resulting in the front-end timeout.

I think it makes sense to also process the abort if the tx is sitting in
the queue awaiting CAN_COMMIT. If the front-end says to abort for any
reason, the Shard should honor it. Also, if it isn't aborted, the Shard
may dequeue it sometime later and attempt to commit it which can lead to
unpredictable results if prior commits failed.

As per the comments in the Helium patch, I did some re-factoring to make
it a bit cleaner. I moved the abort code from the Shard to the
ShardCommitCoordinator. This makes it consistent with the other tx
phases where the Shard mostly delegates to the ShardCommitCoordinator. I
also removed the getCohort method from CohortEntry and added appropriate
methods so the internal cohort instance isn't exposed.

There's more refactoring/cleanup that can be done re: Futures and also
moving CohortEntry into its own class (it's large enough) but I don't
want to overload this patch.

Change-Id: I73c79a5e4a2b39b7ee4d97a011de2d29b050dbc4
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit 70e0f223f41ab77de24b6df940d12acd39279e9a)

4 years agoCDS: Retry remote front-end transactions on AskTimeoutException 61/24261/2
Tom Pantelis [Wed, 1 Jul 2015 20:28:43 +0000 (16:28 -0400)]
CDS: Retry remote front-end transactions on AskTimeoutException

With the front-end PrimaryShardInfo cache, if the cached primary/leader
shard is remote and unavailable, the RemoteTransactionContextSupport
will fail with an AskTimeoutException when it tries to send the
CreateTransaction message. Since it can take at least 1 election timeout
period to re-elect a new leader, I changed RemoteTransactionContextSupport
to also retry on AskTimeoutException (it already retries on
NoShardLeaderException). However instead of re-sending the
CreateTransaction message, as it did before, it now re-sends the
FindPrimary message to get a new primary shard actor.

I also modified how RemoteTransactionContextSupport retries. It will now
retry for a total period of 2 times the shard election timeout which
should be ample time for a re-election to occur. If no leader is found then
the txn will fail.

I also added a ShardLeaderNotRespondingException which the
RemoteTransactionContextSupport will throw if it ends up with an
AskTimeoutException after the tx creation timeout period. This shouldn't
occur normally as, with the retries, it should get a NoShardLeaderException
even if the initial error was AskTimeoutException. But it's possible to
end up with an AskTimeoutException, eg if the system is overloaded and
the election timeout is delayed.

During testing, I noticed that if you take down the 2 followers and try
a transaction, it fails with an AskTimeoutEx instead of
NoShardLeaderException as one would expect. This is b/c the leader
changes to an isolated leader. So I changed the Shardanager to return
NoShardLeaderException if the state is IsolatedLeader.

Change-Id: I3efd3f841cf41b7738aedb694fa18b44851b3074
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit 845609758d1739ee07d5ca92f5448e18a8933861)

4 years agoCDS: Real snapshot log trimming changes 60/24260/2
Tom Pantelis [Fri, 10 Jul 2015 12:30:11 +0000 (08:30 -0400)]
CDS: Real snapshot log trimming changes

Bug 2692 changed real snapshotting to trim the in-memory log based on
the current replicatedToAllIndex for the normal case when all follower's
are up and "fake" snapshotting is advancing replicatedToAllIndex.

When a follower is down, real snapshots don't trim the log b/c
replicatedToAllIndex isn't advancing unless the memory threshold is
exceeded. So it will let the in-memory log keep growing past the
snapshot batch count. This sort of defeats the purpose of snapshotting,
ie to keep the journal size in check both on disk and in memory. It's
also a bit dangerous - it can chew up a lot of memory and starve the
rest of the system and cause large STW GC's once the follower comes
back up and the log is cleared. This can also cause multiple snapshots
in the follower once it comes back and catches up - eg, if it's behind
60K entries, it will snapshot after each 20K batch in quick succession.

To alleviate the potential excessive memory growth, in addition to
trimming the log from the captured lastAppliedIndex if the log memory
size threshold is exceeded, I changed the code to do the same if the log
size exceeds the snapshot batch count. So if a follower is down long
enough to exceed the snapshot batch count, the leader will install a
single snapshot to catch up the follower. Otherwise, the follower will
be caught up via AppendEntries.

I also noticed that if snapshot tries happen in quick succession, a
second attempt may be tried prematurely while the previous one is in
the PERSISTING state. This is b/c isCapturing() returns false in the
PERSISTING state. The state machine prevents another capture from
actually initiating b/c only the IDLE state implements capture but I
think to be clean we should disallow it by returning true from
isCapturing() in the PERSISTING state. This avoids state violations
during valid workflows (it's not invalid to attempt a capture while
another is in progress). Therefore, since every state now returns true
for isCapturing() except IDLE, I made true the default in
AbstractSnapshotState so only IDLE overrides it.

I added more end-to-end test cases to
ReplicationAndSnapshotsWithLaggingFollowerIntegrationTest to cover
leader snapshots where the log size exceeds the snapshotBatchCount,
where the memory threshold is exceeded and where neither of the first
2 conditions are met and the log is effectively not trimmed. The former
2 cases trim the log to last applied and result in a snapshot installed on
the follower once it's resumed. The latter case results in the leader
catching up the follower via AppendEntries.

Change-Id: Iaec9ba94232a17d6fa7b192c31c431b328e3d22e
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit 7a992a25fa34c6ce4a1d52919f7aa71dd1d20060)

4 years agoAdd netconf-mapping-api test for HandlingPriority 63/23163/3
Tomas Cere [Tue, 23 Jun 2015 09:35:50 +0000 (11:35 +0200)]
Add netconf-mapping-api test for HandlingPriority

Change-Id: I29a6fdaab266acd42c5355101769bb82c14135fc
Signed-off-by: Tomas Cere <tcere@cisco.com>
4 years agoAdd discardChanges branch to unit test 62/23162/3
Tomas Cere [Mon, 22 Jun 2015 12:57:09 +0000 (14:57 +0200)]
Add discardChanges branch to unit test

Add service instance deletion to NetconfMappingTest

Change-Id: I25d1ebefde86050c42a2d43ec445feaf8d5889de
Signed-off-by: Tomas Cere <tcere@cisco.com>
4 years agoAdd netconf-cli and netconf-testtool to sonar exclusions. 60/23060/4
Tomas Cere [Mon, 22 Jun 2015 09:01:37 +0000 (11:01 +0200)]
Add netconf-cli and netconf-testtool to sonar exclusions.

Change-Id: Ibdaf3eada4828c8120c1c280fc2f326c9d0173ef
Signed-off-by: Tomas Cere <tcere@cisco.com>
4 years agoAdd controller default JVM options 79/17379/5
Thanh Ha [Mon, 30 Mar 2015 17:47:53 +0000 (13:47 -0400)]
Add controller default JVM options

Maven 3.3.1 has a new feature which lets us configure default
commandline options per project. This patch takes advantage of the new
feature so that Controller devs using the Maven 3.3.1+ no longer have
to export MAVEN_OPTS.

http://blog.soebes.de/blog/2015/03/17/apache-maven-3-dot-3-1-features/

Change-Id: Ic42840b5778bd8a421997f6e22df4a74f56210f7
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
4 years agoRemove yang-data-operations dependencies 88/24088/1
Maros Marsalek [Tue, 14 Jul 2015 08:41:56 +0000 (10:41 +0200)]
Remove yang-data-operations dependencies

Not used anymore

Change-Id: I692bdbc00efb38bb29d7f5c18ca042bc10eeb11f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
4 years agoCDS: Add pending tx queue size to ShardStats 08/24008/1
Tom Pantelis [Wed, 1 Jul 2015 20:58:28 +0000 (16:58 -0400)]
CDS: Add pending tx queue size to ShardStats

To aid debugging, I added the pending commit queue size of the
ShardCommitCoordinator to the ShardStats bean.

Change-Id: I2af3493eb5dd54f9f9406b0a005d66be004c12ff
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit 5fc8785d919cd3cad92036b1add1a7fdd25bf715)

4 years agoBug 3195: Cleanup on error paths and error handling 11/23911/2
Tom Pantelis [Mon, 15 Jun 2015 23:38:06 +0000 (19:38 -0400)]
Bug 3195: Cleanup on error paths and error handling

Modified ShardCommitCoordinator#handleBatchedModifications to remove the
cohortEntry from the cache if the total messages sent doesn't match the
total received.

With recent yangtools changes, write and merge on a DOM tx can throw
unchecked exceptions if he data is invalid. Modified the front-end
local tx path to catch unchecked exceptions in LocalTransactionContext
and propagate to the LocalThreePhaseCommit to immediately fail the
ready.

Similarly modified ShardCommitCoordinator#handleBatchedModifications to
handle unchecked exceptions from applied operations and propagate when
the tx is readied.

Added unit tests to cover these cases.

Also, modified LocalTransactionContext#readyTransaction to handle
unchecked exceptions from the DOM tx ready.

Change-Id: Ib6fe6e04b8626bf996cfabfe74da780f05ce838a
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit 3cd149e98ed5260b46006ff474bebe96f198756f)

4 years agoCDS: Change operationTimeout units to millis 84/23884/2
Tom Pantelis [Wed, 1 Jul 2015 20:21:35 +0000 (16:21 -0400)]
CDS: Change operationTimeout units to millis

For upcoming changes, I'll need to be able to set the operationTimeout
in millis for unit tests.

Change-Id: I7463a9b2e20db2b678e23a94cafd768db3ac099e
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
(cherry picked from commit f428caf33164fedd3dbfe06aad4814c06913e883)

4 years agoBug 868 - Continuous: remove deprecated APIs 16/22616/3
Jan Hajnar [Wed, 10 Jun 2015 11:55:42 +0000 (13:55 +0200)]
Bug 868 - Continuous: remove deprecated APIs

* removed deprecated API from Bug3595Test

Change-Id: Ic8f987aeb000cfb150286ad44e478771e8a52384
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
(cherry picked from commit e1b79358817f1202c50f7410b92746b0777d0642)

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.