controller.git
3 months agoDo not depend directly on mdsal-binding-dom-codec 72/100872/1
Robert Varga [Thu, 28 Apr 2022 17:34:35 +0000 (19:34 +0200)]
Do not depend directly on mdsal-binding-dom-codec

Depend on the API package, not the entire codec.

Change-Id: Ibcb0e8187cbf9bbca179ebe93b25bde56098b24c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoFixup version mis-bump 38/100838/1
Robert Varga [Wed, 27 Apr 2022 14:01:39 +0000 (16:01 +0200)]
Fixup version mis-bump

We have missed the config artifacts, bump them to 0.17.0-SNAPSHOT.

Change-Id: I5ac96840f6d567b02679b287c48c44c5550ad3ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump upstreams to snapshots 27/100827/7
Robert Varga [Tue, 26 Apr 2022 19:26:37 +0000 (21:26 +0200)]
Bump upstreams to snapshots

Adopt:
- odlparent-11.0.0-SNAPSHOT
- yangtools-9.0.0-SNAPSHOT
- mdsal-10.0.0-SNAPSHOT

Also adjust to identity mapping change by referencing .VALUE instead of
.class.

Change-Id: Idf2e4a845aa20ec029708a174e2787490170a927
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoDo not implement concepts.Builder 36/100836/1
Robert Varga [Wed, 27 Apr 2022 09:21:44 +0000 (11:21 +0200)]
Do not implement concepts.Builder

concepts.Builder is going away, do not implement it.

Change-Id: I1f1f8d72965225f4342c52b0602f8266109700a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump versions to 6.0.0-SNAPSHOT 26/100826/2
Robert Varga [Tue, 26 Apr 2022 19:24:47 +0000 (21:24 +0200)]
Bump versions to 6.0.0-SNAPSHOT

This starts the next major development iteration.

Change-Id: I83abc669c47abc5142f9cfb41e7a886b651b94c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoImprove SegmentedJournalActor logging 25/100825/2
Robert Varga [Tue, 26 Apr 2022 19:22:58 +0000 (21:22 +0200)]
Improve SegmentedJournalActor logging

Log timing around journal open and each write message. Also include
the number of bytes written in each message, so there is a correlation.

JIRA: CONTROLLER-2043
Change-Id: I27bb6bc6edf0baf4ec0b3ec0d07f6bfd1adf867e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoCorrect tracing arguments 24/100824/2
Robert Varga [Tue, 26 Apr 2022 16:21:57 +0000 (18:21 +0200)]
Correct tracing arguments

We have arguments switched around, resulting in a confusing message.
Fix that up.

JIRA: CONTROLLER-2043
Change-Id: I7f99b8665a1790aa9fd9d5607bfb44c69cf2a03d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump versions to 5.0.4-SNAPSHOT 81/100781/1
Robert Varga [Sun, 24 Apr 2022 19:32:12 +0000 (21:32 +0200)]
Bump versions to 5.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I950d01305027fccb4fc70162457d75d6ca8f2f8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoHandle the case when newModification() fails 57/100657/9
Robert Varga [Tue, 19 Apr 2022 20:53:18 +0000 (22:53 +0200)]
Handle the case when newModification() fails

When we are chaining DataTreeModification on top of each other, it is
possible that we have an invalid modification, which fails to apply. In
that case there is nothing we can do, as we cannot establish a baseline.

Handle this case by allocating a specialized modification
implementation, which allows close to no interactions.

JIRA: CONTROLLER-2039
Change-Id: I9b55da7ccc89c9aeae641a049397d2120e292a9c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoFail read requests after we have observed a modification failure 65/100765/7
Robert Varga [Sun, 24 Apr 2022 08:16:42 +0000 (10:16 +0200)]
Fail read requests after we have observed a modification failure

A local RW transaction can intercept a modification. If this happens, we
postpone the failure until commit time, but we must not allow further
reads to be satisfied, as they may end up returning incorrect data.

JIRA: CONTROLLER-2041
Change-Id: Ic1bb4c33b786e5926022125be8ee66aebfafee87
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoCleanup Local*ProxyTransactionTest 76/100776/2
Robert Varga [Sun, 24 Apr 2022 16:26:06 +0000 (18:26 +0200)]
Cleanup Local*ProxyTransactionTest

Do not use expected exceptions and use static imports for asserts.

Change-Id: Ib7838b36683b9e1d2042f1832272b88a0195cef6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoImprove IdentifiablePayload.toString() implementations 75/100775/3
Robert Varga [Sun, 24 Apr 2022 16:01:13 +0000 (18:01 +0200)]
Improve IdentifiablePayload.toString() implementations

We can expose at least the size (and most of the time identity) of the
payload. Let's do that to ease debugging.

JIRA: CONTROLLER-2043
Change-Id: Ia0f1e17ca46de8a9d117d5f8bdb85b246e32be01
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoAdd more tracing to DataJournalV0 74/100774/2
Robert Varga [Sun, 24 Apr 2022 14:58:40 +0000 (16:58 +0200)]
Add more tracing to DataJournalV0

We seem to have a problem with completing a specific write, add a few
more traces to try to pin the problem down.

JIRA: CONTROLLER-2043
Change-Id: I9efb37fd40e48ff81c988da7edcb0ae0010f7baf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoCompare messages in the log 73/100773/1
Robert Varga [Sun, 24 Apr 2022 13:54:04 +0000 (15:54 +0200)]
Compare messages in the log

Make sure we have the distinction between reordered messages and
messages getting missed.

JIRA: CONTROLLER-2024
Change-Id: If1f65eaa93b71911dcf197f8b053282f6ea0303c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump atomix to 3.1.12 72/100772/2
Robert Varga [Sun, 24 Apr 2022 12:45:36 +0000 (14:45 +0200)]
Bump atomix to 3.1.12

I could not find any release notes, so all we have is
https://github.com/atomix/atomix/compare/atomix-3.1.5...atomix-3.1.12

Of that only
https://github.com/atomix/atomix/commit/4a65503db2c810df7aa9f9b1dc0aec4debe21380
seems relevant.

Change-Id: Ifdefc9a5c00b1acb3db2e141b0c63fc74ef4513c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoRoute {Journal,Snapshot}Protocol messages to DataPersistenceProvider 69/100769/1
Robert Varga [Sun, 24 Apr 2022 11:17:15 +0000 (13:17 +0200)]
Route {Journal,Snapshot}Protocol messages to DataPersistenceProvider

The way we wire our messages ends up being not exactly nice, as the
baseline RaftActor is not cognizant of all persistence operations. This
means it cannot correctly ignore responses to deletion of journal and
snapshot entries -- and hence we get dead letters logged.

Route JournalProtocol and SnapshotProtocol messages to
DataPersistenceProvider, which can then handle them and correctly
tell us whether to log them or not.

JIRA: CONTROLLER-2042
Change-Id: I47b8c3ae67d0a0ea0aad9f0a64e1bb8dc11400fc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoImprove AbstractClientConnection nullness guarantees 67/100767/1
Robert Varga [Sun, 24 Apr 2022 08:45:15 +0000 (10:45 +0200)]
Improve AbstractClientConnection nullness guarantees

We have a few missing @NonNull annotations, make sure to add them.
Also remove a superfluous requireNonNull() in copy constructor.

Change-Id: I1bbd46d31856be3ce25483f05eae8e9f2a67370f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoDo not use NPE for consistency checks 66/100766/1
Robert Varga [Sun, 24 Apr 2022 08:37:29 +0000 (10:37 +0200)]
Do not use NPE for consistency checks

We are using Preconditions.checkNotNull() when guarding against illegal
state. Improve this by using verifyNotNull(), which results in
VerifyException, making the intent clearer.

Also migrate a verify(foo != null) to a proper verifyNotNull(), using
the resoluting value.

Change-Id: I2689852d396315714f126743b70469ceef75ce45
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoClean up unhandled request exceptions 64/100764/1
Robert Varga [Sun, 24 Apr 2022 08:23:22 +0000 (10:23 +0200)]
Clean up unhandled request exceptions

We have a few places which throw the same exception, make sure we
share the formatting and expose the proper control flow to Java.

Change-Id: I514faf987b780de813fe6a1374c5e634e22326a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoEnable tell-based protocol by default in DTO 07/100707/1
Ivan Hrasko [Thu, 21 Apr 2022 14:25:37 +0000 (16:25 +0200)]
Enable tell-based protocol by default in DTO

We have switched to tell-based protocol by default in datastore.cfg
configuration. Reflect that change in DTO DatastoreContext as well.

JIRA: CONTROLLER-2040
Change-Id: I2ed6c287fe7a39415afe49cb45fd485b64208e03
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
3 months agoImprove LocalProxyTransaction.doExists() 56/100656/1
Robert Varga [Tue, 19 Apr 2022 20:50:22 +0000 (22:50 +0200)]
Improve LocalProxyTransaction.doExists()

We can use immediateBooleanFluentFuture() and skip allocating two
objects.

Change-Id: I11747ddef4fa8e3dbf950b5e1879d2e1ccc395ba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoRemove FindBugs workaround 55/100655/2
Robert Varga [Tue, 19 Apr 2022 20:15:10 +0000 (22:15 +0200)]
Remove FindBugs workaround

SpotBugs no longer throws a fit on callback's nullness, remove the
workaround. Also do not execute read/exists if there is no callback
-- although there always should be.

Change-Id: I3609d3be076de488f7fa64c72ad3b875e77a633e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoExpose CursorAwareDataTreeSnapshot from local RW proxy 54/100654/1
Robert Varga [Tue, 19 Apr 2022 19:00:44 +0000 (21:00 +0200)]
Expose CursorAwareDataTreeSnapshot from local RW proxy

We can improve type safety a bit by exposing the fact the backing
snapshot supports cursors.

Change-Id: If65549d6a28851c0abd1c8b826e48503ef12860c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump versions to 5.0.3-SNAPSHOT 82/100582/1
Robert Varga [Thu, 14 Apr 2022 09:18:12 +0000 (11:18 +0200)]
Bump versions to 5.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I3cf534a6c69bd38fa3a178d9becd61275fefae0f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoBump to yangtools-8.0.3/mdsal-9.0.2 81/100581/1
Robert Varga [Thu, 14 Apr 2022 09:17:36 +0000 (11:17 +0200)]
Bump to yangtools-8.0.3/mdsal-9.0.2

Pick up fixes from upstream.

Change-Id: I38ff023ba4828e36f5ebb89fed7d6f54db1fdc24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoImplement scatter/gather on module shards 78/100478/3
Robert Varga [Thu, 7 Apr 2022 15:45:48 +0000 (17:45 +0200)]
Implement scatter/gather on module shards

ClientBackedDatastore does perform module shard root scatter/gather,
hence reads of root end up talking to only the default shard.

Refactor the scatter/gather logic from DistributedDatastore into a
common component and use it for both modes of operation.

JIRA: CONTROLLER-2038
Change-Id: Ib04efab46e36e512eb89606d026fd2082de1b693
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoNormalizedNodeAggregator should also report empty 79/100479/1
Robert Varga [Thu, 7 Apr 2022 20:23:33 +0000 (22:23 +0200)]
NormalizedNodeAggregator should also report empty

DataTree root is always present as of now, which means that even if we
pretend there is no result, the result of aggregation is non-empty.

Fix NormalizedNodeAggregator to check whether there was any operation
applied before running actual transaction.

JIRA: CONTROLLER-2038
Change-Id: Ie7e4625ad2377483d0623d96234bcc77fbba033d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoUse ImmutableBiMap builder fluently 76/100476/2
Robert Varga [Thu, 7 Apr 2022 15:16:07 +0000 (17:16 +0200)]
Use ImmutableBiMap builder fluently

We can simply allocate the builder without intermediate local, saving
us an import. Also split the locked update part into a separate method
to aid inlining.

Change-Id: I34b3dffd49c5bd637792c743e9b71e31082201f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoCap shard-snapshot-chunk-size to 480KiB 28/100428/1
Robert Varga [Wed, 6 Apr 2022 06:07:51 +0000 (08:07 +0200)]
Cap shard-snapshot-chunk-size to 480KiB

We have a few places where we are using a default of 2MiB for chunk
size. Bring them down to 480KiB to match datastore.cfg.

JIRA: CONTROLLER-2037
Change-Id: I4dfc4cf3f41acd8c4b782e6450d17f5d5e8bf281
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoAdd supervisor to EOS singleton actor 57/100357/3
Shibu Vijayakumar [Fri, 1 Apr 2022 18:14:34 +0000 (18:14 +0000)]
Add supervisor to EOS singleton actor

The actor may fail, for example due to AskTimeoutException. This still
needs to be investigated, but mitigate the failure by adding an
OwnerSupervisor to restart it on failure.

JIRA: CONTROLLER-2035
Change-Id: I2dafaa35804357415d9aaa5400372cfd8e54b85b
Signed-off-by: Shibu Vijayakumar <shibu.vijayakumar@infosys.com>
4 months agoBump versions to 5.0.2-SNAPSHOT 62/100262/1
Robert Varga [Fri, 25 Mar 2022 17:31:19 +0000 (18:31 +0100)]
Bump versions to 5.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: Icae7ce95024658ee30b8672300fa11c40f50f47b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoUpdate upstreams 55/100255/1
Robert Varga [Fri, 25 Mar 2022 13:38:39 +0000 (14:38 +0100)]
Update upstreams

Adopt yangtools-8.0.2 and mdsal-9.0.1.

Change-Id: I7d010a073386cd5e9144f92c83d4351058f4b5d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump akka to 2.6.19 48/100248/1
Robert Varga [Thu, 24 Mar 2022 20:23:11 +0000 (21:23 +0100)]
Bump akka to 2.6.19

https://akka.io/blog/news/2022/03/21/akka-2.6.19-released

Change-Id: Ib53536c127fa0b4b2e6e0d80f5c78828bec1e750
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump versions to 5.0.1-SNAPSHOT 59/100159/1
Robert Varga [Sun, 20 Mar 2022 13:38:34 +0000 (14:38 +0100)]
Bump versions to 5.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I082d9652feda9aa875f5a5d23d577a0d04c62553
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump mdsal to 9.0.0 57/100157/1
Robert Varga [Sun, 20 Mar 2022 12:59:15 +0000 (13:59 +0100)]
Bump mdsal to 9.0.0

Use released version instead of snapshots.

Change-Id: I3563eae608f91b7b8cc94181fd7c1aee2d2c68a7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoBump yangtools to 8.0.1 12/100112/1
Robert Varga [Sun, 13 Mar 2022 23:15:27 +0000 (00:15 +0100)]
Bump yangtools to 8.0.1

yangtools-8.0.0 has a small bug, make sure we have the fix for it.

Change-Id: If437c6e12855bdde39d4d118f02c8b2362d1ae33
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoBump yangtools to 8.0.0 07/100107/1
Robert Varga [Sun, 13 Mar 2022 17:08:39 +0000 (18:08 +0100)]
Bump yangtools to 8.0.0

There is a proper release out there, use it instead of snapshots.

Change-Id: I6897c2b69f064ce6af95a98492d4bc7979e2199c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoAdjust Blueprint to ensure the container is a ChildOf 84/100084/1
Robert Varga [Fri, 11 Mar 2022 17:57:07 +0000 (18:57 +0100)]
Adjust Blueprint to ensure the container is a ChildOf

InstanceIdentifier requires data tree steps, make sure we enforce
that invariant.

JIRA: MDSAL-370
Change-Id: Icb3c08eb7052eed28ef6638facb884857baec3e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoIntroduce remaining cli commands for clustering-test-app 83/99783/4
Dominik Vrbovsky [Wed, 16 Feb 2022 07:32:28 +0000 (08:32 +0100)]
Introduce remaining cli commands for clustering-test-app

There are some RPCs that were not reworked to Karaf CLI commands
during first round of introducing these commands, so we need to
introduce them as well and have complete set of commands.

JIRA: CONTROLLER-1995
Change-Id: Ifbb67e26fb4ede4a589dd07999b52e3639e5c794
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoRemove an unneeded @SuppressFBWarnings 52/100052/1
Robert Varga [Wed, 9 Mar 2022 18:08:03 +0000 (19:08 +0100)]
Remove an unneeded @SuppressFBWarnings

The warning is no longer emitted here with our current SpotBugs, hence
we can remove the suppression.

Change-Id: Id1bb3c87a05f14cba76dc8a1af73740a461a1fc1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoUse CommitInfo in AsyncNotifyingSettableFuture 51/100051/1
Robert Varga [Wed, 9 Mar 2022 18:04:16 +0000 (19:04 +0100)]
Use CommitInfo in AsyncNotifyingSettableFuture

We are performing a future transformation which boils down to converting
a null (Void) into an CommitInfo.empty().

Rather than doing that, let's make sure AsyncNotifyingSettableFuture
results directly in CommitInfo, removing the need for transformation,
saving us an object allocation and a few CPU cycles.

Change-Id: I7e34ad5e24dc6470d16243dad5ce7ba7395c5397
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoUse SettableFuture<Empty> for readinessFuture 50/100050/1
Robert Varga [Wed, 9 Mar 2022 17:57:01 +0000 (18:57 +0100)]
Use SettableFuture<Empty> for readinessFuture

java.lang.Void is promoting use of nulls, whereas Empty.value() is
a non-null object. Migrate internal users.

Change-Id: I6a8a85917d9c3a8c3d5a9aadf691c9d1a63a767b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoUse Empty instead of Void in cohorts 12/100012/5
Robert Varga [Wed, 9 Mar 2022 06:59:30 +0000 (07:59 +0100)]
Use Empty instead of Void in cohorts

Void is inherently null-happy, switch to Empty, which has a proper
value.

Change-Id: I6ce60a0933e15e7b779fcbef149481c59aa93970
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoFixup comparison formatting 15/100015/1
Robert Varga [Wed, 9 Mar 2022 08:37:24 +0000 (09:37 +0100)]
Fixup comparison formatting

Make sure the '&&' is on a single line for readability.

Change-Id: I7c1f07e2c967c3c1bff1826afdde94a59a0c7cb9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoBump upstream SNAPSHOTS 02/99502/13
Robert Varga [Thu, 27 Jan 2022 17:10:28 +0000 (18:10 +0100)]
Bump upstream SNAPSHOTS

Adopt:
- odlparent-10.0.0
- yangtools-8.0.0-SNAPSHOT
- mdsal-9.0.0-SNAPSHOT

Change-Id: I60991718a6d1ef6f108c2b1f7b2c09b0c5f973c4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 months agoBump mdsal to 8.0.12 10/99810/1
Robert Varga [Fri, 18 Feb 2022 10:50:45 +0000 (11:50 +0100)]
Bump mdsal to 8.0.12

Pick up the single fix from upstream.

Change-Id: I27e3c14ae8dc86110932466519ba4b824ded9c21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6fe3278a3a5421758cc49f7e65097887cd4a5c48)

5 months agoFix yangtools mis-alignment 33/99733/1
Robert Varga [Mon, 14 Feb 2022 14:55:02 +0000 (15:55 +0100)]
Fix yangtools mis-alignment

We have a mis-aligned yangtools versions, fix that up.

Change-Id: I5153b518d2146eef8e3d7cb239a05686515755cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit fcf0f01fbb4ea92258699ac40bdd5143a06d51c9)

5 months agoBump upstream versions 09/99709/1
Robert Varga [Mon, 14 Feb 2022 07:26:31 +0000 (08:26 +0100)]
Bump upstream versions

Adopt:
- odlparent-9.0.13
- yangtools-7.0.13
- mdsal-8.0.11

Change-Id: I4987c100930e883b51f8b519d2a1f9696196a032
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 40929a81c7a1e38b2cba76da0e684a1368d0e2ee)

6 months agoRemove odl-controller-blueprint from odl-mdsal-broker 56/97856/2
Robert Varga [Sat, 9 Oct 2021 11:21:13 +0000 (13:21 +0200)]
Remove odl-controller-blueprint from odl-mdsal-broker

Only a few services need ODL blueprint extensions, minimize their
exposure by not installing them for odl-mdsal-broker.

JIRA: CONTROLLER-2006
Change-Id: I63f4b8b977d993b989f45351b7b22ae3bd92dbec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoMigrate to Empty.value() 04/99504/1
Robert Varga [Thu, 27 Jan 2022 18:33:09 +0000 (19:33 +0100)]
Migrate to Empty.value()

Empty.getInstance() is deprecated for removal, use its replacement.

Change-Id: I07d6796e8211fa1ef9a08bc8bc8826d66c1b7ec9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoFix clearing of candidates from previous iterations 30/99130/8
Tomas Cere [Tue, 21 Dec 2021 16:16:40 +0000 (17:16 +0100)]
Fix clearing of candidates from previous iterations

During initialization the CandidateRegistry wasnt clearing
candidates from the previous instance in a reliable way.
Event with ReadMajority if the cluster members havent been updated
yet, it acted as if there were no candidates present so it did
not clear them.

Introduce a mechansim that goes through the akka singleton that
picks owners, so it only executes the clearing of candidates once
the cluster is in a healthy state.

JIRA: CONTROLLER-2025
Change-Id: I5a43908e45273adfea325621189f633ce493ca87
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoBump upstream versions 41/99041/1
Robert Varga [Wed, 19 Jan 2022 12:27:01 +0000 (13:27 +0100)]
Bump upstream versions

Adopt:
- odlparent-9.0.12
- yangtools-7.0.12
- mdsal-8.0.10

Change-Id: Ia0b658d8c92e5ae41e50e13f01c848fb4ffb6b81
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 99bd02d911c4c284b13dea70f4692c378636fa9d)

6 months agoRestart downed nodes. 27/98927/7
Tomas Cere [Wed, 8 Dec 2021 11:40:40 +0000 (12:40 +0100)]
Restart downed nodes.

Nodes can be downed by sbr(for example when Isolated, sbr makes the
decision to down the minority), so we need to make sure they can
come up automatically unless we have another mechanism in place
for bringing up downed nodes.

JIRA: CONTROLLER-2025
Change-Id: I23d3ca2cee471c51d0eadc6c426461aa6eef193d
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
6 months agoEnable Split-Brain Resolver 34/98634/6
Tomas Cere [Mon, 22 Nov 2021 10:32:48 +0000 (11:32 +0100)]
Enable Split-Brain Resolver

In order to make EOS service work, we need to have a provider handling
dead nodes. Enable SBR to fill that role, so that we properly recover
from nodes going away.

JIRA: CONTROLLER-2025
Change-Id: Idf817455bfe2a90d6e02011eee4ed407e1254fd2
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoSwitch to using tell-based protocol 97/96497/6
Ivan Hrasko [Wed, 9 Jun 2021 08:08:46 +0000 (10:08 +0200)]
Switch to using tell-based protocol

Using Artery with ask-based protocol in our current settings leads
to easily running out of native memory. Switch to tell-based protocol,
which can slice its messages to fit in smaller buffers.

JIRA: CONTROLLER-1983
Change-Id: I0a296dbb3ba6e4e659c94761d78cfb985633061c
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoBump versions to 5.0.0-SNAPSHOT 96/99296/1
Robert Varga [Thu, 13 Jan 2022 13:54:26 +0000 (14:54 +0100)]
Bump versions to 5.0.0-SNAPSHOT

This starts the next major version development.

Change-Id: I0bc9fed64efeee1dcb30b1a464321e9654c14eec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoBump akka to 2.6.18 24/99124/7
Robert Varga [Mon, 20 Dec 2021 11:52:55 +0000 (12:52 +0100)]
Bump akka to 2.6.18

https://akka.io/blog/news/2021/12/20/akka-2.6.18-released

JIRA: CONTROLLER-2027
Change-Id: I7ec7581f48610d8d8479e971186a16d6b870ed9c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoBump scala-java8-compat_2.13 to 1.0.2 86/99286/2
Robert Varga [Thu, 13 Jan 2022 10:23:18 +0000 (11:23 +0100)]
Bump scala-java8-compat_2.13 to 1.0.2

Akka 2.6.16+ is using version 1.0.0, and they are binary compatible,
let's make sure we align to a newer version as well.

https://github.com/scala/scala-java8-compat/releases/tag/v1.0.0
https://github.com/scala/scala-java8-compat/releases/tag/v1.0.1
https://github.com/scala/scala-java8-compat/releases/tag/v1.0.2

Change-Id: I6c5f21c296dae9ca7236487e460755f0ef3e7622
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoBump scala to 2.13.8 83/99283/2
Robert Varga [Thu, 13 Jan 2022 09:29:04 +0000 (10:29 +0100)]
Bump scala to 2.13.8

https://github.com/scala/scala/releases/tag/v2.13.7
https://github.com/scala/scala/releases/tag/v2.13.8

Change-Id: Ifc5ac268e531b10a9920c7a16bfbdbb3de12d611
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoRework karaf CLI commands to print results on console 35/98635/2
Dominik Vrbovsky [Mon, 22 Nov 2021 10:56:26 +0000 (11:56 +0100)]
Rework karaf CLI commands to print results on console

Some of these karaf CLI commands may produce return values and some CSIT components need to
read them from console.

Change-Id: Iae54c9481515c1e8fc42e9b1cf7b1530d523a142
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
7 months agoBump upstream versions 51/99251/1
Robert Varga [Mon, 10 Jan 2022 13:10:56 +0000 (14:10 +0100)]
Bump upstream versions

Adopt:
- odlparent-9.0.10
- yangtools-7.0.11
- mdsal-8.0.9

Change-Id: I24be0e4be695c02720f139b25e0be9f7854410e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoBump upstream versions 64/99164/1
Robert Varga [Sat, 25 Dec 2021 13:28:03 +0000 (14:28 +0100)]
Bump upstream versions

Adopt:
- odlparent-9.0.9
- yangtools-7.0.10
- mdsal-8.0.8

Change-Id: Ifbfb9c8b335bbf49df4a2965c5a4744ce558089b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoCleanup asserts a bit 27/99127/1
Robert Varga [Tue, 21 Dec 2021 08:38:43 +0000 (09:38 +0100)]
Cleanup asserts a bit

Rather than using String operations, use assertThat() and matchers.

Change-Id: I0e76854950965fbfef739c38b061ccda1a9f1e37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoakka.actor.provider set to 'cluster' 33/98733/5
Dominik Vrbovsky [Mon, 6 Dec 2021 17:05:03 +0000 (18:05 +0100)]
akka.actor.provider set to 'cluster'

A number of sal-akka-raft test logs are polluted by ConfigurationException.
ActorSystem needs to have 'akka.actor.provider' set to 'cluster' in the
configuration.

JIRA: CONTROLLER-2023
Change-Id: If6e873864ffe0ea8261c80c233b6d40459d05164
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
8 months agoBump versions to 4.0.8-SNAPSHOT 95/98495/1
Robert Varga [Sun, 14 Nov 2021 09:12:49 +0000 (10:12 +0100)]
Bump versions to 4.0.8-SNAPSHOT

This starts the next development iteration.

Change-Id: I96de621e9636e25b8855e38c0d0cfc9c19fc063e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoAdd an actor for entity rpc execution. 66/98466/2
Tomas Cere [Fri, 12 Nov 2021 17:17:00 +0000 (18:17 +0100)]
Add an actor for entity rpc execution.

Instead of entity-owners rpcs being handled by owner supervisor
directly add an actor that handles the execution, preventing failures
that happen after the akka singleton has moved to a different node.

This new actor first attempts to retrieve current data from the supervisor
and if that fails, falls back to using distributed-data.

JIRA: CONTROLLER-2010
Change-Id: Idf71d66d380402c10e276c726edef2f5034f7363
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoCleanup test format 93/98493/1
Robert Varga [Sun, 14 Nov 2021 06:26:53 +0000 (07:26 +0100)]
Cleanup test format

We have wrong spaces, fix them up.

Change-Id: I166314fe85d350292fa25f36cfdbb7cd5424be76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoUse DateTimeFormatter in ShardStats 92/98492/1
Robert Varga [Sun, 14 Nov 2021 05:36:34 +0000 (06:36 +0100)]
Use DateTimeFormatter in ShardStats

This conversion allows us to drop a global lock. Also clean up the
associated test.

Change-Id: Ie91e99dd0d1ba4726b802c1c8953cfe1226714e1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoHandle ModifyTransactionRequest in forward path 89/98489/4
Robert Varga [Sat, 13 Nov 2021 18:38:08 +0000 (19:38 +0100)]
Handle ModifyTransactionRequest in forward path

When we have remote -> local handoff, we will use a
ModifyTransactionRequest, which we need to apply before moving on.

JIRA: CONTROLLER-2022
Change-Id: I04bdfda162d474966b153223c7480fd5b3af8099
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoModernize TransactionRateLimitingCallbackTest 85/98485/3
Robert Varga [Sat, 13 Nov 2021 18:05:06 +0000 (19:05 +0100)]
Modernize TransactionRateLimitingCallbackTest

Use assertThrows() and mockito runner.

Change-Id: I8cda7b267ebc923304e5b1b60c42d78a70d17d19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoModernize ThreePhaseCommitCohortProxyTest 84/98484/3
Robert Varga [Sat, 13 Nov 2021 17:58:19 +0000 (18:58 +0100)]
Modernize ThreePhaseCommitCohortProxyTest

Use List.of(), assertEquals() and mockito runner.

Change-Id: Ide20b467ddc7128680f3f29668f4e978a978696e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoCleanup AbstractDOMBrokerWriteTransactionTest 83/98483/3
Robert Varga [Sat, 13 Nov 2021 17:39:45 +0000 (18:39 +0100)]
Cleanup  AbstractDOMBrokerWriteTransactionTest

Use mockito runner instead of initMocks().

Change-Id: I205513eb6600deb9380db9b0380e2f70ac556f89
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoClean up ClientBackedReadTransactionTest 82/98482/3
Robert Varga [Sat, 13 Nov 2021 17:36:24 +0000 (18:36 +0100)]
Clean up ClientBackedReadTransactionTest

Use mockito junit runner instead of initMocks().

Change-Id: I4d51748007191df9d490bf5b25cf03acdad8cc75
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoCleanup TransactionRateLimiterTest 81/98481/3
Robert Varga [Sat, 13 Nov 2021 17:31:11 +0000 (18:31 +0100)]
Cleanup TransactionRateLimiterTest

Use guava stopwatch and mockito runner.

Change-Id: I87fd7f6b32379307875a2d3f353e6ad2d5bc2d38
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoMigrate AbstractClientHandleTest 80/98480/2
Robert Varga [Sat, 13 Nov 2021 17:16:20 +0000 (18:16 +0100)]
Migrate AbstractClientHandleTest

Mockito.initMocks() is deprecated, migrate to using mockito runner.

Change-Id: I6fbf7dd3502ed054701a1f6f41cd26e537b163e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoFold AbstractShardManagerTest 79/98479/3
Robert Varga [Sat, 13 Nov 2021 17:09:40 +0000 (18:09 +0100)]
Fold AbstractShardManagerTest

We have only a single subclass, ShardManagerTest, hence we can reduce
complexity by merging the two classes together. Also use
MockitoJUnitRunner to initialize mocks.

Change-Id: Idadafff3a3c96b38a5695ba903998382dc4054eb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoMigrate AbstractProxyTransactionTest to MockitoJUnitRunner 75/98475/2
Robert Varga [Sat, 13 Nov 2021 16:14:32 +0000 (17:14 +0100)]
Migrate AbstractProxyTransactionTest to MockitoJUnitRunner

Do not use Mockito.openMocks(), but rather a proper runner.

Change-Id: I26d9d15cd10f8717c7bc36ccb91591a70305bda2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoEnable testTransactionWithIsolatedLeader() for tell-based protocol 74/98474/1
Robert Varga [Sat, 13 Nov 2021 14:47:43 +0000 (15:47 +0100)]
Enable testTransactionWithIsolatedLeader() for tell-based protocol

Behaviour differs between ask-based (which fails) and tell-based (which
continues retrying). Modify the test suite to account for this
difference.

JIRA: CONTROLLER-2018
Change-Id: I208fd8aa8088558dbe2160168ee35182e02c97fa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoCleanup IntegrationTestKit 73/98473/1
Robert Varga [Sat, 13 Nov 2021 14:27:44 +0000 (15:27 +0100)]
Cleanup IntegrationTestKit

Use equality on optionals, assertThrows(), and static imports of test
DSL.

Change-Id: I1e66e5b1a3e10dd2d866f355de0d24da604d2c3a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoFix error message concatenation 72/98472/1
Robert Varga [Sat, 13 Nov 2021 12:08:56 +0000 (13:08 +0100)]
Fix error message concatenation

We are missing a space here, fix that up.

Change-Id: I2eba64ddcb7db14a56eb65a84d25851e4869ba5a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoClean up modification tests 71/98471/1
Robert Varga [Sat, 13 Nov 2021 11:52:29 +0000 (12:52 +0100)]
Clean up modification tests

Make sure we close the read transaction and improve assertions with
Optional.

Change-Id: Ia465f64c5845e3d5e215759cc32048e06478104b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoEnable testLeadershipTransferOnShutdown() 97/98397/7
Robert Varga [Thu, 11 Nov 2021 01:01:42 +0000 (02:01 +0100)]
Enable testLeadershipTransferOnShutdown()

We are looking at cohort caches here -- and those are not used by
ClientBackedDatastore.

Change-Id: I3abfa3299d8222df6edfa98cc4a3d108a05454e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoTrack skipped transactions 49/85749/63
Robert Varga [Tue, 12 Nov 2019 22:50:34 +0000 (23:50 +0100)]
Track skipped transactions

We are allocating transaction identifiers which are shared across
shards. As a transaction can touch only some shards, non-participating
shards will never see the transaction ID, leading to holes in their
UnsignedLongSets -- and those holes gradually eat up more and more
memory.

Track when we have such a hole and lazily forward a new request, which
purges one or more such identifiers -- plugging the memory leak.

The crux of the machinery is exchanging state between ProxyHistory
and FrontendHistoryMetadataBuilder.

JIRA: CONTROLLER-1991
Change-Id: I3817fa2841e5f9c405bb20ff1a104537ad459ce3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoHandle SnapshotComplete message 02/98402/4
Robert Varga [Thu, 11 Nov 2021 07:38:58 +0000 (08:38 +0100)]
Handle SnapshotComplete message

This is an internally-generated message, make sure we handle it in
support to indicate when we have finished completely propagating
state.

JIRA: CONTROLLER-2019
Change-Id: I4f5c5231070140d54531c2e5379dffcaf1c5c4ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoDisable state tracking on ReadyLocalTransaction 03/98403/1
Robert Varga [Thu, 11 Nov 2021 08:22:08 +0000 (09:22 +0100)]
Disable state tracking on ReadyLocalTransaction

We are failing to recognize ReadyLocalTransaction as an ask-based
message, leading to us populating state.

JIRA: CONTROLLER-2021
Change-Id: I48b3c57e11430a5ca15e0559f2a8e13627f4bab1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoDrop a test re-enable FIXME 01/98401/2
Robert Varga [Thu, 11 Nov 2021 07:10:31 +0000 (08:10 +0100)]
Drop a test re-enable FIXME

Add an explicit JIRA tag to the FIXME.

Change-Id: If567cf66476a16ce3193d1a64e18538d7bdcab53
JIRA: CONTROLLER-2020
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoAdd update FIXME to enable test 00/98400/3
Robert Varga [Thu, 11 Nov 2021 06:16:35 +0000 (07:16 +0100)]
Add update FIXME to enable test

Add an explicit reference to the issue tracking enablement of this
test.

JIRA: CONTROLLER-2018
Change-Id: I62fb6377e138cfb00deb0a3fd9093ec13f76dc46
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoMove assumption 96/98396/4
Robert Varga [Thu, 11 Nov 2021 01:00:13 +0000 (02:00 +0100)]
Move assumption

Let's assume things only just before we are hitting and error and tag
the FIXME with an issue.

JIRA: CONTROLLER-2017
Change-Id: I114ff0f3ef2e72fdc1be5e8eb61adac8ed00ff42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoAdd a FIXME for enabling a test 95/98395/4
Robert Varga [Thu, 11 Nov 2021 00:47:15 +0000 (01:47 +0100)]
Add a FIXME for enabling a test

Record the problem observed and assign an issue to track it.

JIRA: CONTROLLER-2016
Change-Id: Idbf52a2598a93f55797954223de98cd974abac3a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoRename UnsignedLongSet.size() 94/98394/1
Robert Varga [Wed, 10 Nov 2021 21:05:44 +0000 (22:05 +0100)]
Rename UnsignedLongSet.size()

Since we have 'Set' in our name, size() invokes Set.size(), which is
not we provide w.r.t. the number of distinct elements that are contained
in the set.

We are communicating how many ranges are stored, hence the method's name
is 'rangeSize()'.

Change-Id: Iaf9999db86fe03a8e753107638fc2e189b680677
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoMake UnsignedLongSet.Entry immutable 93/98393/1
Robert Varga [Wed, 10 Nov 2021 19:44:05 +0000 (20:44 +0100)]
Make UnsignedLongSet.Entry immutable

Having entries mutable is just a drag when transferring them to
mutable, as we need to perform deep copies. Let's turn them into
immutables and be done with it.

JIRA: CONTROLLER-2015
Change-Id: I3be807cbdf71a51e6b9506e0932857a230924986
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoFix UnsignedLongSet entry lifecycle 92/98392/2
Robert Varga [Wed, 10 Nov 2021 17:51:05 +0000 (18:51 +0100)]
Fix UnsignedLongSet entry lifecycle

When we are copying things around, we have to ensure we copy Entries,
because they cannot be shared.

JIRA: CONTROLLER-2015
Change-Id: I8a484a3bf52ffeaf4f4d0e770bc77dba31dbb221
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoFix Eclipse compilation error 91/98391/1
Robert Varga [Wed, 10 Nov 2021 13:43:58 +0000 (14:43 +0100)]
Fix Eclipse compilation error

JDT has trouble with Scala classes here, make sure we specify
more general scala.collections.Set instead of its immutable counterpart.

Change-Id: I60b56e6b7ec5705409aee8d1e30a8ae9e5579bfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoFixup assertions a bit 90/98390/1
Robert Varga [Wed, 10 Nov 2021 12:52:15 +0000 (13:52 +0100)]
Fixup assertions a bit

The tests are using different transaction mix, pass down explicit
expected transaction count.

Change-Id: I5007fe0ad90009fcafb727bac8d37bd07dfaae94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoImprove tell-based protocol assumptions 89/98389/2
Robert Varga [Wed, 10 Nov 2021 11:34:30 +0000 (12:34 +0100)]
Improve tell-based protocol assumptions

Make failures a bit more visible by comparing human-readable things.

Change-Id: I682c020be348c61fcdf4c3f31949ba0f666af020
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoPartially enable testSingleTransactionsWritesInQuickSuccession() 80/98380/6
Robert Varga [Tue, 9 Nov 2021 20:02:31 +0000 (21:02 +0100)]
Partially enable testSingleTransactionsWritesInQuickSuccession()

Split the asserts into two methods, asserting the two datastore
options. The ask-based path remains disabled because it currently
fails tests.

Also improve tell-based protocol assertions, which need to wait
for the purge process to settle.

Change-Id: I8b2f3d84b2c7cd01dec4f7994eda716d022a98aa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoCleanup DistributedDataStoreRemotingIntegrationTest 82/98382/5
Robert Varga [Wed, 10 Nov 2021 06:33:12 +0000 (07:33 +0100)]
Cleanup DistributedDataStoreRemotingIntegrationTest

We have a few @Ignored tests and assumptions scattered a bit, perform
a general cleanup on them.

JIRA: CONTROLLER-1991
Change-Id: I70054276b5ffa179337a302e5d2498e925b65ce8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoCleanup JsonExportActor 86/98386/1
Robert Varga [Wed, 10 Nov 2021 10:18:19 +0000 (11:18 +0100)]
Cleanup JsonExportActor

Remove unneeded 'this.' qualifiers and using an
EffectiveStatementInference instead of SchemaPath when instantiating
JSON codec.

Change-Id: Iac6b980771c4ad395341a9c88ee0d16c34d8a02a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoCleanup ShardInformation 85/98385/1
Robert Varga [Wed, 10 Nov 2021 10:12:33 +0000 (11:12 +0100)]
Cleanup ShardInformation

Drop unneeded 'this.' qualifiers and use a simple return expression
in getSerializedLeaderActor().

Change-Id: I9a11410f8bc6d8246bacf99fa86c42de85c328ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoCleanup ShardWriteTransaction 84/98384/1
Robert Varga [Wed, 10 Nov 2021 10:10:52 +0000 (11:10 +0100)]
Cleanup ShardWriteTransaction

A few arguments can be made final and an if/else block can be
simplified.

Change-Id: Ib5464482b4e4cc1d73f755b4b467470fc3b2af25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>