controller.git
5 years agoMerge "BUG-2459: Default to byte-aligned encoding"
Tony Tkacik [Fri, 5 Dec 2014 11:21:57 +0000 (11:21 +0000)]
Merge "BUG-2459: Default to byte-aligned encoding"

5 years agoMerge "BUG-2477 Remove unused pax-exam plugin from netconf-it"
Anil Vishnoi [Fri, 5 Dec 2014 10:48:48 +0000 (10:48 +0000)]
Merge "BUG-2477 Remove unused pax-exam plugin from netconf-it"

5 years agoMerge "BUG-2459: Fix netconf-monitoring not reusing JAXB context"
Tony Tkacik [Fri, 5 Dec 2014 09:56:25 +0000 (09:56 +0000)]
Merge "BUG-2459: Fix netconf-monitoring not reusing JAXB context"

5 years agoBUG 2463 - Changing setting for shard-snapshot-data-threshold-percentage does not... 41/13341/2
Moiz Raja [Wed, 3 Dec 2014 13:20:33 +0000 (05:20 -0800)]
BUG 2463 - Changing setting for shard-snapshot-data-threshold-percentage does not work

This was missed by the commit which introduced this setting. It was not read from the config
and set on the DataStoreContext. This meant that the default (12 percent) was used regardless
of the actual setting.

Also changed the name of the stat to InMemoryJournalDataSize instead of just DataSize to be
more clear

Change-Id: Iaffddb3e614db7a270d847ba219801e36c8a64e0
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Make neutron a simple osgi app"
Moiz Raja [Thu, 4 Dec 2014 23:14:21 +0000 (23:14 +0000)]
Merge "Make neutron a simple osgi app"

5 years agoMake neutron a simple osgi app 54/12654/14
Ed Warnicke [Fri, 7 Nov 2014 21:15:58 +0000 (15:15 -0600)]
Make neutron a simple osgi app

Change-Id: I57aabd9db316632d6051eae477ea8a9882699d7f
Signed-off-by: Ed Warnicke <eaw@cisco.com>
5 years agoBUG-2477 Remove unused pax-exam plugin from netconf-it 72/13372/3
Vaclav Demcak [Thu, 4 Dec 2014 21:15:38 +0000 (22:15 +0100)]
BUG-2477 Remove unused pax-exam plugin from netconf-it

+ remove version depend. in for pax-exam in adsal/commons/integrationtest

Change-Id: Ib077603f23072a1c56f6d39c51ad29bb7d7d8ad7
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoBUG-2459: Fix netconf-monitoring not reusing JAXB context 73/13373/2
Robert Varga [Thu, 4 Dec 2014 16:22:16 +0000 (17:22 +0100)]
BUG-2459: Fix netconf-monitoring not reusing JAXB context

JAXBContext can be freely reused, so cache it, as it has significant
footprint in testing tool.

Change-Id: If2f53b9dfd4a1d30390580fd800aa2f5eb4e2b72
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2459: Default to byte-aligned encoding 78/13378/1
Robert Varga [Thu, 4 Dec 2014 19:06:13 +0000 (20:06 +0100)]
BUG-2459: Default to byte-aligned encoding

Switches from preCompress encoding, and optimizes things a bit more.

Change-Id: I77afc3e7c105d5a5711852f3f63a63bada96613f
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Fix bug 2450 - Statistics collection slow - performance"
Anil Vishnoi [Wed, 3 Dec 2014 11:30:37 +0000 (11:30 +0000)]
Merge "Fix bug 2450 - Statistics collection slow - performance"

5 years agoMerge "Do not force toString() in NetconfClientSession"
Tony Tkacik [Wed, 3 Dec 2014 10:28:18 +0000 (10:28 +0000)]
Merge "Do not force toString() in NetconfClientSession"

5 years agoMerge "Refactor DOMDataBrokerImpl"
Tony Tkacik [Wed, 3 Dec 2014 10:28:00 +0000 (10:28 +0000)]
Merge "Refactor DOMDataBrokerImpl"

5 years agoMerge "Add MD-SAL artifacts"
Tony Tkacik [Wed, 3 Dec 2014 10:27:44 +0000 (10:27 +0000)]
Merge "Add MD-SAL artifacts"

5 years agoMerge "Remove use of xtend"
Tony Tkacik [Wed, 3 Dec 2014 10:26:32 +0000 (10:26 +0000)]
Merge "Remove use of xtend"

5 years agoMerge "Fix checkstyle warnings in netty-threadgroup-config."
Tony Tkacik [Wed, 3 Dec 2014 09:26:58 +0000 (09:26 +0000)]
Merge "Fix checkstyle warnings in netty-threadgroup-config."

5 years agoMerge "Fix checkstyle warnings in netty-event-executor-config."
Tony Tkacik [Wed, 3 Dec 2014 09:26:50 +0000 (09:26 +0000)]
Merge "Fix checkstyle warnings in netty-event-executor-config."

5 years agoMerge "Fix checkstyle warnings in logback-config"
Tony Tkacik [Wed, 3 Dec 2014 09:26:42 +0000 (09:26 +0000)]
Merge "Fix checkstyle warnings in logback-config"

5 years agoMerge "Fix checkstyle warnings in netconf-util"
Tony Tkacik [Wed, 3 Dec 2014 09:26:34 +0000 (09:26 +0000)]
Merge "Fix checkstyle warnings in netconf-util"

5 years agoMerge "BUG-8: migrate newMBeanProxy() -> newMXBeanProxy()"
Tony Tkacik [Wed, 3 Dec 2014 09:26:27 +0000 (09:26 +0000)]
Merge "BUG-8: migrate newMBeanProxy() -> newMXBeanProxy()"

5 years agoFix bug 2450 - Statistics collection slow - performance 28/13328/2
Vaclav Demcak [Tue, 2 Dec 2014 10:36:34 +0000 (11:36 +0100)]
Fix bug 2450 - Statistics collection slow - performance

* fix timeout value for statWaiter to notification (30 sec is mistake - 3sec is correct value)
* add check TransactionId for every notification (prevent unexpected notification for collecting next statistics)
* timeout has to clear TransactionId (prevention for notification from slower statistics processes

* patch 3  - revert the log level msg (debuging issue in StatPermCollectorImpl)
- change an expiration calculation for cached RPC results (StatRpcMsgManagerImpl)
- fix conditions for call notifyToCollectNextStat (Meter, Group)

succesfull tested for karaf-compatible

Change-Id: I54d7fe9e5c1a5d265c9378507fce1163691b62e5
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoDo not force toString() in NetconfClientSession 15/13315/2
Robert Varga [Tue, 2 Dec 2014 17:27:20 +0000 (18:27 +0100)]
Do not force toString() in NetconfClientSession

Passing 'this' will cause toString() to be invoked if needed.

Change-Id: I3859cee6aafd26bf57107f66fb20695b3df15c93
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoRefactor DOMDataBrokerImpl 78/13078/6
Robert Varga [Mon, 24 Nov 2014 14:15:42 +0000 (15:15 +0100)]
Refactor DOMDataBrokerImpl

This patch shuffles the abstractions, eliminating two intermediate
interfaces and ensuring proper layring is maintained with
AbstractDataBroker serving as a base for the Concurrent and Serialized
versions.

Change-Id: If363aa796db0c2ebf22fdefe7659dd428745dc75
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMerge "Handle more specific BindException and IOException"
Ed Warnicke [Tue, 2 Dec 2014 16:21:52 +0000 (16:21 +0000)]
Merge "Handle more specific BindException and IOException"

5 years agoMerge "Fix allowable Unix ports range 1024 - 65535"
Ed Warnicke [Tue, 2 Dec 2014 16:20:59 +0000 (16:20 +0000)]
Merge "Fix allowable Unix ports range 1024 - 65535"

5 years agoMerge "BUG 2335 : Add jolokia feature"
Ed Warnicke [Tue, 2 Dec 2014 14:49:28 +0000 (14:49 +0000)]
Merge "BUG 2335 : Add jolokia feature"

5 years agoBUG 2335 : Add jolokia feature 72/12772/7
Moiz Raja [Wed, 12 Nov 2014 00:55:45 +0000 (16:55 -0800)]
BUG 2335 : Add jolokia feature

This is to make it easy to install jolokia. Earlier it was
possible to install the jolokia bundle the feature just makes
it more convenient.

With this patch I have created a placeholder for extra features. This is
where tiny little utility features of the controller can be put in.

Change-Id: Ifd980656d368902b13834e1e77783151536ca87c
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBug 2175 - Migrate frm, statistics and inventory manager to config subsystem 03/13303/3
Vaclav Demcak [Tue, 2 Dec 2014 11:10:18 +0000 (12:10 +0100)]
Bug 2175 - Migrate frm, statistics and inventory manager to config subsystem

* migrated statistics manager to config subsystem
* updated tests
* patch resolves Bug 1646 and Bug 2079
* Patch Set 6 - add log.warn msg for a fail loading xml ConfigSubsystem input value + fix MIN_REQUEST_NET_MONITOR_INTERVAL_DEFAULT to 3sec (follow Anil's comment)

Change-Id: I67d398c82c3dafbb2ef759d07a80d17ad6656c1e
Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
5 years agoMerge "Bug 2415: Fixed intermittent RpcRegistry unit test failures"
Moiz Raja [Tue, 2 Dec 2014 01:19:37 +0000 (01:19 +0000)]
Merge "Bug 2415: Fixed intermittent RpcRegistry unit test failures"

5 years agoMerge "BUG 2437 - Enable snapshotting based on size of data in the in-memory journal"
Tom Pantelis [Mon, 1 Dec 2014 22:03:00 +0000 (22:03 +0000)]
Merge "BUG 2437 - Enable snapshotting based on size of data in the in-memory journal"

5 years agoMerge "bug 2266 : added more types of schema nodes to increase code coverage"
Moiz Raja [Mon, 1 Dec 2014 21:59:11 +0000 (21:59 +0000)]
Merge "bug 2266 : added more types of schema nodes to increase code coverage"

5 years agoHandle more specific BindException and IOException 77/13177/2
Thanh Ha [Thu, 27 Nov 2014 20:22:54 +0000 (15:22 -0500)]
Handle more specific BindException and IOException

It is good pratice to handle specific exceptions rather than using the
catch all generic Exception.

This code change handles the java.net.BindException such that if an port
is already in use we skip creating the simulated device on that port.

IOException will display the failure message and exception and not cause
additional attempts.

Change-Id: I7cbf3aa7016b0589f8fdd3f6476006954068a9a0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix allowable Unix ports range 1024 - 65535 76/13176/3
Thanh Ha [Thu, 27 Nov 2014 19:38:07 +0000 (14:38 -0500)]
Fix allowable Unix ports range 1024 - 65535

The well known ports / system ports are actually only in the range
between 0 - 1023. The port 1024 should be usable. Also now handles the
max allowable port of 65535.

Change-Id: I5ec944abfe40156467ac53b9f5731a0aa6776596
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoBUG 2437 - Enable snapshotting based on size of data in the in-memory journal 48/13148/4
Moiz Raja [Wed, 26 Nov 2014 17:07:40 +0000 (09:07 -0800)]
BUG 2437 - Enable snapshotting based on size of data in the in-memory journal

- Changed RaftActor to snapshot based on the transaction count or the size of the
  data in the in-memory journal whichever comes earlier
- The size of data that is used is the rough (not-accurate) size of the Payload
  in the Replicated log entry
- In ShardStats exposed another property which is the data size of the in-memory
  journal
- The snapshot data threshold percentage is configurable using the config sub-system and is
  set to a default of 12%. The reason for setting it at 12% by default is because we have
  a total of 8 default shards out of the box. I could have set this to 16% as toaster is not
  a "real" data shard.
- The snapshot data threshold is calculated as a percentage of the Runtime.totalMemory()
  which is the total memory the jvm considers available for object allocation. From testing
  it appears that the total memory is what would appear in jconsole as the committed memory.

I have not added any unit testing for this - but tested this using the scenario described in
bug 2437 and it seems to work pretty well. The deployment used only 2G of memory and worked
fine for a 7 switch topology and I observed that it had not run out of memory after more than
2 hours.

Change-Id: I09ec0827c0411c42a9224bb6d159d5590c22e20b
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoBUG 2371 : Leader should reset it's snapshot tracking when follower is restarted 09/13109/5
Moiz Raja [Tue, 25 Nov 2014 05:22:34 +0000 (21:22 -0800)]
BUG 2371 : Leader should reset it's snapshot tracking when follower is restarted

This patch adds a new protocol to InstallSnapshot. It the InstallSnapshotReply returns
a failure and the chunkIndex is -1 then the Leader will reset the FollowerSnapshot so
that when the next heartbeat occurs the Leader would start sending chunks from the beginning.

Change-Id: I0d5f0a4230209856ecf9bcef46220ae348f52b5d
Signed-off-by: Moiz Raja <moraja@cisco.com>
5 years agoMerge "Bug-2397:Provide a mechanism for stakeholders to get notifications on Raft...
Moiz Raja [Mon, 1 Dec 2014 18:29:36 +0000 (18:29 +0000)]
Merge "Bug-2397:Provide a mechanism for stakeholders to get notifications on Raft state change"

5 years agobug 2266 : added more types of schema nodes to increase code coverage 75/13275/1
Harman Singh [Fri, 21 Nov 2014 03:49:07 +0000 (19:49 -0800)]
bug 2266 : added more types of schema nodes to increase code coverage

Change-Id: I7372157ffc2b2e69ff9ae34b44eaeecadbf6b75d
Signed-off-by: Harman Singh <harmasin@cisco.com>
(cherry picked from commit 3b743648ca93c5f65b8334fe699b4ceb5aaa054d)

5 years agoRemove use of xtend 03/13203/3
Robert Varga [Thu, 27 Nov 2014 23:49:18 +0000 (00:49 +0100)]
Remove use of xtend

This patch converts RuntimeCodeGenerator into pure Java, optimizing it
in the process a bit. Since this is the last piece of Xtend code in
controller, also remove any trace of xtend.

Change-Id: I462968202d0e26c852aa683905b97bab8c5f99cf
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoAdd MD-SAL artifacts 66/13266/1
Robert Varga [Mon, 1 Dec 2014 14:49:03 +0000 (15:49 +0100)]
Add MD-SAL artifacts

This migrates the version declarations into mdsal-artifacts artifact,
such that they can be imported by downstream projects. This will be
shuffled again as we define the scope more.

Change-Id: Ie97584dd477b786e3fc4f6d79a174425c020fa0c
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-8: migrate newMBeanProxy() -> newMXBeanProxy() 71/13071/2
Maros Marsalek [Mon, 1 Dec 2014 14:11:08 +0000 (15:11 +0100)]
BUG-8: migrate newMBeanProxy() -> newMXBeanProxy()

newMBeanProxy() is deprecated, so migrate users over, eliminating
associated warnings.

Change-Id: Ifd9ff1146f2f0e5b2a20a55bd8c34f48f837cb01
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoMerge "Bug 2435 - Controller/MD-SAL throwing ModifiedNodeDoesNotExistException except...
Devin Avery [Mon, 1 Dec 2014 13:48:28 +0000 (13:48 +0000)]
Merge "Bug 2435 - Controller/MD-SAL throwing ModifiedNodeDoesNotExistException exception when statistics manager augment queue statistics to the node connector. Exception was thrown because parent (queue) container was not present when statistics manager tried to augment statistics. Fixed the issue by creating empty queue container and 'merge'ing it to the node connector before augmenting the statistics."

5 years agoMerge "Fix checkstyle warnings in netconf-usermanager"
Tony Tkacik [Mon, 1 Dec 2014 10:19:01 +0000 (10:19 +0000)]
Merge "Fix checkstyle warnings in netconf-usermanager"

5 years agoMerge "Fix checkstyle warnings in netconf-tcp"
Tony Tkacik [Mon, 1 Dec 2014 10:18:09 +0000 (10:18 +0000)]
Merge "Fix checkstyle warnings in netconf-tcp"

5 years agoFix checkstyle warnings in netty-threadgroup-config. 00/13000/10
Marian Dubai [Thu, 20 Nov 2014 10:15:35 +0000 (11:15 +0100)]
Fix checkstyle warnings in netty-threadgroup-config.

Change-Id: Iaafffc02425ea4369b02002b39a4e7b46baaaf3f
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in netty-event-executor-config. 99/12999/7
Marian Dubai [Thu, 20 Nov 2014 10:08:05 +0000 (11:08 +0100)]
Fix checkstyle warnings in netty-event-executor-config.

Change-Id: I955f3b546aee0ba7d4269ec62c25158b25d92d50
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in logback-config 98/12998/7
Marian Dubai [Thu, 20 Nov 2014 10:07:03 +0000 (11:07 +0100)]
Fix checkstyle warnings in logback-config

Change-Id: I36c4cbd8df84c047bc83ec62d0fd6c09326f3822
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoMerge "Make sure we include maven plugin in execution"
Tony Tkacik [Mon, 1 Dec 2014 09:02:42 +0000 (09:02 +0000)]
Merge "Make sure we include maven plugin in execution"

5 years agoMerge "BUG-2259: mark AbstractBindingAware* as deprecated"
Tony Tkacik [Mon, 1 Dec 2014 08:28:37 +0000 (08:28 +0000)]
Merge "BUG-2259: mark AbstractBindingAware* as deprecated"

5 years agoMerge "BUG-2340 Fix improper cleanup of resources in netconf ssh handler"
Tony Tkacik [Mon, 1 Dec 2014 08:25:10 +0000 (08:25 +0000)]
Merge "BUG-2340 Fix improper cleanup of resources in netconf ssh handler"

5 years agoBug 2372: Removing duplicate call in loadBalancerPoolNorthbound to loadBalancerPoolIn... 24/13224/1
Srini Seetharaman [Sun, 30 Nov 2014 01:48:33 +0000 (17:48 -0800)]
Bug 2372: Removing duplicate call in loadBalancerPoolNorthbound to loadBalancerPoolInterface.addNeutronLoadBalancerPool(singleton);

Change-Id: I0b5790b6d363c85bcd0d2bb739a0de14c8516800
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>
5 years agoBUG-2259: mark AbstractBindingAware* as deprecated 81/12981/4
Robert Varga [Thu, 20 Nov 2014 11:15:03 +0000 (12:15 +0100)]
BUG-2259: mark AbstractBindingAware* as deprecated

These classes encapsulate OSGi-activated clients, which are deprecated
in favor of using config subsystem activation.

Change-Id: I9632c6608be67e5763117a9bbb6e9c2519eb27b0
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoMake sure we include maven plugin in execution 19/13119/4
Robert Varga [Tue, 25 Nov 2014 13:26:45 +0000 (14:26 +0100)]
Make sure we include maven plugin in execution

Change-Id: Ibdaf3fe5004d366561845b283e92207127618914
Signed-off-by: Robert Varga <rovarga@cisco.com>
5 years agoBUG-2340 Fix improper cleanup of resources in netconf ssh handler 01/13201/2
Maros Marsalek [Fri, 28 Nov 2014 11:19:19 +0000 (12:19 +0100)]
BUG-2340 Fix improper cleanup of resources in netconf ssh handler

This commit also fixes proper reconnect scheduling for netconf-connector.

Change-Id: I1d848af57fddc35e73596fc47f8c7318b8747130
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
5 years agoBug 2435 - Controller/MD-SAL throwing ModifiedNodeDoesNotExistException exception... 56/13156/5
Anil Vishnoi [Wed, 26 Nov 2014 21:28:41 +0000 (02:58 +0530)]
Bug 2435 - Controller/MD-SAL throwing ModifiedNodeDoesNotExistException exception when statistics manager
augment queue statistics to the node connector. Exception was thrown because parent (queue) container was
not present when statistics manager tried to augment statistics. Fixed the issue by creating empty queue
container and 'merge'ing it to the node connector before augmenting the statistics.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: I7d68f3e177ccf62c7adf154e655226450a74296c

5 years agoMerge "Optimize xsql's use of collections"
Tony Tkacik [Fri, 28 Nov 2014 10:12:18 +0000 (10:12 +0000)]
Merge "Optimize xsql's use of collections"

5 years agoMerge "Netconf-cli compilable and included in project"
Tony Tkacik [Fri, 28 Nov 2014 10:00:35 +0000 (10:00 +0000)]
Merge "Netconf-cli compilable and included in project"

5 years agoFix bug 2413 NPE for group and meters 83/12983/6
Vaclav Demcak [Mon, 27 Oct 2014 23:17:39 +0000 (00:17 +0100)]
Fix bug 2413 NPE for group and meters

* group/meter features
* Device RPC features Calls for group/meter depend on FlowCapableNode data change event (create event only)
* Remove Meter's and Group's feature calls from perm. stat. collect
* Add API methods for additional registration new StatCapabTypes for a specific Node statistic collecting process
* Fix NPE for features
* refactoring group/meter stats update processing (Target: Don't block the RPC Notification threads as soon as is possible)
* Fix NPE List processing
* queue - add delete processing (becasue queues has to be edit outside and we are not cleaning it)
* add validations input values
* remove unnecessary validation input values (StatRpcMsgManagerImpl)

Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Change-Id: If10a0ea0bb098ca70cd19ce32a7ca5790159aae5

5 years agoFix checkstyle warnings in netconf-util 66/12866/8
Marian Dubai [Fri, 14 Nov 2014 15:25:53 +0000 (16:25 +0100)]
Fix checkstyle warnings in netconf-util

Change-Id: I0fbe00cc76f3b84a8b2673f1716b8ceb08c2b52b
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in netconf-usermanager 65/12865/11
Marian Dubai [Fri, 14 Nov 2014 14:58:58 +0000 (15:58 +0100)]
Fix checkstyle warnings in netconf-usermanager

Change-Id: Id4cc11b487f98e6b33985c16f7a95a434c01dd74
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in netconf-tcp 64/12864/11
Marian Dubai [Fri, 14 Nov 2014 14:57:14 +0000 (15:57 +0100)]
Fix checkstyle warnings in netconf-tcp

Change-Id: I95e776dde2645288734f7687c22fc158ee7b486d
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in netconf-ssh. 63/12863/12
Marian Dubai [Fri, 14 Nov 2014 14:55:54 +0000 (15:55 +0100)]
Fix checkstyle warnings in netconf-ssh.

Change-Id: I01cee96432edcf361b463f89c648823042165b9e
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in netconf-netty-util 62/12862/5
Marian Dubai [Fri, 14 Nov 2014 14:52:51 +0000 (15:52 +0100)]
Fix checkstyle warnings in netconf-netty-util

Change-Id: I123c7cbff15c1267a1bdb537e100c1bf2f9894d7
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoMerge "Fix expression deprecated warning on ${version}"
Ed Warnicke [Wed, 26 Nov 2014 21:52:03 +0000 (21:52 +0000)]
Merge "Fix expression deprecated warning on ${version}"

5 years agoBug-2397:Provide a mechanism for stakeholders to get notifications on Raft state... 33/12933/7
Kamal Rameshan [Tue, 18 Nov 2014 23:26:51 +0000 (15:26 -0800)]
Bug-2397:Provide a mechanism for stakeholders to get notifications on Raft state change

A notifier actor is spawned from the RaftActor inherited implementation, in our case Shard or ExampleActor .

Its injected into the RaftActor.RaftActor notifies the notifier with the role changes. The Notification message is local to Shard or Example.

The idea is for any implementation to create a notifier, inject it and issue a notification from that notifier on a role change.

A sample example notifier, listener and notification is provided to show how a listener can register with the notifier and get notifications form the notifier.

Notifier and Notifications are assembled in commons, to be shared along with other apps who might need similar logic. It can be override by specific implementations.

Has been tested with the TestDriver, with separate actorsystems for listner and notifier

Tests have been added.

Change-Id: I23f16d4e76bb7dae640c544df282293274d9a1cb
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
5 years agoFix expression deprecated warning on ${version} 53/13153/1
Thanh Ha [Wed, 26 Nov 2014 19:50:15 +0000 (14:50 -0500)]
Fix expression deprecated warning on ${version}

${version} is deprecated and ${project.version} should be used instead.
This patch fixes the expression used.

Change-Id: Iaf3a3bf8b852836ed01106a419cca2ab60c314d5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoCleanup temporary test files 69/13069/3
Thanh Ha [Sun, 23 Nov 2014 23:41:57 +0000 (18:41 -0500)]
Cleanup temporary test files

A properly defined test should correctly cleanup after itself when the
tests have completed execution.

Change-Id: I9887558e698a2ee823a9f91727cde5eccc2348f2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoMerge "Bug 2267: Reuse leaf and leaf set entry builders in NormalizedNodeInputStreamR...
Moiz Raja [Wed, 26 Nov 2014 18:34:42 +0000 (18:34 +0000)]
Merge "Bug 2267: Reuse leaf and leaf set entry builders in NormalizedNodeInputStreamReader"

5 years agoMerge "Bug-915: Adding static document generation. Currently the API Explorer can...
Moiz Raja [Wed, 26 Nov 2014 17:35:38 +0000 (17:35 +0000)]
Merge "Bug-915: Adding static document generation. Currently the API Explorer can only be accessed from a running server. With this change, the API Explorer will be generated as static html pages at build time in the features folder."

5 years agoMerge "Fix checkstyle warnings in logback-config-loader."
Tony Tkacik [Wed, 26 Nov 2014 10:25:46 +0000 (10:25 +0000)]
Merge "Fix checkstyle warnings in logback-config-loader."

5 years agoNetconf-cli compilable and included in project 28/13128/2
Marian Dubai [Tue, 25 Nov 2014 16:33:30 +0000 (17:33 +0100)]
Netconf-cli compilable and included in project

Change-Id: Ia08396f52c98ea2661e13f60a3787b18c4ae50d6
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in logback-config-loader. 97/12997/6
Marian Dubai [Thu, 20 Nov 2014 10:05:06 +0000 (11:05 +0100)]
Fix checkstyle warnings in logback-config-loader.

Change-Id: If926826e233000f771518d966493ee8b100a76e4
Signed-off-by: Marian Dubai <mdubai@cisco.com>
5 years agoFix checkstyle warnings in netconf-monitoring. 61/12861/6
Marian Dubai [Fri, 14 Nov 2014 14:50:22 +0000 (15:50 +0100)]
Fix checkstyle warnings in netconf-monitoring.

Change-Id: I57cdbd26a841cb8fa6b0435089832c635302594b
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoFix checkstyle warnings in netconf-mapping-api. 60/12860/5
Marian Dubai [Fri, 14 Nov 2014 14:45:32 +0000 (15:45 +0100)]
Fix checkstyle warnings in netconf-mapping-api.

Change-Id: Ic0e339063aa79bc0c0338c33486e43fcdd29ef56
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoFix checkstyle warnings in netconf-it 59/12859/5
Marian Dubai [Fri, 14 Nov 2014 14:38:18 +0000 (15:38 +0100)]
Fix checkstyle warnings in netconf-it

Change-Id: I73f4325f6ff3ca7139b4e4ccf459fa8a10e36696
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoFix checkstyle warnings in netconf-impl. 58/12858/6
Marian Dubai [Fri, 14 Nov 2014 14:36:12 +0000 (15:36 +0100)]
Fix checkstyle warnings in netconf-impl.

Change-Id: I921b51e79475bdc7a0a03398bb6a709836bffdb2
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoMerge "Fix checkstyle warnings in config-util"
Tony Tkacik [Tue, 25 Nov 2014 16:59:26 +0000 (16:59 +0000)]
Merge "Fix checkstyle warnings in config-util"

6 years agoOptimize xsql's use of collections 43/12643/9
Robert Varga [Fri, 7 Nov 2014 19:03:32 +0000 (20:03 +0100)]
Optimize xsql's use of collections

Rather than performing class comparisons, we perform a simple
instanceof check... and then rather than adding items one at a time, we
use Collections.addAll().

Change-Id: I2e73788ab6f1625291970ad9b32d3b5d18ee8205
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-2255: introduce PingPongDataBroker 83/12583/9
Robert Varga [Thu, 6 Nov 2014 19:13:59 +0000 (20:13 +0100)]
BUG-2255: introduce PingPongDataBroker

This is a forwarding DOMDataBroker implementation, which ensures that
there is at most one transaction pending for a particular transaction
chain. This is not useful in all scenarios, but if the users can
restrain themselves to use the supported semantics, they can use it.

Change-Id: I4a9ca12254763829f99e270d6716cd034b4b5ea9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
6 years agoFix checkstyle warnings in config-util 96/12996/4
Marian Dubai [Thu, 20 Nov 2014 10:04:15 +0000 (11:04 +0100)]
Fix checkstyle warnings in config-util

Change-Id: I5a8caa79f38081b65f2e25f9aaecc403584fa394
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoMerge changes If7159c39,I6c84b2fe
Tony Tkacik [Tue, 25 Nov 2014 08:53:14 +0000 (08:53 +0000)]
Merge changes If7159c39,I6c84b2fe

* changes:
  Deprecate ForwardedBackwardsCompatibleDataBroker
  Migrate from using the deprecated SchemaContextProvider

6 years agoMerge "Migrate FRM/SM to use model API SchemaContextProvider"
Tony Tkacik [Tue, 25 Nov 2014 08:51:54 +0000 (08:51 +0000)]
Merge "Migrate FRM/SM to use model API SchemaContextProvider"

6 years agoBug-915: Adding static document generation. 29/12129/7
Alex Fan [Tue, 18 Nov 2014 23:07:44 +0000 (15:07 -0800)]
Bug-915: Adding static document generation.
Currently the API Explorer can only be accessed from a running server.
With this change, the API Explorer will be generated as static html
pages at build time in the features folder.

Change-Id: I0a898e1a3d9753fd2b046d690173838be057d6ea
Signed-off-by: Alex Fan <railor33@gmail.com>
6 years agoDeprecate ForwardedBackwardsCompatibleDataBroker 49/13049/1
Robert Varga [Fri, 21 Nov 2014 16:55:30 +0000 (17:55 +0100)]
Deprecate ForwardedBackwardsCompatibleDataBroker

It implements a deprecated API only, so rather than suppressing the
deprecation warnings, deprecate the entire class.

Change-Id: If7159c3960b3ca2707bb4b9c716e95ed38ddb394
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMigrate from using the deprecated SchemaContextProvider 48/13048/1
Robert Varga [Fri, 21 Nov 2014 17:08:51 +0000 (18:08 +0100)]
Migrate from using the deprecated SchemaContextProvider

org.opendaylight.controller.sal.dom.broker.SchemaContextProvider has
been deprecated, the services away so it is no longer used.

Change-Id: I6c84b2fe6ce02dce71aed4e4c24f8bc84ba078d8
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMigrate FRM/SM to use model API SchemaContextProvider 47/13047/1
Robert Varga [Fri, 21 Nov 2014 16:53:07 +0000 (17:53 +0100)]
Migrate FRM/SM to use model API SchemaContextProvider

Simple migration, eliminates the need for deprecation suppression.

Change-Id: Ic6d14c15dd1909d89c9b76bef20c36cdbde23187
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRename 01-mdsal.xml to 01-md-sal.xml 46/13046/1
Robert Varga [Fri, 21 Nov 2014 16:35:33 +0000 (17:35 +0100)]
Rename 01-mdsal.xml to 01-md-sal.xml

This renames the feature definition to ensure that the file distributed
in karaf matches the name that is stored in the SCM.

Change-Id: Ic885e1714f1754d9e57b513e3ad9e24395c6d11f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Remove raw references to Map in XSQL"
Tony Tkacik [Fri, 21 Nov 2014 15:46:14 +0000 (15:46 +0000)]
Merge "Remove raw references to Map in XSQL"

6 years agoMerge "BUG-8: mark deprecated classes as such"
Tony Tkacik [Fri, 21 Nov 2014 15:45:34 +0000 (15:45 +0000)]
Merge "BUG-8: mark deprecated classes as such"

6 years agoBug 865: Changed Config subsystem module for ForwardedBindingDataBroker. 18/13018/4
Tony Tkacik [Thu, 20 Nov 2014 16:49:47 +0000 (17:49 +0100)]
Bug 865: Changed Config subsystem module for ForwardedBindingDataBroker.

Implementation of new Bidning Data Broker was wired to deprecated APIs
and used broker to discover dependencies which did not allowed for
full-fledged customized wiring. Reworked configuration to explicitly
allow injection of each required depenency and to not use
deprecated APIs for dependency injection.

Change-Id: Iccbb20ee4bb1df380f5fc4a3a1bbc5748dcc5a38
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "BUG-650: Split out CommitCoordinationTask"
Tony Tkacik [Fri, 21 Nov 2014 11:58:21 +0000 (11:58 +0000)]
Merge "BUG-650: Split out CommitCoordinationTask"

6 years agoMerge changes Ia7cd7eda,If961a029,I9f6a57a2,Id8551489
Tony Tkacik [Fri, 21 Nov 2014 11:37:08 +0000 (11:37 +0000)]
Merge changes Ia7cd7eda,If961a029,I9f6a57a2,Id8551489

* changes:
  Fix checkstyle warnings in config-persister-file-xml-adapter.
  Fix checkstyle warnings in config-persister-feature-adapter
  Fix checkstyle warnings in config-persister-directory-xml-adapter
  Fix checkstyle warnings in config-manager

6 years agoMerge "Fix checkstyle warnings in config-api"
Tony Tkacik [Fri, 21 Nov 2014 11:36:43 +0000 (11:36 +0000)]
Merge "Fix checkstyle warnings in config-api"

6 years agoFix checkstyle warnings in netconf-client 57/12857/6
Marian Dubai [Fri, 14 Nov 2014 14:25:45 +0000 (15:25 +0100)]
Fix checkstyle warnings in netconf-client

Change-Id: I94d8c31a16f0755451a3bebad5a8792a97d426d2
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoBUG-650: Split out CommitCoordinationTask 37/12437/13
Robert Varga [Thu, 2 Oct 2014 00:07:35 +0000 (02:07 +0200)]
BUG-650: Split out CommitCoordinationTask

The coordination task takes most of the coordinator implementation. We
do not want to expose it, but at the same time we want to evolve task.
Split it out and eliminate the unneeded atomic state updates, as it is
only ever touched by a single thread.

Change-Id: I49b494d23a8b8f9cdf6cb3dc33e08d22c5bf325e
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "BUG-650: remove executor abstraction"
Tony Tkacik [Fri, 21 Nov 2014 08:43:40 +0000 (08:43 +0000)]
Merge "BUG-650: remove executor abstraction"

6 years agoBug-2277: fix the Leader test failing in jenkins 70/12970/3
Kamal Rameshan [Thu, 20 Nov 2014 03:21:14 +0000 (19:21 -0800)]
Bug-2277: fix the Leader test failing in jenkins

Change-Id: I149d643b517df5010595962cbdf616c2b2fb9945
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
6 years agoBUG-8: mark deprecated classes as such 80/12980/5
Robert Varga [Thu, 20 Nov 2014 10:37:09 +0000 (11:37 +0100)]
BUG-8: mark deprecated classes as such

These classes refer to various deprecated interfaces of MD-SAL,
triggering a lot of warnings about deprecated constructs. Since these
classes themselves have been superseded, mark them as Deprecated,
lowering the amount of warnings we get.

Change-Id: I19753166fa1fd617ad7085b71a1218f6bc4a3f53
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoRemove raw references to Map in XSQL 42/12642/8
Robert Varga [Fri, 7 Nov 2014 18:53:12 +0000 (19:53 +0100)]
Remove raw references to Map in XSQL

This adds the proper types to map, removing some casts and improving
efficiency slightly. Fixes quite a few of eclipse warnings.

Change-Id: Ia8cc61961a1898dd17e4e5d0e6e7a247475a007a
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoFix checkstyle warnings in config-persister-file-xml-adapter. 95/12995/2
Marian Dubai [Thu, 20 Nov 2014 10:03:24 +0000 (11:03 +0100)]
Fix checkstyle warnings in config-persister-file-xml-adapter.

Change-Id: Ia7cd7eda114225cfc35ec301535d5aaec0fa8794
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoFix checkstyle warnings in config-api 91/12991/1
Marian Dubai [Thu, 20 Nov 2014 09:51:24 +0000 (10:51 +0100)]
Fix checkstyle warnings in config-api

Change-Id: I56eedb15f3c5892731a757bdb06c34d9d15efab7
Signed-off-by: Marian Dubai <mdubai@cisco.com>
6 years agoFix checkstyle warnings in config-persister-feature-adapter 94/12994/1
Marian Dubai [Thu, 20 Nov 2014 10:01:58 +0000 (11:01 +0100)]
Fix checkstyle warnings in config-persister-feature-adapter

Change-Id: If961a029b48d85b58ca10b9b71f5fc29d41dbe9c
Signed-off-by: Marian Dubai <mdubai@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.