controller.git
6 months agoMove assumption 96/98396/4
Robert Varga [Thu, 11 Nov 2021 01:00:13 +0000 (02:00 +0100)]
Move assumption

Let's assume things only just before we are hitting and error and tag
the FIXME with an issue.

JIRA: CONTROLLER-2017
Change-Id: I114ff0f3ef2e72fdc1be5e8eb61adac8ed00ff42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoAdd a FIXME for enabling a test 95/98395/4
Robert Varga [Thu, 11 Nov 2021 00:47:15 +0000 (01:47 +0100)]
Add a FIXME for enabling a test

Record the problem observed and assign an issue to track it.

JIRA: CONTROLLER-2016
Change-Id: Idbf52a2598a93f55797954223de98cd974abac3a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoRename UnsignedLongSet.size() 94/98394/1
Robert Varga [Wed, 10 Nov 2021 21:05:44 +0000 (22:05 +0100)]
Rename UnsignedLongSet.size()

Since we have 'Set' in our name, size() invokes Set.size(), which is
not we provide w.r.t. the number of distinct elements that are contained
in the set.

We are communicating how many ranges are stored, hence the method's name
is 'rangeSize()'.

Change-Id: Iaf9999db86fe03a8e753107638fc2e189b680677
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoMake UnsignedLongSet.Entry immutable 93/98393/1
Robert Varga [Wed, 10 Nov 2021 19:44:05 +0000 (20:44 +0100)]
Make UnsignedLongSet.Entry immutable

Having entries mutable is just a drag when transferring them to
mutable, as we need to perform deep copies. Let's turn them into
immutables and be done with it.

JIRA: CONTROLLER-2015
Change-Id: I3be807cbdf71a51e6b9506e0932857a230924986
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoFix UnsignedLongSet entry lifecycle 92/98392/2
Robert Varga [Wed, 10 Nov 2021 17:51:05 +0000 (18:51 +0100)]
Fix UnsignedLongSet entry lifecycle

When we are copying things around, we have to ensure we copy Entries,
because they cannot be shared.

JIRA: CONTROLLER-2015
Change-Id: I8a484a3bf52ffeaf4f4d0e770bc77dba31dbb221
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoFix Eclipse compilation error 91/98391/1
Robert Varga [Wed, 10 Nov 2021 13:43:58 +0000 (14:43 +0100)]
Fix Eclipse compilation error

JDT has trouble with Scala classes here, make sure we specify
more general scala.collections.Set instead of its immutable counterpart.

Change-Id: I60b56e6b7ec5705409aee8d1e30a8ae9e5579bfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoFixup assertions a bit 90/98390/1
Robert Varga [Wed, 10 Nov 2021 12:52:15 +0000 (13:52 +0100)]
Fixup assertions a bit

The tests are using different transaction mix, pass down explicit
expected transaction count.

Change-Id: I5007fe0ad90009fcafb727bac8d37bd07dfaae94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoImprove tell-based protocol assumptions 89/98389/2
Robert Varga [Wed, 10 Nov 2021 11:34:30 +0000 (12:34 +0100)]
Improve tell-based protocol assumptions

Make failures a bit more visible by comparing human-readable things.

Change-Id: I682c020be348c61fcdf4c3f31949ba0f666af020
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoPartially enable testSingleTransactionsWritesInQuickSuccession() 80/98380/6
Robert Varga [Tue, 9 Nov 2021 20:02:31 +0000 (21:02 +0100)]
Partially enable testSingleTransactionsWritesInQuickSuccession()

Split the asserts into two methods, asserting the two datastore
options. The ask-based path remains disabled because it currently
fails tests.

Also improve tell-based protocol assertions, which need to wait
for the purge process to settle.

Change-Id: I8b2f3d84b2c7cd01dec4f7994eda716d022a98aa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoCleanup DistributedDataStoreRemotingIntegrationTest 82/98382/5
Robert Varga [Wed, 10 Nov 2021 06:33:12 +0000 (07:33 +0100)]
Cleanup DistributedDataStoreRemotingIntegrationTest

We have a few @Ignored tests and assumptions scattered a bit, perform
a general cleanup on them.

JIRA: CONTROLLER-1991
Change-Id: I70054276b5ffa179337a302e5d2498e925b65ce8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoCleanup JsonExportActor 86/98386/1
Robert Varga [Wed, 10 Nov 2021 10:18:19 +0000 (11:18 +0100)]
Cleanup JsonExportActor

Remove unneeded 'this.' qualifiers and using an
EffectiveStatementInference instead of SchemaPath when instantiating
JSON codec.

Change-Id: Iac6b980771c4ad395341a9c88ee0d16c34d8a02a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoCleanup ShardInformation 85/98385/1
Robert Varga [Wed, 10 Nov 2021 10:12:33 +0000 (11:12 +0100)]
Cleanup ShardInformation

Drop unneeded 'this.' qualifiers and use a simple return expression
in getSerializedLeaderActor().

Change-Id: I9a11410f8bc6d8246bacf99fa86c42de85c328ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoCleanup ShardWriteTransaction 84/98384/1
Robert Varga [Wed, 10 Nov 2021 10:10:52 +0000 (11:10 +0100)]
Cleanup ShardWriteTransaction

A few arguments can be made final and an if/else block can be
simplified.

Change-Id: Ib5464482b4e4cc1d73f755b4b467470fc3b2af25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoClean up AbstractTransactionContextFactory 83/98383/3
Robert Varga [Wed, 10 Nov 2021 09:50:50 +0000 (10:50 +0100)]
Clean up AbstractTransactionContextFactory

Add a few @NonNull annotations and eliminate two else blocks.

Change-Id: Ide21c363f349af7b24fb4835b859a224357586c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoExpose ImmutableList from FrontendClientMetadata 78/98378/1
Robert Varga [Tue, 9 Nov 2021 18:48:16 +0000 (19:48 +0100)]
Expose ImmutableList from FrontendClientMetadata

ImmutableList is an API contract, exposed it to callers.

Change-Id: I7fb2a09c2b225ce48ece7400128c8215d70292fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoCleanup cds-access-api dependencies 77/98377/1
Robert Varga [Tue, 9 Nov 2021 18:31:28 +0000 (19:31 +0100)]
Cleanup cds-access-api dependencies

We are using Guava, declare that as a dependency.

Change-Id: Ibe905f0d2d87c5e7dfb4fad598acb27b4323c7b8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoAdd MutableUnsignedLongSet.addAll() 72/98372/1
Robert Varga [Tue, 9 Nov 2021 10:23:05 +0000 (11:23 +0100)]
Add MutableUnsignedLongSet.addAll()

Add the ability to merge two UnsignedLongSets. This is useful when
we are using ImmutableUnsignedLongSet as a data interchange format
to communicate changes to a MutableUnsignedLongSet.

JIRA: CONTROLLER-2015
Change-Id: Ia84474b685872586722914f20db8f96a3c172f97
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoAdd UnsignedLongBitmap 10/98310/13
Robert Varga [Sat, 6 Nov 2021 15:04:48 +0000 (16:04 +0100)]
Add UnsignedLongBitmap

Rather than using a ImmutableMap<UnsignedLong, Boolean>, we can do
have a much denser representation with a specialized class. Here we
are introducing an explicit UnsignedLongBitmap, which stores an array
of longs and an array of booleans, ditching the intermediate objects.

Also clean up error reporting, throwing an IOException instead of a
VerifyException when things should go south unexpectedly.

JIRA: CONTROLLER-2013
Change-Id: Ie64da0af68ea2898dc77368afd4fce8abd2cccea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoSprinkle @NonNull annotations 69/98369/2
Robert Varga [Mon, 8 Nov 2021 15:50:25 +0000 (16:50 +0100)]
Sprinkle @NonNull annotations

We have a few return methods which could use @NonNull annotations,
sprinkle them around.

Change-Id: I48c0f8879127673eb122321dd6c92d4572098f68
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoInline Entry.contains() 60/98360/1
Robert Varga [Mon, 8 Nov 2021 08:22:45 +0000 (09:22 +0100)]
Inline Entry.contains()

MutableUnsignedLongSet.add() has half of the check done in contains()
as an invariant. Inline the second part there, improving performance a
bit.

Thisleaves only UnsignedLongSet.contains() as the sole caller of
Entry.contains(). Inline it there, reducing the footprint a bit.

JIRA: CONTROLLER-2014
Change-Id: Ie38283a1fc46aff8fbc717a23aa9a068805636db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoRemove UnsignedLongSet.addImpl() 59/98359/1
Robert Varga [Mon, 8 Nov 2021 07:49:15 +0000 (08:49 +0100)]
Remove UnsignedLongSet.addImpl()

We now do not share utilities in UnsignedLongSet, hence relocate
implementation code to MutableUnsignedLongSet.add().

JIRA: CONTROLLER-2014
Change-Id: Id1578a8ea639ed512d55b2e6dca26de5abdf3ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoImprove UnsignedLongSet efficiency 58/98358/1
Robert Varga [Mon, 8 Nov 2021 07:42:03 +0000 (08:42 +0100)]
Improve UnsignedLongSet efficiency

We can use NavigableMap's higher() and floor() methods to elide object
object allocations.

JIRA: CONTROLLER-2014
Change-Id: I75747c58027caee2678e32187dbd628d60ce6604
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoBump versions to 4.0.7-SNAPSHOT 23/98323/1
Robert Varga [Sun, 7 Nov 2021 09:58:38 +0000 (10:58 +0100)]
Bump versions to 4.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I837a7d5dcc6df7deb8360d3a662d0628fb1a199f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoMinor sal-distributed-datastore cleanups 14/98314/3
Robert Varga [Sun, 7 Nov 2021 00:19:18 +0000 (01:19 +0100)]
Minor sal-distributed-datastore cleanups

Corrent a @GuardedBy annotations, add @NonNull annotations, fix javadocs
and make a few methods final.

Change-Id: Icb93aae229fb0aece5ece223a759ce9f36ee0297
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoUse ImmutableList.Builder in FrontendClientMetadata 09/98309/1
Robert Varga [Sat, 6 Nov 2021 14:20:11 +0000 (15:20 +0100)]
Use ImmutableList.Builder in FrontendClientMetadata

We are performing a defensive copy in constructor, hence it is
better to allocate a builder, skipping an untrusted copy operation.

Change-Id: I95d7aa90f6da325aaae6a340caf49a6e17fe9f64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoUse ImmutableSortedSet for small ImmutableUnsignedLongSets 07/98307/5
Robert Varga [Sat, 6 Nov 2021 13:31:20 +0000 (14:31 +0100)]
Use ImmutableSortedSet for small ImmutableUnsignedLongSets

This adds a bit of indirection, but for a few entries this ends up
using arrays instead of an RB tree, offering better density.

JIRA: CONTROLLER-2012
Change-Id: I09714c6bf3272946f6cee4360f80a106453d0e61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoUse UnsignedLongSet instead of RangeSet in metadata 02/98302/8
Robert Varga [Sat, 6 Nov 2021 10:18:54 +0000 (11:18 +0100)]
Use UnsignedLongSet instead of RangeSet in metadata

Split UnsignedLongSet into two implementations, mutable and immutable.
Use the mutable implementation in runtime tracking of identifiers and
use the immutable implementation for tracking identifiers in metadata.

The serialization format is kept compatible with RangeSets, although
that implies a minor penalty in serdes.

This switch ends up potentially using more objects for small sets, but
that is offset by not having Cut indirections and most notably being
resistent to allocation of huge arrays.

JIRA: CONTROLLER-2011
Change-Id: I0c84ffaaa4ce39299cef9006784b8aff78dd0f83
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoReimplement UnsignedLongRangeSet 98/98298/6
Robert Varga [Sat, 6 Nov 2021 01:15:46 +0000 (02:15 +0100)]
Reimplement UnsignedLongRangeSet

We are tracking simple discrete values, for which a RangeSet is an
overkill due to it being generalized utility working with all possible
ranges.

Reimplement UnsignedLongRangeSet as UnsignedLongSet, tracking discrete
closed ranges of longs, which improves both memory footprint and speed
of contains()/add() operations.

This also spots a failure to disconnect purged histories during
FrontendHistoryMetadataBuilder.toLeaderState().

JIRA: CONTROLLER-1720
Change-Id: I24fae4174201fd133a282f27589d6c274c06c8dc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoImprove Frontend{Client,History}Metadata 01/98301/2
Robert Varga [Sat, 6 Nov 2021 09:20:00 +0000 (10:20 +0100)]
Improve Frontend{Client,History}Metadata

We are using Guava's immutable implementations, make sure we annotate
fields with @NonNull and use concrete types.

Change-Id: I4fc2a0ff39b2b8166deca41425771ea9ed04e469
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoSprinkle @NonNull on FrontendClientMetadataBuilder fields 00/98300/2
Robert Varga [Sat, 6 Nov 2021 09:18:02 +0000 (10:18 +0100)]
Sprinkle @NonNull on FrontendClientMetadataBuilder fields

We have two fields which are guaranteed to be @NonNull, mark them as
such, making it clear we comply to getIdentifier() contract.

Change-Id: I9159823fb6c8a4a3c064796cb6752f57d98846c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoCorrect Frontend{Client,History}Metadata deserialization 99/98299/2
Robert Varga [Sat, 6 Nov 2021 09:08:05 +0000 (10:08 +0100)]
Correct Frontend{Client,History}Metadata deserialization

We are turning Range.closedOpen() into Range.closed() during
deserialization, which the resulting ends up also covering the upper
bound, which it should not.

JIRA: CONTROLLER-1942
Change-Id: Ib8f9016e2eddcf014ff5e451ac82cd77b66d7019
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoCorrect annotations 97/98297/3
Robert Varga [Fri, 5 Nov 2021 10:25:41 +0000 (11:25 +0100)]
Correct annotations

Correct @GuardedBy vs @Holding and add @NonNull annotations.

Change-Id: I2142b1c5910f2388e8f30a04f7ff8bc8237dde26
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoFix eos entity lookups with YangInstanceIdentifier 81/98281/4
Tomas Cere [Wed, 3 Nov 2021 11:20:45 +0000 (12:20 +0100)]
Fix eos entity lookups with YangInstanceIdentifier

Caused by entity-name only being a string type which was inadvertently
trying to lookup all entities as General.

Fix this by changing entity-name to a union of instance-identifier and
string.

Also changed up the output of get-entities slightly:
- if the entity is string based it will only contain the name in the
  output.
- if, however, it is Instance-identifier based it will contain the
  entire identifier in the name field.

JIRA: CONTROLLER-2009
Change-Id: I93e108bd54b14850b6bf276ec1eca4d7671d7d87
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoBump version to 4.0.6-SNAPSHOT 56/98156/1
Robert Varga [Wed, 27 Oct 2021 08:25:57 +0000 (10:25 +0200)]
Bump version to 4.0.6-SNAPSHOT

This starts the next development iteration.

Change-Id: I48c884e1f35f9509b811bb654fdec22c3dc198b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 months agoRealign odlparent versions 49/98149/1
Robert Varga [Tue, 26 Oct 2021 23:02:31 +0000 (01:02 +0200)]
Realign odlparent versions

We have a misalignment of versions, which may hurt downstreams. Also
bump mdsal, as it is fixing the same issue.

JIRA: CONTROLLER-2008
Change-Id: Iacf5921d4f960eaef554419cd6b2dac3494fd2a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoBump versions to 4.0.5-SNAPSHOT 22/98022/1
Robert Varga [Thu, 21 Oct 2021 07:47:34 +0000 (09:47 +0200)]
Bump versions to 4.0.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I8f8e85a7b2bb1a07f0d05948d372ae3f7d42345a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoMerge (Abstract)TransactionContext 86/97586/8
Robert Varga [Tue, 21 Sep 2021 19:01:27 +0000 (21:01 +0200)]
Merge (Abstract)TransactionContext

We have an interface and an abstract base class. Merge the two into
an abstract class, reducing visibility of various methods. Also derive
from AbstractSimpleIdentifiable, to make it more explicit we require
a transaction identifier.

This allows all callers to bind to the same vtable, improving method
dispatch.

Change-Id: I51419c4ac832aa676c8707d9bd459936fd906760
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoBump upstreams 19/98019/2
Robert Varga [Thu, 21 Oct 2021 07:01:58 +0000 (09:01 +0200)]
Bump upstreams

Use odlparent-9.0.7, yangtools-7.0.9, mdsal-8.0.6.

Change-Id: I661a98b52b7b93b63a348e15deb4b548ca0f5075
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoTune eos gossip/notification intervals 73/97973/3
Tomas Cere [Tue, 19 Oct 2021 08:54:47 +0000 (10:54 +0200)]
Tune eos gossip/notification intervals

Looks like eos gossips take much too long, so lets
lower these so we have faster response times all around.

JIRA: CONTROLLER-2004
Change-Id: I3daf8d207a6b51b16e6b8cb3f7dcefd55e6626cf
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoPull in atinject_spec-1.0 55/97955/2
Robert Varga [Sun, 17 Oct 2021 14:31:40 +0000 (16:31 +0200)]
Pull in atinject_spec-1.0

pax-exam is using version 1.0, make sure we can work nicely with it.
Should fix controller-sonar failures.

Change-Id: I0f185b02a5b63ddadfd72993160db350f9513164
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoBump to akka-2.6.17 01/97901/2
Robert Varga [Fri, 15 Oct 2021 11:41:34 +0000 (13:41 +0200)]
Bump to akka-2.6.17

https://akka.io/blog/news/2021/10/15/akka-2.6.17-released

Change-Id: I4183b02b42fb3dcda599ba77c73d26832fabea7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoBump Scala to 2.13.6 00/97900/1
Robert Varga [Fri, 15 Oct 2021 11:39:23 +0000 (13:39 +0200)]
Bump Scala to 2.13.6

https://github.com/scala/scala/releases/tag/v2.13.6

Change-Id: I6fba6c4d7856446d54cb016ec3a93f4976375a0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoCleanup LogGenerator 99/97899/1
Robert Varga [Fri, 15 Oct 2021 10:52:02 +0000 (12:52 +0200)]
Cleanup LogGenerator

We are getting flagged in SonarCloud for this example, clean it up.

Change-Id: I9665e444857f6fb5b67a1bcb064d10b0ada8069b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoMove odl-controller-blueprint dependency 55/97855/1
Robert Varga [Sat, 9 Oct 2021 09:42:04 +0000 (11:42 +0200)]
Move odl-controller-blueprint dependency

Nothing in odl-mdsal-distributed-datastore needs blueprint, move
the dependency to lower blueprint exposure a bit.

JIRA: CONTROLLER-1999
Change-Id: Idea6146c9cdb9d0db363f6d0443e0294af42f72b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoDo not use odl blueprint in odl-controller-exp-netty-config 54/97854/1
Robert Varga [Sat, 9 Oct 2021 08:26:54 +0000 (10:26 +0200)]
Do not use odl blueprint in odl-controller-exp-netty-config

Components packaged here do not need ODL blueprint extensions, do
not pull in the corresponding plugin.

JIRA: CONTROLLER-2005
Change-Id: Ibd45c6e9aee39eba83ab7c266cababfde2d7ff5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoMigrate rpcbenchmark to OSGi DS 26/97726/4
Robert Varga [Mon, 4 Oct 2021 08:12:30 +0000 (10:12 +0200)]
Migrate rpcbenchmark to OSGi DS

Ditch blueprint and use turn NtfBenchmarkProvider into a simple
component. Requires some amount of refactoring.

JIRA: CONTROLLER-2001
Change-Id: Ib8db52d91013fe1ae13c55b5537b743f8ccbf320
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoMigrate ntfbenchmark to OSGi DS 22/97722/3
Robert Varga [Sun, 3 Oct 2021 14:33:33 +0000 (16:33 +0200)]
Migrate ntfbenchmark to OSGi DS

Ditch blueprint and use turn NtfBenchmarkProvider into a simple
component.

JIRA: CONTROLLER-2001
Change-Id: I68dd5559f61c28bbdcbff54815af7d287e948a50
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 months agoMigrate dsbenchmark to OSGi DS 87/97687/1
Robert Varga [Thu, 30 Sep 2021 12:09:35 +0000 (14:09 +0200)]
Migrate dsbenchmark to OSGi DS

Ditch blueprint and use turn DsbenchmarkProvider into a simple
component.

JIRA: CONTROLLER-2001
Change-Id: I5378359af1ae12d2f7cc03c281599f71ded5a06a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoUse URLEncoder.encode(String, Charset) 89/97589/3
Robert Varga [Tue, 21 Sep 2021 20:10:37 +0000 (22:10 +0200)]
Use URLEncoder.encode(String, Charset)

We are running with Java 11 and as Modernizer correctly points out, we
can use direct charset variant which was introduced with Java 10. This
cuts down a tiny bit of dead code.

Change-Id: I7c42984bc1e05e94f5266f26e13aaab650ae4f70
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoIntroduce cli commands for cluster-admin 34/97434/9
Dominik Vrbovsky [Fri, 10 Sep 2021 09:09:41 +0000 (11:09 +0200)]
Introduce cli commands for cluster-admin

Rework the rpcs needed by csit in cluster-admin to karaf cli commands

JIRA: CONTROLLER-1996
Change-Id: I148c7c9140701ff8ffe81c612999898115f4661d
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
8 months agoSpecialize TransactionContextWrapper 64/90864/56
tadei.bilan [Thu, 2 Jul 2020 10:48:54 +0000 (13:48 +0300)]
Specialize TransactionContextWrapper

Most of the time we are talking to local leader, in which case
we do not need to queue messages and bounce them through the queue.

JIRA: CONTROLLER-1952
Change-Id: I07d85c82c2ab6e4251c70b2e6d1dafa2dc455d39
Signed-off-by: tadei.bilan <tadei.bilan@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoBe mindful of non-existent actors 72/97572/1
Robert Varga [Tue, 21 Sep 2021 09:49:06 +0000 (11:49 +0200)]
Be mindful of non-existent actors

We have observed the following splat in SFT:

java.lang.NullPointerException: null
        at org.opendaylight.controller.eos.akka.registry.listener.type.EntityTypeListenerRegistry.onUnregisterListener(EntityTypeListenerRegistry.java:69) ~[bundleFile:?]
        at akka.actor.typed.javadsl.BuiltReceive.receive(ReceiveBuilder.scala:213) ~[bundleFile:?]

This this by checking whether we actually removed a listener.

Change-Id: Ifc80ae650db05fd1031af074c694588034f6903a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoBump versions to 4.0.4-SNAPSHOT 94/97494/1
Robert Varga [Wed, 15 Sep 2021 10:52:50 +0000 (12:52 +0200)]
Bump versions to 4.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I06cec6aa2381d9aa96edb2555352458bdc60d0a9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoAdd a private modifiers to command arguments in clustering-test-app 90/97490/2
Dominik Vrbovsky [Tue, 14 Sep 2021 14:07:12 +0000 (16:07 +0200)]
Add a private modifiers to command arguments in clustering-test-app

Change-Id: I29e188d39a7dc507c0f9f61f086e699522757dc5
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
8 months agoIncrease eos-dom-akka teardown timeouts 89/97489/1
Tomas Cere [Tue, 14 Sep 2021 12:26:58 +0000 (14:26 +0200)]
Increase eos-dom-akka teardown timeouts

Looks like the default 10 seconds is not quite enough on releng.
Increase the default shutdown timeouts to 20 seconds.

Change-Id: I6a5b3bc6822835dd2515cef86de7376162d070bf
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
8 months agoIntroduce cli commands for clustering-test-app 14/97414/7
Dominik Vrbovsky [Tue, 7 Sep 2021 16:10:31 +0000 (18:10 +0200)]
Introduce cli commands for clustering-test-app

Rework the rpcs needed by csit in clustering-test-app to Karaf CLI commands.
This is essentially a custom-coded invocation of MD-SAL services.

JIRA: CONTROLLER-1995
Change-Id: If406a4dff6d441e9d0932de05f844d66f1e5bc83
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoBump upstreams 52/97452/1
Robert Varga [Sun, 12 Sep 2021 13:30:56 +0000 (15:30 +0200)]
Bump upstreams

Use odlparent-9.0.6, yangtools-7.0.8, mdsal-8.0.5.

Change-Id: Ib14c3b138a88e58104650bd2026618d53fec1011
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoUse terminate message in eos listener actors 11/97411/3
Tomas Cere [Tue, 7 Sep 2021 09:49:19 +0000 (11:49 +0200)]
Use terminate message in eos listener actors

getContext().stop() can cause NPE during actor system
shutdown so lets use a terminate message here instead.
Its still possible to get dead letters with this approach
when the child actor was stopped first during the shutdown,
but at least we prevent the NPEs.

JIRA: CONTROLLER-1989
Change-Id: Id38b56c12141164d45ed19613885a4d9f650e4dd
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
8 months agoBump akka to 2.6.16 34/95334/14
Robert Varga [Wed, 24 Feb 2021 09:05:26 +0000 (10:05 +0100)]
Bump akka to 2.6.16

https://akka.io/blog/news/2021/02/23/akka-2.6.13-released
https://akka.io/blog/news/2021/04/08/akka-2.6.14-released
https://akka.io/blog/news/2021/06/10/akka-2.6.15-released
https://akka.io/blog/news/2021/08/19/akka-2.6.16-released

Change-Id: I6d255bd6d2b4b1284bb6c7d8ccae4ec44a691556
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
8 months agoCleanup OwnerSupervisor a bit 21/97321/3
Robert Varga [Tue, 24 Aug 2021 21:37:13 +0000 (23:37 +0200)]
Cleanup OwnerSupervisor a bit

Use streaming to reduce funky copy/remove/remove cycle. This way
we perform minimal needed materialization.

Change-Id: I0cf25fc7bb57e2d053cb4368cdd4ac8905995e42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoBump versions to 4.0.3-SNAPSHOT 22/97322/2
Robert Varga [Wed, 25 Aug 2021 08:20:08 +0000 (10:20 +0200)]
Bump versions to 4.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I5c4e26a129c037afa783b309ceb031435677faea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoFix parent reference 23/97323/1
Robert Varga [Wed, 25 Aug 2021 09:05:52 +0000 (11:05 +0200)]
Fix parent reference

The relativePath needs to point to correct pom, fix that.

Change-Id: I76382cc09ec294f585cdb7fdc1fd86a0bc2762b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoExpose entity details in MDSAL 11/97111/14
Robert Varga [Mon, 9 Aug 2021 16:00:28 +0000 (18:00 +0200)]
Expose entity details in MDSAL

Our previous implementation was very open about it state, which was
completely visible through RESTCONF (and from datastore).

We have a number of tools which need information relating to where each
entity lives -- and to that effect we want to expose a read-only API.

This patch instroduces odl-akka-eos model, which exposes a few RPCs,
which in turn provide information formerly visible from the datastore.

JIRA: CONTROLLER-1992
Change-Id: I85da8941f84ca9e109c4dec61fb07a697e937639
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
8 months agoRemove PeerUp/Down messages 15/97315/2
Tomas Cere [Tue, 24 Aug 2021 11:42:20 +0000 (13:42 +0200)]
Remove PeerUp/Down messages

These were used only in EntityOwnershipShard and thus
can be removed.

JIRA: CONTROLLER-1993
Change-Id: I49873bf7e379c996719d6ec1b3bfc88395b3f3fd
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
8 months agoHandle owner changed message 05/97305/2
Tomas Cere [Tue, 24 Aug 2021 09:07:19 +0000 (11:07 +0200)]
Handle owner changed message

We need to handle this response message otherwise
it ends up in dead letters polluting logs.

JIRA: CONTROLLER-1994
Change-Id: Idd110e48a10f2d290b2a587fdd2dcf11f2a89d51
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoBump upstreams 20/97320/1
Robert Varga [Tue, 24 Aug 2021 17:59:15 +0000 (19:59 +0200)]
Bump upstreams

Adopt odlparent-9.0.5, yangtools-7.0.7, mdsal-8.0.4

Change-Id: I5d6be3c4c658668aa41f659c7956fe42a0501d52
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoBump upstreams 02/97302/2
Robert Varga [Mon, 23 Aug 2021 19:50:38 +0000 (21:50 +0200)]
Bump upstreams

Adopt odlparent-9.0.4, yangtools-7.0.6, mdsal-8.0.3

Change-Id: I1cea6ced706978b2bd3e11b0532b2ec5f1da55a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoBump odlparent/yangtools/mdsal 79/97279/2
Robert Varga [Fri, 20 Aug 2021 12:44:18 +0000 (14:44 +0200)]
Bump odlparent/yangtools/mdsal

Adopt latest versions, namely;
- odlparent-9.0.3
- yangtools-7.0.5
- mdsal-8.0.2

Change-Id: I11e44a49e1ba55ed45aa890efcbe353f4591a11f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoFixup DataCenterControl javadocs 47/97247/1
Robert Varga [Wed, 18 Aug 2021 20:13:28 +0000 (22:13 +0200)]
Fixup DataCenterControl javadocs

Add a @return and improve phrasing a bit.

Change-Id: Ic9d4cca1a98d2618a9765f34bebc0f5d98657b34
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
9 months agoRename NativeEosService to DataCenterControl 43/97243/4
Robert Varga [Tue, 17 Aug 2021 22:57:08 +0000 (00:57 +0200)]
Rename NativeEosService to DataCenterControl

This is a wee bit more descriptive name. While we are here, also ditch
java.lang.Void, as it promotes nulls. Use yamg.common.Empty, which has a
singleton instance.

Fold common implementation code into a static method, which is making
things very obvious.

Change-Id: I28230523034224e978244d1edce997376812bf91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoBump versions to 4.0.2-SNAPSHOT 20/97020/1
Robert Varga [Sun, 25 Jul 2021 05:25:54 +0000 (07:25 +0200)]
Bump versions to 4.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I41da66267aec81d79ab0d60a7b6f87827a0bf350
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoBump mdsal/yangtools 19/97019/1
Robert Varga [Sat, 24 Jul 2021 23:08:40 +0000 (01:08 +0200)]
Bump mdsal/yangtools

Adopt yangtools-7.0.4 and mdsal-8.0.1.

Change-Id: I832db6bf295da8b9bd55a15628a975b70e0852ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoIgnore DataTreeChangeReply message 75/96875/1
Robert Varga [Tue, 13 Jul 2021 11:31:26 +0000 (13:31 +0200)]
Ignore DataTreeChangeReply message

DataTreeChangeListenerActor is sending replies towards shard on each
processed datatree change. This is not handled by Shard, which ends up
flooding dead letters.

Make sure we ignore these messages, so that the logs are cleaner. Also
speed up the non-null check in DTCLActor.

JIRA: CONTROLLER-1986
Change-Id: I11b172d778c5b8cdf16aec58e77ec7faa9b6b146
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoBump versions to 4.0.1-SNAPSHOT 81/96781/1
Robert Varga [Fri, 2 Jul 2021 13:49:35 +0000 (15:49 +0200)]
Bump versions to 4.0.1-SNAPSHOT

This starts the next development interation.

Change-Id: I9f28f1a3d346b2288c77b43b612ee136c1b6ab3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoFix MXBean annotation warnings 80/96780/1
Robert Varga [Fri, 2 Jul 2021 13:30:52 +0000 (15:30 +0200)]
Fix MXBean annotation warnings

Use transitive requires to expose annotations to downstream users.

Change-Id: If7a47430c7c2a25d80fae05717113d42373885c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoRemove support for payloads older than Sodium SR1 78/96778/2
Robert Varga [Fri, 2 Jul 2021 11:44:59 +0000 (13:44 +0200)]
Remove support for payloads older than Sodium SR1

Older payloads are not as efficient, nor can they really support
all our datatypes. Prune supported versions to Sodium SR1-and-newer,
retaining 2 years worth of backwards compatibility.

JIRA: CONTROLLER-1985
Change-Id: I5ebabee1ddff37af7c0e0a5dca91db433ca9d5ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoRemove support for pre-Sodium SR1 peers 77/96777/1
Robert Varga [Fri, 2 Jul 2021 11:34:00 +0000 (13:34 +0200)]
Remove support for pre-Sodium SR1 peers

The messages exchanged between cluster participants are versioned to
maintain backwards compatibility. Trim how far back we can go to
Sodium SR1 -- breaking compatibility with Boron, Fluorine and
Neon SR2 software.

JIRA: CONTROLLER-1985
Change-Id: I11ba4041242650bc3ad70da3f4b2869df0ca5ceb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoVersionedExternalizableMessage.getVersion() is final 76/96776/2
Robert Varga [Fri, 2 Jul 2021 10:58:04 +0000 (12:58 +0200)]
VersionedExternalizableMessage.getVersion() is final

This is a property which is under control of the baseline class,
do not allow it to be modified.

Change-Id: Icab5e415954b27842f5af65ecde75202a0c53589
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoActivate DataStoreVersions.PHOSPHORUS_VERSION 75/96775/2
Robert Varga [Fri, 2 Jul 2021 10:37:34 +0000 (12:37 +0200)]
Activate DataStoreVersions.PHOSPHORUS_VERSION

Flip the current version to Phosphorus, taking making a few
improvements:
- CompositeModification's structure is better
- BigInteger is no longer supported

JIRA: CONTROLLER-1939
Change-Id: If6105c302a9d7c3b4a6591600d62a04abf55d582
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoAdd new MutableCompositeModification version 58/93858/14
tadei.bilan [Tue, 17 Nov 2020 13:39:03 +0000 (15:39 +0200)]
Add new MutableCompositeModification version

Add new version of MutableCompositeModification, that will write NNDO
header right after number of modifications, forming proper embedded
block of modifications.

For communicating this, we are renaming
DataStoreVersions.MAGNESIUM_VERSION and reusing it for the bump.

JIRA: CONTROLLER-1939
Change-Id: Ic5c2a8f91fcc41e78682ec202442308d6dc1191a
Signed-off-by: tadei.bilan <tadei.bilan@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoFixup docs dependencies 66/96766/1
Robert Varga [Thu, 1 Jul 2021 14:41:26 +0000 (16:41 +0200)]
Fixup docs dependencies

We have a @PreDestroy reference, make sure docs compile.

Change-Id: I72537f6ea6be660971db0bc8e6f1114d9fb92eab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoRemove obsolete datastore.cfg properties 59/96759/5
Robert Varga [Thu, 1 Jul 2021 08:48:11 +0000 (10:48 +0200)]
Remove obsolete datastore.cfg properties

We have a number of leftovers here, which have been no-ops. Remove them
to reduce code clutter.

JIRA: CONTROLLER-1984
Change-Id: I490188fb7ebc83c344997861d637852f40fce7a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoHide ShardManagerSnapshot 62/96762/1
Robert Varga [Thu, 1 Jul 2021 10:28:41 +0000 (12:28 +0200)]
Hide ShardManagerSnapshot

This class is scheduled for removal. Hide it before removing it.

Change-Id: I902d33da14411ec44429de5474d953adc9722dea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoUpdate sal-distributed-datastore tests a bit 61/96761/2
Robert Varga [Thu, 1 Jul 2021 09:30:07 +0000 (11:30 +0200)]
Update sal-distributed-datastore tests a bit

Use MockitoJUnitRunner and clean up imports/mocking a bit.

Change-Id: I854f95e37e503d28903c8aa83aecafdef4c4c1fa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoLock down ShardDataTree 54/96754/3
Robert Varga [Wed, 30 Jun 2021 21:32:34 +0000 (23:32 +0200)]
Lock down ShardDataTree

Now that our primary user is an implmentation detail, we can lock down a
few aspects of ShardDataTree operation. This will ease refactoring
further down the road.

Change-Id: I91248347889ea0ceecee9f093f54b5d8241fb39c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoUpdate SimpleShardDataTreeCohortTest 60/96760/1
Robert Varga [Thu, 1 Jul 2021 08:32:42 +0000 (10:32 +0200)]
Update SimpleShardDataTreeCohortTest

Use MockitoJUnitRunner instead of MockitoAnnotations.initMocks().

Change-Id: I2a96d971ca100278e495f826c988f85e2f83efb1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoRemove org.opendaylight.controller.sal.common.util 58/96758/2
Robert Varga [Thu, 1 Jul 2021 07:42:10 +0000 (09:42 +0200)]
Remove org.opendaylight.controller.sal.common.util

Arguments and NoopAutoCloseable have been deprecated for removal, remove
them now.

Change-Id: I72017f2cf9deffb99d493392a84ca829c639c592
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoFix sal-common-util dependencies 57/96757/2
Robert Varga [Thu, 1 Jul 2021 07:40:45 +0000 (09:40 +0200)]
Fix sal-common-util dependencies

We have a number of unused dependencies here, clean them up.

Change-Id: Ibc534ab9ba28a7e70270a042a1b8e55f8934bc28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoLock down controller.cluster.datastore.Shard 53/96753/1
Robert Varga [Wed, 30 Jun 2021 21:14:31 +0000 (23:14 +0200)]
Lock down controller.cluster.datastore.Shard

Since sal-distributed-eos is gone, we do not have any known subclasses,
lock down Shard implementation as much as possible. This will aid us in
refactoring later. The entire class is now considered an implementation
detail, amenable to changes driven by RaftActor evolution.

Change-Id: Ic54794b33766459f16a5ebdac6a3faa731c2b49d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoRemove an TrieMap dependency 52/96752/1
Robert Varga [Wed, 30 Jun 2021 21:13:32 +0000 (23:13 +0200)]
Remove an TrieMap dependency

We are not using TrieMap directly, do not hard-code a dependency on it.

Change-Id: I3285e2f1484c1f9db9dd4b149f469c9392ddb7d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoRemove sal-distrubited-eos 51/96751/1
Robert Varga [Wed, 30 Jun 2021 20:16:56 +0000 (22:16 +0200)]
Remove sal-distrubited-eos

There are no more packaging references to datastore-based entity
ownership. Remove the implementation.

JIRA: CONTROLLER-1982
Change-Id: Ia6a96a1853e0f173d7af559c76a06e9dfadc540e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoAdd integration test with cluster-singleton 60/96160/15
Tomas Cere [Fri, 7 May 2021 12:04:52 +0000 (14:04 +0200)]
Add integration test with cluster-singleton

JIRA: CONTROLLER-1982
Change-Id: I75aec3a46da42c38287970590006655a2d15b926
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
10 months agoCleanup candidate registrations from previous instance 59/96159/13
Tomas Cere [Tue, 11 May 2021 10:32:01 +0000 (12:32 +0200)]
Cleanup candidate registrations from previous instance

JIRA: CONTROLLER-1982
Change-Id: I5337b08f6fd951a7a2acabb935cbf2e2156f5985
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
10 months agoAdd cluster-admin api for datacenter activation 81/95981/14
Tomas Cere [Mon, 3 May 2021 11:26:08 +0000 (13:26 +0200)]
Add cluster-admin api for datacenter activation

Add rpcs into cluster-admin so we can activate/deactivate
datacenters for active/backup scenariop.

JIRA: CONTROLLER-1982
Change-Id: Ic68652199d79251fe9b166e47ca06520121213e4
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
10 months agoSnapshot and journal export on recovery 53/90453/81
tadei.bilan [Mon, 15 Jun 2020 13:31:00 +0000 (16:31 +0300)]
Snapshot and journal export on recovery

Added ability to export snapshot and journal content into json file
during recovery.

JIRA: CONTROLLER-1955
Change-Id: Ic2d6181ab56d7b413f06ed91cf5f9d37e3aa2029
Signed-off-by: tadei.bilan <tadei.bilan@pantheon.tech>
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoUse akka-multi-dc in eos native 80/95980/18
Tomas Cere [Fri, 30 Apr 2021 10:05:55 +0000 (12:05 +0200)]
Use akka-multi-dc in eos native

Add the ability to activate/deactivate singleton supervisor.
Make the supervisor pick owners only from the active datacenter.
All in all this should give us the building blocks needed for
the active/backup cluster use-case.

JIRA: CONTROLLER-1982
Change-Id: Iae0a4a59cc461c8187c59bb8a5a66c73dee5be4c
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoUpgrade lz4-java to 1.8.0 08/96708/2
Robert Varga [Tue, 29 Jun 2021 08:47:28 +0000 (10:47 +0200)]
Upgrade lz4-java to 1.8.0

https://github.com/lz4/lz4-java/releases/tag/1.8.0

Change-Id: Ica9bc96f8db76cb8dd8eda19264f72bfb1ea674c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoClean up sal-clustering-commons dependencies 07/96707/2
Robert Varga [Tue, 29 Jun 2021 08:44:43 +0000 (10:44 +0200)]
Clean up sal-clustering-commons dependencies

We are not using yang-model-util here.

Change-Id: I30c03983964f614cfe0d19e2494f1ccdf0f53a79
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoCleanup cds-access-api dependencies 06/96706/2
Robert Varga [Tue, 29 Jun 2021 08:43:58 +0000 (10:43 +0200)]
Cleanup cds-access-api dependencies

We do not need sal-clustering-commons anymore, as the requisite
functionality has been upstreamed.

Change-Id: Ia2bcf61e1eaed79e349fad811e88e710f76a232d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
10 months agoConvert netty-threadgroup-config to OSGi DS 03/96703/2
Robert Varga [Mon, 28 Jun 2021 17:53:47 +0000 (19:53 +0200)]
Convert netty-threadgroup-config to OSGi DS

This is a rather simple wiring, use OSGi DS instead of blueprint.

Change-Id: I49686821b3d7f70ae058d3362b16d9c6acae8d03
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>