controller.git
9 years agoMerge "Added extensible implementation of Transformators"
Giovanni Meo [Wed, 29 May 2013 14:30:08 +0000 (14:30 +0000)]
Merge "Added extensible implementation of Transformators"

9 years agoMerge "Correct maven dependency for MavenProject"
Giovanni Meo [Wed, 29 May 2013 14:13:51 +0000 (14:13 +0000)]
Merge "Correct maven dependency for MavenProject"

9 years agoAdded extensible implementation of Transformators 02/402/1
Tony Tkacik [Tue, 28 May 2013 11:26:05 +0000 (13:26 +0200)]
Added extensible implementation of Transformators

- set of generic Transformers - factories responsible for producing
  outputs based on input objects
  - Ideal for development of translation layers between protocol
  specific objects and abstract transfer objects such as Actions in SAL.

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoCorrect maven dependency for MavenProject 01/401/2
Robert Varga [Wed, 29 May 2013 02:41:21 +0000 (04:41 +0200)]
Correct maven dependency for MavenProject

The name of the artifact which exports
org.apache.maven.project.MavenProject has changed between maven 2.x and
3.x to mave-core. Update the dependency to pick up the changes, which
include generics -- allowing for safer codegen.

Change-Id: I6237eb935e837e8ff887f8e072be12dd8ddb4c8c
Signed-off-by: Martin Vitez <mvitez@cisco.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
9 years agoStatistics Northbound Integration Test 00/400/1
Kalvin Hom [Wed, 29 May 2013 01:02:38 +0000 (18:02 -0700)]
Statistics Northbound Integration Test

Added northbound tests for node specific
requests

Change-Id: I7e0c1ce446f91d29665837fac645ea09693f29d9
Signed-off-by: Kalvin Hom <kahom@cisco.com>
9 years agoNodeFactory service 99/399/2
Kalvin Hom [Tue, 28 May 2013 23:41:12 +0000 (16:41 -0700)]
NodeFactory service

Added INodeFactory interface in SAL to
handle creation of different Node types;

Node will use INodeFactory to create Nodes
that are not one of the preset types;

StubNodeFactory for plugin stub creates
Nodes of STUB type;

Change-Id: I727eb7e4eae8daacf732b0856f6d0cc1d55ba749
Signed-off-by: Kalvin Hom <kahom@cisco.com>
9 years agoExtend getJsonResult() to accommodate HTTP methods other than "GET". 98/398/1
taochang [Tue, 28 May 2013 21:43:36 +0000 (14:43 -0700)]
Extend getJsonResult() to accommodate HTTP methods other than "GET".
Also pass the HTTP response code to calling program.

Change-Id: Ie5ff6af9765a82ea5dbf7d2108da081b15c65d76
Signed-off-by: taochang <taochang@cisco.com>
9 years agoMerge "Fixed dependency management."
Giovanni Meo [Tue, 28 May 2013 18:30:52 +0000 (18:30 +0000)]
Merge "Fixed dependency management."

9 years agoMerge "Fixed yang grouping resolution. Fixed refine parsing. Updated tests."
Giovanni Meo [Tue, 28 May 2013 18:25:37 +0000 (18:25 +0000)]
Merge "Fixed yang grouping resolution. Fixed refine parsing. Updated tests."

9 years agoMerge "Fixed whitespace for Gerrit 393"
Giovanni Meo [Tue, 28 May 2013 18:19:25 +0000 (18:19 +0000)]
Merge "Fixed whitespace for Gerrit 393"

9 years agoMerge "Fix for bug 24."
Giovanni Meo [Tue, 28 May 2013 18:18:24 +0000 (18:18 +0000)]
Merge "Fix for bug 24."

9 years agoFixed dependency management. 96/396/1
lsedlak [Tue, 28 May 2013 14:44:41 +0000 (16:44 +0200)]
Fixed dependency management.

Fixed dependency management for Binding Generator and Yang projects.

Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
9 years agoFixed yang grouping resolution. 95/395/2
Martin Vitez [Mon, 27 May 2013 15:10:16 +0000 (17:10 +0200)]
Fixed yang grouping resolution.
Fixed refine parsing. Updated tests.

Change-Id: I1d0b27458fde7b7b78cbaff6af210b5885493506
Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoFixed whitespace for Gerrit 393 94/394/1
Ed Warnicke [Sat, 25 May 2013 17:35:39 +0000 (12:35 -0500)]
Fixed whitespace for Gerrit 393

This commit is primarily about experimenting
with commits against not yet merged Gerrits.
I took as an opportunity doing this patch to fix
some tabs and trailing whitespaces for
https://git.opendaylight.org/gerrit/#/c/393/

Change-Id: If9573cfc36c1554894854821b530443243a72070
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFix for bug 24. 93/393/5
Chi-Vien Ly [Fri, 24 May 2013 23:24:55 +0000 (16:24 -0700)]
Fix for bug 24.

Description: Ping between host hosts takes more than 1second
Solution: Make modification in ArpHandler to handle the followings
- When a ARP Request is received from an host (requestor) to an unknown target host, an requestor entry is added. This will be used by ArpHandler to relay the ARP Reply back to this requestor once the target host replies.
- These target hosts  are saved and timed for up to 2sec. If the target host does not reply within up to 2sec, the host will be removed. This housekeeping process is implemented in a periodic timer task.

Change-Id: I85c6c1ef7c55845a76920ad1023b45ec6ac41974
Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
9 years agoRefactored yang-model-parser-impl to improve readability. SchemaContextImpl moved... 92/392/1
Martin Vitez [Fri, 24 May 2013 15:14:33 +0000 (17:14 +0200)]
Refactored yang-model-parser-impl to improve readability. SchemaContextImpl moved to separate class. Fixed parsing of refine statement. Fixed bug in YangParser.g4 in min-elements statement.
Updated tests. Improved code generation: added import statemets to generated code.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoMerge "Statistics Northbound Test"
Giovanni Meo [Fri, 24 May 2013 09:42:32 +0000 (09:42 +0000)]
Merge "Statistics Northbound Test"

9 years agoMerge "ICMP fix and Packet class should store and provide access to the raw payload...
Giovanni Meo [Fri, 24 May 2013 09:41:16 +0000 (09:41 +0000)]
Merge "ICMP fix and Packet class should store and provide access to the raw payload in case no packet class is available to parse it."

9 years agoMerge "CodeGenerator update."
Giovanni Meo [Fri, 24 May 2013 09:34:09 +0000 (09:34 +0000)]
Merge "CodeGenerator update."

9 years agoMerge "Refactored yang-maven-plugin. Updated tests. Removed backup files."
Giovanni Meo [Fri, 24 May 2013 09:33:13 +0000 (09:33 +0000)]
Merge "Refactored yang-maven-plugin. Updated tests. Removed backup files."

9 years agoICMP fix and Packet class should store and provide access to the raw payload in case... 88/388/3
Alessandro Boch [Thu, 23 May 2013 01:01:41 +0000 (18:01 -0700)]
ICMP fix and Packet class should store and provide access to the raw payload in case no packet class is available to parse it.

- Packet to store a copy of the raw payload if no packet class is present to parse it
- Added missing code for ICMP
- Refactored PAcket, ICMP and IPv4 code
- Fixed corrupted flag setting when comparing checksum after deserializing
- Added Junit for IPv4.computeChecksum() and for serilaize/deserialize ICMP message
- Addressed some eclipse and static analysis warnings

Change-Id:If2ae95cbc3462ffcda8662e27efd9de5614872ef
Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoStatistics Northbound Test 91/391/2
Kalvin Hom [Fri, 24 May 2013 00:35:34 +0000 (17:35 -0700)]
Statistics Northbound Test

Added to stub plugin's ReadService
to return a flow for each action type

Adding additional tests for checking
that actions are being passed up
properly to the northbound

Change-Id: I01548fad2efadada3d7991616787baf6f8e9b0b8
Signed-off-by: Kalvin Hom <kahom@cisco.com>
9 years agoCodeGenerator update. 89/389/1
Martin Vitez [Thu, 23 May 2013 15:03:50 +0000 (17:03 +0200)]
CodeGenerator update.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoRefactored yang-maven-plugin. Updated tests. 85/385/5
Martin Vitez [Wed, 22 May 2013 13:12:51 +0000 (15:12 +0200)]
Refactored yang-maven-plugin. Updated tests.
Removed backup files.

Change-Id: Ic1cd3f0cafba7c9eee2c6a39aadb77c50db88fc2
Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoEquals/HashCode/StringBuilder removal from Supported/PeerBandwidth 75/375/3
Ed Warnicke [Fri, 17 May 2013 15:33:10 +0000 (08:33 -0700)]
Equals/HashCode/StringBuilder removal from Supported/PeerBandwidth

Supported/PeerBandwidth does not add any new non-static members, so it should be
safe to simply fall back to the parent classes equals/hashcode.

Change-Id: I9951a7539b8371365266ac9fe49e286573748f06
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoEquals/HashCode/StringBuilder removal 74/374/3
Ed Warnicke [Fri, 17 May 2013 15:30:48 +0000 (08:30 -0700)]
Equals/HashCode/StringBuilder removal

AdvertisedBandwidth is a subclass of Bandwidth.  Bandwidth has equals/hashcode.
AsvertisedBandwidth does not add any new non-static members, so it should be
safe to simply fall back to the parent classes equals/hashcode.

Change-Id: I7da7155af144e099510f14e1db2c57f12a2cb083
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoTwo more Equals/HashCode/StringBuilder replacements 73/373/3
Ed Warnicke [Fri, 17 May 2013 15:26:09 +0000 (08:26 -0700)]
Two more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Eleventh set.

Change-Id: I45b20ae7c5d285598a1e1a0bfa9fbbfa7c1b617a
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFive more Equals/HashCode/StringBuilder replacements 72/372/4
Ed Warnicke [Fri, 17 May 2013 15:12:09 +0000 (08:12 -0700)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Tenth set.

Change-Id: I62a1b9724ed235c6b406fbbf2a005606cfd9d87e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoFive more Equals/HashCode/StringBuilder replacements 71/371/4
Ed Warnicke [Fri, 17 May 2013 15:10:12 +0000 (08:10 -0700)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Ninth set.

Change-Id: Icf3ea474ed0313ab92e93717658f20f6bc7c228c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFive more Equals/HashCode/StringBuilder replacements 70/370/4
Ed Warnicke [Fri, 17 May 2013 15:07:18 +0000 (08:07 -0700)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Eighth set.

Change-Id: I47e13d6ae3ecfcb574aa33c78579271eee16b2eb
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "Five more Equals/HashCode/StringBuilder replacements"
Giovanni Meo [Thu, 23 May 2013 08:25:01 +0000 (08:25 +0000)]
Merge "Five more Equals/HashCode/StringBuilder replacements"

9 years agoFive more Equals/HashCode/StringBuilder replacements 69/369/4
Ed Warnicke [Fri, 17 May 2013 15:04:23 +0000 (08:04 -0700)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Seventh set.

Fixed to no longer use NodeIDString in Node or NodeConnectorIDString in
NodeConnector when computing equality or hashcode.

Change-Id: Ic433f705cb27c6454ab06e897ede6715fcf5a5a2
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoEnable multiple roles per user (backend) 81/381/2
Alessandro Boch [Wed, 22 May 2013 00:54:03 +0000 (17:54 -0700)]
Enable multiple roles per user (backend)

Signed-off-by: Alessandro Boch <aboch@cisco.com>
9 years agoNorthbound IntegrationTest 77/377/3
Kalvin Hom [Tue, 21 May 2013 01:48:28 +0000 (18:48 -0700)]
Northbound IntegrationTest

Initial base for writing integration
tests for northbound bundles.

All northbound integration tests can be
done within this bundle.  A full controller
using the stub protocol plugin will be started.

A test for getting all flow statistics is also
done.

Change-Id: Ife16e2fb81a2fe223813473fdd83402385fc59ba
Signed-off-by: Kalvin Hom <kahom@cisco.com>
9 years agoplugin-stub: InventoryService to Stub 76/376/2
Kalvin Hom [Mon, 20 May 2013 22:45:11 +0000 (15:45 -0700)]
plugin-stub: InventoryService to Stub

Changing the InventoryService to use the
node STUB type instead of OF.  Changed the
SwitchManagerIntegrationTest to match the
stub type changes.

Change-Id: I1a508bb8893c0f7f655a0270234aeeb13cf644b3
Signed-off-by: Kalvin Hom <kahom@cisco.com>
9 years agoMerge "- Respond to switch Echo Request immediately. It bypasses transmit queue and...
Giovanni Meo [Wed, 22 May 2013 12:17:49 +0000 (12:17 +0000)]
Merge "- Respond to switch Echo Request immediately. It bypasses transmit queue and sends the message over the socket directly. - Send PACKET_OUT (lldp/arp etc) at high priority. When the controller sends down large amount of flowmod messages, the switch may take some time to install/update all the rules in HW. At high priority, the PACKET_OUT messages do not have to wait for the whole flowmod operation to be complete."

9 years agoMerge "Added support for resolving augmentations."
Giovanni Meo [Wed, 22 May 2013 10:41:27 +0000 (10:41 +0000)]
Merge "Added support for resolving augmentations."

9 years agoRefactored equals in AugmentationSchemaImpl. 84/384/3
Martin Vitez [Wed, 22 May 2013 08:14:47 +0000 (10:14 +0200)]
Refactored equals in AugmentationSchemaImpl.

Change-Id: Ib683418a3e2547845a71b721aea1090c2cf1ba40
Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years ago- Respond to switch Echo Request immediately. It bypasses transmit queue and sends... 83/383/1
Jason Ye [Tue, 21 May 2013 18:29:50 +0000 (11:29 -0700)]
- Respond to switch Echo Request immediately. It bypasses transmit queue and sends the message over the socket directly.
- Send PACKET_OUT (lldp/arp etc) at high priority. When the controller sends down large amount of flowmod messages, the switch may take some time to install/update all the rules in HW. At high priority, the PACKET_OUT messages do not have to wait for the whole flowmod operation to be complete.

Signed-off-by: Jason Ye <yisye@cisco.com>
9 years agoMore javadocs added to yang-model-api. 65/365/2
Martin Vitez [Mon, 20 May 2013 11:20:54 +0000 (13:20 +0200)]
More javadocs added to yang-model-api.
Deleted not used KeyDefinition class.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoAdded support for resolving augmentations. 66/366/4
lsedlak [Mon, 20 May 2013 16:35:22 +0000 (18:35 +0200)]
Added support for resolving augmentations.

Added implementation into BindingGeneratorImpl to support generation of augmentati statements from yang models.
Added AugmentedTypeTest and augmented-test-models for testing of agumentation functionality.

Added ability to generate Java Interfaces that extends generic types.
Added Augmentation and Augmentable interfaces into yang-binding project.

Fixed bug in bad equals resolving in AbstractBaseType in binding-generator-util;
Added ReferencedTypeImpl into binding-generator-util;

Added findParentModule static method into SchemaContextUtil for resolving Module from SchemaNode in Schema Tree;
Added DATA_OBJECT, augmentableTypeFor and augmentationTypeFor into Types for referencing of Augmentable<T>, Augmentation<T> and DataObject interfaces defined in yang-binding;

Fixed incorrect resolving of namespaces and package names during generation of interfaces from yang lists;
Fixed bug in TypeProvider in resolving of extended types extended from multiple extended types;
Added ControllerTest and controller-models as test resources;
Changed position of revision date during package generation -> Now revision date comes after namespace;

Change-Id: I687925a622853bb6c9a809f17efd980c2960ae39
Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
9 years agoMerge "Updated SCM location"
Giovanni Meo [Mon, 20 May 2013 16:53:58 +0000 (16:53 +0000)]
Merge "Updated SCM location"

9 years agoUpdated SCM location 64/364/2
David Erickson [Mon, 20 May 2013 16:35:55 +0000 (09:35 -0700)]
Updated SCM location

Change-Id: I6c59e59713366e77825270e4f0f5265a88ed628d
Signed-off-by: David Erickson <daviderickson@cs.stanford.edu>
9 years agoMerge "Formatting cleanup of POM files"
Giovanni Meo [Mon, 20 May 2013 10:59:40 +0000 (10:59 +0000)]
Merge "Formatting cleanup of POM files"

9 years agoMerge changes I02c2af4b,If6adaabc,I559b92ff
Giovanni Meo [Mon, 20 May 2013 10:28:05 +0000 (10:28 +0000)]
Merge changes I02c2af4b,If6adaabc,I559b92ff

* changes:
  Change generated MANIFEST.MF location
  Remove superfluous groupId.
  Add PDE OSGi launcher for the controller project

9 years agoMerge "Fixed tests. Added javadocs to yang-model-api. Minor formatting changes perfor...
Giovanni Meo [Mon, 20 May 2013 09:59:51 +0000 (09:59 +0000)]
Merge "Fixed tests. Added javadocs to yang-model-api. Minor formatting changes performed in yang-model-parser-impl."

9 years agoFormatting cleanup of POM files 63/363/1
David Erickson [Sat, 18 May 2013 22:50:54 +0000 (15:50 -0700)]
Formatting cleanup of POM files

Replaced tabs with two spaces and removed
some extraneous lines and tail whitespace.

Change-Id: I3dbc766b3ffabf76a17a04454beb69933f67f8a0
Signed-off-by: David Erickson <daviderickson@cs.stanford.edu>
9 years agoChange generated MANIFEST.MF location 62/362/1
David Erickson [Sat, 18 May 2013 22:34:44 +0000 (15:34 -0700)]
Change generated MANIFEST.MF location

This patch moves the generated MANIFEST.MF for
OSGi from the target/classes/META-INF folder to
./META-INF for non-web bundles, and to
./src/main/resources/META-INF for web bundles.
This fixes a problem in Eclipse where it would
think that the project is always out of sync,
indicating this on the OSGi run configuration.

Change-Id: I02c2af4bf80a7f1fe66f53ddf3ae24232d8b83ec
Signed-off-by: David Erickson <daviderickson@cs.stanford.edu>
9 years agoRemove superfluous groupId. 61/361/1
David Erickson [Sat, 18 May 2013 18:51:42 +0000 (11:51 -0700)]
Remove superfluous groupId.

The groupId is already specified in the
parent element, and the additional declaration
causes warnings in Eclipse.

Change-Id: If6adaabc4407a4ea5100ba8af666b05c333dae8d
Signed-off-by: David Erickson <daviderickson@cs.stanford.edu>
9 years agoFixed tests. Added javadocs to yang-model-api. 60/360/1
Martin Vitez [Fri, 17 May 2013 15:48:08 +0000 (17:48 +0200)]
Fixed tests. Added javadocs to yang-model-api.
Minor formatting changes performed in yang-model-parser-impl.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoAdd PDE OSGi launcher for the controller project 58/358/2
Giovanni Meo [Fri, 17 May 2013 11:34:50 +0000 (13:34 +0200)]
Add PDE OSGi launcher for the controller project

- Created a p2site distribution which will place in a p2 repository
all the artifacts that are part of the
opendaylight/commons/opendaylight/pom.xml parent pom. The p2site will
be built by the controller-merge job on jenkins and will be used as
update site for the "opendaylight" target platform.
- Created a target-platform "opendaylight" to be used by PDE when used
in eclipse, this target platform is supposed to fetch the artifact
from a remote P2 site that will be hosted on jenkins after this patch
will get in.
- Create an OSGi PDE launcher "opendaylight-osgi-launcher" to be able
to launch the controller without the assembly phase to be required,
this one works with the target-platform "opendaylight"
- Created a target-platform "opendaylight-local" to be used by PDE
with the assumptions that the p2 site reside local and has been built
in the p2site distribution.
All this enhancements are to address some of the eclipse usability
issues as documented in:
https://bugs.opendaylight.org/show_bug.cgi?id=21

Change-Id: I559b92ff52011cd69d306b43edd2531901aac85f
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
9 years agoFix for exception seen on selecting device tab, after stopping switchmgr bundle. 59/359/1
Pramila Singh [Thu, 16 May 2013 18:02:23 +0000 (11:02 -0700)]
Fix for exception seen on selecting device tab, after stopping switchmgr bundle.

Signed-off-by: Pramila Singh <pramisin@cisco.com>
9 years agoAdded support for Modules to ModuleDependencySort (beside ModuleBuilders). 57/357/3
Maros Marsalek [Thu, 16 May 2013 09:34:08 +0000 (11:34 +0200)]
Added support for Modules to ModuleDependencySort (beside ModuleBuilders).
ModuleDependencySort now provides only static methods.

Change-Id: Ia407c30f3a99ffd2b5bd7b726590132a71c4fc49
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
9 years agoMerge "Fixing minor build errors"
Giovanni Meo [Thu, 16 May 2013 13:01:49 +0000 (13:01 +0000)]
Merge "Fixing minor build errors"

9 years agoMerge "Five more Equals/HashCode/StringBuilder replacements"
Giovanni Meo [Thu, 16 May 2013 13:01:00 +0000 (13:01 +0000)]
Merge "Five more Equals/HashCode/StringBuilder replacements"

9 years agoMerge "Seven more Equals/HashCode/StringBuilder replacements"
Giovanni Meo [Thu, 16 May 2013 12:59:59 +0000 (12:59 +0000)]
Merge "Seven  more Equals/HashCode/StringBuilder replacements"

9 years agoMerge "Six more Equals/HashCode/StringBuilder replacements"
Giovanni Meo [Thu, 16 May 2013 12:58:23 +0000 (12:58 +0000)]
Merge "Six  more Equals/HashCode/StringBuilder replacements"

9 years agoMerge "Five more Equals/HashCode/StringBuilder replacements"
Giovanni Meo [Thu, 16 May 2013 12:57:22 +0000 (12:57 +0000)]
Merge "Five more Equals/HashCode/StringBuilder replacements"

9 years agoMerge "Five more Equals/HashCode/StringBuilder replacements"
Giovanni Meo [Thu, 16 May 2013 12:56:22 +0000 (12:56 +0000)]
Merge "Five more Equals/HashCode/StringBuilder replacements"

9 years agoMerge "Five more Equals/HashCode/StringBuilder replacements"
Giovanni Meo [Thu, 16 May 2013 12:54:10 +0000 (12:54 +0000)]
Merge "Five more Equals/HashCode/StringBuilder replacements"

9 years agoMerge "Fixed YANG union type parsing. Changed module builders storing from HashMap...
Giovanni Meo [Thu, 16 May 2013 12:50:33 +0000 (12:50 +0000)]
Merge "Fixed YANG union type parsing. Changed module builders storing from HashMap to LinkedHashMap."

9 years agoMerge "Added test to yang-maven-plugin-it."
Giovanni Meo [Thu, 16 May 2013 12:49:16 +0000 (12:49 +0000)]
Merge "Added test to yang-maven-plugin-it."

9 years agoFixing minor build errors 56/356/1
David Erickson [Thu, 16 May 2013 09:12:13 +0000 (02:12 -0700)]
Fixing minor build errors

The POM of the northbound integration test was
referencing the onecontroller name instead of
opendaylight.  And /logger/log/ in a test file.

Signed-off-by: David Erickson <daviderickson@cs.stanford.edu>
9 years agoFive more Equals/HashCode/StringBuilder replacements 55/355/1
Ed Warnicke [Wed, 15 May 2013 16:36:18 +0000 (11:36 -0500)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Sixth set.

Change-Id: Iddab53b9e960a416c1416415daa6c00ebb1bfc96
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoSeven more Equals/HashCode/StringBuilder replacements 54/354/1
Ed Warnicke [Wed, 15 May 2013 16:31:48 +0000 (11:31 -0500)]
Seven  more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Fifth set.

Change-Id: I905753ad4b1c2f6947fae8c447de27e091aa7519
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoSix more Equals/HashCode/StringBuilder replacements 53/353/1
Ed Warnicke [Wed, 15 May 2013 16:17:48 +0000 (11:17 -0500)]
Six  more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Fourth in set.

Change-Id: Ic24cd900b1b88a1496c5f0a14f8f24650c00b297
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFive more Equals/HashCode/StringBuilder replacements 52/352/1
Ed Warnicke [Wed, 15 May 2013 16:14:48 +0000 (11:14 -0500)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Third in the set.

Change-Id: If8008c7e9db88022edd50fbc36f82cd32cdb6bad
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFive more Equals/HashCode/StringBuilder replacements 51/351/1
Ed Warnicke [Wed, 15 May 2013 16:11:56 +0000 (11:11 -0500)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Second in the set.

Change-Id: I5bf19c2bdf33bfde391f30867b27f433fc971a30
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFive more Equals/HashCode/StringBuilder replacements 50/350/1
Ed Warnicke [Wed, 15 May 2013 16:05:14 +0000 (11:05 -0500)]
Five more Equals/HashCode/StringBuilder replacements

I'm intentionally breaking these up into small groups so they can
be reasonably reviewed, rather than one giant group that can't.
Contributes to fixing bug 20.

Change-Id: I8fb7e4ce544a15fd0b819dcffe978e2af990fe52
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoReplace EqualsBuilder and HashCodeBuilder in transient member case. 49/349/1
Ed Warnicke [Wed, 15 May 2013 15:55:16 +0000 (10:55 -0500)]
Replace EqualsBuilder and HashCodeBuilder in transient member case.

This partially addresses bug 20, and provides the example of the
case where we have transient member.  I'm breaking it out
so that the transient member case can be reviewed simply.

Change-Id: Ic05c3d6daa7e9412e195578336ed95a5d71671d8
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFixed YANG union type parsing. Changed module builders storing from HashMap to Linked... 47/347/1
Martin Vitez [Wed, 15 May 2013 15:44:29 +0000 (17:44 +0200)]
Fixed YANG union type parsing. Changed module builders storing from HashMap to LinkedHashMap.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoAdded test to yang-maven-plugin-it. 46/346/1
Martin Vitez [Wed, 15 May 2013 14:30:42 +0000 (16:30 +0200)]
Added test to yang-maven-plugin-it.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoMerge "Fixed generation of Transfer Objects;"
Giovanni Meo [Wed, 15 May 2013 14:12:07 +0000 (14:12 +0000)]
Merge "Fixed generation of Transfer Objects;"

9 years agoMerge "Removed unused private variable containerAwareRegistration and unused import "
Giovanni Meo [Wed, 15 May 2013 13:59:25 +0000 (13:59 +0000)]
Merge "Removed unused private variable containerAwareRegistration and unused import "

9 years agoMerge "Removed unused private variable containerAwareRegistration - please review...
Giovanni Meo [Wed, 15 May 2013 13:57:37 +0000 (13:57 +0000)]
Merge "Removed unused private variable containerAwareRegistration - please review this change"

9 years agoFixed generation of Transfer Objects; 45/345/1
lsedlak [Wed, 15 May 2013 10:56:08 +0000 (12:56 +0200)]
Fixed generation of Transfer Objects;

Fiexed bad generating of parametrized constructors when constructor had
more than two parameters;

Fixed generation of hashCode, equals and toString when
GeneratedTransferObject had not specified equals, hashCode and toString
properties;

Added capability to generate setters if property has flag isReadOnly set
to false.
Parameters which contains flag isReadOnly == false will not apear as
parameters in generated constructor;

Fixed generation of subdirs from package when used generateToFile with
File as parent directory;

Signed-off-by: Lukas Sedlak <lsedlak@cisco.com>
9 years agoRemoved unused private variable containerAwareRegistration and unused 44/344/1
Natarajan P [Wed, 15 May 2013 07:18:02 +0000 (12:48 +0530)]
Removed unused private variable containerAwareRegistration and unused
import

Change-Id: I6b3bd2a85d66f73408a90a3adfe114216df94743
Signed-off-by: Natarajan P<natp@cisco.com>
9 years agoReplace EqualsBuilder, HashBuilder, ReflectionToString 42/342/2
Ed Warnicke [Wed, 15 May 2013 00:33:18 +0000 (19:33 -0500)]
Replace EqualsBuilder, HashBuilder, ReflectionToString

In one file, as a test case, replace the EqualsBuilder,
HashiCodeBuilder, and ReflectionToString
with code generated by Eclipse. This is a
very partial fix for bug 20 (more work to be done).

Change-Id: I21cbcb0abf1a22f6a644884e966af953a2a9da14
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRemoved unused private variable containerAwareRegistration - please 43/343/1
Natarajan P [Tue, 14 May 2013 17:36:26 +0000 (23:06 +0530)]
Removed unused private variable containerAwareRegistration - please
review this change

Change-Id: I4c6e16dcc3fe08ff44f2ad225238391165b1fcd9
Signed-off-by: Natarajan P<natp@cisco.com>
9 years agoMerge "Session invalidation is done after the custom error handling"
Giovanni Meo [Tue, 14 May 2013 15:22:16 +0000 (15:22 +0000)]
Merge "Session invalidation is done after the custom error handling"

9 years agoSession invalidation is done after the custom error handling 41/341/1
Madhu Venugopal [Tue, 14 May 2013 15:07:10 +0000 (08:07 -0700)]
Session invalidation is done after the custom error handling

Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
9 years agoRemove 'model' from package names in yang-model-parser-impl. 40/340/1
Martin Vitez [Tue, 14 May 2013 14:11:27 +0000 (16:11 +0200)]
Remove 'model' from package names in yang-model-parser-impl.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoFixed relative/absolute yang files directory resolving. 39/339/1
Martin Vitez [Tue, 14 May 2013 11:05:16 +0000 (13:05 +0200)]
Fixed relative/absolute yang files directory resolving.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years agoMerge "Refactored yang-maven-plugin."
Giovanni Meo [Tue, 14 May 2013 08:49:43 +0000 (08:49 +0000)]
Merge "Refactored yang-maven-plugin."

9 years agoMerge "new LinkedList() mostly redundant with Arrays.asList()"
Ed Warnicke [Mon, 13 May 2013 22:16:39 +0000 (22:16 +0000)]
Merge "new LinkedList() mostly redundant with Arrays.asList()"

9 years agoMerge "Logging improvements to improve efficiency - specifically in critical path...
Alessandro Boch [Mon, 13 May 2013 21:46:42 +0000 (21:46 +0000)]
Merge "Logging improvements to improve efficiency - specifically in critical path. Signed-off-by: Madhavan Kasthurirangan <mkasthur@cisco.com>"

9 years agoLogging improvements to improve efficiency - specifically in critical path. 38/338/1
Madhavan Kasthurirangan [Mon, 13 May 2013 21:29:21 +0000 (14:29 -0700)]
Logging improvements to improve efficiency - specifically in critical path.
Signed-off-by: Madhavan Kasthurirangan <mkasthur@cisco.com>
9 years agoFix single node in visual topology 37/337/1
Andrew Kim [Mon, 13 May 2013 19:14:03 +0000 (12:14 -0700)]
Fix single node in visual topology

When staging a node from the cache, forgot to update the adjacencies correctly.

Signed-off-by: Andrew Kim <andrekim@cisco.com>
9 years agoMerge "- Discard discovery packet if the ingress port is down - SwitchManager osgi...
Madhu Venugopal [Mon, 13 May 2013 18:17:50 +0000 (18:17 +0000)]
Merge "- Discard discovery packet if the ingress port is down - SwitchManager osgi cmds are useful tools for debugging. But the input node id currently has to be in long format. Change it to take node id string. Example: pncs "OF|00:01:44:03:a7:7a:54:e0" Signed-off-by: Jason Ye <yisye@cisco.com>"

9 years agoRefactored yang-maven-plugin. 36/336/1
Martin Vitez [Mon, 13 May 2013 15:11:53 +0000 (17:11 +0200)]
Refactored yang-maven-plugin.

Signed-off-by: Martin Vitez <mvitez@cisco.com>
9 years ago- Discard discovery packet if the ingress port is down 35/335/1
Jason Ye [Sun, 12 May 2013 19:09:52 +0000 (12:09 -0700)]
- Discard discovery packet if the ingress port is down
- SwitchManager osgi cmds are useful tools for debugging. But the input node id currently has to be in long format. Change it to take node id string. Example: pncs "OF|00:01:44:03:a7:7a:54:e0"
Signed-off-by: Jason Ye <yisye@cisco.com>
9 years agonew LinkedList() mostly redundant with Arrays.asList() 33/333/1
Rob Sherwood [Sat, 11 May 2013 16:05:37 +0000 (09:05 -0700)]
new LinkedList() mostly redundant with Arrays.asList()

General code clean up.

You get a ArrayList by default and that's the right thing in most
places.  This commit removes a bunch of missing Java generic warnings
and shouldn't affect any code.

Change-Id: I777cdf6a3fd1f2c883aac188d544ebc5a4420f55
Signed-off-by: Rob Sherwood <Rob.Sherwood@bigswitch.com>
9 years agoRemoved unused imports 27/327/1
Natarajan P [Fri, 10 May 2013 09:56:04 +0000 (15:26 +0530)]
Removed unused imports

Change-Id: Ief3f6879e3e4ed9cb743a699a8614fff4d5d9a59
Signed-off-by: Natarajan <natp@cisco.com>
9 years agoCorrect NodeConnetor insertion for edgeMap. 26/326/1
Madhavan Kasthurirangan [Thu, 9 May 2013 16:40:39 +0000 (09:40 -0700)]
Correct NodeConnetor insertion for edgeMap.
Signed-off-by: Madhavan Kasthurirangan <mkasthur@cisco.com>
9 years agoAuthorization fixes for Northbound bundles 24/324/1
Sapan Shah [Thu, 9 May 2013 01:20:30 +0000 (18:20 -0700)]
Authorization fixes for Northbound bundles

Signed-off-by: Sapan Shah <sapshah@cisco.com>
9 years agoFix user changing their password 23/323/1
Andrew Kim [Wed, 8 May 2013 22:57:51 +0000 (15:57 -0700)]
Fix user changing their password

Wrong user was being sent to change the password (it was the session user).

Signed-off-by: Andrew Kim <andrekim@cisco.com>
9 years agoAdding plugin stub: 91/291/3
Kalvin Hom [Fri, 3 May 2013 22:33:06 +0000 (15:33 -0700)]
Adding plugin stub:
FlowProgrammerService

Change-Id: Ia5a09a1dfc1547b4016296473e7751f0a23ccf50
Signed-off-by: Kalvin Hom <kahom@cisco.com>
9 years agoMerge "- Added osgi cmds to enable/disable LLDP snooping on each individual node...
Giovanni Meo [Wed, 8 May 2013 10:29:57 +0000 (10:29 +0000)]
Merge "- Added osgi cmds to enable/disable LLDP snooping on each individual node connector - Fixed TopologyManager nodeConnectorsDB which should only contain ISL ports"

9 years agoMerge "Fixed augment schema path resolving."
Giovanni Meo [Wed, 8 May 2013 10:28:52 +0000 (10:28 +0000)]
Merge "Fixed augment schema path resolving."

9 years agoMerge "Fix NPE and enhance flows table"
Giovanni Meo [Wed, 8 May 2013 10:26:23 +0000 (10:26 +0000)]
Merge "Fix NPE and enhance flows table"