controller.git
6 years agoMerge "BUG-509: remove unused code"
Tony Tkacik [Tue, 20 May 2014 13:42:07 +0000 (13:42 +0000)]
Merge "BUG-509: remove unused code"

6 years agoMerge "BUG-509: Move DataTree concepts into separate package"
Tony Tkacik [Tue, 20 May 2014 13:41:49 +0000 (13:41 +0000)]
Merge "BUG-509: Move DataTree concepts into separate package"

6 years agoMerge "BUG-509: simple cleanup of DataTreeModification"
Tony Tkacik [Tue, 20 May 2014 13:39:41 +0000 (13:39 +0000)]
Merge "BUG-509: simple cleanup of DataTreeModification"

6 years agoMerge "BUG-509: Rename MutableDataTree to DataTreeModification"
Tony Tkacik [Tue, 20 May 2014 13:38:12 +0000 (13:38 +0000)]
Merge "BUG-509: Rename MutableDataTree to DataTreeModification"

6 years agoMerge "BUG-731: fix warnings from missing generic arguments"
Tony Tkacik [Tue, 20 May 2014 13:19:25 +0000 (13:19 +0000)]
Merge "BUG-731: fix warnings from missing generic arguments"

6 years agoMerge "BUG-731: fix unused imports"
Tony Tkacik [Tue, 20 May 2014 13:18:37 +0000 (13:18 +0000)]
Merge "BUG-731: fix unused imports"

6 years agoMerge "BUG-1018 Implement BackwardsCompatible BI broker data notifications"
Tony Tkacik [Tue, 20 May 2014 13:11:24 +0000 (13:11 +0000)]
Merge "BUG-1018 Implement BackwardsCompatible BI broker data notifications"

6 years agoMerge "BUG-868: move to use unified ClassLoaderUtils"
Tony Tkacik [Tue, 20 May 2014 12:51:02 +0000 (12:51 +0000)]
Merge "BUG-868: move to use unified ClassLoaderUtils"

6 years agoMerge "BUG-994: introduce object-cache into distribution"
Tony Tkacik [Tue, 20 May 2014 12:50:42 +0000 (12:50 +0000)]
Merge "BUG-994: introduce object-cache into distribution"

6 years agoMerge "Added .DS_STORE and .metadata to .gitignore"
Tony Tkacik [Tue, 20 May 2014 12:46:51 +0000 (12:46 +0000)]
Merge "Added .DS_STORE and .metadata to .gitignore"

6 years agoBUG-509: remove unused code 42/7242/1
Robert Varga [Tue, 20 May 2014 07:21:43 +0000 (09:21 +0200)]
BUG-509: remove unused code

Removes unused code, writen -> written, adds a FIXME

Change-Id: Id0795edc23f2aef6f73e42d54be877003daf4244
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: Move DataTree concepts into separate package 23/7223/2
Robert Varga [Mon, 19 May 2014 09:56:10 +0000 (11:56 +0200)]
BUG-509: Move DataTree concepts into separate package

Create a new package for the data tree and related concepts to clean out
interactions. Also create and document the API and hide implementation
classes from the user itself.

Change-Id: I69f2a9b7bcac863b531f46f669bfd2fcfcd5b743
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: simple cleanup of DataTreeModification 22/7222/2
Robert Varga [Mon, 19 May 2014 09:38:38 +0000 (11:38 +0200)]
BUG-509: simple cleanup of DataTreeModification

Rename rootModification to rootNode to clarify what it is
Use field updated to fix seals to save some memory

Change-Id: I0fe7f58a3c15613c15198830b77bc28a84a9006a
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: Rename MutableDataTree to DataTreeModification 21/7221/2
Robert Varga [Mon, 19 May 2014 09:30:53 +0000 (11:30 +0200)]
BUG-509: Rename MutableDataTree to DataTreeModification

This name better reflects the semantics of the class. Also add some
javadoc documentation.

Change-Id: I7292c134bf87af8c0518e2905c7bd2b628c37a25
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: fix warnings from missing generic arguments 28/7228/2
Robert Varga [Mon, 19 May 2014 20:20:29 +0000 (22:20 +0200)]
BUG-731: fix warnings from missing generic arguments

This just goes in and adds wildcard generic arguments where appropriate,
removing ~100 eclipse warnings.

Change-Id: I34269906d6b78618646876f6448d3066bf036105
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-731: fix unused imports 24/7224/1
Robert Varga [Mon, 19 May 2014 16:20:07 +0000 (18:20 +0200)]
BUG-731: fix unused imports

Performs just regular maintenance to get rid of warnings.

Change-Id: Icdaf65e6d92ebb3423187f012c3e931428db092c
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-868: move to use unified ClassLoaderUtils 61/7161/2
Robert Varga [Sun, 18 May 2014 14:39:10 +0000 (16:39 +0200)]
BUG-868: move to use unified ClassLoaderUtils

This is a follow-up for yangtools patch
https://git.opendaylight.org/gerrit/#/c/7160/ . It updates the imports
to use the newly exposed version of ClassLoaderUtils.

Change-Id: I7178475ae698c3ba7120cf5ddfe56c4094f23d8b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-994: introduce object-cache into distribution 98/6998/2
Robert Varga [Wed, 14 May 2014 19:38:16 +0000 (21:38 +0200)]
BUG-994: introduce object-cache into distribution

This is the prerequisite for
https://git.opendaylight.org/gerrit/#/c/6926/, which introduces
dependency on object-cache-api. We also add implementation based on
Guava's Cache.

Change-Id: I798750bf95da540ee1c95c4ac18977729322a291
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Bug 624 - Separate netty and exi specific classes from netconf-util."
Ed Warnicke [Mon, 19 May 2014 12:39:04 +0000 (12:39 +0000)]
Merge "Bug 624 - Separate netty and exi specific classes from netconf-util."

6 years agoMerge "Commit generated test files after copyright was removed."
Ed Warnicke [Mon, 19 May 2014 12:36:18 +0000 (12:36 +0000)]
Merge "Commit generated test files after copyright was removed."

6 years agoMerge "Bug 953 - Enable mounted RPC calls via RestConf"
Tony Tkacik [Mon, 19 May 2014 12:35:53 +0000 (12:35 +0000)]
Merge "Bug 953 - Enable mounted RPC calls via RestConf"

6 years agoMerge "Adjust regenerated files to match what latest and greatest yang-tools will...
Ed Warnicke [Mon, 19 May 2014 12:29:24 +0000 (12:29 +0000)]
Merge "Adjust regenerated files to match what latest and greatest yang-tools will produce. This will avoid the annoying experience of having the following files shown as modified in git status."

6 years agoMerge "Store yang store snapshot cache using soft reference."
Ed Warnicke [Mon, 19 May 2014 12:28:20 +0000 (12:28 +0000)]
Merge "Store yang store snapshot cache using soft reference."

6 years agoMerge "Breaking up 6360: Adding base features"
Ed Warnicke [Mon, 19 May 2014 12:03:42 +0000 (12:03 +0000)]
Merge "Breaking up 6360: Adding base features"

6 years agoMerge "Trigger a GC once initial configuration has been pushed"
Tony Tkacik [Mon, 19 May 2014 09:50:34 +0000 (09:50 +0000)]
Merge "Trigger a GC once initial configuration has been pushed"

6 years agoMerge "BUG-1027: rework lookup for clarity"
Tony Tkacik [Mon, 19 May 2014 09:28:43 +0000 (09:28 +0000)]
Merge "BUG-1027: rework lookup for clarity"

6 years agoMerge "BUG-1026: workaround race condition"
Tony Tkacik [Mon, 19 May 2014 09:25:07 +0000 (09:25 +0000)]
Merge "BUG-1026: workaround race condition"

6 years agoMerge "BUG-509: reorganize data tree abstractions."
Tony Tkacik [Mon, 19 May 2014 09:16:13 +0000 (09:16 +0000)]
Merge "BUG-509: reorganize data tree abstractions."

6 years agoBUG-1018 Implement BackwardsCompatible BI broker data notifications 14/7214/1
Maros Marsalek [Mon, 19 May 2014 09:10:14 +0000 (11:10 +0200)]
BUG-1018 Implement BackwardsCompatible BI broker data notifications

Finish support for notifying BI data change listeners in backwards compatible broker.

Change-Id: I221a1e6937c8f9c493444afd0756e6c23fd4b18f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Bug 1029: Remove dead code: sal-binding-spi"
Tony Tkacik [Mon, 19 May 2014 09:08:48 +0000 (09:08 +0000)]
Merge "Bug 1029: Remove dead code: sal-binding-spi"

6 years agoMerge "Bug 1029: Remove dead code: sal-rest-connector-it"
Tony Tkacik [Mon, 19 May 2014 09:08:14 +0000 (09:08 +0000)]
Merge "Bug 1029: Remove dead code: sal-rest-connector-it"

6 years agoMerge "Bug 1029: Remove dead code: sal-dom-demo"
Tony Tkacik [Mon, 19 May 2014 09:07:59 +0000 (09:07 +0000)]
Merge "Bug 1029: Remove dead code: sal-dom-demo"

6 years agoMerge "Bug 1029: Remove dead code: sal-data-api"
Tony Tkacik [Mon, 19 May 2014 09:07:38 +0000 (09:07 +0000)]
Merge "Bug 1029: Remove dead code: sal-data-api"

6 years agoMerge "BUG-868: do not use InstanceIdentifier.getPath()"
Tony Tkacik [Mon, 19 May 2014 08:42:21 +0000 (08:42 +0000)]
Merge "BUG-868: do not use InstanceIdentifier.getPath()"

6 years agoMerge "Bug 1029: Remove dead code: clustered-data-store"
Tony Tkacik [Mon, 19 May 2014 08:12:16 +0000 (08:12 +0000)]
Merge "Bug 1029: Remove dead code: clustered-data-store"

6 years agoBUG-868: do not use InstanceIdentifier.getPath() 13/7213/1
Robert Varga [Mon, 19 May 2014 06:45:47 +0000 (08:45 +0200)]
BUG-868: do not use InstanceIdentifier.getPath()

This simplifies the NodeMapping class significantly by using the
utility methods shipped in InstanceIdentifier itself.

Change-Id: I1bb79bd4a16da9d78c600d21f67e3ca1926a0445
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoReplaced a couple of package imports with class imports 11/7211/1
Brent Salisbury [Mon, 19 May 2014 01:47:30 +0000 (21:47 -0400)]
Replaced a couple of package imports with class imports
in the L2switch sample bundle.

Change-Id: I2dbcf59e974cea99565ab254c528d4f7ea8dcec0
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
6 years agoBug 1029: Remove dead code: sal-binding-spi 08/7208/1
Ed Warnicke [Sun, 18 May 2014 23:01:43 +0000 (18:01 -0500)]
Bug 1029: Remove dead code: sal-binding-spi

opendaylight/md-sal/sal-binding-spi is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.
If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I2698f4bfa687e24e65989c1257c5f80d84ebe262
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoBug 1029: Remove dead code: sal-rest-connector-it 93/7193/1
Ed Warnicke [Sun, 18 May 2014 18:00:33 +0000 (13:00 -0500)]
Bug 1029: Remove dead code: sal-rest-connector-it

opendaylight/md-sal/test/sal-rest-connector-it is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I2ab837c661552022792ff7f02a1c2b68f7928501
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoBug 1029: Remove dead code: sal-dom-demo 92/7192/1
Ed Warnicke [Sun, 18 May 2014 17:59:02 +0000 (12:59 -0500)]
Bug 1029: Remove dead code: sal-dom-demo

opendaylight/md-sal/sal-dom-demo is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I77357764b8a779c444ed173e9e8a29a227ba3bf7
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoBug 1029: Remove dead code: sal-data-api 91/7191/1
Ed Warnicke [Sun, 18 May 2014 17:57:04 +0000 (12:57 -0500)]
Bug 1029: Remove dead code: sal-data-api

opendaylight/md-sal/sal-data-api is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If it needs to be revived in the future it can be retrieved
from git.

Change-Id: I28d9a8f63ff0398766d0d8c29f18a27d75642d2e
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoBug 1029: Remove dead code: clustered-data-store 90/7190/1
Ed Warnicke [Sun, 18 May 2014 17:50:40 +0000 (12:50 -0500)]
Bug 1029: Remove dead code: clustered-data-store

opendaylight/md-sal/clustered-data-store/ is dead code that is not being
built and hasn't for some time.  Its complicating keeping
versions up to date and verifying that they are up to date.

If in the future it needs to be revived it can be retrieved from
git.

Change-Id: Ie8365d5cb48e806a9d9a9fc0175478ef21277cbd
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoBUG-509: reorganize data tree abstractions. 07/7107/2
Robert Varga [Thu, 15 May 2014 13:14:03 +0000 (15:14 +0200)]
BUG-509: reorganize data tree abstractions.

This patch has no functional changes, it only rearranges code such that
the flow of data and object lifecycle becomes more obvious. This will
make metadata lifecycle easier to manage.

Change-Id: I10fd912433b72e25729d163c27699a5a5c47e305
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-1027: rework lookup for clarity 53/7153/1
Robert Varga [Sun, 18 May 2014 10:10:21 +0000 (12:10 +0200)]
BUG-1027: rework lookup for clarity

This patch gets rid of the nasty 'catch Exception', making the lookup
fail as soon as a DeserializationException is thrown. We account for
most of the checked exceptions, so this should not be a problem.

Change-Id: I3d0440933ebc30ba32a06690ebe326e18addf613
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-1026: workaround race condition 49/7149/1
Robert Varga [Sun, 18 May 2014 08:19:27 +0000 (10:19 +0200)]
BUG-1026: workaround race condition

This patch provides a workaround: move the netconf-connector config past
any other configuration that may be present, such that it initializes
last. This will ensure that any models referenced have been instantiated
by the time the mount instance is announced.

Change-Id: Iba3587806932c307474e708209a39cba1d63ee5d
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoChange in sal.connectionservice.notifyNodeDisconnectFromMaster 39/7139/1
Alessandro Boch [Sat, 17 May 2014 20:40:14 +0000 (13:40 -0700)]
Change in sal.connectionservice.notifyNodeDisconnectFromMaster

- On node disconnect from Master, notify the respective protocol plugin, not all of them

Change-Id: I2bfb30d2f649a1bc3f07be60150a814bcd1b8a45
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoMerge "Bug 967: Do not translate leaf Instance Identifiers."
Ed Warnicke [Fri, 16 May 2014 15:15:24 +0000 (15:15 +0000)]
Merge "Bug 967: Do not translate leaf Instance Identifiers."

6 years agoBug 967: Do not translate leaf Instance Identifiers. 11/7111/1
Tony Tkacik [Fri, 16 May 2014 11:02:33 +0000 (13:02 +0200)]
Bug 967: Do not translate leaf Instance Identifiers.

Improved extraction of Instance Identifiers from
DOM Data Change Event.

Logs in console are poluted with DeserializationException,
which fails to deserialize DOM Instance Identifier
to Binding Instance Identifier.

Added explicit check against schema context to
see if Instance Identifier is representable
in Binding Format, if not we will not report
is as part of subtree Data Change event.

Change-Id: Iaee2390fd089e0a2d66ec658aab4e7dab2a93a46
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoBug 1022 - Add ability to lookup dependent Module's attribute. 10/7110/1
Tomas Olvecky [Fri, 16 May 2014 11:24:49 +0000 (13:24 +0200)]
Bug 1022 - Add ability to lookup dependent Module's attribute.

Add 2 methods to DependencyResolver to allow modules look up values
of dependent bean attributes.

Change-Id: I2ebee82cc1260a84a16f5e69b32c9234bf576e87
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBug 624 - Separate netty and exi specific classes from netconf-util. 31/6931/2
Tomas Olvecky [Tue, 13 May 2014 13:26:28 +0000 (15:26 +0200)]
Bug 624 - Separate netty and exi specific classes from netconf-util.

As preparation step for splitting netconf into service and protocol,
create netconf-netty-util bundle with classes dependent on protocol
handlers - netty, exi, ssh.

Change-Id: I22ba17d0fa4f86c5f64cb3258a55f2c54da85dee
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoMerge "Add lispflowmapping specific configuration options"
Giovanni Meo [Fri, 16 May 2014 08:24:09 +0000 (08:24 +0000)]
Merge "Add lispflowmapping specific configuration options"

6 years agoMerge "Node Name in non-default container should default to Node Name in Default...
Andrew Kim [Thu, 15 May 2014 22:00:43 +0000 (22:00 +0000)]
Merge "Node Name in non-default container should default to Node Name in Default Slice"

6 years agoNode Name in non-default container should default to Node Name in Default Slice 04/7004/2
Pramila Singh [Wed, 14 May 2014 22:35:13 +0000 (15:35 -0700)]
Node Name in non-default container should default to Node Name in Default Slice

Change-Id: I81670c824bfcb4d7f400ef224abf329b6bc20abd
Signed-off-by: Pramila Singh <pramisin@cisco.com>
6 years agoBug 953 - Enable mounted RPC calls via RestConf 15/6815/15
Devin Avery [Thu, 8 May 2014 13:00:29 +0000 (09:00 -0400)]
Bug 953 - Enable mounted RPC calls via RestConf

Modify RestconfImpl to allow RPC calls via mount points.
===
MountPointImpl - wired pass through call for invokeRpc that was missing.
RestconfImpl - abstract the execution of RPC out to an "RpcExecutor" class.
Remaining classes - added tests to cover new code, including the toaster.yang file (modified from original) to test various RPC calls.

- Patch Set 8 - fixed unit tests which were failing (one failure due to missing future enhancement, another due to missing test rpc in yang file).
- Patch Set 10 - fixed run failure by addressing package import.
- Patch Set 13 - Cleaned up exception throws / used Preconditions checking.
- Patch Set 14 - Rebased
- Patch Set 15 - Added back change that was accidently removed during merge / rebase.

Change-Id: Ib214b4c82ffc487ee2f7b912e65d5c189b82154a
Signed-off-by: Devin Avery <devin.avery@brocade.com>
6 years agoMerge "Bug 509: Improve conflict detection of leaf merges"
Tony Tkacik [Thu, 15 May 2014 15:50:38 +0000 (15:50 +0000)]
Merge "Bug 509: Improve conflict detection of leaf merges"

6 years agoMerge changes Ibe0145be,I0764bfa9
Tony Tkacik [Thu, 15 May 2014 15:50:08 +0000 (15:50 +0000)]
Merge changes Ibe0145be,I0764bfa9

* changes:
  BUG-509: remove DataAndMetadataSnapshot.Builder.getDataTree()
  BUG-509: remove StoreMetadataNode.children()

6 years agoMerge "BUG-509: remove StoreUtils.initialChangeEvent()"
Tony Tkacik [Thu, 15 May 2014 15:49:44 +0000 (15:49 +0000)]
Merge "BUG-509: remove StoreUtils.initialChangeEvent()"

6 years agoMerge "BUG-509: StoreUtils should operate on NormalizedNode"
Tony Tkacik [Thu, 15 May 2014 15:49:11 +0000 (15:49 +0000)]
Merge "BUG-509: StoreUtils should operate on NormalizedNode"

6 years agoBug 509: Improve conflict detection of leaf merges 22/7022/1
Robert Varga [Thu, 15 May 2014 14:55:02 +0000 (16:55 +0200)]
Bug 509: Improve conflict detection of leaf merges

Original conflict detection for merge action on leaves
only looked at node version and subtree version, which
caused the transaction to fail even if the leaf was
unmodified and contained the same value.

Conflict detection now checks if the leaves are not same,
and only in that case it checks for concurrent writes.

Change-Id: I5e43233e86adf96e3dad2a93cdcf512b3d17977a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: remove DataAndMetadataSnapshot.Builder.getDataTree() 17/7017/1
Robert Varga [Thu, 15 May 2014 12:37:19 +0000 (14:37 +0200)]
BUG-509: remove DataAndMetadataSnapshot.Builder.getDataTree()

This getter and its associated field is completely unused. Remove it to
improve clarity.

Change-Id: Ibe0145bee610c7a2b147852f43d0492ca5061adc
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoMerge "Bug 1002 - REST POST transaction is not commited"
Tony Tkacik [Thu, 15 May 2014 12:02:38 +0000 (12:02 +0000)]
Merge "Bug 1002 - REST POST transaction is not commited"

6 years agoMerge "Cosmetics: fix typo facilitate"
Ed Warnicke [Thu, 15 May 2014 11:12:31 +0000 (11:12 +0000)]
Merge "Cosmetics: fix typo facilitate"

6 years agoBug 1002 - REST POST transaction is not commited 90/6990/4
Vaclav Demcak [Wed, 14 May 2014 12:39:10 +0000 (14:39 +0200)]
Bug 1002 - REST POST transaction is not commited

fix REST POST create workflow (create data only), fix according to specification
  http://tools.ietf.org/html/draft-bierman-netconf-restconf-03#section-2.4

I'm missing implementation for ietf-restconf:errors, so I can't do more for now
  http://tools.ietf.org/html/draft-bierman-netconf-restconf-03#page-48

* fix a check for an existing node in DataStore
* add warn log and a correct ResponseException
* fix tests for BrokerFacade

Change-Id: I68c95e831f42cae4df0608a40c585251a631693f
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
6 years agoBUG-509: remove StoreMetadataNode.children() 15/7015/1
Robert Varga [Thu, 15 May 2014 09:10:36 +0000 (11:10 +0200)]
BUG-509: remove StoreMetadataNode.children()

This patch removes the now-unneeded access, which means the children
iteration order is no longer part of StoreMetadataNode, allowing us to
use more memory-efficient HashMap instead of LinkedHashMap. Let's do
precisely that.

Change-Id: I0764bfa9861f9df4d3014151db96edf1024e3f9b
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: remove StoreUtils.initialChangeEvent() 14/7014/1
Robert Varga [Thu, 15 May 2014 08:56:48 +0000 (10:56 +0200)]
BUG-509: remove StoreUtils.initialChangeEvent()

This method is unused. Remove it, such that StoreUtils are now
completely independent of org.opendaylight.controller.md.sal, making
them a candidate for move to yang-data-*.

Change-Id: Idf945aee6fd4a80f8ca58fc50bcc997880a60ec0
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBUG-509: StoreUtils should operate on NormalizedNode 13/7013/1
Robert Varga [Thu, 15 May 2014 08:47:00 +0000 (10:47 +0200)]
BUG-509: StoreUtils should operate on NormalizedNode

This prunes the use of MetadataNode from StoreUtils. It turns out it is
completely unnecessary. This removes the last user of
Metadata.getChildren(), which will be removed in a subsequent patch.

Change-Id: I778e77b826576b8fa53e040a825d615dab7d253f
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoCommit generated test files after copyright was removed. 12/7012/1
Tomas Olvecky [Thu, 15 May 2014 07:54:26 +0000 (09:54 +0200)]
Commit generated test files after copyright was removed.

This prevents from changing files during build.

Change-Id: I1319d5f01d0c532cae2a680f59f5d76f3128da8a
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoTrigger a GC once initial configuration has been pushed 03/7003/1
Robert Varga [Wed, 14 May 2014 22:04:17 +0000 (00:04 +0200)]
Trigger a GC once initial configuration has been pushed

This introduces a single run of GC once we complete the initial
configuration.

The reasoning behind that is that we generate a fair amount of metadata
which we are likely to retain unmodified for extended periods of time.
We take care to store it in both memory and CPU efficient format, which
unfortunately requires us to do some copying around to compact it,
leaving a sizeable chunk of garbage on the heap.

Change-Id: I81af7d317e3b6f82a431e78b5fb439d8cb5f1997
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoBug 967: Fixed incorrect delete was addressing augmentation of augmentation 82/6782/2
Tony Tkacik [Wed, 7 May 2014 11:10:40 +0000 (13:10 +0200)]
Bug 967: Fixed incorrect delete was addressing  augmentation of augmentation

DataNormalizationOperation was constructed incorrectly, if augmentation
was already augmented, which leaded to incorrect construction of instance
identifier for delete.

Patchset 2: Fixed normalization in cases of mixin inside mixin
e.g. augmentation containing choice with cases.

Change-Id: I580e5dfe41ce504775ac454b66368037f4d707bb
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "BUG 1001 Failing test - RestGetOperationTest.getStreamsTest"
Tony Tkacik [Wed, 14 May 2014 10:16:45 +0000 (10:16 +0000)]
Merge "BUG 1001 Failing test - RestGetOperationTest.getStreamsTest"

6 years agoMerge "Add Pagination to Neutron Networks Northbound API"
Giovanni Meo [Wed, 14 May 2014 09:45:10 +0000 (09:45 +0000)]
Merge "Add Pagination to Neutron Networks Northbound API"

6 years agoMerge "BUG-372 Add reconnecting to netconf-connector for unexpected session drop"
Tony Tkacik [Wed, 14 May 2014 09:02:00 +0000 (09:02 +0000)]
Merge "BUG-372 Add reconnecting to netconf-connector for unexpected session drop"

6 years agoBUG 1001 Failing test - RestGetOperationTest.getStreamsTest 84/6984/1
Jozef Gloncak [Wed, 14 May 2014 08:23:24 +0000 (10:23 +0200)]
BUG 1001 Failing test - RestGetOperationTest.getStreamsTest

responseBody variable now contained some data and therefore it wasn't xml
tag <streams/> but <streams></streams>

Change-Id: I73004f848f0dfc5f2929f8f8ea2dbd6afc25d35a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoAdjust regenerated files to match what latest and greatest yang-tools will produce. 78/6978/1
Flavio Fernandes [Wed, 14 May 2014 03:26:40 +0000 (23:26 -0400)]
Adjust regenerated files to match what latest and greatest yang-tools will produce.
This will avoid the annoying experience of having the following files shown as modified
in git status.

Change-Id: I581de6082164ef1b7368e0487c4244869bb83e93
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
6 years agoMerge "REST API to fetch Node Property"
Andrew Kim [Tue, 13 May 2014 18:30:11 +0000 (18:30 +0000)]
Merge "REST API to fetch Node Property"

6 years agoMerge "Bug 617: Remove extend files from sal-rest-connector"
Tony Tkacik [Tue, 13 May 2014 15:02:41 +0000 (15:02 +0000)]
Merge "Bug 617: Remove extend files from sal-rest-connector"

6 years agoBUG-372 Add reconnecting to netconf-connector for unexpected session drop 34/6934/1
Maros Marsalek [Tue, 13 May 2014 14:10:59 +0000 (16:10 +0200)]
BUG-372 Add reconnecting to netconf-connector for unexpected session drop

Netconf connector will reattempt connection if the session to remote device is dropped.
Increase sleep factor in netconf connector from 1.0 to 1.5.
This prevents connection attempt every second in case remote device is not comming back for longer time.
Connection attempts span increases gradually.

Change-Id: Icc4b993942e9cc6897c0da858eb867afa4c8aa87
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoMerge "Bug 809: Enhancements to the toaster example"
Tony Tkacik [Tue, 13 May 2014 13:52:24 +0000 (13:52 +0000)]
Merge "Bug 809: Enhancements to the toaster example"

6 years agoBUG-981: Fixed incorrect condition in ResolveDataChangeEventsTask 29/6929/1
Robert Varga [Tue, 13 May 2014 11:52:10 +0000 (13:52 +0200)]
BUG-981: Fixed incorrect condition in ResolveDataChangeEventsTask

When we insert a new subtree, we need to make sure to call serialization
on the entire, such that any new elements which appear have their
classed attached to paths.

This reuses a previous code path, which pruned the walk tree as soon as
it encountered a node which did not have any listeners attached (thus
improving performance when we're gathering listeners).

In this specific case, though, this check is not correct: we need to
walk the path because it may be placing new data in the subtree.

At the same time add debug statements which made pinpointing this
problem possible.

Change-Id: I1687ba45817a84ea4a888496a90defc5896216c9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
6 years agoREST API to fetch Node Property 15/6915/1
Sapan Shah [Tue, 13 May 2014 00:06:28 +0000 (17:06 -0700)]
REST API to fetch Node Property

Change-Id: Iad693deefcc3a3f5420e8e19ddb81919c788738f
Signed-off-by: Sapan Shah <sapshah@cisco.com>
6 years agoMerge "Bug-574 Added a 4th RPC Invocation strategy for the case where the RPC has...
Tony Tkacik [Mon, 12 May 2014 18:48:31 +0000 (18:48 +0000)]
Merge "Bug-574 Added a 4th RPC Invocation strategy for the case where the RPC has an output, but no input"

6 years agoAdded .DS_STORE and .metadata to .gitignore 09/6909/1
Ed Warnicke [Mon, 12 May 2014 17:48:42 +0000 (12:48 -0500)]
Added .DS_STORE and .metadata to .gitignore

Change-Id: I95a89d26593064d8a471a8cc7bd6c48922109ece
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoMerge "BUG-704 Remove pax from netconf identity-ref test."
Tony Tkacik [Mon, 12 May 2014 16:35:07 +0000 (16:35 +0000)]
Merge "BUG-704 Remove pax from netconf identity-ref test."

6 years agoBug-574 Added a 4th RPC Invocation strategy for the case where the RPC has an output... 90/6190/2
Mayank Agarwal [Mon, 14 Apr 2014 21:58:31 +0000 (14:58 -0700)]
Bug-574 Added a 4th RPC Invocation strategy for the case where the RPC has an output, but no input

Change-Id: I7d1a596f3bb1362044cc240a15bdb9bb7d094c55
Signed-off-by: Mayank Agarwal <mayagarw@cisco.com>
6 years agoMerge "Bug 508: Improved error reporting for failed canCommit phase."
Ed Warnicke [Mon, 12 May 2014 14:41:49 +0000 (14:41 +0000)]
Merge "Bug 508: Improved error reporting for failed canCommit phase."

6 years agoMerge "Bug 981: Fixed accidental shaddowing of data in Data Change Event."
Giovanni Meo [Mon, 12 May 2014 13:53:28 +0000 (13:53 +0000)]
Merge "Bug 981: Fixed accidental shaddowing of data in Data Change Event."

6 years agoStore yang store snapshot cache using soft reference. 93/6893/1
Tomas Olvecky [Mon, 12 May 2014 12:58:53 +0000 (14:58 +0200)]
Store yang store snapshot cache using soft reference.

Change-Id: I9b159db83ba204b4a636f2314fd4fc2e7b6f654c
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
6 years agoBug 508: Improved error reporting for failed canCommit phase. 91/6891/3
Tony Tkacik [Mon, 12 May 2014 10:33:58 +0000 (12:33 +0200)]
Bug 508: Improved error reporting for failed canCommit phase.

Original implementation did not provide enough information
when transaction precondition failed.

Introduced new Exception DataPreconditionFailedException
which captures fail reason and path to subtree
for which precondition failed.

This helps debug accidental overwrites / conflicting
writes between transactions.

Change-Id: I0133fd3fdb8e6492bf457dab7b20efa67fd6e2af
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "Bug 849: Fixed NPE in Translated Data Change Events."
Giovanni Meo [Mon, 12 May 2014 11:05:43 +0000 (11:05 +0000)]
Merge "Bug 849: Fixed NPE in Translated Data Change Events."

6 years agoBUG-704 Remove pax from netconf identity-ref test. 34/6834/2
Maros Marsalek [Fri, 9 May 2014 12:58:08 +0000 (14:58 +0200)]
BUG-704 Remove pax from netconf identity-ref test.

Make this test a regular unit test without pax.

Change-Id: I0f9767d860f25bb60494ded2011e3f398fbcf43f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
6 years agoBug 981: Fixed accidental shaddowing of data in Data Change Event. 83/6883/4
Tony Tkacik [Sun, 11 May 2014 20:46:24 +0000 (22:46 +0200)]
Bug 981: Fixed accidental shaddowing of data in Data Change Event.

Not all Normalized DOM InstanceIdentifier has their counterpart
in Binding-Aware representation. Added explicit check to
detect mixin instance-identifiers which could lead to
incorrect deserialization into maps and shadowing parent data.

Change-Id: I66166f50c636ce0dfcd962efac7fc488da622336
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoMerge "BUG-648: Improve performance by reusing old data nodes"
Tony Tkacik [Mon, 12 May 2014 07:05:37 +0000 (07:05 +0000)]
Merge "BUG-648: Improve performance by reusing old data nodes"

6 years agoMerge "BUG-980: stop emiting copyright"
Tony Tkacik [Mon, 12 May 2014 07:04:12 +0000 (07:04 +0000)]
Merge "BUG-980: stop emiting copyright"

6 years agoMerge "BUG-731: RoutedRegistration.close() should not throw"
Tony Tkacik [Mon, 12 May 2014 07:03:49 +0000 (07:03 +0000)]
Merge "BUG-731: RoutedRegistration.close() should not throw"

6 years agoMerge "Remove overriding versions"
Tony Tkacik [Mon, 12 May 2014 07:03:30 +0000 (07:03 +0000)]
Merge "Remove overriding versions"

6 years agoMerge "Unify maven-bundle-plugin version at 2.4.0"
Tony Tkacik [Mon, 12 May 2014 07:03:15 +0000 (07:03 +0000)]
Merge "Unify maven-bundle-plugin version at 2.4.0"

6 years agoMerge "BUG-972: correct Precondition"
Tony Tkacik [Mon, 12 May 2014 07:02:55 +0000 (07:02 +0000)]
Merge "BUG-972: correct Precondition"

6 years agoMerge "Add serialVersionUID to Serializable"
Tony Tkacik [Mon, 12 May 2014 07:02:33 +0000 (07:02 +0000)]
Merge "Add serialVersionUID to Serializable"

6 years agoMerge "BUG-868: stop using InstanceIdentifier.builder()"
Tony Tkacik [Mon, 12 May 2014 07:02:17 +0000 (07:02 +0000)]
Merge "BUG-868: stop using InstanceIdentifier.builder()"

6 years agoBUG-648: Improve performance by reusing old data nodes 86/6886/2
Robert Varga [Thu, 8 May 2014 16:29:30 +0000 (18:29 +0200)]
BUG-648: Improve performance by reusing old data nodes

This patchset gives yang-data-api the chance to optimize copy
operations we execute when creating a new generation.

Change-Id: Ib23a87e116a0a04f7fd4f2b709d7239e213ea744
Signed-off-by: Robert Varga <rovarga@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.