Robert Varga [Thu, 13 Nov 2014 14:35:49 +0000 (15:35 +0100)]
BUG-2381: do not retain references to DependencyResolverManager
Instead of creating an anonymous subclass, define a proper class and
pass it the three required fields.
Change-Id: I5c9eea66284b60597ac77b336ef3afa652633479
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 20 Nov 2014 09:06:09 +0000 (09:06 +0000)]
Merge "Set auth timeout along with idle in SshProxyServer"
Tony Tkacik [Thu, 20 Nov 2014 09:05:53 +0000 (09:05 +0000)]
Merge changes Ic434bf4a,I05a3fb18,I47a3783d,I8234bbfd
* changes:
Fix checkstyle warnings in netconf-cli
Fix checkstyle warnings ietf-netconf-monitoring
Fix checkstyle warnings for netconf-testtool
Fix checkstyle warnings for config-netconf-connector
Tony Tkacik [Thu, 20 Nov 2014 09:04:25 +0000 (09:04 +0000)]
Merge "BUG-2243 Fixing invalid hello message handling"
Tony Tkacik [Thu, 20 Nov 2014 08:52:29 +0000 (08:52 +0000)]
Merge "BUG-2218: Keep existing link augmentations during discovery process"
Tony Tkacik [Thu, 20 Nov 2014 08:50:51 +0000 (08:50 +0000)]
Merge "Bug 2273: Removed unbuilt third-party code."
Tony Tkacik [Thu, 20 Nov 2014 08:42:10 +0000 (08:42 +0000)]
Merge "Remove unneeded embedded dependency"
Tony Tkacik [Thu, 20 Nov 2014 08:41:53 +0000 (08:41 +0000)]
Merge "Do not retain NetconfConnectModule reference"
Tony Tkacik [Thu, 20 Nov 2014 08:41:16 +0000 (08:41 +0000)]
Merge "Use ImmutableSet/Map in ServiceReferenceRegistry"
Tony Tkacik [Thu, 20 Nov 2014 08:40:50 +0000 (08:40 +0000)]
Merge "Fix raw references to Iterator"
Tony Tkacik [Thu, 20 Nov 2014 08:40:38 +0000 (08:40 +0000)]
Merge "Fix raw ServiceReferences and ServiceRegistrations"
Tony Tkacik [Thu, 20 Nov 2014 08:35:52 +0000 (08:35 +0000)]
Merge changes Ife66b5fe,I174ea168
* changes:
Fix checkstyle warnings for config-persister-impl
Fix checkstyle warnings in netconf-api
Moiz Raja [Wed, 19 Nov 2014 19:09:51 +0000 (19:09 +0000)]
Merge "Bug-2277 : Isolated Leader Implementation"
Tony Tkacik [Wed, 19 Nov 2014 15:59:08 +0000 (15:59 +0000)]
Merge "BUG-2304 Fix leafref/instanceIdentifier processing in restconf -> netconf pipeline"
Marian Dubai [Wed, 19 Nov 2014 15:28:07 +0000 (16:28 +0100)]
BUG-2243 Fixing invalid hello message handling
When invalid message before hello message, session dropped after hello message
Change-Id: I2c92012d3ba25069693a35b76d105407d200a833
Signed-off-by: Marian Dubai <mdubai@cisco.com>
Maros Marsalek [Wed, 5 Nov 2014 15:46:01 +0000 (16:46 +0100)]
BUG-2304 Fix leafref/instanceIdentifier processing in restconf -> netconf pipeline
Resolve the leafref type based on type being referenced by the xpath.
Fix tests testing wrong instance identifier behavior
Fix subtree filtering in netconf northbound when identityrefs are involved
Change-Id: I561e0c92550dd6639a9f9fbd1909695041c378e4
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Marian Dubai [Fri, 14 Nov 2014 14:15:05 +0000 (15:15 +0100)]
Fix checkstyle warnings in netconf-cli
Change-Id: Ic434bf4aac666c312e41781588aa9fca94acca4e
Signed-off-by: Marian Dubai <mdubai@cisco.com>
Marian Dubai [Fri, 14 Nov 2014 13:35:25 +0000 (14:35 +0100)]
Fix checkstyle warnings ietf-netconf-monitoring
Change-Id: I05a3fb185ae53128c31f8565a9489f7d0399febe
Signed-off-by: Marian Dubai <mdubai@cisco.com>
Marian Dubai [Fri, 14 Nov 2014 13:25:25 +0000 (14:25 +0100)]
Fix checkstyle warnings for netconf-testtool
Change-Id: I47a3783d9b89cadc6549d6f4784508cefb149059
Signed-off-by: Marian Dubai <mdubai@cisco.com>
Marian Dubai [Fri, 14 Nov 2014 13:19:10 +0000 (14:19 +0100)]
Fix checkstyle warnings for config-netconf-connector
Change-Id: I8234bbfdb7092f6423cedc7f95de07995871756d
Signed-off-by: Marian Dubai <mdubai@cisco.com>
Marian Dubai [Fri, 14 Nov 2014 13:16:07 +0000 (14:16 +0100)]
Fix checkstyle warnings for config-persister-impl
Change-Id: Ife66b5fea7bb6d1fe293d6181d6da7221e296731
Signed-off-by: Marian Dubai <mdubai@cisco.com>
Robert Varga [Fri, 14 Nov 2014 11:13:40 +0000 (12:13 +0100)]
Use ImmutableSet/Map in ServiceReferenceRegistry
Rather than wrapping collections in unmodifiable references, perform a
copy to obtain a properly-constant collection. These references are
usually retained for longer time, so opting for memory efficiency is
better than using sparse collections.
Change-Id: I708beaaa9abb13560297a7eb1369322220e87d5a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 13 Nov 2014 22:12:38 +0000 (23:12 +0100)]
Remove unneeded embedded dependency
yangtools:util already embeds the dependency with a different version,
causing a potential clash. Since sal-dom-broker is not a direct user,
this will work just fine.
Change-Id: If92555d6feb15c6ee9495fb789244750a48e9129
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 14 Nov 2014 11:53:17 +0000 (12:53 +0100)]
Do not retain NetconfConnectModule reference
Anononymous classes retain a reference to the module, which means we
leak quite a bit of memory if the client is not shut down.
Change-Id: Ifeaeb383afe8ff5c899cee66ea861e30bdf2ae41
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 18:30:26 +0000 (19:30 +0100)]
Fix raw ServiceReferences and ServiceRegistrations
Adding a windcard is enough to reduce the number of eclipse warnings.
Change-Id: I060ce96e2eb4cc6c6ed0e2bf87daabacc33b2d3f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:45:21 +0000 (18:45 +0100)]
Fix raw references to Iterator
Adds type declarations to fix eclipse warnings.
Change-Id: I33c9303bda2d5dd42632de2ec191e294d496e09b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Wed, 19 Nov 2014 08:39:45 +0000 (09:39 +0100)]
Set auth timeout along with idle in SshProxyServer
Change-Id: I4d7de2ca3f5e2025856646b825040b79ca344f34
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Kamal Rameshan [Thu, 13 Nov 2014 00:00:34 +0000 (16:00 -0800)]
Bug-2277 : Isolated Leader Implementation
A new RaftState has been added and on a scheduler, we check if the leader is isolated, looking at the majority peer statuses.
If Yes, then it switches the behavior to IsolatedLeader.
On the receipt of each AppendEntriesReply, the IsolatedLeader checks for isolation.
And if no, then switches back to either Leader or Follower.
These changes have been tested with TestDriver and 3 node cluster and the switching of Leader to IsolatedLeader and back,
on the stopping and reinstating of followers, was successful.
The Isolated Leader check interval can be configured via the config subsystem
Change-Id: I42b9165cc477d812c7e0e02339537c0f1fe74934
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Ed Warnicke [Wed, 5 Nov 2014 00:29:54 +0000 (18:29 -0600)]
Remove legacy distribution.
Change-Id: I0652f606efb99a4c8bcb06df8418413c3cc68d8c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Marian Dubai [Fri, 14 Nov 2014 15:46:20 +0000 (16:46 +0100)]
Fix checkstyle warnings in netconf-api
Change-Id: I174ea168e5b264cd99c2faa9ab182859806ef12f
Signed-off-by: Marian Dubai <mdubai@cisco.com>
Ed Warnicke [Fri, 14 Nov 2014 18:09:54 +0000 (18:09 +0000)]
Merge "Updating features archetype to talk about user-facing features."
Tony Tkacik [Fri, 14 Nov 2014 11:25:44 +0000 (11:25 +0000)]
Merge "Netconf testtool fix multiple feature file modification"
Tony Tkacik [Fri, 14 Nov 2014 10:08:04 +0000 (10:08 +0000)]
Merge "BUG-2345 Move bouncycastle bundles from netconf-connector to netconf feature"
Shigeru Yasuda [Wed, 12 Nov 2014 15:23:08 +0000 (00:23 +0900)]
Bug 2368: MD-SAL FRM may update/remove unexpected flow entries.
FRM should always set strict flag into update-flow/remove-flow
RPC input.
Change-Id: I6027442b56f4cd93cfc3f954dc8501bb57e2d64a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Kamal Rameshan [Mon, 10 Nov 2014 22:35:39 +0000 (14:35 -0800)]
Bug-2136 - fix for is-local-path
Change-Id: I38a58683c94c54e9f399df56aa586e3916f75e41
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Moiz Raja [Thu, 13 Nov 2014 21:47:14 +0000 (21:47 +0000)]
Merge "Bug 2347: Minor fixes to correct log output"
Tom Pantelis [Thu, 13 Nov 2014 21:25:21 +0000 (21:25 +0000)]
Merge "Bug 2021 - Continuous WARN log nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx"
Tom Pantelis [Thu, 13 Nov 2014 19:29:39 +0000 (19:29 +0000)]
Merge "BUG 2353 : Handle binary, bits and instanceidentifier types in NodeIdentifiers"
Maros Marsalek [Thu, 13 Nov 2014 15:30:23 +0000 (16:30 +0100)]
BUG-2345 Move bouncycastle bundles from netconf-connector to netconf feature
Apache mina sshd bundle is located in features-netconf and bouncycastle in features-netconf-connector.
This is wrong because mina sshd depends directly on bouncycastle but marks the dependency as optional which is probably not correct because this can result in runtime errors instead of resolution problems.
Change-Id: Ic9ef61294069859788fd10366e50b71f5bac9a43
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Wed, 12 Nov 2014 17:28:38 +0000 (18:28 +0100)]
BUG-2370 Reset schema context on disconnect in nc
Change-Id: I64197fc4ec375a07b2f0ea1dfb1215c4e31e206c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Thu, 13 Nov 2014 09:40:40 +0000 (10:40 +0100)]
Netconf testtool fix multiple feature file modification
Change-Id: I141c5298cecdbd6607789bd1688ffb8792acdad7
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
tpantelis [Thu, 13 Nov 2014 02:57:49 +0000 (21:57 -0500)]
Bug 2347: Minor fixes to correct log output
DOMConcurrentDataCommitCoordinator#handleException hard-codes the error
mapper to CAN_COMMIT_ERROR_MAPPER however this should be passed
in corresponding to the phase.
In TransactionCommitFailedExceptionMapper, the opNames for
PRE_COMMIT_MAPPER and CAN_COMMIT_ERROR_MAPPER are reversed, should be
"preCommit", "canCommit" respectively.
Change-Id: I6c0513f0f6265ec19de39476c95efefee53d2ee1
Signed-off-by: tpantelis <tpanteli@brocade.com>
Ed Warnicke [Wed, 29 Oct 2014 19:20:56 +0000 (14:20 -0500)]
Bug 2273: Removed unbuilt third-party code.
Change-Id: I0158a970b3ae65e6a0c49c93d96ab71928b25dd0
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Moiz Raja [Wed, 12 Nov 2014 21:10:09 +0000 (13:10 -0800)]
BUG 2353 : Handle binary, bits and instanceidentifier types in NodeIdentifiers
This fix properly serializes and deserializes NodeIdentifier attributes of the types
- binary (byte[])
- yanginstanceidentifier
- bits (set)
Change-Id: I612d40f9730c939be0594496c26370db96ea6449
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Wed, 12 Nov 2014 18:14:29 +0000 (18:14 +0000)]
Merge "Bug 2347: DOMConcurrentDataCommitCoordinator uses wrong phase name"
tpantelis [Wed, 12 Nov 2014 16:21:40 +0000 (11:21 -0500)]
Bug 2347: DOMConcurrentDataCommitCoordinator uses wrong phase name
Change-Id: I8b9083a428553525861137fc8630635f6508c2dc
Signed-off-by: tpantelis <tpanteli@brocade.com>
Tony Tkacik [Wed, 12 Nov 2014 16:12:45 +0000 (16:12 +0000)]
Merge "Bug 1029: Remove dead code: samples/clustersession"
Tony Tkacik [Wed, 12 Nov 2014 16:11:43 +0000 (16:11 +0000)]
Merge "Bug 1029: Remove dead code: p2site"
Flavio Fernandes [Thu, 6 Nov 2014 13:22:04 +0000 (08:22 -0500)]
Bug 2021 - Continuous WARN log nodeConnector creation failed at node: OF|00:00:xx:xx:xx:xx:xx:xx
This fixes the bug in ToSalConversionsUtils.actionFrom() that mistakenly
passed an AD-SAL-style NodeID to a conversion utility (fromNodeConnectorRef)
that was expecting a MD-SAL-style NodeID.
Patch 8: Add unit test to exercise code path that exposes the issue
Change-Id: Icc107bd785d6558a3351f139c1b13b8737b56ae7
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Signed-off-by: Colin Dixon <colin@colindixon.com>
Moiz Raja [Tue, 11 Nov 2014 17:57:51 +0000 (17:57 +0000)]
Merge "Move adsal into its own subdirectory."
Moiz Raja [Tue, 11 Nov 2014 01:27:18 +0000 (17:27 -0800)]
BUG 2302 : odl-clustering-test-app should not be part of the odl-restconf-all feature set
This patch does the following,
1. It removes odl-clustering-test-app from the restconf features
2. Move odl-clustering-test-app to the md-sal feature (just like odl-toaster)
3. Removes all unneccessary dependencies from odl-clustering-test-app
4. Removes all the clustering configuration files from the odl-clustering-test-app feature
This now allows the odl-clustering-test-app to be used with/without clustering. It also
eliminates the problem is inadvertently installing the odl-clustering-test-app when installing
odl-restconf-all.
Change-Id: I8021f88c967576aa8cf8da54dbfa8f4464233bc3
Signed-off-by: Moiz Raja <moraja@cisco.com>
Ed Warnicke [Tue, 4 Nov 2014 22:17:43 +0000 (16:17 -0600)]
Move adsal into its own subdirectory.
Moved various adsal components into an opendaylight/adsal subdir,
gave it a parent pom, and changed the root parent pom to have the
opendaylight/adsal as a module.
Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Tony Tkacik [Mon, 10 Nov 2014 16:04:56 +0000 (16:04 +0000)]
Merge "BUG-2329 Add test for anyxmls inside rpc resonse for netcfon-connector"
Tony Tkacik [Mon, 10 Nov 2014 16:04:41 +0000 (16:04 +0000)]
Merge "BUG-2254 Enable schema-less rpcs invocation in netconf-connector"
Tony Tkacik [Mon, 10 Nov 2014 16:03:57 +0000 (16:03 +0000)]
Merge "Make idle timeout configurable in ssh proxy server"
Maros Marsalek [Mon, 10 Nov 2014 13:20:52 +0000 (14:20 +0100)]
BUG-2254 Enable schema-less rpcs invocation in netconf-connector
Change-Id: Id84a2be3db050a546380186c79deadf5c9f7fd28
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Mon, 10 Nov 2014 10:50:16 +0000 (10:50 +0000)]
Merge "Fix raw references to SimpleNode"
Tony Tkacik [Mon, 10 Nov 2014 10:50:06 +0000 (10:50 +0000)]
Merge "Fix raw reference to SessionNegotiatior"
Tony Tkacik [Mon, 10 Nov 2014 10:46:22 +0000 (10:46 +0000)]
Merge "Fix raw use of Gauge"
Tony Tkacik [Mon, 10 Nov 2014 10:45:00 +0000 (10:45 +0000)]
Merge "Add serialVersionUID to Serializable classes"
Tony Tkacik [Mon, 10 Nov 2014 10:44:32 +0000 (10:44 +0000)]
Merge changes Ic7e83322,I2482a37c
* changes:
Fix a non-generic reference to Comparable
Fix non-generic references to ArrayList
Tony Tkacik [Mon, 10 Nov 2014 10:44:10 +0000 (10:44 +0000)]
Merge changes I525c2070,Ib920ff67
* changes:
Fix neutron pagination
Reuse NeutronObject comparator
Tony Tkacik [Mon, 10 Nov 2014 10:43:11 +0000 (10:43 +0000)]
Merge "Use generic-aware empty collections"
Maros Marsalek [Fri, 7 Nov 2014 12:31:48 +0000 (13:31 +0100)]
Make idle timeout configurable in ssh proxy server
Change-Id: Ia17b79331159dc04c2a837eacc33f3b7ac8033bc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Thu, 6 Nov 2014 15:02:55 +0000 (16:02 +0100)]
BUG-2329 Add test for anyxmls inside rpc resonse for netcfon-connector
Change-Id: If58216b8174c7cdbf248e6472ae1c5ba3a405a5b
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Fri, 7 Nov 2014 18:34:03 +0000 (19:34 +0100)]
Fix raw references to SimpleNode
Just adds a wildcard.
Change-Id: I62114265db13ee1945c91282b7c572c3c91458ec
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 18:31:37 +0000 (19:31 +0100)]
Fix raw reference to SessionNegotiatior
Add a wildcard and be done with it.
Change-Id: Ifc72e1fe88e9d5ee9047c55ed93fc0fae7db331a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 10 Nov 2014 08:56:24 +0000 (08:56 +0000)]
Merge "Fix raw references to Promise"
Tony Tkacik [Mon, 10 Nov 2014 08:56:13 +0000 (08:56 +0000)]
Merge "Fix raw reference to Predicate"
Tony Tkacik [Mon, 10 Nov 2014 08:56:02 +0000 (08:56 +0000)]
Merge "Fix raw ProtocolService references"
Tony Tkacik [Mon, 10 Nov 2014 08:55:52 +0000 (08:55 +0000)]
Merge "Fix a raw ServiceReference"
Tony Tkacik [Mon, 10 Nov 2014 08:55:47 +0000 (08:55 +0000)]
Merge "Fix a non-generic reference to DataContainerNode"
Tony Tkacik [Mon, 10 Nov 2014 08:55:42 +0000 (08:55 +0000)]
Merge "Fix non-generic references to NormalizedNode"
Tony Tkacik [Mon, 10 Nov 2014 08:55:14 +0000 (08:55 +0000)]
Merge changes I0fe4b78d,I3d3bc71b
* changes:
Fix non-generic reference to org.opendaylight.yangtools.yang.data.api.Node
Fix non-generic references to java.util.Map
Tony Tkacik [Mon, 10 Nov 2014 08:54:36 +0000 (08:54 +0000)]
Merge "Remove dead code in RuntimeMappingModule"
Tony Tkacik [Mon, 10 Nov 2014 08:54:13 +0000 (08:54 +0000)]
Merge "Do not override managed versions"
Tony Tkacik [Mon, 10 Nov 2014 08:53:44 +0000 (08:53 +0000)]
Merge "Fix raw types in Neutron northbound"
Robert Varga [Fri, 7 Nov 2014 19:27:49 +0000 (20:27 +0100)]
Remove dead code in RuntimeMappingModule
RuntimeMappingModule.RuntimeGeneratedMappingServiceProxy is private and
not used locally. Remove it, as it also uses deprecated classes -- thus
eliminating quite a few eclipse warnings.
Change-Id: Ica5d11dfceb34435af30811c79f9c2bd194575a8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 19:58:06 +0000 (20:58 +0100)]
Use generic-aware empty collections
Rather than referring to the instances directly, use the generic-aware
factory methods.
Change-Id: Ie0cdd4b3fdc03da1cf723907d03420bd10c57e45
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 18:14:38 +0000 (19:14 +0100)]
Fix raw use of Gauge
It is a generic type, so add type declarations to fix warnings.
Change-Id: I228629392261c22ec6a9037795aeb5bdbccc2dfe
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Sat, 8 Nov 2014 16:08:44 +0000 (16:08 +0000)]
Merge changes I9865d0cd,Ic71d525f,Ib8faba91,Ia10e5ec9,I35591747,If456a131,I9f8709cc
* changes:
Fix non-generic references to List
Hide XSQLBluePrintRelation.addToResult()
Fix non-generic references to Set
Fix HashMap references
Fix raw references to java.lang.Class
Fix raw references to NotificationListener
Fix non-generic references to HashSet
Tony Tkacik [Sat, 8 Nov 2014 16:06:15 +0000 (16:06 +0000)]
Merge changes I52c2aaab,I2509ed5e,Ic1d8a4e5,I73730f79,Ica1959e5,I0ce61b07
* changes:
Fix a raw Dictionary reference
Fix a raw Enumeration reference
Fix a non-generic CheckedFuture
Access static methods via class
Remove unused local variable
Fix non-generic references to Optional
Tony Tkacik [Sat, 8 Nov 2014 15:59:58 +0000 (15:59 +0000)]
Merge "Do not create Map subclasses"
Robert Varga [Fri, 7 Nov 2014 18:22:24 +0000 (19:22 +0100)]
Fix raw references to Promise
Adds the proper type, so we do not have the warnings.
Change-Id: Ib02779460f60f54e31f64815fd5cc6f68460ba83
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 18:18:29 +0000 (19:18 +0100)]
Fix raw reference to Predicate
Adds Object as the input type, fixing a few eclipse warnings.
Change-Id: Ia04d2e51282adda7572b8296c5228f37a1232535
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:48:04 +0000 (18:48 +0100)]
Fix raw ProtocolService references
Adds a wildcard type to suppress an eclipse warning.
Change-Id: I7750d9202802e0785a0c71eafc4c062b5ed5c68e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:46:58 +0000 (18:46 +0100)]
Fix a raw ServiceReference
Add the type argument to fix an eclipse warning.
Change-Id: I220858aa7c87d1616aede4f7d1b5e4822a3f0191
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:39:30 +0000 (18:39 +0100)]
Fix a non-generic reference to DataContainerNode
Just add a wildcards, as it's only used in a cast.
Change-Id: I0be921b5e63dcc3d0fa005a54c8a55dcfbffa866
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:38:43 +0000 (18:38 +0100)]
Fix non-generic references to NormalizedNode
Adds wildcard type arguments to get rid of eclipse warnings.
Change-Id: I16514de7e82b6cabdc9fc17cc76dcb0cbdbe76ce
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:31:55 +0000 (18:31 +0100)]
Fix non-generic reference to org.opendaylight.yangtools.yang.data.api.Node
Adds the proper wildcard to suppress warnings.
Change-Id: I0fe4b78d35fe16a068f10cc23393a27080178f69
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:41:47 +0000 (18:41 +0100)]
Fix a raw Dictionary reference
Fix the cast to match the variable declaration.
Change-Id: I52c2aaab4f9df9699672042b23272a7b8cc54e98
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:30:09 +0000 (18:30 +0100)]
Fix non-generic references to java.util.Map
Adds proper arguments. Also eliminates unneeded casts to Map.Entry,
caused by unnecessary loss of type.
Change-Id: I3d3bc71b88a404b02029d836a3d02d37e304c39e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:40:39 +0000 (18:40 +0100)]
Fix a raw Enumeration reference
Adds the proper type argument.
Change-Id: I2509ed5efc784ab5bef8a34aed66223c69cc41ab
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:22:13 +0000 (18:22 +0100)]
Fix a non-generic CheckedFuture
This adds proper type, and actually amkes the code cleaner.
Change-Id: Ic1d8a4e526830dd9ce48e0677b97842def537cf4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 18:16:12 +0000 (19:16 +0100)]
Access static methods via class
Invocation is slightly faster and fixes eclipse warnings.
Change-Id: I73730f7903aa8f25786625aa4903dc66d4f61e09
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:11:55 +0000 (18:11 +0100)]
Remove unused local variable
It does not use generic arguments, it's unused, and has overall no
impact (aside from eclipse warnings).
Change-Id: Ica1959e50f6e60a9431893e2ebee31a5595fc6db
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:09:24 +0000 (18:09 +0100)]
Fix non-generic references to Optional
Just adds arguments as needed.
Change-Id: I0ce61b07e3286a2d3415c92bbbe5e5bc28b5baef
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 19:50:32 +0000 (20:50 +0100)]
Add serialVersionUID to Serializable classes
Each serializable class withouth serialVersionUID produces an eclipse
warning. It also means that the class has undefined versioning and
cannot be be upgraded -- this patch fixes all such classes.
Change-Id: I57696f47b312517acd44799e10850f4887dab2e5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:25:25 +0000 (18:25 +0100)]
Fix a non-generic reference to Comparable
Fixes a warning stemming from not specifying the object type.
Change-Id: Ic7e833223246d56a95034ef84a1e012fa544a396
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 7 Nov 2014 17:18:22 +0000 (18:18 +0100)]
Fix non-generic references to List
Adds arguments as appropriate.
Change-Id: I9865d0cd56b9432be8cc079e32f5c6c513ba51e0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Code Review / controller.git / log