controller.git
7 years agoMerge "Do not rely od DataStore for all connected nodes"
Tony Tkacik [Sat, 15 Feb 2014 01:37:07 +0000 (01:37 +0000)]
Merge "Do not rely od DataStore for all connected nodes"

7 years agoMerge "Split off tracking of node presence"
Tony Tkacik [Sat, 15 Feb 2014 01:36:41 +0000 (01:36 +0000)]
Merge "Split off tracking of node presence"

7 years agoMerge "Fix issue where NodeConnector ADDED events were propagated as NodeConnector...
Tony Tkacik [Sat, 15 Feb 2014 01:32:32 +0000 (01:32 +0000)]
Merge "Fix issue where NodeConnector ADDED events were propagated as NodeConnector CHANGED events"

7 years agoMerge "Changing SimpleBroadcastHandler so that it's disabled by default to fix stabil...
Alessandro Boch [Fri, 14 Feb 2014 22:33:16 +0000 (22:33 +0000)]
Merge "Changing SimpleBroadcastHandler so that it's disabled by default to fix stability issues with >10 switches."

7 years agoSwitch Manager should ignore redundant updates 29/5329/3
Yevgeny Khodorkovsky [Wed, 12 Feb 2014 18:04:41 +0000 (10:04 -0800)]
Switch Manager should ignore redundant updates

- Redundant node and node connector updates (such as in the case of
  cluster switchover) should not be notified to apps/listeners, to avoid expensive tasks

Change-Id: Ia541bdcba6b53170c7a6c29e2c35f1b7b8104d60
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
7 years agoMerge "Fixed bug when RPC was not propagared"
Tony Tkacik [Fri, 14 Feb 2014 22:06:04 +0000 (22:06 +0000)]
Merge "Fixed bug when RPC was not propagared"

7 years agoChanging SimpleBroadcastHandler so that it's disabled by default to fix stability... 36/5336/1
Colin Dixon [Fri, 14 Feb 2014 21:37:04 +0000 (15:37 -0600)]
Changing SimpleBroadcastHandler so that it's disabled by default to fix stability issues with >10 switches.

Change-Id: I6ac1c15e431760c97348bc466a9783f25f6d9fee
Signed-off-by: Colin Dixon <ckd@us.ibm.com>
7 years agoFix for container directory creation/deletion in startup without saving config 38/5238/7
Diti Bhatia [Fri, 14 Feb 2014 21:42:42 +0000 (13:42 -0800)]
Fix for container directory creation/deletion in startup without saving config

Change-Id: I423e7c3ab186af5ea5bd0ab6d42553b4f988e82f
Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
7 years agoDo not rely od DataStore for all connected nodes 92/5292/5
Robert Varga [Thu, 13 Feb 2014 02:27:26 +0000 (03:27 +0100)]
Do not rely od DataStore for all connected nodes

Now that we track all connected flow-capable nodes we do need to go and
read all nodes just to find them. Just look at which handlers are
currently created.

Change-Id: I1a33b53399d0de0e2cdbdbd90512a09933d127c8
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoSplit off tracking of node presence 90/5290/6
Robert Varga [Thu, 13 Feb 2014 02:03:13 +0000 (03:03 +0100)]
Split off tracking of node presence

Introducing FlowCapableTracker. It's sole responsibility is to react
to FlowCapableNodes appearing and disappearing in the inventory and
spinning up statistics handlers based on that. This makes the
NodeStatisticsHandler lifecycle more predictable, thus we can activate
the 'ignore' part of the getStatisticsHandler(). Final part limits the
visibility of the various 'getFooStats' methods, so we can reason about
them better.

Change-Id: Icdbcca6038ae7fb0bff06d378fafa0f476f0fe18
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFixed bug when RPC was not propagared 15/5315/2
Abhishek Kumar [Fri, 14 Feb 2014 00:20:35 +0000 (16:20 -0800)]
Fixed bug when RPC was not propagared

 - Fixed DOM Broker and BI Connector code
 - The refactoring was done so that DOM Broker does not get exposed to
 - BA Broker directly but rather through a proxy. This also fixes the
   issue where DOM Broker would not be initialized in BI Connector, therefore
   any messages from BA Broker would not flow to DOM Broker via BI Connector.

Change-Id: Ia25a71787857c8d052a5dbd40e8237015d8c4d63
Signed-off-by: Abhishek Kumar <abhishk2@cisco.com>
7 years agoMerge "Fixed bug when Binding-Aware Data Change Listeners we're not triggered."
Ed Warnicke [Fri, 14 Feb 2014 15:36:23 +0000 (15:36 +0000)]
Merge "Fixed bug when Binding-Aware Data Change Listeners we're not triggered."

7 years agoLimit visibility of FlowEntry 91/5291/4
Robert Varga [Thu, 13 Feb 2014 02:26:08 +0000 (03:26 +0100)]
Limit visibility of FlowEntry

This class is no longer needed to be visible. Make it private and
static.

Change-Id: I30c612fca44aa993f29922fb1465ecdb16ea50c5
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFixed bug when Binding-Aware Data Change Listeners we're not triggered. 20/5320/3
Tony Tkacik [Fri, 14 Feb 2014 05:10:59 +0000 (06:10 +0100)]
Fixed bug when Binding-Aware Data Change Listeners we're not triggered.

  - Added additional strategy to inspect changes based on registered listeners
  - Fixed normalization of data for changes where parent node was written
      - Extracts data for listener, so listener does not need to
        extract that data manually
  - Splitted AbstractDataBroker.xtend into several classes

Change-Id: I7e5d1d759c40519d164b08678a9dc22743d329bb
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoFix issue where NodeConnector ADDED events were propagated as NodeConnector CHANGED... 41/5241/6
Moiz Raja [Tue, 11 Feb 2014 03:23:50 +0000 (19:23 -0800)]
Fix issue where NodeConnector ADDED events were propagated as NodeConnector CHANGED events

Note that this is an interim fix which will work only in a non-clustered setup

The major part of this fix is coded in InventoryAndReadAdapter. The fix is as follows when a NodeConnectorChanged
event is received by the InventoryAdapter it first checks whether this node connector has ever been seen before by
it. It does this by looking at a Map of Nodes to NodeConnectors that it maintains. If the Node Connector is not found
in the Map then this must be a NodeConnector ADDED notification otherwise it is a NodeConnector CHANGED notification.

This commit also contains some code for what would be the ideal fix - one that would work in a cluster scenario as well
That code is in InventoryNotificationProvider and NodeConnectorDataChangeListener. The fix in there works like this. We set
up a DataChangeListener on the MD-SAL DataProvider Service which would notify us whenever a NodeConnector is added, modified
or removed. When the change event comes in depending on whether the node connector was added or modified the data change
listener fires the ADDED or CHANGED event. This fix is disabled for now till another issue with MD-SAL regarding removal
of nodes on mininet exit (or switch disconnect) is resolved.

There are some other changes in the FlowProgrammerAdapter which basically suppress some error conditions when a flow that is
being removed or modified does not exist in the cache that the FlowProgrammerAdapter maintains to translate between AD-SAL and
MD-SAL flows.

This fix allows pingall to work with upto 32 switches - after that other issues prevent testing with more switches.

Change-Id: Ide2e6e85191856a8c6a9746b2397605905938d56
Signed-off-by: Moiz Raja <moraja@cisco.com>
7 years agoMerge "Fix for Bug 403: Install button does not work correctly first time if flow...
Andrew Kim [Thu, 13 Feb 2014 17:10:26 +0000 (17:10 +0000)]
Merge "Fix for Bug 403: Install button does not work correctly first time if flow is edited in UI."

7 years agoremoved obsolete config yang and RuntimeGeneratedMappingService 06/5306/2
Martin Bobak [Thu, 13 Feb 2014 14:48:42 +0000 (15:48 +0100)]
removed obsolete config yang and RuntimeGeneratedMappingService

Change-Id: I86c721ecce6132bd545778fe9a7380684c53c8f8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoMerge "Refactor Additional header for netconf hello message."
Ed Warnicke [Thu, 13 Feb 2014 11:44:11 +0000 (11:44 +0000)]
Merge "Refactor Additional header for netconf hello message."

7 years agoMerge "sal-restconf-broker initial implementation needs https://git.opendaylight...
Ed Warnicke [Thu, 13 Feb 2014 11:31:25 +0000 (11:31 +0000)]
Merge "sal-restconf-broker initial implementation  needs https://git.opendaylight.org/gerrit/#/c/5259/  and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for  successful build"

7 years agoFix for Bug 403: Install button does not work correctly first time if flow is edited... 02/5302/2
deepankar [Thu, 13 Feb 2014 08:55:34 +0000 (14:25 +0530)]
Fix for Bug 403: Install button does not work correctly first time if flow is edited in UI.

Root Cause: Whenever user edits a flow entry, page.js file passes the value of installInHw as true always (line ). If the flow is not installed in the hardware, this reverts the value of installInHw from false to true causing this issue.

Fix: Changes Done:
1. In page.js file, On edit click button a new variable install is defined, which is assigned to the value of installInHw(true/false) in respect to a flow entry.
2. The variable install is passed to the edit function instead of passing the value as true always

Change-Id: I4e0df2a3061d165b8ab534dff44d4c196e7d9872
Signed-off-by: deepankar <deepankar.gupta@tcs.com>
7 years agoRefactor Additional header for netconf hello message. 63/5263/3
Maros Marsalek [Tue, 11 Feb 2014 17:19:42 +0000 (18:19 +0100)]
Refactor Additional header for netconf hello message.

Allow additional header only for hello messages.
Introduce customized (en|decoders) for hello message to parse/serialize additional header.
These handlers are replaced after successful negotiation.

Change-Id: I54c441bc166e7141f503888f0eb1934882971045
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
7 years agoMerge "Increase SSL input buffer size to accommodate large number of flows"
Chi-Vien Ly [Thu, 13 Feb 2014 07:17:11 +0000 (07:17 +0000)]
Merge "Increase SSL input buffer size to accommodate large number of flows"

7 years agoCompress removals into a single transaction 78/5278/2
Robert Varga [Wed, 12 Feb 2014 02:34:26 +0000 (03:34 +0100)]
Compress removals into a single transaction

When node removal occurs, do not cascade into multiple transactions, but
trigger only a single one.

Change-Id: Ic9994e6a801953efdf83a707be3b821f9a93b35b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRename NodeStatisticsAger and StatisticsUpdateCommiter 77/5277/2
Robert Varga [Wed, 12 Feb 2014 02:16:40 +0000 (03:16 +0100)]
Rename NodeStatisticsAger and StatisticsUpdateCommiter

The component's responsibilities have changed, rename them to reflect
this change. The new division of responsibilities is:

There is a single StatisticsListener listens for notifications
carrying the statistics data and routes them towards the appropriate
NodeStatisticsHandler. Once MD-SAL is able to route notifications based
on key, this class should be completely removed.

There are per-node NodeStatisticsHandlers, each of which is responsible
for taking care of lifecycle of statistics for a particular node.

Change-Id: I16d7a1f353a1f484db11da1e5edc97b4778dad3c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMove flow statistics update handling 76/5276/2
Robert Varga [Wed, 12 Feb 2014 02:07:45 +0000 (03:07 +0100)]
Move flow statistics update handling

This finishes the cleanup of StatisticsUpdateCommiter, we now have all
per-node statistics processing guarded by the lock -- e.g. have
predictable and isolated updates to statistics.

Change-Id: Ia58983d5d1dc857e5239a68e3e94fc7d3676cf6d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Move flow comparison methods into utility class"
Ed Warnicke [Thu, 13 Feb 2014 03:52:26 +0000 (03:52 +0000)]
Merge "Move flow comparison methods into utility class"

7 years agoMerge "Prepare for transitioning NodeStatisticsAger"
Ed Warnicke [Thu, 13 Feb 2014 03:51:54 +0000 (03:51 +0000)]
Merge "Prepare for transitioning NodeStatisticsAger"

7 years agoMerge "Simplify StatisticsManagerActivator/StatisticsProvider contract"
Ed Warnicke [Thu, 13 Feb 2014 03:51:29 +0000 (03:51 +0000)]
Merge "Simplify StatisticsManagerActivator/StatisticsProvider contract"

7 years agoMerge "Centralize NodeStatisticsAger creation"
Ed Warnicke [Thu, 13 Feb 2014 03:50:54 +0000 (03:50 +0000)]
Merge "Centralize NodeStatisticsAger creation"

7 years agoMerge "Optimize statistics cleanup"
Ed Warnicke [Thu, 13 Feb 2014 03:50:39 +0000 (03:50 +0000)]
Merge "Optimize statistics cleanup"

7 years agoIncrease SSL input buffer size to accommodate large number of flows 93/5293/1
Jason Ye [Thu, 13 Feb 2014 03:07:05 +0000 (19:07 -0800)]
Increase SSL input buffer size to accommodate large number of flows

Change-Id: I59036ba805682ef1d4dae0d7a7d5f7f40acd94ac
Signed-off-by: Jason Ye <yisye@cisco.com>
7 years agoMerge "Do not allocate/commit transactions in tight loops"
Ed Warnicke [Wed, 12 Feb 2014 15:33:09 +0000 (15:33 +0000)]
Merge "Do not allocate/commit transactions in tight loops"

7 years agoMerge "Rework NETCONF interfaces"
Ed Warnicke [Wed, 12 Feb 2014 15:32:33 +0000 (15:32 +0000)]
Merge "Rework NETCONF interfaces"

7 years agoMerge "Fix thread safety issues in netconf client"
Ed Warnicke [Wed, 12 Feb 2014 15:32:00 +0000 (15:32 +0000)]
Merge "Fix thread safety issues in netconf client"

7 years agoMerge "Cache sessionID to increase readability"
Ed Warnicke [Wed, 12 Feb 2014 15:31:42 +0000 (15:31 +0000)]
Merge "Cache sessionID to increase readability"

7 years agoMerge "Remove unused DefaultNetconfOperation marker"
Ed Warnicke [Wed, 12 Feb 2014 15:29:27 +0000 (15:29 +0000)]
Merge "Remove unused DefaultNetconfOperation marker"

7 years agosal-restconf-broker initial implementation 69/5169/11
Martin Bobak [Mon, 20 Jan 2014 13:27:44 +0000 (14:27 +0100)]
sal-restconf-broker initial implementation
 needs https://git.opendaylight.org/gerrit/#/c/5259/
 and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for
 successful build

Change-Id: Ic665eaf25c908ed7633cfeee7629354d647ef09f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoRemoved redundant dependency on configuration artifact 82/5282/1
Martin Bobak [Wed, 12 Feb 2014 12:51:51 +0000 (13:51 +0100)]
Removed redundant dependency on configuration artifact

Change-Id: Ifae0e3071c08ddc7363af1fdb05d97e2b22e4329
Signed-off-by: Martin Bobak <mbobak@cisco.com>
7 years agoMerge "Fixed removals from data store did not clean direct-match indexes to child...
Ed Warnicke [Wed, 12 Feb 2014 06:57:08 +0000 (06:57 +0000)]
Merge "Fixed removals from data store did not clean direct-match indexes to child nodes."

7 years agoMerge "Fixed bug when publisher's thread was blocked until all notifications were...
Ed Warnicke [Wed, 12 Feb 2014 06:56:15 +0000 (06:56 +0000)]
Merge "Fixed bug when publisher's thread was blocked until all notifications were delivered."

7 years agoAuthenticatedUser not to expose internal implementation 79/5279/2
Alessandro Boch [Wed, 12 Feb 2014 04:55:12 +0000 (20:55 -0800)]
AuthenticatedUser not to expose internal implementation

Update unit test

Change-Id: I9606742fbdfe3bbbae8bbf789e130d24bd946d82
Signed-off-by: Alessandro Boch <aboch@cisco.com>
7 years agoMove flow comparison methods into utility class 75/5275/1
Robert Varga [Wed, 12 Feb 2014 01:52:27 +0000 (02:52 +0100)]
Move flow comparison methods into utility class

The whole machinery is not interesting except for the two public
methods. Let's move into its dedicated file and limit its visibility to
package for now.

Change-Id: I0377a135b085cc674c66ba238dd5a4608c307cb4
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoPrepare for transitioning NodeStatisticsAger 73/5273/3
Robert Varga [Wed, 12 Feb 2014 00:35:30 +0000 (01:35 +0100)]
Prepare for transitioning NodeStatisticsAger

NodeStatisticsAger is currently the object which tracks per-node state,
synchronizing our view of what comes from the network vs. what is timed
out. Previous patches have already added partial ordering, this patch
moves the actual modifications in NodeStatisticsAger. This gives us
predictable behavior while keeping us per-switch scalable.

Change-Id: I7a11cf5eb885b46972ecf7a362a8d80a97923a0a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFixed removals from data store did not clean direct-match indexes to child 70/5270/1
Tony Tkacik [Wed, 12 Feb 2014 00:19:23 +0000 (01:19 +0100)]
Fixed removals from data store did not clean direct-match indexes to child
nodes.

  - Added deepRemoveStrategy, which checks for all quick indexes
    if they are removed correctly.

Change-Id: Icb7a231ca0308774f76b43ac40ab4eaf47e68937
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoSimplify StatisticsManagerActivator/StatisticsProvider contract 72/5272/1
Robert Varga [Tue, 11 Feb 2014 23:16:39 +0000 (00:16 +0100)]
Simplify StatisticsManagerActivator/StatisticsProvider contract

Get rid of the need for the StatisticsManagerActivator to keep around
the Provider session -- it is only ever referenced from
StatisticsProvider.start(). Same goes for the various services which
are set into it.

Change-Id: I8014dbdd03e8830bb929e083672f988504d02994
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoCentralize NodeStatisticsAger creation 71/5271/1
Robert Varga [Tue, 11 Feb 2014 22:58:56 +0000 (23:58 +0100)]
Centralize NodeStatisticsAger creation

Change-Id: I47fd16cfbcd41b89ea1ec760e1d4e07cf02e1ca1
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoProvide Switch Information in Troubleshooting Tab 69/5269/1
Sapan Shah [Tue, 11 Feb 2014 22:51:27 +0000 (14:51 -0800)]
Provide Switch Information in Troubleshooting Tab

Change-Id: I5fc02b4c6ac5babbe21cc082aa4723882846568a
Signed-off-by: Sapan Shah <sapshah@cisco.com>
7 years agoOptimize statistics cleanup 67/5267/1
Robert Varga [Tue, 11 Feb 2014 18:20:25 +0000 (19:20 +0100)]
Optimize statistics cleanup

Perform a single transaction for cleaning up the flow. Also use
System.nanoTime() for keeping the expiry time and keep it constant.

Furthermore, use HashMap instead of ConcurrentHashMap to gain better
memory peformance. This requires synchronizing between the statistics
update and statistics cleanup -- which actually is okay, as it closes
the race between an update happening precisely when a flow entry would
be retired. With the lockless design that entry could be lost, simply
because we'd get undefined ordering between cleanup and update
transaction commit.

Change-Id: Iceaee5b44643075d325f664af774a9c6841bcfc6
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFixed bug when publisher's thread was blocked until all notifications were delivered. 66/5266/1
Tony Tkacik [Tue, 11 Feb 2014 18:35:42 +0000 (19:35 +0100)]
Fixed bug when publisher's thread was blocked until all notifications were delivered.

Change-Id: Ieb083feec0ac6a64877fb045fa4fa6ba6e3fa412
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
7 years agoDo not allocate/commit transactions in tight loops 30/5230/4
Robert Varga [Mon, 10 Feb 2014 16:35:19 +0000 (17:35 +0100)]
Do not allocate/commit transactions in tight loops

A transaction is additive and there's little harm in commiting empty
ones. Move allocation/commit outside of tight loops, such that we get
proper bulking.

Change-Id: I1f4920965c8ecf3091b6afb69ce1e1baa7ca0e24
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRework NETCONF interfaces 18/5218/7
Robert Varga [Sun, 9 Feb 2014 22:41:45 +0000 (23:41 +0100)]
Rework NETCONF interfaces

NetconfSession and NetconfClientSessionListener are supposed to be
interfaces, not classes. Convert them to such and introduce utility
classes which retain their current functionality. Remove an unused
method and fix type safety warnings while we're at it.

Change-Id: Id7d78c831e3c3d46abb4379efe4a5ca353cd55ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix thread safety issues in netconf client 17/5217/3
Robert Varga [Sun, 9 Feb 2014 19:32:33 +0000 (20:32 +0100)]
Fix thread safety issues in netconf client

This patch introduces a proper asynchronous interface and reworks
internals such that thread safety is maintained.

Change-Id: I6eb1c56518b0b3cc6f64c1df8bc0c857298f79b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoCache sessionID to increase readability 13/5213/4
Robert Varga [Sun, 9 Feb 2014 17:04:16 +0000 (18:04 +0100)]
Cache sessionID to increase readability

Change-Id: Ia4440f8a30cdc9b987139879f471be67ffe1dc3f
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove unused DefaultNetconfOperation marker 12/5212/4
Robert Varga [Sun, 9 Feb 2014 15:48:01 +0000 (16:48 +0100)]
Remove unused DefaultNetconfOperation marker

DefaultCloseSession and DefaultGetSchema do not need the netconf
session. so drop their use of DefaultNetconfOperation.

Change-Id: I724bd56d913b0f836c88ca8d1b436be308852a30
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix yangtools API incompatibility 57/5257/1
Robert Varga [Tue, 11 Feb 2014 14:42:42 +0000 (15:42 +0100)]
Fix yangtools API incompatibility

Change-Id: Ia6883492a49765f1ffcd38128fcd6084636bc470
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Do not use deprecated StringBufferInputStream"
Ed Warnicke [Tue, 11 Feb 2014 01:51:42 +0000 (01:51 +0000)]
Merge "Do not use deprecated StringBufferInputStream"

7 years agoMerge "Fix a warning"
Ed Warnicke [Tue, 11 Feb 2014 01:51:11 +0000 (01:51 +0000)]
Merge "Fix a warning"

7 years agoMerge "Remove deprecated API elements from protocol framework"
Ed Warnicke [Tue, 11 Feb 2014 01:47:28 +0000 (01:47 +0000)]
Merge "Remove deprecated API elements from protocol framework"

7 years agoMerge "Fix typo in match types yang model"
Ed Warnicke [Tue, 11 Feb 2014 01:34:35 +0000 (01:34 +0000)]
Merge "Fix typo in match types yang model"

7 years agoMerge "Changed model versions to dependencies"
Ed Warnicke [Tue, 11 Feb 2014 01:31:00 +0000 (01:31 +0000)]
Merge "Changed model versions to dependencies"

7 years agoDo not use deprecated StringBufferInputStream 16/5216/2
Robert Varga [Sun, 9 Feb 2014 21:02:56 +0000 (22:02 +0100)]
Do not use deprecated StringBufferInputStream

Change-Id: I745529dd05f2a4156dab98535ba73b81de44872b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix a warning 11/5211/3
Robert Varga [Sun, 9 Feb 2014 15:16:06 +0000 (16:16 +0100)]
Fix a warning

Change-Id: I8605ada63c471d9446ebf7fe31fb518138422cd4
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRewrite POSSIBLE_ENDS and POSSIBLE_STARTS 99/5199/3
Robert Varga [Sat, 8 Feb 2014 02:45:52 +0000 (03:45 +0100)]
Rewrite POSSIBLE_ENDS and POSSIBLE_STARTS

These two are really simple byte arrays, initialized them as such
withouth going through strings/UTF8.

Change-Id: Id80151d9ff57df4b7a5595f76f30a379d89af3dd
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Some methods should be final"
Ed Warnicke [Tue, 11 Feb 2014 00:08:29 +0000 (00:08 +0000)]
Merge "Some methods should be final"

7 years agoMerge "Expose ChannelFuture from sendMessage()"
Ed Warnicke [Mon, 10 Feb 2014 23:50:32 +0000 (23:50 +0000)]
Merge "Expose ChannelFuture from sendMessage()"

7 years agoMerge "Getter methods should be final"
Ed Warnicke [Mon, 10 Feb 2014 23:49:36 +0000 (23:49 +0000)]
Merge "Getter methods should be final"

7 years agoMerge "Fix a warning and make field final"
Ed Warnicke [Mon, 10 Feb 2014 23:44:58 +0000 (23:44 +0000)]
Merge "Fix a warning and make field final"

7 years agoMerge "Remove use of deprecated Exceptions"
Ed Warnicke [Mon, 10 Feb 2014 23:44:08 +0000 (23:44 +0000)]
Merge "Remove use of deprecated Exceptions"

7 years agoMerge "minor pom cleanup to eliminate duplicate group ID specification when the group...
Ed Warnicke [Mon, 10 Feb 2014 23:42:49 +0000 (23:42 +0000)]
Merge "minor pom cleanup to eliminate duplicate group ID specification when the group ID is the same as the parent pom, just removes some warnings from eclipse, should not be any functional difference"

7 years agoSome methods should be final 98/5198/2
Robert Varga [Sat, 8 Feb 2014 04:18:06 +0000 (05:18 +0100)]
Some methods should be final

Change-Id: I8969a8d099222f8360c07e621b9157c4bb5fb8f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Fix warnings reported in toaster"
Ed Warnicke [Mon, 10 Feb 2014 23:36:51 +0000 (23:36 +0000)]
Merge "Fix warnings reported in toaster"

7 years agoMerge "Fix a few eclipse-reported warnings"
Ed Warnicke [Mon, 10 Feb 2014 23:36:04 +0000 (23:36 +0000)]
Merge "Fix a few eclipse-reported warnings"

7 years agoExpose ChannelFuture from sendMessage() 97/5197/2
Robert Varga [Sat, 8 Feb 2014 04:17:00 +0000 (05:17 +0100)]
Expose ChannelFuture from sendMessage()

Change-Id: If76f0c3ab7ce290d50ed7177c08af78cb9f7a354
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGetter methods should be final 96/5196/2
Robert Varga [Fri, 7 Feb 2014 23:40:38 +0000 (00:40 +0100)]
Getter methods should be final

Change-Id: I24eafd9b1319e9296de5680220802820944fe333
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agominor pom cleanup to eliminate duplicate group ID specification when the group ID... 37/5237/1
David K. Bainbridge [Mon, 10 Feb 2014 20:03:51 +0000 (12:03 -0800)]
minor pom cleanup to eliminate duplicate group ID specification when the group ID is the same as the parent pom, just removes some warnings from eclipse, should not be any functional difference

Change-Id: I396126408fff54d7120d3ae94b2a5c447d14f8d2
Signed-off-by: David K. Bainbridge <dbainbri@ciena.com>
7 years agoMerge "Get rid of NetconfMessageFactory"
Ed Warnicke [Mon, 10 Feb 2014 19:44:20 +0000 (19:44 +0000)]
Merge "Get rid of NetconfMessageFactory"

7 years agoMerge "Get rid of DeserializerException"
Ed Warnicke [Mon, 10 Feb 2014 19:44:01 +0000 (19:44 +0000)]
Merge "Get rid of DeserializerException"

7 years agoMerge "Get rid of using ProtocolHandlerFactory, part 2"
Ed Warnicke [Mon, 10 Feb 2014 19:43:32 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 2"

7 years agoMerge "Get rid of using ProtocolHandlerFactory, part 1"
Ed Warnicke [Mon, 10 Feb 2014 19:43:22 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 1"

7 years agoMerge "Cleanup dependencyManagement section"
Ed Warnicke [Mon, 10 Feb 2014 19:42:50 +0000 (19:42 +0000)]
Merge "Cleanup dependencyManagement section"

7 years agoMerge "Remove repositories/pluginRepositories/distributionManagement"
Ed Warnicke [Mon, 10 Feb 2014 19:41:45 +0000 (19:41 +0000)]
Merge "Remove repositories/pluginRepositories/distributionManagement"

7 years agoMerge "Remove duplicate properties"
Ed Warnicke [Mon, 10 Feb 2014 19:41:24 +0000 (19:41 +0000)]
Merge "Remove duplicate properties"

7 years agoMerge "SwitchMgrNB: URL does not allow nodeconnectorId with forward slash"
Alessandro Boch [Mon, 10 Feb 2014 19:33:00 +0000 (19:33 +0000)]
Merge "SwitchMgrNB: URL does not allow nodeconnectorId with forward slash"

7 years agoFix for BUG 410 32/5232/3
Ryan Moats [Mon, 10 Feb 2014 18:02:16 +0000 (12:02 -0600)]
Fix for BUG 410

Ensure lower case alpha hex representation is included in MAC
regex match in all cases.

Change-Id: Ic2da17146cf8f9325cc5d951f70d614ec61762a0
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
7 years agoSwitchMgrNB: URL does not allow nodeconnectorId with forward slash 06/5206/2
Pramila Singh [Sun, 9 Feb 2014 00:15:10 +0000 (16:15 -0800)]
SwitchMgrNB: URL does not allow nodeconnectorId with forward slash

Change-Id: I489d5ae559b8c1e35a3c7b9749f7476618b2765b
Signed-off-by: Pramila Singh <pramisin@cisco.com>
7 years agoMerge "Fixed bugs in getUnsigned methods of NetUtils class."
Alessandro Boch [Mon, 10 Feb 2014 16:49:34 +0000 (16:49 +0000)]
Merge "Fixed bugs in getUnsigned methods of NetUtils class."

7 years agoCleanup dependencyManagement section 44/4744/4
Robert Varga [Fri, 24 Jan 2014 22:37:13 +0000 (23:37 +0100)]
Cleanup dependencyManagement section

Change-Id: I48ab30fc7f96ab0a30e1094f8f9ca5097be0975b
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove repositories/pluginRepositories/distributionManagement 43/4743/4
Robert Varga [Fri, 24 Jan 2014 22:30:03 +0000 (23:30 +0100)]
Remove repositories/pluginRepositories/distributionManagement

Change-Id: I1d005ee4ea4881d79c368a009ae2dfa1d643746a
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove deprecated API elements from protocol framework 91/5191/2
Robert Varga [Fri, 7 Feb 2014 22:50:42 +0000 (23:50 +0100)]
Remove deprecated API elements from protocol framework

The use of these concepts has been deprecated in version 0.4.0, which
was released. The only in-tree user was netconf, which was refactored to
not to rely on these concepts, so bump the version to 0.5.0 and purge
the  code.

Change-Id: Ibf2195b51bf12ea99b8b21f3da322d666b103b5e
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix a warning and make field final 90/5190/2
Robert Varga [Fri, 7 Feb 2014 22:20:04 +0000 (23:20 +0100)]
Fix a warning and make field final

Drive-by fix
- additionalHeader should be final,
- the class is not serializable, no uuid is needed

Change-Id: I484b07e64942179d153e7c42ca32d753fb2a5b23
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove use of deprecated Exceptions 89/5189/2
Robert Varga [Fri, 7 Feb 2014 22:19:04 +0000 (23:19 +0100)]
Remove use of deprecated Exceptions

DocumentedException and DeserializerException are deprecated and were
only used by deprecated interfaces which we no longer use. Stop using
them.

Change-Id: I899beb6d08be2c4a0b17ecbe6e1ca2be334e12a9
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of NetconfMessageFactory 88/5188/2
Robert Varga [Fri, 7 Feb 2014 22:15:56 +0000 (23:15 +0100)]
Get rid of NetconfMessageFactory

This removes the use of deprecated ProtocolMessageFactory and
ProtocolHandlerFactory. Just instantiate appropriate Netty handlers
instead.

Change-Id: I98b6424af0256483be21c92dfdbe4c0ddbac7a9d
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of DeserializerException 87/5187/2
Robert Varga [Fri, 7 Feb 2014 21:19:43 +0000 (22:19 +0100)]
Get rid of DeserializerException

We can throw anything, so use NetconfDeserializerException instead.

Change-Id: Ibf2b7f2778217b19e7b4aaf22571f19fdf3f610f
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of using ProtocolHandlerFactory, part 2 86/5186/2
Robert Varga [Fri, 7 Feb 2014 21:08:39 +0000 (22:08 +0100)]
Get rid of using ProtocolHandlerFactory, part 2

Now that we do not rely on passing it around, we can safely keep
NetconfHandlerFactory wired directly to the
ProtocolMessageEncoder/Decoder.

Change-Id: I47a9b76f8d9bbb98304e06960e5a85d2730994f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoGet rid of using ProtocolHandlerFactory, part 1 85/5185/3
Robert Varga [Fri, 7 Feb 2014 20:57:07 +0000 (21:57 +0100)]
Get rid of using ProtocolHandlerFactory, part 1

This gets rid of completely dead code in NetconfSshClientDispatcher. It
already talks directly to the initializer.

Change-Id: Ieaac37a3335e87032730cfa65e94bb59f26dd3c1
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove duplicate properties 42/4742/4
Robert Varga [Fri, 24 Jan 2014 22:28:48 +0000 (23:28 +0100)]
Remove duplicate properties

Change-Id: If079f0051241989a4f71e0ac8fa42f3a80e27182
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Cleanup imports/whitespace in MD-SAL"
Ed Warnicke [Mon, 10 Feb 2014 12:20:21 +0000 (12:20 +0000)]
Merge "Cleanup imports/whitespace in MD-SAL"

7 years agoMerge "Adding FlowRef,GroupRef and MeterRef for the ErrorNotification Message"
Ed Warnicke [Mon, 10 Feb 2014 11:56:41 +0000 (11:56 +0000)]
Merge "Adding FlowRef,GroupRef and MeterRef for the ErrorNotification Message"

7 years agoMerge "BUG-362: add some diagnostic information Changed Remote RPC Server Implementat...
Ed Warnicke [Mon, 10 Feb 2014 11:55:41 +0000 (11:55 +0000)]
Merge "BUG-362: add some diagnostic information Changed Remote RPC Server Implementation to log an error when host IP address is not found and stop itself. Earlier it would raise exception that the configuration subsystem could not handle."

7 years agoCleanup imports/whitespace in MD-SAL 83/5183/3
Robert Varga [Fri, 7 Feb 2014 20:01:21 +0000 (21:01 +0100)]
Cleanup imports/whitespace in MD-SAL

Change-Id: I0f18ffe229ed213308a0cd5cf343fd64ff79a17c
Signed-off-by: Robert Varga <rovarga@cisco.com>

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.