Minor sal-distributed-datastore cleanups

Corrent a @GuardedBy annotations, add @NonNull annotations, fix javadocs
and make a few methods final.

Change-Id: Icb93aae229fb0aece5ece223a759ce9f36ee0297
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use ImmutableList.Builder in FrontendClientMetadata

We are performing a defensive copy in constructor, hence it is
better to allocate a builder, skipping an untrusted copy operation.

Change-Id: I95d7aa90f6da325aaae6a340caf49a6e17fe9f64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use ImmutableSortedSet for small ImmutableUnsignedLongSets

This adds a bit of indirection, but for a few entries this ends up
using arrays instead of an RB tree, offering better density.

JIRA: CONTROLLER-2012
Change-Id: I09714c6bf3272946f6cee4360f80a106453d0e61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use UnsignedLongSet instead of RangeSet in metadata

Split UnsignedLongSet into two implementations, mutable and immutable.
Use the mutable implementation in runtime tracking of identifiers and
use the immutable implementation for tracking identifiers in metadata.

The serialization format is kept compatible with RangeSets, although
that implies a minor penalty in serdes.

This switch ends up potentially using more objects for small sets, but
that is offset by not having Cut indirections and most notably being
resistent to allocation of huge arrays.

JIRA: CONTROLLER-2011
Change-Id: I0c84ffaaa4ce39299cef9006784b8aff78dd0f83
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reimplement UnsignedLongRangeSet

We are tracking simple discrete values, for which a RangeSet is an
overkill due to it being generalized utility working with all possible
ranges.

Reimplement UnsignedLongRangeSet as UnsignedLongSet, tracking discrete
closed ranges of longs, which improves both memory footprint and speed
of contains()/add() operations.

This also spots a failure to disconnect purged histories during
FrontendHistoryMetadataBuilder.toLeaderState().

JIRA: CONTROLLER-1720
Change-Id: I24fae4174201fd133a282f27589d6c274c06c8dc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve Frontend{Client,History}Metadata

We are using Guava's immutable implementations, make sure we annotate
fields with @NonNull and use concrete types.

Change-Id: I4fc2a0ff39b2b8166deca41425771ea9ed04e469
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Sprinkle @NonNull on FrontendClientMetadataBuilder fields

We have two fields which are guaranteed to be @NonNull, mark them as
such, making it clear we comply to getIdentifier() contract.

Change-Id: I9159823fb6c8a4a3c064796cb6752f57d98846c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct Frontend{Client,History}Metadata deserialization

We are turning Range.closedOpen() into Range.closed() during
deserialization, which the resulting ends up also covering the upper
bound, which it should not.

JIRA: CONTROLLER-1942
Change-Id: Ib8f9016e2eddcf014ff5e451ac82cd77b66d7019
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct annotations

Correct @GuardedBy vs @Holding and add @NonNull annotations.

Change-Id: I2142b1c5910f2388e8f30a04f7ff8bc8237dde26
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix eos entity lookups with YangInstanceIdentifier

Caused by entity-name only being a string type which was inadvertently
trying to lookup all entities as General.

Fix this by changing entity-name to a union of instance-identifier and
string.

Also changed up the output of get-entities slightly:
- if the entity is string based it will only contain the name in the
  output.
- if, however, it is Instance-identifier based it will contain the
  entire identifier in the name field.

JIRA: CONTROLLER-2009
Change-Id: I93e108bd54b14850b6bf276ec1eca4d7671d7d87
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump version to 4.0.6-SNAPSHOT

This starts the next development iteration.

Change-Id: I48c884e1f35f9509b811bb654fdec22c3dc198b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Realign odlparent versions

We have a misalignment of versions, which may hurt downstreams. Also
bump mdsal, as it is fixing the same issue.

JIRA: CONTROLLER-2008
Change-Id: Iacf5921d4f960eaef554419cd6b2dac3494fd2a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I8f8e85a7b2bb1a07f0d05948d372ae3f7d42345a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge (Abstract)TransactionContext

We have an interface and an abstract base class. Merge the two into
an abstract class, reducing visibility of various methods. Also derive
from AbstractSimpleIdentifiable, to make it more explicit we require
a transaction identifier.

This allows all callers to bind to the same vtable, improving method
dispatch.

Change-Id: I51419c4ac832aa676c8707d9bd459936fd906760
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Use odlparent-9.0.7, yangtools-7.0.9, mdsal-8.0.6.

Change-Id: I661a98b52b7b93b63a348e15deb4b548ca0f5075
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Tune eos gossip/notification intervals

Looks like eos gossips take much too long, so lets
lower these so we have faster response times all around.

JIRA: CONTROLLER-2004
Change-Id: I3daf8d207a6b51b16e6b8cb3f7dcefd55e6626cf
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Pull in atinject_spec-1.0

pax-exam is using version 1.0, make sure we can work nicely with it.
Should fix controller-sonar failures.

Change-Id: I0f185b02a5b63ddadfd72993160db350f9513164
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to akka-2.6.17

https://akka.io/blog/news/2021/10/15/akka-2.6.17-released

Change-Id: I4183b02b42fb3dcda599ba77c73d26832fabea7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Scala to 2.13.6

https://github.com/scala/scala/releases/tag/v2.13.6

Change-Id: I6fba6c4d7856446d54cb016ec3a93f4976375a0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup LogGenerator

We are getting flagged in SonarCloud for this example, clean it up.

Change-Id: I9665e444857f6fb5b67a1bcb064d10b0ada8069b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move odl-controller-blueprint dependency

Nothing in odl-mdsal-distributed-datastore needs blueprint, move
the dependency to lower blueprint exposure a bit.

JIRA: CONTROLLER-1999
Change-Id: Idea6146c9cdb9d0db363f6d0443e0294af42f72b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use odl blueprint in odl-controller-exp-netty-config

Components packaged here do not need ODL blueprint extensions, do
not pull in the corresponding plugin.

JIRA: CONTROLLER-2005
Change-Id: Ibd45c6e9aee39eba83ab7c266cababfde2d7ff5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate rpcbenchmark to OSGi DS

Ditch blueprint and use turn NtfBenchmarkProvider into a simple
component. Requires some amount of refactoring.

JIRA: CONTROLLER-2001
Change-Id: Ib8db52d91013fe1ae13c55b5537b743f8ccbf320
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate ntfbenchmark to OSGi DS

Ditch blueprint and use turn NtfBenchmarkProvider into a simple
component.

JIRA: CONTROLLER-2001
Change-Id: I68dd5559f61c28bbdcbff54815af7d287e948a50
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate dsbenchmark to OSGi DS

Ditch blueprint and use turn DsbenchmarkProvider into a simple
component.

JIRA: CONTROLLER-2001
Change-Id: I5378359af1ae12d2f7cc03c281599f71ded5a06a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use URLEncoder.encode(String, Charset)

We are running with Java 11 and as Modernizer correctly points out, we
can use direct charset variant which was introduced with Java 10. This
cuts down a tiny bit of dead code.

Change-Id: I7c42984bc1e05e94f5266f26e13aaab650ae4f70
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Introduce cli commands for cluster-admin

Rework the rpcs needed by csit in cluster-admin to karaf cli commands

JIRA: CONTROLLER-1996
Change-Id: I148c7c9140701ff8ffe81c612999898115f4661d
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>

Specialize TransactionContextWrapper

Most of the time we are talking to local leader, in which case
we do not need to queue messages and bounce them through the queue.

JIRA: CONTROLLER-1952
Change-Id: I07d85c82c2ab6e4251c70b2e6d1dafa2dc455d39
Signed-off-by: tadei.bilan <tadei.bilan@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Be mindful of non-existent actors

We have observed the following splat in SFT:

java.lang.NullPointerException: null
        at org.opendaylight.controller.eos.akka.registry.listener.type.EntityTypeListenerRegistry.onUnregisterListener(EntityTypeListenerRegistry.java:69) ~[bundleFile:?]
        at akka.actor.typed.javadsl.BuiltReceive.receive(ReceiveBuilder.scala:213) ~[bundleFile:?]

This this by checking whether we actually removed a listener.

Change-Id: Ifc80ae650db05fd1031af074c694588034f6903a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I06cec6aa2381d9aa96edb2555352458bdc60d0a9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a private modifiers to command arguments in clustering-test-app

Change-Id: I29e188d39a7dc507c0f9f61f086e699522757dc5
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>

Increase eos-dom-akka teardown timeouts

Looks like the default 10 seconds is not quite enough on releng.
Increase the default shutdown timeouts to 20 seconds.

Change-Id: I6a5b3bc6822835dd2515cef86de7376162d070bf
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Introduce cli commands for clustering-test-app

Rework the rpcs needed by csit in clustering-test-app to Karaf CLI commands.
This is essentially a custom-coded invocation of MD-SAL services.

JIRA: CONTROLLER-1995
Change-Id: If406a4dff6d441e9d0932de05f844d66f1e5bc83
Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Use odlparent-9.0.6, yangtools-7.0.8, mdsal-8.0.5.

Change-Id: Ib14c3b138a88e58104650bd2026618d53fec1011
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use terminate message in eos listener actors

getContext().stop() can cause NPE during actor system
shutdown so lets use a terminate message here instead.
Its still possible to get dead letters with this approach
when the child actor was stopped first during the shutdown,
but at least we prevent the NPEs.

JIRA: CONTROLLER-1989
Change-Id: Id38b56c12141164d45ed19613885a4d9f650e4dd
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Bump akka to 2.6.16

https://akka.io/blog/news/2021/02/23/akka-2.6.13-released
https://akka.io/blog/news/2021/04/08/akka-2.6.14-released
https://akka.io/blog/news/2021/06/10/akka-2.6.15-released
https://akka.io/blog/news/2021/08/19/akka-2.6.16-released

Change-Id: I6d255bd6d2b4b1284bb6c7d8ccae4ec44a691556
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Cleanup OwnerSupervisor a bit

Use streaming to reduce funky copy/remove/remove cycle. This way
we perform minimal needed materialization.

Change-Id: I0cf25fc7bb57e2d053cb4368cdd4ac8905995e42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I5c4e26a129c037afa783b309ceb031435677faea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix parent reference

The relativePath needs to point to correct pom, fix that.

Change-Id: I76382cc09ec294f585cdb7fdc1fd86a0bc2762b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expose entity details in MDSAL

Our previous implementation was very open about it state, which was
completely visible through RESTCONF (and from datastore).

We have a number of tools which need information relating to where each
entity lives -- and to that effect we want to expose a read-only API.

This patch instroduces odl-akka-eos model, which exposes a few RPCs,
which in turn provide information formerly visible from the datastore.

JIRA: CONTROLLER-1992
Change-Id: I85da8941f84ca9e109c4dec61fb07a697e937639
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove PeerUp/Down messages

These were used only in EntityOwnershipShard and thus
can be removed.

JIRA: CONTROLLER-1993
Change-Id: I49873bf7e379c996719d6ec1b3bfc88395b3f3fd
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Handle owner changed message

We need to handle this response message otherwise
it ends up in dead letters polluting logs.

JIRA: CONTROLLER-1994
Change-Id: Idd110e48a10f2d290b2a587fdd2dcf11f2a89d51
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt odlparent-9.0.5, yangtools-7.0.7, mdsal-8.0.4

Change-Id: I5d6be3c4c658668aa41f659c7956fe42a0501d52
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt odlparent-9.0.4, yangtools-7.0.6, mdsal-8.0.3

Change-Id: I1cea6ced706978b2bd3e11b0532b2ec5f1da55a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal

Adopt latest versions, namely;
- odlparent-9.0.3
- yangtools-7.0.5
- mdsal-8.0.2

Change-Id: I11e44a49e1ba55ed45aa890efcbe353f4591a11f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup DataCenterControl javadocs

Add a @return and improve phrasing a bit.

Change-Id: Ic9d4cca1a98d2618a9765f34bebc0f5d98657b34
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename NativeEosService to DataCenterControl

This is a wee bit more descriptive name. While we are here, also ditch
java.lang.Void, as it promotes nulls. Use yamg.common.Empty, which has a
singleton instance.

Fold common implementation code into a static method, which is making
things very obvious.

Change-Id: I28230523034224e978244d1edce997376812bf91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I41da66267aec81d79ab0d60a7b6f87827a0bf350
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal/yangtools

Adopt yangtools-7.0.4 and mdsal-8.0.1.

Change-Id: I832db6bf295da8b9bd55a15628a975b70e0852ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ignore DataTreeChangeReply message

DataTreeChangeListenerActor is sending replies towards shard on each
processed datatree change. This is not handled by Shard, which ends up
flooding dead letters.

Make sure we ignore these messages, so that the logs are cleaner. Also
speed up the non-null check in DTCLActor.

JIRA: CONTROLLER-1986
Change-Id: I11b172d778c5b8cdf16aec58e77ec7faa9b6b146
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 4.0.1-SNAPSHOT

This starts the next development interation.

Change-Id: I9f28f1a3d346b2288c77b43b612ee136c1b6ab3c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix MXBean annotation warnings

Use transitive requires to expose annotations to downstream users.

Change-Id: If7a47430c7c2a25d80fae05717113d42373885c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove support for payloads older than Sodium SR1

Older payloads are not as efficient, nor can they really support
all our datatypes. Prune supported versions to Sodium SR1-and-newer,
retaining 2 years worth of backwards compatibility.

JIRA: CONTROLLER-1985
Change-Id: I5ebabee1ddff37af7c0e0a5dca91db433ca9d5ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove support for pre-Sodium SR1 peers

The messages exchanged between cluster participants are versioned to
maintain backwards compatibility. Trim how far back we can go to
Sodium SR1 -- breaking compatibility with Boron, Fluorine and
Neon SR2 software.

JIRA: CONTROLLER-1985
Change-Id: I11ba4041242650bc3ad70da3f4b2869df0ca5ceb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

VersionedExternalizableMessage.getVersion() is final

This is a property which is under control of the baseline class,
do not allow it to be modified.

Change-Id: Icab5e415954b27842f5af65ecde75202a0c53589
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Activate DataStoreVersions.PHOSPHORUS_VERSION

Flip the current version to Phosphorus, taking making a few
improvements:
- CompositeModification's structure is better
- BigInteger is no longer supported

JIRA: CONTROLLER-1939
Change-Id: If6105c302a9d7c3b4a6591600d62a04abf55d582
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add new MutableCompositeModification version

Add new version of MutableCompositeModification, that will write NNDO
header right after number of modifications, forming proper embedded
block of modifications.

For communicating this, we are renaming
DataStoreVersions.MAGNESIUM_VERSION and reusing it for the bump.

JIRA: CONTROLLER-1939
Change-Id: Ic5c2a8f91fcc41e78682ec202442308d6dc1191a
Signed-off-by: tadei.bilan <tadei.bilan@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup docs dependencies

We have a @PreDestroy reference, make sure docs compile.

Change-Id: I72537f6ea6be660971db0bc8e6f1114d9fb92eab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove obsolete datastore.cfg properties

We have a number of leftovers here, which have been no-ops. Remove them
to reduce code clutter.

JIRA: CONTROLLER-1984
Change-Id: I490188fb7ebc83c344997861d637852f40fce7a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Hide ShardManagerSnapshot

This class is scheduled for removal. Hide it before removing it.

Change-Id: I902d33da14411ec44429de5474d953adc9722dea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update sal-distributed-datastore tests a bit

Use MockitoJUnitRunner and clean up imports/mocking a bit.

Change-Id: I854f95e37e503d28903c8aa83aecafdef4c4c1fa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Lock down ShardDataTree

Now that our primary user is an implmentation detail, we can lock down a
few aspects of ShardDataTree operation. This will ease refactoring
further down the road.

Change-Id: I91248347889ea0ceecee9f093f54b5d8241fb39c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update SimpleShardDataTreeCohortTest

Use MockitoJUnitRunner instead of MockitoAnnotations.initMocks().

Change-Id: I2a96d971ca100278e495f826c988f85e2f83efb1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove org.opendaylight.controller.sal.common.util

Arguments and NoopAutoCloseable have been deprecated for removal, remove
them now.

Change-Id: I72017f2cf9deffb99d493392a84ca829c639c592
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix sal-common-util dependencies

We have a number of unused dependencies here, clean them up.

Change-Id: Ibc534ab9ba28a7e70270a042a1b8e55f8934bc28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Lock down controller.cluster.datastore.Shard

Since sal-distributed-eos is gone, we do not have any known subclasses,
lock down Shard implementation as much as possible. This will aid us in
refactoring later. The entire class is now considered an implementation
detail, amenable to changes driven by RaftActor evolution.

Change-Id: Ic54794b33766459f16a5ebdac6a3faa731c2b49d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove an TrieMap dependency

We are not using TrieMap directly, do not hard-code a dependency on it.

Change-Id: I3285e2f1484c1f9db9dd4b149f469c9392ddb7d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove sal-distrubited-eos

There are no more packaging references to datastore-based entity
ownership. Remove the implementation.

JIRA: CONTROLLER-1982
Change-Id: Ia6a96a1853e0f173d7af559c76a06e9dfadc540e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add integration test with cluster-singleton

JIRA: CONTROLLER-1982
Change-Id: I75aec3a46da42c38287970590006655a2d15b926
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Cleanup candidate registrations from previous instance

JIRA: CONTROLLER-1982
Change-Id: I5337b08f6fd951a7a2acabb935cbf2e2156f5985
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Add cluster-admin api for datacenter activation

Add rpcs into cluster-admin so we can activate/deactivate
datacenters for active/backup scenariop.

JIRA: CONTROLLER-1982
Change-Id: Ic68652199d79251fe9b166e47ca06520121213e4
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Snapshot and journal export on recovery

Added ability to export snapshot and journal content into json file
during recovery.

JIRA: CONTROLLER-1955
Change-Id: Ic2d6181ab56d7b413f06ed91cf5f9d37e3aa2029
Signed-off-by: tadei.bilan <tadei.bilan@pantheon.tech>
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use akka-multi-dc in eos native

Add the ability to activate/deactivate singleton supervisor.
Make the supervisor pick owners only from the active datacenter.
All in all this should give us the building blocks needed for
the active/backup cluster use-case.

JIRA: CONTROLLER-1982
Change-Id: Iae0a4a59cc461c8187c59bb8a5a66c73dee5be4c
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade lz4-java to 1.8.0

https://github.com/lz4/lz4-java/releases/tag/1.8.0

Change-Id: Ica9bc96f8db76cb8dd8eda19264f72bfb1ea674c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up sal-clustering-commons dependencies

We are not using yang-model-util here.

Change-Id: I30c03983964f614cfe0d19e2494f1ccdf0f53a79
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup cds-access-api dependencies

We do not need sal-clustering-commons anymore, as the requisite
functionality has been upstreamed.

Change-Id: Ia2bcf61e1eaed79e349fad811e88e710f76a232d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert netty-threadgroup-config to OSGi DS

This is a rather simple wiring, use OSGi DS instead of blueprint.

Change-Id: I49686821b3d7f70ae058d3362b16d9c6acae8d03
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use mdsal-8.0.0

Use released versions of MDSAL artifacts.

Change-Id: Icf98e0732d870d1ac79a7b5101dbe64d2bed7781
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adjust to DOMDataTreeChangeListener update

We are required to implement onInitialData() method, add it.

Change-Id: I55e60c9013c49689252f662218db31152982019c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correctly forward DOMDataTreeChangeListener.onInitialData()

When registering proxy listener, make sure we do not lose
onInitialData() events.

Change-Id: I2529d64d10f477ad52e90dec15d88c6228a47af0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup dependencies

We have superfluous dependencies in a number of non-production
artifacts. Clean them up to better bracket our intent.

Change-Id: I30968cd763bd8c727eccdf33299c6f3fb93b0570
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded dependency

sal-dummy-distributed-datastore does not need clustering-commons.

Change-Id: Ibeedb314011ee7f6956627040cc656643a32121a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove prefix shard leftovers

With the removal of everything producer related we
can also remove everything related to prefix shards.

JIRA: CONTROLLER-1977
Change-Id: I05bd1a286cd8fac252c122d2118d1d7dedcc8941
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Bump yangtools to 7.0.3

Pick up latest fixes from upstream.

Change-Id: Ib1372f4ec100c9ab65c5c8302bd8492f3eae39b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 7.0.2

Use released version instead of snapshot.

Change-Id: Ie083843b018ccb731c5890e9ec737aa45cfc7cc3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Introduce DOMEntityOwnershipService replacement

Introduce a new DOMEntityOwnershipService implementation backed by
Akka's distributed-data and cluster-singleton. This severs an
implementation link to sal-distributed-datastore, reducing overall
complexity.

JIRA: CONTROLLER-1982
Change-Id: I30753e83d1af10658141311842bdceb315b9237f
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded exclusion

jsr173-ri is excluded by odlparent now, remove the unneeded exclusion.

Change-Id: I44530c041491cc6bf7eeceedf94b36c3da76efac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools

Pick latest fixes from odlparent-9.0.2 and yangtools-7.0.2-SNAPSHOT.

Change-Id: I90c9896263c3e7bc1c38221d37cee7f32b8f2de5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove model-inventory and odl-mdsal-model-inventory

This model is only used by OpenFlow world, do not carry it in controller
and let OFP take ownership of it.

JIRA: CONTROLLER-1979
Change-Id: I12371cafba9f8033e8d2174181769b6ac11793d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal

Adopt latest versions, namely;
- odlparent-9.0.1
- yangtools-7.0.1
- mdsal-8.0.0-SNAPSHOT

There are a few adjustments needed, which mostly deal with the interface
to NormalizedNode.

Change-Id: I918fb885a6df62e16e17119a7e04ba1672ef7c39
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use correct failure detector for akka clustering

Since we are not using classic remoting, we need to use proper
tuning for clustering's failure-detector. Correct the template
to reflect that.

Change-Id: I4bff994b786237778df5bdfb83df858b00b549ed
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use memory-mapped segmented journal by default

Segmented file implementation requires a buffer double the size
of the file's maximum size. This ends up being allocated on-healp, which
is wasteful from effeciency perspective. Switch default configuration
so that it uses memory-mapped files instead.

JIRA: CONTROLLER-1954
Change-Id: Icad9ef74c50467323e31567828a949c0cae52a9e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to Akka Artery

The migration away from legacy akka remoting to artery tcp.

JIRA: CONTROLLER-1968
Change-Id: Iac1a0186292eb5a303cf075e540f3f6c8c09a932
Signed-off-by: Kostiantyn Nosach <kostiantyn.nosach@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable odl-controller-broker-local SFT

JIRA: CONTROLLER-1584
Change-Id: I6462efd24d7c4e72fd3c7c18917e2d90d6effa86
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Move odl-mdsal-broker-local feature

JIRA: CONTROLLER-1584
Change-Id: Iae6840f75df0f90cc5427b3b83fc6289fa09ee10
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Migrate javax.inject references

Use GuicedEE reference instead of the old javax.inject jar.

Change-Id: Id54d90aee20f967a013c90c1be39437ad5abc97e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate osgi.core reference

OSGi core artifact was renamed for Release 7, update references to
eliminate dependency on OSGi R6.

Change-Id: I1e51f5bd82e15e3cefb7dad637e0e771abcefcea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove model-topology

The opendaylight-topology*.yang models are the very first cut at
modeling a network. As such they have been superseded by standard-track
draft ietf-topology, which evolved into ietf-network.

There is noone using these old models in OpenDaylight proper, which
means they are just a maintenance burden and serve only to confuse
newcomers.

JIRA: CONTROLLER-1978
Change-Id: I051781d05f1caf10b9b3c65a4f178b20162adad6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove odl-controller-exp-messagebus

Messagebus bridge is an unfinished concept, which was never productized.
It was deprecated in previous release, now we remove it.

JIRA: YANGTOOLS-1974
Change-Id: I8d544f8edf54bcacfb36419badb5003976e6b409
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove DOMDataTreeProducer-related classes

DOMDataTreeProducer is being removed by upstream, remove our
constructs relying on it.

JIRA: CONTROLLER-1977
Change-Id: Icbbcdd41ac0df3ee916538f18908edda21f23cd8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>