Bump versions to 6.0.11-SNAPSHOT

This starts the next development iteration.

Change-Id: I27b9ec2e053b70f91fad2d5046f6ee1f13668287
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release controller

Bump upstreams

Adopt:
- odlparent-11.0.7
- yangtools-9.0.10
- mdsal-10.0.9

Change-Id: I5f673ef51b9d6271ce7e0ecc8f9915d3eab6f30d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor RaftActorTest to avoid test failures

The "doReturn(value).when(mockObj).coolMethod(same(arg))" way of mocking
the return values for "coolMethod()" calls resulted in
UnfinishedStubbingException, even though there seems to be no reason
for such error. This change introduces "the other" way of such mocking:
"when(mockObj.coolMethod(same(arg)).thenReturn()".

JIRA: CONTROLLER-2080
Change-Id: I58b9c08780c27b43ad5eff4e21c921b9260fc236
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
(cherry picked from commit 1f3e1e45b2a4805fca97a375893c96103a48c175)

Make snapshot offset long to prevent overflow

The current implementation uses integer which can
easily overflow if the Snapshot grows over 2.14GB

JIRA: CONTROLLER-2086
Change-Id: Ibbe3d3e1667cf59137e057b31141033a826142e4
Signed-off-by: tibor.kral <tibor.kral@pantheon.tech>
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2528d0289abab04cac5cbdf973f1bb4cff6c4864)

Fix sal-distributed-datastore checkstyle

Upgraded checkstyle is flagging a few nested classes as potentially
final, fix that up.

Change-Id: I8f5370fb700a76f6f71ad186d78cbb50e595a8a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 91143d29e61cd262543f0ec2d0b85461c2898b23)

Fix sal-remoterpc-connector checkstyle

Upgraded checkstyle is flagging a few nested classes as potentially
final, fix that up.

Change-Id: Ie3835769d50e3a692644fc0dbed480e6c4d5f2de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8ed828bb0f5cbc52ae6d217e71d3eba844222ee2)

Clean up SnapshotManager nested classes

Upgraded checkstyle is detecting a number of these as 'should be final'.
Fix those findings.

Change-Id: I171c046616a0b0c30f5cd46de0d3486e9943e757
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 44bd251909ae479ccf452f6d4f4ca36d9e478d6d)

Fix FlexibleThreadPoolWrapper checkstyle

Nested static classes are detected as checkstyle violations if they are
not final. Fix that.

Change-Id: Ifa5878890cabe845ecf8d98d46f2fc8015a78770
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 771bcd1a76b7f40f2338c047eced3e34794c33a1)

Make MemoryOutputStream final

This is a checkstyle violation with upgraded checkstyle. Fix that.

Change-Id: I370b50baa146a710632e501f1ce7acad913166c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2209dcefbf9cf3b980ea0c0efab1ca29aed6cccc)

Bump Scala to 2.13.12

https://github.com/scala/scala/releases/tag/v2.13.12

Change-Id: Ic406869380c4b639508d05ef0e40ca9c2a09cb75
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c1b9e960d0888cc42f58268f61fd0db75b4c77b9)

Bump akka to 2.6.21

https://github.com/akka/akka/releases/tag/v2.6.21

Change-Id: I79d5d143ac6e8e35661568c439fa07acdf34f64b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ebdf7aac3fe5bb9db1d3512c8228b5b715488e86)

Bump Scala to 2.13.11

https://github.com/scala/scala/releases/tag/v2.13.11

Change-Id: I9bc86788da00c1d46eadb298db1c55fe19bbca5f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.10-SNAPSHOT

This starts the next development iteration.

Change-Id: If5c969a849cba665e2ebde9d994693c0e3903c93
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-11.0.6
- yangtools-9.0.8
- mdsal-10.0.8

Change-Id: Ieb9e3fa72eed3bac725069eb93ded0f9226d4475
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.9-SNAPSHOT

This starts the next development iteration.

Change-Id: I1ab1e8f5d25e615920475c74de15f5f81294a926
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove explicit Serializable

All Payloads are serializable, hence AbstractIdentifiablePayload is as
well.

Change-Id: I4153cad6f800746162d5e2cebb7f80f655d6ec32
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 79790f2c144d1b7d9275b1c8bd70983de8b929e8)

Use ArgumentMatchers.anyCollection()

Instead of using any(Collection.class) use better anyCollection()
method.

Change-Id: Icff803dd6379dc15dfca1d2ab1bf89319f583e22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 55ac0d700c4b20f145924b169b938321dc10a476)

Eliminate unneeded else branch

Eclipse is right to point out we can just ditch the else branch.

Change-Id: I816dd9a34b6fd8e1272ad1b8b93c2c5b3120ed4b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1a9684ec6ce9dae26b3292028f6a2b3fa5d61cc4)

Diagnose mockito downgrade better

Mockito is doing a very weird thing to get the inline MockMaker work,
which is known to not work with OSGi. Clean up the way we are
approaching byte-buddy and provide a pointer to the issue.

Change-Id: I87420710c5b6859e984fb72204826b91c7e4863a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 17a018384a969e748b79c1146b982f3b924c178d)

Clean up cds-access-client dependencies

Update dependencies to match what we are actually using.

Change-Id: I8c6e17cfe853e6e7105fdc497315aaf008cf4c7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3d5859ae84a722c9481071f506b84acd8f6c5ae6)

Reduce mockito workaround

Use mockito-inline and upgraded mockito.

Change-Id: Ibc3ff9afbef0d586ed186c08de5364420c795fce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 793af237fdd742b0bf925a6bc9897a38804c5bdc)

Bump upstreams

Adopt:
- odlparent-11.0.5
- yangtools-9.0.7
- mdsal-10.0.7

Change-Id: Id719d3ec6e1cde33b6cec006e13144783255d17d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove commons-lang dependencies

Use commons-lang3 instead, as it provides better interface anyway.

Change-Id: I8574166cf77f8f40c9a2ada4b06cc0d8b14244a9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9d54b1eee0fad545f720eebbbf6634bdab14bd80)

Fixup sal-cluster-admin-impl dependencies

The dependencies here are rather baroque, clean them up to the point
of confusigng maven-dependency-plugin.

Change-Id: Ifbc3e605217b0ece2ea7691d96eea28ec7bef3fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a104ab1562db179590eaa5bd742d9e00073d4053)

Honor shard-batched-modification-count

RemoteProxyTransaction should honor not use a hard-coded limit, but
rather pick it up from DatastoreContext configuration.

JIRA: CONTROLLER-2075
Change-Id: I5cf6491f76c05582b2c59e918d8af9521c01d98f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ba5f7cb9866163cffbae48d50355bc48cb3d0604)

Use instanceof patterns in RemoteProxyTransaction

Remove explicit casts with instanceof patterns, which are safer. Also
use Optional.orElseThrow().

Change-Id: If52285168a2ec6791ca86ba095f0e944fae8d3f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e4673e2f5f64daaed0ce44680f425fb1171b1fee)

Centralize DataTree operations

Centralize taking the snapshot and creating a modifications to the
extent possible.

Change-Id: Ifd2632f583230046686c97cd1b07fefd06266451
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7708d30b155169f6226b09973d6ff457214ec75e)

Use instanceof pattern in FrontendReadWriteTransaction

Improve cast safety by combining the check and cast into a instanceof
pattern,

Change-Id: I987f78de9df8ca1f3ccbb98fd807938bb0743855
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9939de5ae72370f3d27f0b789b2ee9e3f6f14fcc)

Fix StandaloneFrontendHistory accounting

testTransactionForwardedToLeaderAfterRetry() is exposing a scheduling
difference between the two implementations -- with tell-based protocol
we are holding off sending modifications until there is a significant
event needing them to be flushed to the backend.

Fixing this up exposes a bug in StandaloneFrontendHistory transaction
accounting, as circles back to ShardDataTree, where its transactions
are accounted for again -- fix that mistake by allocating transactions
directly in StandaloneFrontendHistory.

JIRA: CONTROLLER-2017
Change-Id: Ied00910f55bd3c63f99ae187396c1a193e5ece20
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f70fb5eaee514ffa5963049ac12286c2dee4ff80)

Access historyId only once

This is a simple improvement, improving access a bit.

Change-Id: I42dbd91a0a8d5ce75cd99b36d786d446eac69501
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c45dbeced41db0fa006d12648f6c56e0a4be8f87)

Use instanceof pattern in AbstractFrontendHistory

Reduce the number of casts by using instanceof patterns.

Change-Id: I0ce1ca0229b1e55a5b4745584b679a7872953297
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7314a4f99840d76cd0c167d22a588d98faa362a4)

Fix DistributedDataStoreRemotingIntegrationTest typos

We have a few typos in comments, fix them up.

Change-Id: I574849a397f6dea62e928026609c8a191451d701
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 1c7ddb7ffc8a78636c731ca589945636f28007a2)

Add java.io.Serial to EmptyState

Annotate members related to serialization.

Change-Id: I46b486244cd4f34dbae47c459c353411eccdf675
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ef9927802a079c374db971f94b33b030fd355943)

Mark Payloads with java.io.Serial

We have a number of fields/methods which should be marked with @Serial,
add another pass on them.

Change-Id: Ie08d6e718980e4e3acb148226760ad75ef82566e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c1bae57105d04c2d13fcf6c0ca654177743b51f8)

Mark readResolve() with @Serial

This method is related to serialization, mark it as such.

Change-Id: I65fc80e73a7a6775e8f535f85ba8c5af7ab6677b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 537c44438b1e8854b719903ac2a4a0d5e12d6606)

Improve Follower's Snapshot

Use List.of() to communicate empty lists.

Change-Id: I5cebcde9e92b11a82be0bddf3645eeb8bc909895
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 703c260bebba0a8f7efa85edef4ad4d359c59cda)

Improve Candidate.votingPeers

Use ImmutableList to ensure the list is never modified. This also
improves overhead/performance slightly.

Change-Id: Iad491da0e446da0a07e96067846c2c57c0dcfb9a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e44f00950d144590e0d30ef892e7b8e800dcbb06)

Clean up sal-clustering-commons

Clean up argument finality and whitespace in for(:) constructs.

Change-Id: If22f693e6c499aafc8fe0a606b2abb40a9f67cfc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 5608c84a27437ec16ea732c76cf4fd176342a605)

Clean up RpcErrorsException

Fix whitespace and use local variable type inference to improve sizing.

Change-Id: I344305a59e3b0078d942636c339d1686c006e4a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit fc3cdd82fa019e010afc624e1a0f1d56609c0a59)

Dump DTCL changes on trace

Reduce memory usage by not dumping all changes at once, but rather each
of them separately and only when trace is enabled.

Change-Id: I954dd4576d2625a862b254532379974c19bc1c60
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f8208948eb67a26207343ca60b5b19286f5e4410)

Upgrade reflectasm to 1.11.9

https://github.com/EsotericSoftware/reflectasm/issues/68, removing the
need to override ASM version.

Change-Id: I489f75a63f9649518493291fe0f36362d4011242
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.8-SNAPSHOT

This starts the next development iteration.

Change-Id: I2664b22c7e8565dcad3aa46b9a6264f226db4ee9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to use PayloadVersion.CHLORINE_SR2

PayloadVersion.CHLORINE_SR2 is more efficient format, switch to using
it and deprecate old versions for removal.

JIRA: CONTROLLER-2056
Change-Id: Id05a34a28e4d3e817fc6ff783669493ee80af3b7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0f88bd70a92ec2b536b0633a6ba4e6733cee475d)

Revert "Revert "Bump upstreams""

This reverts commit 9053d501fd2c8327e5e94c6458705047df39e1e9,
reinstating 0875001fa5c27015f44bd8afc802d148bc475775.

Change-Id: I5731f64e992e3a92508f8e91d8a96a4f73483ffe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I3b3a8620b02ae32796d8cfec6b6662541a564b2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Bump upstreams"

This reverts commit 0875001fa5c27015f44bd8afc802d148bc475775, as we need
to issue a release without this bump.

Change-Id: I9652e8dbfd0ff401c7b3c8f3b9a253a60acfa078
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Define PayloadVersion.CHLORINE_SR2

Add the definition of PayloadVersion.CHLORINE_SR2. This is backwards
compatiblein most senses.

JIRA: CONTROLLER-2056
Change-Id: Ia39ccf117ec1a0eb0edf909fbaea903f13c185f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 058765d3385b98d6e6bfc9d5aab1d0a2d6769dd6)

Bump upstreams

Adopt:
- odlparent-11.0.4
- yangtools-9.0.6
- mdsal-10.0.6

Change-Id: Iad6e08c2fbaa66fd4499464e690a392b0e2c1786
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.6-SNAPSHOT

This starts the next development iteration.

Change-Id: If88e64e55a796eb8224ff9f20ac83a5b1c502ca8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools/mdsal

Adopt yangtools-9.0.5 and mdsal-10.0.5.

Change-Id: Ifef09234c94a94647c2dc607ab5624c52f00a0ba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize sal-akka-raft

Use instanceof and switch expressions to improve code flows. Also
shortcut handleRequestVote(), as we can have the instance casted
in AbstractLeader.

Change-Id: Ib726c79fbcc667335a3749f528b3836dc3896e73
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 67d8d3684dda352f957990c80c8e628dabcd0ca6)

Bump versions to 6.0.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I7cefea6119e14ce5e1b07686b3d827f1d834c248
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Define RaftVersions.ARGON_VERSION

Our serialization proxies result in a unnecessarity-big footprint.
Define their replacements for forward compatibility with Argon raft
version.

JIRA: CONTROLLER-2058
Change-Id: I545485c6abdf16f6d81a48672b36eb83613013e1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9a091425d16dadf09a5be4e764785707f5253013)

Use instanceof patterns in Follower

We can reduce casts and improve logic a bit with instanceof patterns.

Change-Id: Ife036c99cba938b79c35fb042f642e96b6a769a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b8de4ba085d8d165a7bb48511dc374ed278fa8bd)

Add sal-akka-raft serialization assertions

We need to be in control of serialized payload size. This patch adds the
assertions on sizes.

Change-Id: Ic73724d0acc51d7d7f28acb392fe569f719762c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0096ccec7c45aa0d22cf56250b06517881ca2300)

Deprecate ABIVersion.{BORON,NEON_SR2,SODIUM_SR1}

These versions are ancient and should not be used. They will be removed
in version 7.0.0.

JIRA: CONTROLLER-2059
Change-Id: I1e4584f0771d3e40eee1fcf9ada6e564a9bb2475
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit edfd0bcb062ade225d26b74d4f289ee98f15a79d)

Assert new request sizes

We now have ABIVersion.CHLORINE_SR2, use it to test serialization
proxy sizes -- showing the improvements to size.

JIRA: CONTROLLER-2051
Change-Id: I8c37201e531c00c5ff9d1322db911dfbcf8fd97b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8cfb2b25798db8916cb5d30e65cdf1bbfd07767c)

Add ABIVersion.CHLORINE_SR2

We have a fresh set of serialization proxies used when we have a version
newer than MAGNESIUM. This patch defines that new version.

JIRA: CONTROLLER-2051
Change-Id: Id91201652afc9dd55d4b44c73bd2d9d3fa3853d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8d4821705d12546cb554c5c2e67f446be81a28eb)

Add new cds-access-api proxies

Externalizable serialization format record class hierarchy, which leads
to significant overheads. This patch introduces proxies which are are
flat, i.e. have java.Object as their superclass, eliminating this
overhead.

The way we do this is we defined SerialForm interfaces which extend
Externalizable and define the serialization protocol in terms of default
methods. We then define a bunch of classes which are pure data holders
implementing individual SerialForms.

Also ensure messages properly implement cloneAsVersion() to propagate
the target version, now that it matters for them.

Finally audit use of java.io.Serial so that we do not import it -- it is
just pure overhead vs. using @java.io.Serial directly.

JIRA: CONTROLLER-2051
Change-Id: I01132665027687edc1c6d44dda8a6ab0cab6ad6a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d92bd0e575983b3d6a09a73089ef8f9c62f94eaa)

Add serialization size assertions for Request{Failure,Success}

We have a bunch of unasserted sizes, make sure we fill them in.

JIRA: CONTROLLER-2051
Change-Id: I7b812d53133425b5ac754652901787b202e16c63
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e085f22bb1934959f9d6f7f4368c1afe964b1e07)

Add missing final keywords

We have a few ommissions here, fix that up.

Change-Id: If633f22e293e7a0ca022d12bed8f39ec68ae05d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3f406c078a3fc91f1ea2199fe32d53e9e1064f4b)

Define efficient serialization proxies

Superclasses have footprint in serialization protocol, as their
descriptors get written out.

Capture Externalizable logic into SerialForm, which implements
Externalizable -- the protocol to be easily implemented without a
superclass. This entails updating the API footprint of AbstractProxy
to reuse its methods.

Then introduce shorthand proxy classes which behave exactly like their
AbstractProxy counterparts, but without the AbstractProxy baggage.

This enables reading implied serialization format, if we encounter it,
providing forward compatibility with the format.

JIRA: CONTROLLER-2056
Change-Id: I4da54ca57849c2bfdaaf76c22e7903abcfa58be9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2dedb8231e13abe55d6b75eb532d23dbe536e168)

Use a switch expression for Payload parsing

We can simplify the switch statement here, making it easier to read.

Change-Id: Ie6e23e7817072b5968f14d17d7063e036563122b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 16b15aea2abdda554ce89da99061e159417596ee)

Use a switch expression for TreeType

Use exhaustiveness of a switch expression to peel an impossible case.

Change-Id: I7d1d228484656fc81b51762878d569698d570f80
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 04502b115693e22d215716feef7b34b6d3c37f6a)

Use an instanceof pattern

We can merge the check and cast here.

Change-Id: I95cb4d5574dab43e4f5f06c9c372fe294c131224
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 034d4e72ffaffc2081a2a6df83ad2ed8a794e2e6)

Assert payload serialized size

We want to be in control over the size of our serialization, make sure
to add assertions.

JIRA: CONTROLLER-2051
JIRA: CONTROLLER-2056
Change-Id: I72957eaf284bfd5498cfdb11301239ac50d612f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit deaa438d6cb6d271bd800bb1879dbdc2360e5392)

Add serialVersionUID fields

We are missing a few definitions and are about to modify the classes
in backwards-compatible ways, but the changes would end up changing
the versions. Make sure to define generated serialVersionUIDs.

JIRA: CONTROLLER-2051
JIRA: CONTROLLER-2056
Change-Id: I006f51e16dd3fee66fb9c344bb99235780b08d3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 0597bd64ca6214fd3ca3fb152ab2ca7fd3b32ed5)

Bump upstrems

Adopt:
- odlparent-11.0.3
- yangtools-9.0.4
- mdsal-10.0.4

Change-Id: I41a097ffc5e4f1aae4f81d5e051faed64856d572
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump verions to 6.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: Icca925e3b86b9e44aa7000ce0844c274857936d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstrems

Adopt:
- odlparent-11.0.2
- yangtools-9.0.2
- mdsal-10.0.3

Change-Id: I221bb0697db1987c2cb3069ec88f492ce7201e5a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch default ABIVersion

Somehow we missed an update of version here. Make sure to use Magnesium.

JIRA: CONTROLLER-2052
Change-Id: I1d45b4fc558c34c0c40faba41f29522772431a24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize AbstractLocalTransactionRequestTest

Use static imports and use assertThrows() and better assertion on the
thrown exception.

Change-Id: I9b11e8a6797b76efa52f1eb3506b630de4a3ae44
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize AbstractRequestTest

Use static imports and improve message assertion.

Change-Id: I97cf242781c25988bf3bcf50f76e9a2dd1b0c8fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize ABIVersionTest

Use assertThrows() instead of expected exception.

Change-Id: Ib2cfc2af5d8da99951d9c8fb6fcedf7eba894b6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

More cds-access-api cleanup

Fixup previous patch and sprinkle more @Serial annotations.

Change-Id: I74414861197bb417dadc445ebc3fc2703a97ea4d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use constructor injection in OSGiClusterAdmin

Remove @Beta and inject services directly into RPC service.

Change-Id: I6d836c84099f17945d0e1e6af8a38e8dbd03f123
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote cds-access-client constructs

These constructs are stable enough, remove @Beta annotation.

Change-Id: I0a63f306fea0fca884fb26ec09560420652c4983
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote AbstractMXBean

This class can be evolved with SemVer, drop @Beta annotation.

Change-Id: Ie34b2b0e557691ea471cf03e23ad927153aadff5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote cds-access-api

This API is no longer @Beta.

Change-Id: If81e77c8b2c9dc2fcfa6bcd94f58426c75f6cd0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote BucketStoreAccess

This is no longer @Beta.

Change-Id: I294085026f7306547230d476951793e09b3d0618
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote cds-dom-api contracts

These are stable enough not to warrant a @Beta annotation.

Change-Id: I2e493febf1a99560047b86ff5aa576c5428ff35d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote DataCenterControl

This is no longer @Beta.

Change-Id: Ic1c2686e8d6c71e27d65a4a8a2ae13979724f2b8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Promote OSGiGlobalEventExecutor

Drop @Beta annotation.

Change-Id: I15e93a4645dd586fe80aab36e6d27495508fda82
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not reference immutable node builders

Use Builders/ImmutableNodes instead of direct implementation reference.
Also use fluent nature of builders, which flushes out a number of unused
constructs, which we remove here.

Change-Id: I8803da6a244f4f4dceaf4da06934b0f8df24b827
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump scala to 2.13.10

https://github.com/scala/scala/releases/tag/v2.13.10

Change-Id: I2c18e38c5f72be43f4bfb71c67049552ad690784
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Scala to 2.13.9

https://github.com/scala/scala/releases/tag/v2.13.9

Change-Id: I2d004d2c3e7d193c803786191c55b53018f63156
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: Ia7fdafe6d534daeef8fb636907367358d135ae24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 10.0.2

Pick up fixes from upstream.

Change-Id: I66e104394b41052d6821da6d3d159fa49f5a0626
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump junit-4-13_2.13

Adopt version 3.2.13.0.

Change-Id: I421dd2ae4be9a560eaeffe6f86d9828ed9c2e7eb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Akka to 2.6.20

https://akka.io/blog/news/2022/09/06/akka-2.6.20-released
https://github.com/real-logic/agrona/releases/tag/1.15.0
https://github.com/real-logic/agrona/releases/tag/1.15.1
https://github.com/real-logic/agrona/releases/tag/1.15.2
https://github.com/real-logic/aeron/releases/tag/1.38.0
https://github.com/real-logic/aeron/releases/tag/1.38.1

JIRA: CONTROLLER-2048
Change-Id: I4d3b2da9bd1a716403bfae5b957c73b05406ba15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump reactive-streams to 1.0.4

https://github.com/reactive-streams/reactive-streams-jvm/blob/master/RELEASE-NOTES.md#version-104-released-on-2022-05-20

Change-Id: I6f9072f4b053f831a4855c2c5c97ad8509d9e8bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I313fd43923f2f8c82aaf8d999846e7c98a1e81d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-11.0.1
- yangtools-9.0.1
- mdsal-10.0.1

Change-Id: I63b6d252955e9397dd9283fd37522046eabf7036
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use FrameworkUtil.asDictionary()

We do not need a Hashtable, use FrameworkUtil to give us what we need.

Change-Id: I50099a7b8f036d7f7f8af467242005e74b48d89d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: If243be33db2568b59ceee22084e1abf19d95dae0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use mdsal-10.0.0

Use released artifacts instead of snapshots.

Change-Id: Ia6f4c28001d19449ee47c62a5754f6966103e4ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use yangtools-9.0.0

We have a release available, use that instead of snapshots.

Change-Id: I845de0908448e1e8dbceda3f5700d090226d0fb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix a documentation reference

We do not use ConstructorProperties, fix the reference.

Change-Id: I3fed8217367ce3948fa561bdf4b00a4e99087c07
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup javadoc build

javadoc-3.4.0 has problems with scala-parser-combinators, as it cannot
derive its module name. Fix this by downgrading javadoc plugin version
for now.

Change-Id: Ica9274e2afc50306c1620e9f32efc5d7371a7c2b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>