controller.git
6 years agoJGroups AUTH handler in Clustering Services 57/1457/1 topic/codeshare/of1.3
Madhu Venugopal [Fri, 27 Sep 2013 12:48:38 +0000 (05:48 -0700)]
JGroups AUTH handler in Clustering Services

It is possible to add Jgroups AUTH as part of the protocol stack below infinispan if the deployment requires
more secured clustered controllers. Failing on such Authentication must be treated critical and the controller
must exit.

Change-Id: Ifa2b5cb2588b82038dcd6fcf7785a48ae2af8bf4
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
6 years agoMerge "Introduce ASYNC caches and use them in FRM"
Alessandro Boch [Fri, 27 Sep 2013 00:47:33 +0000 (00:47 +0000)]
Merge "Introduce ASYNC caches and use them in FRM"

6 years agoMerge "Update devices page"
Alessandro Boch [Fri, 27 Sep 2013 00:46:06 +0000 (00:46 +0000)]
Merge "Update devices page"

6 years agoMerge "Make FRM cleanup only local entries"
Alessandro Boch [Fri, 27 Sep 2013 00:44:29 +0000 (00:44 +0000)]
Merge "Make FRM cleanup only local entries"

6 years agoMerge "In case of an error event, cleanup the config too"
Alessandro Boch [Thu, 26 Sep 2013 21:41:24 +0000 (21:41 +0000)]
Merge "In case of an error event, cleanup the config too"

6 years agoIn case of an error event, cleanup the config too 49/1449/1
Asad Ahmed [Thu, 26 Sep 2013 21:21:55 +0000 (14:21 -0700)]
In case of an error event, cleanup the config too

Change-Id: Id413fbc230e0aa6df5682a8f0f70f0fb4c71243f
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoUpdate devices page 28/1428/2
Andrew Kim [Wed, 25 Sep 2013 18:22:50 +0000 (13:22 -0500)]
Update devices page

- Minor enhancements to device page
- MAC Address in proper format
- Update examples in device page
- Update examples in flows page
- Hide first legend in add flows modal for cleaner look

Change-Id: I12c17804a9900f37a3f2fe610b58dbc7964e1ae0
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoMake FRM cleanup only local entries 45/1445/1
Giovanni Meo [Thu, 26 Sep 2013 15:58:12 +0000 (17:58 +0200)]
Make FRM cleanup only local entries

- FRM when shutting down should only clean local entries and avoid to
trigger remote deletion because that cleanup will also be initiated on
the remote controller
- On shutdown make sure to wake up who may still be sleeping

Change-Id: I15346f73a761c71014c02762e44ccdae8e95edef
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "To SAL conversion test."
Giovanni Meo [Thu, 26 Sep 2013 08:27:30 +0000 (08:27 +0000)]
Merge "To SAL conversion test."

6 years agoPorting Tristate logic to SAL Connection Service and make use of it in Inventory... 31/1431/1
Madhu Venugopal [Thu, 26 Sep 2013 01:01:01 +0000 (18:01 -0700)]
Porting Tristate logic to SAL Connection Service and make use of it in Inventory Service Shim

ConnectionManager's locality status was moved from a binary state to tristate to address timing issues.
With this push, it is ported to the SAL Connection Service so that the protocol-plugins can make use of it as well.

Change-Id: I07a495a8c1d2606f6ae11ccdb73ec3445a438769
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
6 years agoFix wrong dependency 29/1429/1
Giovanni Meo [Wed, 25 Sep 2013 20:42:57 +0000 (22:42 +0200)]
Fix wrong dependency

Change-Id: I98afe96161a785fe5c5aca1114d77bdd804332b4
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "Silent false positive, and enhance real error message"
Madhu Venugopal [Wed, 25 Sep 2013 15:13:18 +0000 (15:13 +0000)]
Merge "Silent false positive, and enhance real error message"

6 years agoMerge "Stop overriding method just to call super."
Giovanni Meo [Wed, 25 Sep 2013 14:37:25 +0000 (14:37 +0000)]
Merge "Stop overriding method just to call super."

6 years agoMerge "Stop creating new Boolean, move to use valueOf method"
Giovanni Meo [Wed, 25 Sep 2013 14:36:16 +0000 (14:36 +0000)]
Merge "Stop creating new Boolean, move to use valueOf method"

6 years agoMerge "Add SCM section to all the poms"
Giovanni Meo [Wed, 25 Sep 2013 14:35:37 +0000 (14:35 +0000)]
Merge "Add SCM section to all the poms"

6 years agoTo SAL conversion test. 24/1424/1
Jozef Gloncak [Wed, 25 Sep 2013 12:44:24 +0000 (14:44 +0200)]
To SAL conversion test.

The test was added

Change-Id: I19988b3e8b4090cef504bc4edff16dc9d5ff7e4c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoDeclare version property for maven bundle plugin, reuse it in poms and 41/1341/3
Alissa Bonas [Mon, 23 Sep 2013 11:58:34 +0000 (14:58 +0300)]
Declare version property for maven bundle plugin, reuse it in poms and
use version 2.3.7 instead of 2.3.6 and 2.4.0 used in parallel.

Change-Id: I3749f69ea38edbcacbe217386ac8accb19837c50
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoStop overriding method just to call super. 17/1417/1
Alissa Bonas [Wed, 25 Sep 2013 12:12:28 +0000 (15:12 +0300)]
Stop overriding method just to call super.

Change-Id: Ia0128d0d324378260b9eedb4c91a6e1b17e8c615
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoAdd SCM section to all the poms 14/1414/1
Giovanni Meo [Wed, 25 Sep 2013 11:52:38 +0000 (13:52 +0200)]
Add SCM section to all the poms

- For the release process we need SCM section to all the poms, some
are still missing it so adding them.

Change-Id: Id401e8502e9fc183e9b15ed5e28b7374ad86d80e
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoStop creating new Boolean, move to use valueOf method 12/1412/1
Alissa Bonas [Wed, 25 Sep 2013 11:24:03 +0000 (14:24 +0300)]
Stop creating new Boolean, move to use valueOf method

Change-Id: Ieecece68265b60a93b638204bae58a043ed3264b
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoMerge "Strong password check to consider underscore as a special character"
Giovanni Meo [Wed, 25 Sep 2013 10:03:18 +0000 (10:03 +0000)]
Merge "Strong password check to consider underscore as a special character"

6 years agoIntroduce ASYNC caches and use them in FRM 10/1410/1
Giovanni Meo [Wed, 25 Sep 2013 07:43:39 +0000 (09:43 +0200)]
Introduce ASYNC caches and use them in FRM

- Add the option in clustering.services contract to allocate caches
that are async
- Use them for FRM workOrder and workStatus
- Add unit tests for sync/async incompatibility

Change-Id: Icfc8d9b8a9277d97b095805cb4323a950c82ef78
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoSilent false positive, and enhance real error message 09/1409/1
Giovanni Meo [Wed, 25 Sep 2013 08:35:03 +0000 (10:35 +0200)]
Silent false positive, and enhance real error message

- With gerrit https://git.opendaylight.org/gerrit/#/c/1366/ i have
introduced a log error, to spot inconsistent hashcode but indeed it
turn out is getting exercised also during a normal code path,
basically when:
 <command orginator> --> <key owner> --> <all the other members>

all the other members when getting the replication from the non-key
owner will end up in this case. So that cannot be actually considered
an error.

Change-Id: Id38b45066164cb4998fdcdbb356bdf7af720b8c5
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoFix: Flows are deleted when another controller is started 06/1406/1
Pramila Singh [Tue, 24 Sep 2013 23:35:45 +0000 (16:35 -0700)]
Fix: Flows are deleted when another controller is started

Change-Id: I9f6c78bb80c4d7f988cc5fd760918f89436f2bf3
Signed-off-by: Pramila Singh <pramisin@cisco.com>
6 years agoStrong password check to consider underscore as a special character 05/1405/1
Alessandro Boch [Tue, 24 Sep 2013 17:03:19 +0000 (10:03 -0700)]
Strong password check to consider underscore as a special character

ISSUE:
Current strong password check regular expression does not consider '_' as a special character

Change-Id: Ib64fe2e94c1e6c76f24d42bd256f3e708f40d1cc
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoMerge "Add to jboss repository snapshot and release properties"
Giovanni Meo [Tue, 24 Sep 2013 14:48:45 +0000 (14:48 +0000)]
Merge "Add to jboss repository snapshot and release properties"

6 years agoMerge "Remove unused class member SAVE"
Giovanni Meo [Tue, 24 Sep 2013 14:35:45 +0000 (14:35 +0000)]
Merge "Remove unused class member SAVE"

6 years agoAdd to jboss repository snapshot and release properties 42/1342/2
Alissa Bonas [Mon, 23 Sep 2013 12:25:05 +0000 (15:25 +0300)]
Add to jboss repository snapshot and release properties

Change-Id: I7e639c369c9e6b16a8e525c51a13e29d50d12f19
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoTimeout ForwardingRulesManager workOrder 65/1365/2
Giovanni Meo [Mon, 23 Sep 2013 20:02:40 +0000 (22:02 +0200)]
Timeout ForwardingRulesManager workOrder

- Before this patch is an FRM request was submitted and no answer was
received by a remote controller, that would indefinitively stuck the
caller, clearly a bad practice. This patch is introducing a default
timeout of 30 second (very bad scenario) and a log.error is being
raised if that happens.
- Cleaned workMonitor cache on workStatus coming back or timeout.
- Make timeout tunable via system properties

Change-Id: I59ac402b30101e3cf1cf1b1beacf03fbc9add6c9
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "Action mapping To|From SAL conversion."
Giovanni Meo [Tue, 24 Sep 2013 13:55:23 +0000 (13:55 +0000)]
Merge "Action mapping To|From SAL conversion."

6 years agoMerge "Added sal-compability to build"
Giovanni Meo [Tue, 24 Sep 2013 13:50:50 +0000 (13:50 +0000)]
Merge "Added sal-compability to build"

6 years agoAction mapping To|From SAL conversion. 49/1349/3
Tony Tkacik [Tue, 24 Sep 2013 09:19:30 +0000 (11:19 +0200)]
Action mapping To|From SAL conversion.

- action was defined in flow-type.yang file according to actions in SAL
- action mapping was added to FromSalConversionsUtils.actionFrom
- action mapping was added to ToSalConversionsUtils.actionFrom

Change-Id: I3bd1c2eba896fb3a305da6ad698db9f0275d6f50
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoAdded sal-compability to build 46/1346/4
Tony Tkacik [Mon, 23 Sep 2013 12:50:12 +0000 (14:50 +0200)]
Added sal-compability to build

Change-Id: I64f8963760a6a6110e000e22c148919eaa841e77
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoAdd project.reporting.outputEncoding property to prevent maven warning 54/1354/2
Alissa Bonas [Mon, 23 Sep 2013 14:25:48 +0000 (17:25 +0300)]
Add project.reporting.outputEncoding property to prevent maven warning

Change-Id: Iaf0153b345a9ff5bade329d37f1377fa1226a99a
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoMerge "Enhance debug capabilities"
Madhu Venugopal [Tue, 24 Sep 2013 13:00:48 +0000 (13:00 +0000)]
Merge "Enhance debug capabilities"

6 years agoRemove unused class member SAVE 94/1394/1
Alissa Bonas [Tue, 24 Sep 2013 11:43:16 +0000 (14:43 +0300)]
Remove unused class member SAVE

Change-Id: If56dcd30aeaa49a400fd5a14b955268b9c7f6105
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoMoved MD SAL from sal/yang-prototype to md-sal 40/1340/2
Tony Tkacik [Mon, 23 Sep 2013 11:54:29 +0000 (13:54 +0200)]
Moved MD SAL from sal/yang-prototype to md-sal

Moved MD SAL sources, artefacts from
 opendaylight/sal/yang-prototype to opendaylight/md-sal

Change-Id: Ic3a6dca94faff8cef0dffe830a767d3ad5f0f21a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
6 years agoEnhance debug capabilities 66/1366/2
Giovanni Meo [Mon, 23 Sep 2013 20:57:03 +0000 (22:57 +0200)]
Enhance debug capabilities

- Make sure infinispan complains very loud when it think an hashcode
is not consistent in the cluster.
- For now this patch is controller specific, but i will propose to
upstream in infinispan as well.
- Given BaseDistributionInterceptor.java came from version 5.3.0.Final
enforce it in the build

Change-Id: I029abac8d311ec3f49795ba325f075541fd3784b
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoFix occasional NPEs in Connection manager 88/1388/1
Yevgeny Khodorkovsky [Mon, 16 Sep 2013 18:02:03 +0000 (11:02 -0700)]
Fix occasional NPEs in Connection manager

- This fixes an issue where ConnectionManager bundle start/stop
  callbacks don't have the required dependenicies available, which
  causes occasional NPEs.

Change-Id: I3f9f17a4a500915cf72419bb352a40233506b846
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoMerge "UI: Fix broken html literals"
Andrew Kim [Tue, 24 Sep 2013 01:12:15 +0000 (01:12 +0000)]
Merge "UI: Fix broken html literals"

6 years agoMerge "Minor log msg changes"
Alessandro Boch [Tue, 24 Sep 2013 00:21:43 +0000 (00:21 +0000)]
Merge "Minor log msg changes"

6 years agoAdded null check in FRM error handling and also formatting of OF ErrorMessage in... 84/1384/1
Asad Ahmed [Mon, 23 Sep 2013 22:59:40 +0000 (15:59 -0700)]
Added null check in FRM error handling and also formatting of OF ErrorMessage in the log statement

Change-Id: I2b32318284e74df51719786762499016831789ef
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoMinor log msg changes 71/1371/1
Jason Ye [Mon, 23 Sep 2013 21:37:02 +0000 (14:37 -0700)]
Minor log msg changes

Change-Id: I289d031ff8157d1c0652d8471d4e5f017188dcf9
Signed-off-by: Jason Ye <yisye@cisco.com>
6 years agoUI: Fix broken html literals 68/1368/2
Yevgeny Khodorkovsky [Mon, 23 Sep 2013 21:17:12 +0000 (14:17 -0700)]
UI: Fix broken html literals

- Fix html literals that don't have correct apostrophes,
  resulting in breakage when user enters strings with spaces

Change-Id: Id2cb05ff4b3b5207602b2c27873f2c4ca9b48dad
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoMerge "Remove unused spring dependency and wrong version in web pom"
Giovanni Meo [Mon, 23 Sep 2013 19:31:20 +0000 (19:31 +0000)]
Merge "Remove unused  spring dependency and wrong version in web pom"

6 years agoRemove unused spring dependency and wrong version in web pom 62/1362/1
Alissa Bonas [Mon, 23 Sep 2013 17:29:43 +0000 (20:29 +0300)]
Remove unused  spring dependency and wrong version in web pom

Change-Id: I1bc3b413b04ed7d706b89a0449b21df00ec18923
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoInitial push of Neutron interface 94/1294/8
Ryan Moats [Fri, 20 Sep 2013 17:51:39 +0000 (12:51 -0500)]
Initial push of Neutron interface

Two bundles included in this:
-networkconfig.neutron (contains JAXB annotated classes, *CRUD
interfaces with an implementation [for storing objects], and
Aware interfaces [for other bundles to register services])
-networkconfig.neutron.northbound (contains the JAXRS annotated
classes along with JAXB annotated request specific classes)

Commit amended to refactor .internal package to separate
implementation bundle and package

Commit re-amended to clean up issues in commons/opendaylight
and distribution/opendaylight poms

Commit re-re-amended to fix conflicts on rebase (I hope)

Getting close to just abandoning the change and starting over

Commit re-re-re-amended to fix parent issues in pom

amend to remove leaked CRs in distribution pom

- Cleanup of some duplicates artifact and of commons-net in modules
dependencies, anyway they get in via the commons.opendaylight

Change-Id: I15724c55e843237c010dfaec1e1e523560174f51
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
6 years agoMove mockito to dependencyManagement section in parent pom. 38/1338/2
Alissa Bonas [Mon, 23 Sep 2013 09:18:11 +0000 (12:18 +0300)]
Move mockito to dependencyManagement section in parent pom.

Change-Id: I6eeb91e1b5713db11b7ffdc9054eb6f316737079
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoMerge "Declare osgi.core.version in one pom and reuse it."
Giovanni Meo [Mon, 23 Sep 2013 13:11:59 +0000 (13:11 +0000)]
Merge "Declare osgi.core.version in one pom and reuse it."

6 years agoMerge "Move init and destroy empty impl from Activator classes. Have only one empty...
Giovanni Meo [Mon, 23 Sep 2013 13:10:49 +0000 (13:10 +0000)]
Merge "Move init and destroy empty impl from Activator classes. Have only one empty implementation in parent class instead of having it in more than 20 classes. Only one class actually has a non empty implementation and it overrides the empty implementation from the parent."

6 years agoDeclare osgi.core.version in one pom and reuse it. 37/1337/2
Alissa Bonas [Mon, 23 Sep 2013 09:13:18 +0000 (12:13 +0300)]
Declare osgi.core.version in one pom and reuse it.

Change-Id: Ice2e727b5228a38208a355cc677f2779e8e69f0a
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoMove init and destroy empty impl from Activator classes. Have only one 27/1327/1
Alissa Bonas [Sun, 22 Sep 2013 19:10:09 +0000 (22:10 +0300)]
Move init and destroy empty impl from Activator classes. Have only one
empty implementation in parent class instead of having it in more than
20 classes. Only one class actually has a non empty implementation and
it overrides the empty implementation from the parent.

Change-Id: Ibbe43ba3e48e4eb80402c158cd45be0afc497fae
Signed-off-by: Alissa Bonas <abonas@redhat.com>
6 years agoMerge "Removing the Container Aware dependency from Clustering Services."
Giovanni Meo [Sun, 22 Sep 2013 13:38:07 +0000 (13:38 +0000)]
Merge "Removing the Container Aware dependency from Clustering Services."

6 years agoMerge "FRM to remove flows on switchport admin down"
Giovanni Meo [Sun, 22 Sep 2013 13:04:33 +0000 (13:04 +0000)]
Merge "FRM to remove flows on switchport admin down"

6 years agoMerge "Conversion class FromSalConversionsUtils."
Giovanni Meo [Sun, 22 Sep 2013 13:01:25 +0000 (13:01 +0000)]
Merge "Conversion class FromSalConversionsUtils."

6 years agoRemoving the Container Aware dependency from Clustering Services. 26/1326/1
Madhu Venugopal [Sun, 22 Sep 2013 08:38:11 +0000 (01:38 -0700)]
Removing the Container Aware dependency from Clustering Services.

Clustering Services implementation is ContainerAware to handle the case of Container deletion.
More appropriate way to handle it is to have an explicit API in global cluster manager to expose
a functionality to clean all the caches assocaited with a Container. This API can be used by
the Container Manager to clean up the caches.

Change-Id: I9758a01da13ffa7d951307a116df34a7fe9c19f6
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
6 years agoFix NPE in visual topology 24/1324/1
Andrew Kim [Sat, 21 Sep 2013 16:35:25 +0000 (11:35 -0500)]
Fix NPE in visual topology

Change-Id: I345b9ed2d1086e370681aa1985c9df8c16902859
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoFRM to remove flows on switchport admin down 16/1316/2
Alessandro Boch [Fri, 20 Sep 2013 16:45:22 +0000 (09:45 -0700)]
FRM to remove flows on switchport admin down

- When a swithport is shutdown FRM should uninstall the flows which have that port as input/output
- Similarly when a port is moved to admin up state, FRM should install the interested flows from the config

Change-Id: I890a4fb6541c9a01b0adacba7af9c0b8c2d69878
Signed-off-by: Alessandro Boch <aboch@cisco.com>
6 years agoChange the member isValid in class MatchField non-transient so that it can be synced... 23/1323/1
Chi-Vien Ly [Sat, 21 Sep 2013 13:26:54 +0000 (06:26 -0700)]
Change the member isValid in class MatchField non-transient so that it can be synced properly.

Change-Id: I036d43b6328d16136a99004ed53d0eb2b70d12c8
Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
6 years agoFRM uses "Start Level Thread" to handle container flow changes during bootup 22/1322/1
Chi-Vien Ly [Sat, 21 Sep 2013 01:47:32 +0000 (18:47 -0700)]
FRM uses "Start Level Thread"  to handle container flow changes during bootup

Modify the current design: when FRM receives the notification, it puts it into its own event queue and returns immediately. The event is eventually handled (in the same way) but through FRM's own thread.

Change-Id: I7d1b3608424f44a0f4129ae08a4c9a836a71e370
Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
6 years agoCouple of changes 21/1321/1
Asad Ahmed [Fri, 20 Sep 2013 23:08:41 +0000 (16:08 -0700)]
Couple of changes

1. StaticRoutingImplementation now updates cache after updating nodeconnector for   \
the static route

2. The clone method of MatchField now clones the valid flag and the type

Change-Id: I7e4e274742a4680f1369eecbeff155bbede3283c
Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
6 years agoCherry-picked and merged modified JavaDocs for northbound apis to fix JSON/XML repres... 19/1319/1
mrajvaid [Fri, 20 Sep 2013 16:38:05 +0000 (09:38 -0700)]
Cherry-picked and merged modified JavaDocs for northbound apis to fix JSON/XML representation

Change-Id: I322b3b77e55c54b54352eb3999ec0fc7a447b2c6
Signed-off-by: mrajvaid <mrajvaid@cisco.com>
6 years agoMerge "Few debug enhancements to debug hashing issues"
Alessandro Boch [Fri, 20 Sep 2013 17:19:47 +0000 (17:19 +0000)]
Merge "Few debug enhancements to debug hashing issues"

6 years agoMerge "Fix: IPProtocols not parsing correctly"
Alessandro Boch [Fri, 20 Sep 2013 17:10:40 +0000 (17:10 +0000)]
Merge "Fix: IPProtocols not parsing correctly"

6 years agoMerge "Fix multi-host caching in visual topology"
Giovanni Meo [Fri, 20 Sep 2013 14:18:28 +0000 (14:18 +0000)]
Merge "Fix multi-host caching in visual topology"

6 years agoReverting the FRM WorkOrder caches to NON_TRANSACTIONAL 15/1315/1
Madhu Venugopal [Fri, 20 Sep 2013 13:56:18 +0000 (06:56 -0700)]
Reverting the FRM WorkOrder caches to NON_TRANSACTIONAL

After Giovanni's recent hashCode fix, most of the cache issue issues are resolved and it also renders itself to making
FRM WorkOrder back NON_TRANSACTIONAL. Also reverted the need to have a seperate thread to handle this processing.
Now it is back to normal and how it is supposed to be.

Change-Id: I0abbe66ea0ec7203ef306bc73d848112110f6460
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
6 years agoConversion class FromSalConversionsUtils. 10/1310/1
Jozef Gloncak [Fri, 20 Sep 2013 07:35:31 +0000 (09:35 +0200)]
Conversion class FromSalConversionsUtils.

SAL -> YANG conversion

Change-Id: I8e5166cdbe94edab84741ea7a7293262d79830cb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoFix: IPProtocols not parsing correctly 04/1304/3
Yevgeny Khodorkovsky [Fri, 20 Sep 2013 04:07:05 +0000 (21:07 -0700)]
Fix: IPProtocols not parsing correctly

- Add IP protocol field validation where appropriate
- Enabled all IP protocols in enum
- Added unit tests

Change-Id: I2ae26ad1c3b56129817f41e0a93d27f5b031b790
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoMerge "In Firefox DropDown sub menus will have the first option selected"
Andrew Kim [Fri, 20 Sep 2013 05:46:46 +0000 (05:46 +0000)]
Merge "In Firefox DropDown sub menus will have the first option selected"

6 years agoIn Firefox DropDown sub menus will have the first option selected 06/1306/1
Sapan Shah [Fri, 20 Sep 2013 05:32:16 +0000 (22:32 -0700)]
In Firefox DropDown sub menus will have the first option selected

Change-Id: Ib7ea1fbfc0cbe3c8921116ffc7f79ac7b9d9f654
Signed-off-by: Sapan Shah <sapshah@cisco.com>
6 years agoFix for Refresh Port Details and Flow Details in Troubleshoot makes search hard 05/1305/1
lakshya [Fri, 20 Sep 2013 04:55:05 +0000 (21:55 -0700)]
Fix for Refresh Port Details and Flow Details in Troubleshoot makes search hard
Replace the auto refresh with a refresh button.

Change-Id: If231b7ee722c436d792000646b743028469f6f03
Signed-off-by: lakshya <lakshya@cisco.com>
6 years agoFix multi-host caching in visual topology 03/1303/1
Andrew Kim [Fri, 20 Sep 2013 02:43:10 +0000 (21:43 -0500)]
Fix multi-host caching in visual topology

Change-Id: I68cd3de135d8422b3994387f43bc0df67c612f3f
Signed-off-by: Andrew Kim <andrekim@cisco.com>
6 years agoController User Audit log to track activities 79/1279/3
Sapan Shah [Wed, 18 Sep 2013 21:26:58 +0000 (14:26 -0700)]
Controller User Audit log to track activities

Change-Id: I78760a5bcea3de9fcea4a0edd46eb7ea44765db0
Signed-off-by: Sapan Shah <sapshah@cisco.com>
6 years agoFew debug enhancements to debug hashing issues 97/1297/2
Giovanni Meo [Thu, 19 Sep 2013 15:58:01 +0000 (17:58 +0200)]
Few debug enhancements to debug hashing issues

Change-Id: I4a173c0a423d740ef75249f777aa35e5d2772d9c
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "Provide consistent hash code for enums and use it too"
Madhu Venugopal [Thu, 19 Sep 2013 15:46:14 +0000 (15:46 +0000)]
Merge "Provide consistent hash code for enums and use it too"

6 years agoMerge "Validate user input in FlowSepc Configuration"
Giovanni Meo [Thu, 19 Sep 2013 15:36:49 +0000 (15:36 +0000)]
Merge "Validate user input in FlowSepc Configuration"

6 years agoMerge "Sal Models for meter table. Removed tab space from group models and formatted...
Giovanni Meo [Thu, 19 Sep 2013 15:23:23 +0000 (15:23 +0000)]
Merge "Sal Models for meter table. Removed tab space from group models and formatted the same."

6 years agoMerge "Aligning JSON marshalled output for Properties similar to the XML counterpart."
Giovanni Meo [Thu, 19 Sep 2013 15:22:22 +0000 (15:22 +0000)]
Merge "Aligning JSON marshalled output for Properties similar to the XML counterpart."

6 years agoMerge "Added validation for protocol field while adding flow"
Giovanni Meo [Thu, 19 Sep 2013 15:21:04 +0000 (15:21 +0000)]
Merge "Added validation for protocol field while adding flow"

6 years agoProvide consistent hash code for enums and use it too 92/1292/2
Giovanni Meo [Thu, 19 Sep 2013 09:33:45 +0000 (11:33 +0200)]
Provide consistent hash code for enums and use it too

- Java enums if used as key, works well in a single JVM, but across
JVM the hashcode generated by them is not guaranteed to be the same
and that breaks the calculation of a cluster wide consistent hash
code, needed by the clustering services. The fix is to provide a
consistent hashcode for the Enum and to use it in the dependent data
structures.

Change-Id: Iee80f262253a287e8bc8be4d5371d0bd407f0462
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
6 years agoMerge "UI: Allow admin to reset password for other users"
Giovanni Meo [Thu, 19 Sep 2013 14:19:39 +0000 (14:19 +0000)]
Merge "UI: Allow admin to reset password for other users"

6 years agoMerge "Simple changes to eliminate pmd warnings"
Giovanni Meo [Thu, 19 Sep 2013 08:58:20 +0000 (08:58 +0000)]
Merge "Simple changes to eliminate pmd warnings"

6 years agoMerge "Add strong password check for users"
Giovanni Meo [Thu, 19 Sep 2013 08:24:02 +0000 (08:24 +0000)]
Merge "Add strong password check for users"

6 years agoMerge "Prepare the TopologyManager code for integration testing. Need to have the...
Giovanni Meo [Thu, 19 Sep 2013 08:12:44 +0000 (08:12 +0000)]
Merge "Prepare the TopologyManager code for integration testing. Need to have the code in a structure where topologymanager is the top level directory and has sub directories - api - implementation - integrationtest"

6 years agoValidate user input in FlowSepc Configuration 78/1278/3
Maurice Qureshi [Wed, 18 Sep 2013 21:15:44 +0000 (14:15 -0700)]
Validate user input in FlowSepc Configuration

Existing flow spec validation was missing range check for IP Protocol and Protocol
source and destination ports. Also, port number were not being checked for invalid
input

Change-Id: I11a5c6b90c4d5193f4e1950df684363e22b0e33a
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
6 years agoAligning JSON marshalled output for Properties similar to the XML counterpart. 83/1283/1
Madhu Venugopal [Thu, 19 Sep 2013 05:06:45 +0000 (22:06 -0700)]
Aligning JSON marshalled output for Properties similar to the XML counterpart.

After the Jackson migration (https://git.opendaylight.org/gerrit/#/c/1131), the marshalled JSON output
got misaligned from its XML counterpart. This is because of the "special" handling of XmlElementRef by
Jettison.
Please refer to http://pastebin.com/6kCSuddg for various marshalled JSON output for Jettison, Jackson and Moxy.

Having tried & exhausted various mechanisms (using Jackson and Moxy), finally decided to use the Jackson
annotations to take care of this requirement. Changes involves :

1. Modified NodeConnectProperties, EdgProperties and NodeProperties to use @JsonIgnore and @JsonProperty
2. Reverted a few NorthboundIT changes as prior to the gerrit#1131 version to align to the JSON format.
3. Added @XmlAccessorType(XmlAccessType.NONE) in all the Property classes to avoid including unnecessary data.

Change-Id: I574956328fa841b2165e0c10ddec995c70b76e4d
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
6 years agoSal Models for meter table. 82/1282/2
Prasanna Huddar [Thu, 19 Sep 2013 04:27:59 +0000 (21:27 -0700)]
Sal Models for meter table.
Removed tab space from group models and formatted the same.

Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com>
Change-Id: I2415ac716c344ae308907f708da3d1f3b5559093

6 years agoAdded validation for protocol field while adding flow 81/1281/1
Diti Bhatia [Thu, 19 Sep 2013 02:06:08 +0000 (19:06 -0700)]
Added validation for protocol field while adding flow

Signed-off-by: Diti Bhatia <dibhatia@cisco.com>
Change-Id: Iac1a49ce0b3fa576ba07ea48b2afe978d6ced661

6 years agoUI: Allow admin to reset password for other users 80/1280/2
Yevgeny Khodorkovsky [Wed, 18 Sep 2013 20:11:00 +0000 (13:11 -0700)]
UI: Allow admin to reset password for other users

- Allow admin to reset password for other users
  without providing current password.
- enforce re-login if changed own password

Change-Id: I4553739315fe7a93328e54cf4d345e79011246bc
Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
6 years agoSwitched odl-model-project archetype to use yangtools 0.5.8-SNAPSHOT 76/1276/1
Ed Warnicke [Wed, 18 Sep 2013 19:39:11 +0000 (14:39 -0500)]
Switched odl-model-project archetype to use yangtools 0.5.8-SNAPSHOT

Change-Id: I404759c5863d5e7dde6d7a2a139177bbf1bcf8d7
Signed-off-by: Ed Warnicke <eaw@cisco.com>
6 years agoMerge "Remove maven repo2 from poms because no need for 2 maven repos, especially...
Giovanni Meo [Wed, 18 Sep 2013 18:05:52 +0000 (18:05 +0000)]
Merge "Remove maven repo2 from poms because no need for 2 maven repos, especially since only repo1 is the official supported one."

6 years agoMerge "Fix "FileNotFound" error for jacoco.exec and the path to the integration tests."
Giovanni Meo [Wed, 18 Sep 2013 18:04:59 +0000 (18:04 +0000)]
Merge "Fix "FileNotFound" error for jacoco.exec and the path to the integration tests."

6 years agoMerge "Conversion class ToSalConversionsUtils."
Ed Warnicke [Wed, 18 Sep 2013 15:38:28 +0000 (15:38 +0000)]
Merge "Conversion class ToSalConversionsUtils."

6 years agoMerge "Configure jackson to turn off FAIL_ON_UNKNOWN_PROPERTIES. This ensures that...
Madhu Venugopal [Wed, 18 Sep 2013 15:37:38 +0000 (15:37 +0000)]
Merge "Configure jackson to turn off FAIL_ON_UNKNOWN_PROPERTIES. This ensures that Jackson is more lenient when it sees extra attributes in the request payload. Add custom exception mapper for handling jackson json exceptions during deserialization"

6 years agoMerge "Adding Tri-states to the connection manager locality check."
Giovanni Meo [Wed, 18 Sep 2013 15:37:28 +0000 (15:37 +0000)]
Merge "Adding Tri-states to the connection manager locality check."

6 years agoMerge "Added Router code generation and unit tests for runtime code generator"
Ed Warnicke [Wed, 18 Sep 2013 15:36:19 +0000 (15:36 +0000)]
Merge "Added Router code generation and unit tests for runtime code generator"

6 years agoMerge "MD-SAL model for group feature in OF 1.3."
Ed Warnicke [Wed, 18 Sep 2013 14:52:53 +0000 (14:52 +0000)]
Merge "MD-SAL model for group feature in OF 1.3."

6 years agoConversion class ToSalConversionsUtils. 67/1267/1
Jozef Gloncak [Wed, 18 Sep 2013 14:10:57 +0000 (16:10 +0200)]
Conversion class ToSalConversionsUtils.

YANG -> SAL conversion

Change-Id: If502dabcb00bba0f189ec0d1b4ce714ef55426aa
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
6 years agoAdding Tri-states to the connection manager locality check. 65/1265/1
Madhu Venugopal [Wed, 18 Sep 2013 13:04:10 +0000 (06:04 -0700)]
Adding Tri-states to the connection manager locality check.

As of now, the connection manager's isLocal() provides a binary true/false for a locality.
But is missing a key state of not-connected. This is now included as part of a new API (getLocalityStatus).
Retaining the isLocal as a deprecated method to be removed later once all the users have migrated.

Change-Id: I0feddf2a86770740f441060bd411f28d1bb15610
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
6 years agoMerge "In o.o.c.switchmanager.SpanConfig, handle node connector string format correctly."
Giovanni Meo [Wed, 18 Sep 2013 10:27:47 +0000 (10:27 +0000)]
Merge "In o.o.c.switchmanager.SpanConfig, handle node connector string format correctly."

©2013 OpenDaylight, A Linux Foundation Collaborative Project. All Rights Reserved.
OpenDaylight is a registered trademark of The OpenDaylight Project, Inc.
Linux Foundation and OpenDaylight are registered trademarks of the Linux Foundation.
Linux is a registered trademark of Linus Torvalds.