From ab2a9352f4c07aeede61f9c071264b8a35586717 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Mon, 3 Apr 2023 16:25:33 +0200 Subject: [PATCH] Annotate AbstractRaftRPC with java.io.Serial We have constructs which are related to serialization, annotate them. Change-Id: I8e5d95adaaa25eee35dc2bba349925eb982af207 Signed-off-by: Robert Varga --- .../controller/cluster/raft/messages/AbstractRaftRPC.java | 2 ++ .../controller/cluster/raft/messages/AppendEntries.java | 1 + .../controller/cluster/raft/messages/AppendEntriesReply.java | 1 + .../controller/cluster/raft/messages/InstallSnapshot.java | 1 + .../controller/cluster/raft/messages/InstallSnapshotReply.java | 1 + .../controller/cluster/raft/messages/RequestVote.java | 1 + .../controller/cluster/raft/messages/RequestVoteReply.java | 1 + 7 files changed, 8 insertions(+) diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AbstractRaftRPC.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AbstractRaftRPC.java index 76edc54990..038ad48b8e 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AbstractRaftRPC.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AbstractRaftRPC.java @@ -8,6 +8,7 @@ package org.opendaylight.controller.cluster.raft.messages; public abstract class AbstractRaftRPC implements RaftRPC { + @java.io.Serial private static final long serialVersionUID = -6061342433962854822L; // term @@ -23,5 +24,6 @@ public abstract class AbstractRaftRPC implements RaftRPC { } // All implementations must use Externalizable Proxy pattern + @java.io.Serial abstract Object writeReplace(); } diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntries.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntries.java index 5ca5d3a5e2..5572b01d30 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntries.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntries.java @@ -27,6 +27,7 @@ import org.opendaylight.controller.cluster.raft.persisted.SimpleReplicatedLogEnt * Invoked by leader to replicate log entries (§5.3); also used as heartbeat (§5.2). */ public final class AppendEntries extends AbstractRaftRPC { + @java.io.Serial private static final long serialVersionUID = 1L; // So that follower can redirect clients diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java index 80bcb70d9a..7cfe8b1c6d 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/AppendEntriesReply.java @@ -18,6 +18,7 @@ import org.opendaylight.controller.cluster.raft.RaftVersions; * Reply for the AppendEntries message. */ public final class AppendEntriesReply extends AbstractRaftRPC { + @java.io.Serial private static final long serialVersionUID = -7487547356392536683L; // true if follower contained entry matching diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshot.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshot.java index e3e587f791..4d78aa7a86 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshot.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshot.java @@ -22,6 +22,7 @@ import org.opendaylight.controller.cluster.raft.persisted.ServerConfigurationPay * Message sent from a leader to install a snapshot chunk on a follower. */ public final class InstallSnapshot extends AbstractRaftRPC { + @java.io.Serial private static final long serialVersionUID = 1L; private final String leaderId; diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java index 1579ba2ee4..978ae8006d 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java @@ -13,6 +13,7 @@ import java.io.ObjectInput; import java.io.ObjectOutput; public final class InstallSnapshotReply extends AbstractRaftRPC { + @java.io.Serial private static final long serialVersionUID = 642227896390779503L; // The followerId - this will be used to figure out which follower is diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVote.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVote.java index f9a984feae..2ac4d7e355 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVote.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVote.java @@ -16,6 +16,7 @@ import java.io.ObjectOutput; * Invoked by candidates to gather votes (§5.2). */ public final class RequestVote extends AbstractRaftRPC { + @java.io.Serial private static final long serialVersionUID = -6967509186297108657L; // candidate requesting vote diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVoteReply.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVoteReply.java index 9a194223ce..8aa74e7037 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVoteReply.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/RequestVoteReply.java @@ -13,6 +13,7 @@ import java.io.ObjectInput; import java.io.ObjectOutput; public final class RequestVoteReply extends AbstractRaftRPC { + @java.io.Serial private static final long serialVersionUID = 8427899326488775660L; // true means candidate received vote -- 2.36.6