From a81d98f692b80c45bce3fe6a87e731abfb012a9f Mon Sep 17 00:00:00 2001
From: Robert Varga
* It aligns the last numBits bits to the head of the byte array following
* them with numBits % 8 zero bits.
*
* Example: For inputbytes = [00000111][01110001] and numBits = 12 it
* returns: shiftedBytes = [01110111][00010000]
*
- * @param byte[] inputBytes
- * @param int numBits - number of bits to be left aligned
+ * @param numBits - number of bits to be left aligned
* @return byte[]
*/
public static byte[] shiftBitsToMSB(byte[] inputBytes, int numBits) {
@@ -571,8 +537,8 @@ public abstract class BitBufferHelper {
* Example: For inputbytes = [01110111][00010000] and numBits = 12 it
* returns: shiftedBytes = [00000111][01110001]
*
- * @param byte[] inputBytes
- * @param int numBits - number of bits to be right aligned
+ * @param inputBytes
+ * @param numBits - number of bits to be right aligned
* @return byte[]
*/
public static byte[] shiftBitsToLSB(byte[] inputBytes, int numBits) {
@@ -604,11 +570,6 @@ public abstract class BitBufferHelper {
* Insert in the data buffer at position dictated by the offset the number
* of bits specified from the input data byte array. The input byte array
* has the bits stored starting from the LSB
- *
- * @param byte[] data
- * @param byte[] inputdata
- * @param int startOffset
- * @param int numBits
*/
public static void insertBits(byte[] data, byte[] inputdataLSB,
int startOffset, int numBits) {
@@ -690,10 +651,7 @@ public abstract class BitBufferHelper {
/**
* Checks for overflow and underflow exceptions
- * @param data
- * @param startOffset
- * @param numBits
- * @throws PacketException when the startOffset and numBits parameters
+ * @throws BufferException when the startOffset and numBits parameters
* are not congruent with the data buffer's size
*/
public static void checkExceptions(byte[] data, int startOffset, int numBits)
diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/DataLinkAddress.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/DataLinkAddress.java
index de9f4ec820..2649489569 100644
--- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/DataLinkAddress.java
+++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/DataLinkAddress.java
@@ -37,8 +37,6 @@ abstract public class DataLinkAddress implements Serializable {
*
* @param name Create a new DataLink, not for general use but
* available only for sub classes
- *
- * @return constructed object
*/
protected DataLinkAddress(String name) {
this.name = name;
diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java
index c2d9e7003e..424bdd016a 100644
--- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java
+++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Ethernet.java
@@ -104,7 +104,7 @@ public class Ethernet extends Packet {
/**
* Sets the destination MAC address for the current Ethernet object instance
- * @param byte[] - the destinationMACAddress to set
+ * @param destinationMACAddress the destinationMACAddress to set
*/
public Ethernet setDestinationMACAddress(byte[] destinationMACAddress) {
fieldValues.put(DMAC, destinationMACAddress);
@@ -113,7 +113,7 @@ public class Ethernet extends Packet {
/**
* Sets the source MAC address for the current Ethernet object instance
- * @param byte[] - the sourceMACAddress to set
+ * @param sourceMACAddress the sourceMACAddress to set
*/
public Ethernet setSourceMACAddress(byte[] sourceMACAddress) {
fieldValues.put(SMAC, sourceMACAddress);
@@ -122,7 +122,7 @@ public class Ethernet extends Packet {
/**
* Sets the etherType for the current Ethernet object instance
- * @param short - the etherType to set
+ * @param etherType the etherType to set
*/
public Ethernet setEtherType(short etherType) {
byte[] ethType = BitBufferHelper.toByteArray(etherType);
diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/EthernetAddress.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/EthernetAddress.java
index a3f8d5075d..947603c45b 100644
--- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/EthernetAddress.java
+++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/EthernetAddress.java
@@ -52,8 +52,6 @@ public class EthernetAddress extends DataLinkAddress {
*
* @param macAddress A byte array in big endian format
* representing the Ethernet MAC Address
- *
- * @return The constructed object if valid
*/
public EthernetAddress(byte[] macAddress) throws ConstructionException {
super(addressName);
diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java
index 15dced5f11..bbee8599b6 100644
--- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java
+++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDP.java
@@ -90,7 +90,7 @@ public class LLDP extends Packet {
}
/**
- * @param String
+ * @param type
* - description of the type of TLV
* @return LLDPTLV - full TLV
*/
@@ -103,11 +103,10 @@ public class LLDP extends Packet {
}
/**
- * @param String
+ * @param type
* - description of the type of TLV
- * @param LLDPTLV
+ * @param tlv
* - tlv to set
- * @return void
*/
public void setTLV(String type, LLDPTLV tlv) {
putToTLVs(getType(type), tlv);
@@ -121,7 +120,7 @@ public class LLDP extends Packet {
}
/**
- * @param LLDPTLV
+ * @param chassisId
* - the chassisId to set
*/
public LLDP setChassisId(LLDPTLV chassisId) {
@@ -137,8 +136,8 @@ public class LLDP extends Packet {
}
/**
- * @param LLDPTLV
- * - the chassisId to set
+ * @param systemNameId
+ * - the systemNameId to set
*/
public LLDP setSystemNameId(LLDPTLV systemNameId) {
setTLV(SYSTEMNAMEID, systemNameId);
@@ -153,7 +152,7 @@ public class LLDP extends Packet {
}
/**
- * @param LLDPTLV
+ * @param portId
* - the portId to set
* @return LLDP
*/
@@ -170,7 +169,7 @@ public class LLDP extends Packet {
}
/**
- * @param LLDPTLV
+ * @param ttl
* - the ttl to set
* @return LLDP
*/
@@ -206,7 +205,7 @@ public class LLDP extends Packet {
}
/**
- * @param customTLVList
+ * @param customTLV
* the list of custom TLVs to set
* @return this LLDP
*/
diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDPTLV.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDPTLV.java
index 3c5623475e..bc241928fb 100644
--- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDPTLV.java
+++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/LLDPTLV.java
@@ -121,7 +121,7 @@ public class LLDPTLV extends Packet {
}
/**
- * @param byte - the type to set
+ * @param type the type to set
* @return LLDPTLV
*/
public LLDPTLV setType(byte type) {
@@ -131,7 +131,7 @@ public class LLDPTLV extends Packet {
}
/**
- * @param short - the length to set
+ * @param length the length to set
* @return LLDPTLV
*/
public LLDPTLV setLength(short length) {
@@ -140,7 +140,7 @@ public class LLDPTLV extends Packet {
}
/**
- * @param byte[] - the value to set
+ * @param value the value to set
* @return LLDPTLV
*/
public LLDPTLV setValue(byte[] value) {
@@ -266,10 +266,10 @@ public class LLDPTLV extends Packet {
/**
* Creates the custom TLV value including OUI, subtype and custom string
*
- * @param portId
+ * @param customString
* port identifier string
* @return the custom TLV value in byte array
- * @see {@link #createCustomTLVValue(byte,String)}
+ * @see #createCustomTLVValue(byte[],byte[])
*/
static public byte[] createCustomTLVValue(String customString) {
byte[] customByteArray = customString.getBytes(Charset.defaultCharset());
@@ -279,7 +279,7 @@ public class LLDPTLV extends Packet {
/**
* Creates the custom TLV value including OUI, subtype and custom string
* @param subtype openflow subtype
- * @param portId
+ * @param customByteArray
* port identifier string
* @return the custom TLV value in byte array
*/
diff --git a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Packet.java b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Packet.java
index 59a786339d..8a4fa36970 100644
--- a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Packet.java
+++ b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/Packet.java
@@ -76,10 +76,10 @@ public abstract class Packet {
* This method deserializes the data bits obtained from the wire into the
* respective header and payload which are of type Packet
*
- * @param byte[] data - data from wire to deserialize
- * @param int bitOffset bit position where packet header starts in data
+ * @param data - data from wire to deserialize
+ * @param bitOffset bit position where packet header starts in data
* array
- * @param int size of packet in bits
+ * @param size size of packet in bits
* @return Packet
* @throws PacketException
*/
@@ -205,7 +205,7 @@ public abstract class Packet {
* normal Packet.serialize() path. An example is the checksum computation
* for IPv4
*
- * @param byte[] - serialized bytes
+ * @param myBytes serialized bytes
* @throws PacketException
*/
protected void postSerializeCustomOperation(byte[] myBytes)
@@ -220,8 +220,8 @@ public abstract class Packet {
* Currently only IPv4 and ICMP do checksum computation and validation. TCP
* and UDP need to implement these if required.
*
- * @param byte[] data The byte stream representing the Ethernet frame
- * @param int startBitOffset The bit offset from where the byte array corresponding to this Packet starts in the frame
+ * @param data The byte stream representing the Ethernet frame
+ * @param startBitOffset The bit offset from where the byte array corresponding to this Packet starts in the frame
* @throws PacketException
*/
protected void postDeserializeCustomOperation(byte[] data, int startBitOffset)
@@ -255,8 +255,6 @@ public abstract class Packet {
* 'fieldname'. The offset is present in the hdrFieldCoordMap of the
* respective packet class
*
- * @param String
- * fieldName
* @return Integer - startOffset of the requested field
*/
public int getfieldOffset(String fieldName) {
@@ -268,8 +266,6 @@ public abstract class Packet {
* 'fieldname'. The numBits are present in the hdrFieldCoordMap of the
* respective packet class
*
- * @param String
- * fieldName
* @return Integer - number of bits of the requested field
*/
public int getfieldnumBits(String fieldName) {
diff --git a/opendaylight/commons/protocol-framework/pom.xml b/opendaylight/commons/protocol-framework/pom.xml
index b97be83fe6..e6029f77d0 100644
--- a/opendaylight/commons/protocol-framework/pom.xml
+++ b/opendaylight/commons/protocol-framework/pom.xml
@@ -114,27 +114,6 @@
-
* Example:
* TODO extract generic interface for config subsystem facades
*/
public class ConfigSubsystemFacade implements Closeable {
diff --git a/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/attributes/fromxml/ArrayAttributeReadingStrategy.java b/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/attributes/fromxml/ArrayAttributeReadingStrategy.java
index f80494fcb2..5f169de9fb 100644
--- a/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/attributes/fromxml/ArrayAttributeReadingStrategy.java
+++ b/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/attributes/fromxml/ArrayAttributeReadingStrategy.java
@@ -18,10 +18,6 @@ public class ArrayAttributeReadingStrategy extends AbstractAttributeReadingStrat
private final AttributeReadingStrategy innerStrategy;
- /**
- * @param attributeIfc
- * @param innerStrategy
- */
public ArrayAttributeReadingStrategy(String nullableDefault, AttributeReadingStrategy innerStrategy) {
super(nullableDefault);
this.innerStrategy = innerStrategy;
diff --git a/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/config/Config.java b/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/config/Config.java
index 30726db82e..10602ce7e5 100644
--- a/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/config/Config.java
+++ b/opendaylight/config/config-manager-facade-xml/src/main/java/org/opendaylight/controller/config/facade/xml/mapping/config/Config.java
@@ -160,7 +160,7 @@ public class Config {
}
/**
- * return a map containing namespace -> moduleName -> instanceName map. Attribute parsing is omitted.
+ * return a map containing namespace -> moduleName -> instanceName map. Attribute parsing is omitted.
*/
public Map
* The Role Change listener receives a SetNotifiers message with the notifiers to register itself with.
- *
* It kicks of a scheduler which sents registration messages to the notifiers, till it gets a RegisterRoleChangeListenerReply
- *
* If all the notifiers have been regsitered with, then it cancels the scheduler.
* It starts the scheduler again when it receives a new registration
*
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ConfigParams.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ConfigParams.java
index 652771b4f1..0e701e3aa5 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ConfigParams.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ConfigParams.java
@@ -13,10 +13,12 @@ import scala.concurrent.duration.FiniteDuration;
/**
* Configuration Parameter interface for configuring the Raft consensus system
- *
* Any component using this implementation might want to provide an implementation of
* this interface to configure
- *
* A default implementation will be used if none is provided.
*
* @author Kamal Rameshan
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/DefaultConfigParamsImpl.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/DefaultConfigParamsImpl.java
index 2d2f95bd76..317ce6a220 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/DefaultConfigParamsImpl.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/DefaultConfigParamsImpl.java
@@ -41,7 +41,8 @@ public class DefaultConfigParamsImpl implements ConfigParams {
/**
* The interval at which a heart beat message will be sent to the remote
* RaftActor.
- *
* Since this is set to 100 milliseconds the Election timeout should be
* at least 200 milliseconds
*/
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ElectionTerm.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ElectionTerm.java
index e8c9b458c6..264f7a5d63 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ElectionTerm.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ElectionTerm.java
@@ -12,10 +12,12 @@ import javax.annotation.Nullable;
/**
* ElectionTerm contains information about a RaftActors election term.
- *
* This information includes the last known current term of the RaftActor
* and which candidate was voted for by the RaftActor in that term.
- *
* This class ensures that election term information is persisted.
*/
public interface ElectionTerm {
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java
index 8d29614105..e3fa649ab1 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/RaftActor.java
@@ -59,7 +59,8 @@ import org.opendaylight.yangtools.concepts.Immutable;
* in a cluster. It implements the RAFT algorithm as described in the paper
*
* In Search of an Understandable Consensus Algorithm
- *
* RaftActor has 3 states and each state has a certain behavior associated
* with it. A Raft actor can behave as,
*
* A RaftActor MUST be a Leader in order to accept requests from clients to
* change the state of it's encapsulated state machine. Once a RaftActor becomes
* a Leader it is also responsible for ensuring that all followers ultimately
* have the same log and therefore the same state machine as itself.
- *
* The current behavior of a RaftActor determines how election for leadership
* is initiated and how peer RaftActors react to request for votes.
- *
* Each RaftActor also needs to know the current election term. It uses this
* information for a couple of things. One is to simply figure out who it
* voted for in the last election. Another is to figure out if the message
* it received to update it's state is stale.
- *
* The RaftActor uses akka-persistence to store it's replicated log.
* Furthermore through it's behaviors a Raft Actor determines
- *
* The transfer process is as follows:
*
* NOTE: All methods on this class must be called on the actor's thread dispatcher as they may access/modify
* internal state.
*
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLog.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLog.java
index 73ab6ea66c..cd70812d9d 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLog.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/ReplicatedLog.java
@@ -61,7 +61,8 @@ public interface ReplicatedLog {
/**
* Removes entries from the in-memory log and the persisted log starting at the given index.
- *
* The persisted information would then be used during recovery to properly
* reconstruct the state of the in-memory replicated log
*
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java
index fab1714989..31bf99c2dc 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/AbstractLeader.java
@@ -50,7 +50,8 @@ import scala.concurrent.duration.FiniteDuration;
/**
* The behavior of a RaftActor when it is in the Leader state
- *
* Leaders:
*
* Install Snapshot works as follows
* 1. Leader initiates the capture snapshot by calling createSnapshot on the RaftActor.
* 2. On receipt of the CaptureSnapshotReply message, the RaftActor persists the snapshot and makes a call to
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Candidate.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Candidate.java
index b86d28b5f7..ac7dbaba27 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Candidate.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Candidate.java
@@ -24,7 +24,8 @@ import org.opendaylight.controller.cluster.raft.messages.RequestVoteReply;
/**
* The behavior of a RaftActor when it is in the Candidate raft state.
- *
* Candidates (§5.2):
*
* If the reply from the majority of the followers is not received then the leader changes its behavior
* to IsolatedLeader. An isolated leader may have followers and they would continue to receive replicated messages.
- *
* A schedule is run, at an interval of (10 * Heartbeat-time-interval), in the Leader
* to check if its isolated or not.
- *
* In the Isolated Leader , on every AppendEntriesReply, we aggressively check if the leader is isolated.
* If no, then the state is switched back to Leader.
- *
*/
public class IsolatedLeader extends AbstractLeader {
IsolatedLeader(RaftActorContext context, @Nullable AbstractLeader initializeFromLeader) {
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
index 4821d98835..f5f3f51819 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/Leader.java
@@ -24,7 +24,8 @@ import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply;
/**
* The behavior of a RaftActor when it is in the Leader state.
- *
* Leaders:
*
* The use of a no-op entry in this manner is outlined in the last paragraph in §8 of the
* extended raft version.
*
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeader.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeader.java
index 8f23a89b8b..945ace7410 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeader.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeader.java
@@ -15,7 +15,8 @@ import java.io.Serializable;
* Request to locate the leader raft actor. Each {@link org.opendaylight.controller.cluster.raft.RaftActor} must
* respond with a {@link FindLeaderReply} containing the address of the leader, as it is known to that particular
* actor.
- *
* This message is intended for testing purposes only.
*/
@VisibleForTesting
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeaderReply.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeaderReply.java
index 5fbeb92fbd..90cec9db6c 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeaderReply.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/client/messages/FindLeaderReply.java
@@ -17,7 +17,8 @@ import javax.annotation.Nullable;
* Reply to {@link FindLeader} message, containing the address of the leader actor, as known to the raft actor which
* sent the message. If the responding actor does not have knowledge of the leader, {@link #getLeaderActor()} will
* return {@link Optional#empty()}.
- *
* This message is intended for testing purposes only.
*/
@VisibleForTesting
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/policy/RaftPolicy.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/policy/RaftPolicy.java
index c535c2299d..183e3400e6 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/policy/RaftPolicy.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/policy/RaftPolicy.java
@@ -13,12 +13,12 @@ package org.opendaylight.controller.cluster.raft.policy;
* we may want to be able to determine which Raft replica should become the leader - with Raft elections are
* randomized so it is not possible to specify which replica should be the leader. The ability to specify
* the leader would be quite useful when testing a raft cluster.
- *
* Similarly we may want to customize when exactly we apply a modification to the state - with Raft a modification
* is only applied to the state when the modification is replicated to a majority of the replicas. The ability to
* apply a modification to the state before consensus would be useful in scenarios where you have only 2 nodes
* in a Raft cluster and one of them is down but you still want the RaftActor to apply a modification to the state.
- *
*/
public interface RaftPolicy {
/**
diff --git a/opendaylight/md-sal/sal-binding-api/pom.xml b/opendaylight/md-sal/sal-binding-api/pom.xml
index e8d6a45c1e..08141e8b58 100644
--- a/opendaylight/md-sal/sal-binding-api/pom.xml
+++ b/opendaylight/md-sal/sal-binding-api/pom.xml
@@ -42,26 +42,4 @@
, L extends
* Creates a client.
*
* @param address remote address
- * @param connectStrategy Reconnection strategy to be used when initial connection fails
+ * @param strategy Reconnection strategy to be used when initial connection fails
*
* @return Future representing the connection process. Its result represents the combined success of TCP connection
* as well as session negotiation.
@@ -266,7 +266,7 @@ public abstract class AbstractDispatcher, L extends
}
/**
- * @deprecated Should only be used with {@link AbstractDispatcher#AbstractDispatcher()}
+ * @deprecated Should only be used with AbstractDispatcher#AbstractDispatcher()
*/
@Deprecated
@Override
diff --git a/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/AbstractSessionNegotiator.java b/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/AbstractSessionNegotiator.java
index 8a19828c57..ddd10d2ce5 100644
--- a/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/AbstractSessionNegotiator.java
+++ b/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/AbstractSessionNegotiator.java
@@ -25,7 +25,7 @@ import com.google.common.base.Preconditions;
* needing to provide only
*
* @param Protocol session type, has to extend ProtocolSession Protocol session type, has to extend {@code ProtocolSession {
diff --git a/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java b/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java
index dfe0208c54..06b2730730 100644
--- a/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java
+++ b/opendaylight/commons/protocol-framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java
@@ -19,7 +19,7 @@ public interface SessionListener
*
*
- *
- * @RequireInterface(value = ThreadPoolServiceInterface.class, optional =
- * false)
+ * {@literal @}RequireInterface(value = ThreadPoolServiceInterface.class, optional = false)
void setThreadPool(ObjectName on);
- *
+ * void setThreadPool(ObjectName on);
+ *
*/
@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD)
diff --git a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/ConfigTransactionControllerMXBean.java b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/ConfigTransactionControllerMXBean.java
index e5123e2bee..b59bf2d736 100644
--- a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/ConfigTransactionControllerMXBean.java
+++ b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/ConfigTransactionControllerMXBean.java
@@ -11,7 +11,7 @@ import org.opendaylight.controller.config.api.ConfigTransactionController;
/**
* Those are executed by Jolokia clients on configuration transaction
- * represented by {@link ConfigMBeanServer} instance. Note: Reason for having
+ * represented by ConfigMBeanServer
instance. Note: Reason for having
* methods in super interface is that JMX allows only one MXBean to be
* implemented and implementations can expose additional methods to be exported.
* Implementation of {@link ConfigTransactionController} is not required to
diff --git a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/notifications/ConfigJMXNotification.java b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/notifications/ConfigJMXNotification.java
index 13efafb79d..2548711aa2 100644
--- a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/notifications/ConfigJMXNotification.java
+++ b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/api/jmx/notifications/ConfigJMXNotification.java
@@ -49,9 +49,6 @@ public abstract class ConfigJMXNotification extends Notification {
* Creates notification about successful commit execution.
*
* Intended for config-persister.
- *
- * @param transactionName
- * @param cfgSnapshot
*/
public static CommitJMXNotification afterCommit(NotificationBroadcasterSupport source, String messages) {
return new CommitJMXNotification(source, messages);
diff --git a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/spi/AbstractModule.java b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/spi/AbstractModule.java
index 7fcc0cc5c0..9f6a5512ca 100644
--- a/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/spi/AbstractModule.java
+++ b/opendaylight/config/config-api/src/main/java/org/opendaylight/controller/config/spi/AbstractModule.java
@@ -15,7 +15,7 @@ import org.slf4j.LoggerFactory;
/**
* Base implementation of Module. This implementation contains base logic for Module reconfiguration with associated fields.
- * @param isSame()
method
*/
public abstract class AbstractModule
@@ -67,27 +68,26 @@ import org.opendaylight.yangtools.concepts.Immutable;
*
- *
- *
+ *
+ *
*
*
- *
+ *
+ *
*
@@ -699,7 +700,8 @@ public abstract class AbstractLeader extends AbstractRaftActorBehavior {
/**
* Initiates a snapshot capture to install on a follower.
- *
+ *
+ *
*
*
* @param leadershipTransferCohort the cohort participating in the leadership transfer
diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/PreLeader.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/PreLeader.java
index 09f5186a01..bb54688437 100644
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/PreLeader.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/behaviors/PreLeader.java
@@ -22,7 +22,8 @@ import org.opendaylight.controller.cluster.raft.persisted.NoopPayload;
* the log with the leader's current term. Once the no-op entry is committed, all prior entries are committed
* indirectly. Once all entries are committed, ie commitIndex matches the last log index, it switches to the
* normal Leader state.
- *
+ *
+ *
*
*
@@ -107,14 +108,14 @@ public class Leader extends AbstractLeader {
*
*
+ *
* Lets assume we have following YANG model: * @@ -40,14 +40,14 @@ import org.opendaylight.yangtools.yang.binding.NotificationListener; * * * The generated interface will be: - *
+ * {@code * public interface ExampleListener extends NotificationListener { * void onStart(Start notification); * void onStop(Stop notification); * } - *+ * } * The following defines an implementation of the generated interface: - *
+ * {@code * public class MyExampleListener implements ExampleListener { * public void onStart(Start notification) { * // do something @@ -57,12 +57,12 @@ import org.opendaylight.yangtools.yang.binding.NotificationListener; * // do something * } * } - *+ * } * The implementation is registered as follows: - *
+ * {@code * MyExampleListener listener = new MyExampleListener(); * ListenerRegistration+ * } * Thereg = service.registerNotificationListener( listener ); - *
onStart
method will be invoked when someone publishes a Start
notification and
* the onStop
method will be invoked when someone publishes a Stop
notification.
*/
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/AbstractBrokerAwareActivator.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/AbstractBrokerAwareActivator.java
index bd78c584ee..9972ce7b8a 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/AbstractBrokerAwareActivator.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/AbstractBrokerAwareActivator.java
@@ -78,7 +78,7 @@ public abstract class AbstractBrokerAwareActivator implements BundleActivator {
/**
* Called when this bundle is started (before
- * {@link #onSessionInitiated(ProviderContext)} so the Framework can perform
+ * {@link BindingAwareProvider#onSessionInitiated(ProviderContext)} so the Framework can perform
* the bundle-specific activities necessary to start this bundle. This
* method can be used to register services or to allocate any resources that
* this bundle needs.
@@ -88,7 +88,7 @@ public abstract class AbstractBrokerAwareActivator implements BundleActivator {
*
* @param context
* The execution context of the bundle being started.
- * @throws Exception
+ * @throws RuntimeException
* If this method throws an exception, this bundle is marked as
* stopped and the Framework will remove this bundle's
* listeners, unregister all services registered by this bundle,
@@ -110,7 +110,7 @@ public abstract class AbstractBrokerAwareActivator implements BundleActivator {
* This method must complete and return to its caller in a timely manner.
*
* @param context The execution context of the bundle being stopped.
- * @throws Exception If this method throws an exception, the bundle is still
+ * @throws RuntimeException If this method throws an exception, the bundle is still
* marked as stopped, and the Framework will remove the bundle's
* listeners, unregister all services registered by the bundle, and
* release all services used by the bundle.
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareBroker.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareBroker.java
index 8ede7476b6..b934800d98 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareBroker.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareBroker.java
@@ -18,7 +18,7 @@ import org.osgi.framework.BundleContext;
* Binding-aware core of the SAL layer responsible for wiring the SAL consumers.
*
* The responsibility of the broker is to maintain registration of SAL
- * functionality {@link Consumer}s and {@link Provider}s, store provider and
+ * functionality Consumers and Providers, store provider and
* consumer specific context and functionality registration via
* {@link ConsumerContext} and provide access to infrastructure services, which
* removes direct dependencies between providers and consumers.
@@ -68,9 +68,9 @@ public interface BindingAwareBroker {
* The consumer is required to use returned session for all communication
* with broker or one of the broker services. The session is announced to
* the consumer by invoking
- * {@link Consumer#onSessionInitiated(ConsumerContext)}.
+ * {@link BindingAwareConsumer#onSessionInitialized(ConsumerContext)}.
*
- * @param cons
+ * @param consumer
* Consumer to be registered.
* @return a session specific to consumer registration
* @throws IllegalArgumentException
@@ -92,7 +92,7 @@ public interface BindingAwareBroker {
* * During the registration, the broker obtains the initial functionality * from consumer, using the - * {@link BindingAwareProvider#getImplementations()}, and register that + * BindingAwareProvider#getImplementations(), and register that * functionality into system and concrete infrastructure services. * *
@@ -106,7 +106,7 @@ public interface BindingAwareBroker {
* {@link BindingAwareProvider#onSessionInitiated(ProviderContext)}.
*
*
- * @param prov
+ * @param provider
* Provider to be registered.
* @return a session unique to the provider registration.
* @throws IllegalArgumentException
@@ -127,7 +127,7 @@ public interface BindingAwareBroker {
* The session serves to store SAL context (e.g. registration of
* functionality) for the consumer and provides access to the SAL
* infrastructure services and other functionality provided by
- * {@link Provider}s.
+ * {@link BindingAwareProvider}s.
*/
interface ConsumerContext extends RpcConsumerRegistry {
@@ -192,7 +192,7 @@ public interface BindingAwareBroker {
* Register particular instance identifier to be processed by this
* RpcService
*
- * Deprecated in favor of {@link RoutedRegistration#registerPath(Object, Object)}.
+ * Deprecated in favor of RoutedRegistration#registerPath(Object, Object).
*
* @param context
* @param instance
@@ -204,7 +204,7 @@ public interface BindingAwareBroker {
* Unregister particular instance identifier to be processed by this
* RpcService
*
- * Deprecated in favor of {@link RoutedRegistration#unregisterPath(Object, Object)}.
+ * Deprecated in favor of RoutedRegistration#unregisterPath(Class, InstanceIdentifier).
*
* @param context
* @param instance
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareConsumer.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareConsumer.java
index bcbd6879d0..b3b3e07b5e 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareConsumer.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareConsumer.java
@@ -64,9 +64,6 @@ import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.ConsumerCo
* DataBroker databroker = session.getSALService(BindingDataBroker.class);
* }
* }
-* @see org.opendaylight.controller.md.sal.common.api.data.BindingDataBroker
-* for more info on using the DataBroker.
-*
*/
public interface BindingAwareConsumer {
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareProvider.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareProvider.java
index 35583c0d42..808863262d 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareProvider.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/BindingAwareProvider.java
@@ -45,27 +45,28 @@ import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.ProviderCo
*
* To get a NotificationService:
*
- * {code
+ * {@code
* public void onSessionInitiated(ProviderContext session) {
* NotificationProviderService notificationService = session.getSALService(NotificationProviderService.class);
* }
+ * }
* For more information on sending notifications via the NotificationProviderService
* @see org.opendaylight.controller.sal.binding.api.NotificationProviderService
*
* To register an RPC implementation:
*
- * {code
+ * {@code
* public void onSessionInitiated(ProviderContext session) {
* RpcRegistration
- *
* Where MyService.class is a Service interface generated from a yang model with RPCs modeled in it and myImplementationInstance
* is an instance of a class that implements MyService.
*
* To register a Routed RPC Implementation:
- * {code
+ * {@code
* public void onSessionInitiated(ProviderContext session) {
* RoutedRpcRegistration
* The line:
- * {code
+ * {@code
* flowRegistration.registerPath(NodeContext.class, nodeInstanceId);
* }
* Is indicating that the RPC implementation is registered to handle RPC invocations that have their NodeContext pointing to the node with instance id nodeInstanceId.
@@ -92,14 +93,11 @@ import org.opendaylight.controller.sal.binding.api.BindingAwareBroker.ProviderCo
*
* To get a DataBroker to allow access to the data tree:
*
- * {code
+ * {@code
* public void onSessionInitiated(final ProviderContext session) {
* DataBroker databroker = session.getSALService(BindingDataBroker.class);
* }
* }
- * @see org.opendaylight.controller.md.sal.common.api.data.BindingDataBroker
- * for more info on using the DataBroker.
- *
*/
public interface BindingAwareProvider {
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/NotificationService.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/NotificationService.java
index dd66aa67f8..015988e3d9 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/NotificationService.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/NotificationService.java
@@ -20,6 +20,7 @@ import org.opendaylight.yangtools.yang.binding.Notification;
*
@@ -47,11 +48,11 @@ import org.opendaylight.yangtools.yang.binding.Notification;
* are registered using {@link #registerNotificationListener(org.opendaylight.yangtools.yang.binding.NotificationListener)}
* method.
*
- *
* Lets assume we have following YANG model:
*
- *
- *
* The following snippet declares a simple YANG
* We then use the declared identity to define a context type by using it in combination
* with the
* The statement
- * The {@link Consumer} could initiate a commit of candidate data
+ * The Consumer could initiate a commit of candidate data
*
*
* The successful commit changes the state of the system and may affect
@@ -49,15 +45,11 @@ public interface DataModificationTransaction extends
*
*
* The effects of successful commit of data are described in the
- * specifications and YANG models describing the {@link Provider} components
- * of controller. It is assumed that {@link Consumer} has an understanding
+ * specifications and YANG models describing the Provider components
+ * of controller. It is assumed that the Consumer has an understanding
* of this changes.
*
*
- * @see org.opendaylight.controller.md.sal.common.api.data.DataCommitHandler for further information how two-phase commit is
- * processed.
- * @param store
- * Identifier of the store, where commit should occur.
* @return Result of the commit, containing success information or list of
* encountered errors, if commit was not successful.
*/
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/SynchronizedTransaction.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/SynchronizedTransaction.java
index fc0d3964ea..cc3ee4b26f 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/SynchronizedTransaction.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/SynchronizedTransaction.java
@@ -26,10 +26,10 @@ import com.google.common.base.Preconditions;
* To get instance of synchronized wrapper use {@link #from(DataModificationTransaction)}
*
* @deprecated Replaced by more specific transaction types. Please use
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadOnlyTransaction(),
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadWriteTransaction()
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadOnlyTransaction()},
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadWriteTransaction()}
* or
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newWriteOnlyTransaction().
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newWriteOnlyTransaction()}.
*
*/
@Deprecated
diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MessageTracker.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MessageTracker.java
index 326430922c..65cef56a2b 100644
--- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MessageTracker.java
+++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MessageTracker.java
@@ -29,7 +29,7 @@ import org.slf4j.LoggerFactory;
* expected to arrive in a given time interval does not arrive. It attempts to keep track of all the messages that
* received between the arrival of two instances of the same message and the amount of time it took to process each
* of those messages.
- *
* This behaviour meters actor's default behaviour. It captures 2 metrics:
* , D, L extends AsyncDataChange
*
*
*
- * @see http://www.idevelopment.info/data/LDAP/LDAP_Resources/
- * SEARCH_Setting_the_SCOPE_Parameter.shtml
+ * @see LDAP
*/
enum DataChangeScope {
diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataChangeListener.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataChangeListener.java
index 53194b372b..a7a9fef07f 100644
--- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataChangeListener.java
+++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataChangeListener.java
@@ -43,8 +43,10 @@ public interface AsyncDataChangeListener , D> extends EventList
*
*
* Note: This method may be invoked from a shared thread pool.
+ * , D> extends AsyncTransaction {
diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java
index e47b54a0a1..cc22bb91ad 100644
--- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java
+++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncWriteTransaction.java
@@ -132,8 +132,6 @@ public interface AsyncWriteTransaction , D> extends AsyncTransa
*
* This call logically seals the transaction, which prevents the client from
* further changing data tree using this transaction. Any subsequent calls to
- * {@link #put(LogicalDatastoreType, Path, Object)},
- * {@link #merge(LogicalDatastoreType, Path, Object)} or
* {@link #delete(LogicalDatastoreType, Path)} will fail with
* {@link IllegalStateException}.
*
@@ -149,24 +147,24 @@ public interface AsyncWriteTransaction , D> extends AsyncTransa
* The effects of a successful commit of data depends on data change listeners
* ({@link AsyncDataChangeListener}) and commit participants
* ({@link AsyncConfigurationCommitHandler}) that are registered with the data broker.
- *
+ *
* , D> extends AsyncTransa
* which are based on same initial state, Tx 1 completes successfully
* before Tx 2 is submitted.
*
- * , D> extends AsyncTransa
* which are based on same initial state, Tx 1 completes successfully
* before Tx 2 is submitted.
*
- * , D> extends DataChange
* controller. It is assumed that Consumer has an understanding of this
* changes.
*
- *
- * @see DataCommitHandler for further information how two-phase commit is
- * processed.
- * @param store
- * Identifier of the store, where commit should occur.
* @return Result of the Commit, containing success information or list of
* encountered errors, if commit was not successful. The Future
* blocks until {@link TransactionStatus#COMMITED} or
diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/TransactionChain.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/TransactionChain.java
index 11f28039be..12d9da696e 100644
--- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/TransactionChain.java
+++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/TransactionChain.java
@@ -26,7 +26,7 @@ import org.opendaylight.yangtools.concepts.Path;
* t1.submit();
*
* AsyncReadTransaction t2 = broker.newReadOnlyTransaction();
- * Optional> maybeData = t2.read(id).get();
+ * Optional<?> maybeData = t2.read(id).get();
*
* it may happen, that it sees maybeData.isPresent() == false, simply because
* t1 has not completed the processes of being applied and t2 is actually
diff --git a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerMXBean.java b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerMXBean.java
index 9646adc773..dd89e00678 100644
--- a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerMXBean.java
+++ b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/md/sal/common/util/jmx/QueuedNotificationManagerMXBean.java
@@ -13,7 +13,7 @@ import java.util.List;
import org.opendaylight.yangtools.util.concurrent.ListenerNotificationQueueStats;
/**
- * MXBean interface for {@link QueuedNotificationManager} statistic metrics.
+ * MXBean interface for {@link org.opendaylight.yangtools.util.concurrent.QueuedNotificationManager} statistic metrics.
*
* @author Thomas Pantelis
*/
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java
index e1f2777373..cee7344577 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/DataChangeListener.java
@@ -25,7 +25,7 @@ import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
/**
* Actor for a DataChangeListener.
*
- * @Deprecated Replaced by {@link DataTreeChangeListener}
+ * @deprecated Replaced by {@link DataTreeChangeListener}
*/
@Deprecated
public class DataChangeListener extends AbstractUntypedActor {
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java
index 4a1be9862b..26f18bd932 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java
@@ -93,7 +93,8 @@ import scala.concurrent.duration.FiniteDuration;
/**
* A Shard represents a portion of the logical data tree.
- *
* Our Shard uses InMemoryDataTree as it's internal representation and delegates all requests it
*/
public class Shard extends RaftActor {
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java
index ef6436ae8d..f18271ae36 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java
@@ -77,7 +77,8 @@ import scala.concurrent.duration.Duration;
* Internal shard state, similar to a DOMStore, but optimized for use in the actor system,
* e.g. it does not expose public interfaces and assumes it is only ever called from a
* single thread.
- *
* This class is not part of the API contract and is subject to change at any time.
*/
@NotThreadSafe
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContext.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContext.java
index 1e23120f0b..b62b056d58 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContext.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionContext.java
@@ -32,7 +32,8 @@ interface TransactionContext {
* Invoked by {@link TransactionContextWrapper} when it has finished handing
* off operations to this context. From this point on, the context is responsible
* for throttling operations.
- *
* Implementations can rely on the wrapper calling this operation in a synchronized
* block, so they do not need to ensure visibility of this state transition themselves.
*/
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionReadyReplyMapper.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionReadyReplyMapper.java
index 986cca5f3d..d1774980bf 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionReadyReplyMapper.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/TransactionReadyReplyMapper.java
@@ -20,7 +20,8 @@ import scala.concurrent.Future;
/**
* A {@link Mapper} extracting the {@link ActorSelection} pointing to the actor which
* is backing a particular transaction.
- *
* This class is not for general consumption. It is public only to support the pre-lithium compatibility
* package.
* TODO: once we remove compatibility, make this class package-private and final.
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/DataTreeChanged.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/DataTreeChanged.java
index 919f9448a9..ff2c89c8dd 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/DataTreeChanged.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/DataTreeChanged.java
@@ -14,8 +14,8 @@ import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate;
/**
* A message about a DataTree having been changed. The message is not
* serializable on purpose. For delegating the change across cluster nodes,
- * this needs to be intercepted by a local agent and forwarded as
- * a {@link DataTreeDelta}.
+ * this needs to be intercepted by a local agent and forwarded as reconstructed
+ * candidate.
*/
public final class DataTreeChanged {
private final Collection
* Simple modifications can be of type,
+ *
* Modifications can in turn be lumped into a single
* {@link org.opendaylight.controller.cluster.datastore.modification.CompositeModification}
* which can then be applied to a write transaction.
- *
* This version effectively defines the protocol version between actors participating on a particular shard. A shard
* participant instance should oppose RAFT candidates which produce persistence of an unsupported version. If a follower
* encounters an unsupported version it must not become fully-operational, as it does not have an accurate view
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardDataTreeSnapshotMetadata.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardDataTreeSnapshotMetadata.java
index 25cfda0177..0ddc785a90 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardDataTreeSnapshotMetadata.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardDataTreeSnapshotMetadata.java
@@ -17,11 +17,13 @@ import javax.annotation.Nonnull;
* an interface because we want to make sure all subclasses implement the externalizable proxy pattern, for which
* we need to force {@link #writeReplace()} to be abstract. We do that by making it final and exposing a protected
* {@link #externalizableProxy()} method.
- *
* All concrete subclasses of this class should be final so as to form a distinct set of possible metadata. Since
* metadata is serialized along with {@link MetadataShardDataTreeSnapshot}, this set is part of the serialization format
* guarded by {@link PayloadVersion}.
- *
* If a new metadata type is introduced or a type is removed, {@link PayloadVersion} needs to be bumped to ensure
* compatibility.
*
diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategy.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategy.java
index 0440b7f023..496069d0a1 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategy.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategy.java
@@ -16,7 +16,8 @@ import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
public interface ShardStrategy {
/**
* Find the name of the shard in which the data pointed to by the specified path belongs in.
- *
* Should return the name of the default shard DefaultShardStrategy.DEFAULT_SHARD
* if no matching shard was found
*
diff --git a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataTreeListener.java b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataTreeListener.java
index 083cd10ef3..7392b15345 100644
--- a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataTreeListener.java
+++ b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/md/sal/dom/api/DOMDataTreeListener.java
@@ -36,7 +36,7 @@ public interface DOMDataTreeListener extends EventListener {
* a connection to external subtree source is broken. The listener will not receive any other
* callbacks, but its registration still needs to be closed to prevent resource leak.
*
- * @param cause Collection of failure causes, may not be null or empty.
+ * @param causes Collection of failure causes, may not be null or empty.
*/
void onDataTreeFailed(@Nonnull Collection
* This exception indicates that given notification can not be processed by corresponding mechanism.
* More info can be provided in message.
- *
* Expected use: {@link DOMNotificationPublishService}
- *
* It uses {@link org.opendaylight.controller.remote.rpc.registry.gossip.BucketStore} to maintain this
* cluster wide information.
*/
diff --git a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/registry/gossip/Gossiper.java b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/registry/gossip/Gossiper.java
index 9230591d46..439c131e3f 100644
--- a/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/registry/gossip/Gossiper.java
+++ b/opendaylight/md-sal/sal-remoterpc-connector/src/main/java/org/opendaylight/controller/remote/rpc/registry/gossip/Gossiper.java
@@ -44,19 +44,21 @@ import scala.concurrent.duration.FiniteDuration;
/**
* Gossiper that syncs bucket store across nodes in the cluster.
- *
* It keeps a local scheduler that periodically sends Gossip ticks to
* itself to send bucket store's bucket versions to a randomly selected remote
* gossiper.
- *
* When bucket versions are received from a remote gossiper, it is compared
* with bucket store's bucket versions. Which ever buckets are newer
* locally, are sent to remote gossiper. If any bucket is older in bucket store,
* a gossip status is sent to remote gossiper so that it can send the newer buckets.
- *
* When a bucket is received from a remote gossiper, its sent to the bucket store
* for update.
- *
*/
public class Gossiper extends AbstractUntypedActorWithMetering {
diff --git a/pom.xml b/pom.xml
index 26c99151e2..58d1fd0923 100644
--- a/pom.xml
+++ b/pom.xml
@@ -46,26 +46,4 @@
{ModelName}Listener
interface,
* which has dispatch methods for each defined notification. Methods are invoked based on notification type (class).
* Generic Listener
* Dispatch Listener Example
+ * Dispatch Listener Example
*
+ * {@code
* module example {
* ...
*
@@ -63,17 +64,17 @@ import org.opendaylight.yangtools.yang.binding.Notification;
* ...
* }
* }
- *
+ * }
*
* The generated interface will be:
- *
+ * {@code
* public interface ExampleListener extends NotificationListener {
* void onStart(Start notification);
* void onStop(Stop notification);
* }
- *
+ * }
* The following defines an implementation of the generated interface:
- *
+ * {@code
* public class MyExampleListener implements ExampleListener {
* public void onStart(Start notification) {
* // do something
@@ -83,12 +84,12 @@ import org.opendaylight.yangtools.yang.binding.Notification;
* // do something
* }
* }
- *
+ * }
* The implementation is registered as follows:
- *
+ * {@code
* MyExampleListener listener = new MyExampleListener();
* ListenerRegistration
+ * }
* The onStart
method will be invoked when someone publishes a Start
notification and
* the onStop
method will be invoked when someone publishes a Stop
notification.
*
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java
index 0c5e7649f8..d31a2fe327 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcConsumerRegistry.java
@@ -49,7 +49,7 @@ public interface RpcConsumerRegistry extends BindingAwareService, BindingService
* to listen for Rpc Result. This will asynchronously listen for future result in executor and
* will not block current thread.
*
- *
+ * {@code
* final Future
+ * }
+ * }
+ *
* @param serviceInterface the interface of the RPC Service. Typically this is an interface generated
* from a YANG model.
* @return the proxy for the requested RPC service. This method never returns null.
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcProviderRegistry.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcProviderRegistry.java
index 22db985ba9..759dbe01a7 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcProviderRegistry.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/RpcProviderRegistry.java
@@ -68,11 +68,11 @@ import org.opendaylight.yangtools.yang.binding.RpcService;
*
* Routed RPC example
* 1. Defining a Context Type
+ * 1. Defining a Context Type
* identity
named example-context
:
*
- *
+ * {@code
* module example {
* ...
* identity example-context {
@@ -80,7 +80,7 @@ import org.opendaylight.yangtools.yang.binding.RpcService;
* }
* ...
* }
- *
+ * }
* context-instance
YANG extension. We'll associate the context type
@@ -90,7 +90,7 @@ import org.opendaylight.yangtools.yang.binding.RpcService;
* The following YANG snippet imports the yang-ext
module and defines the list
* element named item
inside a container named foo
:
*
- *
+ * {@code
* module foo {
* ...
* import yang-ext {prefix ext;}
@@ -104,7 +104,7 @@ import org.opendaylight.yangtools.yang.binding.RpcService;
* }
* ...
* }
- *
+ * }
* ext:context-instance "example-context";
inside the list element
* declares that any instance identifier referencing item
in the data
@@ -257,7 +257,7 @@ public interface RpcProviderRegistry extends //
* @param serviceInterface the YANG-generated interface of the RPC Service for which to register.
* @param implementation the implementation instance to register.
* @return a RoutedRpcRegistration instance which can be used to register paths for the RPC
- * implementation via invoking {@link RoutedRpcRegistration#registerPath(....).
+ * implementation via invoking RoutedRpcRegistration#registerPath(Class, InstanceIdentifer).
* {@link RoutedRpcRegistration#close()} should be called to unregister the implementation
* and all previously registered paths when no longer needed.
*
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataBrokerService.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataBrokerService.java
index d1f9d3eafe..47855da301 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataBrokerService.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataBrokerService.java
@@ -29,10 +29,10 @@ public interface DataBrokerService extends BindingAwareService,
*
* @return new blank data modification transaction.
* @deprecated Replaced by more specific transaction types. Please use
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadOnlyTransaction(),
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadWriteTransaction()
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadOnlyTransaction()},
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadWriteTransaction()}
* or
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newWriteOnlyTransaction().
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newWriteOnlyTransaction()}.
*/
@Deprecated
DataModificationTransaction beginTransaction();
diff --git a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataModificationTransaction.java b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataModificationTransaction.java
index b769812f2b..7e72bd488f 100644
--- a/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataModificationTransaction.java
+++ b/opendaylight/md-sal/sal-binding-api/src/main/java/org/opendaylight/controller/sal/binding/api/data/DataModificationTransaction.java
@@ -17,15 +17,11 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
import org.opendaylight.yangtools.yang.common.RpcResult;
/**
- *
- *
* @deprecated Replaced by more specific transaction types. Please use
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadOnlyTransaction(),
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadWriteTransaction()
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadOnlyTransaction()},
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newReadWriteTransaction()}
* or
- * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newWriteOnlyTransaction().
- *
- *
+ * {@link org.opendaylight.controller.md.sal.binding.api.DataBroker#newWriteOnlyTransaction()}.
*/
@Deprecated
public interface DataModificationTransaction extends
@@ -41,7 +37,7 @@ public interface DataModificationTransaction extends
* Initiates a two-phase commit of candidate data.
*
*
+ *
* Usage of the API is as follows,
*
*
diff --git a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java
index 5e631b90d3..523417ec76 100644
--- a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java
+++ b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/common/actor/MeteringBehavior.java
@@ -17,7 +17,8 @@ import org.opendaylight.controller.cluster.reporting.MetricsReporter;
/**
* Represents behaviour that can be exhibited by actors of type {@link akka.actor.UntypedActor}
- *
+ *
+ *
*
*
+ *
* @param request
* Commit Request submitted by client, which contains
* information about modifications and read-only view as
diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataBroker.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataBroker.java
index 8265fc4057..2af9f055f9 100644
--- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataBroker.java
+++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncDataBroker.java
@@ -97,8 +97,7 @@ public interface AsyncDataBroker
*
* scenarios.
*
*
diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncReadTransaction.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncReadTransaction.java
index afa86704ff..053d6346a4 100644
--- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncReadTransaction.java
+++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/AsyncReadTransaction.java
@@ -55,9 +55,6 @@ import org.opendaylight.yangtools.concepts.Path;
* tree
* @param Example usage:
*
* private void doWrite( final int tries ) {
* WriteTransaction writeTx = dataBroker.newWriteOnlyTransaction();
*
* MyDataObject data = ...;
- * InstanceIdentifier
+ *
*
* Initial state Tx 1 Tx 2 Result
* Empty put(A,1) put(A,2) Tx 2 will fail, state is A=1
@@ -238,7 +236,7 @@ public interface AsyncWriteTransactionEmpty put(A,1) merge(A,2) A=2
+ *
*
*
* Initial state Tx 1 Tx 2 Result
diff --git a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataModification.java b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataModification.java
index f90098c959..5356c56d8a 100644
--- a/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataModification.java
+++ b/opendaylight/md-sal/sal-common-api/src/main/java/org/opendaylight/controller/md/sal/common/api/data/DataModification.java
@@ -85,11 +85,6 @@ public interface DataModificationEmpty put(TOP,[]) put(TOP,[]) Tx 2 will fail, state is TOP=[]
*
+ *
+ *
+ *
- *
*
diff --git a/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/AbstractDOMStoreTransaction.java b/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/AbstractDOMStoreTransaction.java
index 106abca3ec..fba643d8f9 100644
--- a/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/AbstractDOMStoreTransaction.java
+++ b/opendaylight/md-sal/sal-dom-spi/src/main/java/org/opendaylight/controller/sal/core/spi/data/AbstractDOMStoreTransaction.java
@@ -22,7 +22,7 @@ import javax.annotation.Nullable;
*
* It can optionally capture the context where it was allocated.
*
- *
*
* Id of returned transaction is generated via
@@ -166,30 +167,30 @@ abstract class AbstractDOMForwardedTransactionFactory