From 7ad6a27e9b98861d9286977320198375a44a38f1 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Wed, 20 Feb 2019 11:46:03 +0100 Subject: [PATCH] Cleanup java.util.Optional references As a byproduct of gradual migration, we have a few places where we use FQCN to reference java.util.Optional eventhough it is among imports. Fix that. Change-Id: Ibede76ffc614c02dbc5e29e78e6c421abcd81ec9 Signed-off-by: Robert Varga --- .../dsbenchmark/simpletx/SimpletxDomRead.java | 2 +- .../actors/dds/AbstractProxyTransaction.java | 6 +++--- .../databroker/actors/dds/RemoteProxyTransaction.java | 10 +++++----- .../cluster/datastore/FrontendReadOnlyTransaction.java | 2 +- .../datastore/FrontendReadWriteTransaction.java | 9 ++++----- .../cluster/datastore/FrontendTransaction.java | 6 +++--- .../controller/cluster/datastore/TransactionProxy.java | 3 +-- .../DistributedEntityOwnershipService.java | 7 +++---- .../databroker/actors/dds/ClientSnapshotTest.java | 2 +- .../databroker/actors/dds/ClientTransactionTest.java | 2 +- .../DistributedDataStoreRemotingIntegrationTest.java | 9 ++++----- .../cluster/datastore/TransactionProxyTest.java | 3 +-- .../sharding/DistributedShardedDOMDataTreeTest.java | 2 +- 13 files changed, 29 insertions(+), 34 deletions(-) diff --git a/benchmark/dsbenchmark/src/main/java/org/opendaylight/dsbenchmark/simpletx/SimpletxDomRead.java b/benchmark/dsbenchmark/src/main/java/org/opendaylight/dsbenchmark/simpletx/SimpletxDomRead.java index 0800585a4e..30812898c5 100644 --- a/benchmark/dsbenchmark/src/main/java/org/opendaylight/dsbenchmark/simpletx/SimpletxDomRead.java +++ b/benchmark/dsbenchmark/src/main/java/org/opendaylight/dsbenchmark/simpletx/SimpletxDomRead.java @@ -62,7 +62,7 @@ public class SimpletxDomRead extends DatastoreAbstractWriter { try (DOMDataTreeReadTransaction tx = domDataBroker.newReadOnlyTransaction()) { for (int l = 0; l < outerListElem; l++) { YangInstanceIdentifier yid = pid.node(new NodeIdentifierWithPredicates(OuterList.QNAME, olId, l)); - FluentFuture>> submitFuture = tx.read(dsType, yid); + FluentFuture>> submitFuture = tx.read(dsType, yid); try { Optional> optionalDataObject = submitFuture.get(); if (optionalDataObject != null && optionalDataObject.isPresent()) { diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/AbstractProxyTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/AbstractProxyTransaction.java index dab0c9fe27..f8cb9e01bc 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/AbstractProxyTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/AbstractProxyTransaction.java @@ -350,7 +350,7 @@ abstract class AbstractProxyTransaction implements Identifiable optState = flushState(); + final Optional optState = flushState(); if (optState.isPresent()) { forwardToSuccessor(successor, optState.get(), null); } @@ -722,7 +722,7 @@ abstract class AbstractProxyTransaction implements Identifiable optState = flushState(); + final Optional optState = flushState(); if (optState.isPresent()) { successor.handleReplayedRemoteRequest(optState.get(), null, enqueuedTicks); } @@ -801,7 +801,7 @@ abstract class AbstractProxyTransaction implements Identifiable>> doRead(YangInstanceIdentifier path); @GuardedBy("this") - abstract java.util.Optional flushState(); + abstract Optional flushState(); abstract TransactionRequest abortRequest(); diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/RemoteProxyTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/RemoteProxyTransaction.java index 284be4a457..46e1924dd5 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/RemoteProxyTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/databroker/actors/dds/RemoteProxyTransaction.java @@ -284,14 +284,14 @@ final class RemoteProxyTransaction extends AbstractProxyTransaction { } @Override - java.util.Optional flushState() { + Optional flushState() { if (!builderBusy) { - return java.util.Optional.empty(); + return Optional.empty(); } final ModifyTransactionRequest request = builder.build(); builderBusy = false; - return java.util.Optional.of(request); + return Optional.of(request); } @Override @@ -342,7 +342,7 @@ final class RemoteProxyTransaction extends AbstractProxyTransaction { final ModifyTransactionRequest req) { req.getModifications().forEach(this::appendModification); - final java.util.Optional maybeProto = req.getPersistenceProtocol(); + final Optional maybeProto = req.getPersistenceProtocol(); if (maybeProto.isPresent()) { // Persistence protocol implies we are sealed, propagate the marker, but hold off doing other actions // until we know what we are going to do. @@ -483,7 +483,7 @@ final class RemoteProxyTransaction extends AbstractProxyTransaction { final ModifyTransactionRequest req) { req.getModifications().forEach(this::appendModification); - final java.util.Optional maybeProto = req.getPersistenceProtocol(); + final Optional maybeProto = req.getPersistenceProtocol(); if (maybeProto.isPresent()) { // Persistence protocol implies we are sealed, propagate the marker, but hold off doing other actions // until we know what we are going to do. diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadOnlyTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadOnlyTransaction.java index 81400a2f04..daba580906 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadOnlyTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadOnlyTransaction.java @@ -74,7 +74,7 @@ final class FrontendReadOnlyTransaction extends FrontendTransaction { private void handleModifyTransaction(final ModifyTransactionRequest request, final RequestEnvelope envelope, final long now) { // The only valid request here is with abort protocol - final java.util.Optional optProto = request.getPersistenceProtocol(); + final Optional optProto = request.getPersistenceProtocol(); Preconditions.checkArgument(optProto.isPresent(), "Commit protocol is missing in %s", request); Preconditions.checkArgument(optProto.get() == PersistenceProtocol.ABORT, "Unsupported commit protocol in %s", request); diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java index e2ae16f097..28ab70a351 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendReadWriteTransaction.java @@ -509,12 +509,11 @@ final class FrontendReadWriteTransaction extends FrontendTransaction { throw new UnsupportedRequestException(request); } - final java.util.Optional optFailure = request.getDelayedFailure(); + final Optional optFailure = request.getDelayedFailure(); if (optFailure.isPresent()) { state = new Ready(history().createFailedCohort(getIdentifier(), sealedModification, optFailure.get())); } else { - state = new Ready(history().createReadyCohort(getIdentifier(), sealedModification, - java.util.Optional.empty())); + state = new Ready(history().createReadyCohort(getIdentifier(), sealedModification, Optional.empty())); } if (request.isCoordinated()) { @@ -562,7 +561,7 @@ final class FrontendReadWriteTransaction extends FrontendTransaction { final RequestEnvelope envelope, final long now) throws RequestException { // We need to examine the persistence protocol first to see if this is an idempotent request. If there is no // protocol, there is nothing for us to do. - final java.util.Optional maybeProto = request.getPersistenceProtocol(); + final Optional maybeProto = request.getPersistenceProtocol(); if (!maybeProto.isPresent()) { applyModifications(request.getModifications()); return replyModifySuccess(request.getSequence()); @@ -608,7 +607,7 @@ final class FrontendReadWriteTransaction extends FrontendTransaction { } applyModifications(modifications); - state = new Ready(checkOpen().ready(java.util.Optional.empty())); + state = new Ready(checkOpen().ready(Optional.empty())); LOG.debug("{}: transitioned {} to ready", persistenceId(), getIdentifier()); } diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendTransaction.java index b25e5da42a..25cb174ea6 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendTransaction.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/FrontendTransaction.java @@ -70,10 +70,10 @@ abstract class FrontendTransaction implements Identifiable> replaySequence(final long sequence) throws RequestException { + final Optional> replaySequence(final long sequence) throws RequestException { // Fast path check: if the requested sequence is the next request, bail early if (expectedSequence == sequence) { - return java.util.Optional.empty(); + return Optional.empty(); } // Check sequencing: we do not need to bother with future requests @@ -109,7 +109,7 @@ abstract class FrontendTransaction implements Identifiable createMultiCommitCohort() { final List cohorts = new ArrayList<>(txContextWrappers.size()); - final java.util.Optional> shardNames = - java.util.Optional.of(new TreeSet<>(txContextWrappers.keySet())); + final Optional> shardNames = Optional.of(new TreeSet<>(txContextWrappers.keySet())); for (Entry e : txContextWrappers.entrySet()) { LOG.debug("Tx {} Readying transaction for shard {}", getIdentifier(), e.getKey()); diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipService.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipService.java index 95b01fb48b..10988a05ad 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipService.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/entityownership/DistributedEntityOwnershipService.java @@ -187,7 +187,7 @@ public class DistributedEntityOwnershipService implements DOMEntityOwnershipServ return Optional.empty(); } - java.util.Optional> entityNode = dataTree.takeSnapshot().readNode( + Optional> entityNode = dataTree.takeSnapshot().readNode( entityPath(forEntity.getType(), forEntity.getIdentifier())); if (!entityNode.isPresent()) { return Optional.empty(); @@ -195,7 +195,7 @@ public class DistributedEntityOwnershipService implements DOMEntityOwnershipServ // Check if there are any candidates, if there are none we do not really have ownership state final MapEntryNode entity = (MapEntryNode) entityNode.get(); - final java.util.Optional> optionalCandidates = + final Optional> optionalCandidates = entity.getChild(CANDIDATE_NODE_ID); final boolean hasCandidates = optionalCandidates.isPresent() && ((MapNode) optionalCandidates.get()).getValue().size() > 0; @@ -204,8 +204,7 @@ public class DistributedEntityOwnershipService implements DOMEntityOwnershipServ } MemberName localMemberName = context.getCurrentMemberName(); - java.util.Optional> ownerLeaf = entity.getChild( - ENTITY_OWNER_NODE_ID); + Optional> ownerLeaf = entity.getChild(ENTITY_OWNER_NODE_ID); String owner = ownerLeaf.isPresent() ? ownerLeaf.get().getValue().toString() : null; boolean hasOwner = !Strings.isNullOrEmpty(owner); boolean isOwner = hasOwner && localMemberName.getName().equals(owner); diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientSnapshotTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientSnapshotTest.java index 6ccd091b4f..8e5d5650f8 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientSnapshotTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientSnapshotTest.java @@ -28,7 +28,7 @@ public class ClientSnapshotTest extends AbstractClientHandleTest @Override public void setUp() throws Exception { super.setUp(); - when(getDataTreeSnapshot().readNode(PATH)).thenReturn(java.util.Optional.empty()); + when(getDataTreeSnapshot().readNode(PATH)).thenReturn(Optional.empty()); } @Override diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientTransactionTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientTransactionTest.java index a801b9c865..bb8fbf15e6 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientTransactionTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/databroker/actors/dds/ClientTransactionTest.java @@ -49,7 +49,7 @@ public class ClientTransactionTest extends AbstractClientHandleTest> capturedValue = captorForChanges.getAllValues(); - final java.util.Optional> dataAfter = + final Optional> dataAfter = capturedValue.get(0).iterator().next().getRootNode().getDataAfter(); final NormalizedNode expected = ImmutableContainerNodeBuilder.create() -- 2.36.6